Re: [PATCH 5/8] net: dwc_eth_qos: add dwc eqos for imx support

2021-05-04 Thread Daniil Stas
Hi, i think there are some issues with this patch. > @@ -1131,6 +1205,7 @@ static int eqos_start(struct udevice *dev) > } > > /* Configure MTL */ > + writel(0x60, &eqos->mtl_regs->txq0_quantum_weight - 0x100); > > /* Enable Store and Forward mode for TX */ > /* Prog

[PATCH] net: dwc_eth_qos: Fix needless phy auto-negotiation restarts

2021-05-23 Thread Daniil Stas
x27;t disable clk_ck clock after it was enabled. Signed-off-by: Daniil Stas Cc: Ramon Fried Cc: Joe Hershberger Cc: Patrick Delaunay Cc: Patrice Chotard --- drivers/net/dwc_eth_qos.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dwc_eth_qos.c b/driver

[PATCH] spi: stm32_qspi: Fix short data write operation

2021-05-23 Thread Daniil Stas
TCF flag only means that all data was sent to FIFO. To check if the data was sent out of FIFO we should also wait for the BUSY flag to be cleared. Otherwise there is a race condition which can lead to inability to write short (one byte long) data. Signed-off-by: Daniil Stas Cc: Patrick Delaunay

Re: [PATCH] spi: stm32_qspi: Fix short data write operation

2021-05-24 Thread Daniil Stas
On Mon, 24 May 2021 09:40:05 +0200 Patrice CHOTARD wrote: > Hi Daniil > > On 5/24/21 12:24 AM, Daniil Stas wrote: > > TCF flag only means that all data was sent to FIFO. To check if the > > data was sent out of FIFO we should also wait for the BUSY flag to > > be cl

[PATCH] net: dwc_eth_qos: Revert some changes of commit 3a97da12ee7b

2021-05-30 Thread Daniil Stas
forms. And another makes some writes at unknown memory location. Fixes: 3a97da12ee7b ("net: dwc_eth_qos: add dwc eqos for imx support") Signed-off-by: Daniil Stas Cc: Ye Li Cc: Fugang Duan Cc: Peng Fan Cc: Ramon Fried Cc: Joe Hershberger Cc: Patrice Chotard Cc: Patrick Delaun