Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2010-08-31 Thread Cyril Chemparathy
Hi Ben, [...] >> +COBJS-$(CONFIG_DRIVER_TI_CPSW) += cpsw.o > Please don't use the word DRIVER here. If possible, use something more > verbose than "CPSW" too. Will TI_CPSW_SWITCH work better considering that "CPSW" is the name of the hardware block? [...] >> +++ b/drivers/net/cpsw.c > Please re

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2010-09-01 Thread Cyril Chemparathy
Hi Ben, I seem to have missed a comment while responding earlier: [...] >> +int cpsw_register(struct cpsw_platform_data *data) > Please redo things so that this function takes generic arguments. Build > up your struct internally. Could you elaborate on the generic arguments here? Are you refer

[U-Boot] [PATCH] ARM1176: Coexist with other ARM1176 platforms

2010-03-11 Thread Cyril Chemparathy
after disabling the MMU. Signed-off-by: Cyril Chemparathy --- cpu/arm1176/cpu.c |1 - cpu/arm1176/start.S| 60 ++-- include/configs/smdk6400.h |6 3 files changed, 58 insertions(+), 9 deletions(-) diff --git a/cpu/arm1176/cp

[U-Boot] [PATCH v2 1/1] TI: Davinci: NAND Driver Cleanup

2010-03-16 Thread Cyril Chemparathy
Modified to use IO accessor routines consistently. Eliminated volatile usage to keep checkpatch.pl happy. Signed-off-by: Cyril Chemparathy --- 1. Added fixes for DA830 EVM and Davinci Schmoogie boards 2. Reverted to include davinci_emif_regs macro definition board/davinci/da830evm/da830evm.c

[U-Boot] [PATCH v3] TI: Davinci: NAND Driver Cleanup

2010-03-17 Thread Cyril Chemparathy
Modified to use IO accessor routines consistently. Eliminated volatile usage to keep checkpatch.pl happy. Signed-off-by: Cyril Chemparathy --- Minor formatting board/davinci/da830evm/da830evm.c|2 +- drivers/mtd/nand/davinci_nand.c | 128

[U-Boot] [PATCH 1/3] ARM1176: Coexist with other ARM1176 platforms

2010-03-29 Thread Cyril Chemparathy
after disabling the MMU. Signed-off-by: Cyril Chemparathy --- cpu/arm1176/cpu.c |1 - cpu/arm1176/start.S| 60 ++-- include/configs/smdk6400.h |6 3 files changed, 58 insertions(+), 9 deletions(-) diff --git a/cpu/arm1176/cp

[U-Boot] [PATCH 0/3] TI: tnetv107x patch series

2010-03-29 Thread Cyril Chemparathy
this series are identical to the larger patch posted earlier. The only difference here is that these changes have been split up as per feedback from Sandeep. Cyril Chemparathy (3): ARM1176: Coexist with other ARM1176 platforms ARM1176: TI: TNETV107X soc initial support TI: TNETV107X EVM

[U-Boot] [PATCH 3/3] TI: TNETV107X EVM initial support

2010-03-29 Thread Cyril Chemparathy
TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a bunch on on-chip integrated peripherals. This patch adds support for the TNETV107X EVM board. Signed-off-by: Cyril Chemparathy --- MAKEALL |1 + Makefile |3

[U-Boot] [PATCH v2 1/3] ARM1176: Coexist with other ARM1176 platforms

2010-03-31 Thread Cyril Chemparathy
after disabling the MMU. Signed-off-by: Cyril Chemparathy --- Unchanged from v1 cpu/arm1176/cpu.c |1 - cpu/arm1176/start.S| 60 ++-- include/configs/smdk6400.h |6 3 files changed, 58 insertions(+), 9 deletions(-) diff --

[U-Boot] [PATCH v2 0/3] TI: tnetv107x patch series

2010-03-31 Thread Cyril Chemparathy
this series are identical to the larger patch posted earlier. The only difference here is that these changes have been split up as per feedback from Sandeep. Cyril Chemparathy (3): ARM1176: Coexist with other ARM1176 platforms ARM1176: TI: TNETV107X soc initial support TI: TNETV107X EVM

[U-Boot] [PATCH v2 3/3] TI: TNETV107X EVM initial support

2010-03-31 Thread Cyril Chemparathy
TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a bunch on on-chip integrated peripherals. This patch adds support for the TNETV107X EVM board. Signed-off-by: Cyril Chemparathy --- 1. Added maintainers entry 2. Fixed sort order in main makefile 3. Remove board specific

[U-Boot] [PATCH v3 0/3] TI: tnetv107x patch series

2010-04-06 Thread Cyril Chemparathy
this series are identical to the v2 patch series posted earlier, with the exception of an added comment in tnetv107x_evm.h indicating the reasoning behind reusing the davinci_nand MTDID. Cyril Chemparathy (3): ARM1176: Coexist with other ARM1176 platforms ARM1176: TI: TNETV107X soc initial

[U-Boot] [PATCH v3 1/3] ARM1176: Coexist with other ARM1176 platforms

2010-04-06 Thread Cyril Chemparathy
after disabling the MMU. Signed-off-by: Cyril Chemparathy --- v3: unchanged from v2 v2: unchanged from v1 cpu/arm1176/cpu.c |1 - cpu/arm1176/start.S| 60 ++-- include/configs/smdk6400.h |6 3 files changed, 58 insertions(

[U-Boot] [PATCH v3 3/3] TI: TNETV107X EVM initial support

2010-04-06 Thread Cyril Chemparathy
TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a bunch on on-chip integrated peripherals. This patch adds support for the TNETV107X EVM board. Signed-off-by: Cyril Chemparathy --- v3: Added NAND MTDID comment in board config v2: Added maintainers entry v2: Fixed sort

[U-Boot] [PATCH v4 1/3] ARM1176: Coexist with other ARM1176 platforms

2010-04-12 Thread Cyril Chemparathy
after disabling the MMU. Signed-off-by: Cyril Chemparathy --- v4: rebased on next in u-boot-arm.git v3: unchanged from v2 v2: unchanged from v1 cpu/arm1176/cpu.c |3 -- cpu/arm1176/start.S| 62 include/configs/smdk6400.h |6 ++

[U-Boot] [PATCH v4 0/3] TI: tnetv107x patch series

2010-04-12 Thread Cyril Chemparathy
this series are identical to the v2 patch series posted earlier, with the exception of an added comment in tnetv107x_evm.h indicating the reasoning behind reusing the davinci_nand MTDID. Cyril Chemparathy (3): ARM1176: Coexist with other ARM1176 platforms ARM1176: TI: TNETV107X soc initial

[U-Boot] [PATCH v4 3/3] TI: TNETV107X EVM initial support

2010-04-12 Thread Cyril Chemparathy
TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a bunch on on-chip integrated peripherals. This patch adds support for the TNETV107X EVM board. Signed-off-by: Cyril Chemparathy --- v4: rebased on next in u-boot-arm.git (unchanged) v3: Added NAND MTDID comment in board

[U-Boot] [PATCH v5 3/3] TI: TNETV107X EVM initial support

2010-04-19 Thread Cyril Chemparathy
TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a bunch on on-chip integrated peripherals. This patch adds support for the TNETV107X EVM board. Signed-off-by: Cyril Chemparathy --- v5: rebased on master in u-boot-arm.git (unchanged) v4: rebased on next in u-boot-arm.git

[U-Boot] [PATCH v5 0/3] TI: tnetv107x patch series

2010-04-19 Thread Cyril Chemparathy
TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a bunch on on-chip integrated peripherals. This patch series generalizes current ARM1176 code to allow for the addition of new ARM1176 SOCs. The remaining patches in this series add arch and board support. Cyril Chemparathy

[U-Boot] [PATCH v5 1/3] ARM1176: Coexist with other ARM1176 platforms

2010-04-19 Thread Cyril Chemparathy
after disabling the MMU. Signed-off-by: Cyril Chemparathy --- v5: rebased on master in u-boot-arm.git v4: rebased on next in u-boot-arm.git v3: unchanged from v2 v2: unchanged from v1 arch/arm/cpu/arm1176/cpu.c |3 -- arch/arm/cpu/arm1176/start.S |

Re: [U-Boot] [PATCH] ARM1176: Coexist with other ARM1176 platforms

2010-04-30 Thread Cyril Chemparathy
Hi Tom, [...] >> +#ifndef CONFIG_SKIP_LOWLEVEL_INIT > > CONFIG_SKIP_LOWLEVEL_INIT is not used in the other patches. > Why is this needed ? > board/samsung/samsung/smdk6400 has a lowlevel_init.o function. > It is confusing why this function is being if-def and not the real > lowlevel_init.. Will

Re: [U-Boot] [PATCH v5 2/3] ARM1176: TI: TNETV107X soc initial support

2010-05-02 Thread Cyril Chemparathy
Hi Tom, Thanks for the excellent review. [...] >> +static struct async_emif_config default_async_emif_config[NUM_CS] = { >> + { /* CS0 */ >> + .mode = ASYNC_EMIF_MODE_NAND, >> + .select_strobe = ASYNC_EMIF_CS0_SELECT_STROBE, >> +

[U-Boot] [PATCH v6 0/3] TI: tnetv107x patch series

2010-05-03 Thread Cyril Chemparathy
TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a bunch on on-chip integrated peripherals. This patch series generalizes current ARM1176 code to allow for the addition of new ARM1176 SOCs. The remaining patches in this series add arch and board support. Cyril Chemparathy

[U-Boot] [PATCH v6 1/3] ARM1176: Coexist with other ARM1176 platforms

2010-05-03 Thread Cyril Chemparathy
es to figure out the physical address of the jump target label. Consequently, it ends up branching to the wrong address after disabling the MMU. Signed-off-by: Cyril Chemparathy --- v6: remove CONFIG_SKIP_LOWLEVEL_INIT support v6: modified virt-to-phys mapping to use offset instead of mask v6: changed

[U-Boot] [PATCH v6 3/3] TI: TNETV107X EVM initial support

2010-05-03 Thread Cyril Chemparathy
TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a bunch on on-chip integrated peripherals. This patch adds support for the TNETV107X EVM board. Signed-off-by: Cyril Chemparathy --- v6: moved async emif config, and pll config to board code v6: moved pll and aemif

[U-Boot] [PATCH 0/2] tnetv107x cpsw ethernet switch driver

2010-08-03 Thread Cyril Chemparathy
This patch series adds support for the cpsw ethernet switch found on tnetv107x and other SoCs from Texas Instruments. Cyril Chemparathy (2): TI: netdev: add driver for cpsw ethernet device TI: add tnetv107x evm board support for cpsw board/ti/tnetv107xevm/sdb_board.c | 155 +++ drivers

[U-Boot] [PATCH 2/2] TI: add tnetv107x evm board support for cpsw

2010-08-03 Thread Cyril Chemparathy
This patch adds the necessary board-level hookups to get the CPSW device working on tnetv107x evm boards. Signed-off-by: Cyril Chemparathy --- board/ti/tnetv107xevm/sdb_board.c | 155 + include/configs/tnetv107x_evm.h | 16 2 files changed, 171

[U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2010-08-03 Thread Cyril Chemparathy
CPSW is an on-chip ethernet switch that is found on various SoCs from Texas Instruments. This patch adds a simple driver (based on the Linux driver) for this hardware module. Signed-off-by: Cyril Chemparathy --- drivers/net/Makefile |1 + drivers/net/cpsw.c | 861