>
> #ifdef CONFIG_FMAN_ENET
> #if defined(CONFIG_T1040RDB) || defined(CONFIG_T1042RDB)
> -#define CONFIG_SYS_SGMII1_PHY_ADDR 0x03
> +#define CONFIG_SYS_SGMII1_PHY_ADDR 0x03
> +#elif defined(CONFIG_T1040D4RDB) || defined(CONFIG_T1042D4RDB)
> +#define CONFIG_SYS_SGMII1_PHY_AD
Hi York,
Sure, I will make v4 this week for this change only. I will try to shrink the
function and inline it in the header file.
Thanks and best regards,
Codrin
> -Original Message-
> From: Sun York-R58495
> Sent: Wednesday, August 12, 2015 10:59 PM
> To: Ciubotariu Codrin Constantin-B
Hi Joe, York,
> -Original Message-
> From: Sun York-R58495
> Sent: Wednesday, August 12, 2015 10:59 PM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com
> Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate
Hi York,
> -Original Message-
> From: Sun York-R58495
> Sent: Thursday, August 13, 2015 6:55 PM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com
> Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a
> MA
> -Original Message-
> From: Joe Hershberger [mailto:joe.hershber...@gmail.com]
> Sent: Monday, August 17, 2015 5:38 PM
> To: Sun York-R58495
> Cc: Ciubotariu Codrin Constantin-B43658; u-boot@lists.denx.de;
> joe.hershber...@ni.com
> Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add f
Hi York,
I didn't know that SPL uses net/eth.c . Could you please suggest a place for
eth_validate_ethaddr_str()?
Thanks and best regards,
Codrin
> -Original Message-
> From: Sun York-R58495
> Sent: Saturday, August 08, 2015 3:31 AM
> To: Ciubotariu Codrin Constantin-B43658; u-boot@list
Hi,
Just a heads up, I already sent a patch for T1040D4RDB regarding CPLD
configuration: mpc85xx/T1040D4RDB: Disable all CPLD interrupts, except QSGMI1
and QSGMI2. Since this patch includes the CPLD configurations, I guess mine
will become deprecated.
Best regards,
Codrin
> -Original Mess
Please ignore this cover letter. I resent it. Sorry!
Best regards,
Codrin
> -Original Message-
> From: Codrin Ciubotariu [mailto:codrin.ciubota...@freescale.com]
> Sent: Thursday, June 11, 2015 6:07 PM
> To: u-boot@lists.denx.de
> Cc: Kushwaha Prabhakar-B32579; Sun York-R58495; joe.hershb
Please ignore this patch. I resent it. Sorry!
Best regards,
Codrin
> -Original Message-
> From: Codrin Ciubotariu [mailto:codrin.ciubota...@freescale.com]
> Sent: Thursday, June 11, 2015 6:07 PM
> To: u-boot@lists.denx.de
> Cc: Kushwaha Prabhakar-B32579; Sun York-R58495; joe.hershber...@n
Hi Joe,
> > The VSC9953 DS reserves a register between vlan_mask and anag_efil
> > registers.
> >
> > Signed-off-by: Johnson Leung
> > ---
>
> Where is your Signed-off-by: ? Please either update the "Author" in the
> commit
> to Johnson Leung or add your Signed-off-by.
>
> -Joe
Johnson found
Hi Joe,
> >
> > /* alloc eth device */
> > dev = (struct eth_device *)calloc(1, sizeof(struct eth_device));
> > if (!dev)
> > - return 1;
> > + return -1;
>
> Is it reasonable to use values from asm/errno.h here and elsewhere in
> the driver? Th
Hi Joe,
> > + return !!timeout;
>
> Maybe this:
>
> + return timeout ? 0 : -EBUSY;
Ok.
> > +
> > + if (!vsc9953_vlan_table_poll_idle()) {
>
> If you accept the above, you need to change these to:
> + if (vsc9953_vlan_table_poll_idle() < 0) {
>
> or
>
> + if (vs
Hi Joe,
I removed the lines on which we agreed on...
> >> > + switch (mode) {
> >> > + case EGRESS_UNTAG_ALL:
> >> > + clrsetbits_le32(&l2rew_reg->port[port_no].port_tag_cfg,
> >> > + CONFIG_VSC9953_TAG_CFG_MASK,
> >> > +
Hi Joe,
> -Original Message-
> From: Joe Hershberger [mailto:joe.hershber...@gmail.com]
> Sent: Friday, June 26, 2015 1:26 AM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: u-boot; Joe Hershberger; Sun York-R58495
> Subject: Re: [U-Boot] [PATCH 03/11 v2] drivers/net/vsc9953: Add default
>
Hi Joe,
> -Original Message-
> From: Joe Hershberger [mailto:joe.hershber...@gmail.com]
> Sent: Friday, June 26, 2015 1:31 AM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: u-boot; Joe Hershberger; Sun York-R58495
> Subject: Re: [U-Boot] [PATCH 04/11 v2] drivers/net/vsc9953: Refractor the
Hi Joe,
I will make the changes you requested.
Thanks and best regards,
Codrin
> -Original Message-
> From: Joe Hershberger [mailto:joe.hershber...@gmail.com]
> Sent: Friday, June 26, 2015 1:34 AM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: u-boot; Joe Hershberger; Sun York-R58495
>
Hi Joe,
I will make the changes you requested.
Thanks and best regards,
Codrin
> -Original Message-
> From: Joe Hershberger [mailto:joe.hershber...@gmail.com]
> Sent: Friday, June 26, 2015 1:38 AM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: u-boot; Joe Hershberger; Sun York-R58495
>
Hi Joe,
> -Original Message-
> From: Joe Hershberger [mailto:joe.hershber...@gmail.com]
> Sent: Friday, June 26, 2015 1:39 AM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: u-boot; Joe Hershberger; Sun York-R58495
> Subject: Re: [U-Boot] [PATCH 07/11 v2] drivers/net/vsc9953: Add commands
Hi Joe,
> -Original Message-
> From: Joe Hershberger [mailto:joe.hershber...@gmail.com]
> Sent: Friday, June 26, 2015 1:41 AM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: u-boot; Joe Hershberger; Sun York-R58495
> Subject: Re: [U-Boot] [PATCH 08/11 v2] drivers/net/vsc9953: Add VLAN comm
Hi Joe,
I will make a v3 with your suggestions.
Thanks and best regards,
Codrin
> -Original Message-
> From: Joe Hershberger [mailto:joe.hershber...@gmail.com]
> Sent: Friday, June 26, 2015 1:41 AM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: u-boot; Joe Hershberger; Sun York-R58495
>
Hi Joe,
I will make a v3 with your suggestions.
Thanks and best regards,
Codrin
> -Original Message-
> From: Joe Hershberger [mailto:joe.hershber...@gmail.com]
> Sent: Friday, June 26, 2015 1:42 AM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: u-boot; Joe Hershberger; Sun York-R58495
>
s/net/vsc9953: Add default
> configuration for VSC9953 L2 Switch
>
> Hi Codrin,
>
> On Tue, Jun 30, 2015 at 2:51 AM, Codrin Constantin Ciubotariu
> wrote:
> > Hi Joe,
> >
> > I removed the lines on which we agreed on...
> >
> >>
s/net/vsc9953: Add commands to
> manipulate the FDB for VSC9953
>
> Hi Codrin,
>
> On Tue, Jun 30, 2015 at 8:31 AM, Codrin Constantin Ciubotariu
> wrote:
> > Hi Joe,
> >
> >> -Original Message-
> >> From: Joe Hershberger [mailto:joe.hersh
Hi Joe,
> > -#define CONFIG_VSC9953_PORT_ENA0x3a00
>
> Why is this value changing? Was it just wrong before?
Sorry, I missed this comment. Yes, the correct value that only enables the port
is 0x2000. The rest of the bits are set to 1 because they are reserved and
default
vsc9953: Refractor the
> parser
> for VSC9953 commands
>
> Hi Codrin,
>
> On Tue, Jun 30, 2015 at 3:57 AM, Codrin Constantin Ciubotariu
> wrote:
> > Hi Joe,
> >
> >> -Original Message-
> >> From: Joe Hershberger [mailto:joe.he
Hi,
Anyone has any comments on this? Please share your thoughts.
Thanks and best regards,
Codrin
> -Original Message-
> From: Codrin Ciubotariu [mailto:codrin.ciubota...@freescale.com]
> Sent: Friday, February 13, 2015 2:48 PM
> To: u-boot@lists.denx.de
> Cc: Sun York-R58495; Ciubotariu
26 matches
Mail list logo
