Re: [U-Boot] Question about Coding-Style

2014-02-10 Thread Chris Moore
Hi Albert, Le 10/02/2014 10:58, Albert ARIBAUD a écrit : Hi Tom, On Tue, 4 Feb 2014 10:07:32 -0500, Tom Rini wrote: On Tue, Feb 04, 2014 at 04:02:56PM +0100, Stefano Babic wrote: Hi Hannes, On 04/02/2014 15:50, Hannes Petermaier wrote: [snip] Another thing is linewrapping of output string

Re: [U-Boot] [PATCH] Orion5x: bugfix: window size (mis)calculation

2010-08-26 Thread Chris Moore
Hi list, Le 24/08/2010 15:27, Albert Aribaud a écrit : > Fix orion5x_winctrl_calcsize() off-by-1 bug which caused mapping > windows to be cut by half. This afected all windows including NOR > flash (causing half the flash to be unaccessible) but DRAM was and > still is fine as its size is determ

Re: [U-Boot] [PATCH] Orion5x: bugfix: window size (mis)calculation

2010-08-27 Thread Chris Moore
Hello Albert, Le 27/08/2010 07:37, Albert ARIBAUD a écrit : > Le 27/08/2010 07:00, Chris Moore a écrit : > > > I think your proposal to handle size 0 as meaning '4 MB' is fine, > since there is no way to express 4MB and a zero size is meaningless as > such. > s

Re: [U-Boot] [PATCH] orion5x: optimize window size computation

2010-10-05 Thread Chris Moore
ot@lists.denx.de >> Subject: [U-Boot] [PATCH] orion5x: optimize window size computation >> >> >> Signed-off-by: Chris Moore >> --- >> >> This is a simple optimization of the orion5x window size >> computation. This code was contributed by Chris Moore s

Re: [U-Boot] [PATCH V2] orion5x: optimize window size computation

2010-10-06 Thread Chris Moore
Hi, Sorry Albert I missed this one last time :( Le 06/10/2010 16:46, Albert Aribaud a écrit : > + * 1) A sizeval equal to 0x0 specifies 4 TB s/TB/GB/ or maybe even s/TB/GiB/ Question: are MB, GB, ... or MiB, GiB, ... preferred in U-Boot? I generally try to use the "i" versions where appropri

Re: [U-Boot] [PATCH] ppc/85xx: Fix LCRR_CLKDIV defines

2009-09-15 Thread Chris Moore
Peter Tyser a écrit : > On Tue, 2009-09-15 at 22:26 -0500, Kumar Gala wrote: > >> For some reason the CLKDIV field varies between SoC in how it interprets >> the bit values. >> >> [snip] >> >> Ensure that the MPC86xx and MPC85xx still get the same behavior and make >> the the defines refl

Re: [U-Boot] [PATCH 1/3] memcpy: use 32-bit copies if possible

2009-10-07 Thread Chris Moore
Alessandro Rubini a écrit : > From: Alessandro Rubini > > Signed-off-by: Alessandro Rubini > Acked-by: Andrea Gallo > --- > lib_generic/string.c | 11 ++- > 1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/lib_generic/string.c b/lib_generic/string.c > index 181eda6..

Re: [U-Boot] [PATCH V2 1/3] memcpy: copy one word at a time if possible

2009-10-08 Thread Chris Moore
Wolfgang Denk a écrit : > I think we should change this if-else into a plain if, something like > that: > > void * memcpy(void *dest, const void *src, size_t count) > { > char *tmp = (char *) dest, *s = (char *) src; > char *d8 = (char *)dest, *s8 = (char *)src; > unsigned long *d

Re: [U-Boot] [PATCH V3 1/3] lib_generic memcpy: copy one word at a time if possible

2009-10-09 Thread Chris Moore
Alessandro Rubini a écrit : > From: Alessandro Rubini > > If source and destination are aligned, this copies ulong values > until possible, trailing part is copied by byte. Thanks for the details > to Wolfgang Denk, Mike Frysinger, Peter Tyser, Chris Moore. > > Signed-off-

Re: [U-Boot] [PATCH V3 2/3] lib_generic memset: fill one word at a time if possible

2009-10-09 Thread Chris Moore
Similar remarks to those for memcpy : Alessandro Rubini a écrit : > From: Alessandro Rubini > > If the destination is aligned, fill ulong values until possible. > Then fill remaining part by bytes. > > Signed-off-by: Alessandro Rubini > Acked-by: Andrea Gallo > --- > lib_generic/string.c | 2

Re: [U-Boot] [PATCH V2 1/3] memcpy: copy one word at a time if possible

2009-10-11 Thread Chris Moore
Mike Frysinger a écrit : > On Friday 09 October 2009 06:11:16 Mark Jackson wrote: > >> Chris Moore wrote: >> >>> I agree wholeheartedly with the idea but shouldn't it be more like this >>> (untested) code : >>> >>&

Re: [U-Boot] [PATCH V3 1/3] lib_generic memcpy: copy one word at a time if possible

2009-10-11 Thread Chris Moore
Hi Alessandro, Alessandro Rubini a écrit : >>> + unsigned long *dl = (unsigned long *)dest, *sl = (unsigned long *)src; >>> > > >> Nitpick: Are you sure the casts are necessary here ? >> > > Without the one on src it complains because of "const". So I write > both for symetry. >

Re: [U-Boot] [PATCH v4 2/7] gpio: Add Multi-Function-Pin configuration driver for Marvell SoCs

2010-12-08 Thread Chris Moore
Hi, Le 07/12/2010 18:39, Albert ARIBAUD a écrit : > Le 07/12/2010 18:10, Prafulla Wadaskar a écrit : > + val&= ~MFP_AF_MASK; >>> Do we need to do this& here? For val is only 0 here... >> This can be removed. > OTOH, with the&, this line makes no assumption about val, a

[U-Boot] Fwd: Debian platform firmware strategy?

2014-07-02 Thread Chris Moore
Hi Paul, I hope you don't mind my forwarding your message below to the U-Boot ML. I think U-Boot ML subscribers may be interested in this discussion. My apologies in advance if I am wrong. Cheers, Chris Message original Sujet: Debian platform firmware strategy? Date de renvoi

Re: [U-Boot] PATCH-add "0X" hexadecimal prefix to simple_strtoul

2011-02-08 Thread Chris Moore
Hi, Le 08/02/2011 20:14, Wolfgang Denk a écrit : > Dear Rob Alexander, > > In message<4d51716d.3060...@motorola.com> you wrote: > >> +if ((tolower(*cp) == 'x')&& isxdigit(cp[1])) { > ERROR: spaces required around that '&&' (ctx:VxW) > I suspect that this could be the Thunderbird pr

Re: [U-Boot] Thunderbird bug (was PATCH-add "0X" hexadecimal prefix to simple_strtoul)

2011-02-09 Thread Chris Moore
Hi, Le 09/02/2011 22:17, Scott Wood a écrit : > On Wed, 9 Feb 2011 07:40:44 +0100 > Albert ARIBAUD wrote: > >> Le 09/02/2011 07:19, Chris Moore a écrit : >>> I also noticed this in some of my (rare) posts. >>> I am using TB 3.1.5. >>> I am too ashamed

Re: [U-Boot] Thunderbird bug (was PATCH-add "0X" hexadecimal prefix to simple_strtoul)

2011-02-09 Thread Chris Moore
Hi, Me again. Le 10/02/2011 07:16, Chris Moore a écrit : > Hi, > > Le 09/02/2011 22:17, Scott Wood a écrit : >> On Wed, 9 Feb 2011 07:40:44 +0100 >> Albert ARIBAUD wrote: >> >>> Le 09/02/2011 07:19, Chris Moore a écrit : >>>> I also noticed thi

Re: [U-Boot] u-boot <=> kernel compatibility?

2017-11-04 Thread Chris Moore
Hi, Le 04/11/2017 à 19:37, Tom Rini a écrit : On Sat, Nov 04, 2017 at 07:22:06AM +0100, daggs wrote: Greetings, is there a minimum kernel version limitation on the latest release of u-boot? the reason I'm asking is that I'm unable to boot a arm board with latest u-boot and the vendor's kernel

Re: [U-Boot] u-boot <=> kernel compatibility?

2017-11-08 Thread Chris Moore
Hi, Le 08/11/2017 à 09:11, daggs a écrit : Greetings Tom, Sent: Saturday, November 04, 2017 at 8:37 PM From: "Tom Rini" To: daggs Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] u-boot <=> kernel compatibility? On Sat, Nov 04, 2017 at 07:22:06AM +0100, daggs wrote: Greetings, is there a m