Re: [RFC PATCH 1/2] kconfig: Bring in from Linux v6.2

2023-03-12 Thread Bin Meng
00644 scripts/kconfig/tests/preprocess/variable/expected_stderr > delete mode 100644 scripts/kconfig/tests/rand_nested_choice/Kconfig > delete mode 100644 scripts/kconfig/tests/rand_nested_choice/__init__.py > delete mode 100644 scripts/kconfig/tests/rand_nested_choice/expected_stdout0 > delete mode 100644 scripts/kconfig/tests/rand_nested_choice/expected_stdout1 > delete mode 100644 scripts/kconfig/tests/rand_nested_choice/expected_stdout2 > Tested building qemu-x86 and qemu-riscv_spl, and boot on QEMU Tested-by: Bin Meng

Re: [RFC PATCH 2/2] kconfig: U-Boot additions

2023-03-12 Thread Bin Meng
le | 10 ++ > 1 file changed, 10 insertions(+) > Tested building qemu-x86 and qemu-riscv_spl, and boot on QEMU Tested-by: Bin Meng

Re: [PATCH v2 2/2] x86: minnowmax: Adjust CONFIG_TEXT_BASE et at

2023-03-13 Thread Bin Meng
Hi Simon, On Sat, Mar 11, 2023 at 7:33 AM Simon Glass wrote: > > At present U-Boot no longer builds as a complete rom for minnowmaxs since > it is too big for the section. > > Adjust CONFIG_TEXT_BASE and CONFIG_SYS_MONITOR_LEN to allow more code > space. Move the MRC cache out of the way too. > >

Re: [PATCH v2 1/2] x86: Revert "x86: minnowmax: Adjust CONFIG_TEXT_BASE"

2023-03-13 Thread Bin Meng
Hi Simon, On Sat, Mar 11, 2023 at 7:33 AM Simon Glass wrote: > > This causes Minnowmax to stop booting. Revert it so we have a good > example of how to do this fully. > > This reverts commit 66e2c665f3b60d726e1c26ad44ac97aa76ead6f5. > > Signed-off-by: Simon Glass > --- > > (no changes since v1)

Re: [PATCH v3 1/5] x86: minnowmax: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
Change the commit message and subject > > Changes in v2: > - Add new patch which boots while still enabling EFI_LOADER > > arch/x86/dts/minnowmax.dts| 2 +- > configs/minnowmax_defconfig | 1 + > doc/board/intel/minnowmax.rst | 15 +++++-- > 3 files changed, 15 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 2/5] x86: bayleybay: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
by: Simon Glass > Fixes: f38be308683 ("x86: bayleybay: Adjust CONFIG_TEXT_BASE") > --- > > Changes in v3: > - Add new patch > > arch/x86/dts/bayleybay.dts | 2 +- > configs/bayleybay_defconfig | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 3/5] x86: conga-qeval20-qa3-e3845: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
onfig | 1 + > configs/conga-qeval20-qa3-e3845_defconfig | 1 + > configs/theadorable-x86-conga-qa3-e3845-pcie-x4_defconfig | 1 + > configs/theadorable-x86-conga-qa3-e3845_defconfig | 1 + > 5 files changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 4/5] x86: dfi-bt700: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
fconfig | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 5/5] x86: som-db5800-som-6867: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
by: Simon Glass > Fixes: e23cae30801 ("x86: som-db5800-som-6867: Adjust CONFIG_TEXT_BASE") > --- > > Changes in v3: > - Add new patch > > arch/x86/dts/baytrail_som-db5800-som-6867.dts | 2 +- > configs/som-db5800-som-6867_defconfig | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 1/5] x86: minnowmax: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Bin Meng
On Thu, Mar 16, 2023 at 3:27 PM Bin Meng wrote: > > On Wed, Mar 15, 2023 at 8:00 AM Simon Glass wrote: > > > > With recent CONFIG_TEXT_BASE changes, there are inconsistencies between > > several settings. > > > > Adjust CONFIG_SYS_MONITOR_LEN to allow more co

Re: [PATCH 01/13] mtrr: Don't show an invalid CPU number

2023-03-19 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > When U-Boot did not do the MP init, we don't get an actual CPU number > here. Skip printing it in that case. > > Signed-off-by: Simon Glass > --- > > cmd/x86/mtrr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > dif

Re: [PATCH 02/13] x86: Adjust search range for sysinfo table

2023-03-19 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > Avoid searching starting at 0 since this memory may not be available Please describe in more detail why memory address 0 is not available? > and the table cannot be there anyway. Start at 0x400 instead. > > Signed-off-by: Simon Gl

Re: [PATCH 03/13] input: Only reset the keyboard when running bare metal

2023-03-19 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > If U-Boot is not the first-stage bootloader we should not init the > keyboard, since it has already been done. Check for this. But re-init does no harm, right? > > Signed-off-by: Simon Glass > --- > > drivers/input/i8042.c | 13

Re: [PATCH 05/13] x86: coreboot: Collect the address of the ACPI tables

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > Pick this up from the sysinfo tables and display it with the cbsysinfo > command. This allows the 'acpi list' command to work when booting from > coreboot. > > Signed-off-by: Simon Glass > --- > > arch/x86/include/asm/cb_sysinfo.h

Re: [PATCH 06/13] x86: Allow locating UARTs by device ID

2023-03-20 Thread Bin Meng
+Andy Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > When coreboot does not pass a UART in its sysinfo struct, there is no > easy way to find it out. Add a way to specify known UARTs so we can > find them without needing help from coreboot. > > Since coreboot does not actually

Re: [PATCH 07/13] pci: coreboot: Don't read regions when booting

2023-03-20 Thread Bin Meng
is not safe for U-Boot to make any changes. > > Signed-off-by: Simon Glass > --- > > drivers/pci/pci-uclass.c | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 09/13] x86: coreboot: Use a memory-mapped UART

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > This is much more common on modern hardware, so default to using it. > > Signed-off-by: Simon Glass > --- > > include/configs/coreboot.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/configs/coreboot.h b/inclu

Re: [PATCH 09/13] x86: coreboot: Use a memory-mapped UART

2023-03-20 Thread Bin Meng
On Mon, Mar 20, 2023 at 4:08 PM Bin Meng wrote: > > Hi Simon, > > On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > > > This is much more common on modern hardware, so default to using it. > > > > Signed-off-by: Simon Glass > > --- > > &g

Re: [PATCH 10/13] x86: coreboot: Document how to enable the debug UART

2023-03-20 Thread Bin Meng
On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > This is not obvious so add a little note about how it works. > > Signed-off-by: Simon Glass > --- > > doc/board/coreboot/coreboot.rst | 29 + > 1 file changed, 29 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 11/13] x86: coreboot: Scan PCI after relocation

2023-03-20 Thread Bin Meng
On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > Enable this so that PCI devices can be used correctly without needing > to do a manual scan. > > Signed-off-by: Simon Glass > --- > > configs/coreboot_defconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng

Re: [PATCH 12/13] x86: coreboot: Log function names and line numbers

2023-03-20 Thread Bin Meng
1 file changed, 4 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 13/13] x86: coreboot: Show unimplemented sysinfo tags

2023-03-20 Thread Bin Meng
asm/cb_sysinfo.h | 6 ++ > arch/x86/lib/coreboot/cb_sysinfo.c | 2 ++ > cmd/x86/cbsysinfo.c | 8 > 3 files changed, 16 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 03/13] input: Only reset the keyboard when running bare metal

2023-03-20 Thread Bin Meng
Hi Simon, On Tue, Mar 21, 2023 at 2:40 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 20 Mar 2023 at 19:32, Bin Meng wrote: > > > > Hi Simon, > > > > On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > > > > > If U-Boot is not the first-

Re: [PATCH v2 01/19] test: Restore test behaviour on failure

2023-07-12 Thread Bin Meng
- Add a comment that this is not a full revert > > include/test/ut.h | 36 ++---------- > 1 file changed, 18 insertions(+), 18 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 04/19] bootstd: Use bootdev instead of bootdevice

2023-07-12 Thread Bin Meng
> drivers/usb/host/usb_bootdev.c | 2 +- > fs/sandbox/host_bootdev.c | 2 +- > include/bootdev.h | 2 +- > include/bootflow.h | 2 +- > net/eth_bootdev.c | 2 +- > 8 files changed, 9 insertions(+), 9 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 07/19] bootstd: Use the bootargs env var for changing the cmdline

2023-07-12 Thread Bin Meng
; + > + if (value) { > + cmdline = strdup(value); > + if (!cmdline) > + return -ENOMEM; > + } > + > + free(bflow->cmdline); v1 comment was not addressed. But I assume bflow->cmdline is zero for the very first time so there will be no issue. > + bflow->cmdline = cmdline; > + > + return 0; > +} Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH v2 08/19] bootstd: Allow storing x86 setup information

2023-07-12 Thread Bin Meng
ion is not behind an #ifdef > > cmd/bootflow.c | 2 ++ > include/bootflow.h | 2 ++ > 2 files changed, 4 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v2 10/19] bootstd: Add a function to update a command line

2023-07-12 Thread Bin Meng
- Add a comment as to why @len is needed > > boot/bootflow.c | 190 +++ > include/bootflow.h | 40 + > test/boot/bootflow.c | 154 +++++++ > 3 files changed, 384 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v2 12/19] x86: qemu: Create a little more room for U-Boot

2023-07-12 Thread Bin Meng
--- > > Changes in v2: > - Add new patch to create a little more room for U-Boot on qemu-x86_64 > > configs/qemu-x86_64_defconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 13/19] x86: qemu: Switch to standard boot

2023-07-12 Thread Bin Meng
es in v2: > - Add new patch to switch x86 qemu to standard boot > > configs/qemu-x86_64_defconfig | 2 +- > configs/qemu-x86_defconfig| 2 +- > include/configs/qemu-x86.h| 8 > 3 files changed, 2 insertions(+), 10 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 18/19] x86: coreboot: Adjust various config options

2023-07-12 Thread Bin Meng
ed-off-by: Simon Glass > --- > > (no changes since v1) > > configs/coreboot_defconfig | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 19/19] x86: coral: Adjust various config options

2023-07-12 Thread Bin Meng
t; --- > > Changes in v2: > - Drop mention of NVMe support > Reviewed-by: Bin Meng

Re: [PATCH v2 00/19] bootstd: Add a bootmeth for ChromiumOS on x86

2023-07-12 Thread Bin Meng
Hi Simon, On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > This series adds a simple bootmeth for ChromiumOS on x86. It uses zimage > to boot the kernel. > > Full verified boot is not included at this stage - that is still a > separate chunk of code to be brought into standard boot at some

Re: [PATCH v2 18/19] x86: coreboot: Adjust various config options

2023-07-12 Thread Bin Meng
Hi Simon, On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > Drop IDE since this is not widely used anymore. Add NVME since it is > becoming more popular. > > Add ms so it is easier to search for tables in memory. > > Expand the command-line and print buffers so that we can deal with the > ve

Re: [PATCH v4 01/45] x86: Return mtrr_add_request() to its old purpose

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > This function used to be for adding a list of requests to be actioned on > relocation. Revert it back to this purpose, to avoid problems with boards > which need control of their MTRRs (i.e. those which don't use FSP). > > The mtrr_

Re: [PATCH v4 02/45] x86: Allow listing MTRRs in SPL

2023-07-12 Thread Bin Meng
; uint64_t base, mask; > - int i, type = -1; > + int type = -1; > bool valid; > int ret; > > if (argc < 3) > return CMD_RET_USAGE; > - for (i = 0; i < MTRR_TYPE_COUNT; i++) { > - if (*typename == *mtrr_type_name[i]) > - type = i; > - } > - if (type == -1) { > + type = mtrr_get_type_by_name(typename); > + if (type < 0) { > printf("Invalid type name %s\n", typename); > return CMD_RET_USAGE; > } > @@ -146,7 +94,7 @@ static int do_mtrr(struct cmd_tbl *cmdtp, int flag, int > argc, > if (!first) > printf("\n"); > printf("CPU %d:\n", i); > - ret = do_mtrr_list(reg_count, i); > + ret = mtrr_list(reg_count, i); > if (ret) { > printf("Failed to read CPU %s (err=%d)\n", >i < MP_SELECT_ALL ? simple_itoa(i) : > "", > -- > Otherwise, Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH v4 03/45] x86: mtrr: Add documentation

2023-07-12 Thread Bin Meng
Y Uncacheable d000 000ff000 1000 > +6 N Uncacheable 0010 > +7 N Uncacheable 0010 > +8 N Uncacheable 0010 > +9 N Uncacheable 0010 > +=> > diff --git a/doc/usage/index.rst b/doc/usage/index.rst > index 84ef8a9a427d..f45b3d2bb6ed 100644 > --- a/doc/usage/index.rst > +++ b/doc/usage/index.rst > @@ -71,6 +71,7 @@ Shell commands > cmd/md > cmd/mmc > cmd/mtest > + cmd/mtrr > cmd/panic > cmd/part > cmd/pause > Otherwise, Reviewed-by: Bin Meng

Re: [PATCH v4 04/45] bios_emulator: Add Kconfig and adjust Makefile for SPL

2023-07-12 Thread Bin Meng
since v1) > > board/google/Kconfig | 7 --- > drivers/Kconfig | 2 ++ > drivers/Makefile | 2 +- > drivers/bios_emulator/Kconfig | 10 ++ > 4 files changed, 13 insertions(+), 8 deletions(-) > create mode 100644 drivers/bios_emulator/Kconfig > Reviewed-by: Bin Meng

Re: [PATCH v4 05/45] bios_emulator: Drop VIDEO_IO_OFFSET

2023-07-12 Thread Bin Meng
.h | 2 -- > include/configs/minnowmax.h | 2 -- > include/configs/som-db5800-som-6867.h | 2 -- > include/configs/theadorable-x86-common.h | 2 -- > include/configs/x86-chromebook.h | 2 -- > 8 files changed, 10 insertions(+), 21 deletions(-) > Otherwise, Reviewed-by: Bin Meng

Re: [PATCH v4 06/45] x86: Tidy up EFI code in interrupt_init()

2023-07-12 Thread Bin Meng
++ > 1 file changed, 5 insertions(+), 12 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 07/45] x86: Add a comment for board_init_f_r_trampoline()

2023-07-12 Thread Bin Meng
lass > --- > > (no changes since v2) > > Changes in v2: > - Add docs to board_init_f_r() too > > arch/x86/include/asm/u-boot-x86.h | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 08/45] x86: Show the CPU physical address size with bdinfo

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > This is useful information so show it with the bdinfo command. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/x86/lib/bdinfo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/lib/bdinfo.c

Re: [PATCH v4 09/45] x86: Correct get_sp() implementation for 64-bit

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Use an assembler implementation as is done for i386, so that the results > are equivalent. The commit message is confusing. It says "Correct the implementation ..." and here it says "the results are equivalent", but what was change

Re: [PATCH v4 10/45] x86: Show an error when a BIOS exception occurs

2023-07-12 Thread Bin Meng
Fix BINS typo > - Drop the Ooops string > > arch/x86/lib/bios.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 11/45] acpi: Add a comment to set the acpi tables

2023-07-12 Thread Bin Meng
l(buf); > + addr = map_to_sysmem(buf); > + ut_assertok(setup_ctx_and_base_tables(uts, &ctx, addr)); > + > + ut_assertok(acpi_write_dev_tables(&ctx)); > + > + ut_assertok(run_command("acpi set", 0)); > + ut_assert_nextline("ACPI pointer: %lx", addr); > + > + ut_assertok(run_command("acpi set 0", 0)); > + ut_assert_nextline("Setting ACPI pointer to 0"); > + ut_asserteq(0, gd_acpi_start()); > + > + ut_assertok(run_commandf("acpi set %lx", addr)); > + ut_assert_nextline("Setting ACPI pointer to %lx", addr); > + ut_asserteq(addr, gd_acpi_start()); > + > + ut_assert_console_end(); > + > + return 0; > +} > +DM_TEST(dm_test_acpi_cmd_set, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT); > -- Otherwise, Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH v4 12/45] bdinfo: Show the RAM top and approximate stack pointer

2023-07-12 Thread Bin Meng
gned-off-by: Simon Glass > Reviewed-by: Nikhil M Jain > Tested-by: Nikhil M Jain > --- > > (no changes since v1) > > cmd/Kconfig | 8 > cmd/bdinfo.c | 5 + > 2 files changed, 13 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 13/45] part: Allow setting the partition-table type

2023-07-12 Thread Bin Meng
> include/part.h | 9 + > 4 files changed, 133 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 14/45] qfw: Show the file address if available

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Some files have an associated address. Show this with the 'qfw list' > command so that it is possible to dump the data. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > cmd/qfw.c | 2 +- > doc/usage/

Re: [PATCH v4 15/45] log: Tidy up an ambiguous comment.

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Add a a bit more detail so it is clear that multiple devices are Remove one 'a' also, please remove the period in the commit summary > supported, but only one per driver. > > Signed-off-by: Simon Glass > --- > > (no changes sinc

Re: [PATCH v4 16/45] qfw: Set the address of the ACPI tables

2023-07-12 Thread Bin Meng
misc/qfw.c | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 17/45] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

2023-07-12 Thread Bin Meng
nabled. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > lib/uuid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 19/45] Show the malloc base with the bdinfo command

2023-07-12 Thread Bin Meng
* @malloc_base: base address of early malloc() > @@ -560,6 +566,13 @@ static_assert(sizeof(struct global_data) == GD_SIZE); > #define gd_event_state() NULL > #endif > > +#if CONFIG_IS_ENABLED(CMD_BDINFO_EXTRA) > +#define gd_malloc_start() gd->malloc_start > +#define gd_set_malloc_start(_val) gd->malloc_start = (_val) > +#else > +#define gd_malloc_start() 0 > +#define gd_set_malloc_start(val) > +#endif > /** > * enum gd_flags - global data flags > * Otherwise, Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH v4 18/45] x86: Improve the trampoline in 64-bit mode

2023-07-12 Thread Bin Meng
h | 11 +++ > common/board_f.c | 12 +++- > 3 files changed, 37 insertions(+), 5 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 20/45] nvme: Provide more useful debugging messages

2023-07-12 Thread Bin Meng
++-- > 1 file changed, 26 insertions(+), 10 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 1/2] CI: Update to QEMU 8.0.3

2023-07-12 Thread Bin Meng
On Thu, Jul 13, 2023 at 10:04 AM Tom Rini wrote: > > Move up to the latest tagged release of QEMU I have the same patch in my local tree :) > > Signed-off-by: Tom Rini > --- > tools/docker/Dockerfile | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tools/docker/D

Re: [PATCH 1/2] CI: Update to QEMU 8.0.3

2023-07-12 Thread Bin Meng
On Thu, Jul 13, 2023 at 11:04 AM Tom Rini wrote: > > On Thu, Jul 13, 2023 at 10:51:15AM +0800, Bin Meng wrote: > > On Thu, Jul 13, 2023 at 10:04 AM Tom Rini wrote: > > > > > > Move up to the latest tagged release of QEMU > > > > I have the same patch

Re: [PATCH v4 22/45] pci: Allow the video BIOS to work in SPL with QEMU

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > QEMU emulates two common machines (Q35 and i440fx) which use mapping to > determine whether RAM is present below 1MB. In order to copy the video > BIOS to c we need to flip this mapping over to RAM. This does not > happen automa

Re: [PATCH v4 23/45] pci: Tidy up logging and reporting for video BIOS

2023-07-12 Thread Bin Meng
since v1) > > drivers/pci/pci_rom.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 24/45] x86: Allow video-BIOS code to be built for SPL

2023-07-12 Thread Bin Meng
> > (no changes since v1) > > arch/x86/lib/Makefile | 7 --- > arch/x86/lib/bios.c | 2 +- > drivers/pci/pci_rom.c | 28 ++-- > 3 files changed, 19 insertions(+), 18 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 25/45] x86: Pass video settings from SPL to U-Boot proper

2023-07-12 Thread Bin Meng
+ * struct video_handoff - video information passed from SPL > + * > + * This is used when video is set up by SPL, to provide the details to U-Boot > + * proper. > + * > + * @fb: Base address of frame buffer, 0 if not yet known > + * @size: Frame-buffer size, in bytes > + * @xsize: Number of pixel columns (e.g. 1366) > + * @ysize: Number of pixels rows (e.g.. 768) > + * @line_length: Length of each frame buffer line, in bytes. This can > be > + * set by the driver, but if not, the uclass will set it after > + * probing > + * @bpix: Encoded bits per pixel (enum video_log2_bpp) > + */ > +struct video_handoff { > + u64 fb; > + u32 size; > + ushort xsize; > + ushort ysize; nits: use u16 > + u32 line_length; > + u8 bpix; > +}; > + > /** enum colour_idx - the 16 colors supported by consoles */ > enum colour_idx { > VID_BLACK = 0, > -- Otherwise, Reviewed-by: Bin Meng

Re: [PATCH v4 21/45] pci: Support autoconfig in SPL

2023-07-12 Thread Bin Meng
> > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/pci/Kconfig | 8 > drivers/pci/pci-uclass.c | 10 +- > 2 files changed, 17 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 26/45] x86: Init video in SPL if enabled

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > When video is required in SPL, set this up ready for use. Ignore any > problems since it may be that video is not actually available and we > still want to continue on to U-Boot proper in that case. > > Make sure that the SPL banner

Re: [PATCH v4 27/45] pci: Adjust video BIOS debugging to be SPL-friendly

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > A hex value is expected for the VGA mode. Drop the 0x prefix, which is > not supported in SPL. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/pci/pci_rom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH v4 28/45] pci: Mask the ROM address in case it is already enabled

2023-07-12 Thread Bin Meng
ivers/pci/pci_rom.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 29/45] x86: Enable display for QEMU 64-bit

2023-07-12 Thread Bin Meng
; +CONFIG_SPL_PCI_PNP=y > CONFIG_SPL_DM_RTC=y > CONFIG_SYS_NS16550_PORT_MAPPED=y > CONFIG_SPI=y > CONFIG_USB_KEYBOARD=y > +CONFIG_SPL_VIDEO=y > CONFIG_FRAMEBUFFER_SET_VESA_MODE=y > CONFIG_FRAMEBUFFER_VESA_MODE_USER=y > CONFIG_FRAMEBUFFER_VESA_MODE=0x144 > -- Otherwise, Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH v4 30/45] x86: Allow logging to be used in SPL reliably

2023-07-12 Thread Bin Meng
ly. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/x86/lib/spl.c | 13 + > 1 file changed, 13 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 31/45] fs: fat: Shrink the size of a few strings

2023-07-13 Thread Bin Meng
in strings and use log_err() for messages > > fs/fat/fat.c | 20 +++- > fs/fat/fat_write.c | 14 -- > 2 files changed, 15 insertions(+), 19 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 32/45] fs: fat: Support reading from a larger block size

2023-07-13 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:02 PM Simon Glass wrote: > > At present it is not possible to read from some CDROM drives since the > FAT sector size does not match the media's block size. Add a conversion > option for this, so that reading is possible. I am completely confused. The CDROM us

Re: [PATCH v4 33/45] x86: Enable useful options for qemu-86_64

2023-07-13 Thread Bin Meng
; CONFIG_CMD_TIME=y > CONFIG_CMD_QFW=y > CONFIG_CMD_BOOTSTAGE=y > @@ -83,5 +89,7 @@ CONFIG_FRAMEBUFFER_SET_VESA_MODE=y > CONFIG_FRAMEBUFFER_VESA_MODE_USER=y > CONFIG_FRAMEBUFFER_VESA_MODE=0x144 > CONFIG_CONSOLE_SCROLL_LINES=5 > +CONFIG_FAT_BLK_XLATE=y Except this one that is in question > +# CONFIG_SPL_USE_TINY_PRINTF is not set > CONFIG_GENERATE_ACPI_TABLE=y > # CONFIG_GZIP is not set > -- Reviewed-by: Bin Meng

Re: [PATCH v4 34/45] x86: Refactor table-writing code a litlle

2023-07-13 Thread Bin Meng
_end - rom_table_start > size) { > + rom_addr, rom_table_end); > + if (rom_table_end - rom_addr > size) { > log_err("Out of space for configuration tables: need > %x, have %x\n", > -

Re: [PATCH v4 35/45] x86: Record the start and end of the tables

2023-07-13 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:02 PM Simon Glass wrote: > > The ACPI tables are special in that they are passed to EFI as a separate > piece, independent of other tables. > > Also they can be spread over two areas of memory, e.g. with QEMU we end > up with tables kept in high memory as well.

Re: [PATCH v4 36/45] x86: Show the number of physical address bits

2023-07-13 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:02 PM Simon Glass wrote: > > Add this information to global_data and show it with the 'bdinfo' command. > For now we use CONFIG_CPU_ADDR_BITS to control the number of bits, but > this could change if needed. > > Signed-off-by: Simon Glass > --- > > (no changes

Re: [PATCH v4 38/45] x86: link: Support Micron memory

2023-07-13 Thread Bin Meng
does not look good to me. I believe the right name should add a "u-boot" prefix here. > reg = <2>; > data = [92 11 0b 03 04 19 02 02 > 03 11 01 08 0a 00 fe 00 > -- Anyway, Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH v4 37/45] x86: Convert some debug statements to use logging

2023-07-13 Thread Bin Meng
unc__, ret); > + log_debug("Could not locate SPD (err=%d)\n", ret); > return ret; > } > > diff --git a/arch/x86/lib/mrccache.c b/arch/x86/lib/mrccache.c > index 2f6f6880003e..6494b8d26341 100644 > --- a/arch/x86/lib/mrccache.c

Re: [PATCH v4 39/45] x86: Make sure that the LPC is active before SDRAM init

2023-07-13 Thread Bin Meng
ass > --- > > (no changes since v2) > > Changes in v2: > - Add new patch to make sure that the LPC is active before SDRAM init > > arch/x86/lib/spl.c | 9 + > 1 file changed, 9 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 40/45] log: Support outputing function names in SPL

2023-07-13 Thread Bin Meng
t outputing function names in SPL > > common/log_console.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 41/45] sandbox: Correct header order in board file

2023-07-13 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:02 PM Simon Glass wrote: > > Fix the header order in this file. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > board/sandbox/sandbox.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 42/45] sandbox: Install ACPI tables on startup

2023-07-13 Thread Bin Meng
x.c | 16 > 1 file changed, 16 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v4 43/45] efi: Use the installed ACPI tables

2023-07-13 Thread Bin Meng
n v4: > - Drop patch "video: Allow building video drivers for SPL" > > Changes in v2: > - Drop patch to set high bits of the mtrr base register, for now > > lib/efi_loader/efi_acpi.c | 33 +++-- > 1 file changed, 19 insertions(+), 14 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v4 44/45] x86: video: Add a driver for QEMU bochs emulation

2023-07-13 Thread Bin Meng
123 + > drivers/video/bochs.h | 36 > 4 files changed, 190 insertions(+) > create mode 100644 drivers/video/bochs.c > create mode 100644 drivers/video/bochs.h > Reviewed-by: Bin Meng

Re: [PATCH v4 45/45] x86: Switch QEMU over to use the bochs driver

2023-07-13 Thread Bin Meng
> @@ -54,9 +54,6 @@ CONFIG_NVME_PCI=y > CONFIG_SYS_NS16550_PORT_MAPPED=y > CONFIG_SPI=y > CONFIG_USB_KEYBOARD=y > -CONFIG_FRAMEBUFFER_SET_VESA_MODE=y > -CONFIG_FRAMEBUFFER_VESA_MODE_USER=y > -CONFIG_FRAMEBUFFER_VESA_MODE=0x144 > CONFIG_CONSOLE_SCROLL_LINES=5 > CONFIG_GENERATE_ACPI_TABLE=y > # CONFIG_GZIP is not set > -- Otherwise, Reviewed-by: Bin Meng

Re: [PATCH v3 00/18] bootstd: Add a bootmeth for ChromiumOS on x86

2023-07-13 Thread Bin Meng
On Wed, Jul 12, 2023 at 11:04 PM Simon Glass wrote: > > This series adds a simple bootmeth for ChromiumOS on x86. It uses zimage > to boot the kernel. > > Full verified boot is not included at this stage - that is still a > separate chunk of code to be brought into standard boot at some point. > F

Re: [PATCH] bootstd: Correct 'bpot' typo

2023-07-13 Thread Bin Meng
On Thu, Jul 13, 2023 at 8:14 PM Julien Delbergue wrote: > > Fix it to 'boot' in the header, as it is in the source file. > > Signed-off-by: Julien Delbergue > --- > include/bootstd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCHv2 1/2] CI: Update to QEMU 8.0.3

2023-07-13 Thread Bin Meng
On Thu, Jul 13, 2023 at 10:16 PM Tom Rini wrote: > > Move up to the latest tagged release of QEMU > > Signed-off-by: Tom Rini > --- > Changes in v2: > - Drop --enable-slirp, per Bin > --- > tools/docker/Dockerfile | 5 ++--- > 1 file changed, 2 insertions(+), 3 de

Re: [PATCH 1/1] doc: riscv: running SiFive Unleashed image in QEMU

2023-07-13 Thread Bin Meng
On Thu, Jul 13, 2023 at 9:28 PM Heinrich Schuchardt wrote: > > Describe how to run the SiFive Unleashed image in QEMU. > > Signed-off-by: Heinrich Schuchardt > --- > doc/board/sifive/unleashed.rst | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/doc/board/sifive/unleashed.rs

Re: [PATCH v3 00/18] bootstd: Add a bootmeth for ChromiumOS on x86

2023-07-14 Thread Bin Meng
Hi Simon, On Thu, Jul 13, 2023 at 9:14 PM Bin Meng wrote: > > On Wed, Jul 12, 2023 at 11:04 PM Simon Glass wrote: > > > > This series adds a simple bootmeth for ChromiumOS on x86. It uses zimage > > to boot the kernel. > > > > Full verified boot is not incl

Re: [PATCH v4 32/45] fs: fat: Support reading from a larger block size

2023-07-16 Thread Bin Meng
Hi Simon, On Sun, Jul 16, 2023 at 7:42 AM Simon Glass wrote: > > Hi Bin, > > On Thu, 13 Jul 2023 at 04:49, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Jun 19, 2023 at 8:02 PM Simon Glass wrote: > > > > > > At present it is not possi

Re: [PATCH v3 00/18] bootstd: Add a bootmeth for ChromiumOS on x86

2023-07-16 Thread Bin Meng
Hi Tom and Simon, On Sun, Jul 16, 2023 at 7:40 AM Simon Glass wrote: > > Hi Tom, > > On Fri, 14 Jul 2023 at 11:29, Tom Rini wrote: > > > > On Fri, Jul 14, 2023 at 05:29:40PM +0800, Bin Meng wrote: > > > Hi Simon, > > > > > > On Thu, Jul 13,

Re: [PATCH v3 00/18] bootstd: Add a bootmeth for ChromiumOS on x86

2023-07-16 Thread Bin Meng
Hi Simon, On Mon, Jul 17, 2023 at 10:16 AM Simon Glass wrote: > > Hi Tom and Bin, > > I've already sent a patch in the new series that fixes bdinfo. Please take a > look. > Are these sandbox failures regressions? Or issues introduced in your series? If the latter, I think we should squash the

Re: [PATCH v5 01/46] bdinfo: Add tests for serial settings

2023-07-16 Thread Bin Meng
Hi Simon, On Sun, Jul 16, 2023 at 11:39 AM Simon Glass wrote: > > Since the original patch was written, tests have been added for the > 'bdinfo' command. Add the missing pieces so that the tests pass. > > Signed-off-by: Simon Glass > Fixes: 68130503fbd ("bdinfo: Show information about the serial

Re: [PATCH v5 09/46] x86: Show the CPU physical address size with bdinfo

2023-07-16 Thread Bin Meng
On Sun, Jul 16, 2023 at 11:39 AM Simon Glass wrote: > > This is useful information so show it with the bdinfo command. > > Signed-off-by: Simon Glass > --- > > Changes in v5: > - Adjust the prompt for clarity (although it is now >12 chars) > Reviewed-by: Bin Meng

Re: [PATCH v5 10/46] x86: Correct get_sp() implementation for 64-bit

2023-07-16 Thread Bin Meng
/x86/lib/bootm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v5 15/46] qfw: Show the file address if available

2023-07-16 Thread Bin Meng
n file. > > Signed-off-by: Simon Glass > --- > > Changes in v5: > - Drop extra 'qfw list' line > - Update commit message to explain 'md' reference > > cmd/qfw.c | 2 +- > doc/usage/cmd/qfw.rst | 27 +++++++---- > 2 files changed, 16 insertions(+), 13 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v5 16/46] log: Tidy up an ambiguous comment

2023-07-16 Thread Bin Meng
op extra 'a' in commit message > > common/log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v5 23/46] pci: Allow the video BIOS to work in SPL with QEMU

2023-07-16 Thread Bin Meng
Hi Simon, On Sun, Jul 16, 2023 at 11:39 AM Simon Glass wrote: > > QEMU emulates two common machines (Q35 and i440fx) which use mapping to > determine whether RAM is present below 1MB. In order to copy the video > BIOS to c we need to flip this mapping over to RAM. This does not > happen autom

Re: [PATCH v5 27/46] x86: Ensure SPL banner is only shown once

2023-07-16 Thread Bin Meng
ch causes tests to fail. > > Signed-off-by: Simon Glass > --- > > Changes in v5: > - Split out banner code into a separate patch > > arch/x86/lib/spl.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v5 28/46] x86: Init video in SPL if enabled

2023-07-16 Thread Bin Meng
ff-by: Simon Glass > --- > > Changes in v5: > - Drop code to ensure the SPL banner is only shown once > > arch/x86/lib/spl.c | 9 + > 1 file changed, 9 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v5 29/46] pci: Adjust video BIOS debugging to be SPL-friendly

2023-07-16 Thread Bin Meng
"done\n"); > #endif > } > - debug("Final vesa mode %#x\n", mode_info.video_mode); > + debug("Final vesa mode %x\n", mode_info.video_mode); Missing adding "0x" here? > ret = 0; > > err: > -- Reviewed-by: Bin Meng

Re: [PATCH v5 37/46] x86: Record the start and end of the tables

2023-07-17 Thread Bin Meng
> arch/sandbox/include/asm/global_data.h | 4 > arch/x86/include/asm/global_data.h | 4 > arch/x86/lib/bdinfo.c | 4 > arch/x86/lib/tables.c | 20 +++- > drivers/misc/qfw.c | 9 + > 5 files changed, 40 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v5 00/46] x86: Use qemu-x86_64 to boot EFI installers

2023-07-17 Thread Bin Meng
Hi Simon, On Sun, Jul 16, 2023 at 11:39 AM Simon Glass wrote: > > This series adds various minor features so that qemu-x86_64 can boot the > Ubuntu 2022.04 installer using a virtio device: > > qemu-system-x86_64 -M pc -drive format=raw,file=root.img > -bios /tmp/b/qemu-x86_64/u-boot.r

  1   2   3   4   5   6   7   8   9   10   >