[PATCH 0/3] Add MRMAC driver support

2021-06-23 Thread Ashok Reddy Soma
× 25GE 4 × 10GE Currently added support and tested below configurations in the driver: 4 × 25GE 4 × 10GE Ashok Reddy Soma (3): net: ethtool: Add ethernet speed macros for higher speeds net: xilinx: axi_mrmac: Add MRMAC driver xilinx: versal: Enable Xilinx AXI MRMAC MAINTAINERS

[PATCH 2/3] net: xilinx: axi_mrmac: Add MRMAC driver

2021-06-23 Thread Ashok Reddy Soma
and 25G on all 4 ports. Signed-off-by: Ashok Reddy Soma --- MAINTAINERS| 1 + drivers/net/Kconfig| 9 + drivers/net/Makefile | 1 + drivers/net/xilinx_axi_mrmac.c | 525 + drivers/net/xilinx_axi_mrmac.h | 192

RE: [PATCH 2/3] net: xilinx: axi_mrmac: Add MRMAC driver

2021-06-28 Thread Ashok Reddy Soma
Hi Simon, Thanks for the review. I will address the review points and send V2. Thanks, Ashok > -Original Message- > From: Simon Glass > Sent: Sunday, June 27, 2021 12:02 AM > To: Ashok Reddy Soma > Cc: U-Boot Mailing List ; Joe Hershberger > ; Ramon Fried ; Mi

RE: [PATCH 0/2] Add support for 10G/25G to AXI emac driver

2021-06-28 Thread Ashok Reddy Soma
> -Original Message- > From: Ramon Fried > Sent: Monday, June 28, 2021 10:43 PM > To: Michal Simek ; Simon Glass > Cc: Ashok Reddy Soma ; U-Boot Mailing List b...@lists.denx.de>; Joe Hershberger ; Michal > Simek ; git ; > somaashokre...@gmail.com > Subject:

[PATCH v2 1/3] net: ethtool: Add ethernet speed macros for higher speeds

2021-07-02 Thread Ashok Reddy Soma
Add speed macro's for higher ethernet speeds to be used in u-boot networking drivers. Added Macros for speeds 14G, 20G, 25G, 40G, 50G, 56G, 100G and 200G inline with linux. Signed-off-by: Ashok Reddy Soma Reviewed-by: Simon Glass Acked-by: Ramon Fried --- (no changes since v1) include/

[PATCH v2 3/3] xilinx: versal: Enable Xilinx AXI MRMAC

2021-07-02 Thread Ashok Reddy Soma
Enable Xilinx AXI MRMAC for Versal platforms. Signed-off-by: Ashok Reddy Soma Reviewed-by: Simon Glass --- (no changes since v1) configs/xilinx_versal_virt_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/xilinx_versal_virt_defconfig b/configs

[PATCH v2 0/3] Add MRMAC driver support

2021-07-02 Thread Ashok Reddy Soma
stead of 1 or -1 - Changed return type of isrxready() from int to bool - Changed all printf's to log_warning, and debug to log_debug - Added function headers with desciption - Changed all capital hex numbers to small hex numbers Ashok Reddy Soma (3): net: ethtool: Add ethernet speed

[PATCH v2 2/3] net: xilinx: axi_mrmac: Add MRMAC driver

2021-07-02 Thread Ashok Reddy Soma
and 25G on all 4 ports. Signed-off-by: Ashok Reddy Soma --- Changes in v2: - Changed all static allocations to dynamic and freed them. - Used setbits_le32 and clrbits_le32 wherever applicable - All return's are changed to proper error codes instead of 1 or -1 - Changed return type of isrx

[PATCH v2 2/3] net: xilinx: axi_mrmac: Add MRMAC driver

2021-07-02 Thread Ashok Reddy Soma
and 25G on all 4 ports. Signed-off-by: Ashok Reddy Soma --- Changes in v2: - Changed all static allocations to dynamic and freed them. - Used setbits_le32 and clrbits_le32 wherever applicable - All return's are changed to proper error codes instead of 1 or -1 - Changed return type of isrx

[PATCH v3 0/3] Add MRMAC driver support

2021-07-02 Thread Ashok Reddy Soma
d function headers with desciption - Changed all capital hex numbers to small hex numbers Ashok Reddy Soma (3): net: ethtool: Add ethernet speed macros for higher speeds net: xilinx: axi_mrmac: Add MRMAC driver xilinx: versal: Enable Xilinx AXI MRMAC MAINTAINERS

[PATCH v3 1/3] net: ethtool: Add ethernet speed macros for higher speeds

2021-07-02 Thread Ashok Reddy Soma
Add speed macro's for higher ethernet speeds to be used in u-boot networking drivers. Added Macros for speeds 14G, 20G, 25G, 40G, 50G, 56G, 100G and 200G inline with linux. Signed-off-by: Ashok Reddy Soma Reviewed-by: Simon Glass Acked-by: Ramon Fried --- (no changes since v1) include/

[PATCH v3 3/3] xilinx: versal: Enable Xilinx AXI MRMAC

2021-07-02 Thread Ashok Reddy Soma
Enable Xilinx AXI MRMAC for Versal platforms. Signed-off-by: Ashok Reddy Soma Reviewed-by: Simon Glass --- (no changes since v1) configs/xilinx_versal_virt_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/xilinx_versal_virt_defconfig b/configs

[PATCH v3 2/3] net: xilinx: axi_mrmac: Add MRMAC driver

2021-07-02 Thread Ashok Reddy Soma
and 25G on all 4 ports. Signed-off-by: Ashok Reddy Soma --- Changes in v3: - In V2 by mistake changed return type of isrxready() of xilinx_axi_emac driver instead of xilinx_axi_mrmac driver. Fixed it in V3. Changes in v2: - Changed all static allocations to dynamic and freed them. - Used

Re: [PATCH v2 2/3] net: xilinx: axi_mrmac: Add MRMAC driver

2021-07-02 Thread Ashok Reddy Soma
Please drop this patch V2 2/3. Will send updated one. Apologies for the trouble. On Fri, Jul 2, 2021, 3:51 PM Ashok Reddy Soma wrote: > Add support for xilinx multirate(MRMAC) ethernet driver. > This driver uses multichannel DMA(MCDMA) for data transfers of MRMAC. > Added support for 4

[PATCH 2/6] mmc: zynq_sdhci: Allow configuring zero Tap values

2021-07-09 Thread Ashok Reddy Soma
values and in this case u-boot has to re-configure required tap values(including zero) based on the operating mode. Signed-off-by: Ashok Reddy Soma --- drivers/mmc/zynq_sdhci.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/mmc/zynq_sdhci.c b

[PATCH 4/6] mmc: zynq_sdhci: Split set_tapdelay function to in and out

2021-07-09 Thread Ashok Reddy Soma
vice-versa. Restrict tap_delay value calculated to max allowed 8 bits for ITAP and 6 bits for OTAP for ZynqMP. Signed-off-by: Ashok Reddy Soma --- board/xilinx/zynqmp/tap_delays.c | 73 +--- drivers/mmc/zynq_sdhci.c | 10 - include/zynqmp_tap_delay.h

[PATCH 5/6] mmc: zynq_sdhci: Fix kernel doc warnings

2021-07-09 Thread Ashok Reddy Soma
_set_phase' drivers/mmc/zynq_sdhci.c:467: warning: contents before sections Signed-off-by: Michal Simek Signed-off-by: Ashok Reddy Soma --- drivers/mmc/zynq_sdhci.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/mmc/zynq_sdhci.c

[PATCH 6/6] mmc: zynq_sdhci: Make variables/structure static

2021-07-09 Thread Ashok Reddy Soma
drivers/mmc/zynq_sdhci.c:546:24: warning: symbol 'arasan_ops' was not declared. Should it be static? Signed-off-by: Michal Simek Signed-off-by: Ashok Reddy Soma --- drivers/mmc/zynq_sdhci.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 1/6] mmc: zynq_sdhci: Resolve uninitialized return value

2021-07-09 Thread Ashok Reddy Soma
set_phase() functions are not modifying the ret value and returning the same uninitialized ret, return 0 instead. Signed-off-by: Ashok Reddy Soma --- drivers/mmc/zynq_sdhci.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/mmc/zynq_sdhci.c

[PATCH 0/6] This patch set fixes minor issues related to tapdelays

2021-07-09 Thread Ashok Reddy Soma
local structures as static structures Ashok Reddy Soma (4): mmc: zynq_sdhci: Resolve uninitialized return value mmc: zynq_sdhci: Allow configuring zero Tap values mmc: zynq_sdhci: Use Mask writes for Tap delays mmc: zynq_sdhci: Split set_tapdelay function to in and out Michal Simek (2):

[PATCH 3/6] mmc: zynq_sdhci: Use Mask writes for Tap delays

2021-07-09 Thread Ashok Reddy Soma
Restrict tap_delay value to the allowed size(8bits for itap and 6 bits for otap) before writing to the tap delay register. Clear ITAP and OTAP delay bits before updating with the new tap value for Versal platform. Signed-off-by: Ashok Reddy Soma --- drivers/mmc/zynq_sdhci.c | 58

RE: [PATCH 1/6] mmc: zynq_sdhci: Resolve uninitialized return value

2021-07-09 Thread Ashok Reddy Soma
Hi Jaehoon, > -Original Message- > From: Jaehoon Chung > Sent: Friday, July 9, 2021 3:08 PM > To: Ashok Reddy Soma ; u-boot@lists.denx.de > Cc: peng@nxp.com; git ; mon...@monstr.eu; > somaashokre...@gmail.com > Subject: Re: [PATCH 1/6] mmc: zynq_sdhci: Resolve

RE: [PATCH 5/6] mmc: zynq_sdhci: Fix kernel doc warnings

2021-07-09 Thread Ashok Reddy Soma
Hi Jaehoon, > -Original Message- > From: Jaehoon Chung > Sent: Friday, July 9, 2021 3:12 PM > To: Ashok Reddy Soma ; u-boot@lists.denx.de > Cc: peng@nxp.com; git ; mon...@monstr.eu; > somaashokre...@gmail.com; Michal Simek > Subject: Re: [PATCH 5/6] mmc: zynq_

[PATCH v2 1/6] mmc: zynq_sdhci: Resolve uninitialized return value

2021-07-09 Thread Ashok Reddy Soma
set_phase() functions are not modifying the ret value and returning the same uninitialized ret, return 0 instead. Signed-off-by: Ashok Reddy Soma --- Changes in v2: - Changed "@degree" to "@degrees:" in function descriptions of tap delay functions drivers/m

[PATCH v2 5/6] mmc: zynq_sdhci: Fix kernel doc warnings

2021-07-09 Thread Ashok Reddy Soma
sections drivers/mmc/zynq_sdhci.c:467: warning: contents before sections Signed-off-by: Michal Simek Signed-off-by: Ashok Reddy Soma --- Changes in v2: - Removed @degree warning from commit description since it is fixed in patch 1/6. drivers/mmc/zynq_sdhci.c | 20 ++-- 1

[PATCH v2 2/6] mmc: zynq_sdhci: Allow configuring zero Tap values

2021-07-09 Thread Ashok Reddy Soma
values and in this case u-boot has to re-configure required tap values(including zero) based on the operating mode. Signed-off-by: Ashok Reddy Soma --- (no changes since v1) drivers/mmc/zynq_sdhci.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH v2 0/6] This patch set fixes minor issues related to tapdelays

2021-07-09 Thread Ashok Reddy Soma
local structures as static structures Changes in v2: - Changed "@degree" to "@degrees:" in function descriptions of tap delay functions - Removed @degree warning from commit description since it is fixed in patch 1/6. Ashok Reddy Soma (4): mmc: zynq_sdhci: Resolve uniniti

RE: [PATCH v2] spi: zynqmp_gqspi: support dual and quad mode

2021-02-03 Thread Ashok Reddy Soma
Reviewed-by: Ashok Reddy Soma > -Original Message- > From: Brandon Maier > Sent: Wednesday, January 20, 2021 10:10 PM > To: u-boot@lists.denx.de > Cc: bmeng...@gmail.com; Brandon Maier > ; ja...@amarulasolutions.com; Michal > Simek ; Ashok Reddy Soma >

[PATCH v2 3/6] mmc: zynq_sdhci: Use Mask writes for Tap delays

2021-07-09 Thread Ashok Reddy Soma
Restrict tap_delay value to the allowed size(8bits for itap and 6 bits for otap) before writing to the tap delay register. Clear ITAP and OTAP delay bits before updating with the new tap value for Versal platform. Signed-off-by: Ashok Reddy Soma --- (no changes since v1) drivers/mmc

[PATCH v2 6/6] mmc: zynq_sdhci: Make variables/structure static

2021-07-09 Thread Ashok Reddy Soma
drivers/mmc/zynq_sdhci.c:546:24: warning: symbol 'arasan_ops' was not declared. Should it be static? Signed-off-by: Michal Simek Signed-off-by: Ashok Reddy Soma --- (no changes since v1) drivers/mmc/zynq_sdhci.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) d

[PATCH v2 4/6] mmc: zynq_sdhci: Split set_tapdelay function to in and out

2021-07-09 Thread Ashok Reddy Soma
vice-versa. Restrict tap_delay value calculated to max allowed 8 bits for ITAP and 6 bits for OTAP for ZynqMP. Signed-off-by: Ashok Reddy Soma --- (no changes since v1) board/xilinx/zynqmp/tap_delays.c | 73 +--- drivers/mmc/zynq_sdhci.c | 10 - include

RE: [PATCH 1/6] mmc: zynq_sdhci: Resolve uninitialized return value

2021-07-09 Thread Ashok Reddy Soma
Hi Jaehoon, > -Original Message- > From: Jaehoon Chung > Sent: Friday, July 9, 2021 4:21 PM > To: Ashok Reddy Soma ; u-boot@lists.denx.de > Cc: peng@nxp.com; git ; mon...@monstr.eu; > somaashokre...@gmail.com > Subject: Re: [PATCH 1/6] mmc: zynq_sdhci: Resolve

RE: [PATCH v2 3/6] mmc: zynq_sdhci: Use Mask writes for Tap delays

2021-07-09 Thread Ashok Reddy Soma
HI Michal, > -Original Message- > From: Michal Simek > Sent: Friday, July 9, 2021 4:37 PM > To: Ashok Reddy Soma ; u-boot@lists.denx.de > Cc: peng@nxp.com; jh80.ch...@samsung.com; git ; > mon...@monstr.eu; somaashokre...@gmail.com > Subject: Re: [PATCH v2 3/6]

RE: [PATCH v2 1/6] mmc: zynq_sdhci: Resolve uninitialized return value

2021-07-09 Thread Ashok Reddy Soma
Hi Michal, > -Original Message- > From: Michal Simek > Sent: Friday, July 9, 2021 4:35 PM > To: Ashok Reddy Soma ; u-boot@lists.denx.de > Cc: peng@nxp.com; jh80.ch...@samsung.com; git ; > mon...@monstr.eu; somaashokre...@gmail.com > Subject: Re: [PATCH v2

[PATCH v3 0/6] This patch set fixes minor issues related to tapdelays

2021-07-09 Thread Ashok Reddy Soma
in function descriptions of tap delay functions - Removed @degree warning from commit description since it is fixed in patch 1/6. Ashok Reddy Soma (4): mmc: zynq_sdhci: Resolve uninitialized return value mmc: zynq_sdhci: Allow configuring zero Tap values mmc: zynq_sdhci: Use Mask writ

[PATCH v3 4/6] mmc: zynq_sdhci: Split set_tapdelay function to in and out

2021-07-09 Thread Ashok Reddy Soma
vice-versa. Restrict tap_delay value calculated to max allowed 8 bits for ITAP and 6 bits for OTAP for ZynqMP. Signed-off-by: Ashok Reddy Soma --- (no changes since v1) board/xilinx/zynqmp/tap_delays.c | 73 +--- drivers/mmc/zynq_sdhci.c | 10 - include

[PATCH v3 6/6] mmc: zynq_sdhci: Make variables/structure static

2021-07-09 Thread Ashok Reddy Soma
drivers/mmc/zynq_sdhci.c:546:24: warning: symbol 'arasan_ops' was not declared. Should it be static? Signed-off-by: Michal Simek Signed-off-by: Ashok Reddy Soma --- (no changes since v1) drivers/mmc/zynq_sdhci.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) d

[PATCH v3 5/6] mmc: zynq_sdhci: Fix kernel doc warnings

2021-07-09 Thread Ashok Reddy Soma
egrees' not described in 'sdhci_versal_sampleclk_set_phase' drivers/mmc/zynq_sdhci.c:467: warning: contents before sections Signed-off-by: Michal Simek Signed-off-by: Ashok Reddy Soma --- Changes in v3: - Change "@degree" to "@degrees:" in sdhci_zynqmp_sampleclk_set_phase() and sd

[PATCH v3 2/6] mmc: zynq_sdhci: Allow configuring zero Tap values

2021-07-09 Thread Ashok Reddy Soma
values and in this case u-boot has to re-configure required tap values(including zero) based on the operating mode. Signed-off-by: Ashok Reddy Soma --- (no changes since v1) drivers/mmc/zynq_sdhci.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH v3 3/6] mmc: zynq_sdhci: Use Mask writes for Tap delays

2021-07-09 Thread Ashok Reddy Soma
Restrict tap_delay value to the allowed size(8bits for itap and 6 bits for otap) before writing to the tap delay register. Clear ITAP and OTAP delay bits before updating with the new tap value for Versal platform. Signed-off-by: Ashok Reddy Soma --- Changes in v3: - Updated macro's wit

[PATCH v3 1/6] mmc: zynq_sdhci: Resolve uninitialized return value

2021-07-09 Thread Ashok Reddy Soma
set_phase() functions are not modifying the ret value and returning the same uninitialized ret, return 0 instead. Keep the return type as int to return errors when the tapdelay's are set via xilinx_pm_request() in future. Signed-off-by: Ashok Reddy Soma --- Changes in v3: - Updated co

[PATCH] test/py: tpm2: Skip tpm pytest based on env variable

2021-07-23 Thread Ashok Reddy Soma
ariable is absent. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- test/py/tests/test_tpm2.py | 28 1 file changed, 28 insertions(+) diff --git a/test/py/tests/test_tpm2.py b/test/py/tests/test_tpm2.py index 70f906da51..bb147d4e88 100644 --- a/tes

[PATCH 0/7] Arasan sdhci driver updates

2021-07-24 Thread Ashok Reddy Soma
driver and remove tap_dealy.c and zynqmp_tap_delay.h - Change variable name from deviceid to node_id in couple of functions for consistancy - Add a workaround for sd card detect stable issue for Versal platforms - Use set_control_reg from sdhci.c Ashok Reddy Soma (4): mmc: zynq_sdhci: Use

[PATCH 3/7] mmc: zynq_sdhci: Use xilinx pm request instead of mmio_write

2021-07-24 Thread Ashok Reddy Soma
after OTAP (release DLL) to avoid issues in some cases. Also handle error return where possible. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- board/xilinx/zynqmp/tap_delays.c | 89 +++- drivers/mmc/zynq_sdhci.c | 72

[PATCH 7/7] mmc: zynq_sdhci: Use set_control_reg from sdhci.c

2021-07-24 Thread Ashok Reddy Soma
Since set_control_reg is available in sdhci.c, use it and remove arasan_sdhci_set_control_reg(). Signed-off-by: Ashok Reddy Soma --- drivers/mmc/zynq_sdhci.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc

[PATCH 2/7] zynqmp_firmware: Add zynqmp firmware related enums

2021-07-24 Thread Ashok Reddy Soma
From: T Karthik Reddy Add enums for pm node id's, pm ioctl id's, tapdelay types, dll reset types Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- include/zynqmp_firmware.h | 127 ++ 1 file changed, 127 insertions(+) diff --git

[PATCH 6/7] mmc: zynq_sdhci: Wait till sd card detect state is stable

2021-07-24 Thread Ashok Reddy Soma
nqmp platform should behave the same as Versal, but we did not encounter this issue as of now. So we are fixing it for Versal only. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- drivers/mmc/zynq_sdhci.c | 17 + 1 file changed, 17 insertions(+) diff --g

[PATCH 1/7] mmc: sdhci: Return error in case of failure

2021-07-24 Thread Ashok Reddy Soma
arasan_sdhci_set_tapdelay() and also for set_delay() in sdhci_ops structure. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- drivers/mmc/sdhci.c | 8 ++-- drivers/mmc/zynq_sdhci.c | 21 - include/sdhci.h | 2 +- 3 files changed, 23 insertions(+), 8

[PATCH 4/7] mmc: zynq_sdhci: Move setting tapdelay code to driver

2021-07-24 Thread Ashok Reddy Soma
zynqmp_tap_delay.h files. Signed-off-by: Ashok Reddy Soma --- board/xilinx/zynqmp/Makefile | 2 -- board/xilinx/zynqmp/tap_delays.c | 26 drivers/mmc/zynq_sdhci.c | 21 +++- include/zynqmp_tap_delay.h | 34 4 files

[PATCH 5/7] mmc: zynq_sdhci: Change variable deviceid to node_id

2021-07-24 Thread Ashok Reddy Soma
Change deviceid to node_id in arasan_zynqmp_dll_reset() and also in tapdelay related static inline functions to reflect proper name and for consistency. Signed-off-by: Ashok Reddy Soma --- drivers/mmc/zynq_sdhci.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

RE: [PATCH 1/7] mmc: sdhci: Return error in case of failure

2021-07-25 Thread Ashok Reddy Soma
Hi Jaehoon, Thanks for the review. > -Original Message- > From: Jaehoon Chung > Sent: Monday, July 26, 2021 3:18 AM > To: Ashok Reddy Soma ; u-boot@lists.denx.de > Cc: peng@nxp.com; faiz_ab...@ti.com; s...@chromium.org; > mich...@walle.cc; git ; mon...@monstr

[PATCH v2 2/8] mmc: sdhci: Change prototype of set_delay to return errors

2021-07-27 Thread Ashok Reddy Soma
set_delay() has return type as void. If there are any errors while setting tapdelay's it won't be able to return them. Change the prototype of set_delay() in sdhci_ops structure and return the errors from wherever it is called. Signed-off-by: Ashok Reddy Soma --- Changes in v2: - T

[PATCH v2 0/8] Arasan sdhci driver updates

2021-07-27 Thread Ashok Reddy Soma
- Remove mmc->dev->seq_ and use priv->deviceid instead - Changed return error from -EIO to -ETIMEDOUT in arasan_sdhci_probe() in card detect state stable workaround Ashok Reddy Soma (6): mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay mmc: sdhci: Change prototype of set

[PATCH v2 6/8] mmc: zynq_sdhci: Change variable deviceid to node_id

2021-07-27 Thread Ashok Reddy Soma
Change deviceid to node_id in arasan_zynqmp_dll_reset() and also in tapdelay related static inline functions to reflect proper name and for consistency. Signed-off-by: Ashok Reddy Soma --- (no changes since v1) drivers/mmc/zynq_sdhci.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH v2 3/8] zynqmp_firmware: Add zynqmp firmware related enums

2021-07-27 Thread Ashok Reddy Soma
From: T Karthik Reddy Add enums for pm node id's, pm ioctl id's, tapdelay types, dll reset types Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- (no changes since v1) include/zynqmp_firmware.h | 127 ++ 1 file changed, 127

[PATCH v2 4/8] mmc: zynq_sdhci: Use xilinx pm request instead of mmio_write

2021-07-27 Thread Ashok Reddy Soma
after OTAP (release DLL) to avoid issues in some cases. Also handle error return where possible. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- Changes in v2: - Added comment for why 1ms delay is needed between DLL assert and release - Remove mmc->dev->seq_ and us

[PATCH v2 8/8] mmc: zynq_sdhci: Use set_control_reg from sdhci.c

2021-07-27 Thread Ashok Reddy Soma
Since set_control_reg is available in sdhci.c, use it and remove arasan_sdhci_set_control_reg(). Signed-off-by: Ashok Reddy Soma --- (no changes since v1) drivers/mmc/zynq_sdhci.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/mmc

[PATCH v2 1/8] mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay

2021-07-27 Thread Ashok Reddy Soma
Change return type of arasan_sdhci_set_tapdelay() to int, to facilitate returning errors. Get return values from input and output set clock phase functions inside arasan_sdhci_set_tapdelay() and return those errors. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- Changes in

[PATCH v2 7/8] mmc: zynq_sdhci: Wait till sd card detect state is stable

2021-07-27 Thread Ashok Reddy Soma
nqmp platform should behave the same as Versal, but we did not encounter this issue as of now. So we are fixing it for Versal only. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- Changes in v2: - Changed return error from -EIO to -ETIMEDOUT in arasan_sdhci_probe() in

[PATCH v2 5/8] mmc: zynq_sdhci: Move setting tapdelay code to driver

2021-07-27 Thread Ashok Reddy Soma
zynqmp_tap_delay.h files. Signed-off-by: Ashok Reddy Soma --- (no changes since v1) board/xilinx/zynqmp/Makefile | 2 -- board/xilinx/zynqmp/tap_delays.c | 26 drivers/mmc/zynq_sdhci.c | 21 +++- include/zynqmp_tap_delay.h | 34

RE: [PATCH v2 5/8] mmc: zynq_sdhci: Move setting tapdelay code to driver

2021-07-27 Thread Ashok Reddy Soma
Reviewed-by: Jaehoon Chung Sorry, Forgot to add Reviewed-by: https://patchwork.ozlabs.org/project/uboot/patch/20210724081009.15761-5-ashok.reddy.s...@xilinx.com/ Thanks, Ashok > -Original Message- > From: Ashok Reddy Soma > Sent: Tuesday, July 27, 2021 6:07 PM >

RE: [PATCH v2 6/8] mmc: zynq_sdhci: Change variable deviceid to node_id

2021-07-27 Thread Ashok Reddy Soma
Reviewed-by: Jaehoon Chung Sorry, Forgot to add Reviewed-by: https://patchwork.ozlabs.org/project/uboot/patch/20210724081009.15761-6-ashok.reddy.s...@xilinx.com/ Thanks, Ashok > -Original Message- > From: Ashok Reddy Soma > Sent: Tuesday, July 27, 2021 6:07 PM >

RE: [PATCH v2 8/8] mmc: zynq_sdhci: Use set_control_reg from sdhci.c

2021-07-27 Thread Ashok Reddy Soma
Reviewed-by: Jaehoon Chung Sorry, Forgot to add Reviewed-by: https://patchwork.ozlabs.org/project/uboot/patch/20210724081009.15761-8-ashok.reddy.s...@xilinx.com/ Thanks, Ashok > -Original Message- > From: Ashok Reddy Soma > Sent: Tuesday, July 27, 2021 6:07 PM >

RE: [PATCH] mmc: Add support for enumerating MMC card in a given mode using mmc command

2021-07-29 Thread Ashok Reddy Soma
eng > ; Patrick Delaunay ; > Pragnesh Patel ; Frédéric Danis > ; Reuben Dowle ; > Yangbo Lu ; Stefan Bosch ; Ashok > Reddy Soma ; Nicolas Saenz Julienne > ; Pali Rohár ; u-boot@lists.denx.de > Subject: [PATCH] mmc: Add support for enumerating MMC card in a given > mode using

RE: [PATCH] mmc: Add support for enumerating MMC card in a given mode using mmc command

2021-07-29 Thread Ashok Reddy Soma
HI Aswath, > -Original Message- > From: Aswath Govindraju > Sent: Friday, July 30, 2021 10:41 AM > To: Ashok Reddy Soma > Cc: Lokesh Vutla ; Vignesh Raghavendra > ; Kishon Vijay Abraham I ; Peng Fan > ; Jaehoon Chung ; Simon > Glass ; Heinrich Schuchardt ; Bin &

[PATCH v3 0/7] Arasan sdhci driver updates

2021-07-30 Thread Ashok Reddy Soma
om -EIO to -ETIMEDOUT in arasan_sdhci_probe() in card detect state stable workaround Ashok Reddy Soma (5): mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay mmc: sdhci: Change prototype of set_delay to return errors mmc: zynq_sdhci: Add xilinx_pm_request() method to set tapdelays mmc:

[PATCH v3 3/7] zynqmp_firmware: Add zynqmp firmware related enums

2021-07-30 Thread Ashok Reddy Soma
From: T Karthik Reddy Add enums for pm node id's, pm ioctl id's, tapdelay types, dll reset types Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- (no changes since v1) include/zynqmp_firmware.h | 127 ++ 1 file changed, 127

[PATCH v3 2/7] mmc: sdhci: Change prototype of set_delay to return errors

2021-07-30 Thread Ashok Reddy Soma
set_delay() has return type as void. If there are any errors while setting tapdelay's it won't be able to return them. Change the prototype of set_delay() in sdhci_ops structure and return the errors from wherever it is called. Signed-off-by: Ashok Reddy Soma --- (no changes since v2

[PATCH v3 1/7] mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay

2021-07-30 Thread Ashok Reddy Soma
Change return type of arasan_sdhci_set_tapdelay() to int, to facilitate returning errors. Get return values from input and output set clock phase functions inside arasan_sdhci_set_tapdelay() and return those errors. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- Changes in

[PATCH v3 4/7] mmc: zynq_sdhci: Add xilinx_pm_request() method to set tapdelays

2021-07-30 Thread Ashok Reddy Soma
DLL resets in regular flow(EL2). Host driver should explicitly request DLL reset before ITAP (assert DLL) and after OTAP (release DLL) to avoid issues in some cases. Also handle error return where possible. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- Changes in v3: - As

[PATCH v3 5/7] mmc: zynq_sdhci: Move setting tapdelay code to driver

2021-07-30 Thread Ashok Reddy Soma
Move tapdelay function calls to zynq_sdhci.c and make them static inline. zynqmp_tap_delay.h has function prototypes for the functions defined in tap_delays.c, which will not be needed anymore. Remove tap_delays.c and zynqmp_tap_delay.h files. Signed-off-by: Ashok Reddy Soma --- Changes in v3

[PATCH v3 6/7] mmc: zynq_sdhci: Wait till sd card detect state is stable

2021-07-30 Thread Ashok Reddy Soma
nqmp platform should behave the same as Versal, but we did not encounter this issue as of now. So we are fixing it for Versal only. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- (no changes since v2) Changes in v2: - Changed return error from -EIO to -ETIMEDOU

[PATCH v3 7/7] mmc: zynq_sdhci: Use set_control_reg from sdhci.c

2021-07-30 Thread Ashok Reddy Soma
Since set_control_reg is available in sdhci.c, use it and remove arasan_sdhci_set_control_reg(). Signed-off-by: Ashok Reddy Soma Reviewed-by: Jaehoon Chung --- (no changes since v1) drivers/mmc/zynq_sdhci.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff

RE: [PATCH 2/7] mmc: zynq_sdhci: Define timing macro's

2020-06-10 Thread Ashok Reddy Soma
Hi Faiz, > -Original Message- > From: Faiz Abbas > Sent: Wednesday, May 27, 2020 12:28 PM > To: Jaehoon Chung ; Michal Simek > ; u-boot@lists.denx.de; git > Cc: Ashok Reddy Soma ; Heinrich Schuchardt > ; Lokesh Vutla ; Marek Vasut > ; Masahiro Yamada ; &g

RE: [PATCH 2/7] mmc: zynq_sdhci: Define timing macro's

2020-06-10 Thread Ashok Reddy Soma
Hi Jaehoon, > -Original Message- > From: Jaehoon Chung > Sent: Wednesday, June 10, 2020 4:07 PM > To: Ashok Reddy Soma ; Faiz Abbas > ; Michal Simek ; u- > b...@lists.denx.de; git > Cc: Heinrich Schuchardt ; Lokesh Vutla > ; Marek Vasut ; Masahiro > Yamada ;

[PATCH] mmc: zynq_sdhci: Fix timing macros for MMC High speed

2022-06-27 Thread Ashok Reddy Soma
Timing macro's are wrong for MMC_HS_52 and MMC_DDR_52. Fix it with correct values of MMC_TIMING_MMC_HS and MMC_TIMING_MMC_DDR52 respectively. Signed-off-by: Ashok Reddy Soma --- drivers/mmc/zynq_sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH 0/5] Enable power domain driver in ZynqMP and Versal

2022-07-15 Thread Ashok Reddy Soma
request for node of the IP's based on DT. - Load pmufw config object dynamically based on DT. Ashok Reddy Soma (5): firmware: zynqmp: Change prototype of zynqmp_pmufw_load_config_object() firmware: zynqmp: Load config overlay for core0 to pmufw arm64: zynqmp: Enable power d

[PATCH 1/5] firmware: zynqmp: Change prototype of zynqmp_pmufw_load_config_object()

2022-07-15 Thread Ashok Reddy Soma
zynqmp_pmufw_load_config_object() has some error cases and it is better to return those errors. Change prototype of this function to return errors. Signed-off-by: Ashok Reddy Soma --- drivers/firmware/firmware-zynqmp.c | 8 +--- include/zynqmp_firmware.h | 2 +- 2 files changed, 6

[PATCH 2/5] firmware: zynqmp: Load config overlay for core0 to pmufw

2022-07-15 Thread Ashok Reddy Soma
Try loading pmufw config overlay for core0, if it doesn't return any error it means pmufw is accepting nodes for other IP's. Otherwise dont try to load config object for any other IP, just return from zynqmp_pmufw_node function. Signed-off-by: Ashok Reddy Soma --- drivers/firmwar

[PATCH 3/5] arm64: zynqmp: Enable power domain driver

2022-07-15 Thread Ashok Reddy Soma
Enable power domain driver to configure pmufw config object and request node for all the IP's that are enabled in DT. Signed-off-by: Ashok Reddy Soma --- configs/xilinx_zynqmp_virt_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/xilinx_zynqmp_virt_defconfig b/co

[PATCH 4/5] mailbox: zynqmp: Move struct zynqmp_ipi_msg from sys_proto.h

2022-07-15 Thread Ashok Reddy Soma
Mailbox driver might be need for Versal and other future platforms. To remove the dependency, move struct zynqmp_ipi_msg to zynqmp_firmware.h so that mailbox driver compiles for other platforms easily. Signed-off-by: Ashok Reddy Soma --- arch/arm/mach-zynqmp/include/mach/sys_proto.h | 5

[PATCH 5/5] arm64: versal: Enable power domain driver and its dependencies

2022-07-15 Thread Ashok Reddy Soma
ff-by: Ashok Reddy Soma --- configs/xilinx_versal_virt_defconfig | 4 drivers/mailbox/Kconfig | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configs/xilinx_versal_virt_defconfig b/configs/xilinx_versal_virt_defconfig index 0419992be4..a2d4debbf5 100644

[PATCH 0/4] Xilinx zynq_qspi updates

2022-07-15 Thread Ashok Reddy Soma
This patch series does below things - Add child preprobe function - Use dummy buswidth in dummy byte calculation - Add support for zynq_qspi_mem_exec_op - Fix qspi speed issue Ashok Reddy Soma (2): spi: zynq_qspi: Add support for zynq_qspi_mem_exec_op spi: zynq_qspi: Fix programming

[PATCH 1/4] spi: zynq_qspi: Add child pre probe function

2022-07-15 Thread Ashok Reddy Soma
From: Siva Durga Prasad Paladugu Add child pre probe function in the driver. Update max_hz of priv from spi_slave structure. Signed-off-by: Siva Durga Prasad Paladugu Signed-off-by: Ashok Reddy Soma --- drivers/spi/zynq_qspi.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH 2/4] spi: zynq_qspi: Use dummy buswidth in dummy byte calculation

2022-07-15 Thread Ashok Reddy Soma
From: T Karthik Reddy Fix dummy bytes calculation incase of valid dummy bytes when dummy buswidth is > 1. Current dummy bytes calculation does not provide correct dummy values for dummy buswidth > 1. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- drivers/spi/zynq_

[PATCH 3/4] spi: zynq_qspi: Add support for zynq_qspi_mem_exec_op

2022-07-15 Thread Ashok Reddy Soma
Add support_ops function zynq_qspi_mem_exec_op to check controller supported operations by spi-mem framework. Current default support ops function does not allow dummy buswidth no more than 1, unless we are using buswidth is 4 for TX. Signed-off-by: Ashok Reddy Soma --- drivers/spi/zynq_qspi.c

[PATCH 4/4] spi: zynq_qspi: Fix programming qspi speed

2022-07-15 Thread Ashok Reddy Soma
: Ashok Reddy Soma --- drivers/spi/zynq_qspi.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/spi/zynq_qspi.c b/drivers/spi/zynq_qspi.c index 52db7b3f21..00e3ffcd1d 100644 --- a/drivers/spi/zynq_qspi.c +++ b/drivers/spi/zynq_qspi.c @@ -622,15 +622,12

[PATCH v2 1/2] arm64: versal: Add qspi flash mini u-boot configuration

2022-10-12 Thread Ashok Reddy Soma
Add configuration file for mini u-boot configuration which runs on a smaller footprint from on chip memory(OCM). This configuration has required CONFIG's enabled to support qspi flash and uses DCC terminal for console output. Signed-off-by: Ashok Reddy Soma --- Changes in v2: - Removed co

[PATCH v2 0/2] Add quad & octal spi flash mini u-boot configuration files

2022-10-12 Thread Ashok Reddy Soma
g and updated mini config to align with latest Kconfig layout - Run savedefconfig and updated mini config for ospi to align with latest Kconfig layout Ashok Reddy Soma (2): arm64: versal: Add qspi flash mini u-boot configuration arm64: versal: Add octal spi flash mini u-boot configur

[PATCH v2 2/2] arm64: versal: Add octal spi flash mini u-boot configuration

2022-10-12 Thread Ashok Reddy Soma
Add configuration file for mini u-boot configuration which runs on a smaller footprint from on chip memory(OCM). This configuration has required CONFIG's enabled to support octal spi flash and uses DCC terminal for console output. Signed-off-by: Ashok Reddy Soma --- Changes in v2:

[PATCH] arm64: versal: Add support to load an app at EL1

2022-05-05 Thread Ashok Reddy Soma
Add support to switch to EL1 and load an EL1 app from U-Boot which is executing at EL2 or EL3 in aarch64 mode. Signed-off-by: Ashok Reddy Soma --- board/xilinx/versal/board.c | 17 + 1 file changed, 17 insertions(+) diff --git a/board/xilinx/versal/board.c b/board/xilinx

[PATCH] arm64: zynqmp: Add missing ZYNQMP_FIRMWARE dependencies

2023-02-01 Thread Ashok Reddy Soma
d and also sdhci and gem drivers didn't protect the code properly. So, add the missing ZYNQMP_FIRMWARE dependencies. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy Soma --- board/xilinx/zynqmp/Kconfig | 1 + drivers/clk/Kconfig | 4 ++-- drivers/fpga/Kco

[PATCH 0/3] Add quad & octal spi flash mini u-boot configuration files

2022-11-16 Thread Ashok Reddy Soma
moved configs/xilinx_* from MAINTAINERS as, it is already taken care. - Run savedefconfig and updated mini config to align with latest Kconfig layout - Run savedefconfig and updated mini config for ospi to align with latest Kconfig layout Ashok Reddy Soma (3): arm64: versal: Add qspi flash m

[PATCH 1/3] arm64: versal: Add qspi flash mini u-boot configuration

2022-11-16 Thread Ashok Reddy Soma
ff-by: Ashok Reddy Soma --- Changes in v3: - Added dts files for qspi mini configuration - Added CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xfffe to fix compilation error. Changes in v2: - Removed configs/xilinx_* from MAINTAINERS as, it is already

[PATCH 2/3] spi: cadence-qspi: Fix compilation error in mini u-boot flash reset

2022-11-16 Thread Ashok Reddy Soma
When cadence_qspi_versal_flash_reset() function is called in mini u-boot where there is no firmware support, it is missing defines for macro's BOOT_MODE_POR_0 & BOOT_MODE_POR_1. Remove them and replace with already define macro's which have same values as these. Signed-off-by: As

[PATCH 3/3] arm64: versal: Add octal spi flash mini u-boot configuration

2022-11-16 Thread Ashok Reddy Soma
ation. Signed-off-by: Ashok Reddy Soma --- Changes in v3: - Add dts files for octal flash mini u-boot. - Add below configs to fix compilation error. CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xFFFE Changes in v2: - Run savedefconfig and updated mini config for

[PATCH] mtd: spi-nor-core: Invert logic to reflect sst26 flash unlocked

2022-11-21 Thread Ashok Reddy Soma
ck to work properly. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy Soma --- drivers/mtd/spi/spi-nor-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c index 78de3c5281..1ea8363d9f 10

[PATCH] spi: zynqmp_gqspi: Update tapdelay value

2022-11-22 Thread Ashok Reddy Soma
From: T Karthik Reddy Update GQSPI_LPBK_DLY_ADJ_DLY_1 tapdelay value for Versal for frequencies above 100MHz. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- drivers/spi/zynqmp_gqspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi

[PATCH v2] spi: zynqmp_gqspi: Update tapdelay value

2022-11-23 Thread Ashok Reddy Soma
From: T Karthik Reddy The driver was using an incorrect value for GQSPI_LPBK_DLY_ADJ_DLY_1 tapdelay for Versal for frequencies above 100MHz. Change it from 2 to 1 based on the recommended value in IP spec. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- Changes in v2

[PATCH] spi: cadence-qspi: Remove condition for calling enable linear mode

2022-11-29 Thread Ashok Reddy Soma
cadence_qspi_apb_enable_linear_mode() has a weak function defined, so no need to gaurd this under if (CONFIG_IS_ENABLED(ARCH_VERSAL)). In cadence_qspi_apb_write_execute(), enable linear mode is called twice by mistake, remove extra one. Signed-off-by: Ashok Reddy Soma --- drivers/spi

<    1   2   3   >