Re: [U-Boot] [PATCH 2/4] dfu: generic backend parts

2012-01-09 Thread Andrzej Pietrasiewicz
Hello Mike, On Sunday, January 08, 2012 6:14 AM Mike Frysinger wrote: > -Original Message- > From: Mike Frysinger [mailto:vap...@gentoo.org] > Sent: Sunday, January 08, 2012 6:14 AM > To: u-boot@lists.denx.de > Cc: Andrzej Pietrasiewicz; Kyungmin Park; Marek Szyprowski &g

Re: [U-Boot] [PATCH] dfu: initial implementation

2011-11-03 Thread Andrzej Pietrasiewicz
Hello Stefan, On Wednesday, November 02, 2011 3:29 PM Stefan Shmidt wrote: > > Have you fully implemented 1.1? With the detahc logic inside the > device implementation? As you noticed in another post, the state machine is reused. > Just curious. What version of dfu-util your are using for your

Re: [U-Boot] [PATCH] dfu: initial implementation

2011-11-03 Thread Andrzej Pietrasiewicz
Hello Mike, Thank you for your review. Please see my comments inline. On Wednesday, November 02, 2011 4:16 PM Mike Frysinger wrote: > > > > Dear All, > > > > This is Device Firmware Upgrade (DFU) implementation which supports > > data upload and download function to devices which are equipped wi

Re: [U-Boot] [PATCH] dfu: initial implementation

2011-11-03 Thread Andrzej Pietrasiewicz
Hello Stefan, On Wednesday, November 02, 2011 8:30 PM Stefan Schmidt writes: > > Agreed. The eMMC flashing with files on FAT is nothing goni specific. > Others should be able to use this as well. I see three different parts > here that can be separated: I agree. Since there is interest in DFU i

Re: [U-Boot] [PATCH] dfu: initial implementation

2011-11-03 Thread Andrzej Pietrasiewicz
nst HEAD and it failed for me. Anything I miss? > Sorry about that. I forgot to mention the reference. It is http://patchwork.ozlabs.org/patch/122080 > On Wed, 2011-11-02 at 11:00, Andrzej Pietrasiewicz wrote: > > > > The implementation is split into two parts: the dfu gadget >

Re: [U-Boot] [PATCH] dfu: initial implementation

2011-11-03 Thread Andrzej Pietrasiewicz
On Thursday, November 03, 2011 11:33 AM Andrzej Pietrasiewicz wrote: > > > Sorry about that. I forgot to mention the reference. It is > http://patchwork.ozlabs.org/patch/122080 > Sorry again. I meant http://patchwork.ozlabs.org/patch/

Re: [U-Boot] [PATCH] dfu: initial implementation

2011-11-03 Thread Andrzej Pietrasiewicz
Hello Stefan, On Thursday, November 03, 2011 2:32 PM Stefan Schmidt wrote: > > > > > Sorry about that. I forgot to mention the reference. It is > > > http://patchwork.ozlabs.org/patch/122080 > > > > > Sorry again. I meant http://patchwork.ozlabs.org/patch/11122079 > > Hmm, applied this one but t

Re: [U-Boot] [PATCH] dfu: initial implementation

2011-11-03 Thread Andrzej Pietrasiewicz
Dear Wolfgang Denk, Please see my comments inline. On Thursday, November 03, 2011 7:14 PM Wolfgang Denk wrote: > > > > http://www.usb.org/developers/devclass_docs/DFU_1.1.pdf > ... DFU is part of USB; an extension to be precise, but an extension bound so tightly to the design and philosophy of

Re: [U-Boot] [PATCH] dfu: initial implementation

2011-11-04 Thread Andrzej Pietrasiewicz
Hello, On Thursday, November 03, 2011 3:01 PM Stefan Schmidt wrote: > > o I will send out my not ready for mainline patch to give you and > others an impression how it is tackled in my patch. > > o I like your split between dfu and flashing and also the addition of > the dfu command. Could

Re: [U-Boot] [PATCH] dfu: initial implementation

2011-11-07 Thread Andrzej Pietrasiewicz
Dear Wolfgang Denk, Please see my comments inline. > > > > DFU is part of USB; an extension to be precise, but an extension > bound > > so tightly to the design and philosophy of USB that it is rather > > inconceivable to separate the two. > > Could you please be so kind and explain which exact

[U-Boot] [PATCH v2 0/4] DFU initial implementation

2011-11-09 Thread Andrzej Pietrasiewicz
is to provide board_dfu_init/cleanup pair and call register_flash_entities. Andrzej Pietrasiewicz (4): dfu: protocol initial implementation dfu: generic backend parts dfu: command implementation dfu: target-specific implementation for Goni Makefile|1 + board/samsung

[U-Boot] [PATCH 1/4] dfu: protocol initial implementation

2011-11-09 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Makefile |1 + drivers/usb/gadget/dfu.c| 920 +++ drivers/usb/gadget/dfu.h| 171 include/dfu.h | 28 ++ include/flash_entity.h

[U-Boot] [PATCH 3/4] dfu: command implementation

2011-11-09 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- common/Makefile |1 + common/cmd_dfu.c | 51 +++ 2 files changed, 52 insertions(+), 0 deletions(-) create mode 100644 common/cmd_dfu.c diff --git a/common/Makefile b

[U-Boot] [PATCH 4/4] dfu: target-specific implementation for Goni

2011-11-09 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- board/samsung/goni/Makefile |2 + board/samsung/goni/flash.c | 341 +++ board/samsung/goni/flash.h | 28 board/samsung/goni/goni.c | 17 ++ include/configs/s5p_goni.h

[U-Boot] [PATCH 2/4] dfu: generic backend parts

2011-11-09 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- Makefile |1 + drivers/usb/dfu/Makefile | 33 drivers/usb/dfu/dfu.c| 109 drivers/usb/dfu/fat.c| 77 drivers