[U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

This is used for compatibility with text files which are using CRLF instead of LF as the end of a line. Signed-off-by: Alexander Holler --- lib/hashtable.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/lib/hashtable.c b/lib/hashtable.c index abd61c8

Re: [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

Am 11.05.2012 21:09, schrieb Wolfgang Denk: Dear Alexander Holler, In message<1336720486-7424-1-git-send-email-hol...@ahsoftware.de> you wrote: This is used for compatibility with text files which are using CRLF instead of LF as the end of a line. I don't think we should do th

Re: [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

Am 12.05.2012 08:17, schrieb Marek Vasut: Dear Alexander Holler, This is used for compatibility with text files which are using CRLF instead of LF as the end of a line. Signed-off-by: Alexander Holler Why don't you run the file trough dos2unix or tr -d '\r' ? Because

Re: [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

Am 12.05.2012 16:46, schrieb Marek Vasut: Dear Alexander Holler, Am 12.05.2012 08:17, schrieb Marek Vasut: Dear Alexander Holler, This is used for compatibility with text files which are using CRLF instead of LF as the end of a line. Signed-off-by: Alexander Holler Why don't you ru

Re: [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

Am 12.05.2012 18:08, schrieb Marek Vasut: > Dear Alexander Holler, > >> Am 12.05.2012 16:46, schrieb Marek Vasut: >>> Dear Alexander Holler, >>> >>>> Am 12.05.2012 08:17, schrieb Marek Vasut: >>>>> Dear Alexander Holler, >>>

Re: [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

Am 12.05.2012 20:37, schrieb Marek Vasut: Dear Alexander Holler, Am 12.05.2012 18:08, schrieb Marek Vasut: Dear Alexander Holler, Am 12.05.2012 16:46, schrieb Marek Vasut: Dear Alexander Holler, Am 12.05.2012 08:17, schrieb Marek Vasut: Dear Alexander Holler, This is used for

Re: [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

Am 12.05.2012 23:21, schrieb Wolfgang Denk: Dear Alexander Holler, In message<4faeb5c2.40...@ahsoftware.de> you wrote: In the good old days (tm) with line printers and almost endless paper from dead trees, CRLF instead only LF as line endings in text files did made sense. It still m

Re: [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

Hello, Am 12.05.2012 23:18, schrieb Wolfgang Denk: Thanks - but it adds restrictions to doing perfectly valid things. I see the disadvantages significantly bigger than what we can win - keep in mind, that dealing wqith DOS line endings is a topic that is decades old. Not dealing with them to

[U-Boot] [PATCH 1/2] Add option -r to env import to allow import of text files with CRLF as line endings

get imported without that CR. Signed-off-by: Alexander Holler --- common/cmd_nvedit.c | 17 ++--- common/env_common.c |4 ++-- include/search.h|2 +- lib/hashtable.c | 23 +++ 4 files changed, 36 insertions(+), 10 deletions(-) diff --git a/c

[U-Boot] [PATCH 2/2] beagle: handle import of environments in files with CRLF as line endings

Use the new option -r for env import. Signed-off-by: Alexander Holler --- include/configs/omap3_beagle.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h index ddeb414..d8b10c2 100644 --- a/include/configs

[U-Boot] [PATCH 1/2 v2] Add option -r to env import to allow import of text files with CRLF as line endings

get imported without that CR. Signed-off-by: Alexander Holler --- common/cmd_nvedit.c | 17 ++--- common/env_common.c |4 ++-- include/search.h|2 +- lib/hashtable.c | 17 - 4 files changed, 33 insertions(+), 7 deletions(-) diff --git a/common/c

Re: [U-Boot] [PATCH 2/2] beagle: handle import of environments in files with CRLF as line endings

On 13.05.2012 19:09, Marek Vasut wrote: Dear Alexander Holler, Use the new option -r for env import. Signed-off-by: Alexander Holler --- include/configs/omap3_beagle.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/configs/omap3_beagle.h b/include/configs

Re: [U-Boot] [PATCH 2/2] beagle: handle import of environments in files with CRLF as line endings

On 13.05.2012 20:52, Marek Vasut wrote: Dear Alexander Holler, On 13.05.2012 19:09, Marek Vasut wrote: Dear Alexander Holler, Use the new option -r for env import. Signed-off-by: Alexander Holler --- include/configs/omap3_beagle.h |2 +- 1 files changed, 1 insertions(+), 1

Re: [U-Boot] [PATCH 2/2] beagle: handle import of environments in files with CRLF as line endings

On 13.05.2012 20:57, Marek Vasut wrote: Dear Wolfgang Denk, Dear Marek Vasut, In message<201205131909.49488.marek.va...@gmail.com> you wrote: - "env import -t $loadaddr $filesize\0" \ + "env import -t -r $loadaddr $filesize\0" \ Not everyone importing env on bea

Re: [U-Boot] [PATCH 2/2] beagle: handle import of environments in files with CRLF as line endings

Am 13.05.2012 23:38, schrieb Wolfgang Denk: Dear Alexander, In message<4fb01720.90...@ahsoftware.de> you wrote: Sorry, it seems you just are unable or yiu don't want to understand the problem. So here is my last message on this topic, trying to explain it for you. I'm sorry you are giving u

Re: [U-Boot] [PATCH 2/2] beagle: handle import of environments in files with CRLF as line endings

Am 13.05.2012 23:38, schrieb Wolfgang Denk: Dear Alexander, In message<4fb01720.90...@ahsoftware.de> you wrote: What exactly are such error modes, by the way? I would expect that trailing white space is pretty much harmless for most variable settings? The problem already starts in u-boot

Re: [U-Boot] [PATCH 2/2] beagle: handle import of environments in files with CRLF as line endings

Am 14.05.2012 11:07, schrieb Alexander Holler: Am 13.05.2012 23:38, schrieb Wolfgang Denk: Dear Alexander, In message<4fb01720.90...@ahsoftware.de> you wrote: What exactly are such error modes, by the way? I would expect that trailing white space is pretty much harmless for most va

Re: [U-Boot] [PATCH 2/2] beagle: handle import of environments in files with CRLF as line endings

Am 14.05.2012 18:02, schrieb Tom Rini: On Sun, May 13, 2012 at 02:50:07PM +0200, Alexander Holler wrote: Use the new option -r for env import. Signed-off-by: Alexander Holler While I am sympathetic, the right answer is to tell users to use a text editor that can save with UNIX-style

Re: [U-Boot] [PATCH 2/2] beagle: handle import of environments in files with CRLF as line endings

On 14.05.2012 20:45, Marek Vasut wrote: Dear Alexander Holler, Am 14.05.2012 18:02, schrieb Tom Rini: On Sun, May 13, 2012 at 02:50:07PM +0200, Alexander Holler wrote: Use the new option -r for env import. Signed-off-by: Alexander Holler While I am sympathetic, the right answer is to tell

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Am 01.08.2014 14:08, schrieb Wolfgang Denk: Dear Alexander Holler, In message <1405352998-7707-2-git-send-email-hol...@ahsoftware.de> you wrote: When this option is enabled, CRLF is treated like LF when importing environments from text files, which means CRs ('\r') in front o

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Am 02.08.2014 23:09, schrieb Alexander Holler: Am 01.08.2014 14:08, schrieb Wolfgang Denk: Should we not, for reasons of symmetry, then also extend "env export" by such a "-r" option? Sorry, but I don't follow the new features of u-boot that closely. Is it al

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

ns a -r for "env export", maybe it could be added to the TODO-list which contains documentation for "env *" too. ;) Regards, Alexander Holler ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Am 04.08.2014 08:47, schrieb Alexander Holler: But it would not be really symmetric. The -r for "env import" makes "env import" eat both formats, which means it can be used almost always, but using -r with "env export" would be a decision which always would be wro

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Am 04.08.2014 12:00, schrieb Måns Rullgård: Alexander Holler writes: Why not just make "env import" treat \r like any other whitespace? It would be a slight change from current behaviour, but the chance that someone actually relies on a trailing \r being part of the value is v

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

each any possible user. So without consensus about what such a symmetry feature for "env export" should be and how it will look like I will not spend the (little) time to write a patch, nor the much large time to discuss the patch afterwards. Regards, Alexander Holler _

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Am 06.08.2014 12:02, schrieb Alexander Holler: Am 06.08.2014 08:43, schrieb Wolfgang Denk: Dear Alexander, In message <53dfdc99.2020...@ahsoftware.de> you wrote: At least I've understood it such that nobody still has an objection=20 against the new feature for "env impo

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Am 06.08.2014 12:44, schrieb Måns Rullgård: Alexander Holler writes: Am 06.08.2014 08:43, schrieb Wolfgang Denk: Dear Alexander, In message <53dfdc99.2020...@ahsoftware.de> you wrote: At least I've understood it such that nobody still has an objection=20 against the new featu

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Am 06.08.2014 13:18, schrieb Alexander Holler: Am 06.08.2014 12:44, schrieb Måns Rullgård: Alexander Holler writes: Am 06.08.2014 08:43, schrieb Wolfgang Denk: Dear Alexander, In message <53dfdc99.2020...@ahsoftware.de> you wrote: At least I've understood it such that nobody s

[U-Boot] Confusion when starting storage subsystems

nd to init the subsystem already changed at least once. So there must have been already some thoughts or discussions about that topic. Regards, Alexander Holler ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

"run uenvcmd;" \ "fi;" \ Regards, Alexander Holler ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Am 14.08.2014 17:49, schrieb Stephen Warren: On 08/14/2014 02:25 AM, Alexander Holler wrote: As I've just remembered where I did see your name before, the config for the rpi (as found in 2004.04) misses the uenvcmd. That's necessary to execute commands when using uEnv.txt. It

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Am 14.08.2014 21:51, schrieb Stephen Warren: On 08/14/2014 01:38 PM, Alexander Holler wrote: Am 14.08.2014 17:49, schrieb Stephen Warren: On 08/14/2014 02:25 AM, Alexander Holler wrote: As I've just remembered where I did see your name before, the config for the rpi (as found in 20

[U-Boot] Magically determining the correct root

h the kernel was loaded from and the following two partitions for a "/dev" and assumes that will be the correct root partition. So, assuming /dev does only exist on the root partition that little magic supports parition layouts like the following: - boot (with kernel), root, someth

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Am 14.08.2014 22:08, schrieb Stephen Warren: On 08/14/2014 01:59 PM, Alexander Holler wrote: Am 14.08.2014 21:51, schrieb Stephen Warren: On 08/14/2014 01:38 PM, Alexander Holler wrote: Am 14.08.2014 17:49, schrieb Stephen Warren: On 08/14/2014 02:25 AM, Alexander Holler wrote: As I&#x

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

fying or create a file on disk. ;) Regards, Alexander Holler ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

etter through sha1) as boot.cmd for environments where it makes sense. So in regard to "untrustworthy" sd-cards most boards. ;) Regards, Alexander Holler ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] The way the list manages patch submission

Am 04.08.2012 18:55, schrieb Karl O. Pinc: So perhaps the u-boot list default that has duplicate elimination turned on, where other lists do not, is factor contributing to the confusion. I've never had Some mail-servers have that feature enabled by default too. E.g. cyrus-imapd (called dupl

Re: [U-Boot] U-Boot Graphics Library?

Am 16.01.2013 20:46, schrieb Wolfgang Denk: Dear Simon Glass, In message you wrote: We are currently using a very rudimentary graphics features attached to U-Boot. It can only display bitmap images. We use this in Chromium to composite a display for the various screens we need to display in

[U-Boot] cc-list modified?

Am 18.01.2013 01:50, schrieb Alexander Holler: (...) Yes. Sounds nice at first, but there will be no end of features people would want afterwards. Next will be video tutorials and fancy sound. ;) (...) I've just wondered what happened to the cc-list of that mail I sent. I've send i

Re: [U-Boot] Slow tftp boot with Ubuntu 12.04 tftp server

Am 17.01.2013 12:19, schrieb David Aldrich: Hi I am using an Advantech TMX320TCI6614 EVM to develop code for an ARM core on a TI C66x device. The ARM core runs: U-Boot 2011.06-2-gc4611c1-dirty (May 30 2012 - 15:38:01) I have booted this target card for several months from a tftp server r

Re: [U-Boot] Slow tftp boot with Ubuntu 12.04 tftp server

Am 18.01.2013 11:16, schrieb David Aldrich: > >> Try setting the max. blocksize explicit, e.g. I'm using -B 1460 here. It >> depends >> on the used tftp-server. > > Hi Alexander > > Thanks for your reply. Please will you confirm the exact syntax? I tried: > > # tftp -B 1460 0x8200 tci66

Re: [U-Boot] cc-list modified?

Am 18.01.2013 04:17, schrieb Scott Wood: On 01/17/2013 07:22:57 PM, Alexander Holler wrote: Am 18.01.2013 01:50, schrieb Alexander Holler: (...) Yes. Sounds nice at first, but there will be no end of features people would want afterwards. Next will be video tutorials and fancy sound

Re: [U-Boot] U-Boot Graphics Library?

Am 18.01.2013 21:57, schrieb Simon Glass: > Hi, > > On Fri, Jan 18, 2013 at 7:47 AM, Steve Strobel > wrote: >> Maybe the USB flash drive used for recovery could contain not only the image >> to be written to flash, but also a bootable OS image used to provide >> on-screen messages during the reco

Re: [U-Boot] cc-list modified?

Am 18.01.2013 17:32, schrieb Alexander Holler: Am 18.01.2013 04:17, schrieb Scott Wood: On 01/17/2013 07:22:57 PM, Alexander Holler wrote: Am 18.01.2013 01:50, schrieb Alexander Holler: (...) Yes. Sounds nice at first, but there will be no end of features people would want afterwards. Next

Re: [U-Boot] cc-list modified?

Am 21.01.2013 19:19, schrieb Scott Wood: On 01/20/2013 08:53:05 PM, Alexander Holler wrote: Am 18.01.2013 17:32, schrieb Alexander Holler: Am 18.01.2013 04:17, schrieb Scott Wood: On 01/17/2013 07:22:57 PM, Alexander Holler wrote: Am 18.01.2013 01:50, schrieb Alexander Holler: (...) Yes

Re: [U-Boot] U-Boot Graphics Library?

Am 21.01.2013 02:29, schrieb Alexander Holler: Am 18.01.2013 21:57, schrieb Simon Glass: Hi, On Fri, Jan 18, 2013 at 7:47 AM, Steve Strobel wrote: Maybe the USB flash drive used for recovery could contain not only the image to be written to flash, but also a bootable OS image used to provide

Re: [U-Boot] [PATCH] [ARM] Convert at91 watchdog driver to new SoC access

Hello, Am 23.03.2010 16:58, schrieb Tom: > Achim Ehrlich wrote: >> This converts the at91 watchdog driver to new c structure >> type to access registers of the SoC >> >> Signed-off-by: Achim Ehrlich > > Applied to arm/next Maybe this should go to the current branch because the watchdog-driver cu

[U-Boot] [PATCH 1/2] Add AT91_ECC_BASE to at91sam9260.h to use atmel_nand with HW-ECC

--- include/asm-arm/arch-at91/at91sam9260.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/asm-arm/arch-at91/at91sam9260.h b/include/asm-arm/arch-at91/at91sam9260.h index a60a081..3bc7167 100644 --- a/include/asm-arm/arch-at91/at91sam9260.h +++ b/include/asm-arm/

[U-Boot] [PATCH 0/2] atmel_nand with HW-ECC

Hello, I've cherry-picked the patch for atmel_nand to enable HW-ECC on the master and had to apply some changes. Afterwards it seems to work on an AT91SAM9263. Thanks for that functionality. Regards, Alexander Holler ___ U-Boot mailing list U

[U-Boot] [PATCH 2/2] Fix compile errors for atmel_nand with hw-ecc and new SoC access

atmel_nand.c with HW-ECC doesn't compile with the new SoC access. Using CONFIG_AT91_LEGACY to circumvent the compile errors only leaves the driver in a state where it doesn't find the NAND. To use HW-ECC with atmel_nand one has to use CONFIG_SYS_NAND_ECC_BASE AT91_ECC0_BASE (instead of AT91_ECC0)

[U-Boot] git merge summary

Hello, may I ask if there is reason why merge commits don't have a summary? I find those summaries (enabled with git config [--global] merge.summary true) very hand to see what was changed with the merge commit. Regards, Alexander ___ U-Boot mailing

[U-Boot] [PATCH 0/2] at91sam9x: driver to use the internal RTT as RTC

AT91SAM9261 */ #define CONFIG_RTC_AT91SAM9_GPBR 0 Tested with an AT91SAM9263. Regards, Alexander Holler ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/2] at91sam9x: driver to use the internal RTT as RTC

Based on the linux driver. Signed-off-by: Alexander Holler --- README |1 + drivers/rtc/Makefile |1 + drivers/rtc/at91sam9-rtc.c | 162 3 files changed, 164 insertions(+), 0 deletions(-) create mode 100644 drivers

[U-Boot] [PATCH 1/2] at91: add defines for RTT and GPBR

Signed-off-by: Alexander Holler --- include/asm-arm/arch-at91/at91sam9260.h |2 ++ include/asm-arm/arch-at91/at91sam9261.h |2 ++ include/asm-arm/arch-at91/at91sam9263.h |3 +++ 3 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/asm-arm/arch-at91/at91sam9260.h b

Re: [U-Boot] [PATCH 2/2] at91sam9x: driver to use the internal RTT as RTC

Uups, looks like I have corrupted the set date functionality with one of my last minute changes (as I've just discovered). I will send a fixed patch 2/2 tomorrow. Regards, Alexander Holler ___ U-Boot mailing list U-Boot@lists.denx.de

[U-Boot] [PATCH 1/1] at91sam9x: driver to use the internal RTT as RTC

Based on the linux driver. Signed-off-by: Alexander Holler --- README |1 + drivers/rtc/Makefile |1 + drivers/rtc/at91sam9-rtc.c | 162 3 files changed, 164 insertions(+), 0 deletions(-) create mode 100644 drivers

[U-Boot] [PATCH 0/1] at91samm9x: fix for the rtc-driver

Hello, here is corrected patch 2/2 to add an driver for at91sam9x which uses the internal RTT as RTC. Sorry for not testing my last minute changes before. It was late. ;) The previous send patch 1/2 which adds some defines is still needed. Tested on an AT91SAM9263. Kind regards, Alexander

[U-Boot] [PATCH 1/2] Add AT91_ECC_BASE to at91sam9260.h to use atmel_nand with HW-ECC

Signed-off-by: Alexander Holler --- include/asm-arm/arch-at91/at91sam9260.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/asm-arm/arch-at91/at91sam9260.h b/include/asm-arm/arch-at91/at91sam9260.h index a60a081..3bc7167 100644 --- a/include/asm-arm/arch-at91

[U-Boot] [PATCH 2/2] Fix compile errors for atmel_nand with hw-ecc and new SoC access

AT91_ECC0) for an AT91SAM9263 or AT91_ECC_BASE for an AT91SAM9260. I've removed three unused variables too. Signed-off-by: Alexander Holler --- drivers/mtd/nand/atmel_nand.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/atmel_nand.c b/d

Re: [U-Boot] [PATCH 2/2] Fix compile errors for atmel_nand with hw-ecc and new SoC access

If someone else wonders why an author should sign his own patches, a good explanation can be found here: http://kerneltrap.org/files/Jeremy/DCO.txt ;) Regards, Alexander ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinf

Re: [U-Boot] [PATCH 1/1] at91sam9x: driver to use the internal RTT as RTC

Am 03.04.2010 20:33, schrieb Tom: > Alexander Holler wrote: > > Change parameter name to something more descriptive. > 'tmp' implies used locally and this value is passed back. > Maybe 'tm' as to_tmp(.., struct rtc_time *tm) ? > Maybe someone should pla

Re: [U-Boot] [PATCH 1/2] at91: add defines for RTT and GPBR

Am 03.04.2010 20:36, schrieb Tom: > Alexander Holler wrote: >> Signed-off-by: Alexander Holler >> --- >> include/asm-arm/arch-at91/at91sam9260.h | 2 ++ >> include/asm-arm/arch-at91/at91sam9261.h | 2 ++ >> include/asm-arm/arch-at91/at91sam9263.h | 3 +++ >&

Re: [U-Boot] [PATCH 2/2] Fix compile errors for atmel_nand with hw-ecc and new SoC access

Hi, please just forget my patches. I don't feel the need to waste your and my time in posting examples of my obivous incompetence and I'm long out of school and don't want to take lessons about exploring how other people want their names of variables. Happy easter, Alexander _

Re: [U-Boot] OMAP3: EVM: Linker errors across tool chain versions

Am 14.12.2010 17:01, schrieb Albert ARIBAUD: > Le 14/12/2010 16:42, Dirk Behme a écrit : > > (agree about the analysis) > >> So I'd like to re-send the int conversion patch from >> >> http://lists.denx.de/pipermail/u-boot/2010-December/083524.html >> >> in a proper format again as a workaround for

Re: [U-Boot] OMAP3: EVM: Linker errors across tool chain versions

Am 16.12.2010 14:47, schrieb Alexander Holler: > To put some salt into the wounds ;) , Using gcc 4.5.1 board_init_f isn't > reached here. When I'm using gcc 4.3.5 it is reached. In both cases I've > used the same version of binutils, 2.20.1. > > For a test wit

Re: [U-Boot] OMAP3: EVM: Linker errors across tool chain versions

Am 16.12.2010 16:20, schrieb Dirk Behme: > On 16.12.2010 14:47, Alexander Holler wrote: >> I'm working with the master (f8689b9eb3a7f6925cd50404a12479889188c510) >> on a beagleboard > ^^ > > ? > > This thread is about a (linking) issue b

[U-Boot] oamp3: bug in clock.c with gcc 4.5.1?

Hello, I think I've nailed down, why an u-boot compiled with gcc 4.5.1 fails here. Compiling arch/arm/cpu/armv7/omap3/clock.c with gcc -g -Os -fno-common -ffixed-r8 -msoft-float -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x80008000 -I/usr/src/u-boot/include -fno-builtin -ffreestanding -nostdinc

Re: [U-Boot] oamp3: bug in clock.c with gcc 4.5.1?

Hello, Am 17.12.2010 15:20, schrieb Wolfgang Denk: >> I think I've nailed down, why an u-boot compiled with gcc 4.5.1 fails >> here. Compiling arch/arm/cpu/armv7/omap3/clock.c with >> ... >> That means get_sys_clk_speed() will allways return S12M, at least that >> is what I'm reading here. And I

[U-Boot] [PATCH] nand: fix bug with multiple NAND devices if CONFIG_MTD_DEVICE is defined.

The variable i has to be static, otherwise it would be always zero. Signed-off-by: Alexander Holler --- drivers/mtd/nand/nand.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/nand/nand.c b/drivers/mtd/nand/nand.c index c0e068a..d987f4c 100644 --- a/drivers

[U-Boot] [PATCH] OMAP3: Use sdelay from arch/arm/cpu/armv7/syslib.c instead of cloning that.

There is no need to have such a function twice. Signed-off-by: Alexander Holler --- arch/arm/cpu/armv7/omap3/board.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-) diff --git a/arch/arm/cpu/armv7/omap3/board.c b/arch/arm/cpu/armv7/omap3/board.c index 6c2a132..0e62626

[U-Boot] [RFC PATCH] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

I haven't found a place in the kernel where they were actually enabled (CONFIG_ARM_DMA_MEM_BUFFERABLE). Signed-off-by: Alexander Holler --- arch/arm/include/asm/io.h | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm/include/asm/io.h b/arch/arm/i

Re: [U-Boot] [RFC PATCH] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Hello, Am -10.01.-28163 20:59, schrieb Alexander Holler: > gcc 4.5.1 seems to ignore (at least some) volatile definitions, > avoid that as done in the kernel. > --- > arch/arm/include/asm/io.h | 15 +-- > 1 files changed, 9 insertions(+), 6 deletions(-) > &

[U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

headers avoids such optimizations when gcc 4.5.1 is used. Maybe the headers as used in the current linux-kernel should be used, but to avoid large changes, I've just added a small change to the current headers. Signed-off-by: Alexander Holler --- arch/arm/include/asm/io.h |

Re: [U-Boot] git merge summary

Hello, may I ask again for opinions about enabling that feature? Regards, Alexander Am 29.03.2010 11:32, schrieb Detlev Zundel: > Hi Alexander, > >> may I ask if there is reason why merge commits don't have a summary? > > Yes, you may. Actually this is a good question. > >> I find those summar

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Hello, On 19.12.2010 08:51, Dirk Behme wrote: > On 18.12.2010 23:27, Alexander Holler wrote: >> gcc 4.5.1 seems to ignore (at least some) volatile definitions, >> avoid that as done in the kernel. >> > Acked-by: Dirk Behme Thanks for the ack, but I have to say, that t

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Hello, Am 19.12.2010 12:28, schrieb Albert ARIBAUD: > Le 19/12/2010 11:22, Alexander Holler a écrit : >> Hello, >> >> On 19.12.2010 08:51, Dirk Behme wrote: >>> On 18.12.2010 23:27, Alexander Holler wrote: >>>> gcc 4.5.1 seems to ignore (at least some

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Am 19.12.2010 19:45, schrieb John Rigby: > On Sun, Dec 19, 2010 at 3:22 AM, Alexander Holler > wrote: >> side effects here. Reading NAND now fails on my BeagleBoard. Regardless >> if I use gcc 4.3.5 or gcc 4.5.1, after applying that patch the wrong ID >>

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Am 20.12.2010 01:39, schrieb John Rigby: > On Sun, Dec 19, 2010 at 12:59 PM, Alexander Holler > wrote: > ... >> No EEPROM on expansion board >> Die ID #062a0004040365fa16019019 >> Hit any key to stop autoboot: 0 >> OMAP3 beagleboard.org # nand info >

[U-Boot] [RFC PATCH] ARM: print gcc version

It might be useful to see what compiler version was used to compile u-boot. --- arch/arm/lib/board.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 96c0e30..df90b5e 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/boa

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Hello, Am 20.12.2010 07:07, schrieb John Rigby: > With your patch and the following hack nand works: > > > diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c > index 99b9cef..5e94155 100644 > --- a/drivers/mtd/nand/omap_gpmc.c > +++ b/drivers/mtd/nand/omap_gpmc.c > @@ -29,6 +

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Am 21.12.2010 11:53, schrieb Wolfgang Denk: > Dear Albert ARIBAUD, > > In message<4d1083b4.2060...@free.fr> you wrote: >> >>> And I at your suggestion tried modifying the binary changing the extra >>> ldrb to a nop and it works. >> >> Seems like a compiler issue to me, as the preprocessed C source

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Am 21.12.2010 13:51, schrieb Albert ARIBAUD: > Le 21/12/2010 13:35, Alexander Holler a écrit : > >> Hmm, is there actual somethinbg which should forbid the compiler to >> generate such code which rereads something? It might not be nice, but I >> don't think that it i

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Hello, Am 21.12.2010 01:25, schrieb John Rigby: > On Mon, Dec 20, 2010 at 10:12 AM, Alexander Holler > wrote: > >> There must be more problems. Using gcc 4.5.1, the read*/write*-patch and ... > Yes, you are correct, I see the same here with 4.5.2. I noticed that > bd

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Am 21.12.2010 21:04, schrieb Dirk Behme: > On 21.12.2010 20:52, Wolfgang Denk wrote: >> Dear Albert& friends, >> >> what is your opinion? Should we include the memory barrier patch into >> the upcoming release (and eventually delay it for further testing), or >> release as is and solve this issu

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Am 22.12.2010 08:02, schrieb Albert ARIBAUD: > Le 22/12/2010 01:11, Alexander Holler a écrit : >> Am 21.12.2010 21:04, schrieb Dirk Behme: >>> On 21.12.2010 20:52, Wolfgang Denk wrote: >>>> Dear Albert& friends, >>>> >>>> what is your

[U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

I haven't found a place in the kernel where they were actually enabled (CONFIG_ARM_DMA_MEM_BUFFERABLE). Signed-off-by: Alexander Holler --- arch/arm/include/asm/io.h | 20 ++-- 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/arch/arm/include/asm/io.h b/arch/

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Hello, Am 22.12.2010 09:02, schrieb Wolfgang Denk: > In message<1292711230-3234-1-git-send-email-hol...@ahsoftware.de> you wrote: >> gcc 4.5.1 seems to ignore (at least some) volatile definitions, >> avoid that as done in the kernel. > ... >> +#define writeb(v,c) ({ __iowmb(); __

Re: [U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Hello, Am 22.12.2010 15:50, schrieb Dirk Behme: > This patch seems to be the same as the proposal from Wolfgang > > http://lists.denx.de/pipermail/u-boot/2010-December/084122.html > Exactly. > So we shouldn't drop his > > Signed-off-by: Wolfgang Denk > Sorry, I haven't seen that Signed-Off and

Re: [U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Hello, Am 01.01.2011 13:04, schrieb Dirk Behme: > On 22.12.2010 12:04, Alexander Holler wrote: >> gcc 4.5.1 seems to ignore (at least some) volatile definitions, >> avoid that as done in the kernel. >> >> Reading C99 6.7.3 8 and the comment 114) there, I think it

Re: [U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Am 01.01.2011 19:25, schrieb Dirk Behme: > On 01.01.2011 18:52, Alexander Holler wrote: >> Hello, >> >> Am 01.01.2011 13:04, schrieb Dirk Behme: >>> On 22.12.2010 12:04, Alexander Holler wrote: >>>> gcc 4.5.1 seems to ignore (at least some) volatile d

Re: [U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Am 01.01.2011 20:21, schrieb Dirk Behme: > On 01.01.2011 19:47, Alexander Holler wrote: >> Am 01.01.2011 19:25, schrieb Dirk Behme: >>> On 01.01.2011 18:52, Alexander Holler wrote: >>>> Hello, >>>> >>>> Am 01.01.2011 13:04, schrieb Dirk Be

Re: [U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

On 02.01.2011 14:29, Dirk Behme wrote: > On 02.01.2011 13:43, Alexander Holler wrote: >> Am 01.01.2011 20:21, schrieb Dirk Behme: >>> On 01.01.2011 19:47, Alexander Holler wrote: >>>> Am 01.01.2011 19:25, schrieb Dirk Behme: >>>>> On 01.01.201

[U-Boot] [PATCH] Fix CONFIG_CMD_SHA1SUM

Only CONFIG_CMD_SHA1SUM should have been used. --- README |2 +- common/cmd_mem.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README b/README index 68f5fb0..2e70b48 100644 --- a/README +++ b/README @@ -675,7 +675,7 @@ The following options need to be c

Re: [U-Boot] [PATCH] Fix CONFIG_CMD_SHA1SUM

Am 04.01.2011 08:47, schrieb Alexander Holler: > Only CONFIG_CMD_SHA1SUM should have been used. > --- > README |2 +- > common/cmd_mem.c |4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > Sorry, have forgotten that Signed-off-by: Alexande

Re: [U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Am 02.01.2011 22:00, schrieb Alexander Holler: > On 02.01.2011 14:29, Dirk Behme wrote: >> On 02.01.2011 13:43, Alexander Holler wrote: >>> Am 01.01.2011 20:21, schrieb Dirk Behme: >>>> On 01.01.2011 19:47, Alexander Holler wrote: >>>>> Am 01.01.2011 19

Re: [U-Boot] [RFC PATCH] ARM: print gcc version

Am 09.01.2011 22:03, schrieb Wolfgang Denk: > Dear Alexander Holler, > > In message<1292863117-3175-1-git-send-email-hol...@ahsoftware.de> you wrote: >> It might be useful to see what compiler version was used to compile u-boot. >> --- >> arch/arm/lib/board.c

Re: [U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Am 10.01.2011 16:05, schrieb Wolfgang Denk: > Dear Alexander Holler, > > In message<4d2b1d75.70...@ahsoftware.de> you wrote: >> >> Beeing kind of a defensive programmer, I still would prefer to use have >> that __asm__ for write* too. That would at least preven

Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.

Am 09.01.2011 23:19, schrieb Wolfgang Denk: > gcc 4.5.1 seems to ignore (at least some) volatile definitions, > avoid that as done in the kernel. Have had a look at the asm generated by gcc 4.5.1, looks good. The wrong optimization in arch/arm/cpu/armv7/omap3/clock.c is gone and the writeb in d

Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.

Am 12.01.2011 17:40, schrieb Wolfgang Denk: > Dear Alexander Holler, > > In message<4d2dcb18.20...@ahsoftware.de> you wrote: >> Am 09.01.2011 23:19, schrieb Wolfgang Denk: >> >>> gcc 4.5.1 seems to ignore (at least some) volatile definitions, >>> avoid

Re: [U-Boot] [RFC PATCH v2] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Hello, Am 20.12.2010 17:08, schrieb John Rigby: > Earlier in this thread Alexander said: >> I haven't add the definitions which are using a memory barrier because I >> haven't found >> a place in the kernel where they were actually enabled >> (CONFIG_ARM_DMA_MEM_BUFFERABLE). Because I've just ru

  1   2   3   >