Re: [EXTERNAL] Re: U-Boot ECDSA Implementation Question

2021-02-22 Thread Alex G.
l. Is that something you'd like to take on? Alex All the best, Tim -Original Message- From: Alex G. Sent: February 5, 2021 11:09 AM To: Simon Glass ; Tim Romanski Cc: u-boot@lists.denx.de; Deskin Miller ; Dylan D'Silva Subject: [EXTERNAL] Re: U-Boot ECDSA Implementation Que

Re: Broken build on OpenBSD

2021-02-23 Thread Alex G.
On 2/23/21 1:07 PM, Mark Kettenis wrote: Hi Simon, Commit c5819701a3de61e2ba2ef7ad0b616565b32305e5 broke the build on OpenBSD and probably other non-Linux systems. ENODATA, which is now used in fit_check_format(), isn't defined. It isn't part of POSIX[1] and generally not available on BSD-deri

Re: Broken build on OpenBSD

2021-02-23 Thread Alex G.
On 2/23/21 3:18 PM, Simon Glass wrote: Hi Alex, On Tue, 23 Feb 2021 at 14:48, Alex G. wrote: On 2/23/21 1:07 PM, Mark Kettenis wrote: Hi Simon, Commit c5819701a3de61e2ba2ef7ad0b616565b32305e5 broke the build on OpenBSD and probably other non-Linux systems. ENODATA, which is now used in

Re: Broken build on OpenBSD

2021-02-26 Thread Alex G.
On 2/25/21 1:31 PM, Simon Glass wrote: Hi Alex, To the extent that it is unconventional, that reflects the decision to avoid adding U-Boot-specific error numbers and perhaps also to avoid having a different error number for each possible failure in U-Boot. The set of errno codes is much small

Booting a FIT: The load address of the FDT blob and overlays

2021-03-08 Thread Alex G.
Hi, I was wondering about the correct load address for a devicetree in FIT. Normally, the dtb can be anywhere in RAM, so it doesn't make sense to force it to a specific address with a 'load =' FIT directive. With bootm, the first overlay, but then fail with with: "Overlayed FDT requir

stm32mp: The purpose of "!tee_find_device()"

2020-09-30 Thread Alex G.
Hi I'm trying to wrap my head around the purpose of the following lines in ft_system_setup(): if (!CONFIG_IS_ENABLED(OPTEE) || !tee_find_device(NULL, NULL, NULL, NULL)) stm32_fdt_disable_optee(blob); My interpretation is "if optee is not running, delete the

Something doesn't make sense with SPL_FIT and SPL_LOAD_FIT

2020-10-08 Thread Alex G.
Hi, I think there's something wrong with the implementation distinction of SPL_FIT and SPL_LOAD_FIT. CONFIG_SPL_FIT: * Support Flattened Image Tree within SPL CONFIG_SPL_LOAD_FIT: * This option instead enables generation of a FIT (Flat Image Tree) which provides more

Re: [PATCH] mkimage: use environment variable MKIMAGE_SIGN_PIN to set pin for OpenSSL Engine

2021-08-18 Thread Alex G.
Hi Marc, On 7/23/21 3:17 PM, Marc Kleine-Budde wrote: This patch adds the possibility to pass the PIN the OpenSSL Engine used during signing via the environment variable MKIMAGE_SIGN_PIN. This follows the approach used during kernel module signing ("KBUILD_SIGN_PIN") or UBIFS image signing ("MKI

A mea culpa undefined reference in v2021.10-rc2, padding_algos, linker lists

2021-08-18 Thread Alex G.
Hi Simon, I'm seeing an undefined reference to padding_pkcs_15_verify with v2021.10-rc2. It happens when enabling FIT_SIGNATURE. I've tracked it down to the following two commits: commit 92c960bc1d ("lib: rsa: Remove #ifdefs from rsa.h") commit 61416fe9df ("Kconfig: FIT_SIGNATURE should not s

Massive stm32mp1 breakage with v2021.10-rc2

2021-08-24 Thread Alex G.
Hi Patrick, I'm having issues with some of the recent changes centered around FIP support and CONFIG_STM32MP15x_STM32IMAGE. and commit f91783edf224 ("arm: stm32mp: handle the OP-TEE nodes in DT with FIP support") ## Problem description > +#ifdef CONFIG_STM32MP15x_STM32IMAGE > + /* only

Re: U-Boot ECDSA Software Implementation Status

2021-08-26 Thread Alex G.
Hi Ryan, I'm only aware of the work that Tim has published. I don't think anyone is actively working on it. Alex On 8/26/21 9:00 AM, Pabis, Ryan wrote: I see that Tim was working to add a non-platform specific implementation of the ECDSA algorithm to u-boot back in February. I would like t

Re: [PATCH 04/10] fdt_support: Implement fdt_ethernet_set_macaddr()

2021-08-26 Thread Alex G.
Hi Sean, On 8/26/21 6:35 PM, Sean Anderson wrote: On 8/26/21 5:42 PM, Alexandru Gagniuc wrote: Oftentimes we have MAC address information stored in a ROM or OTP. The way to add that to the FDT would be through the u-boot environment, and then fdt_fixup_ethernet(). This is not very useful in S

Re: [PATCH] spl: fit: Prefer a malloc()'d buffer for loading images

2020-12-07 Thread Alex G.
On 11/3/20 9:11 AM, Simon Glass wrote: +Tom Rini too ping? Alex On Wed, 21 Oct 2020 at 17:33, Alexandru Gagniuc wrote: Fit images were loaded to a buffer provided by spl_get_load_buffer(). This may work when the FIT image is small and fits between the start of DRAM and SYS_TEXT_BASE. One

Re: [PATCH 1/8] spl: fit: Drop 'length' argument to board_spl_fit_post_load()

2020-12-16 Thread Alex G.
On 12/16/20 1:13 AM, Peng Fan wrote: Subject: [PATCH 1/8] spl: fit: Drop 'length' argument to board_spl_fit_post_load() The size is derived from the FIT image itself. Any alignment requirements are machine-specific and known by the board code. Thus the total length can be derived from the FIT im

Re: [PATCH 8/8] spl: fit: Load devicetree when a Linux payload is found

2020-12-16 Thread Alex G.
On 12/15/20 6:09 PM, Alexandru Gagniuc wrote: When a FIT config specifies a devicetree, we should load it, no questions asked. In the case of the "simple" FIT loading path, a difficulty arises in selecting the load address of the FDT. The default FDT location is right after the "kernel" or "f

Re: [U-Boot] [PATCH v1 3/9] sunxi: initial sun7i dram setup support

2014-03-14 Thread Alex G.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/14/2014 09:17 AM, Tom Rini wrote: > On Fri, Mar 14, 2014 at 10:33:45AM +, Ian Campbell wrote: > > [snip] >> +static void mctl_ddr3_reset(void) +{ + struct sunxi_dram_reg >> *dram = +(struct sunxi_dram_reg *)SUNXI_DR

Re: [U-Boot] [PATCH v1 4/9] sunxi: initial generic sun7i cpu, board and start of day support

2014-03-15 Thread Alex G.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/14/2014 09:17 AM, Tom Rini wrote: > On Fri, Mar 14, 2014 at 10:33:46AM +, Ian Campbell wrote: >> +#ifdef CONFIG_SPL_BUILD +void sunxi_board_init(void) +{ + int >> power_failed = 0; + unsigned long ramsize; + + printf("DRAM:"); + >> ra

Re: [U-Boot] [PATCH 4/5] configs: am335x: Enable PHY_VITESSE

2017-02-06 Thread Alex G .
On 02/06/2017 07:56 AM, Andrew F. Davis wrote: On 02/03/2017 05:42 PM, Alexandru Gagniuc wrote: The Adaptrum ACRS2 mainboard uses a Vitesse VSC8601 PHY. Signed-off-by: Alexandru Gagniuc --- include/configs/am335x_evm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/am335x

Re: [U-Boot] [PATCH 4/5] configs: am335x: Enable PHY_VITESSE

2017-02-06 Thread Alex G .
On 02/06/2017 12:38 PM, Andrew F. Davis wrote: On 02/06/2017 02:30 PM, Alex G. wrote: On 02/06/2017 11:47 AM, Andrew F. Davis wrote: On 02/06/2017 01:02 PM, Alex G. wrote: On 02/06/2017 07:56 AM, Andrew F. Davis wrote: On 02/03/2017 05:42 PM, Alexandru Gagniuc wrote: The Adaptrum ACRS2

Re: [U-Boot] [PATCH 4/5] configs: am335x: Enable PHY_VITESSE

2017-02-06 Thread Alex G .
On 02/06/2017 11:47 AM, Andrew F. Davis wrote: On 02/06/2017 01:02 PM, Alex G. wrote: On 02/06/2017 07:56 AM, Andrew F. Davis wrote: On 02/03/2017 05:42 PM, Alexandru Gagniuc wrote: The Adaptrum ACRS2 mainboard uses a Vitesse VSC8601 PHY. Signed-off-by: Alexandru Gagniuc --- include

Re: [PATCH] arm: dts: stm32mp1: use ssbl partition name for U-Boot

2021-09-29 Thread Alex G.
On 9/14/21 7:14 AM, Patrick Delaunay wrote: Continue to use the "ssbl" name for GPT partition of secondary boot stage = U-Boot for basic boot with SPL to avoid to disturb existing user. The "fip" partition name is only used for TFA_BOOT with FIP, it is a TF-A BL2 requirement; it the default conf

Re: FIT image: load secure FPGA

2021-10-04 Thread Alex G.
On 10/4/21 3:32 PM, Jorge Ramirez-Ortiz, Foundries wrote: Hello, We are enabling secure boot on Zynqmp with SPL. The issue however is that during secure boot, the bootrom not only validates the first loader (SPL and PMUFW combo) but it will also expect a signed bitstream during load(FPGA). Sin

Re: [PATCH v5 01/29] compiler: Rename host_build() to tools_build()

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: With the new TOOLS_LIBCRYPTO and some other changes, it seems that we are heading towards calling this a tools build rather than a host build, although of course it does happen on the host. I cannot think of anything built by the host which cannot be des

Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED()

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: At present we must separately test for the host build for many options, since we force them to be enabled. For example, CONFIG_FIT is always enabled in the host tools, even if CONFIG_FIT is not enabled by the board itself. It would be more convenient if we

Re: [PATCH v5 03/29] image: Add Kconfig options for FIT in the tools build

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: In preparation for enabling CONFIG_IS_ENABLED() on the host build, add some options to enable the various FIT options expected in these tools. This will ensure that the code builds correctly when CONFIG_TOOLS_xxx is distinct from CONFIG_xxx. Drop some #i

Re: [PATCH v5 03/29] image: Add Kconfig options for FIT in the tools build

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: In preparation for enabling CONFIG_IS_ENABLED() on the host build, add some options to enable the various FIT options expected in these tools. This will ensure that the code builds correctly when CONFIG_TOOLS_xxx is distinct from CONFIG_xxx. Drop some #i

Re: [PATCH v5 04/29] spl: cypto: Bring back SPL_ versions of SHA

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: Unfortunately these were removed by mistake. This means that adding hash support to SPL brings in all software algorithms, with a substantial increase in code size. The origin of the problem was renaming them to SPL_FIT_xxx and then these were removed altog

Re: [PATCH v5 05/29] hash: Use Kconfig to enable hashing in host tools and SPL

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: At present when building host tools, we force CONFIG_SHAxxx to be enabled regardless of the board Kconfig setting. This is done in the image.h header file. For SPL we currently just assume the algorithm is desired if U-Boot proper enables it. Clean this

Re: [PATCH v5 06/29] hash: Drop some #ifdefs in hash.c

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: We can use the __maybe_unused attribute to avoid some of the #ifdefs in this file. Update the functions accordingly. Note: The actual hashing interface is still a mess, with four separate combinations and lots of #ifdefs. This should really use a driver

Re: [PATCH v5 07/29] image: Drop IMAGE_ENABLE_FIT

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: Make use of the host Kconfig for FIT. With this we can use CONFIG_IS_ENABLED(FIT) directly in the host build, so drop the unnecessary indirection. Signed-off-by: Simon Glass Reviewed-by: Alexandru Gagniuc --- Changes in v5: - Rebase to next arch/a

Re: [PATCH v5 08/29] image: Drop IMAGE_ENABLE_OF_LIBFDT

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: Add a host Kconfig for OF_LIBFDT. With this we can use CONFIG_IS_ENABLED(OF_LIBFDT) directly in the host build, so drop the s/host build/tools build/ unnecessary indirection. Signed-off-by: Simon Glass Reviewed-by: Alexandru Gagniuc --- Change

Re: [PATCH v5 09/29] image: Use Kconfig to enable CONFIG_FIT_VERBOSE on host

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: Add a host Kconfig for FIT_VERBOSE. With this we can use CONFIG_IS_ENABLED(FIT_VERBOSE) directly in the host build, so drop the s/host build/ tools build/ forcing of this in the image.h header. Signed-off-by: Simon Glass Reviewed-by: Alexandru Gagniu

Re: [PATCH v5 10/29] image: Use Kconfig to enable FIT_RSASSA_PSS on host

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: Add a host Kconfig for FIT_RSASSA_PSS. With this we can use CONFIG_IS_ENABLED(FIT_RSASSA_PSS) directly in the host build, so drop the forcing of this in the image.h header. Drop the #ifdef around padding_pss_verify() too since it is not needed. Use the c

Re: [PATCH v5 11/29] image: Use the correct checks for CRC32

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: Add a host Kconfig for CRC32. With this we can use CONFIG_IS_ENABLED(CRC32) directly in the host build, so drop the unnecessary indirection. Add a few more conditions to SPL_CRC32 to avoid build failures as well as TPL_CRC32. Also update hash.c to make c

Re: [PATCH v5 12/29] image: Drop IMAGE_BOOT_GET_CMDLINE

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: This is not needed with Kconfig, since we can use IS_ENABLED() easily enough and the board code is now in a separate file. Update the only place where this is used and drop it. Signed-off-by: Simon Glass Reviewed-by: Alexandru Gagniuc --- Changes

Re: [PATCH v5 13/29] image: Drop IMAGE_OF_BOARD_SETUP

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: This is not needed with Kconfig, since we can use IS_ENABLED() easily enough. Drop it. Signed-off-by: Simon Glass Reviewed-by: Alexandru Gagniuc --- (no changes since v1) common/image-fdt.c | 4 ++-- include/image.h| 6 -- 2 files cha

Re: [PATCH v5 14/29] image: Drop IMAGE_OF_SYSTEM_SETUP

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: This is not needed with Kconfig, since we can use IS_ENABLED() easily enough. Drop it. Signed-off-by: Simon Glass Reviewed-by: Alexandru Gagniuc --- (no changes since v1) common/image-fdt.c | 2 +- include/image.h| 6 -- 2 files chang

Re: [PATCH v5 15/29] image: Drop IMAGE_ENABLE_IGNORE

2021-10-05 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: We can use the new host_build() function for this, so drop it. s/host_build/tools_build/ Signed-off-by: Simon Glass Reviewed-by: Alexandru Gagniuc --- (no changes since v1) common/image-fit.c | 2 +- include/image.h| 3 --- 2 files chan

Re: [PATCH] fit: display proper node on error

2021-10-06 Thread Alex G.
+ Simon On 10/6/21 10:47 AM, Angelo Dureghello wrote: Fix final error message from Verification failed for '' hash node in 'conf@1' config node to Verification failed for 'signature@1' hash node in 'conf@1' config node Signed-off-by: Angelo Dureghello --- common/image-fit-sig.c | 2 +- 1

Re: Broken build with disabling OpenSSL crypto

2021-10-06 Thread Alex G.
Hi Jernej, On 10/6/21 4:27 PM, Jernej Škrabec wrote: Hi everyone! Commit cb9faa6f98ae ("tools: Use a single target-independent config to enable OpenSSL") recently introduced option to disable usage of OpenSSL via CONFIG_TOOLS_LIBCRYPTO. However, just a bit later, another commit b4f3cc2c42d9 ("t

Re: [PATCH 0/3] stm32mp: Attempt to resolve unintended breakage with v2021.10-rc2

2021-10-07 Thread Alex G.
Hi Patrick, On 9/14/21 7:26 AM, Patrick DELAUNAY wrote: Hi Alexandru, I think you need to update  arch/arm/mach-stm32mp/Kconfig something like:  config STM32MP15x bool "Support STMicroelectronics STM32MP15x Soc" -    select ARCH_SUPPORT_PSCI if !TFABOOT -    select ARM_SMCCC if TFA

Re: [Uboot-stm32] [PATCH v2 03/11] stm32mp1: Add support for falcon mode boot from SD card

2021-10-07 Thread Alex G.
On 10/4/21 9:57 AM, Patrick DELAUNAY wrote: Hi, => if OPTEE is loaded after SPL the U-Boot configuration change (running in secure world or not) I am starting to work on these issues in the branch https://github.com/u-boot/u-boot/compare/master...patrickdelaunay:spl_optee_W2140 https://g

Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED()

2021-10-07 Thread Alex G.
On 10/7/21 1:50 PM, Simon Glass wrote: Hi Tom, On Thu, 7 Oct 2021 at 12:30, Tom Rini wrote: On Thu, Oct 07, 2021 at 12:02:24PM -0600, Simon Glass wrote: Hi Tom, On Thu, 7 Oct 2021 at 07:42, Tom Rini wrote: On Thu, Oct 07, 2021 at 07:32:04AM -0600, Simon Glass wrote: Hi Tom, On Wed,

Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED()

2021-10-07 Thread Alex G.
On 10/7/21 2:39 PM, Tom Rini wrote: On Thu, Oct 07, 2021 at 02:32:42PM -0500, Alex G. wrote: On 10/7/21 1:50 PM, Simon Glass wrote: Hi Tom, On Thu, 7 Oct 2021 at 12:30, Tom Rini wrote: On Thu, Oct 07, 2021 at 12:02:24PM -0600, Simon Glass wrote: Hi Tom, On Thu, 7 Oct 2021 at 07:42

Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED()

2021-10-07 Thread Alex G.
On 10/7/21 4:04 PM, Tom Rini wrote: On Thu, Oct 07, 2021 at 03:33:32PM -0500, Alex G. wrote: On 10/7/21 2:39 PM, Tom Rini wrote: On Thu, Oct 07, 2021 at 02:32:42PM -0500, Alex G. wrote: On 10/7/21 1:50 PM, Simon Glass wrote: Hi Tom, On Thu, 7 Oct 2021 at 12:30, Tom Rini wrote: On

Re: Broken build with disabling OpenSSL crypto

2021-10-11 Thread Alex G.
On 10/10/21 6:06 AM, Jernej Škrabec wrote: Dne četrtek, 07. oktober 2021 ob 00:05:24 CEST je Alex G. napisal(a): Can you please give the following diff a try, and if it works for you, submit as patch? This works, I'll submit it as a patch. Should I keep you as original author and add you

Re: using device-tree fragments/overlays

2021-10-14 Thread Alex G.
Hi Tim, On 10/7/21 4:07 PM, Tim Harvey wrote: Greetings, I'm working on some features for the imx8mm-venice boards I support which depend on making small changes to the dt before booting Linux. The purpose is not to have any of this apply to the U-Boot controlling dt but instead to the Linux k

Re: Broken build with disabling OpenSSL crypto

2021-10-15 Thread Alex G.
On 10/15/21 6:34 AM, Pali Rohár wrote: On Wednesday 06 October 2021 17:05:24 Alex G. wrote: Hi Jernej, On 10/6/21 4:27 PM, Jernej Škrabec wrote: Hi everyone! Commit cb9faa6f98ae ("tools: Use a single target-independent config to enable OpenSSL") recently introduced option to disabl

Re: Broken build with disabling OpenSSL crypto

2021-10-18 Thread Alex G.
On 10/15/21 3:30 PM, Pali Rohár wrote: On Friday 15 October 2021 09:35:43 Alex G. wrote: On 10/15/21 6:34 AM, Pali Rohár wrote: On Wednesday 06 October 2021 17:05:24 Alex G. wrote: Hi Jernej, On 10/6/21 4:27 PM, Jernej Škrabec wrote: Hi everyone! Commit cb9faa6f98ae ("tools: Use a s

Re: [PATCH v3 1/4] tools: Separate image types which depend on OpenSSL

2021-10-18 Thread Alex G.
On 10/14/21 10:19 PM, Samuel Holland wrote: Some image types (kwbimage and mxsimage) always depend on OpenSSL, so they can only be included in mkimage when TOOLS_LIBCRYPTO is selected. Use Makefile logic to conditionally link the files. When building for platforms which use those image types, au

Re: [Query - 5 Mins] Information on U-BOOT FIT Malloc changes

2021-10-25 Thread Alex G.
On 10/25/21 6:55 PM, Spandan Mahadevegowda wrote: Hello Alexandru, I'm currently working on some POC on Pine64 that requires a Trusted Execution Environment. I was using U-Boot 2020.10 with SPL_FIT_GENERATOR and modified mksunxi_fit_atf.sh to accommodate OP-TEE. However, due to new changes in

Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Alex G.
On 1/9/22 8:39 AM, Heinrich Schuchardt wrote: The return type of EVP_PKEY_get0_RSA() is const struct rsa_st *. Our code drops the const qualifier leading to In file included from tools/lib/rsa/rsa-sign.c:1: ./tools/../lib/rsa/rsa-sign.c: In function ‘rsa_add_verify_data’: ./tools/../lib/rsa/r

Re: [PATCH] tools: Do not build kwbimage if CONFIG_TOOLS_LIBCRYPTO=n

2022-01-11 Thread Alex G.
On 1/11/22 13:09, Tom Rini wrote: On Tue, Jan 11, 2022 at 07:58:05PM +0100, Marek Vasut wrote: On 1/11/22 17:16, Tom Rini wrote: On Tue, Jan 11, 2022 at 04:36:34PM +0100, Pali Rohár wrote: On Tuesday 11 January 2022 16:31:20 Marek Vasut wrote: The kwbimage has hard dependency on OpenSSL, d

Re: [PATCH] Revert "Fix data abort caused by mis-aligning FIT data"

2020-10-19 Thread Alex G.
On 10/19/20 6:02 PM, Marek Vasut wrote: On 10/20/20 12:58 AM, Tom Rini wrote: On Tue, Oct 20, 2020 at 12:54:35AM +0200, Marek Vasut wrote: On 10/20/20 12:45 AM, Tom Rini wrote: On Mon, Oct 19, 2020 at 11:59:22PM +0200, Marek Vasut wrote: On 10/19/20 11:50 PM, Reuben Dowle wrote: The alignmen

Re: [PATCH] Revert "Fix data abort caused by mis-aligning FIT data"

2020-10-19 Thread Alex G.
On 10/19/20 6:13 PM, Reuben Dowle wrote: The reverted change linked to some kernel documentation that requires 64- bit alignment. I agree with the alignment requirement. Im my opinion, there are two things that need to be done: First is to look at an ALIGNED address for the fdt. A summary ins

Re: [PATCH] Revert "Fix data abort caused by mis-aligning FIT data"

2020-10-20 Thread Alex G.
On 10/20/20 9:32 AM, Tom Rini wrote: On Tue, Oct 20, 2020 at 04:29:36PM +0200, Marek Vasut wrote: On 10/20/20 4:07 PM, Tom Rini wrote: On Tue, Oct 20, 2020 at 11:05:40AM +0200, Marek Vasut wrote: On 10/20/20 2:27 AM, Reuben Dowle wrote: What assumptions? Any code that assumes 4 byte alignment

Re: [PATCH] Revert "Fix data abort caused by mis-aligning FIT data"

2020-10-20 Thread Alex G.
On 10/20/20 10:54 AM, Tom Rini wrote: On Tue, Oct 20, 2020 at 09:38:52AM -0500, Alex G. wrote: On 10/20/20 9:32 AM, Tom Rini wrote: On Tue, Oct 20, 2020 at 04:29:36PM +0200, Marek Vasut wrote: On 10/20/20 4:07 PM, Tom Rini wrote: On Tue, Oct 20, 2020 at 11:05:40AM +0200, Marek Vasut wrote

Re: [PATCH] Revert "Fix data abort caused by mis-aligning FIT data"

2020-10-21 Thread Alex G.
On 10/20/20 1:10 PM, Tom Rini wrote: On Tue, Oct 20, 2020 at 12:01:02PM -0500, Alex G. wrote: On 10/20/20 10:54 AM, Tom Rini wrote: On Tue, Oct 20, 2020 at 09:38:52AM -0500, Alex G. wrote: On 10/20/20 9:32 AM, Tom Rini wrote: On Tue, Oct 20, 2020 at 04:29:36PM +0200, Marek Vasut wrote: On

Re: stm32mp: The purpose of "!tee_find_device()"

2020-10-29 Thread Alex G.
On 9/30/20 6:03 PM, Alex G. wrote: Hi I'm trying to wrap my head around the purpose of the following lines in ft_system_setup(): if (!CONFIG_IS_ENABLED(OPTEE) ||     !tee_find_device(NULL, NULL, NULL, NULL))     stm32_fdt_disable_optee(blob); Hi! Me again! Do we have a

Re: stm32mp: The purpose of "!tee_find_device()"

2020-11-03 Thread Alex G.
On 10/30/20 3:28 AM, Etienne Carriere wrote: On Thu, 29 Oct 2020 at 15:33, Alex G. wrote: On 9/30/20 6:03 PM, Alex G. wrote: Hi I'm trying to wrap my head around the purpose of the following lines in ft_system_setup(): if (!CONFIG_IS_ENABLED(OPTEE) || !tee_find_device

Re: stm32mp: The purpose of "!tee_find_device()"

2020-11-04 Thread Alex G.
On 11/4/20 1:07 AM, Etienne Carriere wrote: On Tue, 3 Nov 2020 at 16:53, Alex G. wrote: On 10/30/20 3:28 AM, Etienne Carriere wrote: On Thu, 29 Oct 2020 at 15:33, Alex G. wrote: On 9/30/20 6:03 PM, Alex G. wrote: Hi I'm trying to wrap my head around the purpose of the following

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-12 Thread Alex G.
On 1/30/22 21:41, Andrew Jeffery wrote: Some platform designs include support for disabling secure-boot via a jumper on the board. Sometimes this control can be separate from the mechanism enabling the root-of-trust for the platform. Add support for this latter scenario by allowing boards to impl

Re: [PATCH 07/10] stm32mp1: spl: Configure MAC address when booting OP-TEE

2021-08-31 Thread Alex G.
On 8/31/21 12:10 PM, Patrick DELAUNAY wrote: Hi, On 8/26/21 11:42 PM, Alexandru Gagniuc wrote: When OP-TEE is booted as the SPL payload, the stage after OP-TEE is not guaranteed to be u-boot. Thus the FDT patching in u-boot is not guaranteed to occur. Add this step to SPL. The patching by stm

Re: [PATCH 10/10] stm32mp1: spl: Copy optee nodes to target FDT for OP-TEE payloads

2021-09-01 Thread Alex G.
Hi Patrick, On 8/31/21 12:24 PM, Patrick DELAUNAY wrote: Hi, On 8/26/21 11:42 PM, Alexandru Gagniuc wrote: OP-TEE does not take a devicetree for its own use. However, it does pass the devicetree to the normal world OS. In most cases that will be some other devicetree-bearing platform, such as

Re: [PATCH 10/10] stm32mp1: spl: Copy optee nodes to target FDT for OP-TEE payloads

2021-09-02 Thread Alex G.
Hi Patrick, On 9/1/21 10:10 AM, Alex G. wrote: Hi Patrick, On 8/31/21 12:24 PM, Patrick DELAUNAY wrote: Hi, On 8/26/21 11:42 PM, Alexandru Gagniuc wrote: OP-TEE does not take a devicetree for its own use. However, it does pass the devicetree to the normal world OS. In most cases that will

Re: [PATCH] lib/rsa: Remove support for OpenSSL < 1.1.0 and libressl < 2.7.0

2021-09-02 Thread Alex G.
On 9/2/21 12:43 PM, Peter Robinson wrote: On Thu, Sep 2, 2021 at 3:38 PM Tom Rini wrote: On Thu, Sep 02, 2021 at 03:36:43PM +0100, Peter Robinson wrote: On Thu, Sep 2, 2021 at 2:28 PM Tom Rini wrote: On Thu, Jul 29, 2021 at 01:31:21PM -0500, Alexandru Gagniuc wrote: Older OpenSSL and

Re: [PATCH 1/2] arm: stm32: Disable ATAGs support

2021-09-03 Thread Alex G.
On 9/2/21 5:02 AM, Patrick Delaunay wrote: These platforms never had to support an ATAGs-based Linux Kernel, so remove the options. Cc: Marek Vasut Signed-off-by: Tom Rini Signed-off-by: Patrick Delaunay Reviewed-by: Alexandru Gagniuc Slowly, but surely, configs/*.h will grow to zero.

Re: [PATCH 2/2] board: stm32: Remove the bi_boot_params initialization

2021-09-03 Thread Alex G.
On 9/2/21 5:02 AM, Patrick Delaunay wrote: The stm32 platforms never had to support an ATAGs-based Linux Kernel, so remove the bi_boot_params initialization. Signed-off-by: Patrick Delaunay Tested-by: Alexandru Gagniuc --- board/dhelectronics/dh_stm32mp1/board.c | 3 ---

Re: [PATCH 1/2] lib: optee: remove the duplicate CONFIG_OPTEE

2021-09-03 Thread Alex G.
Hi Patrick On 9/2/21 4:56 AM, Patrick Delaunay wrote: The configuration CONFIG_OPTEE is defined 2 times: 1- in lib/optee/Kconfig for support of OPTEE images loaded by bootm command 2- in drivers/tee/optee/Kconfig for support of OP-TEE driver. It is abnormal to have the same CONFIG define for 2

Re: [RFC PATCH] stm32mp1: Replace STM32IMAGE config with TFABOOT_FIP

2021-09-03 Thread Alex G.
On 9/3/21 10:32 AM, Marek Vasut wrote: On 9/1/21 11:07 AM, Patrick DELAUNAY wrote: On 8/31/21 6:42 PM, Marek Vasut wrote: I would argue that the U-Boot crypto code went through multiple >> independent security reviews, personally I trust that more than code fully controlled and maintained by

Re: [PATCH 1/2] lib: optee: remove the duplicate CONFIG_OPTEE

2021-09-06 Thread Alex G.
On 9/6/21 11:53 AM, Patrick DELAUNAY wrote: In fact, the SPL boot path for OP-TEE doesn't use this function. That's intentional. Here's what I suggest:     - Remove OPTEE_TZDRAM_BASE and _SIZE There is some legacy here, board/warp7and board/technexion/pico-imx7d. it is not possible, it

Re: [PATCH 1/2] lib: optee: remove the duplicate CONFIG_OPTEE

2021-09-07 Thread Alex G.
On 9/6/21 5:39 PM, Alex G. wrote: On 9/6/21 11:53 AM, Patrick DELAUNAY wrote: In fact, the SPL boot path for OP-TEE doesn't use this function. That's intentional. Here's what I suggest:     - Remove OPTEE_TZDRAM_BASE and _SIZE There is some legacy here, board/warp7and b

Re: [PATCH] Kconfig: Drop duplicate 'select SHA512' instances

2021-09-09 Thread Alex G.
On 9/9/21 10:00 AM, Tom Rini wrote: When dropping SHA512_ALGO in general, we didn't catch some cases where an option was selecting both SHA512 and SHA512_ALGO and caused them to select SHA512 twice. Kconfig doesn't complain, but this is still wrong and should be corrected. Fixes: e60e44993120

Re: [PATCH 5/5] serial: Rework CONFIG_SYS_BAUDRATE_TABLE

2021-09-13 Thread Alex G.
On 9/13/21 4:24 PM, Tom Rini wrote: In order to move CONFIG_SYS_BAUDRATE_TABLE to Kconfig, we need to rework the logic a bit. Rename the users of CONFIG_SYS_BAUDRATE_TABLE to SYS_BAUDRATE_TABLE. Introduce a series of CONFIG_BAUDRATE_TABLE_... that include some number of baud rates. These ma

Re: [PATCH 2/4] dm: hash: Add new UCLASS_HASH support

2021-09-16 Thread Alex G.
Hi, On 7/29/21 8:08 PM, Chia-Wei Wang wrote: Add UCLASS_HASH for hash driver development. Thus the hash drivers (SW or HW-accelerated) can be developed in the DM-based fashion. Software hashing implementations are shared tightly with host tools. With DM, there's no opportunity for code sharin

Re: [PATCH 3/4] crypto: hash: Add software hash DM driver

2021-09-16 Thread Alex G.
On 7/29/21 8:08 PM, Chia-Wei Wang wrote: Add purely software-implmented drivers to support multiple hash operations including CRC, MD5, and SHA family. This driver is based on the new hash uclass. Signed-off-by: Chia-Wei Wang --- drivers/crypto/hash/Kconfig | 11 ++ drivers/crypto/has

Re: [PATCH 4/4] fit: Use DM hash driver if supported

2021-09-16 Thread Alex G.
On 7/29/21 8:08 PM, Chia-Wei Wang wrote: Calculate hash using DM driver if supported. For backward compatibility, the call to legacy hash functions is reserved. Signed-off-by: Chia-Wei Wang --- common/image-fit.c | 30 ++ 1 file changed, 30 insertions(+) diff

Re: [PATCH 1/2] spl: Add CONFIG_SPL_FIT_SIGNATURE_STRICT

2021-09-16 Thread Alex G.
Hi Oleksandr On 9/16/21 8:09 AM, Oleksandr Suvorov wrote: From: Henry Beberman SPL FIT load checks the signature on loadable images but just continues in the case of a failure. This is undesirable behavior because the boot process depends on the authenticity of each loadable part. Adding CONF

Re: [PATCH 2/4] dm: hash: Add new UCLASS_HASH support

2021-09-27 Thread Alex G.
On 9/23/21 9:49 PM, Simon Glass wrote:> On Thu, 16 Sept 2021 at 09:43, Alex G. wrote: On 7/29/21 8:08 PM, Chia-Wei Wang wrote: + +enum HASH_ALGO hash_algo_lookup_by_name(const char *name) string -> hash_lookup_algo() -> ops struct Is the current way to

Re: [PATCH v5 05/29] hash: Use Kconfig to enable hashing in host tools and SPL

2021-09-27 Thread Alex G.
Hi Simon On 9/25/21 8:43 PM, Simon Glass wrote: At present when building host tools, we force CONFIG_SHAxxx to be enabled regardless of the board Kconfig setting. This is done in the image.h header file. For SPL we currently just assume the algorithm is desired if U-Boot proper enables it. Cle

Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED()

2021-09-27 Thread Alex G.
On 9/25/21 8:43 PM, Simon Glass wrote: At present we must separately test for the host build for many options, since we force them to be enabled. For example, CONFIG_FIT is always enabled in the host tools, even if CONFIG_FIT is not enabled by the board itself. It would be more convenient if

Re: [PATCH v5 05/29] hash: Use Kconfig to enable hashing in host tools and SPL

2021-09-27 Thread Alex G.
On 9/27/21 11:06 AM, Simon Glass wrote: Hi Alex, On Mon, 27 Sept 2021 at 09:53, Alex G. wrote: Hi Simon On 9/25/21 8:43 PM, Simon Glass wrote: At present when building host tools, we force CONFIG_SHAxxx to be enabled regardless of the board Kconfig setting. This is done in the image.h

Re: a question about falcon mode

2021-11-25 Thread Alex G.
On 11/25/21 1:07 AM, Chan Kim wrote: Hello all, I'm trying to implement falcon mode for our board. Then should I first implement the normal mode(spl + proper)? It looks like so while I'm reading doc/README.falcon. (It says, after loading kernel, DT etc. I should give 'spl export' command). F

Re: a question about falcon mode

2021-11-26 Thread Alex G.
Alex Thanks! Chan -Original Message- From: Alex G. Sent: Thursday, November 25, 2021 11:57 PM To: Chan Kim ; U-Boot Mailing List Subject: Re: a question about falcon mode On 11/25/21 1:07 AM, Chan Kim wrote: Hello all, I'm trying to implement falcon mode for our board. Then sho

Re: a question about falcon mode

2021-11-29 Thread Alex G.
On 11/26/21 4:36 PM, Abder wrote: Hi Alex, Just a quick remarque that intrigued me: Le jeu. 25 nov. 2021 à 15:57, Alex G. a écrit : On 11/25/21 1:07 AM, Chan Kim wrote: Hello all, I'm trying to implement falcon mode for our board. Then should I first implement the normal mod

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-28 Thread Alex G.
On 2/27/22 19:29, Andrew Jeffery wrote: On Tue, 15 Feb 2022, at 13:55, Andrew Jeffery wrote: On Tue, 15 Feb 2022, at 13:42, Dhananjay Phadke wrote: On 2/14/2022 3:13 PM, Patrick Williams wrote: On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: There's a key-requirement polic

<    1   2