[PATCH v3 04/12] configs: j721x_evm: Remove unneeded check for SYS_K3_SPL_ATF

2023-04-06 Thread Andrew Davis
The TARGET_x_R5_EVM check is already enough to limit these defines to only the correct builds. Remove the extra outer check. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- board/ti/j721e/j721e.env | 2 -- board/ti/j721s2/j721s2.env | 2 -- 2 files changed, 4 deletions

[PATCH v3 05/12] configs: j721s2_evm.h: Remove refrences to J7200 EVM

2023-04-06 Thread Andrew Davis
The J7200 EVM will not include this file, this J7200 checks look to be a copy/paste errora from j721e_evm.h, which J7200 *can* include. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- include/configs/j721s2_evm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-04-06 Thread Andrew Davis
This function is the same for each device when it needs to shutdown the R5 core. Move this to the common section and move the remaining device specific ID list to the device hardware include. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/am642_init.c

[PATCH v3 07/12] arm: mach-k3: Move sysfw-loader.h out of mach includes

2023-04-06 Thread Andrew Davis
This header is only used locally by K3 init files, no need to have it up with the global mach includes. Move into local includes. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/am625_init.c | 2 +- arch/arm/mach-k3/am62a7_init.c

[PATCH v3 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-04-06 Thread Andrew Davis
These probably should be in some system wide header given their use. Until then move them out of K3 sys_proto.h so we can finish cleaning that header out. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/include/mach/sys_proto.h | 4 drivers/ram/k3-am654

[PATCH v3 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-06 Thread Andrew Davis
This matches how it was done for pre-K3 TI platforms and it allows us to move the forward declaration out of sys_proto.h. It also removes the need for K3_BOARD_DETECT as one is free to simply override the weak function in their board files as needed. Signed-off-by: Andrew Davis --- arch/arm

[PATCH v3 09/12] arm: mach-k3: Remove unused fdt_disable_node()

2023-04-06 Thread Andrew Davis
This function is not used currently; remove it. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/common.c | 19 --- arch/arm/mach-k3/include/mach/sys_proto.h | 1 - 2 files changed, 20 deletions(-) diff --git a/arch/arm/mach-k3

[PATCH v3 11/12] arm: mach-k3: Move J721s2 SPL init functions to mach-k3

2023-04-06 Thread Andrew Davis
This matches AM64 and J721e and removes the need to forward declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw() in sys_proto.h. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/include/mach/sys_proto.h | 3 -- arch/arm/mach-k3/j721s2_init.c

[PATCH v3 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-04-06 Thread Andrew Davis
This header file is now empty, remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 2 -- arch/arm/mach-k3/am654_init.c | 1 - arch/arm/mach-k3/common.c | 1 - arch/arm/mach-k3/include/mach/sys_proto.h | 10 -- arch/arm

Re: [PATCH v3 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-06 Thread Andrew Davis
and add the rest of the SoC IDs for completeness and later use. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 20 -- arch/arm/mach-k3/common.h | 3 --- arch/arm/mach-k3/include/mach/hardware.h | 25 +++ arch/arm

[PATCH v4 00/12] Remove K3 misc sys_proto.h header

2023-04-06 Thread Andrew Davis
h [2/12] to use static and turned it into common macro - Removed "EEPROM" from comment as board detection can use other methods - Added more reviewed by tags Changes from v1: - Added reviewed by tag - Rebased on latest Andrew Davis (12): arm: mach-k3: Move MSMC fixup to SoC level arm

[PATCH v4 05/12] configs: j721s2_evm.h: Remove refrences to J7200 EVM

2023-04-06 Thread Andrew Davis
The J7200 EVM will not include this file, this J7200 checks look to be a copy/paste errora from j721e_evm.h, which J7200 *can* include. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- include/configs/j721s2_evm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 04/12] configs: j721x_evm: Remove unneeded check for SYS_K3_SPL_ATF

2023-04-06 Thread Andrew Davis
The TARGET_x_R5_EVM check is already enough to limit these defines to only the correct builds. Remove the extra outer check. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- board/ti/j721e/j721e.env | 2 -- board/ti/j721s2/j721s2.env | 2 -- 2 files changed, 4 deletions

[PATCH v4 03/12] soc: soc_ti_k3: Use hardware.h to remove definition duplication

2023-04-06 Thread Andrew Davis
The K3 JTAG and SoC ID information is already stored in the K3 arch hardware file, include that and use its definitions here. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- drivers/soc/Kconfig | 2 +- drivers/soc/soc_ti_k3.c | 30 +- 2 files

[PATCH v4 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-04-06 Thread Andrew Davis
This function is the same for each device when it needs to shutdown the R5 core. Move this to the common section and move the remaining device specific ID list to the device hardware include. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/am642_init.c

[PATCH v4 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-06 Thread Andrew Davis
and later use. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 20 -- arch/arm/mach-k3/common.h | 3 --- arch/arm/mach-k3/include/mach/hardware.h | 25 +++ arch/arm/mach-k3/include/mach/sys_proto.h | 3 --- 4 files

[PATCH v4 09/12] arm: mach-k3: Remove unused fdt_disable_node()

2023-04-06 Thread Andrew Davis
This function is not used currently; remove it. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/common.c | 19 --- arch/arm/mach-k3/include/mach/sys_proto.h | 1 - 2 files changed, 20 deletions(-) diff --git a/arch/arm/mach-k3

[PATCH v4 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-06 Thread Andrew Davis
This matches how it was done for pre-K3 TI platforms and it allows us to move the forward declaration out of sys_proto.h. It also removes the need for K3_BOARD_DETECT as one is free to simply override the weak function in their board files as needed. Signed-off-by: Andrew Davis Reviewed-by

[PATCH v4 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-04-06 Thread Andrew Davis
These probably should be in some system wide header given their use. Until then move them out of K3 sys_proto.h so we can finish cleaning that header out. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/include/mach/sys_proto.h | 4 drivers/ram/k3-am654

[PATCH v4 07/12] arm: mach-k3: Move sysfw-loader.h out of mach includes

2023-04-06 Thread Andrew Davis
This header is only used locally by K3 init files, no need to have it up with the global mach includes. Move into local includes. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/am625_init.c | 2 +- arch/arm/mach-k3/am62a7_init.c

[PATCH v4 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-04-06 Thread Andrew Davis
is no longer board level. Enable OF_SYSTEM_SETUP in the configurations that use this to keep functionality the same. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/common.c | 16 arch/arm/mach-k3/include/mach/sys_proto.h | 1

[PATCH v4 11/12] arm: mach-k3: Move J721s2 SPL init functions to mach-k3

2023-04-06 Thread Andrew Davis
This matches AM64 and J721e and removes the need to forward declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw() in sys_proto.h. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/include/mach/sys_proto.h | 3 -- arch/arm/mach-k3/j721s2_init.c

[PATCH v4 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-04-06 Thread Andrew Davis
This header file is now empty, remove it. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/am642_init.c | 2 -- arch/arm/mach-k3/am654_init.c | 1 - arch/arm/mach-k3/common.c | 1 - arch/arm/mach-k3/include/mach

Re: [PATCH 0/8] Add ESM support for J721E and J7200

2023-04-11 Thread Andrew Davis
On 4/11/23 4:21 AM, Neha Malcom Francis wrote: Hi Bryan On 10/04/23 20:09, Bryan Brattlof wrote: Hi Neha! On April 10, 2023 thus sayeth Neha Malcom Francis: Add support for ESM (Error Signalling Module) in J721E and J7200. The ESM error pin output is routed to the PMIC (Power Management IC) w

[PATCH 03/17] arm: dts: am57x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/am571x-idk.dts| 7 ++- arch/arm/dts/am5729-beagleboneai.dts | 1 + arch/arm/dts/am572x-idk-common.dtsi| 2 +- arch/arm/dts/am572x-idk.dts| 7 ++- arch/arm/dts/am574x-idk.dts| 2

[PATCH 04/17] arm: dts: dm8x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/da850-evm.dts | 7 ++- arch/arm/dts/da850-lcdk.dts | 3 +-- arch/arm/dts/da850-lego-ev3.dts | 6 +- arch/arm/dts/da850.dtsi | 6 +- arch/arm/dts/dm8168-evm.dts | 6 +- arch/arm/dts/dm816x-clocks.dtsi | 6

[PATCH 06/17] arm: dts: omap3x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/omap-gpmc-smsc9221.dtsi | 1 + arch/arm/dts/omap3-beagle-xm-ab.dts | 7 ++- arch/arm/dts/omap3-beagle-xm.dts | 7 ++- arch/arm/dts/omap3-beagle.dts| 7

[PATCH 05/17] arm: dts: dra7x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/dra7-dspeve-thermal.dtsi | 7 ++- arch/arm/dts/dra7-evm-common.dtsi | 7 ++- arch/arm/dts/dra7-evm.dts | 7 ++- arch/arm/dts/dra7-iva-thermal.dtsi| 7 ++- arch/arm/dts/dra7-mmc-iodelay.dtsi| 2 +- arch/arm

[PATCH 02/17] arm: dts: am43x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/am4372.dtsi| 7 ++- arch/arm/dts/am437x-gp-evm.dts | 7 ++- arch/arm/dts/am437x-idk-evm.dts | 7 ++- arch/arm/dts/am437x-sk-evm.dts | 7 ++- arch/arm/dts/am43x-epos-evm.dts | 7 ++- arch/arm/dts/am43xx-clocks.dtsi | 5

[PATCH 00/17] Sync TI Device Trees with Linux v6.3-rc6

2023-04-11 Thread Andrew Davis
the only functional change, it fixes boot on DRA7-EVMs. Thanks, Andrew Andrew Davis (17): arm: dts: am3x: Update devicetree header comments to sync with v6.3-rc6 arm: dts: am43x: Update devicetree header comments to sync with v6.3-rc6 arm: dts: am57x: Update devicetree header

[PATCH 07/17] arm: dts: omap4x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/omap4-cpu-thermal.dtsi | 7 ++- arch/arm/dts/omap4-panda-common.dtsi | 2 +- arch/arm/dts/omap4-panda-es.dts | 2 +- arch/arm/dts/omap4-panda.dts | 2 +- arch/arm/dts/omap4-sdp-es23plus.dts | 2 +- arch/arm/dts/omap4-sdp.dts

[PATCH 01/17] arm: dts: am3x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/am335x-base0033.dts| 5 + arch/arm/dts/am335x-chiliboard.dts | 7 ++- arch/arm/dts/am335x-chilisom.dtsi | 7 ++- arch/arm/dts/am335x-evm.dts | 7 ++- arch/arm/dts/am335x-evmsk.dts | 7

[PATCH 09/17] arm: dts: keystone: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/keystone-clocks.dtsi | 7 ++- arch/arm/dts/keystone-k2e-clocks.dtsi | 7 ++- arch/arm/dts/keystone-k2e-evm.dts | 7 ++- arch/arm/dts/keystone-k2e-netcp.dtsi | 7 ++- arch/arm/dts/keystone-k2e.dtsi | 7 ++- arch

[PATCH 17/17] Revert "arm: dts: dra7*/am57xx-idk-evm-u-boot: Add ipu early boot DT changes"

2023-04-11 Thread Andrew Davis
This reverts commit 5717294230bc3578959960003be898433642. This does not exist in upstream kernel.org and breaks boot on DRA7-EVMs. Drop the same. Signed-off-by: Andrew Davis --- arch/arm/dts/am57xx-idk-common-u-boot.dtsi | 1 - arch/arm/dts/dra7-evm-u-boot.dtsi | 1 - arch/arm/dts

[PATCH 08/17] arm: dts: omap5x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/omap5-board-common.dtsi | 2 +- arch/arm/dts/omap5-core-thermal.dtsi | 7 ++- arch/arm/dts/omap5-gpu-thermal.dtsi | 7 ++- arch/arm/dts/omap5-uevm.dts | 2 +- arch/arm/dts/omap5.dtsi | 2 +- 5 files changed, 7 insertions

[PATCH 14/17] arm: dts: dm8x: Non-functional changes sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
This is a collection of all the whitespace, renames, comment, and other changes that should not change the DT functionality from Linux v6.3-rc6. Signed-off-by: Andrew Davis --- arch/arm/dts/da850-evm.dts | 20 ++-- arch/arm/dts/da850-lego-ev3.dts | 2 +- arch/arm/dts/da850

[PATCH 15/17] arm: dts: omap: Non-functional changes sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
This is a collection of all the whitespace, renames, comment, and other changes that should not change the DT functionality from Linux v6.3-rc6. Signed-off-by: Andrew Davis --- arch/arm/dts/omap-gpmc-smsc911x.dtsi | 6 ++-- arch/arm/dts/omap-gpmc-smsc9221.dtsi | 6 ++-- arch

[PATCH 12/17] arm: dts: am3x: Non-functional changes sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
This is a collection of all the whitespace, renames, comment, and other changes that should not change the DT functionality from Linux v6.3-rc6. Signed-off-by: Andrew Davis --- arch/arm/dts/am335x-bone-common.dtsi | 1 - arch/arm/dts/am335x-boneblack-hdmi.dtsi | 7 +- arch

[PATCH 11/17] arm: dts: am437x: Update to IOPAD to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Several DTS files have been updated in the Linux kernel with a new IOPAD macro. Sync for the same here. Signed-off-by: Andrew Davis --- arch/arm/dts/am437x-gp-evm.dts | 315 - arch/arm/dts/am437x-sk-evm.dts | 290 +++--- 2 files changed

[PATCH 13/17] arm: dts: dra7x: Non-functional changes sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
This is a collection of all the whitespace, renames, comment, and other changes that should not change the DT functionality from Linux v6.3-rc6. Signed-off-by: Andrew Davis --- arch/arm/dts/am571x-idk.dts| 6 +- arch/arm/dts/am572x-idk-common.dtsi| 8 +- arch/arm/dts

[PATCH 16/17] arm: dts: keystone: Non-functional changes sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
This is a collection of all the whitespace, renames, comment, and other changes that should not change the DT functionality from Linux v6.3-rc6. Signed-off-by: Andrew Davis --- arch/arm/dts/keystone-clocks.dtsi | 52 +- arch/arm/dts/keystone-k2e-clocks.dtsi | 8 +-- arch

[PATCH 10/17] arm: dts: am3x: Update IOPAD to PADCONF to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Several DTS files have been updated in the Linux kernel with a new PADCONF macro replacing the IOPAD version. Sync for the same here. Signed-off-by: Andrew Davis --- arch/arm/dts/am335x-base0033.dts| 48 ++-- arch/arm/dts/am335x-chiliboard.dts | 66 +++--- arch/arm/dts/am335x

Re: [PATCH v2] env: ti: ti_common.env: Fix get_overlaystring for FIT Image

2023-09-21 Thread Andrew Davis
On 9/21/23 5:49 AM, Manorit Chawdhry wrote: After the refactor with conf- nodes in fitImage, overlaystring wasn't didn't handle the new conf- nodes in FIT Booting. Fix get_overlaystring to handle conf- nodes. Fixes: 837833a724b7 ("environment: ti: Add get_fit_config command to get FIT config st

Re: [Question] TI's u-boot.img is built twice

2023-09-22 Thread Andrew Davis
On 9/22/23 10:01 AM, Simon Glass wrote: Hi Masahiro, On Thu, 21 Sept 2023 at 09:36, Masahiro Yamada wrote: Hi. Since the TI platform migrated to binman, u-boot.img is built twice. It is created by "mkimage -E", then overwritten by binman. So, the data are embedded in the FIT structure ins

Re: [Question] TI's u-boot.img is built twice

2023-09-22 Thread Andrew Davis
On 9/22/23 11:40 AM, Simon Glass wrote: Hi Andrew, On Fri, 22 Sept 2023 at 10:35, Andrew Davis wrote: On 9/22/23 10:01 AM, Simon Glass wrote: Hi Masahiro, On Thu, 21 Sept 2023 at 09:36, Masahiro Yamada wrote: Hi. Since the TI platform migrated to binman, u-boot.img is built twice. It

Re: [Question] TI's u-boot.img is built twice

2023-09-22 Thread Andrew Davis
On 9/22/23 1:29 PM, Simon Glass wrote: Hi Andrew, On Fri, 22 Sept 2023 at 12:14, Andrew Davis wrote: On 9/22/23 11:40 AM, Simon Glass wrote: Hi Andrew, On Fri, 22 Sept 2023 at 10:35, Andrew Davis wrote: On 9/22/23 10:01 AM, Simon Glass wrote: Hi Masahiro, On Thu, 21 Sept 2023 at 09:36

Re: [PATCH v3] env: ti: ti_common.env: Fix get_overlaystring for FIT Image

2023-09-25 Thread Andrew Davis
get FIT config string") Reported-by: Aniket Limaye Signed-off-by: Manorit Chawdhry --- Reviewed-by: Andrew Davis Test Logs: => setenv name_overlays ti/k3-dt.dtbo ti/k3-dt1.dtbo => run get_overlaystring => printenv overlaystring overlaystring=#conf-ti_k3-dt.dtbo#conf-ti_

Re: [RFC PATCH v2 0/8] ATF and OP-TEE Firewalling for K3 devices.

2023-09-26 Thread Andrew Davis
On 9/26/23 2:58 AM, Manorit Chawdhry wrote: K3 devices have firewalls that are used to prevent illegal accesses to memory regions that are deemed secure. The series prevents the illegal accesses to ATF and OP-TEE regions that are present in different K3 devices. AM62AX and AM64X are currently in

Re: [PATCH 1/2] board: ti: am62x: am62x.env: Fix boot_targets

2023-10-04 Thread Andrew Davis
On 10/4/23 8:23 AM, Roger Quadros wrote: ti_mmc is not a valid boot_target for standard boot flow so Is there some way to make it into a valid boot_target? Otherwise how do we use uEnv.txt files, or boot from FIT images with overlays? Andrew remove it. Prefer mmc1 (sd-card) over mmc0 (emmc).

Re: [PATCH 1/2] board: ti: am62x: am62x.env: Fix boot_targets

2023-10-05 Thread Andrew Davis
On 10/4/23 8:54 AM, Nishanth Menon wrote: On 08:48-20231004, Andrew Davis wrote: On 10/4/23 8:23 AM, Roger Quadros wrote: ti_mmc is not a valid boot_target for standard boot flow so Is there some way to make it into a valid boot_target? Otherwise how do we use uEnv.txt files, or boot from

[PATCH] arm: mach-k3: Remove secure device makefile

2023-10-05 Thread Andrew Davis
This is now done using binman but this file was leftover and is now unused, remove it. Signed-off-by: Andrew Davis --- MAINTAINERS | 1 - arch/arm/mach-k3/config_secure.mk | 44 --- 2 files changed, 45 deletions(-) delete mode 100644 arch/arm

Re: [PATCH 1/2] board: ti: am62x: am62x.env: Fix boot_targets

2023-10-05 Thread Andrew Davis
On 10/5/23 12:16 PM, Nishanth Menon wrote: On 12:10-20231005, Nishanth Menon wrote: On 12:36-20231005, Tom Rini wrote: On Thu, Oct 05, 2023 at 09:19:48AM -0500, Andrew Davis wrote: On 10/4/23 8:54 AM, Nishanth Menon wrote: On 08:48-20231004, Andrew Davis wrote: On 10/4/23 8:23 AM, Roger

[PATCH] environment: ti: Add get_fit_config command to get FIT config string

2023-04-25 Thread Andrew Davis
lt is fdtfile needs mangled when used to select a config node from OE made FIT image. Do this here. Signed-off-by: Andrew Davis --- include/configs/ti_armv7_common.h | 3 ++- include/environment/ti/ti_armv7_common.env | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --gi

Re: [PATCH v3 11/19] am64x: dts: binman: Package tiboot3.bin, tispl.bin u-boot.img

2023-04-25 Thread Andrew Davis
On 4/25/23 2:31 AM, Neha Malcom Francis wrote: Hi Simon On 25/04/23 01:12, Simon Glass wrote: Hi Neha, On Fri, 21 Apr 2023 at 06:32, Neha Malcom Francis wrote: Support added for HS and GP boot binaries for AM64x. tiboot3.bin, tispl.bin and u-boot.img: For HS-SE devices tiboot3.bin_fs, tisp

Re: [PATCH v2] arch: arm: mach-k3: Delete tifs node in DT fixup

2023-05-01 Thread Andrew Davis
On 4/26/23 9:13 AM, Kumar, Udit wrote: Hi Neha, On 4/26/2023 5:31 PM, Neha Malcom Francis wrote: Hi Udit On 26/04/23 16:09, Kumar, Udit wrote: Hi Neha, Hi Udit, [..] I do have a general doubt; why do we have only atf-sram sub-node in msmc_sram in all other devices (j721e, j7200 and am6

Re: [PATCH] firmware: ti_sci: Add missing LF in error message

2023-05-10 Thread Andrew Davis
00: Message not acknowledgedAuthentication failed!" Fix ths by adding the missing linefeed character. s/ths/this Signed-off-by: Andreas Dannenberg --- Good find, Acked-by: Andrew Davis drivers/firmware/ti_sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] arm: mach-k3: arm64-mmu: do not map ATF and OPTEE regions in A53 MMU

2023-05-11 Thread Andrew Davis
On 5/11/23 4:58 AM, kaml...@ti.com wrote: From: Kamlesh Gurudasani Do not include ATF and OPTEE regions in MMU table for am64, am62, am62a as access to those regions is not allowed anyway. Commit messages should include the "why" we are doing this. Create separate table as ATF region are a

Re: [PATCH v4 05/23] j721e: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img

2023-05-18 Thread Andrew Davis
On 5/18/23 9:26 AM, Neha Malcom Francis wrote: By providing entries in the binman node of the device tree, binman will be able to find and package board config artifacts generated by TIBoardConfig with sysfw.bin and generate the final image sysfw.itb. It will also pick out the R5 SPL and sign it

Re: [PATCH v4 23/23] configs: am64x: Enable TI_SECURE_DEV options

2023-05-18 Thread Andrew Davis
On 5/18/23 9:27 AM, Neha Malcom Francis wrote: From: Kamlesh Gurudasani AM64x family of SoCs by default will have some level of security enforcement checking. Enable CONFIG_TI_SECURE_DEVICE by default so all levels of secure SoCs will boot with binman. Signed-off-by: Kamlesh Gurudasani Signed

Re: [PATCH v4 23/23] configs: am64x: Enable TI_SECURE_DEV options

2023-05-22 Thread Andrew Davis
On 5/22/23 7:35 AM, Kamlesh Gurudasani wrote: Neha Malcom Francis writes: Hi Andrew On 18/05/23 22:09, Andrew Davis wrote: On 5/18/23 9:27 AM, Neha Malcom Francis wrote: From: Kamlesh Gurudasani AM64x family of SoCs by default will have some level of security enforcement checking. Enable

Re: [PATCH 6/6] doc: board: ti: Add beagleplay documentation

2023-07-26 Thread Andrew Davis
On 7/26/23 11:21 AM, Tom Rini wrote: On Wed, Jul 26, 2023 at 09:59:16AM -0500, Andrew Davis wrote: On 7/25/23 5:45 PM, Tom Rini wrote: On Tue, Jul 25, 2023 at 05:00:15PM -0500, Nishanth Menon wrote: On 17:35-20230725, Tom Rini wrote: On Tue, Jul 25, 2023 at 01:52:53PM -0500, Nishanth Menon

Re: [PATCH 6/6] doc: board: ti: Add beagleplay documentation

2023-07-26 Thread Andrew Davis
On 7/25/23 5:45 PM, Tom Rini wrote: On Tue, Jul 25, 2023 at 05:00:15PM -0500, Nishanth Menon wrote: On 17:35-20230725, Tom Rini wrote: On Tue, Jul 25, 2023 at 01:52:53PM -0500, Nishanth Menon wrote: [...] + +Build procedure: + +1. Trusted Firmware-A: + +.. code-block:: bash

Re: [PATCH V2 1/3] omap: timer: add ti,am654-timer compatibility

2023-07-26 Thread Andrew Davis
On 7/26/23 10:10 AM, Nishanth Menon wrote: From: Sjoerd Simons THe TI AM654 timer is compatible with the omap-timer implementation, so s/THe/The add it to the id list s/id list/compatible ID list. Andrew Signed-off-by: Sjoerd Simons Reviewed-by: Tom Rini Tested-by: Ravi Gunasekaran

Re: [PATCH v2 1/2] board: ti: am64x: Recognize AM64-HSEVM

2023-07-31 Thread Andrew Davis
On 7/31/23 7:27 AM, Roger Quadros wrote: AM64-HSEVM is AM64-GPEVM with High Security Device. Gets rid of "Unidentified board claims AM64-HSEVM in eeprom header". Signed-off-by: Roger Quadros --- Acked-by: Andrew Davis board/ti/am64x/evm.c | 3 ++- 1 file changed, 2 insert

Re: [PATCH] board: ti: am62x: Add variable device tree in env

2023-07-31 Thread Andrew Davis
On 7/31/23 9:27 AM, Jason Kacines wrote: Added variable default_device_tree that grabs from defconfig. Prevents needing to change this variable in two locations if using a separate device tree. In the future, it would be a good idea to remove this logic completely, but this will help reduce compl

[PATCH 1/2] configs: am65x: Merge the HS and non-HS defconfigs

2023-08-03 Thread Andrew Davis
K3 devices have runtime type board detection. Make the default defconfig include the secure configuration. Then remove the HS specific config. Non-HS devices will continue to boot due to runtime device type detection. Signed-off-by: Andrew Davis --- MAINTAINERS | 2

[PATCH 2/2] configs: Make TI_SECURE_DEVICE default for K3

2023-08-03 Thread Andrew Davis
: Andrew Davis --- arch/arm/Kconfig | 1 + configs/am62ax_evm_a53_defconfig | 1 - configs/am62ax_evm_r5_defconfig | 1 - configs/am62x_evm_a53_defconfig | 1 - configs/am62x_evm_r5_defconfig | 1 - configs/am64x_evm_a53_defconfig | 1 - configs/am64x_evm_r5_defconfig | 1

Re: [PATCH] common: bouncebuf: Add missing cast to dma_addr_t

2023-08-14 Thread Andrew Davis
ay seems fine, Reviewed-by: Andrew Davis Signed-off-by: Marek Vasut --- Cc: Andrew Davis Cc: Simon Glass --- common/bouncebuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/bouncebuf.c b/common/bouncebuf.c index 93a35668cc2..934b83f7ec3 100644 --- a/common/boun

Re: [PATCH 2/2] doc: ti: add the K3 generation page

2023-01-03 Thread Andrew Davis
On 12/19/22 2:29 PM, Bryan Brattlof wrote: Texas Instrument's entire K3 generation of SoCs use much of the same frameworks and boot flow, especially at the uboot level. Though there are small differences introduced as each new K3 based SoC is developed and as the K3 generation matures that will a

[PATCH] common: bouncebuf: Use dma-mapping for cache ops

2023-01-06 Thread Andrew Davis
This matches how this would be done in Linux and these functions do the alignment for us which makes the code look cleaner. Signed-off-by: Andrew Davis --- common/bouncebuf.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/common/bouncebuf.c b/common

Re: [PATCH] ARM: omap3: evm: Name this directory omap3

2023-01-06 Thread Andrew Davis
On 10/7/22 10:21 PM, Derald Woods wrote: On Fri, Oct 07, 2022 at 12:33:14PM -0500, Andrew Davis wrote: Before this was named just evm, which doesn't match the naming of the other TI board file directory and makes it look like a common directory for evms. Name this omap3. Signed-off-by: A

[PATCH v2] ARM: omap3: evm: Name this directory omap3evm

2023-01-06 Thread Andrew Davis
Before this was named just evm, which doesn't match the naming of the other TI board file directory and makes it look like a common directory for evms. Name this omap3evm. Signed-off-by: Andrew Davis --- Changes from v1: - Call dir omap3evm instead of omap3 arch/arm/mach-omap2/omap3/Kc

Re: [PATCH] firmware: ti_sci: fix typo in boot authentication message name

2023-01-10 Thread Andrew Davis
ed-by: Andrew Davis [0] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h#n50 drivers/firmware/ti_sci.c | 2 +- drivers/firmware/ti_sci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/fir

Re: [PATCH] doc: ti: Add switch setting for boot modes on AM62 SK

2023-01-10 Thread Andrew Davis
On 1/10/23 3:25 PM, Judith Mendez wrote: List some common boot modes and their corresponding switch settings for AM62 SK. Signed-off-by: Judith Mendez --- Acked-by: Andrew Davis doc/board/ti/am62x_sk.rst | 29 + 1 file changed, 29 insertions(+) diff --git a

Re: [PATCH v2] configs: Increase malloc size after relocation

2023-01-11 Thread Andrew Davis
should not be an issue for any K3 device, so make it default for all. Signed-off-by: Neha Malcom Francis --- Acked-by: Andrew Davis Changes since v1: - added ARM64 to conditions to default to 0x40 common/spl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/common/spl

Re: [PATCH 3/3] doc: board: ti: k3: Mention TI_DM argument

2023-12-04 Thread Andrew Davis
"ti-linux-firmware" if that is what you had set as BINMAN_INDIRS. s/ti-linux-firmware/BINMAN_INDIRS Otherwise whole series LGTM, Reviewed-by: Andrew Davis + utilize split firmware. + .. k3_rst_include_end_build_steps_uboot At this point you should have every binary needed

Re: [PATCH 1/2] doc: board: beagle: am62x_beagleplay: Delete SW_PRNG flag for OPTEE

2023-12-05 Thread Andrew Davis
On 12/4/23 1:29 PM, Nishanth Menon wrote: On 15:59-20231201, Dhruva Gole wrote: Delete the flag CFG_WITH_SOFTWARE_PRNG as it's not necessary/ boot requirement for this SoC Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 1 - 1 file changed, 1 deletion(-) diff --git a

Re: [PATCH 1/2] doc: board: beagle: am62x_beagleplay: Delete SW_PRNG flag for OPTEE

2023-12-05 Thread Andrew Davis
On 12/5/23 9:22 AM, Nishanth Menon wrote: On 08:46-20231205, Andrew Davis wrote: On 12/4/23 1:29 PM, Nishanth Menon wrote: On 15:59-20231201, Dhruva Gole wrote: Delete the flag CFG_WITH_SOFTWARE_PRNG as it's not necessary/ boot requirement for this SoC Signed-off-by: Dhruva Gole ---

Re: [PATCH v6 4/8] binman: j721e: Add firewall configurations

2023-12-06 Thread Andrew Davis
On 12/6/23 3:51 AM, Manorit Chawdhry wrote: The following commits adds the configuration of firewalls required to protect ATF and OP-TEE memory region from non-secure reads and writes using master and slave firewalls present in our K3 SOCs. Signed-off-by: Manorit Chawdhry --- arch/arm/dts/k3-

Re: [PATCH v6 8/8] docs: k3: Add secure booting documentation

2023-12-06 Thread Andrew Davis
On 12/6/23 3:51 AM, Manorit Chawdhry wrote: This commit adds a general flow to explain the usage of firewalls and the chain of trust in K3 devices. Signed-off-by: Manorit Chawdhry --- doc/board/ti/k3.rst | 45 + 1 file changed, 45 insertions(+) di

Re: Proposal: FIT support for extension boards / overlays

2023-12-12 Thread Andrew Davis
On 12/12/23 8:05 AM, Simon Glass wrote: Hi, The devicetree files for a board can be quite large, perhaps around 60KB. To boot on any supported board, many of them need to be provided, typically hundreds. All boards for a particular SoC share common parts. It would be helpful to use overlays fo

Re: [PATCH v6 00/17] Introduce initial TI's J784S4 and AM69 support

2023-12-14 Thread Andrew Davis
On 12/14/23 2:10 PM, b...@ti.com wrote: On December 14, 2023 thus sayeth Marcel Ziswiler: Hi Apurva Thanks! On Wed, 2023-12-06 at 18:07 +0530, Apurva Nandan wrote: Hello Everyone! This series will introduce basic support (SD and UART) support for Texas Instruments J784S4 EVM. For the whole

Re: [PATCH v6 00/17] Introduce initial TI's J784S4 and AM69 support

2023-12-15 Thread Andrew Davis
On 12/15/23 2:51 AM, Marcel Ziswiler wrote: On Thu, 2023-12-14 at 14:28 -0600, Andrew Davis wrote: On 12/14/23 2:10 PM, b...@ti.com wrote: On December 14, 2023 thus sayeth Marcel Ziswiler: Hi Apurva Thanks! On Wed, 2023-12-06 at 18:07 +0530, Apurva Nandan wrote: Hello Everyone! This

Re: [PATCH 01/14] arm: mach-k3: Sort CONFIG_SOC* and K3_SOC_ID entries

2024-05-29 Thread Andrew Davis
have it, etc.. No issue with alphabetical either, just looking for a "why" in the commit message, otherwise, Reviewed-by: Andrew Davis Signed-off-by: Jayesh Choudhary --- arch/arm/mach-k3/include/mach/hardware.h | 37 1 file changed, 19 insertions(+), 18

Re: [PATCH 03/14] soc: add info to identify the J722S SoC family

2024-05-29 Thread Andrew Davis
On 5/29/24 8:24 AM, Jayesh Choudhary wrote: Include the part number for TI's j722s family of SoC to identify it during boot. Signed-off-by: Vaishnav Achath Signed-off-by: Jayesh Choudhary --- arch/arm/mach-k3/include/mach/hardware.h | 2 ++ drivers/soc/soc_ti_k3.c | 3 +++

Re: [PATCH 09/14] arch: mach-k3: Introduce basic files to support J722S SoC family

2024-05-29 Thread Andrew Davis
On 5/29/24 8:24 AM, Jayesh Choudhary wrote: Introduce the basic functions and definitions needed to properly initialize TI J722S family of SoCs. Co-developed-by: Vaishnav Achath Signed-off-by: Vaishnav Achath Signed-off-by: Jayesh Choudhary --- arch/arm/mach-k3/Kconfig

Re: [PATCH 1/3] arm: dts: k3-am642-evm-u-boot: Add remoteproc-name for PRU cores

2024-06-07 Thread Andrew Davis
On 5/23/24 1:33 AM, Anwar, Md Danish wrote: Hi Andrew, On 5/22/2024 9:38 PM, Andrew Davis wrote: On 5/22/24 1:36 AM, MD Danish Anwar wrote: Add remoteproc-name property for PRU cores. Signed-off-by: MD Danish Anwar ---   arch/arm/dts/k3-am642-evm-u-boot.dtsi | 44

Re: [PATCH v2 2/8] arm: mach-k3: am62a: Simplify the logic for QOS reg and val propagation

2024-06-14 Thread Andrew Davis
and make the corresponding changes for am62a_qos_uboot file. Suggested-by: Andrew Davis Signed-off-by: Jayesh Choudhary --- Looks a bit better IMHO, Acked-by: Andrew Davis arch/arm/mach-k3/include/mach/k3-qos.h | 86 arch/arm/mach-k3/r5/am62ax/am62a_qos_uboot.c

Re: [PATCH v2 3/8] arm: mach-k3: j721e: Enable QoS for DSS

2024-06-14 Thread Andrew Davis
v/null +++ b/arch/arm/mach-k3/r5/j721e/j721e_qos.h @@ -0,0 +1,96 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Keystone3 Quality of service endpoint definitions Our marketing folks claim it is "K3" not "Keystone3" :), otherwise lgtm, Reviewed-by: Andrew Davis + * Auto

Re: [PATCH 1/6] arm: mach-k3: Add default ATF location for AM62/AM62a

2024-06-19 Thread Andrew Davis
On 6/19/24 1:20 PM, Nishanth Menon wrote: On 17:19-20240619, Dhruva Gole wrote: Hi, On Feb 14, 2024 at 10:30:04 -0600, Andrew Davis wrote: There is a default ATF load address that is used for devices that have ATF running in SRAM. For AM62 and AM62a, ATF runs from DRAM. Instead of having to

Re: [PATCH] board: beagle: beagleplay: enable OF_SYSTEM_SETUP

2024-06-19 Thread Andrew Davis
nel's FDT to inform it of the actual location of the firmware CC: Andrew Davis CC: Nishanth Menon CC: Robert Nelson Reported-by: Dhruva Gole Signed-off-by: Bryan Brattlof --- Acked-by: Andrew Davis Hello everyone, Fair warning, this may turn into a philosophical discussion about t

Re: [RFC PATCH 00/16] Introduce ICSSG Ethernet driver

2024-01-02 Thread Andrew Davis
On 12/27/23 12:56 AM, MD Danish Anwar wrote: On 22/12/23 6:13 pm, Roger Quadros wrote: On 22/12/2023 12:26, MD Danish Anwar wrote: Hi Roger, On 20/12/23 3:29 pm, Roger Quadros wrote: Hi, On 19/12/2023 12:11, MD Danish Anwar wrote: Introduce ICSSG PRUETH support in uboot. The ICSSG driver

Re: [PATCH 1/2] board: ti: am62x: am62x.env: Fix boot_targets

2024-01-02 Thread Andrew Davis
On 12/31/23 6:48 AM, Simon Glass wrote: Hi, On Wed, Nov 29, 2023 at 7:48 PM Simon Glass wrote: Hi Andrew, On Mon, 6 Nov 2023 at 11:05, Andrew Davis wrote: On 11/6/23 11:47 AM, Simon Glass wrote: Hi Andrew, On Mon, 6 Nov 2023 at 10:27, Andrew Davis wrote: On 11/6/23 9:31 AM, Tom Rini

Re: [PATCH v7 4/9] arm: dts: k3-binman: Add k3-security.h and include it in k3-binman.dtsi

2024-01-02 Thread Andrew Davis
0>; Still don't like hardcoding the ATF firewall location here, especially since it is dynamic and we have a var for this: CONFIG_K3_ATF_LOAD_ADDR. Not a blocker, for now.., Reviewed-by: Andrew Davis + end_address = <0x0 0x7

Re: [PATCH 1/2] board: ti: am62x: am62x.env: Fix boot_targets

2024-01-04 Thread Andrew Davis
On 1/4/24 1:52 AM, Manorit Chawdhry wrote: Hi Andrew, Simon, On 08:58-20240102, Andrew Davis wrote: On 12/31/23 6:48 AM, Simon Glass wrote: Hi, On Wed, Nov 29, 2023 at 7:48 PM Simon Glass wrote: Hi Andrew, On Mon, 6 Nov 2023 at 11:05, Andrew Davis wrote: On 11/6/23 11:47 AM, Simon

Re: [PATCH 01/10] board: ti: common: Introduce a common fdt ops library

2024-01-08 Thread Andrew Davis
On 1/8/24 11:32 AM, Nishanth Menon wrote: Introduce a common fdt operations library for basic device tree operations that are common between various boards. The first library to introduce here is the capability to set up fdtfile as a standard variable as part of board identification rather than

Re: [PATCH 08/10] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

2024-01-08 Thread Andrew Davis
On 1/8/24 11:32 AM, Nishanth Menon wrote: Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Signed-off-by: Nishanth Menon --- board/beagle/beagleboneai64/beagleboneai64.c | 14

Re: [PATCH v3 0/8] Suspend to RAM support for K3 J7200

2024-01-09 Thread Andrew Davis
On 1/8/24 10:56 AM, Thomas Richard wrote: This series is the U-Boot part of the work to add the suspend to RAM support for the K3 J7200 EVM board. During the boot R5 SPL makes a copy of DM-Firmware and TF-A in memory. Resume detection is done by reading a magic value in a pmic register (set by D

Re: [PATCH v3 0/8] Suspend to RAM support for K3 J7200

2024-01-12 Thread Andrew Davis
On 1/10/24 3:34 AM, Thomas Richard wrote: On 1/9/24 18:32, Andrew Davis wrote: On 1/8/24 10:56 AM, Thomas Richard wrote: This series is the U-Boot part of the work to add the suspend to RAM support for the K3 J7200 EVM board. During the boot R5 SPL makes a copy of DM-Firmware and TF-A in

Re: [PATCH RFC] Kconfig: Add support for FIT image signature enforcing

2024-01-17 Thread Andrew Davis
On 1/11/24 4:34 AM, Manorit Chawdhry wrote: FIT_SIGNATURE doesn't enforce the U-boot setup to be correct for booting the FIT images, the DTB might not have all the proper nodes and it just boots up without any warning. This makes it difficult to get the correct setup working. Adds an enforcement

<    1   2   3   4   >