Re: [PATCH 10/15] efi_loader: Add support for logging EFI calls

2024-10-29 Thread Heinrich Schuchardt
Am 28. Oktober 2024 13:48:01 MEZ schrieb Simon Glass : >The current logging system suffers from some disadvantages, mainly that >it writes its output to the console and cannot be easily reviewed. > >Add a dedicated log, storing records in a binary format and including >the result codes and any r

[GIT PULL] u-boot-riscv/master

2024-10-29 Thread Leo Liang
Hi Tom, The following changes since commit bfdfc6c12e8ca68fff1a7ed3892c180143a6a0ef: Revert "acpi_table: Fix coverity defect in acpi_write_spcr" (2024-10-28 20:53:34 -0600) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-riscv.git for you to fetch

Re: [PATCH] lmb: Correctly unmap and free memory on errors

2024-10-29 Thread Ilias Apalodimas
Hi Heinrich On Mon, 28 Oct 2024 at 08:40, Heinrich Schuchardt wrote: > > On 10/24/24 12:46, Ilias Apalodimas wrote: > > We never free and unmap the memory on errors and we never unmap it when > > freeing it. This won't cause any problems on actual hardware but it will > > on sandbox > > > > Fixes

Re: [PATCH] lmb: Correctly unmap memory after notifications

2024-10-29 Thread Ilias Apalodimas
Hi Heinrich On Tue, 29 Oct 2024 at 10:00, Ilias Apalodimas wrote: > > Hi Heinrich > > On Mon, 28 Oct 2024 at 08:37, Heinrich Schuchardt wrote: > > > > On 10/24/24 12:46, Ilias Apalodimas wrote: > > > We never unmap the memory used to update the EFI memory map after > > > notifications > > > > >

Re: [RFC PATCH 2/2] apple: dart: use driver specific instance of LMB

2024-10-29 Thread Sughosh Ganu
On Tue, 29 Oct 2024 at 14:02, Janne Grunau wrote: > > Hej, > > On Tue, Oct 29, 2024 at 12:48:46PM +0530, Sughosh Ganu wrote: > > The LMB module is typically used for managing the platform's RAM > > memory. RAM memory gets added to the module's memory map, and > > subsequently allocated through var

[PATCH 3/4] board/BuR/common: split br_resetc_bmode function

2024-10-29 Thread Bernhard Messerklinger
Split br_resetc_bmode function to add support for reading of reset reason in board code with br_resetc_bmode_get. Signed-off-by: Bernhard Messerklinger --- board/BuR/common/br_resetc.c | 129 --- board/BuR/common/br_resetc.h | 1 + 2 files changed, 74 insertion

[PATCH 1/4] board/BuR/common: use strlcpy instead of strncpy

2024-10-29 Thread Bernhard Messerklinger
Now strlcpy is used to copy the defip string to the corresponding environment variable. This preserves memory for the NULL termination. Signed-off-by: Bernhard Messerklinger --- board/BuR/common/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/BuR/common/common

[PATCH 0/4] Update board/BuR/common to keep current mainline boards compatible

2024-10-29 Thread Bernhard Messerklinger
Bernhard Messerklinger (4): board/BuR/common: use strlcpy instead of strncpy board/BuR/common: add parameter for reset controller I2C bus selection board/BuR/common: split br_resetc_bmode function board/BuR/zynq: initial commit arch/arm/dts/Makefile | 8 +- arc

Re: [GIT PULL] u-boot-riscv/next

2024-10-29 Thread Michal Simek
út 29. 10. 2024 v 10:35 odesílatel Leo Liang napsal: > > Hi Tom, > > On Mon, Oct 28, 2024 at 09:20:10AM -0600, Tom Rini wrote: > > [EXTERNAL MAIL] > > Date: Mon, 28 Oct 2024 09:20:10 -0600 > > From: Tom Rini > > To: Leo Liang > > Cc: u-boot@lists.denx.de, r...@andestech.com > > Subject: Re: [GIT

Re: [PATCH] riscv: resume needs to be a global

2024-10-29 Thread Leo Liang
On Thu, Aug 08, 2024 at 02:14:17AM +, Anton Blanchard wrote: > If we take an exception before u-boot is relocated, there's a good > chance we will end up in an endless loop of exceptions because resume is > invalid until after relocation. > > Signed-off-by: Anton Blanchard > --- > arch/riscv

[PATCH] test/py: spi: prevent overwriting relocation memory

2024-10-29 Thread Padmarao Begari
Update spi negative test case to prevent SF command from overwriting relocation memory area. Signed-off-by: Padmarao Begari --- test/py/tests/test_spi.py | 12 1 file changed, 12 insertions(+) diff --git a/test/py/tests/test_spi.py b/test/py/tests/test_spi.py index 3160d58540..caca

Re: [PATCH v2 2/3] board: mpfs_icicle: imply new clk driver dependencies

2024-10-29 Thread Leo Liang
On Wed, Oct 23, 2024 at 11:17:53AM +0100, Conor Dooley wrote: > From: Conor Dooley > > The clock driver for PolarFire SoC now requires syscon and regmap > features, so imply them to preserve implication of the clock driver. > > Signed-off-by: Conor Dooley > --- > board/microchip/mpfs_icicle/Kc

Re: [PATCH v2 1/3] clk: microchip: mpfs: support new syscon based devicetree configuration

2024-10-29 Thread Leo Liang
On Wed, Oct 23, 2024 at 11:17:52AM +0100, Conor Dooley wrote: > From: Conor Dooley > > Why get a devicetree description wrong once when you can get it wrong > twice? The original mistake, which the driver supports was failing to > describe the main PLL that the "cfg" and "periph" clocks parented

Re: [PATCH] lmb: Correctly unmap memory after notifications

2024-10-29 Thread Ilias Apalodimas
Hi Heinrich On Mon, 28 Oct 2024 at 08:37, Heinrich Schuchardt wrote: > > On 10/24/24 12:46, Ilias Apalodimas wrote: > > We never unmap the memory used to update the EFI memory map after > > notifications > > > > Fixes: commit 2f6191526a13 ("lmb: notify of any changes to the LMB memory > > map")

Re: [PATCH 2/2] ARM: renesas: Drop old unused power DT headers

2024-10-29 Thread Adam Ford
On Sun, Oct 27, 2024 at 5:58 AM Paul Barker wrote: > > On 27/10/2024 02:04, Marek Vasut wrote: > > Renesas R-Car systems use mainline Linux DTs for U-Boot via OF_UPSTREAM, > > which also includes headers from dts/upstream/include/dt-bindings/power . > > Remove unused legacy DT header files from in

Re: [PATCH 00/15] efi_loader: Add support for logging to a buffer

2024-10-29 Thread Simon Glass
Hi Ilias, On Tue, 29 Oct 2024 at 10:58, Ilias Apalodimas wrote: > > Hi Simon, > > On Mon, 28 Oct 2024 at 14:48, Simon Glass wrote: > > > > It is a bit of a pain to log EFI boot-services calls at present. The > > output goes to the console so cannot easily be inspected later. Also it > > would be

Re: [PATCH 00/15] efi_loader: Add support for logging to a buffer

2024-10-29 Thread Ilias Apalodimas
On Tue, 29 Oct 2024 at 17:45, Simon Glass wrote: > > Hi Ilias, > > On Tue, 29 Oct 2024 at 10:58, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Mon, 28 Oct 2024 at 14:48, Simon Glass wrote: > > > > > > It is a bit of a pain to log EFI boot-services calls at present. The > > > output goes

Re: [PATCH v7 01/11] test: Allow signaling that U-Boot is ready

2024-10-29 Thread Tom Rini
On Wed, Oct 09, 2024 at 07:51:35PM -0600, Simon Glass wrote: > When Labgrid is used, it can get U-Boot ready for running tests. It > prints a message when it has done so. > > Add logic to detect this message and accept it. > > Note that this does not change pytest, which still (also) looks for t

Re: [PATCH v7 10/11] test: Support testing with two board-builds

2024-10-29 Thread Tom Rini
On Wed, Oct 09, 2024 at 07:51:44PM -0600, Simon Glass wrote: > The Beagleplay board uses two entirely separate builds to produce an > image, rather than using an SPL build for this purpose. JFTR, this is an incorrect explanation of what's going on. The TI K3 families have both a Cortex-R core and

Re: [PATCH v7 05/11] test: Introduce lab mode

2024-10-29 Thread Tom Rini
On Wed, Oct 09, 2024 at 07:51:39PM -0600, Simon Glass wrote: > There is quite a bit of code in pytest to try to start up U-Boot on a > board, with timeouts, expects, etc. > > This is tedious to maintain and is peripheral to the test system's > purpose. It seems better to put this logic in the lab

Re: [PATCH v7 03/11] test: Allow connecting to a running board

2024-10-29 Thread Tom Rini
On Wed, Oct 09, 2024 at 07:51:37PM -0600, Simon Glass wrote: > Sometimes we know that the board is already running the right software, > so provide an option to allow running of tests directly, without first > resetting the board. > > This saves time when re-running a test where only the Python c

Re: [PATCH v7 02/11] test: Release board after tests complete

2024-10-29 Thread Tom Rini
On Wed, Oct 09, 2024 at 07:51:36PM -0600, Simon Glass wrote: > When a board is finished with, the lab may want to power it off, or > perform some other function. Add a new script which is called when tests > are complete. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini But please note I

Re: [PATCH v7 09/11] test: Add a section for closing the connection

2024-10-29 Thread Tom Rini
On Wed, Oct 09, 2024 at 07:51:43PM -0600, Simon Glass wrote: > This can take a while and involve multiple steps (e.g. turning the board > back off). Add a section for it and show the output. > > Signed-off-by: Simon Glass Logging can be useful, so this is fine. Reviewed-by: Tom Rini -- Tom

Re: [PATCH v7 06/11] test: Improve handling of sending commands

2024-10-29 Thread Tom Rini
On Wed, Oct 09, 2024 at 07:51:40PM -0600, Simon Glass wrote: > We expect commands to be echoed and this should happen quite quickly, > since U-Boot is sitting at the prompt waiting for a command. > > Reduce the timeout for this situation. Try to produce a more useful > error message when somethin

Re: [PATCH v7 08/11] test: Try to shut down the lab console gracefully

2024-10-29 Thread Tom Rini
On Wed, Oct 09, 2024 at 07:51:42PM -0600, Simon Glass wrote: > Send the Labgrid quit characters to ask it to exit gracefully. This > typically allows it to power off the board being used. Only do this when > labgrid is being used (detected with an env var). > > If that doesn't work, try the less

Re: [PATCH v9 02/11] efi_loader: Add a test app

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 08:22:10PM +0100, Simon Glass wrote: > Add a simple app to use for testing. This is intended to do whatever it > needs to for testing purposes. For now it just prints a message and > exits boot services. > > There was a considerable amount of discussion about whether it is

Re: [PATCH v9 03/11] sandbox: Add a -N flag to control on-host behaviour

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 08:22:11PM +0100, Simon Glass wrote: > Sandbox is its own architecture, but sometimes we want to mimic the host > architecture, e.g. when running an EFI app not built by U-Boot. > > Add a -N/--native flag which tells sandbox to reflect the architecture > of the host. > >

Re: [PATCH v9 08/11] efi_loader: Drop sandbox PXE architecture

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 08:22:16PM +0100, Simon Glass wrote: > Rather than returning 0, just return an error, since sandbox is not used > with PXE at present. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v1 0/3] Support Aspeed SGPIO controller

2024-10-29 Thread Tom Rini
On Wed, 16 Oct 2024 16:59:52 +0800, Billy Tsai wrote: > AST2600 SoC has 2 SGPIO master interfaces one with 128 pins another one > with 80 pins, AST2500/AST2400 SoC has 1 SGPIO master interface that > supports up to 80 pins. > > Billy Tsai (3): > gpio: Add Aspeed SGPIO driver > ARM: dts: ast25

[PATCH] test/cmd/mem_copy.c: Use CONFIG_SYS_LOAD_ADDR for base

2024-10-29 Thread Tom Rini
When reading/writing to memory we cannot assume that a base address of 0x0 is correct and functional. So use CONFIG_SYS_LOAD_ADDR as the base from which we add a bit more padding and being our tests. Signed-off-by: Tom Rini --- test/cmd/mem_copy.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH 09/15] efi_loader: Fix free in ..._media_device_boot_option()

2024-10-29 Thread Heinrich Schuchardt
Am 29. Oktober 2024 16:45:29 MEZ schrieb Simon Glass : >Hi Ilias, > >On Tue, 29 Oct 2024 at 11:02, Ilias Apalodimas > wrote: >> >> Hi Simon, >> >> On Mon, 28 Oct 2024 at 14:48, Simon Glass wrote: >> > >> > Freeing a NULL pointer is an error in EFI, so check the pointer first, >> > before freein

Re: [PATCH 10/15] efi_loader: Add support for logging EFI calls

2024-10-29 Thread Heinrich Schuchardt
Am 28. Oktober 2024 13:48:01 MEZ schrieb Simon Glass : >The current logging system suffers from some disadvantages, mainly that >it writes its output to the console and cannot be easily reviewed. > >Add a dedicated log, storing records in a binary format and including >the result codes and any r

Re: [PATCH] dm: core: downgrade some dm_warn messages to log_debug()

2024-10-29 Thread Tom Rini
On Tue, 15 Oct 2024 16:32:14 +0200, Quentin Schulz wrote: > People complained that enabling (SPL_)DM_WARN was now totally unusable > due to the amount of messages printed on the console. > > Let's downgrade the log level of some messages that are clearly not on > the error path. > > Note that th

Re: [PATCH 1/1] cmd: simplify network definitions in Makefile

2024-10-29 Thread Tom Rini
On Sat, 19 Oct 2024 12:24:45 +0200, Heinrich Schuchardt wrote: > /Makefile already adds lib include paths to UBOOTINCLUDE. There is no point > in adding the same paths again. > > Clearly separate the lines relating to NET and to NET_LWIP. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] lmb: add a check to prevent memory overrun

2024-10-29 Thread Tom Rini
On Mon, 21 Oct 2024 22:48:20 +0530, Sughosh Ganu wrote: > When printing the LMB flags for a memory region, there is a need to > check that the array index that is computed is a sane value. Put a > noisy assert in case this check fails, as that implies something with > the LMB code is not working a

Re: (subset) [PATCH 1/3] test/cmd: Make some "ut dm" tests only available on sandbox

2024-10-29 Thread Tom Rini
On Mon, 28 Oct 2024 10:48:42 -0600, Tom Rini wrote: > Currently, the "dm" suite in unit tests (ut) is only available on > sandbox. Make sure that all cmd tests that are part of this suite are > only available on sandbox and not attempted to be run on hardware (where > it will fail to be able to be

Re: [PATCH] fdt: lmb: add reserved regions as no-overwrite

2024-10-29 Thread Tom Rini
On Mon, 21 Oct 2024 22:54:33 +0530, Sughosh Ganu wrote: > The boot_fdt_add_mem_rsv_regions() function reserves the memreserve and > reserved-memory regions. These regions are being set with the LMB_NONE > flag which allows overwriting and re-using the regions. This was fine > earlier when the LMB

Re: [PATCH] board_r: Remove duplicate headers

2024-10-29 Thread Tom Rini
On Wed, 23 Oct 2024 08:27:50 +0300, Ilias Apalodimas wrote: > efi_loader.h is included twice. Remove one and move the other in > alphabetical order > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v2] lmb: Remove lmb_alloc_flags()

2024-10-29 Thread Tom Rini
On Wed, 23 Oct 2024 18:26:36 +0300, Ilias Apalodimas wrote: > lmb_alloc_flags() & lmb_alloc_base_flags() are just a wrappers for > _lmb_alloc_base(). Since the only difference is the max address of the > allowed allocation which _lmb_alloc_base() already supports with the > LMB_ALLOC_ANYWHERE flag

Re: [PATCHv2] Kconfig: Remove TARGET_TRICORDER references

2024-10-29 Thread Tom Rini
On Sat, 26 Oct 2024 08:09:59 -0600, Tom Rini wrote: > These were missed when removing the rest of the tricorder platform. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] disk: Mark static functions in part_efi.c

2024-10-29 Thread Tom Rini
On Sat, 26 Oct 2024 11:05:53 +0300, Ilias Apalodimas wrote: > Mark all the functions that are only defined locally as static and > quiesce W=1 warnings > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] cmd: fat: Make do_fat_size static

2024-10-29 Thread Tom Rini
On Sat, 26 Oct 2024 10:33:09 +0300, Ilias Apalodimas wrote: > This is only used locally,so make it static > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 1/2] lmb: Fix lmb_add_region_flags() return codes and testing

2024-10-29 Thread Tom Rini
On Wed, 23 Oct 2024 18:22:00 +0300, Ilias Apalodimas wrote: > The function description says this should return 0 or -1 on failures. > When regions coalesce though this returns the number of coalescedregions > which is confusing and requires special handling of the return code. > On top of that no

Re: [PATCHv2 1/2] CONFIG_SYS_NONCACHED_MEMORY: Move prototypes to include/cpu_func.h for consistency

2024-10-29 Thread Tom Rini
On Tue, 22 Oct 2024 10:31:17 -0600, Tom Rini wrote: > Currently, a number of generic cache related functions have their common > prototype declared in include/cpu_func.h. Move the current set of > noncached functions there as well to match. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] libfdt: Fix build with swig 4.3.0

2024-10-29 Thread David Gibson
On Tue, Oct 29, 2024 at 08:52:52PM +0800, Xi Ruoyao wrote: > On Sat, 2024-10-26 at 12:34 +, Rudi Heitbaum wrote: > > Call SWIG_AppendOutput instead of SWIG_Python_AppendOutput so that > > is_void is handled within swig. > > > > Link: > > https://github.com/swig/swig/commit/cd39cf132c96a0887be

[PATCH] lib: uuid: fix 32-bit support

2024-10-29 Thread Caleb Connolly
In 22c48a92cdce (lib: uuid: supporting building as part of host tools), some instances of simple_strtoull() were accidentally replaced with strtoul() instead (spot the difference!). To keep compatibility with building as part of host tools, re-implement this via a new hextoull macro to handle both

Re: [PATCH] lib: uuid: fix 32-bit support

2024-10-29 Thread Tom Rini
On Wed, Oct 30, 2024 at 01:32:55AM +0100, Caleb Connolly wrote: > In 22c48a92cdce (lib: uuid: supporting building as part of host tools), > some instances of simple_strtoull() were accidentally replaced with > strtoul() instead (spot the difference!). > > To keep compatibility with building as par

[GIT PULL] Please pull u-boot-imx-master-20241029

2024-10-29 Thread Fabio Estevam
/custodians/u-boot-imx.git tags/u-boot-imx-master-20241029 for you to fetch changes up to d88bcd6d247a2b5d1683e393d8c9dc0259cd29f0: net: dwc_eth_qos: Remove obsolete imx8 includes (2024-10-29 16:25:53 -0300) u-boot-imx-master-20241029 -- CI: https://source.denx.de/u-boot

Re: [PATCH 1/3] net: dwc_eth_qos: Add support for platform specific reset

2024-10-29 Thread Fabio Estevam
On Mon, Oct 28, 2024 at 6:42 PM Erik Schumacher wrote: > > This patch adds support for optional platform specific reset logic in > the dwc_eth_qos driver. This new function 'eqos_fix_soc_reset' is called > after the EQOS_DMA_MODE_SWR is set and before the driver waits for this > bit to clear. > >

Re: [PATCH] arm64: imx: Fix 0Xnn to 0xnn

2024-10-29 Thread Fabio Estevam
On Sat, Oct 26, 2024 at 5:15 PM Marek Vasut wrote: > > Use lowercase 0x prefix for hexadecimal number to be consistent > No functional change. > > Signed-off-by: Marek Vasut Applied, thanks.

Re: [PATCH v3] board: emcraft: Add support for Emcraft Systems NavQ+

2024-10-29 Thread Fabio Estevam
On Sun, Oct 27, 2024 at 6:30 PM Fabio Estevam wrote: > This version looks good, thanks: > > Reviewed-by: Fabio Estevam Applied, thanks.

Re: [PATCH v8 06/11] lib: uuid: supporting building as part of host tools

2024-10-29 Thread Caleb Connolly
Hey Patrick, Wow thanks for tracking this one down. On 28/10/2024 15:14, Patrick DELAUNAY wrote: > Hi, > > > This patch seens cause problemes for STM32MP1 platforms, AARCH32 > > For FIP UUID configuration. > > > On 8/30/24 14:34, Caleb Connolly wrote: >> Adjust the UUID library code so that

[PATCH v9 11/11] test: efi: boot: Add a test for the efi bootmeth

2024-10-29 Thread Simon Glass
Add a simple test of booting with the EFI bootmeth, which runs the app and checks that it can call 'exit boot-services' (to check that all the device-removal code doesn't break anything) and then exit back to U-Boot. This uses a disk image containing the testapp, ready for execution by sandbox whe

RE: Issue in probing QSPI flash in Cyclone V SOC

2024-10-29 Thread Santhosh Kumar Janardhanam
Hi All, Has Anyone faced this issue, any suggestion to resolve the below issue would be very helpful? Thanks, Santhosh From: Santhosh Kumar Janardhanam Sent: Friday, October 25, 2024 7:42 PM To: u-boot@lists.denx.de Subject: Issue in probing QSPI flash in Cyclone V SOC Hi All, we are testing QSP

Re: [PATCH 00/15] efi_loader: Add support for logging to a buffer

2024-10-29 Thread Ilias Apalodimas
Hi Simon, On Mon, 28 Oct 2024 at 14:48, Simon Glass wrote: > > It is a bit of a pain to log EFI boot-services calls at present. The > output goes to the console so cannot easily be inspected later. Also it > would be useful to be able to store the log and review it later, perhaps > after somethin

Re: [PATCH] libfdt: Fix build with swig 4.3.0

2024-10-29 Thread Xi Ruoyao
On Sat, 2024-10-26 at 12:34 +, Rudi Heitbaum wrote: > Call SWIG_AppendOutput instead of SWIG_Python_AppendOutput so that > is_void is handled within swig. > > Link: > https://github.com/swig/swig/commit/cd39cf132c96a0887be07c826b80804d7677a701 > > Signed-off-by: Rudi Heitbaum Dtc is a sepa

Re: [PATCH v2 3/8] sysinfo: Add sysinfo driver and data structure for smbios

2024-10-29 Thread Simon Glass
Hi Raymond, On Mon, 28 Oct 2024 at 20:44, Raymond Mao wrote: > > Hi Simon, > > On Mon, 28 Oct 2024 at 13:04, Simon Glass wrote: >> >> Hi Raymond, >> >> On Tue, 22 Oct 2024 at 22:06, Raymond Mao wrote: >> > >> > Add sysinfo driver to retrieve smbios information (Type 4 and 7). >> > So that the s

Re: Pincontrol driver

2024-10-29 Thread Simon Glass
Hi Jayaramudu, On Thu, 24 Oct 2024 at 06:58, Jayaramudu .D wrote: > > Hi, > > I am working on a board which AMD soc, trying to enable gpio at uboot, but > I did not see AMD pincontrol driver in U-boot 2024. Could you please > suggest any info. I would suggest you could look at the MAINTAINERS fi

Re: [PATCH v3 2/2] binman: expand test coverage to nxp_imx8mcst

2024-10-29 Thread Simon Glass
Hi Brian, On Mon, 21 Oct 2024 at 09:38, Brian Ruley wrote: > > Add coverage for IMX8M code siging. Create PKI tree and other assets > required by `cst' using `hab4_pki_tree.sh' script and `srktool' in > `cst_3.4.1' [1]. > > [1] https://www.nxp.com/webapp/Download?colCode=IMX_CST_TOOL_NEW > > Sign

Re: [PATCH v8 2/8] efi_loader: Add a test app

2024-10-29 Thread Simon Glass
Hi Heinrich, On Mon, 28 Oct 2024 at 19:43, Heinrich Schuchardt wrote: > > On 10/28/24 18:00, Simon Glass wrote: > > Hi Heinrich, > > > > On Mon, 28 Oct 2024 at 07:11, Heinrich Schuchardt > > wrote: > > > > > > On 10/22/24 14:00, Simon Glass wrote: > > > > Add a simp

Re: [PATCH 03/21] bloblist: test: doc: Move into the common suite

2024-10-29 Thread Simon Glass
Hi Tom, On Mon, 28 Oct 2024 at 20:33, Tom Rini wrote: > > On Mon, Oct 28, 2024 at 01:41:08PM +0100, Simon Glass wrote: > > > There is no particular need for bloblist to have its own test suite. > > Move it into the common suite instead. > > > > Add the missing help for 'common' and update the doc

Re: [PATCH] test/py: spi: prevent overwriting relocation memory

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 05:17:09PM +0530, Padmarao Begari wrote: > Update spi negative test case to prevent SF command > from overwriting relocation memory area. > > Signed-off-by: Padmarao Begari > --- > test/py/tests/test_spi.py | 12 > 1 file changed, 12 insertions(+) > > diff

[PATCH v1 1/1] drivers: bootcount: Add ZynqMP specific bootcount support

2024-10-29 Thread Vasileios Amoiridis
From: Vasileios Amoiridis Add native support of the bootcount mechanism in the ZynqMP by utilising internal PMU registers. The Persistent Global Storage Registers of the Platform Management Unit can keep their value during reboot cycles unless there is a POR reset, making them appropriate for

Re: (subset) [PATCH v2 00/13] boards: siemens: iot2050: SM variant, sysinfo support, fixes & cleanups

2024-10-29 Thread Tom Rini
On Tue, 22 Oct 2024 08:04:17 +0200, Jan Kiszka wrote: > Changes in v2: > - rebased over master, adding the missing 6.12 cherry-picks from >devicetree-rebasing > > This adds support for the new IOT2050 SM variant, introduces a sysinfo > driver which also permits SMBIOS support and switches th

Re: [PATCH v8 2/8] efi_loader: Add a test app

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 04:46:16PM +0100, Simon Glass wrote: > Hi Heinrich, > > On Mon, 28 Oct 2024 at 19:43, Heinrich Schuchardt wrote: > > > > On 10/28/24 18:00, Simon Glass wrote: > > > Hi Heinrich, > > > > > > On Mon, 28 Oct 2024 at 07:11, Heinrich Schuchardt > > >

Re: [PATCH v3 2/2] binman: expand test coverage to nxp_imx8mcst

2024-10-29 Thread Fabio Estevam
Hi Brian, On Tue, Oct 29, 2024 at 12:52 PM Simon Glass wrote: > Could you please rebase on -master and resend? Please copy me on v4, thanks.

Re: [PATCH 03/21] bloblist: test: doc: Move into the common suite

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 04:45:40PM +0100, Simon Glass wrote: > Hi Tom, > > On Mon, 28 Oct 2024 at 20:33, Tom Rini wrote: > > > > On Mon, Oct 28, 2024 at 01:41:08PM +0100, Simon Glass wrote: > > > > > There is no particular need for bloblist to have its own test suite. > > > Move it into the commo

Re: [PATCH 2/4] board/BuR/common: add parameter for reset controller I2C bus selection

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 09:52:10AM +0100, Bernhard Messerklinger wrote: > Normally B&R reset controllers are located at I2C bus 0. This patch adds > the possibility to change this bus number with BR_RESETC_I2CBUS. > > Signed-off-by: Bernhard Messerklinger > > --- > > board/BuR/common/br_reset

Re: [PULL] u-boot-sh/master

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 02:05:47AM +0100, Marek Vasut wrote: > The following changes since commit 3df6145db0ed3430a2af089db5a82372bea3f4d5: > > x86: Missed removal of CMD_BOOTEFI_HELLO_COMPILE (2024-10-27 20:11:36 -0600) > > are available in the Git repository at: > > https://source.denx.de

Re: [GIT PULL] u-boot-riscv/master

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 08:33:54PM +0800, Leo Liang wrote: > Hi Tom, > > The following changes since commit bfdfc6c12e8ca68fff1a7ed3892c180143a6a0ef: > > Revert "acpi_table: Fix coverity defect in acpi_write_spcr" (2024-10-28 > 20:53:34 -0600) > > are available in the Git repository at: > >

Re: [PATCH v8 5/8] sandbox: Report host default-filename in native mode

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 04:45:54PM +0100, Simon Glass wrote: > Hi Heinrich, > > On Mon, 28 Oct 2024 at 20:16, Heinrich Schuchardt wrote: > > > > On 10/25/24 11:56, Ilias Apalodimas wrote: > > > Hi Simon, > > > > > > > > > On Tue, 22 Oct 2024 at 15:00, Simon Glass wrote: > > >> > > >> When the --

[PATCH v9 02/11] efi_loader: Add a test app

2024-10-29 Thread Simon Glass
Add a simple app to use for testing. This is intended to do whatever it needs to for testing purposes. For now it just prints a message and exits boot services. There was a considerable amount of discussion about whether it is OK to call exit-boot-services and then return to U-Boot. This is not no

[PATCH v9 00/11] efi: Add a test for EFI bootmeth

2024-10-29 Thread Simon Glass
The test coverage for the EFI bootmeth is incomplete since it does not actually boot the application. This series creates a simple test for this purpose. It includes a few patches to make this work: - Revert of an unreviewed patch to change the sandbox efi filename - Hang in sandbox virtio due to

[PATCH v9 03/11] sandbox: Add a -N flag to control on-host behaviour

2024-10-29 Thread Simon Glass
Sandbox is its own architecture, but sometimes we want to mimic the host architecture, e.g. when running an EFI app not built by U-Boot. Add a -N/--native flag which tells sandbox to reflect the architecture of the host. Signed-off-by: Simon Glass --- (no changes since v8) Changes in v8: - Add

[PATCH v9 01/11] test: boot: Update bootflow_iter() for console checking

2024-10-29 Thread Simon Glass
This test checks console output so should have the UTF_CONSOLE flag. Add it. Signed-off-by: Simon Glass --- (no changes since v1) test/boot/bootflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/boot/bootflow.c b/test/boot/bootflow.c index 0d4e966892e..841729bd1ac

Re: [PATCH v1 0/1] bootcount: zynqmp: Add bootcount API

2024-10-29 Thread Tom Rini
On Tue, Oct 29, 2024 at 07:58:13PM +0100, Vasileios Amoiridis wrote: > From: Vasileios Amoiridis > > Add support for the bootcount API by utilizing the internal Persistent > Global General Registers of the PMU. These registers get reset whenever > there is a Power-On-Reset so it makes them suitab

[PATCH v9 06/11] efi_loader: Allow reporting the host defaults

2024-10-29 Thread Simon Glass
Add an 'efidebug filename' command to report the default filename and PXE architecture. Signed-off-by: Simon Glass --- Changes in v9: - Split out into its own patch Changes in v8: - Add new patch to report host default-filename in native mode cmd/efidebug.c | 25 + 1 f

[PATCH v9 04/11] efi: Move default filename to a function

2024-10-29 Thread Simon Glass
Use a function to obtain the device EFI filename, so that we can control how sandbox behaves. Signed-off-by: Simon Glass --- Changes in v9: - Move the function into efi_helper.c Changes in v8: - Add new patch to move default filename to a function boot/bootmeth_efi.c| 4 +-- incl

[PATCH v9 10/11] test: efi: boot: Set up an image suitable for EFI testing

2024-10-29 Thread Simon Glass
Create a new disk for use with tests, which contains the new 'testapp' EFI app specifically intended for testing the EFI loader. Attach it to the USB device, since most testing is currently done with mmc. Initially this image will be used to test the EFI bootmeth. Fix a stale comment in prep_mmc

[PATCH v9 07/11] sandbox: Report host default-filename in native mode

2024-10-29 Thread Simon Glass
When the --native flag is given, pretend to be running the host architecture rather than sandbox. Allow the same control for PXE too. Signed-off-by: Simon Glass --- Changes in v9: - Separate into separate patches Changes in v8: - Add new patch to report host default-filename in native mode i

[PATCH v9 05/11] efi_loader: Move get_efi_pxe_arch() to efi_helper

2024-10-29 Thread Simon Glass
Move this function from the EFI bootmeth to the common efi_helper file. No functional change is intended. Signed-off-by: Simon Glass --- Changes in v9: - Split out into a separate change boot/bootmeth_efi.c | 25 ++--- include/efi.h | 10 ++ li

[PATCH v9 09/11] sandbox: virtio: Disable the sandbox virtio blk device

2024-10-29 Thread Simon Glass
This is not implemented so cannot actually be used to read blocks. Disable it until it is implemented, to avoid causing a hang with EFI, which probes every available BLK device. Signed-off-by: Simon Glass Reviewed-by: Tom Rini Issue: https://source.denx.de/u-boot/u-boot/-/issues/37 --- (no chan

[PATCH v9 08/11] efi_loader: Drop sandbox PXE architecture

2024-10-29 Thread Simon Glass
Rather than returning 0, just return an error, since sandbox is not used with PXE at present. Signed-off-by: Simon Glass --- Changes in v9: - Add new patch to drop sandbox PXE architecture lib/efi_loader/efi_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/efi_loader/efi_helpe

[PATCH v1 0/1] bootcount: zynqmp: Add bootcount API

2024-10-29 Thread Vasileios Amoiridis
From: Vasileios Amoiridis Add support for the bootcount API by utilizing the internal Persistent Global General Registers of the PMU. These registers get reset whenever there is a Power-On-Reset so it makes them suitable for the API. Questions towards reviewers: 1) Is the licensing of t

Re: [PATCH 06/15] sandbox: Add a way to show the sandbox memory-mapping

2024-10-29 Thread Simon Glass
Hi Ilias, On Tue, 29 Oct 2024 at 10:59, Ilias Apalodimas wrote: > > Hi Simon > > This seems completely unrelated to the series. > > Please send it as a separate patch I've moved the initial patches in this series to my queue in patchwork, for now. Regards, Simon > > Thanks > /Ilias > > On Mon

Re: [PATCH v2 6/8] armv8: Add generic smbios information into the device tree

2024-10-29 Thread Simon Glass
On Mon, 28 Oct 2024 at 21:00, Raymond Mao wrote: > > Hi Simon, > > On Mon, 28 Oct 2024 at 13:05, Simon Glass wrote: >> >> Hi Raymond, >> >> On Tue, 22 Oct 2024 at 22:07, Raymond Mao wrote: >> > >> > Add common smbios information that can be used by all armv8 >> > platforms and set it as default

Re: [PATCH 09/15] efi_loader: Fix free in ..._media_device_boot_option()

2024-10-29 Thread Simon Glass
Hi Ilias, On Tue, 29 Oct 2024 at 11:02, Ilias Apalodimas wrote: > > Hi Simon, > > On Mon, 28 Oct 2024 at 14:48, Simon Glass wrote: > > > > Freeing a NULL pointer is an error in EFI, so check the pointer first, > > before freeing it. > > > > Signed-off-by: Simon Glass > > --- > > > > lib/efi_lo

Re: [PATCH v8 5/8] sandbox: Report host default-filename in native mode

2024-10-29 Thread Simon Glass
Hi Heinrich, On Mon, 28 Oct 2024 at 20:16, Heinrich Schuchardt wrote: > > On 10/25/24 11:56, Ilias Apalodimas wrote: > > Hi Simon, > > > > > > On Tue, 22 Oct 2024 at 15:00, Simon Glass wrote: > >> > >> When the --native flag is given, pretend to be running the host > >> architecture rather than

Re: [PATCH] menu: fix the logic checking whether ESC key is pressed

2024-10-29 Thread 高惟杰
On Mon, 2024-10-28 at 18:01 +0100, Simon Glass wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > Hi Weijie, > > On Mon, 28 Oct 2024 at 03:58, Weijie Gao > wrote: > > > > On Mon, 2024-10-28 at 03:33 +0100, Marek

Re: [RFC PATCH 2/2] apple: dart: use driver specific instance of LMB

2024-10-29 Thread Janne Grunau
Hej, On Tue, Oct 29, 2024 at 12:48:46PM +0530, Sughosh Ganu wrote: > The LMB module is typically used for managing the platform's RAM > memory. RAM memory gets added to the module's memory map, and > subsequently allocated through various LMB API's. > > The IOMMU driver for the apple platforms al

[RFC PATCH 2/2] apple: dart: use driver specific instance of LMB

2024-10-29 Thread Sughosh Ganu
The LMB module is typically used for managing the platform's RAM memory. RAM memory gets added to the module's memory map, and subsequently allocated through various LMB API's. The IOMMU driver for the apple platforms also uses the LMB API's for allocating device virtual addresses(VA). These addre

[RFC PATCH 0/2] apple: dart: Add driver specific instance of LMB

2024-10-29 Thread Sughosh Ganu
Sughosh Ganu (2): lmb: refactor lmb push and pop functions apple: dart: use driver specific instance of LMB drivers/iommu/apple_dart.c | 67 +- include/lmb.h | 6 +++- lib/lmb.c | 21 +--- test/lib/lmb.c

Re: [RFC PATCH] apple: dart: add logic to allocate dva addresses

2024-10-29 Thread Sughosh Ganu
On Tue, 29 Oct 2024 at 09:09, Sughosh Ganu wrote: > > The Apple IOMMU driver uses LMB API's to allocate virtual addresses > for IO devices. These virtual addresses fall in the first 4GB address > range. Currently, the driver obtains these virtual addresses through > the LMB API's. This no longer w

[RFC PATCH 1/2] lmb: refactor lmb push and pop functions

2024-10-29 Thread Sughosh Ganu
The LMB module uses a separate instance of the lmb structure when running tests. Setting up the correct instance is done using the lmb_push() and lmb_pop() functions. In addition to pushing and popping the lmb instances, these functions are also doing some test specific operations. Move these opera

Re: [PATCH 4/4] efi: add helper functions to insert pmem node for DT fixup

2024-10-29 Thread Ilias Apalodimas
Hi Heinrich On Mon, 28 Oct 2024 at 08:57, Heinrich Schuchardt wrote: > > On 10/25/24 13:14, Sughosh Ganu wrote: > > The EFI HTTP boot puts the iso installer image at some location in > > memory which needs to be reserved in the devicetree as persistent > > memory (pmem). Add helper functions whic

Re: [PATCH 1/1] lmb: remove __maybe_unused from lmb_map_update_notify

2024-10-29 Thread Ilias Apalodimas
On Mon, 28 Oct 2024 at 08:21, Heinrich Schuchardt wrote: > > Function lmb_map_update_notify() is always referenced. > > Signed-off-by: Heinrich Schuchardt > --- > lib/lmb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lib/lmb.c b/lib/lmb.c > index eec99c185ee..802f

[PATCH v2 3/3] bootmenu: add reprint check

2024-10-29 Thread Weijie Gao
Record the last active menu item and check if it equals to the current selected item before reprint. Signed-off-by: Weijie Gao --- cmd/bootmenu.c | 16 +++- include/menu.h | 1 + 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/cmd/bootmenu.c b/cmd/bootmenu.c index c99

[PATCH v2 2/3] menu: add support to check if menu needs to be reprinted

2024-10-29 Thread Weijie Gao
This patch adds a new callback named need_reprint for menu. The need_reprint will be called before printing the menu. If the callback exists and returns FALSE, menu printing will be canceled. This is very useful if the menu was not changed. It can save time for serial-based menu to handle more inp

Re: [PATCH 09/15] efi_loader: Fix free in ..._media_device_boot_option()

2024-10-29 Thread Ilias Apalodimas
Hi Simon, On Mon, 28 Oct 2024 at 14:48, Simon Glass wrote: > > Freeing a NULL pointer is an error in EFI, so check the pointer first, > before freeing it. > > Signed-off-by: Simon Glass > --- > > lib/efi_loader/efi_bootmgr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --g

Re: [PATCH v2 4/5] arm: mach-k3: j721e-init.c: J7200: Add support for CONFIG_K3_OPP_LOW

2024-10-29 Thread Manorit Chawdhry
Hi Aniket, On 18:27-20241023, Aniket Limaye wrote: > From: Reid Tonking > > The default j7200 devicetree and k3_avs driver set 2GHz/1GHz frequency > for A72/MSMC clks and the OPP_NOM voltage. > > J7200 SOCs may support OPP_LOW Operating Performance Point: > 1GHz/500MHz clks for A72/MSMC and OPP

  1   2   >