Re: [PATCH 1/8] net: dc2114x: add support for platforms that don't have pci controllers

2024-10-27 Thread Tom Rini
On Fri, Aug 09, 2024 at 04:56:54PM +0800, Hanyuan Zhao wrote: > There're a few ethernet IP cores which have the same functions with dc2114x, > and can be connected to CPU by AXI or other buses. This commit adds support > for the platforms that do not have PCI controllers, using MMIO to communicate

Re: [PATCH v1 0/2] Add driver for Motorcomm YT8821 2.5G ethernet phy

2024-10-27 Thread Tom Rini
On Thu, 12 Sep 2024 05:02:23 -0700, Frank Sae wrote: > YT8531 as Gigabit transceiver uses bit15:14(bit9 reserved default 0) as phy > speed mask, YT8821 as 2.5 Gigabit transceiver uses bit9 bit15:14 as phy > speed mask. > > Be compatible to YT8821, reform phy speed mask and phy speed macro. > > B

Re: [PATCH 0/9] net: ksz9477: add support for KSZ GbE switches using SPI bus

2024-10-27 Thread Tom Rini
On Tue, 08 Oct 2024 09:54:23 +0200, Romain Naour wrote: > We are using a custom board where an ethernet switch device KSZ9896 is > available. This family of devices can use several types of serial bus > as management interface: mdio, i2c or SPI. Due to board design > constraints and because we ini

Re: [PATCH v2] net: recv(): return -EAGAIN instead of 0 when no cleanup is expected

2024-10-27 Thread Tom Rini
On Wed, 09 Oct 2024 11:42:08 +0200, Jerome Forissier wrote: > Some drivers do not behave properly when free_pkt() is called with a > length of zero. It is an issue I observed when developing the lwIP > series [1] (see "QEMU CI tests for r2dplus_i82557c, r2dplus_rtl8139" > in the change log) and wh

Re: [PATCH] menu: fix the logic checking whether ESC key is pressed

2024-10-27 Thread Weijie Gao
Hi Daniel, On Sat, 2024-10-26 at 20:23 +0100, Daniel Golle wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Hi! > > On Mon, Oct 21, 2024 at 08:56:42AM +0800, Weijie Gao wrote: > > It's observed that the bootmenu o

[PATCH v2 04/14] dt-bindings: Remove StarFive JH7110 clock and reset definitions

2024-10-27 Thread Hal Feng
As JH7110 switch to use OF_UPSTREAM dt-bindings, remove the redundant clock and reset definitions. Signed-off-by: Hal Feng --- .../dt-bindings/clock/starfive,jh7110-crg.h | 258 -- .../dt-bindings/reset/starfive,jh7110-crg.h | 183 - 2 files changed, 441 deletions

[PATCH v2 00/14] Support OF_UPSTREAM for StarFive JH7110

2024-10-27 Thread Hal Feng
This patchset add OF_STREAM support for StarFive JH7110 based boards. All the JH7110 based boards can use the DT from upstreaming linux kernel. The v1.3b board device tree is set as the default device tree. Support CONFIG_MULTI_DTB_FIT and the SPL selects the correct U-Boot dtb using the EEPROM inf

[PATCH v2 10/14] board: starfive: spl: Drop the unneeded DT modification code

2024-10-27 Thread Hal Feng
As OF_UPSTREAM is implemented, these code are redundant. Signed-off-by: Hal Feng --- board/starfive/visionfive2/spl.c | 358 --- 1 file changed, 358 deletions(-) diff --git a/board/starfive/visionfive2/spl.c b/board/starfive/visionfive2/spl.c index f55c6b5d34..38132e

[PATCH v2 06/14] clk: starfive: jh7110: Sync clock definitions with upstream dt-bindings

2024-10-27 Thread Hal Feng
JH7110 switch to use upstream dt-bindings, so update the clock definitions in drivers accordingly. Signed-off-by: Hal Feng --- drivers/clk/starfive/clk-jh7110-pll.c | 6 ++-- drivers/clk/starfive/clk-jh7110.c | 44 +-- 2 files changed, 25 insertions(+), 25 deletions(

[PATCH v2 13/14] board: starfive: spl: Fix the wrong use of CONFIG_IS_ENABLED()

2024-10-27 Thread Hal Feng
The prefix "SPL_" is not needed when using CONFIG_IS_ENABLED(). Signed-off-by: Hal Feng --- board/starfive/visionfive2/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/starfive/visionfive2/spl.c b/board/starfive/visionfive2/spl.c index 38132ecccd..cf7f39d5c5 100644

[PATCH v2 12/14] riscv: dts: jh7110: Support multiple DTBs in a Fit image

2024-10-27 Thread Hal Feng
Support multiple DTBs for JH7110 based boards, so they can select the correct DT at runtime. Signed-off-by: Hal Feng --- arch/riscv/dts/jh7110-common-u-boot.dtsi | 60 ++-- 1 file changed, 57 insertions(+), 3 deletions(-) diff --git a/arch/riscv/dts/jh7110-common-u-boot.dtsi

[PATCH v2 08/14] riscv: dts: jh7110: Move common code to the new jh7110-common-u-boot.dtsi

2024-10-27 Thread Hal Feng
To support JH7110 based boards besides v1.3B, add a common dtsi and add common code to it. Signed-off-by: Hal Feng --- arch/riscv/dts/jh7110-common-u-boot.dtsi | 150 ++ ...10-starfive-visionfive-2-v1.3b-u-boot.dtsi | 146 + 2 files changed, 151 insertions(+)

[PATCH v2 02/14] dts: starfive: Switch to using upstream DT

2024-10-27 Thread Hal Feng
Enable OF_UPSTREAM to use upstream DT and add starfive/ prefix to the DEFAULT_DEVICE_TREE. Rename jh7110-starfive-visionfive-2-u-boot.dtsi to jh7110-starfive-visionfive-2-v1.3b-u-boot.dtsi and set the v1.3b device tree as the default device tree. Signed-off-by: Hal Feng --- arch/riscv/cpu/jh7110

[PATCH v2 07/14] pcie: starfive: Make the driver compatible with upstream DT

2024-10-27 Thread Hal Feng
There are difference between upstream DT and the old DT in terms of reg base, reset gpio and syscon. Make the driver compatible with upstream DT. Signed-off-by: Hal Feng --- drivers/pci/pcie_starfive_jh7110.c | 59 +++--- 1 file changed, 30 insertions(+), 29 deletions(-)

[PATCH v2 01/14] Makefile: Add OF_UPSTREAM Makefile for RISC-V

2024-10-27 Thread Hal Feng
This makes RISC-V DT buildable with OF_UPSTREAM. Signed-off-by: Hal Feng --- dts/upstream/src/riscv/Makefile | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 dts/upstream/src/riscv/Makefile diff --git a/dts/upstream/src/riscv/Makefile b/dts/upstream/src/riscv/Makefile n

[PATCH v2 03/14] riscv: dts: jh7110: Drop redundant devicetree files

2024-10-27 Thread Hal Feng
JH7110 boards switch to using upstream DT, so drop redundant DT files from arch/riscv/dts/. Signed-off-by: Hal Feng --- arch/riscv/dts/Makefile | 1 - .../dts/jh7110-starfive-visionfive-2.dts | 11 - .../dts/jh7110-starfive-visionfive-2.dtsi | 380 - arc

[PATCH v2 09/14] riscv: dts: jh7110: Add u-boot device tree for JH7110 based boards

2024-10-27 Thread Hal Feng
To support the other JH7110 based boards, add u-boot device tree for them. Cc: Heinrich Schuchardt Cc: H Bell Signed-off-by: Hal Feng --- arch/riscv/dts/jh7110-milkv-mars-u-boot.dtsi | 11 +++ arch/riscv/dts/jh7110-pine64-star64-u-boot.dtsi | 6 ++ .../jh7110-starfi

[PATCH v2 14/14] board: starfive: spl: Support multiple DTBs for JH7110 based boards

2024-10-27 Thread Hal Feng
Use the EEPROM information to select the correct DTB. Signed-off-by: Hal Feng --- board/starfive/visionfive2/spl.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/board/starfive/visionfive2/spl.c b/board/starfive/visionfive2/spl.c index cf7f39d5c5..

[PATCH v2 05/14] riscv: dts: jh7110: Make u-boot device trees adapting to upstream DT

2024-10-27 Thread Hal Feng
Add u-boot features to the U-Boot device tree. Signed-off-by: Hal Feng --- ...10-starfive-visionfive-2-v1.3b-u-boot.dtsi | 49 +-- arch/riscv/dts/jh7110-u-boot.dtsi | 36 +- 2 files changed, 80 insertions(+), 5 deletions(-) diff --git a/arch/riscv/dts/jh7

[PATCH v2 11/14] configs: visionfive2: Enable MULTI_DTB_FIT for JH7110 based board DT

2024-10-27 Thread Hal Feng
So JH7110 based boards can select their own DT at runtime. Signed-off-by: Hal Feng --- configs/starfive_visionfive2_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig index e4ecf205e7..be9605d053 100644

Re: [PATCH 4/4] efi: add helper functions to insert pmem node for DT fixup

2024-10-27 Thread Heinrich Schuchardt
On 10/25/24 13:14, Sughosh Ganu wrote: The EFI HTTP boot puts the iso installer image at some location in memory which needs to be reserved in the devicetree as persistent memory (pmem). Add helper functions which add this pmem node when the EFI_DT_FIXUP protocol's fixup callback is invoked. Sig

Re: [PATCH] lmb: Correctly unmap and free memory on errors

2024-10-27 Thread Heinrich Schuchardt
On 10/24/24 12:46, Ilias Apalodimas wrote: We never free and unmap the memory on errors and we never unmap it when freeing it. This won't cause any problems on actual hardware but it will on sandbox Fixes: commit 22f2c9ed9f53 ("efi: memory: use the lmb API's for allocating and freeing memory")

Re: [PATCH] efi_loader: Simplify efi_free_pages()

2024-10-27 Thread Heinrich Schuchardt
On 10/24/24 13:01, Ilias Apalodimas wrote: We currently call efi_free_pages() with a notify flag and explicitly update the efi memory map. That's not needed as lmb_free_flags() will do that for us if the LMB_NONOTIFY flag is removed Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuch

Re: [PATCH] lmb: Correctly unmap memory after notifications

2024-10-27 Thread Heinrich Schuchardt
On 10/24/24 12:46, Ilias Apalodimas wrote: We never unmap the memory used to update the EFI memory map after notifications Fixes: commit 2f6191526a13 ("lmb: notify of any changes to the LMB memory map") Signed-off-by: Ilias Apalodimas --- lib/lmb.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 1/1] lmb: remove __maybe_unused from lmb_map_update_notify

2024-10-27 Thread Heinrich Schuchardt
Function lmb_map_update_notify() is always referenced. Signed-off-by: Heinrich Schuchardt --- lib/lmb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/lmb.c b/lib/lmb.c index eec99c185ee..802fdb84489 100644 --- a/lib/lmb.c +++ b/lib/lmb.c @@ -38,9 +38,7 @@ static bool

Re: [PATCH 0/4] Add pmem node for preserving distro ISO's

2024-10-27 Thread Heinrich Schuchardt
On 10/25/24 13:14, Sughosh Ganu wrote: When installing a distro via EFI HTTP boot some OS installers expect the .iso image to be preserved and treat it as a "CDROM" to install packages. This is problematic in EFI, since U-Boot mounts the image, starts the installer, and eventually calls ExitBoot

Re: [PATCH 1/2] eth: asix88179: Fix ASIX AX88179A PHY hang

2024-10-27 Thread Marek Vasut
On 10/27/24 6:12 AM, Khoa Hoang wrote: In the original code, the MII_ADVERTISE register is modified while auto-negotiation is still in progress, which causes the PHY to lock up with the ASIX AX88179A. This patch disables auto-negotiation and resets the PHY before modifying the MII_ADVERTISE regi

Re: [PATCH 2/2] eth: asix88179: Fix drop of large fragmented packets

2024-10-27 Thread Marek Vasut
On 10/27/24 6:12 AM, Khoa Hoang wrote: When receiving large fragmented packets, the ASIX 88179A can drop packets due to an insufficient URB buffer size. This change adjusts the URB buffer size to match the configuration used in the Linux kernel, resolving packet drop issues observed when performi

Re: [PATCH 02/10] ARM: socfpga: add Mercury+ AA1 SoM support

2024-10-27 Thread Marek Vasut
On 10/23/24 10:10 PM, Lothar Rubusch wrote: Hi, sorry for the late reply. Can this be generated using binman instead ? This would a oportunity for me to learn the binman tool. Great idea! I need to read a bit more on binman to get a better understanding. I'll give it a try and let you know.

Re: [PATCH v11 00/13] net: tcp: improve tcp support

2024-10-27 Thread Tom Rini
On Wed, Oct 09, 2024 at 01:50:41PM +0300, Mikhail Kshevetskiy wrote: > U-Boot support of LWIP is not ready for a moment, but we already have > some kind of tcp support. Unfortunately this support is really bad. > > Some of the known issues: > * tcp packet from other connection can break a curren

Re: [PATCH v1 1/1] usb: ci_udc: don't use "advance" feature when setting address

2024-10-27 Thread Marek Vasut
On 10/13/24 4:58 PM, Svyatoslav Ryhel wrote: Sorry for the late reply. +++ b/drivers/usb/gadget/ci_udc.c @@ -649,12 +649,30 @@ static void flip_ep0_direction(void) } } +/* + * This function explicitly sets the address, without the "USBADRA" (advance) + * feature, which is not supp

Re: [PATCH 02/14] pinctrl: rzg2l: Support 2.5V PVDD for Ethernet interfaces

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: The Ethenet interfaces on the Renesas RZ/G2L SoC family can operate at multiple power supply voltages: 3.3V (default value), 2.5V and 1.8V. rzg2l_pinconf_set() is extended to support the 2.5V setting, with a check to ensure this is only used on Ethernet in

Re: [PATCH 04/14] pinctrl: rzg2l: Drop unnecessary scope

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: In rzg2l_pinconf_set(), there are no new variables defined in the case statement for PIN_CONFIG_INPUT_ENABLE so no additional scope is needed. Signed-off-by: Paul Barker Reviewed-by: Marek Vasut btw. it might make sense to split the series per subsyste

Re: [PATCH 05/14] net: phy: Port set/clear bits from Linux

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: To simply porting phy drivers from Linux to U-Boot, define phy_set_bits() and phy_clear_bits() functions with a similar API to those used in Linux. The U-Boot versions of these functions include the `devad` argument which is not present in the Linux versio

Re: [PATCH 06/14] net: phy: ksz90x1: Handle ksz9131 LED errata

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: Micrel KSZ9131 PHY LED behavior is not correct when configured in Individual Mode, LED1 (Activity LED) is in the ON state when there is no-link. Workaround this by setting bit 9 of register 0x1e after verifying that the LED configuration is Individual Mode

Re: [PATCH 11/14] net: ravb: Add RZ/G2L Support

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: The Renesas R9A07G044L (RZ/G2L) SoC includes two Gigabit Ethernet interfaces which can be supported using the ravb driver. Some RZ/G2L specific steps need to be taken during initialization due to differences between this SoC and previously supported SoCs. W

Re: [PATCH 09/14] net: ravb: Support up to two instances

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: Several Renesas SoCs in the RZ/G2L family have two Ethernet interfaces. To support this second interface, we extend the bb_miiphy_buses[] array and keep track of the current bus index in ravb_of_to_plat(). Support for an arbitrary number of instances is no

Re: [PATCH 10/14] net: ravb: Simplify max-speed handling in ravb_of_to_plat

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: We can call dev_read_u32_default() instead of calling fdt_getprop() then fdt32_to_cpu(). Signed-off-by: Paul Barker --- drivers/net/ravb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c i

Re: [PATCH 08/14] net: phy: ksz90x1: Simplify ksz9131_config_rgmii_delay

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: We can call phy_modify_mmd() instead of manually calling drv->readext() and drv->writeext(). Signed-off-by: Paul Barker --- drivers/net/phy/micrel_ksz90x1.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a

Re: [PATCH v2] mmc: renesas-sdhi: Add compatible string for rzg2l-sdhi

2024-10-27 Thread Marek Vasut
On 10/23/24 12:53 PM, Paul Barker wrote: After the recent dts/upstream subtree merge, the sdhi compatible string used in the device tree for RZ/G2L family SoCs is "renesas,rzg2l-sdhi" not "renesas,rcar-gen3-sdhi". This broke the ability to access the eMMC and SD card devices on RZ/G2L boards. Fi

Re: [PATCH 01/14] clk: rzg2l: Ignore enable for core clocks

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: In the RZ/G2L family, core clocks are always on and can't be disabled. However, drivers which are shared with other SoCs may call clk_enable() or clk_enable_bulk() for a clock referenced in the device tree which happens to be a core clock on the RZ/G2L. To

Re: [PATCH 07/14] net: phy: ksz90x1: Load skew values from device tree

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: Various signal skew values may be set in the device tree for the ksz9131 Ethernet PHY. For example, the RZ/G2L board requires non-default values for rxc-skew-psec & txc-skew-psec. This is based on the ksz9131 phy driver in Linux v6.11. Signed-off-by: Paul

Re: [PATCH v1 1/1] usb: ci_udc: don't use "advance" feature when setting address

2024-10-27 Thread Svyatoslav Ryhel
нд, 27 жовт. 2024 р. о 18:09 Marek Vasut пише: > > On 10/13/24 4:58 PM, Svyatoslav Ryhel wrote: > > Sorry for the late reply. > > > +++ b/drivers/usb/gadget/ci_udc.c > > @@ -649,12 +649,30 @@ static void flip_ep0_direction(void) > > } > > } > > > > +/* > > + * This function explicitly sets

Re: [PATCH v11 00/13] net: tcp: improve tcp support

2024-10-27 Thread Peter Robinson
On Sun, 27 Oct 2024 at 16:32, Tom Rini wrote: > > On Wed, Oct 09, 2024 at 01:50:41PM +0300, Mikhail Kshevetskiy wrote: > > > U-Boot support of LWIP is not ready for a moment, but we already have > > some kind of tcp support. Unfortunately this support is really bad. > > > > Some of the known issue

Re: [PATCH 5/5] fs: ext4: use fs_ls_generic

2024-10-27 Thread Simon Glass
On Sat, 26 Oct 2024 at 08:41, Heinrich Schuchardt wrote: > > Now that opendir, readir, closedir are implemented for ext4 we can use > fs_ls_generic() for implementing the ls command. > > Adjust the unit tests: > > * fs_ls_generic() produces more spaces between file size and name. > * The ext4 spec

Re: [PATCH] CI: Add a test for building without CMDLINE

2024-10-27 Thread Simon Glass
Hi Tom, On Tue, 22 Oct 2024 at 19:56, Tom Rini wrote: > > On Tue, Oct 22, 2024 at 07:00:39PM +0200, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 22 Oct 2024 at 16:02, Tom Rini wrote: > > > > > > On Tue, Oct 22, 2024 at 02:16:16PM +0200, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon

Re: [PATCH 2/5] fs: ext4: free directory node in ext4fs_exists()

2024-10-27 Thread Simon Glass
On Sat, 26 Oct 2024 at 08:41, Heinrich Schuchardt wrote: > > The directory retrieved in ext4fs_exists() should be freed to avoid a > memory leak. > > Signed-off-by: Heinrich Schuchardt > --- > fs/ext4/ext4fs.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Simon

Re: [PATCH] dm: core: downgrade some dm_warn messages to log_debug()

2024-10-27 Thread Simon Glass
Hi Quentin, On Tue, 15 Oct 2024 at 16:32, Quentin Schulz wrote: > > From: Quentin Schulz > > People complained that enabling (SPL_)DM_WARN was now totally unusable > due to the amount of messages printed on the console. > > Let's downgrade the log level of some messages that are clearly not on >

Re: [PATCH 3/5] fs: ext4: implement opendir, readdir, closedir

2024-10-27 Thread Simon Glass
Hi Heinrich, On Sat, 26 Oct 2024 at 08:41, Heinrich Schuchardt wrote: > > For accessing directories from the EFI sub-system a file system must > implement opendir, readdir, closedir. Provide the missing implementation. > > With this patch the eficonfig command can be used to define load options >

Re: [PATCH 1/4] imx: imxrt*: Fix binman breaking boot

2024-10-27 Thread Simon Glass
On Fri, 25 Oct 2024 at 04:02, Jesse Taube wrote: > > The init_r parsing of U-Boot device tree to search the binman > information errors. set CONFIG_BINMAN_FDT to no to fix this. > > Fixes: 7079eeb72fc ("imx: imxrt1050-evk: Add support for SPI flash booting > s") > Signed-off-by: Jesse Taube > ---

Re: [PATCH v7 6/7] test: efi: boot: Set up an image suitable for EFI testing

2024-10-27 Thread Simon Glass
Hi Tom, On Thu, 24 Oct 2024 at 19:37, Tom Rini wrote: > > On Thu, Oct 24, 2024 at 06:39:00PM +0200, Simon Glass wrote: > > Hi Tom, > > > > On Wed, Oct 23, 2024, 20:41 Tom Rini wrote: > > > > > > On Wed, Oct 23, 2024 at 05:39:07AM +0200, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue,

Re: [PATCH 1/5] fs: ext4: simplify ext4fs_iterate_dir()

2024-10-27 Thread Simon Glass
On Sat, 26 Oct 2024 at 08:41, Heinrich Schuchardt wrote: > > Remove copying a pointer with a cast to the very same type. > > Signed-off-by: Heinrich Schuchardt > --- > fs/ext4/ext4_common.c | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-) > Reviewed-by: Simo

wget bug report

2024-10-27 Thread Simon Glass
Hi Jerome, Just something I noticed earlier...when running 'ut lib' I see this failure on sandbox: test/cmd/wget.c:215, net_test_wget(): 0 == run_command("wget ${loadaddr} 1.1.2.2:/index.html", 0): Expected 0x0 (0), got 0x1 (1) Also, since it is testing a command and is in test/cmd it really sho

Re: [PATCH v8 5/8] sandbox: Report host default-filename in native mode

2024-10-27 Thread Simon Glass
Hi Ilias, Heinrich, On Fri, 25 Oct 2024 at 11:57, Ilias Apalodimas wrote: > > Hi Simon, > > > On Tue, 22 Oct 2024 at 15:00, Simon Glass wrote: > > > > When the --native flag is given, pretend to be running the host > > architecture rather than sandbox. > > > > Add an 'efidebug filename' command

Re: [PATCH 1/5] fs: ext4: simplify ext4fs_iterate_dir()

2024-10-27 Thread Ilias Apalodimas
On Sat, 26 Oct 2024 at 09:41, Heinrich Schuchardt wrote: > > Remove copying a pointer with a cast to the very same type. > > Signed-off-by: Heinrich Schuchardt > --- > fs/ext4/ext4_common.c | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-) > > diff --git a/fs/

Re: [PATCH v2 09/14] riscv: dts: jh7110: Add u-boot device tree for JH7110 based boards

2024-10-27 Thread E Shattow
On Sun, Oct 27, 2024 at 6:59 PM Hal Feng wrote: > > To support the other JH7110 based boards, add u-boot > device tree for them. > > Cc: Heinrich Schuchardt > Cc: H Bell > Signed-off-by: Hal Feng > --- > arch/riscv/dts/jh7110-milkv-mars-u-boot.dtsi | 11 +++ > arch/riscv/dts/j

Re: [PATCH 1/2] eth: asix88179: Fix ASIX AX88179A PHY hang

2024-10-27 Thread Marek Vasut
On 10/28/24 12:41 AM, Khoa Hoang wrote: On Sun, 27 Oct 2024 07:44:59 -0700 Marek Vasut wrote --- > On 10/27/24 6:12 AM, Khoa Hoang wrote: > > In the original code, the MII_ADVERTISE register is modified while > > auto-negotiation is still in progress, which causes the PHY to lock up

Re: [PATCH] imx: hab: fix size of IVT+CSF blob tacked on to u-boot.itb

2024-10-27 Thread Heiko Schocher
Hello Marek, On 27.10.24 22:01, Marek Vasut wrote: On 10/25/24 5:09 PM, Fabio Estevam wrote: On Fri, Oct 25, 2024 at 11:51 AM Fabio Estevam wrote: Heiko, can you check if this works for you? Works fine for me, thanks! Applied, thanks. Sorry, applied it too soon. I see there is an ongoi

Re: [PATCH 1/2] ARM: renesas: Drop old unused clock DT headers

2024-10-27 Thread Sumit Garg
On Sun, 27 Oct 2024 at 07:35, Marek Vasut wrote: > > Renesas R-Car systems use mainline Linux DTs for U-Boot via OF_UPSTREAM, > which also includes headers from dts/upstream/include/dt-bindings/clock . > Remove unused legacy DT header files from include/dt-bindings/clock . > > Signed-off-by: Marek

Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-10-27 Thread Tom Rini
Here's the latest report. -- Forwarded message - From: Date: Sun, Oct 27, 2024 at 9:05 PM Subject: New Defects reported by Coverity Scan for Das U-Boot To: Hi, Please find the latest report on new defect(s) introduced to Das U-Boot found with Coverity Scan. 1 new defect(s) in

Re: [PATCH 2/2] eth: asix88179: Fix drop of large fragmented packets

2024-10-27 Thread Marek Vasut
On 10/28/24 12:14 AM, Khoa Hoang wrote: On Sun, 27 Oct 2024 07:43:26 -0700 Marek Vasut wrote --- > On 10/27/24 6:12 AM, Khoa Hoang wrote: > > When receiving large fragmented packets, the ASIX 88179A can drop > > packets due to an insufficient URB buffer size. This change adjusts >

Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available

2024-10-27 Thread Jan Kiszka
On 27.10.24 15:56, Simon Glass wrote: > Hi Jan, > > On Wed, 23 Oct 2024 at 06:14, Jan Kiszka wrote: >> >> On 23.10.24 05:39, Simon Glass wrote: >>> Hi Jan, >>> >>> On Tue, 22 Oct 2024 at 21:41, Jan Kiszka wrote: On 22.10.24 19:00, Simon Glass wrote: > On Tue, 22 Oct 2024 at 08:06,

Re: [PATCH v8 7/8] test: efi: boot: Set up an image suitable for EFI testing

2024-10-27 Thread Heinrich Schuchardt
On 10/22/24 14:00, Simon Glass wrote: Create a new disk for use with tests, which contains the new 'testapp' EFI app specifically intended for testing the EFI loader. Attach it to the USB device, since most testing is currently done with mmc. Initially this image will be used to test the EFI bo

Re: [PATCH v8 1/8] test: boot: Update bootflow_iter() for console checking

2024-10-27 Thread Heinrich Schuchardt
On 10/22/24 14:00, Simon Glass wrote: This test checks console output so should have the UTF_CONSOLE flag. Add it. Signed-off-by: Simon Glass --- (no changes since v1) test/boot/bootflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/boot/bootflow.c b/test/boot/

Re: [PATCH v8 2/8] efi_loader: Add a test app

2024-10-27 Thread Heinrich Schuchardt
On 10/22/24 14:00, Simon Glass wrote: Add a simple app to use for testing. This is intended to do whatever it needs to for testing purposes. For now it just prints a message and exits boot services. There was a considerable amount of discussion about whether it is OK to call exit-boot-services a

Re: [PATCH] disk: Mark static functions in part_efi.c

2024-10-27 Thread Heinrich Schuchardt
On 10/26/24 10:05, Ilias Apalodimas wrote: Mark all the functions that are only defined locally as static and quiesce W=1 warnings Signed-off-by: Ilias Apalodimas --- disk/part_efi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/disk/part_efi.c b/disk/part_efi.c ind

Re: [PATCH] efi_loader: Mark static functions in smbiosdump

2024-10-27 Thread Heinrich Schuchardt
On 10/26/24 09:57, Ilias Apalodimas wrote: Mark functions that are only used locally as static and quiesce W=1 warnings Signed-off-by: Ilias Apalodimas --- lib/efi_loader/smbiosdump.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/smbiosdump.c b/lib/

Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available

2024-10-27 Thread Jan Kiszka
On 25.10.24 03:08, Tom Rini wrote: > On Tue, Oct 22, 2024 at 08:04:28AM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka >> >> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will >> be first used by the IOT2050 boards. >> >> Based on original patch by Li Hua Qian. >> >> Signed-of

Re: [PATCH] efi_loader: Remove unused diskid

2024-10-27 Thread Heinrich Schuchardt
On 10/26/24 10:00, Ilias Apalodimas wrote: That variable is defined and assigned a value in two functions but it's never used. Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt --- lib/efi_loader/efi_disk.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/efi_lo

Re: [PATCH 4/5] efi_loader: fix GetInfo and SetInfo

2024-10-27 Thread Simon Glass
On Sat, 26 Oct 2024 at 08:41, Heinrich Schuchardt wrote: > > * Some of our file system drivers cannot report a file size for > directories. Use a dummy value in this case. > * For SetInfo the UEFI spec requires to ignore the file size field. > > Signed-off-by: Heinrich Schuchardt > --- > lib/e

Re: [PATCH 2/2] eth: asix88179: Fix drop of large fragmented packets

2024-10-27 Thread Khoa Hoang
On Sun, 27 Oct 2024 07:43:26 -0700 Marek Vasut wrote --- > On 10/27/24 6:12 AM, Khoa Hoang wrote: > > When receiving large fragmented packets, the ASIX 88179A can drop > > packets due to an insufficient URB buffer size. This change adjusts > > the URB buffer size to match the configur

Re: [PATCH 1/2] eth: asix88179: Fix ASIX AX88179A PHY hang

2024-10-27 Thread Khoa Hoang
On Sun, 27 Oct 2024 07:44:59 -0700 Marek Vasut wrote --- > On 10/27/24 6:12 AM, Khoa Hoang wrote: > > In the original code, the MII_ADVERTISE register is modified while > > auto-negotiation is still in progress, which causes the PHY to lock up > > with the ASIX AX88179A. > > > > T

RE: [PATCH] sunxi: power: axp809: Fix DCDC4 programming

2024-10-27 Thread Jaehoon Chung
> -Original Message- > From: Chen-Yu Tsai > Sent: Friday, October 25, 2024 11:43 PM > To: Andre Przywara > Cc: Jaehoon Chung ; Jagan Teki > ; Tom Rini > ; u-boot@lists.denx.de; linux-su...@lists.linux.dev > Subject: Re: [PATCH] sunxi: power: axp809: Fix DCDC4 programming > > On Tue, O

Re: [PATCH v2] board: emcraft: Add support for Emcraft Systems NavQ+

2024-10-27 Thread Gilles Talis
Hi Fabio, thank you for the second review! Le ven. 25 oct. 2024 à 07:20, Fabio Estevam a écrit : > > Hi Gilles, > > On Thu, Oct 24, 2024 at 9:44 PM Gilles Talis wrote: > > > > The Emcraft Systems NavQ+ kit is a mobile robotics platform > > based on NXP i.MX8 MPlus SoC. > > > > The following inte

Re: [PATCH] menu: fix the logic checking whether ESC key is pressed

2024-10-27 Thread Marek Vasut
On 10/28/24 1:25 AM, Weijie Gao wrote: Hi Daniel, On Sat, 2024-10-26 at 20:23 +0100, Daniel Golle wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. Hi! On Mon, Oct 21, 2024 at 08:56:42AM +0800, Weijie Gao wrote: It's obs

Re: [PATCH v10 00/37] Implement ACPI on aarch64

2024-10-27 Thread Tom Rini
On Wed, 23 Oct 2024 15:19:43 +0200, Patrick Rudolph wrote: > Based on the existing work done by Simon Glass this series adds > support for booting aarch64 devices using ACPI only. > As first target QEMU SBSA support is added, which relies on ACPI > only to boot an OS. As secondary target the Raspb

Re: [PATCH] x86: Missed removal of CMD_BOOTEFI_HELLO_COMPILE

2024-10-27 Thread Tom Rini
On Fri, 25 Oct 2024 18:07:00 +0100, Andrew Goodbody wrote: > The config setting CMD_BOOTEFI_HELLO_COMPILE was removed in favour > of BOOTEFI_HELLO_COMPILE but the usage in this Makefile was not > updated. Fix it. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] test: efi_loader: Fix dependency for http test

2024-10-27 Thread Tom Rini
On Fri, 25 Oct 2024 17:47:32 +0100, Andrew Goodbody wrote: > The config setting CMD_BOOTEFI_HELLO_COMPILE was removed in favour > of BOOTEFI_HELLO_COMPILE but the dependency for > test_efi_helloworld_net_http was not updated and so is now incorrect > preventing the test from ever running. Fix it.

Re: [PATCH] menu: fix the logic checking whether ESC key is pressed

2024-10-27 Thread Weijie Gao
On Mon, 2024-10-28 at 03:33 +0100, Marek Vasut wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 10/28/24 1:25 AM, Weijie Gao wrote: > > Hi Daniel, > > > > On Sat, 2024-10-26 at 20:23 +0100, Daniel Golle wrote: >

Re: [PATCH v4 11/11] doc: develop: orthographic delights

2024-10-27 Thread Simon Glass
Hi Lothar On Sat, 26 Oct 2024 at 17:52, Lothar Rubusch wrote: > > Fix some typos and duplicate words in documentation files. > > Signed-off-by: Lothar Rubusch > --- > doc/develop/gdb.rst | 2 +- > tools/binman/binman.rst | 4 ++-- > tools/binman/entries.rst | 22 +++--- >

[PATCH v3] board: emcraft: Add support for Emcraft Systems NavQ+

2024-10-27 Thread Gilles Talis
The Emcraft Systems NavQ+ kit is a mobile robotics platform based on NXP i.MX8 MPlus SoC. The following interfaces and devices are enabled: - eMMC - Gigabit Ethernet (through eQOS interface) - SD-Card - UART console The device tree file is taken from upstream Linux Kernel through OF_UPSTREAM Sig

Re: [PATCH v2] sandbox: Add a build without CMDLINE

2024-10-27 Thread Simon Glass
Hi Tom, On Sun, 27 Oct 2024 at 00:33, Tom Rini wrote: > > On Sat, Oct 26, 2024 at 02:02:49PM +0200, Simon Glass wrote: > > > Something this breaks, so add a build to keep it working. Since sandbox > > enables a lot of options, it is a good board to use. The new config is > > created simply by cop

Re: [PATCH v2] sandbox: Add a build without CMDLINE

2024-10-27 Thread Tom Rini
On Sun, Oct 27, 2024 at 03:52:02PM +0100, Simon Glass wrote: > Hi Tom, > > On Sun, 27 Oct 2024 at 00:33, Tom Rini wrote: > > > > On Sat, Oct 26, 2024 at 02:02:49PM +0200, Simon Glass wrote: > > > > > Something this breaks, so add a build to keep it working. Since sandbox > > > enables a lot of op

Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available

2024-10-27 Thread Simon Glass
Hi Jan, On Wed, 23 Oct 2024 at 06:14, Jan Kiszka wrote: > > On 23.10.24 05:39, Simon Glass wrote: > > Hi Jan, > > > > On Tue, 22 Oct 2024 at 21:41, Jan Kiszka wrote: > >> > >> On 22.10.24 19:00, Simon Glass wrote: > >>> On Tue, 22 Oct 2024 at 08:06, Jan Kiszka wrote: > > From: Jan Kis

Re: [PATCH 1/4] fdt: add support for adding pmem nodes

2024-10-27 Thread Simon Glass
Hi Sughosh, On Fri, 25 Oct 2024 at 13:15, Sughosh Ganu wrote: > > From: Masahisa Kojima > > One of the problems OS installers face, when running in EFI, is that > the mounted ISO after calling ExitBootServices goes away. For some > distros this is a problem since they rely on finding some core p

[PATCH 2/2] eth: asix88179: Fix drop of large fragmented packets

2024-10-27 Thread Khoa Hoang
When receiving large fragmented packets, the ASIX 88179A can drop packets due to an insufficient URB buffer size. This change adjusts the URB buffer size to match the configuration used in the Linux kernel, resolving packet drop issues observed when performing TFTP with a 16KB block size. Signed-o

[PATCH 1/2] eth: asix88179: Fix ASIX AX88179A PHY hang

2024-10-27 Thread Khoa Hoang
In the original code, the MII_ADVERTISE register is modified while auto-negotiation is still in progress, which causes the PHY to lock up with the ASIX AX88179A. This patch disables auto-negotiation and resets the PHY before modifying the MII_ADVERTISE register, then restarts auto-negotiation afte

[PATCH 0/2] eth: asix88179: Fixes for ASIX AX88179A variant

2024-10-27 Thread Khoa Hoang
Hello U-Boot Maintainers, I am submitting two patches that address issues with the ASIX AX88179A Ethernet driver in U-Boot. These patches resolve problems related to PHY hang during auto-negotiation and stalling when handling large fragmented packets for the ASIX AX88179A variant. --- Example of

Re: [PATCH 1/2] ARM: renesas: Drop old unused clock DT headers

2024-10-27 Thread Paul Barker
On 27/10/2024 02:04, Marek Vasut wrote: > Renesas R-Car systems use mainline Linux DTs for U-Boot via OF_UPSTREAM, > which also includes headers from dts/upstream/include/dt-bindings/clock . > Remove unused legacy DT header files from include/dt-bindings/clock . > > Signed-off-by: Marek Vasut > -

Re: [PATCH 2/2] ARM: renesas: Drop old unused power DT headers

2024-10-27 Thread Paul Barker
On 27/10/2024 02:04, Marek Vasut wrote: > Renesas R-Car systems use mainline Linux DTs for U-Boot via OF_UPSTREAM, > which also includes headers from dts/upstream/include/dt-bindings/power . > Remove unused legacy DT header files from include/dt-bindings/power . > > Signed-off-by: Marek Vasut > -

Re: [PATCH v2] ARM: renesas: Add top level board/renesas/ MAINTAINERS file

2024-10-27 Thread Paul Barker
On 27/10/2024 02:10, Marek Vasut wrote: > Add top level board/renesas/ MAINTAINERS file to catch all the common > Renesas file patterns and put people on CC via get_maintainer.pl script. > > Signed-off-by: Marek Vasut > --- > Cc: Nobuhiro Iwamatsu > Cc: Tom Rini > Cc: u-boot@lists.denx.de > ---

Re: [PATCH 2/5] fs: ext4: free directory node in ext4fs_exists()

2024-10-27 Thread Ilias Apalodimas
On Sat, 26 Oct 2024 at 09:41, Heinrich Schuchardt wrote: > > The directory retrieved in ext4fs_exists() should be freed to avoid a > memory leak. > > Signed-off-by: Heinrich Schuchardt > --- > fs/ext4/ext4fs.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/fs/e

Re: [PATCH 03/14] pinctrl: rzg2l: Support Ethernet TXC output enable

2024-10-27 Thread Marek Vasut
On 10/24/24 5:24 PM, Paul Barker wrote: On the RZ/G2L SoC family, the direction of the Ethernet TXC/TX_CLK signal is selectable to support an Ethernet PHY operating in either MII or RGMII mode. By default, the signal is configured as an input and MII mode is supported. The ETH_MODE register can b

Re: [PATCH 4/5] efi_loader: fix GetInfo and SetInfo

2024-10-27 Thread Ilias Apalodimas
On Sat, 26 Oct 2024 at 09:41, Heinrich Schuchardt wrote: > > * Some of our file system drivers cannot report a file size for > directories. Use a dummy value in this case. > * For SetInfo the UEFI spec requires to ignore the file size field. > > Signed-off-by: Heinrich Schuchardt > --- > lib/e

Re: [PATCH] net: wget: check strict_strtoul() return value

2024-10-27 Thread Tom Rini
On Tue, Oct 08, 2024 at 11:46:46AM +0200, Jerome Forissier wrote: > Check the return value of strict_strtoul() when processing the > Content-Length header as recommended by Coverity [1]. > > [1] https://lists.denx.de/pipermail/u-boot/2024-October/567050.html > > Reported-by: Coverity (CID 510464

Re: [PATCH v7 6/7] test: efi: boot: Set up an image suitable for EFI testing

2024-10-27 Thread Tom Rini
On Sun, Oct 27, 2024 at 06:16:25PM +0100, Simon Glass wrote: > Hi Tom, > > On Thu, 24 Oct 2024 at 19:37, Tom Rini wrote: > > > > On Thu, Oct 24, 2024 at 06:39:00PM +0200, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, Oct 23, 2024, 20:41 Tom Rini wrote: > > > > > > > > On Wed, Oct 23, 2024

Re: [PATCH] Bitbanging MDIO driver for DM framework.

2024-10-27 Thread Tom Rini
On Wed, Sep 25, 2024 at 04:47:38PM +, Markus Gothe wrote: > Linux DTS compatible MDIO bitbanging driver. > Both clause 22 and clause 45 MDIO supported and validated. > > Heavily based on the Linux drivers (more or less the same code base). > > Signed-off-by: Markus Gothe Unfortunately the

Re: [PATCH] imx: hab: fix size of IVT+CSF blob tacked on to u-boot.itb

2024-10-27 Thread Rasmus Villemoes
On Fri, Oct 25 2024, Marek Vasut wrote: > On 10/25/24 9:10 AM, Rasmus Villemoes wrote: >> On Thu, Oct 24 2024, Marek Vasut wrote: >> >>> On 10/24/24 2:27 PM, Rasmus Villemoes wrote: Loading flash.bin using uuu fails when flash.bin does not have the right size. When flash.bin is l

Re: [PATCH] imx: hab: fix size of IVT+CSF blob tacked on to u-boot.itb

2024-10-27 Thread Marek Vasut
On 10/25/24 5:09 PM, Fabio Estevam wrote: On Fri, Oct 25, 2024 at 11:51 AM Fabio Estevam wrote: Heiko, can you check if this works for you? Works fine for me, thanks! Applied, thanks. Sorry, applied it too soon. I see there is an ongoing discussion. I will wait for more time. Go ahead

Re: [PATCH] imx: hab: fix size of IVT+CSF blob tacked on to u-boot.itb

2024-10-27 Thread Marek Vasut
On 10/27/24 7:38 PM, Rasmus Villemoes wrote: On Fri, Oct 25 2024, Marek Vasut wrote: On 10/25/24 9:10 AM, Rasmus Villemoes wrote: On Thu, Oct 24 2024, Marek Vasut wrote: On 10/24/24 2:27 PM, Rasmus Villemoes wrote: Loading flash.bin using uuu fails when flash.bin does not have the right s

  1   2   >