Re: OF_UPSTREAM vs. additional dtbs

2024-08-27 Thread Sumit Garg
On Mon, 26 Aug 2024 at 17:51, Jonas Karlman wrote: > > Hi Sumit, > > On 2024-08-26 13:48, Sumit Garg wrote: > > Hi Jonas, > > > > On Mon, 26 Aug 2024 at 14:27, Jonas Karlman wrote: > >> > >> Hi Sumit, > >> > >> On 2024-08-26 08:44, Sumit Garg wrote: > >>> Hi, > >>> > >>> On Wed, 14 Aug 2024 at 22

Re: OF_UPSTREAM vs. additional dtbs

2024-08-27 Thread Sumit Garg
On Mon, 26 Aug 2024 at 18:02, Jan Kiszka wrote: > > On 26.08.24 09:10, Sumit Garg wrote: > > On Mon, 26 Aug 2024 at 12:19, Jan Kiszka wrote: > >> > >> On 26.08.24 08:44, Sumit Garg wrote: > >>> Hi, > >>> > >>> On Wed, 14 Aug 2024 at 22:14, Jan Kiszka wrote: > > On 14.08.24 11:41, Jan K

Re: [PATCH 3/3] tpm_tcg2: hash algo optimization

2024-08-27 Thread Ilias Apalodimas
Hi Benjamin, On Fri, 23 Aug 2024 at 15:29, Benjamin BARATTE wrote: > > Hi @Ilias Apalodimas, > > > ST Restricted > > -Original Message- > > From: Ilias Apalodimas > > Sent: Monday, July 29, 2024 4:10 PM > > To: Benjamin BARATTE > > Cc: u-boot@lists.denx.de; akashi.tk...@gmail.com; > >

Re: [PATCH 1/6] doc/arch/m68k.rst: Update toolchain comment

2024-08-27 Thread Angelo Dureghello
Thanks Tom. Will check this later. angelo On 26/08/24 6:49 PM, Tom Rini wrote: The old wiki page has not exited for quite some time, update to note what we build with in CI at least. Signed-off-by: Tom Rini --- Cc: Angelo Dureghello --- doc/arch/m68k.rst | 6 +++--- 1 file changed, 3 ins

Re: OF_UPSTREAM vs. additional dtbs

2024-08-27 Thread Jan Kiszka
On 27.08.24 09:13, Sumit Garg wrote: > On Mon, 26 Aug 2024 at 18:02, Jan Kiszka wrote: >> >> On 26.08.24 09:10, Sumit Garg wrote: >>> On Mon, 26 Aug 2024 at 12:19, Jan Kiszka wrote: On 26.08.24 08:44, Sumit Garg wrote: > Hi, > > On Wed, 14 Aug 2024 at 22:14, Jan Kiszka wrot

Re: [PATCH] doc/develop/sending_patches.rst: Reword where our git tree is slightly

2024-08-27 Thread Quentin Schulz
Hi Tom, On 8/26/24 7:01 PM, Tom Rini wrote: We shouldn't have had the link to our git tree be contained within "``" as that meant that it did not work as a link, so remove those. And rather than make this a link plus text, keep this as a link within the text for overall clarity. Suggested-by: Q

Re: [PATCH 3/3] imx: Remove CFG_MXC_USB_PORTSC

2024-08-27 Thread Soeren Moch
Hi Fabio, On 27.08.24 02:58, Fabio Estevam wrote: From: Fabio Estevam '#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)' can be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c. Suggested-by: Tim

Re: OF_UPSTREAM vs. additional dtbs

2024-08-27 Thread Sumit Garg
On Tue, 27 Aug 2024 at 15:05, Jan Kiszka wrote: > > On 27.08.24 09:13, Sumit Garg wrote: > > On Mon, 26 Aug 2024 at 18:02, Jan Kiszka wrote: > >> > >> On 26.08.24 09:10, Sumit Garg wrote: > >>> On Mon, 26 Aug 2024 at 12:19, Jan Kiszka wrote: > > On 26.08.24 08:44, Sumit Garg wrote: > >

[PATCH] arm64: zynqmp: Add u-boot command to boot into recovery image

2024-08-27 Thread Prasad Kummari
To boot into the firmware recovery tool, the user currently needs to press a button on the board while powering the system up. To simplify this process, a U-Boot command was added to allow booting directly into the recovery tool. For example: ZynqMP> zynqmp reboot Co-develop-by: Michal Simek Si

Re: OF_UPSTREAM vs. additional dtbs

2024-08-27 Thread Jonas Karlman
Hi Sumit, On 2024-08-27 09:11, Sumit Garg wrote: > On Mon, 26 Aug 2024 at 17:51, Jonas Karlman wrote: >> >> Hi Sumit, >> >> On 2024-08-26 13:48, Sumit Garg wrote: >>> Hi Jonas, >>> >>> On Mon, 26 Aug 2024 at 14:27, Jonas Karlman wrote: Hi Sumit, On 2024-08-26 08:44, Sumit Gar

Re: [PATCH] doc/develop/sending_patches.rst: Reword where our git tree is slightly

2024-08-27 Thread neil . armstrong
On 26/08/2024 19:01, Tom Rini wrote: We shouldn't have had the link to our git tree be contained within "``" as that meant that it did not work as a link, so remove those. And rather than make this a link plus text, keep this as a link within the text for overall clarity. Suggested-by: Quentin S

[PATCH 0/4] Rockchip: Allow to silent TPL/SPL debug console

2024-08-27 Thread Lukasz Czechowski
Currently it is not possible to completely silent the debug console in i.e. PX30, what might be required in some embedded devices Disabling DEBUG_UART results in errors, due to missing symbols. In particular, rockchip sdram driver performs calls to debug_uart functions (i.e. printascii), defined di

[PATCH 1/4] debug_uart: Replace debug functions with dummies if CONFIG_DEBUG_UART is not set

2024-08-27 Thread Lukasz Czechowski
In case DEBUG UART is not used, define dummy macros replacing the actual function implementations that will not be available. This allows to compile code and avoid linker errors. Because the DEBUG_UART_FUNCS macro should not be used if DEBUG UART is not available, redefine it to generate compilatio

[PATCH 2/4] ram: rockchip: Kconfig: Fix dependency of RAM_ROCKCHIP_DEBUG

2024-08-27 Thread Lukasz Czechowski
The RAM_ROCKCHIP_DEBUG can be used only if DEBUG_UART is available, otherwise it won't have any effect. Add negative dependency to TPL_SILENT_CONSOLE. Signed-off-by: Lukasz Czechowski --- drivers/ram/rockchip/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ram/rockchip/Kcon

[PATCH 3/4] rockchip: Kconfig: PX30: Weaken dependency TPL/SPL serial

2024-08-27 Thread Lukasz Czechowski
Allow to disable serial console in TPL and SPL. Weak dependency to SPL_SERIAL and TPL_SERIAL is also used in other Rockchip boards. Signed-off-by: Lukasz Czechowski --- arch/arm/mach-rockchip/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-rockchip/K

[PATCH 4/4] arm: rockchip: PX30: Fix hard dependency to DEBUG_UART_BOARD_INIT

2024-08-27 Thread Lukasz Czechowski
Because DEBUG_UART_BOARD_INIT depends on DEBUG_UART, hard dependency to DEBUG_UART_BOARD_INIT in ROCKCHIP_PX30 can cause warnings if DEBUG_UART is disabled. The DEBUG_UART_BOARD_INIT is already implied by ARCH_ROCKCHIP entry. Remove hard dependency from ROCKCHIP_PX30, so that it will be consistent

imx8ulp_evk build with buildman fails every other time

2024-08-27 Thread Jerome Forissier
Hi, Can someone explain what's happening with the imx8ulp_evk buildman build below? It either fails with a mkimage error, or succeeds with a binman warning, every other time. 100% reproducible. /me confused :o 8<8<== $ docker run -it --rm trini/u-boot-gitlab-ci-runner:

Re: [PATCH v3] imx: ele_ahab: Add HUK derivation support

2024-08-27 Thread Ye Li
On 8/26/2024 6:07 PM, Mathieu Othacehe wrote: Add a new ahab_derive command that derives the hardware unique key (HUK) into a 16 or 32 bytes key and stores it at the given address. Signed-off-by: Mathieu Othacehe --- Changelog: v2: Make the seed size configurable v3: Fix a typo char* seed ->

Re: [PATCH v2 00/19] Tidy up console recording in tests

2024-08-27 Thread Tom Rini
On Thu, 22 Aug 2024 07:57:45 -0600, Simon Glass wrote: > This series started as a small fix for checking for an empty line, > but in the process several other problems were found and fixed: > > - fix tests which use console recording but don't set the flag > - drop unnecessary resetting of the co

Re: imx8ulp_evk build with buildman fails every other time

2024-08-27 Thread Fabio Estevam
Adding Gary and Peng on Cc. On Tue, Aug 27, 2024 at 11:42 AM Jerome Forissier wrote: > > Hi, > > Can someone explain what's happening with the imx8ulp_evk buildman build > below? It either fails with a mkimage error, or succeeds with a binman > warning, every other time. 100% reproducible. /me co

Re: [PATCH 3/3] imx: Remove CFG_MXC_USB_PORTSC

2024-08-27 Thread Tim Harvey
On Mon, Aug 26, 2024 at 5:58 PM Fabio Estevam wrote: > > From: Fabio Estevam > > '#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)' can > be removed from mx5/mx6/mx7/mx8m board config files as it is the > default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c. > > Sug

Re: imx8ulp_evk build with buildman fails every other time

2024-08-27 Thread Simon Glass
Hi Jerome, On Tue, 27 Aug 2024 at 08:53, Fabio Estevam wrote: > > Adding Gary and Peng on Cc. > > On Tue, Aug 27, 2024 at 11:42 AM Jerome Forissier > wrote: > > > > Hi, > > > > Can someone explain what's happening with the imx8ulp_evk buildman build > > below? It either fails with a mkimage erro

Re: xPL terminology

2024-08-27 Thread Tom Rini
On Sun, Aug 25, 2024 at 07:07:23AM -0600, Simon Glass wrote: > Hi, > > We have the term 'SPL', which has a dual meaning. It is both a > particular phase of U-Boot (the one that loads U-Boot proper) and a > generic name for any pre-proper phase. > > You can see that in a few areas, but for exampl

Re: xPL terminology

2024-08-27 Thread Marek Vasut
On 8/25/24 3:07 PM, Simon Glass wrote: Hi, Hi, We have the term 'SPL', which has a dual meaning. It is both a particular phase of U-Boot (the one that loads U-Boot proper) and a generic name for any pre-proper phase. You can see that in a few areas, but for example CONFIG_SPL_BUILD is enable

[PATCH] mkimage: ecdsa: add signature/key nodes to dtb if missing

2024-08-27 Thread Matthias Pritschet
From: Matthias Pritschet If the signature/key node(s) are not yet present in the U-Boot device tree, ecdsa_add_verify_data simply fails if it can't find the nodes. This behaviour differs from rsa_add_verify_data, wich does add the missing nodes and proceeds in that case. This change is mainly co

[PATCH] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Tomas Paukrt
The PSR register works correctly for GPIO pins in input mode, but always returns 0 for GPIO pins in output mode. The DR register works correctly in both modes. Signed-off-by: Tomas Paukrt --- drivers/gpio/mxc_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH] lib: crypto: fix ASYMMETRIC_KEY_TYPE dependency

2024-08-27 Thread Tomas Paukrt
Fix the dependency to avoid a warning if RSA_VERIFY_WITH_PKEY is enabled. Fixes: b7463f198da6 ("Make ASYMMETRIC_KEY_TYPE depend on FIT_SIGNATURE") Signed-off-by: Tomas Paukrt --- lib/crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/crypto/Kconfig b/lib/crypt

Re: [PATCH] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Fabio Estevam
Hi Tomas, On Tue, Aug 27, 2024 at 2:52 PM Tomas Paukrt wrote: > > The PSR register works correctly for GPIO pins in input mode, > but always returns 0 for GPIO pins in output mode. > The DR register works correctly in both modes. The current code is correct as is. You should set the SION bit to

Re: [PATCH v3 0/5] arch: arm: dts: ti: Add missing fss range

2024-08-27 Thread Tom Rini
On Fri, 09 Aug 2024 18:01:52 -0500, Jonathan Humphreys wrote: > Upstream DTS added explicit ranges to the fss node. It did not include > the 32 bit memory space needed by the R5 to access OSPI. With the > upstream DTS sync, OSPI boot no longer works. > > Adding the missing range here. It is also

Re: [PATCH 1/1] ata: dwc_ahsata: create boot device

2024-08-27 Thread Tom Rini
On Thu, 08 Aug 2024 09:08:03 +0200, Heinrich Schuchardt wrote: > For each block device we must create a sibling boot device. > > Applied to u-boot/next, thanks! -- Tom

Re: [PATCH v2] remoteproc: uclass: Modify uc_pdata->name to use combination of device name and device's parent name

2024-08-27 Thread Tom Rini
On Wed, 07 Aug 2024 14:38:29 +0530, MD Danish Anwar wrote: > uc_pdata->name is populated from device tree property "remoteproc-name". > For those devcices that don't set "remoteproc-name", uc_pdata->name > falls back to dev->name. > > If two devices have same name, this will result into uc_pdata-

Re: [PATCH] omap3: omap3evm: Migrate to OF_UPSTREAM

2024-08-27 Thread Tom Rini
On Sat, Aug 24, 2024 at 05:48:22PM -0400, Derald D. Woods wrote: > This commit brings the omap3evm inline with the remaining OMAP3XXX variants. > > Signed-off-by: Derald D. Woods Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] pci: mediatek: add support for upstream split PCIe node

2024-08-27 Thread Tom Rini
On Mon, 12 Aug 2024 14:31:48 +0200, Christian Marangi wrote: > Add support for upstream linux split PCIe node. > > Upstream linux have an alternative way to declare PCIe nodes that splits > them in dedicated nodes for each line instead of putting them all in one > node. > > Detect this by checki

Re: [PATCH v3 1/1] ata: sata_rescan must scan for block devices

2024-08-27 Thread Tom Rini
On Wed, 14 Aug 2024 09:10:37 +0200, Heinrich Schuchardt wrote: > A system may have multiple SATA controller. Removing the controller with > the lowest sequence number before probing all SATA controllers makes no > sense. > > In sata_rescan we remove all block devices which are children of SATA >

Re: [PATCH v4 0/2] bootstd: Try again to resolve infinite-loop bug

2024-08-27 Thread Tom Rini
On Thu, 15 Aug 2024 14:30:20 -0600, Simon Glass wrote: > This little series tries to resolve a problem found with an earlier > fix. > > Changes in v4: > - Split bootstd patches into a separate series > > Changes in v3: > - Update commit message to describe how the problem will be addressed > - F

Re: [PATCH v3] sandbox: Fix pinmux warnings with non-test devicetrees

2024-08-27 Thread Tom Rini
On Thu, 15 Aug 2024 22:38:22 -0400, Sean Anderson wrote: > The sandbox pinmux driver is used in the non-test devicetree as well as > the test one. I didn't realize this when I modified the driver for > tests, and so broke the regular use case (which only resulted in > warnings). First, making the

Re: [PATCH] mkimage: ecdsa: add signature/key nodes to dtb if missing

2024-08-27 Thread Peter Robinson
On Tue, 27 Aug 2024 at 18:52, Matthias Pritschet wrote: > > From: Matthias Pritschet > > If the signature/key node(s) are not yet present in the U-Boot device > tree, ecdsa_add_verify_data simply fails if it can't find the nodes. > This behaviour differs from rsa_add_verify_data, wich does add th

Re: [Binman] Question regarding SPL symbol offsets generation

2024-08-27 Thread Fabio Estevam
Hi Lukasz, On Thu, Aug 15, 2024 at 5:14 PM Lukasz Majewski wrote: > Unfortunately not - this change is only for properly setting start > address of the u-boot. > > The _real_ problem here is the symbol placement generated by binman > when we try to define the image as a single one. > > Moreover,

Re: [PATCH v2] config: imx: Define CFG_SYS_UBOOT_BASE for Phytec's imx8mm SoM QSPI boot

2024-08-27 Thread Fabio Estevam
Hi Lukasz, On Tue, Aug 20, 2024 at 12:00 PM Lukasz Majewski wrote: > > The image offset when booting from SPI-NOR (QSPI, FSPI driver) is > different than one for SD card / eMMC as extra space (0x1000) is consumed > by FSPI configuration header (CONFIG_FSPI_CONF_HEADER). > > Signed-off-by: Lukasz

Re: xPL terminology

2024-08-27 Thread Simon Glass
Hi Tom, On Tue, 27 Aug 2024 at 10:50, Tom Rini wrote: > > On Sun, Aug 25, 2024 at 07:07:23AM -0600, Simon Glass wrote: > > > Hi, > > > > We have the term 'SPL', which has a dual meaning. It is both a > > particular phase of U-Boot (the one that loads U-Boot proper) and a > > generic name for any

Re: [PATCH v2 26/35] global_data: Reduce size of early-malloc vars

2024-08-27 Thread Simon Glass
Hi Tom, On Mon, 26 Aug 2024 at 12:33, Tom Rini wrote: > > On Fri, Aug 23, 2024 at 05:30:48PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 23 Aug 2024 at 15:49, Tom Rini wrote: > > > > > > On Fri, Aug 23, 2024 at 03:44:45PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Fri

Re: [Binman] Question regarding SPL symbol offsets generation

2024-08-27 Thread Simon Glass
Hi, On Tue, 27 Aug 2024 at 12:47, Fabio Estevam wrote: > > Hi Lukasz, > > On Thu, Aug 15, 2024 at 5:14 PM Lukasz Majewski wrote: > > > Unfortunately not - this change is only for properly setting start > > address of the u-boot. > > > > The _real_ problem here is the symbol placement generated b

Re: xPL terminology

2024-08-27 Thread Michael Nazzareno Trimarchi
Hi On Tue, Aug 27, 2024 at 9:25 PM Simon Glass wrote: > > Hi Tom, > > On Tue, 27 Aug 2024 at 10:50, Tom Rini wrote: > > > > On Sun, Aug 25, 2024 at 07:07:23AM -0600, Simon Glass wrote: > > > > > Hi, > > > > > > We have the term 'SPL', which has a dual meaning. It is both a > > > particular phase

Re: [PATCH] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Tomas Paukrt
>> The PSR register works correctly for GPIO pins in input mode, >> but always returns 0 for GPIO pins in output mode. >> The DR register works correctly in both modes. > > The current code is correct as is. > You should set the SION bit to read the value of the output pin. Hi Fabio, you are corr

[PATCH v2 1/4] imx: Remove CFG_MXC_USB_FLAGS

2024-08-27 Thread Fabio Estevam
From: Fabio Estevam CFG_MXC_USB_FLAGS is only used for drivers/usb/host/ehci-mx5.c, so it can be removed from all the imx6/imx7/imx8m board config files. mx51evk.h is the only place CFG_MXC_USB_FLAGS is not set to 0. Suggested-by: Tim Harvey Signed-off-by: Fabio Estevam Reviewed-by: Marek Vas

[PATCH v2 2/4] usb: ehci-mx5: Add a default for CFG_MXC_USB_PORTSC

2024-08-27 Thread Fabio Estevam
From: Fabio Estevam Just like drivers/usb/host/ehci-mx6.c, add a default for drivers/usb/host/ehci-mx5.c. The motivation for doing this is to remove CFG_MXC_USB_PORTSC from board config files. All the mx5 boards, with the exeption of mx51evk, define CFG_MXC_USB_PORTSC as: #define CFG_MXC_USB_

[PATCH v2 3/4] mx5: Remove CFG_MXC_USB_PORT

2024-08-27 Thread Fabio Estevam
From: Fabio Estevam CFG_MXC_USB_PORT is not used anywhere, so remove this unused symbol. Suggested-by: Tim Harvey Signed-off-by: Fabio Estevam --- Changes since v1: - Newly introduced. include/configs/m53menlo.h | 1 - include/configs/mx51evk.h| 1 - include/configs/mx53cx9020.h | 1 -

[PATCH v2 4/4] imx: Remove CFG_MXC_USB_PORTSC

2024-08-27 Thread Fabio Estevam
From: Fabio Estevam The definition of CFG_MXC_USB_PORTSC as (PORT_PTS_UTMI | PORT_PTS_PTW) can be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c. Suggested-by: Tim Harvey Signed-off-by: Fabio Estevam --- Chan

Re: [PATCH v2 4/4] imx: Remove CFG_MXC_USB_PORTSC

2024-08-27 Thread Tim Harvey
On Tue, Aug 27, 2024 at 12:43 PM Fabio Estevam wrote: > > From: Fabio Estevam > > The definition of CFG_MXC_USB_PORTSC as (PORT_PTS_UTMI | PORT_PTS_PTW) > can be removed from mx5/mx6/mx7/mx8m board config files as it is the > default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c.

Re: [PATCH] mkimage: ecdsa: add signature/key nodes to dtb if missing

2024-08-27 Thread Matthias Pritschet
Am 27.08.24 um 20:40 schrieb Peter Robinson: On Tue, 27 Aug 2024 at 18:52, Matthias Pritschet wrote: From: Matthias Pritschet If the signature/key node(s) are not yet present in the U-Boot device tree, ecdsa_add_verify_data simply fails if it can't find the nodes. This behaviour differs from

Re: [PATCH] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Fabio Estevam
Hi Tomas, On Tue, Aug 27, 2024 at 4:41 PM Tomas Paukrt wrote: > Hi Fabio, > > you are correct that the existing code will work if the SION bit is set, but > this is not always possible or desirable. For example, if you use the command > "gpio set" to set the state of a pin that is not configur

[PATCH] ARM: imx: Enable MMU and dcache very early on i.MX8M

2024-08-27 Thread Marek Vasut
Enable MMU and caches very early on in the boot process on i.MX8M in U-Boot proper. This allows board_init_f to run with icache and dcache enabled, which saves some 700 milliseconds of boot time on i.MX8M Plus based device. The 'bootstage report' output is below: Before: ``` Timer summary in micr

[PATCH] ARM: imx: Make PLL settings configurable at board level

2024-08-27 Thread Marek Vasut
Staticize intpll_configure(). Add weak board_imx_intpll_override() function which can be defined at board level to override specific PLL frequency settings early during boot. This can be used to for example force faster CPU core clock frequency if the hardware can handle it. Example of increasing

Re: xPL terminology

2024-08-27 Thread Tom Rini
On Tue, Aug 27, 2024 at 01:24:59PM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 27 Aug 2024 at 10:50, Tom Rini wrote: > > > > On Sun, Aug 25, 2024 at 07:07:23AM -0600, Simon Glass wrote: > > > > > Hi, > > > > > > We have the term 'SPL', which has a dual meaning. It is both a > > > particular p

Re: [PATCH v2 4/4] imx: Remove CFG_MXC_USB_PORTSC

2024-08-27 Thread Fabio Estevam
On 27/08/2024 16:43, Fabio Estevam wrote: diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h index 6c8cb78274b..16a2d860619 100644 --- a/include/configs/mx51evk.h +++ b/include/configs/mx51evk.h @@ -33,7 +33,6 @@ #define CFG_SYS_FSL_ESDHC_ADDR MMC_SDHC1_BASE_ADDR /* USB Config

Re: [PATCH] mtd: nand: raw: omap_gpmc: Check return value of gpmc_nand_init

2024-08-27 Thread Tom Rini
On Wed, 31 Jul 2024 20:28:55 +0530, Vignesh Raghavendra wrote: > If the function is called with no NAND device attached, then this > function can return error value, proceeding further ignoring the same > can cause system crash. This is seen when "mtd list" is run with no NAND > addon cards connec

Re: [PATCH] dm: core: Show device sequence instead in dm_dump_tree()

2024-08-27 Thread Tom Rini
On Fri, 02 Aug 2024 11:28:12 +0200, Zixun LI wrote: > Currently uclass index is shown in DM tree dump which ignores alias > sequence numbering. The result could be confusing since these 2 numbers > could be different. Show device sequence number instead as it's more > meaningful. > > Also update

Re: [PATCH] cmd: bind: Use device sequence instead for driver bind/unbind

2024-08-27 Thread Tom Rini
On Fri, 02 Aug 2024 11:28:13 +0200, Zixun LI wrote: > Currently uclass index is used for bind/unbind which ignores alias > sequence numbering. Use device sequence number instead as it's > the number explicitly set in the DT. > > Also update documentation to use sequence number. > > > [...] App

Re: [PATCH v3] test/py: spi: Add tests for SPI flash device

2024-08-27 Thread Tom Rini
On Wed, 31 Jul 2024 14:54:12 +0530, Love Kumar wrote: > Add test cases for sf commands to verify various SPI flash operations > such as erase, write and read. It also adds qspi lock unlock cases. > This test relies on boardenv_* configurations to run it for different > SPI flash family such as sin

Re: [PATCH v1] gpio: npcm: Add SGPIO support for Nuvoton NPCM SoCs

2024-08-27 Thread Tom Rini
On Mon, 29 Jul 2024 16:51:03 +0800, Jim Liu wrote: > Add Nuvoton BMC NPCM7xx/NPCM8xx sgpio driver. > BMC can use this driver to increase 64 GPI pins and 64 GPO pins to use. > > Applied to u-boot/next, thanks! -- Tom

Re: [PATCH v1] timer: npcm: Change counter source

2024-08-27 Thread Tom Rini
On Mon, 29 Jul 2024 17:04:06 +0800, Jim Liu wrote: > The counter value read from TDR register may not be correct. > Read SECCNT and CNTR25M instead to get the correct timestamp. > > Applied to u-boot/next, thanks! -- Tom

Re: [PATCH 0/3] dm: core: Avoid multiple calls to fdt_parent_offset()

2024-08-27 Thread Tom Rini
On Sun, 04 Aug 2024 15:05:48 +, Jonas Karlman wrote: > Use of fdt_parent_offset() is very expensive as detailed by the function > documentation: > > NOTE: This function is expensive, as it must scan the device tree > structure from the start to nodeoffset, *twice*. > > This series remove

Re: [PATCH] list: use list_count_nodes() to count list entries

2024-08-27 Thread Tom Rini
On Wed, Jul 31, 2024 at 08:25:21PM +0530, Sughosh Ganu wrote: > Use the API function list_count_nodes() to count the number of list > entries. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Simon Glass > --- > > Note: To be applied on top of efi-2024-10-rc2 Please rebase this on top of either

Re: [PATCH] mtd: nand: raw: omap_gpmc: Check return value of gpmc_nand_init

2024-08-27 Thread Michael Nazzareno Trimarchi
Hi Tom On Wed, Aug 28, 2024 at 1:22 AM Tom Rini wrote: > > On Wed, 31 Jul 2024 20:28:55 +0530, Vignesh Raghavendra wrote: > > > If the function is called with no NAND device attached, then this > > function can return error value, proceeding further ignoring the same > > can cause system crash. T

Re: [PATCH] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Fabio Estevam
Hi Tomas, On Tue, Aug 27, 2024 at 4:53 PM Fabio Estevam wrote: > > Hi Tomas, > > On Tue, Aug 27, 2024 at 4:41 PM Tomas Paukrt wrote: > > > Hi Fabio, > > > > you are correct that the existing code will work if the SION bit is set, > > but this is not always possible or desirable. For example, if

Re: [PATCH] android_ab: Fix backup offset calculation

2024-08-27 Thread Sam Protsenko
On Wed, Aug 7, 2024 at 9:14 AM Joshua Watt wrote: > > The backup offset is in bytes, but was incorrectly be interpreted as > blocks, leading to it being written to the wrong location. Fix the > calculation and clarify that ANDROID_AB_BACKUP_OFFSET is in bytes and > must be a multiple of the block

Re: [PATCH] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Tomas Paukrt
> For more information, please read this thread posted on > linux-arm-kernel ten years ago: > > https://patchwork.kernel.org/project/linux-arm-kernel/patch/CAJ+vNU3w9Oi+dErmy9x8g6ps=eLHLNLO-w7=gn_8jty4kab...@mail.gmail.com/ > > I hope this helps to clarify. There is a good point that using the PSR

[PATCH 0/6] x86: Correct timer overflow and add msr/cpuid commands

2024-08-27 Thread Simon Glass
This series corrects an overflow of the timer which happens on QEMU on newer hardware. It also adds commands to read/write CPU ID registers and machine-status registers (MSRs). Simon Glass (6): x86: Show the CPU vendor in bdinfo x86: Ensure the CPU identity exists for timer init x86: Avoid

[PATCH 1/6] x86: Show the CPU vendor in bdinfo

2024-08-27 Thread Simon Glass
Refactor the cpu code and use it to show the CPU vendor, e.g. AuthenticAMD or GenuineIntel Signed-off-by: Simon Glass --- arch/x86/cpu/i386/cpu.c | 94 ++- arch/x86/include/asm/u-boot-x86.h | 8 +++ arch/x86/lib/bdinfo.c | 7 ++- 3 files chang

[PATCH 2/6] x86: Ensure the CPU identity exists for timer init

2024-08-27 Thread Simon Glass
When bootstage is used the timer can be inited before the CPU identity is set up, resulting in the checks for the vendor not working. Add a special call to work around this. Signed-off-by: Simon Glass --- arch/x86/cpu/i386/cpu.c | 5 + arch/x86/cpu/x86_64/cpu.c | 6 ++

[PATCH 3/6] x86: Avoid timer-clock overflow

2024-08-27 Thread Simon Glass
When the clock speed is above about 4GHz, e.g. on modern PC hardware, the timer overflows, resulting in a much lower frequency than expected. Deal with this by capping the clock speed. It would be possible to move to a 64-bit value for the clock, but that is a pain to deal with. A better approach

[PATCH 4/6] x86: Sync up tsc_timer with Linux

2024-08-27 Thread Simon Glass
Since we are using the code from Linux, update it to the newer version in v6.11 Signed-off-by: Simon Glass --- drivers/timer/tsc_timer.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/timer/tsc_timer.c b/drivers/timer/tsc_timer.c index 2f2c2f27b7f..dd

[PATCH 5/6] x86: Add a cpuid command

2024-08-27 Thread Simon Glass
It is useful to obtain the results of cpuid queries, so add a command for this. Signed-off-by: Simon Glass --- cmd/x86/Makefile| 2 +- cmd/x86/cpuid.c | 37 ++ doc/usage/cmd/cpuid.rst | 68 + doc/usage/index.rst |

[PATCH 6/6] x86: Add msr command

2024-08-27 Thread Simon Glass
It is useful to obtain the results of MSR queries as well as to update MSR registers, so add a command these tasks. Signed-off-by: Simon Glass --- cmd/x86/Makefile | 2 +- cmd/x86/msr.c | 52 doc/usage/cmd/msr.rst | 61 +

[PATCH 00/18] vbe: Series part D

2024-08-27 Thread Simon Glass
This includes various patches towards implementing the VBE abrec bootmeth in U-Boot. Simon Glass (18): sandbox: Add missing header file bootstd: Add stub for bootdev_setup_for_sibling_blk() gzip: Correct function comment for gunzip() fdtdec: Support separate BSS for all XPL builds tiny-

[PATCH 01/18] sandbox: Add missing header file

2024-08-27 Thread Simon Glass
This file uses __aligned so should include the header which defines that. Signed-off-by: Simon Glass --- arch/sandbox/include/asm/sections.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sandbox/include/asm/sections.h b/arch/sandbox/include/asm/sections.h index 88837bb35c8..5e157741

[PATCH 02/18] bootstd: Add stub for bootdev_setup_for_sibling_blk()

2024-08-27 Thread Simon Glass
When bootstd is not enabled, bootdevs should not be set up. Add a static inline function to see to this. Signed-off-by: Simon Glass --- include/bootdev.h | 8 1 file changed, 8 insertions(+) diff --git a/include/bootdev.h b/include/bootdev.h index 2cee8832d26..ad4af0d1310 100644 --- a

[PATCH 03/18] gzip: Correct function comment for gunzip()

2024-08-27 Thread Simon Glass
This doesn't describe the length parameter correctly. Fix it and zunzip() too. Signed-off-by: Simon Glass --- include/gzip.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/gzip.h b/include/gzip.h index 5e0d0ec07fb..304002ffc42 100644 --- a/include/gzip.h +++ b

[PATCH 04/18] fdtdec: Support separate BSS for all XPL builds

2024-08-27 Thread Simon Glass
Adjust the condition so that separate BSS can be deselected for TPL and VPL. Signed-off-by: Simon Glass --- lib/fdtdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 5edc8dd2f9f..106bb406365 100644 --- a/lib/fdtdec.c +++ b/lib/fdtdec.c @@

[PATCH 05/18] tiny-printf: Correct return values

2024-08-27 Thread Simon Glass
The sprintf() etc. functions are supposed to return the length of the string written, but do not. Fix this by checking the amount of buffer space used. Signed-off-by: Simon Glass --- lib/tiny-printf.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/lib/tiny-p

[PATCH 06/18] tpl: Support numbered aliases in device tree

2024-08-27 Thread Simon Glass
Add an option so that this feature can be enabled in TPL for boards which need it. Signed-off-by: Simon Glass --- drivers/core/Kconfig | 8 1 file changed, 8 insertions(+) diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig index 1a7be4d9b4d..d811120aef5 100644 --- a/drivers/core

[PATCH 07/18] ram: Support driver model in TPL

2024-08-27 Thread Simon Glass
Some boards want to use RAM in TPL so add an option for that. Signed-off-by: Simon Glass --- drivers/ram/Kconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/ram/Kconfig b/drivers/ram/Kconfig index a64d2dff68d..f7e357f24da 100644 --- a/drivers/ram/Kconfig +++ b/drivers/r

[PATCH 08/18] serial: Support debug UART in TPL

2024-08-27 Thread Simon Glass
Some boards want to use the debug UART in TPL so add an option for that. Signed-off-by: Simon Glass --- drivers/serial/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 3a1e5a6f287..8b27ad9a77e 100644 --- a/drivers/serial/Kc

[PATCH 09/18] armv8: Support not having separate BSS

2024-08-27 Thread Simon Glass
Separate BSS is current mandatory on armv8 but this is not useful for early boot phases. Add support for the combined BSS. Use an #ifdef to avoid using CONFIG_SPL_BSS_START_ADDR which is not valid in this case. Signed-off-by: Simon Glass --- arch/arm/cpu/armv8/u-boot-spl.lds | 12

[PATCH 10/18] arm: cache: Drop a stale comment

2024-08-27 Thread Simon Glass
This header includes more than just dummy functions, so drop this comment. Signed-off-by: Simon Glass --- arch/arm/lib/cache.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c index b2ae74a59f1..648edf308f6 100644 --- a/arch/arm/lib/cache.c +++ b/

[PATCH 11/18] arm: Fix up a stale comment in sections.c

2024-08-27 Thread Simon Glass
There are currently four symbols here, so drop the word 'two'. Signed-off-by: Simon Glass --- arch/arm/lib/sections.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/lib/sections.c b/arch/arm/lib/sections.c index 07efabaa7dc..8955aa6111c 100644 --- a/arch/arm/lib/se

[PATCH 12/18] mmc: Support driver model in TPL

2024-08-27 Thread Simon Glass
Some boards want to use DM_MMC in TPL so add an option for that. Signed-off-by: Simon Glass --- drivers/mmc/Kconfig | 12 1 file changed, 12 insertions(+) diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index 982e84dc3bc..2b55ddb7af2 100644 --- a/drivers/mmc/Kconfig +++ b/d

[PATCH 13/18] mmc: Add more debugging for SPL

2024-08-27 Thread Simon Glass
When MMC booting fails it is sometimes hard to figure out what went wrong as there is no error code. It isn't even clear which MMC device was chosen, since SPL can have its own numbering. Add some debugging to help with this. Signed-off-by: Simon Glass --- common/spl/spl_mmc.c | 13 +++

[PATCH 14/18] mmc: Log the error when init fails

2024-08-27 Thread Simon Glass
Add an error-return log to the call in mmc_init_device() Signed-off-by: Simon Glass --- drivers/mmc/mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 9644aa7aa43..eece4784288 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc

[PATCH 15/18] mmc: rockchip: Log some error returns

2024-08-27 Thread Simon Glass
Add a little logging to some places in this driver, to aid debugging when something goes wrong. Signed-off-by: Simon Glass --- drivers/mmc/rockchip_dw_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/rockchip_dw_mmc.c b/drivers/mmc/rockchip_dw_mmc.c inde

[PATCH 16/18] mmc: rockchip: Allow clocks to be missing

2024-08-27 Thread Simon Glass
Allow MMC init when clock support is not enabled in a particular phase. Refactor the setting of priv->emmc_clk so it is a bit clearer. Signed-off-by: Simon Glass --- drivers/mmc/rockchip_dw_mmc.c | 6 ++ drivers/mmc/rockchip_sdhci.c | 9 - 2 files changed, 6 insertions(+), 9 delet

[PATCH 17/18] rockchip: mmc: Fix a missing colon

2024-08-27 Thread Simon Glass
Add a missing colon in rk3399_emmc_get_phy(). Signed-off-by: Simon Glass --- drivers/mmc/rockchip_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index 15b4a39770a..6c5c8781c3e 100644 --- a/drivers/mmc/rockc

[PATCH 18/18] rockchip: Provided SPL control over efuse presence

2024-08-27 Thread Simon Glass
This driver should not generally be present in SPL, even if misc devices are enabled. Update the Makefile rule accordingly. Signed-off-by: Simon Glass --- drivers/misc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile inde

Re: [PATCH] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Fabio Estevam
Hi Tomas, On Tue, Aug 27, 2024 at 10:31 PM Tomas Paukrt wrote: > I checked the current Linux driver and it uses the DR register for all > outputs. > This change was implemented about a year later after the mentioned discussion: > > https://lore.kernel.org/all/1430321701-13758-5-git-send-email-v

[PATCH v2] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Tomas Paukrt
The PSR register works correctly for GPIO pins in input mode, but always returns 0 for GPIO pins in output mode unless the SION bit is set. The DR register works correctly in both modes without the need to set the SION bit. Please note that the Linux gpio-mxc driver already uses the DR register fo

Re: [PATCH v2] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Fabio Estevam
Adding more folks on Cc to help review it. On Tue, Aug 27, 2024 at 11:13 PM Tomas Paukrt wrote: > > The PSR register works correctly for GPIO pins in input mode, > but always returns 0 for GPIO pins in output mode unless the SION > bit is set. The DR register works correctly in both modes withou

Re: [PATCH 13/18] mmc: Add more debugging for SPL

2024-08-27 Thread Marek Vasut
On 8/28/24 3:45 AM, Simon Glass wrote: When MMC booting fails it is sometimes hard to figure out what went wrong as there is no error code. It isn't even clear which MMC device was chosen, since SPL can have its own numbering. Add some debugging to help with this. Signed-off-by: Simon Glass --

Re: [PATCH v2] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Marek Vasut
On 8/28/24 4:16 AM, Fabio Estevam wrote: Adding more folks on Cc to help review it. On Tue, Aug 27, 2024 at 11:13 PM Tomas Paukrt wrote: The PSR register works correctly for GPIO pins in input mode, but always returns 0 for GPIO pins in output mode unless the SION bit is set. The DR register

[PATCH v3] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-27 Thread Tomas Paukrt
The PSR register works correctly for GPIO pins in input mode, but always returns 0 for GPIO pins in output mode unless the SION bit is set. The DR register should be used for GPIO pins in output mode to allow correct getting of previously set output value. Please note that the Linux gpio-mxc driv