Re: [PATCH] android_ab: Fix backup offset calculation

2024-08-16 Thread Mattijs Korpershoek
Hi Joshua, Thank you for the patch. On mer., août 07, 2024 at 08:13, Joshua Watt wrote: > The backup offset is in bytes, but was incorrectly be interpreted as > blocks, leading to it being written to the wrong location. Fix the > calculation and clarify that ANDROID_AB_BACKUP_OFFSET is in bytes

Re: [PATCH 18/40] lmb: remove the lmb_init_and_reserve() function

2024-08-16 Thread Sughosh Ganu
On Thu, 15 Aug 2024 at 22:14, Caleb Connolly wrote: > > Hi, > > On 24/07/2024 08:02, Sughosh Ganu wrote: > > With the changes to make the LMB reservations persistent, the common > > memory regions are being added during board init. Remove the > > now superfluous lmb_init_and_reserve() function. >

Re: [PATCH v2 27/32] test: cedit: use allocated address for reading file

2024-08-16 Thread Sughosh Ganu
On Fri, 16 Aug 2024 at 02:02, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 14 Aug 2024 at 05:02, Sughosh Ganu wrote: > > > > Instead of a randomly selected address, use an LMB allocated one for > > reading the file into memory. With the LMB map now being persistent > > and global, the address u

Re: [PATCH] imx: ele_ahab: Add HUK derivation support

2024-08-16 Thread Fabio Estevam
Hi Peng and Ye Li, Please help review the patch below. Thanks. On Tue, Aug 13, 2024 at 3:32 AM Mathieu Othacehe wrote: > > Add a new ahab_derive command that derives the hardware unique key (HUK) > into a 16 or 32 bytes key and stores it at the given address. > > Signed-off-by: Mathieu Othacehe

Re: [PATCH] imx: ele_ahab: Add HUK derivation support

2024-08-16 Thread Ye Li
Hi Mathieu, On 8/13/2024 2:32 PM, Mathieu Othacehe wrote: Add a new ahab_derive command that derives the hardware unique key (HUK) into a 16 or 32 bytes key and stores it at the given address. Signed-off-by: Mathieu Othacehe --- arch/arm/include/asm/mach-imx/ele_api.h | 2 + arch/arm/mach-

Re: [PATCH v2 18/32] lmb: add a common implementation of arch_lmb_reserve()

2024-08-16 Thread Sughosh Ganu
On Fri, 16 Aug 2024 at 02:04, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 14 Aug 2024 at 12:02, Sughosh Ganu wrote: > > > > Almost all of the current definitions of arch_lmb_reserve() are doing > > the same thing. The only exception in a couple of cases is the > > alignment parameter requireme

Re: [PATCH v3 04/10] soc: ti: k3-navss-ringacc: Fix reset ring API

2024-08-16 Thread Sverdlin, Alexander
Hi Chintan, Vignesh, On Fri, 2024-07-05 at 10:20 +0530, Chintan Vankar wrote: > From: Vignesh Raghavendra > > Expectation of k3_ringacc_ring_reset_raw() is to reset the ring to > requested size and not to 0. Fix this. > > Signed-off-by: Vignesh Raghavendra > Signed-off-by: Siddharth Vadapalli

Re: [PATCH v3 02/10] firmware: ti_sci: Add No-OP for "RX_FL_CFG"

2024-08-16 Thread Sverdlin, Alexander
On Fri, 2024-07-05 at 10:20 +0530, Chintan Vankar wrote: > From: Kishon Vijay Abraham I > > RX_FL_CFG message should not be forwarded to TIFS and should be > handled within R5 SPL (when DM services are not available). Add > a no-op function to not handle RX_FL_CFG messages. > > Signed-off-by: Ki

Re: [PATCH v3 03/10] soc: ti: k3-navss-ringacc: Initialize base address of ring cfg registers

2024-08-16 Thread Sverdlin, Alexander
On Fri, 2024-07-05 at 10:20 +0530, Chintan Vankar wrote: > From: Kishon Vijay Abraham I > > Initialize base address of ring config registers required to natively > setup ring cfg registers in the absence of Device Manager (DM) services > at R5 SPL stage. Since register property is defined as "rin

Re: [PATCH v3 05/10] dma: ti: k3-udma: Add support for native configuration of chan/flow

2024-08-16 Thread Sverdlin, Alexander
Hi Chintan, On Fri, 2024-07-05 at 10:20 +0530, Chintan Vankar wrote: > From: Kishon Vijay Abraham I > > In absence of Device Manager (DM) services such as at R5 SPL stage, > driver will have to natively setup TCHAN/RCHAN/RFLOW cfg registers. > Existing UDMA driver performed the above mentioned c

Re: [PATCH v3 06/10] arm: mach-k3: am62x: am625_init: Probe AM65 CPSW NUSS

2024-08-16 Thread Sverdlin, Alexander
Hi Chintan, On Fri, 2024-07-05 at 10:20 +0530, Chintan Vankar wrote: > From: Kishon Vijay Abraham I > > In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS > driver in board_init_f(). > > Signed-off-by: Kishon Vijay Abraham I > Signed-off-by: Siddharth Vadapalli > Signed-off-by:

Re: [PATCH v3 09/10] arm: dts: k3-am625-r5-sk: Enable DM services for main_pktdma

2024-08-16 Thread Sverdlin, Alexander
Hi Chintan, On Fri, 2024-07-05 at 10:20 +0530, Chintan Vankar wrote: > From: Siddharth Vadapalli > > Enable DM services for main_pktdma during R5 SPL stage. > > Signed-off-by: Siddharth Vadapalli > Signed-off-by: Chintan Vankar Reviewed-by: Alexander Sverdlin > --- > > Link to v2: > https

Re: [PATCH 12/35] global_data: Convert have_console into a flag

2024-08-16 Thread Sverdlin, Alexander
Hi Simon, On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote: > We don't need a full word for this boolean value. Convert it into a flag > to save space in global_data. > > Signed-off-by: Simon Glass > --- > >  arch/arm/cpu/arm926ejs/mxs/spl_boot.c |  2 +- >  arch/arm/mach-exynos/spl_boot.c  

[PATCH] configs: am64x*_r5_defconfig: Drop BOOTCOMMAND

2024-08-16 Thread Wadim Egorov
There is no need to define a default for bootcmd in R5 u-boot because the R5 is directly booting into the next stage A53 bootloader. Signed-off-by: Wadim Egorov --- configs/am64x_evm_r5_defconfig | 2 -- configs/phycore_am64x_r5_defconfig | 2 -- 2 files changed, 4 deletions(-) diff --git a

[PATCH] spl: fix error handling of spl_fit_read

2024-08-16 Thread mailinglist1
From: Johannes Kirchmair Returning negative values from spl_fit_read leads to u-boot crashing. The return value of spl_fit_read is compared with an unsigned value. Returning negative values leads to the check not detecting the error. Not detecting the error leads to crashing. Returning zero in c

[PATCH] usb: add reset pin handling to onboard-hub driver

2024-08-16 Thread mailinglist1
From: Johannes Kirchmair Some onboard-hub chips have external reset pins. This patch adds handling of said pin to the onboard-hub driver. The naming for the devicetree binding is done in the same way as in the Linux kernel to ensure good compatibility between u-boot's and Linux's devicetrees. Si

Re: [PATCH v2 27/32] test: cedit: use allocated address for reading file

2024-08-16 Thread Simon Glass
Hi Sughosh, On Fri, 16 Aug 2024 at 04:34, Sughosh Ganu wrote: > > On Fri, 16 Aug 2024 at 02:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 14 Aug 2024 at 05:02, Sughosh Ganu wrote: > > > > > > Instead of a randomly selected address, use an LMB allocated one for > > > reading the fil

Re: [PATCH 1/3] test/overlay: Make this depend on SANDBOX

2024-08-16 Thread Simon Glass
On Thu, 15 Aug 2024 at 21:49, Tom Rini wrote: > > As the overlays are sandbox specific, mark the whole test as depending > on sandbox. > > Signed-off-by: Tom Rini > --- > Cc: Simon Glass > --- > test/overlay/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Gla

Re: [PATCH 3/3] test/cmd: Move wget test to under a sandbox guard

2024-08-16 Thread Simon Glass
On Thu, 15 Aug 2024 at 21:49, Tom Rini wrote: > > This test is sandbox-centric, so guard it so. > > Signed-off-by: Tom Rini > --- > test/cmd/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass > > diff --git a/test/cmd/Makefile b/test/cmd/Makefile > inde

Re: [PATCH 2/3] test/boot: Make BOOTSTD tests depend on UT_BOOTSTD

2024-08-16 Thread Simon Glass
On Thu, 15 Aug 2024 at 21:49, Tom Rini wrote: > > While we have a symbol for controlling if we will be testing BOOTSTD or > not, and it depends on SANDBOX, we do not control the building of > test/boot/ content correctly. Guard the current bootstd tests with > a check for UT_BOOTSTD and leave the

Re: [PATCH] usb: gadget: udc: Fix duplicate uclass name

2024-08-16 Thread Mattijs Korpershoek
Hi Zixun, On mar., août 13, 2024 at 15:39, Zixun LI wrote: > Hi Mattijs, > > On Tue, Aug 13, 2024 at 10:28 AM Mattijs Korpershoek > wrote: >> >> Thank you for giving some board examples. I am still a bit unclear on >> the meaning of: >> >> """ >> This breaks the capacity of using "usb" as DT al

[PATCH 00/10] SMBIOS improvements

2024-08-16 Thread Raymond Mao
Motivations for changes: Current SMBIOS library and command-line tool is not fully matching with the requirements: 1. Missing support for other mandatory types (#7, #9, #16, #17, #19). 2. Only a few platforms support SMBIOS node from the device tree. 3. Values of some fields are hardcoded in the li

[PATCH 01/10] sysinfo: Add sysinfo API for accessing data area

2024-08-16 Thread Raymond Mao
Add interface for sysinfo to access a data area from the platform. This is useful to save/read a memory region of platform-specific data. Signed-off-by: Raymond Mao --- drivers/sysinfo/sysinfo-uclass.c | 20 include/sysinfo.h| 30 +

[PATCH 02/10] sysinfo: Add sysinfo driver and data structure for SMBIOS

2024-08-16 Thread Raymond Mao
Add sysinfo interface and definitions to support SMBIOS type 0 to type 4. Signed-off-by: Raymond Mao --- drivers/sysinfo/Makefile | 1 + drivers/sysinfo/smbios_plat.c | 270 ++ drivers/sysinfo/smbios_plat.h | 104 + include/smbios.h

[PATCH 03/10] smbios: Refactor SMBIOS library

2024-08-16 Thread Raymond Mao
Current SMBIOS library does not fully match to the specification. It hardcodes values instead of exposing values from the device. It does not support dynamic length for contained object handles or elements and misses the handling of a few fields. The refactoring of this patch includes: 1. Expose v

[PATCH 04/10] smbios: ignore the non-existence of platform sysinfo detect

2024-08-16 Thread Raymond Mao
During writing SMBIOS table, implementation of sysinfo detect function for a specific platform is not mandatory. Thus we should not return an error when platform sysinfo detect function does not exist. Signed-off-by: Raymond Mao --- lib/smbios.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletio

[PATCH 05/10] armv8: Add arch-specific sysinfo driver

2024-08-16 Thread Raymond Mao
Add common sysinfo driver for armv8 platforms containing all necessary SMBIOS information (Type 1 to 4). Signed-off-by: Raymond Mao --- arch/arm/cpu/armv8/Makefile | 5 + arch/arm/cpu/armv8/sysinfo.c | 203 +++ 2 files changed, 208 insertions(+) create mode 10

[PATCH 06/10] sysinfo: Add sysinfo driver for SMBIOS type 7

2024-08-16 Thread Raymond Mao
Add sysinfo interface and data structures for cache information required by SMBIOS type 7. Signed-off-by: Raymond Mao --- drivers/sysinfo/smbios_plat.c | 172 ++ drivers/sysinfo/smbios_plat.h | 27 ++ include/smbios.h | 112 ++

[PATCH 07/10] smbios: Add support to SMBIOS type 7

2024-08-16 Thread Raymond Mao
Add SMBIOS type 7 (cache information) write functions. Link cache handles from type 7 to type 4. Add SMBIOS command print functions for type 7. Signed-off-by: Raymond Mao --- cmd/smbios.c | 82 +++ lib/smbios.c | 106 ++

[PATCH 08/10] armv8: Add sysinfo driver for cache information

2024-08-16 Thread Raymond Mao
Add cache information sysinfo driver containing necessary information required by SMBIOS type 7 for all armv8 platforms. Signed-off-by: Raymond Mao --- arch/arm/cpu/armv8/sysinfo.c | 188 +++ 1 file changed, 188 insertions(+) diff --git a/arch/arm/cpu/armv8/sysin

[PATCH 09/10] configs: Enable sysinfo for QEMU Arm64

2024-08-16 Thread Raymond Mao
Enable sysinfo smbios by default for Arm64. When SYSINFO_SMBIOS is enabled, disable QFW_SMBIOS. Signed-off-by: Raymond Mao --- configs/qemu_arm64_defconfig | 2 ++ drivers/misc/Kconfig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/configs/qemu_arm64_defconfig b/co

[PATCH 10/10] tests: update smbios pytest

2024-08-16 Thread Raymond Mao
Update the expected test result to align with the smbios library changes. Signed-off-by: Raymond Mao --- test/py/tests/test_smbios.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/py/tests/test_smbios.py b/test/py/tests/test_smbios.py index 82b0b689830..ffa4ea795ec 100

Re: [PATCH v4 13/14] test: efi: boot: Set up an image suitable for EFI testing

2024-08-16 Thread Tom Rini
On Thu, Aug 15, 2024 at 02:24:23PM -0600, Simon Glass wrote: > Create a new disk for use with tests, which contains the new 'testapp' > EFI app specifically intended for testing the EFI loader. > > Attach it to the USB device, since most testing is currently done with > mmc. > > Initially this im

Re: [PATCH v3 04/24] test/py: Fix some pylint warnings in test_ut.py

2024-08-16 Thread Tom Rini
On Thu, Aug 15, 2024 at 02:25:15PM -0600, Simon Glass wrote: > Tidy up most of these warnings. Remaining are four of these: > >R0914: Too many local variables > > which can only by fixed by splitting things into functions, so that is > left for another time. > > Part of this change was done

Re: [PATCH v8 00/23] Introduce the lwIP network stack

2024-08-16 Thread Jerome Forissier
On 8/7/24 22:44, Tom Rini wrote: > On Wed, Aug 07, 2024 at 07:11:44PM +0200, Jerome Forissier wrote: > >> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip >> library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP >> stack [2] [3] as an alternative to

Re: [PATCH v2 1/1] disk: add TegraPT support

2024-08-16 Thread Svyatoslav Ryhel
Since there were no objections (apart help Kconfig expansion which I will add) or improvement suggestions to this patch for over 2 weeks (first patchset submitted on 01.08.24) I am picking it into Tegra custodian tree. пн, 12 серп. 2024 р. о 21:42 Tom Rini пише: > > On Sat, Aug 10, 2024 at 08:29:

Re: [PATCH v2 1/1] board: tegra: convert boards to text env

2024-08-16 Thread Svyatoslav Ryhel
ср, 7 серп. 2024 р. о 17:36 Simon Glass пише: > > On Wed, 7 Aug 2024 at 06:14, Svyatoslav Ryhel wrote: > > > > Convert boards to use text based env. This is the first stage of > > conversion, common inclusions should be converted next. > > > > Signed-off-by: Svyatoslav Ryhel > > --- > > board/a

Re: [PATCH v2 27/32] test: cedit: use allocated address for reading file

2024-08-16 Thread Sughosh Ganu
On Fri, 16 Aug 2024 at 20:17, Simon Glass wrote: > > Hi Sughosh, > > On Fri, 16 Aug 2024 at 04:34, Sughosh Ganu wrote: > > > > On Fri, 16 Aug 2024 at 02:02, Simon Glass wrote: > > > > > > Hi Sughosh, > > > > > > On Wed, 14 Aug 2024 at 05:02, Sughosh Ganu > > > wrote: > > > > > > > > Instead of

Re: [PATCH v3 2/3] buildman: Allow skipping the dtc build

2024-08-16 Thread Tom Rini
On Thu, Aug 15, 2024 at 01:57:45PM -0600, Simon Glass wrote: > For most boards, the device-tree compiler is built in-tree, ignoring the > system version. Add a special option to skip this build. This can be > useful when the system dtc is up-to-date, as it speeds up the build. > > Signed-off-by:

Re: [PATCH v2 1/1] board: tegra: convert boards to text env

2024-08-16 Thread Francesco Dolcini
Hello, On Fri, Aug 16, 2024 at 07:51:25PM +0300, Svyatoslav Ryhel wrote: > > On Wed, 7 Aug 2024 at 06:14, Svyatoslav Ryhel wrote: > > > > > > Convert boards to use text based env. This is the first stage of > > > conversion, common inclusions should be converted next. > > > > > > Signed-off-by: S

Re: [PATCH v2 27/32] test: cedit: use allocated address for reading file

2024-08-16 Thread Sughosh Ganu
On Fri, 16 Aug 2024 at 22:39, Sughosh Ganu wrote: > > On Fri, 16 Aug 2024 at 20:17, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Fri, 16 Aug 2024 at 04:34, Sughosh Ganu wrote: > > > > > > On Fri, 16 Aug 2024 at 02:02, Simon Glass wrote: > > > > > > > > Hi Sughosh, > > > > > > > > On Wed, 1

Re: [PATCH v2 27/32] test: cedit: use allocated address for reading file

2024-08-16 Thread Tom Rini
On Thu, Aug 15, 2024 at 09:32:29PM +0100, Simon Glass wrote: > Hi Sughosh, > > On Wed, 14 Aug 2024 at 05:02, Sughosh Ganu wrote: > > > > Instead of a randomly selected address, use an LMB allocated one for > > reading the file into memory. With the LMB map now being persistent > > and global, the

Re: [PATCH v2 27/32] test: cedit: use allocated address for reading file

2024-08-16 Thread Sughosh Ganu
On Fri, 16 Aug 2024 at 11:36 PM, Tom Rini wrote: > On Thu, Aug 15, 2024 at 09:32:29PM +0100, Simon Glass wrote: > > Hi Sughosh, > > > > On Wed, 14 Aug 2024 at 05:02, Sughosh Ganu > wrote: > > > > > > Instead of a randomly selected address, use an LMB allocated one for > > > reading the file into

Re: [PATCH v2 27/32] test: cedit: use allocated address for reading file

2024-08-16 Thread Tom Rini
On Fri, Aug 16, 2024 at 11:58:46PM +0530, Sughosh Ganu wrote: > On Fri, 16 Aug 2024 at 11:36 PM, Tom Rini wrote: > > > On Thu, Aug 15, 2024 at 09:32:29PM +0100, Simon Glass wrote: > > > Hi Sughosh, > > > > > > On Wed, 14 Aug 2024 at 05:02, Sughosh Ganu > > wrote: > > > > > > > > Instead of a ran

Re: [PATCH v8 00/23] Introduce the lwIP network stack

2024-08-16 Thread Tom Rini
On Fri, Aug 16, 2024 at 06:21:24PM +0200, Jerome Forissier wrote: > > > On 8/7/24 22:44, Tom Rini wrote: > > On Wed, Aug 07, 2024 at 07:11:44PM +0200, Jerome Forissier wrote: > > > >> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip > >> library for the network stack" [1].

Re: [PATCH] Kconfig: clean up the efi configuration status

2024-08-16 Thread Ilias Apalodimas
Hi Simon On mobile apologies for any weird formatting in advance. On Fri, Aug 16, 2024, 04:34 Simon Glass wrote: > Hi Ilias, > > On Thu, 15 Aug 2024 at 15:11, Ilias Apalodimas > wrote: > > > > > > > > On Thu, Aug 15, 2024, 23:33 Simon Glass wrote: > >> > >> Hi Ilias, > >> > >> On Wed, 14 Aug

Re: [PATCH v2 19/32] sandbox: move the TCG event log to the start of ram memory

2024-08-16 Thread Tom Rini
On Wed, Aug 14, 2024 at 04:29:56PM +0530, Sughosh Ganu wrote: > The TCG event log buffer is being set at the end of ram memory. This > region of memory is to be reserved as LMB_NOMAP memory in the LMB > memory map. The current location of this buffer overlaps with the > memory region reserved for

[PATCH 2/2] arm: dts: rockchip: add support for Radxa ROCK 5A with SPI NOR flash module

2024-08-16 Thread FUKAUMI Naoki
on Radxa ROCK 5A, sdhci(eMMC) and fspim0(SPI NOR flash) share pins (i.e. eMMC and SPI NOR flash are exclusive), new defconfig and dts specifically for SPI NOR flash is required. Signed-off-by: FUKAUMI Naoki --- arch/arm/dts/rk3588s-rock-5a-spi-u-boot.dtsi | 24 ++ arch/arm/dts/rk3588s-rock-5

[PATCH 1/2] arm64: dts: rockchip: add (but disabled) SFC node for Radxa ROCK 5A

2024-08-16 Thread FUKAUMI Naoki
This commit adds SFC node for Radxa ROCK 5A. since sdhci and sfc on RK3588s share pins(i.e. exclusive), it cannot be enabled both nodes at the same time. so status = "okay" is omitted here. you may be able to enable sfc (and disable sdhci) by fdt overlay. SPI NOR flash chip may vary, so use safe

[PATCH v6 00/28] Integrate MbedTLS v3.6 LTS with U-Boot

2024-08-16 Thread Raymond Mao
Integrate MbedTLS v3.6 LTS (currently v3.6.0) with U-Boot. Motivations: 1. MbedTLS is well maintained with LTS versions. 2. LWIP is integrated with MbedTLS and easily to enable HTTPS. 3. MbedTLS recently switched license back to GPLv2. Prerequisite: - This patch series

[PATCH v6 02/28] mbedtls: add mbedtls into the build system

2024-08-16 Thread Raymond Mao
Port mbedtls with adapted libc header files. Add mbedtls default config header file. Optimize mbedtls default config by disabling unused features to reduce the target size. Add mbedtls kbuild makefile. Add Kconfig skeleton and config submenu entry for selecting crypto libraries between mbedtls and

[PATCH v6 03/28] lib: Adapt digest header files to MbedTLS

2024-08-16 Thread Raymond Mao
Adapt digest header files to support both original libs and MbedTLS by switching on/off MBEDTLS_LIB_CRYPTO. Introduce _LEGACY kconfig for legacy hash implementations. `IS_ENABLED` or `CONFIG_IS_ENABLED` is not applicable here, since including causes undefined reference on schedule() with sandbox

[PATCH v6 04/28] md5: Remove md5 non-watchdog API

2024-08-16 Thread Raymond Mao
We don't need an API specially for non-watchdog since md5_wd supports it by disabling CONFIG_HW_WATCHDOG and CONFIG_WATCHDOG. Set 0x1 as default chunk size for MD5. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas Reviewed-by: Michal Simek --- Changes in v3 - Initial patch. Changes

[PATCH v6 05/28] sha1: Remove sha1 non-watchdog API

2024-08-16 Thread Raymond Mao
We don't need an API specially for non-watchdog since sha1_csum_wd supports it by disabling CONFIG_HW_WATCHDOG and CONFIG_WATCHDOG. Set 0x1 as default chunk size for SHA1. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v4 - Initial patch. Changes in v5 - None. Change

[PATCH v6 06/28] mbedtls: add digest shim layer for MbedTLS

2024-08-16 Thread Raymond Mao
Implement digest shim layer on top of MbedTLS crypto library. Introduce _MBEDTLS kconfig for MbedTLS crypto implementations. Signed-off-by: Raymond Mao --- Changes in v2 - Split the shim layer into separated files and use the original head files instead of creating new ones. Changes in v3 - Ref

[PATCH v6 07/28] hash: integrate hash on mbedtls

2024-08-16 Thread Raymond Mao
Integrate common/hash.c on the hash shim layer so that hash APIs from mbedtls can be leveraged by boot/image and efi_loader. Signed-off-by: Raymond Mao --- Changes in v2 - Use the original head files instead of creating new ones. Changes in v3 - Add handle checkers for malloc. Changes in v4 - Non

[PATCH v6 09/28] mbedtls/external: support Microsoft Authentication Code

2024-08-16 Thread Raymond Mao
Populate Microsoft Authentication Code from the content data into PKCS7 decoding context if it exists in a PKCS7 message. Add OIDs for describing objects using for Microsoft Authentication Code. The PR for this patch is at: https://github.com/Mbed-TLS/mbedtls/pull/9001 For enabling EFI loader PKC

[PATCH v6 11/28] mbedtls/external: support decoding multiple signer's cert

2024-08-16 Thread Raymond Mao
Support decoding multiple signer's cert in the signed data within a PKCS7 message. The PR for this patch is at: https://github.com/Mbed-TLS/mbedtls/pull/9001 For enabling EFI loader PKCS7 features with MbedTLS build, we need this patch on top of MbedTLS v3.6.0 before it is merged into the next Mb

[PATCH v6 14/28] x509: move common functions to x509 helper

2024-08-16 Thread Raymond Mao
Move x509_check_for_self_signed as a common helper function that can be shared by legacy crypto lib and MbedTLS implementation. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v4 - Initial patch. Changes in v5 - Removed authorship. Changes in v6 - None. lib/crypto/Makef

[PATCH v6 20/28] mbedtls: add PKCS7 parser porting layer

2024-08-16 Thread Raymond Mao
Add porting layer for PKCS7 parser on top of MbedTLS PKCS7 library. Introduce _LEGACY and _MBEDTLS kconfigs for PKCS7 parser legacy and MbedTLS implementations respectively. Signed-off-by: Raymond Mao --- Changes in v2 - Move the porting layer to MbedTLS dir. - Fix EFI Capsule CI test failures. C

[PATCH v6 21/28] lib/crypto: Adapt PKCS7 parser to MbedTLS

2024-08-16 Thread Raymond Mao
Previous patch has introduced MbedTLS porting layer for PKCS7 parser, here to adjust the header and makefiles accordingly. Signed-off-by: Raymond Mao --- Changes in v2 - Move the porting layer to MbedTLS dir. Changes in v3 - Update commit message. Changes in v4 - Control building legacy library v

[PATCH v6 23/28] lib/crypto: Adapt mscode_parser to MbedTLS

2024-08-16 Thread Raymond Mao
Previous patch has introduced MbedTLS porting layer for mscode parser, here to adjust the header and makefiles accordingly. Adding _LEGACY Kconfig for legacy mscode implementation. Signed-off-by: Raymond Mao --- Changes in v2 - Move the porting layer to MbedTLS dir. Changes in v3 - Update commit

[PATCH v6 24/28] mbedtls: add RSA helper layer on MbedTLS

2024-08-16 Thread Raymond Mao
Add RSA helper layer on top on MbedTLS PK and RSA library. Introduce _LEGACY and _MBEDTLS kconfigs for RSA helper legacy and MbedTLS implementations respectively. Signed-off-by: Raymond Mao --- Changes in v2 - Initial patch. Changes in v3 - None. Changes in v4 - Introduce _LEGACY and _MBEDTLS kco

[PATCH v6 26/28] asn1_decoder: add build options for ASN1 decoder

2024-08-16 Thread Raymond Mao
When building with MbedTLS, we are using MbedTLS to decode ASN1 data for x509, pkcs7 and mscode. Introduce _LEGACY and _MBEDTLS kconfigs for ASN1 decoder legacy and MbedTLS implementations respectively. Signed-off-by: Raymond Mao --- Changes in v2 - Initial patch. Changes in v3 - None. Changes in

[PATCH v6 27/28] test: Remove ASN1 library test

2024-08-16 Thread Raymond Mao
With MBEDTLS_LIB_X509 enabled, we don't build the original ASN1 lib, So remove it from test. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v2 - Initial patch. Changes in v3 - None. Changes in v4 - None. Changes in v5 - None. Changes in v6 - None. test/Kconfig | 2 +-

Re: [PATCH 3/9] sunxi: H616: dram: LPDDR4: adjust settings

2024-08-16 Thread Mikhail Kalashnikov
On 16.08.2024 4:03 AM, Chris Morgan wrote: On Wed, Aug 14, 2024 at 04:06:23PM -0500, Chris Morgan wrote: On Sat, Aug 03, 2024 at 03:29:17PM +0300, Mikhail Kalashnikov wrote: On 02.08.2024 01:55, Chris Morgan wrote: From: Jernej Skrabec Adjust H616 LPDDR4 DRAM settings to be in line with vend

[PATCH v6 01/28] CI: Exclude MbedTLS subtree for CONFIG checks

2024-08-16 Thread Raymond Mao
Since MbedTLS is an external repo with its own coding style, exclude it from Azure and gitlab CI CONFIG checks. Signed-off-by: Raymond Mao Reviewed-by: Tom Rini Reviewed-by: Ilias Apalodimas --- Changes in v2 - Initial patch. Changes in v3 - None. Changes in v4 - None. Changes in v5 - None. Cha

[PATCH v6 08/28] mbedtls: Enable smaller implementation for SHA256/512

2024-08-16 Thread Raymond Mao
Smaller implementation for SHA256 and SHA512 helps to reduce the ROM footprint though it has a certain impact on performance. As a trade-off, enable it as a default config when MbedTLS is enabled can reduce the target size significantly with acceptable performace loss. Signed-off-by: Raymond Mao

[PATCH v6 10/28] mbedtls/external: support PKCS9 Authenticate Attributes

2024-08-16 Thread Raymond Mao
Populate PKCS9 Authenticate Attributes from signer info if it exists in a PKCS7 message. Add OIDs for describing objects using for Authenticate Attributes. The PR for this patch is at: https://github.com/Mbed-TLS/mbedtls/pull/9001 For enabling EFI loader PKCS7 features with MbedTLS build, we need

[PATCH v6 12/28] mbedtls/external: update MbedTLS PKCS7 test suites

2024-08-16 Thread Raymond Mao
Update the PKCS7 test suites for multiple certs. The PR for this patch is at: https://github.com/Mbed-TLS/mbedtls/pull/9001 For enabling EFI loader PKCS7 features with MbedTLS build, we need this patch on top of MbedTLS v3.6.0 before it is merged into the next MbedTLS LTS release. Signed-off-by:

[PATCH v6 13/28] public_key: move common functions to public key helper

2024-08-16 Thread Raymond Mao
Move public_key_free and public_key_signature_free as helper functions that can be shared by legacy crypto lib and MbedTLS implementation. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v4 - Initial patch. Changes in v5 - Removed authorship. Changes in v6 - None. lib/c

[PATCH v6 15/28] pkcs7: move common functions to PKCS7 helper

2024-08-16 Thread Raymond Mao
Move pkcs7_get_content_data as a helper function that can be shared by legacy crypto lib and MbedTLS implementation. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v4 - Initial patch. Changes in v5 - Remove authorship. Changes in v6 - None. lib/crypto/Makefile |

[PATCH v6 16/28] mbedtls: add public key porting layer

2024-08-16 Thread Raymond Mao
Add porting layer for public key on top of MbedTLS X509 library. Introduce _LEGACY and _MBEDTLS kconfigs for public key legacy and MbedTLS implementations respectively. Signed-off-by: Raymond Mao --- Changes in v2 - Move the porting layer to MbedTLS dir. Changes in v3 - None. Changes in v4 - Intr

[PATCH v6 17/28] lib/crypto: Adapt public_key header with MbedTLS

2024-08-16 Thread Raymond Mao
Previous patch has introduced MbedTLS porting layer for public key, here to adjust the header and makefiles accordingly. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v2 - Move the porting layer to MbedTLS dir. Changes in v3 - Update commit message. Changes in v4 - Cont

[PATCH v6 18/28] mbedtls: add X509 cert parser porting layer

2024-08-16 Thread Raymond Mao
Add porting layer for X509 cert parser on top of MbedTLS X509 library. Introduce _LEGACY and _MBEDTLS kconfigs for X509 cert parser legacy and MbedTLS implementations respectively. Signed-off-by: Raymond Mao --- Changes in v2 - Move the porting layer to MbedTLS dir. Changes in v3 - None. Changes

[PATCH v6 19/28] lib/crypto: Adapt x509_cert_parser to MbedTLS

2024-08-16 Thread Raymond Mao
Previous patch has introduced MbedTLS porting layer for x509 cert parser, here to adjust the header and makefiles accordingly. Signed-off-by: Raymond Mao --- Changes in v2 - Move the porting layer to MbedTLS dir. Changes in v3 - Update commit message. Changes in v4 - Control building legacy libra

[PATCH v6 22/28] mbedtls: add MSCode parser porting layer

2024-08-16 Thread Raymond Mao
Add porting layer for MSCode on top of MbedTLS ASN1 library. Introduce _MBEDTLS kconfigs for MSCode MbedTLS implementation. Signed-off-by: Raymond Mao --- Changes in v2 - Move the porting layer to MbedTLS dir. Changes in v3 - None. Changes in v4 - Introduce _LEGACY and _MBEDTLS kconfigs for MSCod

[PATCH v6 25/28] lib/rypto: Adapt rsa_helper to MbedTLS

2024-08-16 Thread Raymond Mao
Previous patch has introduced MbedTLS porting layer for RSA helper, here to adjust the makefile accordingly. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v2 - Initial patch. Changes in v3 - Update commit message. Changes in v4 - Control building legacy library via '_LE

[PATCH v6 28/28] configs: enable MbedTLS as default setting

2024-08-16 Thread Raymond Mao
Enable MbedTLS as default setting for qemu arm64 and sandbox. Signed-off-by: Raymond Mao --- Changes in v2 - None. Changes in v3 - None. Changes in v4 - None. Changes in v5 - Remove unused config MBEDTLS_LIB_TLS. - Remove EFI_SECURE_BOOT from the default config. Changes in v6 - Remove MBEDTLS_LIB

Re: [PATCH v3 2/3] buildman: Allow skipping the dtc build

2024-08-16 Thread Simon Glass
Hi Tom, On Fri, 16 Aug 2024 at 11:22, Tom Rini wrote: > > On Thu, Aug 15, 2024 at 01:57:45PM -0600, Simon Glass wrote: > > > For most boards, the device-tree compiler is built in-tree, ignoring the > > system version. Add a special option to skip this build. This can be > > useful when the system

Re: [PATCH v2 27/32] test: cedit: use allocated address for reading file

2024-08-16 Thread Simon Glass
Hi Sughosh, On Fri, 16 Aug 2024 at 11:53, Sughosh Ganu wrote: > > On Fri, 16 Aug 2024 at 22:39, Sughosh Ganu wrote: > > > > On Fri, 16 Aug 2024 at 20:17, Simon Glass wrote: > > > > > > Hi Sughosh, > > > > > > On Fri, 16 Aug 2024 at 04:34, Sughosh Ganu > > > wrote: > > > > > > > > On Fri, 16 A

Re: [PATCH v2 37/39] efi: Avoid using sandbox virtio devices

2024-08-16 Thread Simon Glass
Hi Tom, On Thu, 15 Aug 2024 at 14:33, Simon Glass wrote: > > Hi Tom, > > On Wed, 14 Aug 2024 at 11:56, Tom Rini wrote: > > > > On Sun, Aug 11, 2024 at 08:50:21AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 8 Aug 2024 at 14:06, Tom Rini wrote: > > > > > > > > On Thu, Aug 08, 2024