[PATCH 00/14] spl: mmc: Some tweaks for SPL, particularly with MMC

2024-07-20 Thread Simon Glass
This series includes various minor fixes and tweaks found when trying to reduce the size of MMC code in SPL. Simon Glass (14): rockchip: Move the default timer init to a common file spl: Correct use of CMD_BOOTI and CMD_BOOTZ spl: Remove some #ifdefs in spl_parse_image_header() spl: Remov

[PATCH 11/14] spl: mmc: Try to clean up raw-mode options

2024-07-20 Thread Simon Glass
Make the raw-mode options depend on SPL_SYS_MMCSD_RAW_MODE in a more direct way. This makes it easier to understand the options with 'make menuconfig'. There are three different ways of specifying the offset: - sector offset - partition number - partition type So make these a choice, so it is mo

Re: [PATCH 13/14] spl: Create a function to init spl_load_info

2024-07-20 Thread Michael Nazzareno Trimarchi
Hi On Sat, Jul 20, 2024 at 8:20 AM Simon Glass wrote: > > Rather than having every caller set this up individually, create a > common init function. This allows new fields to be added without the > risk of them being left uninited. > > Signed-off-by: Simon Glass > --- > > arch/arm/mach-imx/spl_

[PATCH 00/20] binman: Enhance FIT support for firmware

2024-07-20 Thread Simon Glass
So far Binman's FIT support is designed for booting the OS. But FIT is also used to hold firmware images. One missing feature is the ability to produce the smaller FDTs used by SPL builds. This series adds this, running fdtgrep on each devicetree to create the correct one for each model, for a pa

[PATCH 01/20] fixdep: Support VPL

2024-07-20 Thread Simon Glass
Add VPL support in this tool. Signed-off-by: Simon Glass Fixes: f86ca5ad8f7 ("Introduce Verifying Program Loader (VPL)") --- scripts/basic/fixdep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index 5ced0f6b069..3d40bd7ee25 100644 --- a/s

[PATCH 02/20] binman: Correct an error in the FIT-template example

2024-07-20 Thread Simon Glass
The example contains references to an non-existent node. Fix it. Signed-off-by: Simon Glass --- tools/binman/binman.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/binman/binman.rst b/tools/binman/binman.rst index 872e9746c8c..0cafc36bdcb 100644 --- a/tools/bin

[PATCH 04/20] binman: Tidy up comment for Bintoolfdt_add_pubkey.run()

2024-07-20 Thread Simon Glass
This function returns a value, so add documentation for it. Signed-off-by: Simon Glass --- tools/binman/btool/fdt_add_pubkey.py | 4 1 file changed, 4 insertions(+) diff --git a/tools/binman/btool/fdt_add_pubkey.py b/tools/binman/btool/fdt_add_pubkey.py index a50774200c9..75a9716ad72 100

[PATCH 03/20] binman: Tidy up bintool docs

2024-07-20 Thread Simon Glass
The docs have somehow got out of sync. Regenerate the file to fix the problem. Signed-off-by: Simon Glass --- tools/binman/bintools.rst | 61 --- 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/tools/binman/bintools.rst b/tools/binman/bintools

[PATCH 05/20] binman: Move problem-checking code into a function

2024-07-20 Thread Simon Glass
This has become quite long, so move it into a separate function. Signed-off-by: Simon Glass --- tools/binman/control.py | 78 - 1 file changed, 46 insertions(+), 32 deletions(-) diff --git a/tools/binman/control.py b/tools/binman/control.py index 2f00279

[PATCH 06/20] binman: elf: Add more debugging to LookupAndWriteSymbols()

2024-07-20 Thread Simon Glass
When symbol-writing does not appear to work, it can sometimes be hard to figure out what is going on. Add some more debugging to help. Signed-off-by: Simon Glass --- tools/binman/elf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/elf.py b/tools/binman/elf.py

[PATCH 07/20] binman: Write the compressed output to a file

2024-07-20 Thread Simon Glass
When an entry is compressed, write the compressed contents to a file so that it is possible to see what was produced. This aids debugging with new images. Signed-off-by: Simon Glass --- tools/binman/entry.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/binman/entry.py b/tools/bi

[PATCH 08/20] binman: Correct comment in blob_dtb GetFdtEtype()

2024-07-20 Thread Simon Glass
The filenames are a bit confused. Fix them. Signed-off-by: Simon Glass --- tools/binman/etype/blob_dtb.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/binman/etype/blob_dtb.py b/tools/binman/etype/blob_dtb.py index d543de9f759..1471ded2211 100644 --- a/tools/binm

[PATCH 09/20] binman: Mention expanded entries in u-boot-vpl

2024-07-20 Thread Simon Glass
Add a comment about this entry type being expanded, to match the comment for SPL and TPL. Drop an unwanted line in the SPL and TPL docs while here. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 11 +-- tools/binman/etype/u_boot_spl_nodtb.py | 2 -- tools/binma

[PATCH 10/20] binman: Fix a comment typo in _DoReadFileDtb()

2024-07-20 Thread Simon Glass
Fix a minor typo in this function. Signed-off-by: Simon Glass --- tools/binman/ftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py index e4da04030a5..bb691cb3ff2 100644 --- a/tools/binman/ftest.py +++ b/tools/binman/ftest.py

[PATCH 12/20] binman: Add a bintool for fdtgrep

2024-07-20 Thread Simon Glass
Binman needs the ability to run fdtgrep to prepare devicetree subsets for use by SPL and TPL. Add a new bintool in preparation for this. Signed-off-by: Simon Glass --- tools/binman/bintools.rst | 8 ++ tools/binman/btool/fdtgrep.py | 137 ++ 2 files changed

[PATCH 13/20] binman: Remove dependency on pylibfdt for entry-docs

2024-07-20 Thread Simon Glass
Allow the entry-docs command to operate even if pylibfdt is not present in the systemn. Signed-off-by: Simon Glass --- tools/binman/image.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/binman/image.py b/tools/binman/image.py index e77b5d0d97c..97443d3c0a7 100644 --- a/tools

[PATCH 11/20] binman: Correct indentation in testSplPubkeyDtb

2024-07-20 Thread Simon Glass
This function has strange indentation. Fix it. Fixes: 8c1fbd1f607 ("binman: ftest: Add test for u_boot_spl_pubkey_dtb") Signed-off-by: Simon Glass --- tools/binman/ftest.py | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/tools/binma

[PATCH 14/20] binman: Allow entry types to override FDT contents

2024-07-20 Thread Simon Glass
At present the contents of an FDT (for each phase) are fixed, determined by the build and provided to Binman as input files. Provide a means for entry types to provide their own FDT, so that it can be processed, if needed. Signed-off-by: Simon Glass --- tools/binman/entry.py | 12

[PATCH 15/20] binman: Add support for alternative FDTs

2024-07-20 Thread Simon Glass
FIT provides a way to select between different devicetree blobs depending on the model. This works fine for U-Boot proper and allows SPL to select the correct blob for the current board at runtime. The boot sequence (SPL->U-Boot proper) is therefore covered by the existing feature set. The first b

[PATCH 16/20] binman: fit: Allow providing FDT filenames in a directory

2024-07-20 Thread Simon Glass
In some cases the list of available FDT files is not available in an entryarg. Provide an option to point to a directory containing them instead. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 7 tools/binman/etype/fit.py | 19 - tools/binman/ft

[PATCH 17/20] binman: fit: Write the compatible string to configuration

2024-07-20 Thread Simon Glass
FIT allows the FDT's root-node compatible string to be placed in a configuration node to simplify and speed up finding the best match for booting. Add a new property to support this. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 5 ++ tools/binman/etype/fit.py

[PATCH 18/20] binman: fit: Allow running fdtgrep on devicetree blobs

2024-07-20 Thread Simon Glass
When using FIT to load firmware builds for multiple models, the FIT must include a common binary along with a number of devicetree blobs, one for each model. This is the same mechanism as is used for loading an OS. However, SPL builds do not normally use the full devicetree, but instead a cut-down

[PATCH 19/20] Makefile: Provide VPL devicetree and padding to binman

2024-07-20 Thread Simon Glass
Provide these parameters to binman so that it can produce images targeted at VPL. Signed-off-by: Simon Glass --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index f5b2512f369..d8e2e6a1b4b 100644 --- a/Makefile +++ b/Makefile @@ -1388,8 +1388,10 @@ cmd_binm

[PATCH 20/20] Makefile: Pass OF_SPL_REMOVE_PROPS to binman

2024-07-20 Thread Simon Glass
Pass CONFIG_OF_SPL_REMOVE_PROPS to binman so that it can remove properties correctly when producing FITs for SPL phases. Signed-off-by: Simon Glass --- Makefile | 1 + tools/binman/etype/fit.py | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Ma

Re: [PATCH 1/1] doc: define html_context in conf.py

2024-07-20 Thread Simon Glass
On Fri, 19 Jul 2024 at 22:23, Heinrich Schuchardt wrote: > > The dictionary html_context is not passed into conf.py but must be created > there. See > https://dev.readthedocs.io/en/latest/design/theme-context.html#customizing-the-context > > Fixes: df86796028df ("doc: enable ReadTheDocs addon mana

Re: [PATCH v6 06/24] soc: qcom: cmd-db: adjust probe for U-Boot

2024-07-20 Thread Simon Glass
Hi Caleb, On Fri, 19 Jul 2024 at 20:45, Caleb Connolly wrote: > > > > On 19/07/2024 17:04, Simon Glass wrote: > > Hi Caleb, > > > > On Tue, 16 Jul 2024 at 08:16, Caleb Connolly > > wrote: > >> > >> > >> > >> On 16/07/2024 09:04, Simon Glass wrote: > >>> Hi Caleb, > >>> > >>> On Mon, 15 Jul 2024

Re: [PATCH v4 08/29] hash: integrate hash on mbedtls

2024-07-20 Thread Simon Glass
Hi Tom, On Fri, 19 Jul 2024 at 16:25, Tom Rini wrote: > > On Fri, Jul 19, 2024 at 04:05:09PM +0100, Simon Glass wrote: > > Hi Raymond, > > > > On Thu, 18 Jul 2024 at 17:46, Raymond Mao wrote: > > > > > > Hi Simon, > > > > > > On Fri, 5 Jul 2024 at 04:36, Simon Glass wrote: > > >> > > >> Hi, > >

Re: [PATCH v2] board: keymile: convert to CONFIG_DM_I2C

2024-07-20 Thread Simon Glass
On Sat, 20 Jul 2024 at 00:24, Anatolij Gustschin wrote: > > The conversion to DM_I2C is mandatory, rework to remove > use of legacy I2C API. > > Signed-off-by: Anatolij Gustschin > Cc: Aleksandar Gerasimovski > Cc: Holger Brunck > Cc: Tomas Alvarez Vanoli > --- > > Changes in v2: > - convert

Re: [PATCH] board: beagle: convert to CONFIG_DM_I2C

2024-07-20 Thread Simon Glass
Hi Anatolij, On Fri, 19 Jul 2024 at 22:51, Anatolij Gustschin wrote: > > Rework to remove use of legacy I2C API. > > Signed-off-by: Anatolij Gustschin > Cc: Tom Rini > --- > board/beagle/beagle/beagle.c | 41 +- > configs/omap3_beagle_defconfig | 2 +- > incl

Re: [PATCH v6 1/3] led: enable LEDST_BLINK state unconditionally

2024-07-20 Thread Simon Glass
On Fri, 19 Jul 2024 at 10:12, Mikhail Kshevetskiy wrote: > > Changes: > * enable LEDST_BLINK state unconditionally > * function led_set_period() becomes available when CONFIG_LED_BLINK >is disabled. This makes led code simpler. > * fix cmd/led.c to work properly when LEDST_BLINK present, bu

Re: [PATCH v6 2/3] led: Implement software led blinking

2024-07-20 Thread Simon Glass
On Fri, 19 Jul 2024 at 10:12, Mikhail Kshevetskiy wrote: > > From: Michael Polyntsov > > If hardware (or driver) doesn't support leds blinking, it's > now possible to use software implementation of blinking instead. > This relies on cyclic functions. > > Signed-off-by: Michael Polyntsov > Signed

Re: [PATCH v6 3/3] led: Add dts property to specify blinking of the led

2024-07-20 Thread Simon Glass
On Fri, 19 Jul 2024 at 10:12, Mikhail Kshevetskiy wrote: > > From: Michael Polyntsov > > The standard property > > linux,default-trigger = "pattern"; > > used to get an effect. No blinking parameters can be set yet. > > Signed-off-by: Michael Polyntsov > Signed-off-by: Mikhail Kshevetskiy >

Re: [PATCH 1/1] test/py/requirements.txt: Bump setuptools to 70.3.0

2024-07-20 Thread Simon Glass
On Wed, 17 Jul 2024 at 18:41, Tom Rini wrote: > > There is some potential security issue resolved by upgrading to v70.0.0 > here and the latest is now v70.3.0. > > Reported-by: GitHub dependabot > Suggested-by: Sebastian Kropatsch > Signed-off-by: Tom Rini > --- > test/py/requirements.txt | 2 +

Re: [PATCH v2 20/21] sandbox: Add an SPL loader for UPL

2024-07-20 Thread Simon Glass
Hi Sean, On Thu, 18 Jul 2024 at 15:12, Sean Anderson wrote: > > On 7/13/24 03:00, Simon Glass wrote: > > Add support for loading a UPL image from SPL. This uses the simple FIT > > implementation, but also loads the full FIT just to permit more testing. > > > > Signed-off-by: Simon Glass > > ---

Re: [PATCH v2 10/21] upl: Add support for reading a upl handoff

2024-07-20 Thread Simon Glass
Hi Heinrich, On Thu, 18 Jul 2024 at 15:53, Heinrich Schuchardt wrote: > > On 13.07.24 09:00, Simon Glass wrote: > > Universal Payload provides a standard way of handing off control between > > two firmware phases. Add support for reading the handoff information into > > a structure. > > > > Signe

Re: [PATCH v2 15/21] spl: Plumb in the Universal Payload handoff

2024-07-20 Thread Simon Glass
Hi Sean, On Thu, 18 Jul 2024 at 14:54, Sean Anderson wrote: > > On 7/13/24 03:00, Simon Glass wrote: > > Specify the FIT and include information about each loaded image, as > > required by the UPL handoff. > > > > Write the UPL handoff into the bloblist before jumping to the next phase. > > > > C

[PATCH 01/40] drivers: ata: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/ata/ahci.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index ac869296d52..8058d5ff1c3 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -294,7

[PATCH 02/40] drivers: bios_emulator: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/bios_emulator/besys.c| 1 - drivers/bios_emulator/include/x86emu/debug.h | 1 - drivers/bios_emulator/x86emu/prim_ops.c | 2 -- 3 files changed, 4 deletions(-) diff --git a/drivers/bio

[PATCH 03/40] drivers: block: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/block/ide.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/ide.c b/drivers/block/ide.c index b16623d7a3a..cab5e1bc92b 100644 --- a/drivers/block/ide.c +++ b/drivers/block/ide.c @@ -790,7 +

[PATCH 04/40] drivers: cache: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/cache/cache-l2x0.c| 1 - drivers/cache/sandbox_cache.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/cache/cache-l2x0.c b/drivers/cache/cache-l2x0.c index c7bdd9d064a..8b29af42338 100644

[PATCH 05/40] drivers: clk: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/clk/clk-uclass.c | 1 - drivers/clk/clk_zynqmp.c | 1 - drivers/clk/imx/clk-imxrt1170.c | 3 --- drivers/clk/imx/clk-pll14xx.c | 1 - drivers/clk/qcom/clock-qcom.c | 1 - drivers

[PATCH 06/40] drivers: core: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/core/of_addr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/core/of_addr.c b/drivers/core/of_addr.c index c893447a1b1..6c7b4c97d67 100644 --- a/drivers/core/of_addr.c +++ b/drivers/core/of_add

[PATCH 07/40] drivers: crypto: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/crypto/fsl/desc.h | 1 - drivers/crypto/fsl/error.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/crypto/fsl/desc.h b/drivers/crypto/fsl/desc.h index 5705c4f9447..eb108a9628b 100644 --- a/dr

[PATCH 08/40] drivers: ddr: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/ddr/altera/sdram_arria10.c| 1 - drivers/ddr/altera/sequencer.c| 2 -- drivers/ddr/altera/sequencer.h| 1 - drivers/ddr/fsl/arm_ddr_gen3.c

[PATCH 09/40] drivers: dfu: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/dfu/dfu_mmc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c index cfa6334e439..8f7ecfa8fc7 100644 --- a/drivers/dfu/dfu_mmc.c +++ b/drivers/dfu/dfu_mmc.c @

[PATCH 10/40] drivers: dma: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/dma/fsl_dma.c| 1 - drivers/dma/ti/k3-udma.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/dma/fsl_dma.c b/drivers/dma/fsl_dma.c index 0cd9bcb5110..e5d242f4f8f 100644 --- a/drivers/dma/fs

[PATCH 11/40] drivers: firmware: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/firmware/ti_sci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index 8ce0f46e70c..e591333ba38 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers

[PATCH 12/40] drivers: fpga: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/fpga/ACEX1K.c | 1 - drivers/fpga/fpga.c | 1 - drivers/fpga/ivm_core.c | 1 - drivers/fpga/lattice.c | 1 - drivers/fpga/spartan2.c | 2 -- drivers/fpga/spartan3.c | 2 -- 6 files changed, 8 deletio

[PATCH 13/40] drivers: gpio: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/gpio/altera_pio.c | 1 - drivers/gpio/pca953x_gpio.c | 1 - drivers/gpio/sunxi_gpio.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/gpio/altera_pio.c b/drivers/gpio/altera_pio.c index 7ba

[PATCH 15/40] drivers: input: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/input/cros_ec_keyb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/cros_ec_keyb.c b/drivers/input/cros_ec_keyb.c index 0917ee20fed..dd1e1bc468e 100644 --- a/drivers/input/cros_ec_keyb.c +

[PATCH 14/40] drivers: i2c: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/i2c/exynos_hs_i2c.c | 1 - drivers/i2c/i2c-uniphier.c | 1 - drivers/i2c/imx_lpi2c.c | 1 - drivers/i2c/muxes/i2c-mux-gpio.c | 1 - drivers/i2c/mxc_i2c.c| 1 - drivers/i2c/rc

[PATCH 16/40] drivers: led: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/led/led_lp5562.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/led/led_lp5562.c b/drivers/led/led_lp5562.c index 0c5f9bc4300..a5776d3174f 100644 --- a/drivers/led/led_lp5562.c +++ b/drivers/l

[PATCH 17/40] drivers: misc: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/misc/cros_ec_i2c.c | 1 - drivers/misc/stm32_rcc.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/misc/cros_ec_i2c.c b/drivers/misc/cros_ec_i2c.c index 5516aa8b3ff..cbdc55054ba 100644 --- a/

[PATCH 18/40] drivers: mmc: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/mmc/aspeed_sdhci.c | 1 - drivers/mmc/davinci_mmc.c | 1 - drivers/mmc/dw_mmc.c| 2 -- drivers/mmc/fsl_esdhc.c | 1 - drivers/mmc/fsl_esdhc_spl.c | 1 - drivers/mmc/mmc-uclass.c| 1 - dri

[PATCH 19/40] drivers: mtd: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/mtd/jedec_flash.c | 3 --- drivers/mtd/mtdcore.c | 2 -- drivers/mtd/nand/raw/am335x_spl_bch.c | 2 -- drivers/mtd/nand/raw/arasan_nfc.c | 1 - drivers/mtd/nand/raw/fsl_i

[PATCH 20/40] drivers: net: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/net/bcm-sf2-eth-gmac.h | 1 - drivers/net/bnxt/bnxt.c | 1 - drivers/net/designware.h| 1 - drivers/net/e1000.c | 6 -- drivers/net/e1000.h

[PATCH 21/40] drivers: pci: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/pci/pci_auto_common.c | 1 - drivers/pci/pcie_dw_rockchip.c | 1 - drivers/pci/pcie_dw_ti.c| 1 - drivers/pci/pcie_layerscape_fixup.c | 1 - 4 files changed, 4 deletions(-) diff --gi

[PATCH 22/40] drivers: phy: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/phy/marvell/comphy_a3700.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/marvell/comphy_a3700.c b/drivers/phy/marvell/comphy_a3700.c index bca325d1996..2a1646cb2c0 100644 --- a/drivers/phy

[PATCH 23/40] drivers: pinctrl: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/pinctrl/exynos/pinctrl-exynos.h | 1 - drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 1 - drivers/pinctrl/pinctrl-sti.c | 1 - drivers/pinctrl/pinctrl_pic32.c | 1 - drivers/pi

[PATCH 24/40] drivers: power: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/power/regulator/lp873x_regulator.c | 1 - drivers/power/regulator/lp87565_regulator.c | 1 - drivers/power/twl6030.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/power/r

[PATCH 25/40] drivers: ram: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/ram/rockchip/dmc-rk3368.c | 3 --- drivers/ram/stm32_sdram.c | 2 -- drivers/ram/stm32mp1/stm32mp1_ddr.c | 1 - 3 files changed, 6 deletions(-) diff --git a/drivers/ram/rockchip/dmc-rk3368.c b

[PATCH 26/40] drivers: remoteproc: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/remoteproc/rproc-uclass.c| 1 - drivers/remoteproc/ti_k3_r5f_rproc.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/remoteproc/rproc-uclass.c b/drivers/remoteproc/rproc-uclass.c index 3ba

[PATCH 27/40] drivers: reset: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/reset/reset-ast2500.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/reset/reset-ast2500.c b/drivers/reset/reset-ast2500.c index 0ed5396b3e9..f3543fa8cc1 100644 --- a/drivers/reset/reset-ast25

[PATCH 28/40] drivers: rtc: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/rtc/ds1307.c | 5 - drivers/rtc/ds1337.c | 5 - drivers/rtc/ds3231.c | 6 -- drivers/rtc/mcfrtc.c | 1 - drivers/rtc/rv3029.c | 2 -- 5 files changed, 19 deletions(-) diff --git a/drivers/rtc/d

[PATCH 29/40] drivers: scsi: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/scsi/scsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 73cb83548eb..51cacf34792 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -345,7 +

[PATCH 30/40] drivers: serial: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/serial/serial_arc.c| 1 - drivers/serial/serial_linflexuart.c| 2 -- drivers/serial/serial_lpuart.c | 1 - drivers/serial/serial_nulldev.c| 1 - drivers/serial/serial_pl01x_i

[PATCH 31/40] drivers: soc: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/soc/ti/k3-navss-ringacc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soc/ti/k3-navss-ringacc.c b/drivers/soc/ti/k3-navss-ringacc.c index d3f3d4761c2..b2643a30d3d 100644 --- a/drivers/soc/ti

[PATCH 32/40] drivers: sound: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/sound/wm8994.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/sound/wm8994.c b/drivers/sound/wm8994.c index 6b3091aa5de..42947357836 100644 --- a/drivers/sound/wm8994.c +++ b/drivers/sound/wm8

[PATCH 33/40] drivers: spi: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/spi/atcspi200_spi.c | 1 - drivers/spi/ath79_spi.c | 1 - drivers/spi/davinci_spi.c| 1 - drivers/spi/mxc_spi.c| 1 - drivers/spi/spi-aspeed-smc.c | 1 - drivers/spi/zynq_spi.c | 1 -

[PATCH 34/40] drivers: sysreset: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/sysreset/sysreset-uclass.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/sysreset/sysreset-uclass.c b/drivers/sysreset/sysreset-uclass.c index 0abb4042e0f..d30b008bf9a 100644 --- a/drivers/sys

[PATCH 35/40] drivers: thermal: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/thermal/thermal-uclass.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/thermal/thermal-uclass.c b/drivers/thermal/thermal-uclass.c index f0fe912e313..c61e6c3ee0e 100644 --- a/drivers/thermal/th

[PATCH 36/40] drivers: timer: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/timer/arc_timer.c | 1 - drivers/timer/sp804_timer.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/timer/arc_timer.c b/drivers/timer/arc_timer.c index 413bcc32f01..6ad520c10aa 100644 --- a/

[PATCH 37/40] drivers: tpm: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/tpm/tpm2_tis_spi.c | 1 - drivers/tpm/tpm_tis_lpc.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/tpm/tpm2_tis_spi.c b/drivers/tpm/tpm2_tis_spi.c index b0fe97ab1d0..d35a4dd3a36 100644 --- a/

[PATCH 38/40] drivers: usb: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/usb/dwc3/dwc3-generic.c| 1 - drivers/usb/dwc3/gadget.c | 1 - drivers/usb/dwc3/samsung_usb_phy.c | 1 - drivers/usb/eth/asix.c | 1 - drivers/us

[PATCH 39/40] drivers: video: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/video/broadwell_igd.c | 1 - drivers/video/console_rotate.c| 1 - drivers/video/dw_hdmi.c | 1 - drivers/video/exynos/exynos_dp.c | 1 - drivers/video/

[PATCH 40/40] drivers: watchdog: Remove duplicate newlines

2024-07-20 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- drivers/watchdog/meson_gxbb_wdt.c| 1 - drivers/watchdog/sandbox_alarm-wdt.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c index 01a

[PATCH] nitrogen6x: convert to DM_I2C and DM_SERIAL

2024-07-20 Thread Anatolij Gustschin
Rework to remove use of legacy I2C API. Also switch to DM_SERIAL to avoid board removal warning. Signed-off-by: Anatolij Gustschin Cc: Troy Kisky --- board/boundary/nitrogen6x/nitrogen6x.c | 79 ++ configs/mx6qsabrelite_defconfig| 7 +-- configs/nitrogen6dl2g_de

usb gadget driver initialization issue

2024-07-20 Thread Zixun Li
Hi, In udc_bind_to_driver(), USB device controller is initialized by usb_gadget_udc_start() and entered connected state by usb_gadget_connect(). From the host's point of view, a device is ready to be enumerated. However, since dm_usb_gadget_handle_interrupts() is only called inside function dri

Re: [PATCH] board: beagle: convert to CONFIG_DM_I2C

2024-07-20 Thread Anatolij Gustschin
Hi Simon, On Sat, 20 Jul 2024 13:36:04 +0100 Simon Glass s...@chromium.org wrote: ... > > - /* return BEAGLE_NO_EEPROM if eeprom doesn't respond */ > > - if (i2c_probe(EXPANSION_EEPROM_I2C_ADDRESS) == 1) { > > - i2c_set_bus_num(TWL4030_I2C_BUS); > > + ret = i2c_get_

Re: [PATCH v2 15/21] spl: Plumb in the Universal Payload handoff

2024-07-20 Thread Sean Anderson
On 7/20/24 08:36, Simon Glass wrote: Hi Sean, On Thu, 18 Jul 2024 at 14:54, Sean Anderson wrote: On 7/13/24 03:00, Simon Glass wrote: Specify the FIT and include information about each loaded image, as required by the UPL handoff. Write the UPL handoff into the bloblist before jumping to th

Re: [PATCH 02/14] spl: Correct use of CMD_BOOTI and CMD_BOOTZ

2024-07-20 Thread Sean Anderson
On 7/20/24 02:16, Simon Glass wrote: These should have a CONFIG_ prefix. Add it. Signed-off-by: Simon Glass Fixes: 7a0d88076b9 ("Add in the ability to load and boot an uncompr...") --- common/spl/spl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/spl/spl.c

Re: [PATCH 03/14] spl: Remove some #ifdefs in spl_parse_image_header()

2024-07-20 Thread Sean Anderson
On 7/20/24 02:16, Simon Glass wrote: This function has a number of unnecessary #ifdefs so remove them. Signed-off-by: Simon Glass --- common/spl/spl.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 6f4a8

[PATCH] mx6boards: convert to DM_I2C and DM_SERIAL

2024-07-20 Thread Anatolij Gustschin
Rework to remove use of legacy I2C API. Also switch to DM_SERIAL to avoid board removal warning. Signed-off-by: Anatolij Gustschin Cc: Eric Bénard --- board/embest/mx6boards/mx6boards.c | 70 +++--- configs/marsboard_defconfig| 6 +-- configs/riotboard_defconfig

Re: [PATCH 04/14] spl: Remove remaining #ifdef in spl_parse_image_header()

2024-07-20 Thread Sean Anderson
On 7/20/24 02:16, Simon Glass wrote: Define spl_set_header_raw_uboot() always so we can drop the last #ifdef in this function. Signed-off-by: Simon Glass --- common/spl/spl.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/common/spl/spl.c b/common/spl/sp

Re: [PATCH 05/14] mmc: Use logging instead of printf()

2024-07-20 Thread Sean Anderson
On 7/20/24 02:16, Simon Glass wrote: The code makes quite a few uses of __func__ which puts the function name into the resulting SPL image. Use the log subsystem instead, to reduce size. The CONFIG_LOGF_FUNC option can be used to enable the function name. Signed-off-by: Simon Glass --- driv

Re: [PATCH 06/14] mmc: Use logging instead of pr_err()

2024-07-20 Thread Sean Anderson
On 7/20/24 02:16, Simon Glass wrote: Use the log subsystem instead of dev, to avoid including function names in the code. The CONFIG_LOGF_FUNC option can be used to enable the function name. Signed-off-by: Simon Glass --- drivers/mmc/mmc.c | 49 --

Re: [PATCH 07/14] log: Avoid including function names by default

2024-07-20 Thread Sean Anderson
On 7/20/24 02:16, Simon Glass wrote: Unless function names are requested, the logging system should not compile these into the code. Adjust the macros to handle this. Enable CONFIG_LOGF_FUNC logging for sandbox since the tests expect the function names to be included. Fix up the pinmux test whic

[PATCH] kontron-sl-mx6ul: switch to DM_SERIAL

2024-07-20 Thread Anatolij Gustschin
Enable DM_SERIAL to avoid board removal warning. Signed-off-by: Anatolij Gustschin Cc: Frieder Schrempf --- configs/kontron-sl-mx6ul_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/kontron-sl-mx6ul_defconfig b/configs/kontron-sl-mx6ul_defconfig index 12d96b674c..f295ecfe4

Re: [PATCH 08/14] spl: mmc: Drop checks for CONFIG_SPL_LIBCOMMON_SUPPORT

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: This check is not needed now, since printf() resolved to nothing if not available. Drop the #ifdefs Signed-off-by: Simon Glass --- common/spl/spl_mmc.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/common/spl/sp

Re: [PATCH 09/14] spl: mmc: Handle error codes consistently

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Use 'ret' as the return code, since it may not be an error and this is the common name in U-Boot. Make sure to return the error code when given, rather than transforming it into -1 (-EPERM). Does this transformation affect code size? Signed-off-by: Simon G

Re: [PATCH 10/14] spl: mmc: Adjust args of spl_mmc_find_device()

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: At present spl_mmc_load() is the only caller of this function, passing it a boot_device, an index into the available MMC devices. Pass the device number instead, since it is known by the caller and simplifies the code. Signed-off-by: Simon Glass --- commo

Re: [PATCH 12/14] spl: Use unified inline functions for spl_load_info

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Rather than declaring completely separate functions, put the code for each case into the same function. This makes it easier to read. Signed-off-by: Simon Glass --- include/spl.h | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-)

Re: [PATCH 13/14] spl: Create a function to init spl_load_info

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Rather than having every caller set this up individually, create a common init function. This allows new fields to be added without the risk of them being left uninited. What is the code size impact of this? IIRC the reason why I didn't do this is to avoid

Re: [PATCH 14/14] blk: Correct comment for blk_get_devnum_by_uclass_idname()

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Update the comment to match the function. Fix the indentation while we are here. Signed-off-by: Simon Glass --- include/blk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/blk.h b/include/blk.h index 7c7cf7f2b10..1fc9a5b

[PATCH] pxm2: switch to DM_I2C

2024-07-20 Thread Anatolij Gustschin
Enable DM_I2C to avoid board removal warning. Signed-off-by: Anatolij Gustschin Cc: Enrico Leto --- configs/pxm2_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/pxm2_defconfig b/configs/pxm2_defconfig index 366d8fc3ae..c2f869391d 100644 --- a/configs/pxm2

Re: [PATCH v3] bootstash: Do not provide a default address for all

2024-07-20 Thread Tom Rini
On Mon, 15 Jul 2024 12:42:00 +0100, Simon Glass wrote: > A valid memory location to stash bootstage information at will be > architecture dependent. Move the existing defaults to the main Kconfig > file for this option and set 0x0 as the default only for sandbox. > > Applied to u-boot/master, t

Re: [PATCH 1/1] drivers/mtd/nvmxip: nvmxip.h is a global include

2024-07-20 Thread Tom Rini
On Mon, 15 Jul 2024 15:19:50 +0200, Heinrich Schuchardt wrote: > include/nvmxip.h is a global and not a local include. > So we should use angle brackets. > > Applied to u-boot/master, thanks! -- Tom

Re: [RESEND PATCH] soc: ti: k3-socinfo: Add support for J721E SR2.0

2024-07-20 Thread Tom Rini
On Mon, 15 Jul 2024 16:45:50 +0530, Neha Malcom Francis wrote: > Add support for identifying J721E SR2.0 > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] configs: j784s4_evm : Increase Dynamic memory allocation size

2024-07-20 Thread Tom Rini
On Mon, 15 Jul 2024 23:13:01 +0530, Udit Kumar wrote: > Increase malloc size to 32 MB to align with other J7 > family devices. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] cmd: correct ELF-related commands dependencies

2024-07-20 Thread Tom Rini
On Mon, 15 Jul 2024 23:01:10 +0300, Maxim Moskalets wrote: > Enable BOOTM_ELF by default for all configs with LIB_ELF selected. > Use OF_LIBFDT as dependency for CMD_ELF_FDT_SETUP. > > Applied to u-boot/master, thanks! -- Tom

  1   2   >