Re: [PATCH] u_boot_pylib: Ensure subprocess is closed down

2023-11-02 Thread Simon Glass
It isn't clear why we need to have two different paths for closing down the pipe. Unify them and use the Python to avoid this warning: subprocess.py:1127: ResourceWarning: subprocess 83531 is still running Note that this code appears to originally have come from [1] and was committed into the C

Re: [PATCH v3 1/1] sandbox: eliminate unused functions from binaries

2023-11-02 Thread Simon Glass
On Tue, Oct 24, 2023 at 08:30:47AM +0200, Heinrich Schuchardt wrote: > The sandbox should closely mimic other architectures. > > Place each function or data in a separate section and let the linker > eliminate unused ones. This will reduce the binary size. > > In the linker script mark that u_boot

Re: [PATCH v4 1/2] binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts

2023-11-02 Thread Simon Glass
On Mon, 23 Oct 2023 at 01:01, Neha Malcom Francis wrote: > > According to the TRMs of K3 platform of devices, the ROM boot image > format specifies a "Core Options Field" that provides the capability to > set the boot core in lockstep when set to 0 or to split mode when set > to 2. Add support for

Re: [PATCH] buildman: Include symbols in the read-only data section

2023-11-02 Thread Simon Glass
On Mon, Oct 23, 2023 at 12:52:43AM -0700, Simon Glass wrote: > When symbols switch between the inited data section and the read-only > data section their visbility changes, at present, with the -B option. > > This is confusing, since adding 'const' to a variable declaration can > make it look like

Re: [PATCH v2] cros_ec: spi: disable annoying key echo on console

2023-11-02 Thread Simon Glass
on Peach-pi console every key press is echoed with message 'cros_ec_command: Returned status 1' this is not proper fix, just hack to disable this message Signed-off-by: Milan P. Stanić Reviewed-by: Simon Glass --- changed patch to use log_debug and added forgoten Signed-off-by and and Reviewed-

Re: [PATCH 6/6] binman: Move stage header into a CBFS attribute

2023-11-02 Thread Simon Glass
cbfsutil completely changed the way that stages are formatted in CBFS. Adjust the binman implementation to do the same. This mirrors commit 81dc20e744 in coreboot. Signed-off-by: Simon Glass --- tools/binman/cbfs_util.py | 64 +- tools/binman/cbfs_util_test

Re: [PATCH 5/6] binman: Rename TYPE_STAGE to TYPE_LEGACY_STAGE

2023-11-02 Thread Simon Glass
In preparation for changing how stages are stored, rename the existing stage tag. Signed-off-by: Simon Glass --- cmd/cbfs.c | 2 +- include/cbfs.h | 2 +- tools/binman/cbfs_util.py | 12 ++-- tools/binman/cbfs_util_test.py | 3 ++- 4 files cha

Re: [PATCH 4/6] binman: Replace FILENAME_ALIGN 16 with ATTRIBUTE_ALIGN 4

2023-11-02 Thread Simon Glass
cbfsutil changed to 4-byte alignment for filenames instead of 16. Adjust the binman implementation to do the same. This mirrors commit 5779ca718c in coreboot. Signed-off-by: Simon Glass --- tools/binman/cbfs_util.py | 10 +- tools/binman/cbfs_util_test.py | 19 ++-

Re: [PATCH 3/6] binman: Ensure attributes always come last in the metadata

2023-11-02 Thread Simon Glass
cbfsutil changed to write zero bytes instead of 0xff when a small padding must be added. Adjust the binman implementation to do the same. Drop the code which looks for an unused attribute tag, since it is not used. A future patch moves the attributes to the end of the header in any case, so no dat

Re: [PATCH 2/6] binman: Don't add compression attribute for uncompressed files

2023-11-02 Thread Simon Glass
Hi Simon On 15/10/23 02:10, Simon Glass wrote: > cbfsutil changed to skip adding a compression attribute if there is no > compression. Adjust the binman implementation to do the same. > > This mirrors commit 105cdf5625 in coreboot. > > Signed-off-by: Simon Glass > --- > > tools/binman/cbfs_util

Re: [PATCH 1/6] binman: Reset missing bintools after testing

2023-11-02 Thread Simon Glass
Hi Simon On 15/10/23 02:10, Simon Glass wrote: > For tests which fake bintools being missing, we need to reset the list > afterwards, to ensure that future tests do not also see the bintools as > missing. > > Reset the list when processing is complete. > > Signed-off-by: Simon Glass > --- > > t

Re: [PATCH v2] patman: Add a 'keep_change_id' setting

2023-11-02 Thread Simon Glass
On Thu, 12 Oct 2023 at 20:06, Maxim Cournoyer wrote: > > A Change-Id can be useful for traceability purposes, and some projects > may wish to have them preserved. This change makes it configurable > via a new 'keep_change_id' setting. > > Signed-off-by: Maxim Cournoyer > --- > > Changes in v2: >

Please pull u-boot-dm

2023-11-02 Thread Simon Glass
Hi Tom, Just various bugfixes, apart from the TI one https://source.denx.de/u-boot/custodians/u-boot-dm/-/commit/3227baad05481e37d75aeae7c7c1467fd6903f7d https://dev.azure.com/simon0972/u-boot/_build/results?buildId=54&view=results (not finished yet) The following changes since commit 07fe79c

Re: [PATCH] mmc: sdhci-cadence: Add support for Cadence sdmmc v6

2023-11-02 Thread Jaehoon Chung
Hi On 10/3/23 16:22, Kuan Lim Lee wrote: > From: Kuan Lim Lee > > Cadence SDMMC v6 controller has a lot of changes on initialize > compared to v4 controller. PHY is needed by v6 controller. > > Signed-off-by: Kuan Lim Lee > Reviewed-by: Alex Soo > Reviewed-by: Wei Liang Lim I didn't see the

[PATCH 3/3] doc: board: ti: k3 docs: Use ::prompt

2023-11-02 Thread Nishanth Menon
Use prompt instead of code-block to have copy-paste friendly command documentation. Signed-off-by: Nishanth Menon --- doc/board/ti/am62x_beagleplay.rst | 46 - doc/board/ti/am62x_sk.rst | 18 +++ doc/board/ti/am64x_evm.rst| 20 +++ doc/board/ti/am65x_evm.r

[PATCH 1/3] doc: board: ti: Use prompt prompt_style to simplify documentation

2023-11-02 Thread Nishanth Menon
The sphinx-prompt documentation[0] provides examples on how we can use prompt as a parameter to simplify the description. Use the same. [0] http://sbrunner.github.io/sphinx-prompt/ Signed-off-by: Nishanth Menon --- doc/board/ti/am335x_evm.rst | 39 + doc/boar

[PATCH 0/3] doc: board: ti: Cleanup ::prompt usage

2023-11-02 Thread Nishanth Menon
Due to the sequence of merges, it looks like many of k3 documentation used code-blocks while the rest of the docs migrated to ::prompt. Sync all to a common style. based off: master 07fe79c93c5c Merge tag 'i2cfixes-for-v2024-01-rc2' of https://source.denx.de/u-boot/custodians/u-boot-i2c Nishant

[PATCH 2/3] doc: board: ti: k3: Use ::prompt for gdb commands

2023-11-02 Thread Nishanth Menon
Provide more friendlier documentation with prompt (gdb) option Signed-off-by: Nishanth Menon --- doc/board/ti/k3.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/board/ti/k3.rst b/doc/board/ti/k3.rst index e9bbe7c09794..c20e33d00412 100644 --- a/doc/board/ti

Re: [PULL] u-boot-sh/master_common_h_cleanup

2023-11-02 Thread Tom Rini
On Thu, Nov 02, 2023 at 11:02:51PM +0100, Marek Vasut wrote: > The following changes since commit a803f87202aa48974bdff4d8100464a8288931e4: > > Merge https://source.denx.de/u-boot/custodians/u-boot-mmc (2023-11-01 > 09:44:33 -0400) > > are available in the Git repository at: > > https://so

Re: [PATCH v2] patman: Add a 'keep_change_id' setting

2023-11-02 Thread Maxim Cournoyer
Hi Simon, Simon Glass writes: > On Thu, 12 Oct 2023 at 20:06, Maxim Cournoyer > wrote: >> >> A Change-Id can be useful for traceability purposes, and some projects >> may wish to have them preserved. This change makes it configurable >> via a new 'keep_change_id' setting. >> >> Signed-off-by:

[PATCH 07/15] board: ti: j721e: evm: Use IS_ENABLED with CONFIG_PHYS_64BIT

2023-11-02 Thread Nishanth Menon
Use IS_ENABLED to replace the #ifdeffery. Signed-off-by: Nishanth Menon --- board/ti/j721e/evm.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c index d49993fffe39..0fc141776818 100644 --- a/board/ti/j721

[PATCH 10/15] configs: j721e_evm_a72_defconfig: Switch to bootstd

2023-11-02 Thread Nishanth Menon
Switch to using bootstd. Note with this change, we will stop using distro_bootcmd and instead depend entirely on bootflow method of starting the system up. Signed-off-by: Nishanth Menon --- configs/j721e_evm_a72_defconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/c

[PATCH 09/15] board: ti: j721e: j721e.env: Add explicit boot_targets

2023-11-02 Thread Nishanth Menon
Add explicit boot_targets to indicate the specific boot sequence to follow. Signed-off-by: Nishanth Menon --- board/ti/j721e/j721e.env | 1 + 1 file changed, 1 insertion(+) diff --git a/board/ti/j721e/j721e.env b/board/ti/j721e/j721e.env index 8cc8232fc131..cb27bf5e2b24 100644 --- a/board/ti/j7

[PATCH 14/15] board: ti: Add j721e_beagleboneai64_* config fragments and env file

2023-11-02 Thread Nishanth Menon
Add defconfig fragments for J721E based BeagleBone AI-64 and corresponding customized environment. Signed-off-by: Nishanth Menon --- board/ti/j721e/beagleboneai64.env| 19 board/ti/j721e/beagleboneai64_a72.config | 55 board/ti/j721e/beagleboneai64_r5.co

[PATCH 06/15] board: ti: j721e: evm: Drop board based serdes initialization

2023-11-02 Thread Nishanth Menon
Serdes initialization should be compile flag based instead of being eeprom based. Signed-off-by: Nishanth Menon --- board/ti/j721e/evm.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c index 17640ae79665..d49993fffe39 100

[PATCH 00/15] board: ti: Add support for BeagleBone AI-64

2023-11-02 Thread Nishanth Menon
Cleanups for J721e/J7200 and add support for BeagleBone AI-64 Based off: master 07fe79c93c5c Merge tag 'i2cfixes-for-v2024-01-rc2' of https://source.denx.de/u-boot/custodians/u-boot-i2c Boot Logs: J721e-SK: https://gist.github.com/nmenon/c144e64f1da9fd49997ef5794b056bb0 J721e-EVM: https://gist.g

[PATCH 02/15] configs: j7200: Remove HBMC_AM654 config

2023-11-02 Thread Nishanth Menon
Kernel commit 1b77265626a4 ("arm64: dts: ti: k3-j7200-mcu-wakeup: Add HyperBus node") was merged to kernel without its dependent patch [1]. Similar fix is needed in U-Boot, and hbmc currently breaks boot. Till this gets fixed in U-Boot, disable the config by default so that the hbmc probe that happ

[PATCH 15/15] doc: board: ti: Add BeagleBone AI-64 documentation

2023-11-02 Thread Nishanth Menon
Add base documentation for BeagleBone AI-64. Signed-off-by: Nishanth Menon --- doc/board/ti/j721e_beagleboneai64.rst | 327 ++ doc/board/ti/k3.rst | 1 + 2 files changed, 328 insertions(+) create mode 100644 doc/board/ti/j721e_beagleboneai64.rst diff

[PATCH 01/15] arm: mach-k3: j721e: Improve support for UDA FS

2023-11-02 Thread Nishanth Menon
Commit 5019170970ad ("arch: arm: mach-k3: j721e: add support for UDA FS") introduced basic UDA FS support, however, we can Take approach similar to commit 0f1c1e8b368b ("arm: mach-k3: am625: Add support for UDA FS"). While boot partition support with EMMC boot is useful, it is constrained by the si

[PATCH 03/15] board: ti: j721e: evm: Drop board check for ESM

2023-11-02 Thread Nishanth Menon
When config is enabled, the esm dt probe makes sense. Simplify by dropping board specific checks. Signed-off-by: Nishanth Menon --- board/ti/j721e/evm.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c index d4f7c1d9f938..

[PATCH 08/15] board: ti: j721e: evm: Split code to isolate eeprom detected logic

2023-11-02 Thread Nishanth Menon
Move code out of evm.c that is based on evm specific checks for board variants and initialization sequences there of. Signed-off-by: Nishanth Menon --- board/ti/j721e/Makefile| 1 + board/ti/j721e/{evm.c => board-variants.c} | 172 + board/ti/j721e/evm.c

[PATCH 11/15] arm: dts: k3-j721e-binman: Allow a single board configuration

2023-11-02 Thread Nishanth Menon
Allow the reuse of k3-j721e-binman for other platforms such as BeagleBone-AI64. We don't need to build SK device tree blobs in-order to be able to build dtbs for single configuration platforms. Signed-off-by: Nishanth Menon --- arch/arm/dts/k3-j721e-binman.dtsi | 21 +

[PATCH 05/15] board: ti: j721e: evm: Switch to using IS_ENABLED

2023-11-02 Thread Nishanth Menon
Switch to using IS_ENABLED() for inline function usage. Signed-off-by: Nishanth Menon --- board/ti/j721e/evm.c | 83 ++-- 1 file changed, 42 insertions(+), 41 deletions(-) diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c index 8f0996c32ee6..17640a

[PATCH 12/15] arm: dts: k3-j721e-binman: Use macros that can be overridden for dtbs

2023-11-02 Thread Nishanth Menon
Allow the reuse of k3-j721e-binman for other platforms such as BeagleBone-AI64. Provide a couple of macros to indicate the correct dtb to be able to re-use soc binman dtsi file Signed-off-by: Nishanth Menon --- arch/arm/dts/k3-j721e-binman.dtsi | 12 1 file changed, 12 insertions(+)

[PATCH 04/15] board: ti: j721e: evm: Drop unused headers

2023-11-02 Thread Nishanth Menon
Drop headers that are no longer necessary for build Signed-off-by: Nishanth Menon --- board/ti/j721e/evm.c | 8 1 file changed, 8 deletions(-) diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c index 75d51a0552c4..8f0996c32ee6 100644 --- a/board/ti/j721e/evm.c +++ b/board/ti/j721

[PATCH 1/1] [u-boot][master][PATCH v6] pico-imx7d: add baseboard SD card boot detect

2023-11-02 Thread egyszeregy
From: Benjamin Szőke Technexion PICO-IMX7 SoM is supporting USDHC3 (eMMC or micro SD on SoM) and USDHC1 (SD on carrier board) to use on any carrier board like PICO-NYMPH. Based on the U-Boot version from Technexion it adds baseboard SD card boot detect to able to boot from selected USDHC1 or USDH

[PATCH 13/15] arm: dts: Add k3-j721e-beagleboneai64

2023-11-02 Thread Nishanth Menon
From: Robert Nelson BeagleBoard.org BeagleBone AI-64 is an open source hardware single board computer based on the Texas Instruments TDA4VM SoC featuring dual-core 2.0GHz Arm Cortex-A72 processor, C7x+MMA and 2 C66x floating-point VLIW DSPs, 3x dual ARM Cortex-R5 co-processors, 2x 6-core Programm

RE: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-11-02 Thread Jaehoon Chung
Hi Mathtjjs, > -Original Message- > From: Mattijs Korpershoek > Sent: Thursday, November 2, 2023 6:15 PM > To: Jaehoon Chung > Cc: lu...@denx.de; u-boot@lists.denx.de > Subject: Re: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration > > Hi Jaehoon, > > On mar., oct. 31, 2023 at 15

Re: [PATCH 0/3] doc: board: ti: Cleanup ::prompt usage

2023-11-02 Thread Nishanth Menon
On 19:09-20231102, Nishanth Menon wrote: > Due to the sequence of merges, it looks like many of k3 documentation > used code-blocks while the rest of the docs migrated to ::prompt. > > Sync all to a common style. > > based off: > master 07fe79c93c5c Merge tag 'i2c

RE: uboot reports adding disk failed(EFI_NOT_FOUND) and first disk is gone in next scsi scan

2023-11-02 Thread Hongxing Zhu
Hi Simon: I found that the EFI complained that the disk install path is not updated for the second disk. The install path is “EFI: installed device path '/VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/Scsi(0,0)'” when first disk is added. But the path is same when the second or later disks are add

[PATCH V2 1/2] doc: board: ti: Use prompt prompt_style to simplify documentation

2023-11-02 Thread Nishanth Menon
The sphinx-prompt documentation[0] provides examples on how we can use prompt as a parameter to simplify the description. Use the same. While at it, ensure to make all relevant prompts clarified such as gdb prompts. [0] http://sbrunner.github.io/sphinx-prompt/ Signed-off-by: Nishanth Menon ---

[PATCH V2 2/2] doc: board: ti: k3 docs: Use ::prompt

2023-11-02 Thread Nishanth Menon
Use prompt instead of code-block to have copy-paste friendly command documentation. Signed-off-by: Nishanth Menon --- Changes since v1: minor fixup for whitespace indentation. V1: https://lore.kernel.org/r/20231103000915.2413501-4...@ti.com doc/board/ti/am62x_beagleplay.rst | 46 ++---

[PATCH V2 0/2] doc: board: ti: Cleanup ::prompt usage

2023-11-02 Thread Nishanth Menon
Due to the sequence of merges, it looks like many of k3 documentation used code-blocks while the rest of the docs migrated to ::prompt. Sync all to a common style. based off: master 07fe79c93c5c Merge tag 'i2cfixes-for-v2024-01-rc2' of https://source.denx.de/u-boot/custodians/u-boot-i2c Changes

RE: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-11-02 Thread Jaehoon Chung
Hi, > -Original Message- > From: U-Boot On Behalf Of Jaehoon Chung > Sent: Friday, November 3, 2023 10:07 AM > To: 'Mattijs Korpershoek' > Cc: lu...@denx.de; u-boot@lists.denx.de > Subject: RE: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration > > Hi Mathtjjs, > > > -Original

Re: [PATCH 1/6] pinctrl: qcom: move out of mach-snapdragon

2023-11-02 Thread Sumit Garg
On Tue, 31 Oct 2023 at 19:52, Caleb Connolly wrote: > > Move the Qualcomm pinctrl drivers out of mach-snapdragon and over to the > rest of the pinctrl drivers, adjust the drivers so that support for each > platform can be enabled/disabled individually and introduce platform > specific configuratio

<    1   2