Re: [PATCH] tools: relocate-rela: Fix typo

2023-06-01 Thread Michal Simek
On 5/31/23 00:53, Marek Vasut wrote: Position is written with one s, fix typo. Signed-off-by: Marek Vasut --- Cc: Michal Simek Cc: Ovidiu Panait Cc: Samuel Holland --- tools/relocate-rela.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/relocate-rela.c b/tool

[PATCH 1/1] efi_selftest: LocateHandleBuffer return code

2023-06-01 Thread Heinrich Schuchardt
Check that LocateHandleBuffer() return EFI_NOT_FOUND when called with ByRegisterNotify and all handles already have been retrieved. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_register_notify.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff

Re: [PATCH 1/1] test: bootflow test depends on CONFIG_VIDEO

2023-06-01 Thread Heinrich Schuchardt
On 5/31/23 23:16, Simon Glass wrote: Hi Heinrich, On Wed, 31 May 2023 at 14:22, Heinrich Schuchardt wrote: On 5/31/23 21:52, Simon Glass wrote: Hi Heinrich, On Wed, 31 May 2023 at 13:27, Heinrich Schuchardt wrote: On 5/31/23 20:24, Tom Rini wrote: On Wed, May 31, 2023 at 08:05:18

Re: [PATCH 1/1] efi_selftest: LocateHandleBuffer return code

2023-06-01 Thread Ilias Apalodimas
On Thu, 1 Jun 2023 at 10:07, Heinrich Schuchardt wrote: > > Check that LocateHandleBuffer() return EFI_NOT_FOUND when called with > ByRegisterNotify and all handles already have been retrieved. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_register_notify.c | 16 ++

Re: [PATCH v7 4/4] Load option with short device path for boot vars

2023-06-01 Thread Ilias Apalodimas
On Wed, 31 May 2023 at 20:47, Raymond Mao wrote: > > The boot variables automatically generated for removable medias > should be with short form of device path without device nodes. > This is a requirement for the case that a removable media is > plugged into a different port but is still able to

[PATCH] configs: synquacer: increase SYS_MALLOC_F_LEN

2023-06-01 Thread Masahisa Kojima
DM_FLAG_PRE_RELOC flag is added into some drivers by recent commits such as 1bd790bc4b ("firmware: psci: enable DM_FLAG_PRE_RELOC"). Current SYS_MALLOC_F_LEN of SynQuacer Developerbox platform is too small, Developerbox will not boot due to lack of heap memory. This commit increases the size of he

Re: [PATCH] configs: synquacer: increase SYS_MALLOC_F_LEN

2023-06-01 Thread Ilias Apalodimas
On Thu, 1 Jun 2023 at 12:14, Masahisa Kojima wrote: > > DM_FLAG_PRE_RELOC flag is added into some drivers > by recent commits such as > 1bd790bc4b ("firmware: psci: enable DM_FLAG_PRE_RELOC"). > Current SYS_MALLOC_F_LEN of SynQuacer Developerbox platform > is too small, Developerbox will not boot

[PATCH v1 0/6] Provide support for mv88e6020 Marvell switch

2023-06-01 Thread Lukasz Majewski
This patch set provides support for mv88e6020 switch. It is a dual chip device, with direct access to port register on SMI bus. However, PHYs are accessed indirectly. I've rebased this series (unmodified) on v2023.07-rcX (SHA1: cb4437e530ec1ff3deae85754010344afab8bcc5) and added reviewed by tags.

[PATCH v1 1/6] net: mv88e61xx: Add support for checking addressing mode

2023-06-01 Thread Lukasz Majewski
Some Marvell switch devices are dual chip ones, like mv88e6020, which use direct MDIO addressing to access its ports' registers. Such approach allows connecting two such devices in a single MDIO bus with simple addressing scheme. Signed-off-by: Lukasz Majewski Reviewed-by: Ramon Fried --- driv

[PATCH v1 3/6] net: mv88e61xx: Clear temporary structs before using them in get_phy_id()

2023-06-01 Thread Lukasz Majewski
Those automatically created structures can have random value. However, mv88e61xx driver assumes that those are zeroed. Signed-off-by: Lukasz Majewski Reviewed-by: Ramon Fried --- drivers/net/phy/mv88e61xx.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/phy/mv88e61xx.c b/d

[PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Lukasz Majewski
After this change PHY ports are able to pass packets between them (and also to CPU port). The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get the PHY ports of the switch and generate proper mask. Signed-off-by: Lukasz Majewski Reviewed-by: Ramon Fried --- drivers/net/phy/mv88e6

[PATCH v1 6/6] net: mv88e61xx: Reset switch PHYs when bootstrapped to !NO_CPU

2023-06-01 Thread Lukasz Majewski
Some devices, when configured in bootstrap to 'no cpu' mode require PHY manual reset to get them operational and responding to reading their ID registers. Without this step - the PHYLIB probing will fail. In more details - the bootstrap configuration from switch must be read. The value of CONFIG

[PATCH v1 5/6] net: mv88e61xx: Set proper offset when R0_LED/ADDR4 is set on bootstrap

2023-06-01 Thread Lukasz Majewski
The mv88e61xx driver need to be adjusted to handle situation when switch MDIO addresses are switched by offset (0x10 in this case). Signed-off-by: Lukasz Majewski Reviewed-by: Ramon Fried --- drivers/net/phy/mv88e61xx.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deleti

[PATCH v1 4/6] net: mv88e61xx: Directly access the switch chip

2023-06-01 Thread Lukasz Majewski
The mv88e6020 is accessed in a direct way (i.e. with direct read and write to mdio bus). The only necessary indirection is required when accessing its PHY registers. Signed-off-by: Lukasz Majewski Reviewed-by: Ramon Fried --- drivers/net/phy/mv88e61xx.c | 15 ++- 1 file changed, 10

Re: [PATCH v2 0/3] Meson Secure PWRC Driver

2023-06-01 Thread Neil Armstrong
Hi, On Wed, 31 May 2023 12:31:53 +0300, Alexey Romanov wrote: > This patch set adds support (driver and sm functions) for working with > power domain controller using secure monitor for Amlogic A1-series. > Additionally, in the future, the driver can be used for other Amlgoic > SoC series, such as

[PATCH] arm64: zynqmp: Check 0 node ID

2023-06-01 Thread Michal Simek
ID is decimal not hexadecimal that's why passing hex number all the time end's up as 0 that's why check it. Node ID 0 is not valid anyway. Also properly say it in help. Signed-off-by: Michal Simek --- board/xilinx/zynqmp/cmds.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --

Re: [PATCH v1 3/6] net: mv88e61xx: Clear temporary structs before using them in get_phy_id()

2023-06-01 Thread Marek Vasut
On 6/1/23 12:00, Lukasz Majewski wrote: Those automatically created structures can have random value. However, mv88e61xx driver assumes that those are zeroed. Signed-off-by: Lukasz Majewski Reviewed-by: Ramon Fried --- drivers/net/phy/mv88e61xx.c | 4 1 file changed, 4 insertions(+)

Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Marek Vasut
On 6/1/23 12:00, Lukasz Majewski wrote: After this change PHY ports are able to pass packets between them (and also to CPU port). The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get the PHY ports of the switch and generate proper mask. Signed-off-by: Lukasz Majewski Reviewed-by:

Re: [PATCH v1 6/6] net: mv88e61xx: Reset switch PHYs when bootstrapped to !NO_CPU

2023-06-01 Thread Marek Vasut
On 6/1/23 12:00, Lukasz Majewski wrote: Some devices, when configured in bootstrap to 'no cpu' mode require PHY manual reset to get them operational and responding to reading their ID registers. Without this step - the PHYLIB probing will fail. In more details - the bootstrap configuration from

Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Lukasz Majewski
Hi Marek, > On 6/1/23 12:00, Lukasz Majewski wrote: > > After this change PHY ports are able to pass packets between them > > (and also to CPU port). > > > > The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get > > the PHY ports of the switch and generate proper mask. > > > > Signe

[PATCH] arm64: zynqmp: Fix command error values properly

2023-06-01 Thread Michal Simek
Process errors from command via cmd_process_error() as is done on Versal. When internal function returns different number then CMD_RET_SUCCESS(0), CMD_RET_FAILURE(1) or CMD_RET_USAGE(-1) shell react on these errors by throwing an error like "exit not allowed from main input shell." that's why use c

[PATCH] arm64: zynqmp: Fix return code from do_zynqmp_pmufw()

2023-06-01 Thread Michal Simek
zynqmp_pmufw_node() can also return values like -ENODEV which means that NODE has been already configured that's why don't propagate this error code. Signed-off-by: Michal Simek --- The same technique was used on power domain driver by this patch https://lore.kernel.org/r/20230523124215.30915-3-

Re: [PATCH 2/5] usb: dwc3-generic: Return early when there is no child node

2023-06-01 Thread Jonas Karlman
Hi Jagan, On 2023-06-01 06:10, Jagan Teki wrote: > On Tue, May 30, 2023 at 3:56 PM Jonas Karlman wrote: >> >> The call to device_find_first_child always return 0, change to return >> early when there is no child node. > > Can you explain a little more about this? Maybe adding device-tree > pipel

[PATCH] firmware: zynqmp: Extend debug message to show parameters

2023-06-01 Thread Michal Simek
Also print more arguments not just ID when xilinx_pm_request is called. It helps to decode what firmware is asked to do. Signed-off-by: Michal Simek --- drivers/firmware/firmware-zynqmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/firmware-zynqmp.c b

Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Marek Vasut
On 6/1/23 13:02, Lukasz Majewski wrote: Hi Marek, On 6/1/23 12:00, Lukasz Majewski wrote: After this change PHY ports are able to pass packets between them (and also to CPU port). The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get the PHY ports of the switch and generate prope

[PATCH 1/2] efi_loader: delete handle from events when a protocol is uninstalled

2023-06-01 Thread Ilias Apalodimas
When a notification event is registered for a protocol the handle of the protocol is added in our event notification list. When all the protocols of the handle are uninstalled we delete the handle but we do not remove it from the event notification list. Clean up the protocol removal functions an

[PATCH 2/2] efi_selftest: check for deleted handles in the event notification list

2023-06-01 Thread Ilias Apalodimas
A previous patch is fixing a problem where handles were added in an event notification list, but were never deleted when the handle got deleted. Add a test case which calls - RegisterProtocolNotify - IstallMultipleProtocolInterface - UnIstallMultipleProtocolInterface - LocateHandleBuffer(ByRegiste

Re: [PATCH v1 6/6] net: mv88e61xx: Reset switch PHYs when bootstrapped to !NO_CPU

2023-06-01 Thread Lukasz Majewski
Hi Marek, > On 6/1/23 12:00, Lukasz Majewski wrote: > > Some devices, when configured in bootstrap to 'no cpu' mode require > > PHY manual reset to get them operational and responding to reading > > their ID registers. > > > > Without this step - the PHYLIB probing will fail. > > > > In more det

Re: [PATCH 1/2] efi_loader: delete handle from events when a protocol is uninstalled

2023-06-01 Thread Ilias Apalodimas
Heinrich [...] > > diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c > index d5065f296aee..450524ddca2f 100644 > --- a/lib/efi_loader/efi_boottime.c > +++ b/lib/efi_loader/efi_boottime.c > @@ -197,6 +197,35 @@ static bool efi_event_is_queued(struct efi_event *event) >

Re: [PATCH] configs: synquacer: increase SYS_MALLOC_F_LEN

2023-06-01 Thread Jassi Brar
On Thu, 1 Jun 2023 at 04:14, Masahisa Kojima wrote: > > DM_FLAG_PRE_RELOC flag is added into some drivers > by recent commits such as > 1bd790bc4b ("firmware: psci: enable DM_FLAG_PRE_RELOC"). > Current SYS_MALLOC_F_LEN of SynQuacer Developerbox platform > is too small, Developerbox will not boot

[PATCH] core: read: fix dev_read_addr_size()

2023-06-01 Thread John Keeping
The behaviour of dev_read_addr_size() is surprising as it does not handle #address-cells and #size-cells but instead hardcodes the values based on sizeof(fdt_addr_t). This is different from dev_read_addr_size_index() and dev_read_addr_size_name() both of which do read the cell sizes from the devic

Re: [PATCH v1 6/6] net: mv88e61xx: Reset switch PHYs when bootstrapped to !NO_CPU

2023-06-01 Thread Marek Vasut
On 6/1/23 14:13, Lukasz Majewski wrote: Hi Marek, On 6/1/23 12:00, Lukasz Majewski wrote: Some devices, when configured in bootstrap to 'no cpu' mode require PHY manual reset to get them operational and responding to reading their ID registers. Without this step - the PHYLIB probing will fail

Re: [PATCH] fastboot: Only call the bootm command if it is enabled

2023-06-01 Thread Tom Rini
On Mon, Feb 20, 2023 at 12:14:58AM -0600, Samuel Holland wrote: > This fixes an error with trying to link against do_bootm() when > CONFIG_CMD_BOOTM is disabled. > > Signed-off-by: Samuel Holland > Reviewed-by: Mattijs Korpershoek > Reviewed-by: Patrick Delaunay Applied to u-boot/next, thanks

Re: [PATCH 1/3] Makefile: Fix incorrect FORCE deps on env rules

2023-06-01 Thread Tom Rini
On Sat, Apr 29, 2023 at 07:21:45PM -0600, Simon Glass wrote: > These rules run on every build even if nothing has changed. The FORCE > dependency is only needed for if_changed, not for cmd. Drop it. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Descript

Re: [PATCH 2/3] acpi: Put the version numbers in a central place

2023-06-01 Thread Tom Rini
On Sat, Apr 29, 2023 at 07:21:46PM -0600, Simon Glass wrote: > At present two acpi files are built every time since they use a version > number from version.h > > This is not necessary. Make use of the same technique as for the version > string, so that they are build only when they change. > >

Re: [PATCH 3/3] efi: Correct .efi rules

2023-06-01 Thread Tom Rini
On Sat, Apr 29, 2023 at 07:21:47PM -0600, Simon Glass wrote: > These files should have both 'always' and 'targets' so that dependencies > are detected correctly. > > When only 'always' is used, the target is built every time, although I am > not quite sure why. > > Make sure each has both 'alway

Re: [PATCH 1/2] cmd: fdt: Correct checking of configuration node

2023-06-01 Thread Tom Rini
On Mon, May 01, 2023 at 11:35:25AM +0800, Bin Meng wrote: > fit_conf_get_node() returns a negative value on error. > > Signed-off-by: Bin Meng > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/2] spl: Correct checking of configuration node

2023-06-01 Thread Tom Rini
On Mon, May 01, 2023 at 11:35:26AM +0800, Bin Meng wrote: > Per the fit_conf_get_node() API doc, it returns configuration node > offset when found (>=0). > > Signed-off-by: Bin Meng > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] cli: avoid buffer overrun

2023-06-01 Thread Tom Rini
On Tue, May 02, 2023 at 04:34:09AM +0200, Heinrich Schuchardt wrote: > Invoking the sandbox with > > /u-boot -c ⧵0xef⧵0xbf⧵0xbd > > results in a segmentation fault. > > Function b_getch() retrieves a character from the input stream. This > character may be > 0x7f. If type char is signed, st

Re: [PATCH] cmd: fs: document where 'size' stores its result

2023-06-01 Thread Tom Rini
On Sun, May 07, 2023 at 01:48:06PM +0300, Baruch Siach wrote: > Make it a little bit easier for the user to utilize the 'size' command. > > Signed-off-by: Baruch Siach > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] semihosting: create file in smh_fs_write_at()

2023-06-01 Thread Tom Rini
On Sat, May 13, 2023 at 12:47:03AM +0200, Heinrich Schuchardt wrote: > If a file does not exist, it should be created. > > Fixes: f676b45151c3 ("fs: Add semihosting filesystem") > Signed-off-by: Heinrich Schuchardt Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signat

Re: [PATCH] arm: set alignment properly for asm funcs

2023-06-01 Thread Tom Rini
On Fri, May 12, 2023 at 04:31:05PM -0600, Sam Edwards wrote: > ARM requires a 4-byte alignment on all ARM code (though this > requirement is relaxed to 2-byte for some THUMB code) and we > should be explicit about that here. > > GAS has its own fix for this[1] that forces proper alignment > on an

Re: [PATCH] scripts/Makefile.lib: change spelling of $(srctree)/arch/$(ARCH)/dts in dtc_cpp_flags

2023-06-01 Thread Tom Rini
On Tue, May 16, 2023 at 11:17:56AM +0200, Rasmus Villemoes wrote: > Currently, all in-tree .dts files (apart from some under test/ and > tools/), reside in arch/$ARCH/dts. However, in the linux kernel tree, > dts files for arm64 boards, and probably in the not too distant > future [1], arm boards

Re: [PATCH v3] cmd: sf/nand: Print and return failure when 0 length is passed

2023-06-01 Thread Tom Rini
On Tue, May 16, 2023 at 05:52:36AM -0600, Ashok Reddy Soma wrote: > For sf commands, when '0' length is passed for erase, update, write or > read, there might be undesired results. Ideally '0' length means nothing to > do. > > So print 'ERROR: Invalid size 0' and return cmd failure when length '0

Re: [PATCH] common: dfu: Remove leading space characters

2023-06-01 Thread Tom Rini
On Thu, May 18, 2023 at 12:06:23PM +0530, Ravi Gunasekaran wrote: > As per [1], dfu_alt_info is mentioned to be as semicolon separated > string of information on each alternate and the parsing logic in > the dfu.c is based on this. > > Typically, the dfu_alt_info_* is defined in .h files as prepr

Re: [PATCH] mmc: fix improper use of memset

2023-06-01 Thread Tom Rini
On Thu, May 18, 2023 at 01:47:07PM -0600, Sam Edwards wrote: > Buffers created through DEFINE_(CACHE_)ALIGN_BUFFER are actually > pointers to the real underlying buffer. Using sizeof(...) is > not appropriate in this case. > > Signed-off-by: Sam Edwards > Reviewed-by: Peng Fan Applied to u-boo

Re: [PATCH 1/2] efi_loader: delete handle from events when a protocol is uninstalled

2023-06-01 Thread Heinrich Schuchardt
On 6/1/23 14:06, Ilias Apalodimas wrote: When a notification event is registered for a protocol the handle of the protocol is added in our event notification list. When all the protocols of the handle are uninstalled we delete the handle but we do not remove it from the event notification list.

[PATCH 00/40] expo: Add an initial configuration editor

2023-06-01 Thread Simon Glass
This series provides a means to edit board configuration in U-Boot in a graphical manner. It supports multiple menu items and allows moving between them and selecting items. The configuration is defined in a data format so that code is not needed in most cases. This allows the board configuration t

[PATCH 01/40] binman: Correct coverage gap in control

2023-06-01 Thread Simon Glass
Add a pragma to deal with the code-coverage gap which drops binman down to 90% coverage. Fixes: de65b122a25 (tools: Fall back to importlib_resources on Python 3.6) Signed-off-by: Simon Glass --- tools/binman/control.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/b

[PATCH 02/40] expo: Correct some header-file comments

2023-06-01 Thread Simon Glass
The use of Returns instead of @return still confuses me. Fix some problems that have crept in. Signed-off-by: Simon Glass --- boot/scene_internal.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/boot/scene_internal.h b/boot/scene_internal.h index e8fd765811e1..9f173

[PATCH 03/40] expo: Convert to using a string ID for the scene title

2023-06-01 Thread Simon Glass
This is easier to deal with if it uses the existing string handling, since we will be able to use translations, etc. in the future. Update it to use an ID instead of a string. Signed-off-by: Simon Glass --- boot/scene.c | 8 ++-- include/expo.h | 10 +- test/boot/expo.c | 19

[PATCH 04/40] sandbox: Fix quiting when the LCD window is closed

2023-06-01 Thread Simon Glass
With recent changes to how sandbox handles reset, closing the window currently just restarts sandbox. Use the correct sysreset type to tell it to shut down. Signed-off-by: Simon Glass --- arch/sandbox/cpu/sdl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/sandbox/

[PATCH 05/40] test: Restore test behaviour on failure

2023-06-01 Thread Simon Glass
A recent change makes test continue to run after failure. This results in a lot of useless output and may lead to a segfault. Fix this by adding back the 'return' statement. Fixes: fa847bb409d ("test: Wrap assert macros in ({ ... }) and fix") Signed-off-by: Simon Glass --- include/test/ut.h |

[PATCH 06/40] gpio: Avoid using an invalid ofnode

2023-06-01 Thread Simon Glass
Devices do not necessarily have nodes attached to them, since they can be created from platdata. In SPL a devicetree may in fact not exist at all. Check the node before using it. This avoids failure when OF_CHECKS is enabled. Signed-off-by: Simon Glass Fixes: 5fc7cf8c8e2 ("gpio: add gpio-hog sup

[PATCH 07/40] dm: core: Avoid registering an inaccessible tree

2023-06-01 Thread Simon Glass
At present there are various restrictions on the use of livetree: - It is only available once the tree is unflattened, i.e. after relocation - It is designed to be used with the control FDT - It can (in principle) be used with other FDTs, but only if they are unflattened first; this is not suppo

[PATCH 08/40] video: Drop #ifdefs from console_truetype

2023-06-01 Thread Simon Glass
Use if() instead to reduce the number of build paths. Signed-off-by: Simon Glass --- drivers/video/console_truetype.c | 112 +++ 1 file changed, 56 insertions(+), 56 deletions(-) diff --git a/drivers/video/console_truetype.c b/drivers/video/console_truetype.c index

[PATCH 10/40] expo: Store the console in the expo

2023-06-01 Thread Simon Glass
Rather than finding this each time, keep a pointer to it. This simplifies the code a little. Signed-off-by: Simon Glass --- boot/expo.c| 9 + boot/scene.c | 10 ++ include/expo.h | 2 ++ 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/boot/expo.c b/boot/e

[PATCH 09/40] video: Provide a way to clear part of the console

2023-06-01 Thread Simon Glass
This is useful when the background colour must be written before text is updated, to avoid strange display artifacts. Add a function for this, using the existing code from the truetype console. Signed-off-by: Simon Glass --- drivers/video/console_truetype.c | 72 ++-

[PATCH 12/40] console: Correct truetype spacing error

2023-06-01 Thread Simon Glass
The putc_xy() method is supposed to return the amount of space used. The existing implementation erroneously adds the previous sub-pixel position to the returned value. This spaces out the characters very slightly more than it should. It is seldom noticeable but it does make accurate measurement of

[PATCH 11/40] expo: Avoid automatically arranging the scene

2023-06-01 Thread Simon Glass
This should ideally be done once after all scene changes have been made. Require an explicit call when everything is ready. Always arrange after a key it sent, just for convenience. Signed-off-by: Simon Glass --- boot/bootflow_menu.c | 4 boot/expo.c | 15 ++- boot/s

[PATCH 17/40] fdt: Clarify the fdt pre-relocation warning

2023-06-01 Thread Simon Glass
Reword this so it is easier to understand. Signed-off-by: Simon Glass --- drivers/core/ofnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c index 1d4ab5bb6f2f..dee890b5527b 100644 --- a/drivers/core/ofnode.c +++ b/drivers/cor

[PATCH 13/40] expo: Rename exp_set_text_mode()

2023-06-01 Thread Simon Glass
Rename this function to match its peers, using the full "expo' prefix. Signed-off-by: Simon Glass --- boot/bootflow_menu.c | 2 +- boot/expo.c | 2 +- include/expo.h | 4 ++-- test/boot/expo.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/boot/bootflo

[PATCH 16/40] fdt: Align the start of the livetree

2023-06-01 Thread Simon Glass
Ensure that the block of memory used by live tree is aligned according to the default for structures. This ensures that the root node appears at the start of the block, so it can be used with free(), rather than being 4 bytes later in some cases. This corrects a rather obscure bug in unflatten_dev

[PATCH 15/40] cat: Update command to use fs_load_alloc()

2023-06-01 Thread Simon Glass
Use this new function since it implements the required functionality and reduces duplicated code. Signed-off-by: Simon Glass --- cmd/cat.c | 47 +-- 1 file changed, 17 insertions(+), 30 deletions(-) diff --git a/cmd/cat.c b/cmd/cat.c index 1273a26b14

[PATCH 14/40] fs: Create functions to load and allocate a file

2023-06-01 Thread Simon Glass
This functionality current sits in bootstd, but it is more generally useful. Add a function to load a file into memory, allocating it as needed. Adjust bootstd to use this version. Note: Tests are added in the subsequent patch which converts the 'cat' command to use this function. Signed-off-by:

[PATCH 24/40] video: Use enum with video_index_to_colour()

2023-06-01 Thread Simon Glass
Use the provided enum with this function, so it is clearer what should be passed to it. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 2 +- include/video.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/video-uclass.c b/driver

[PATCH 26/40] expo: Use flags for objects

2023-06-01 Thread Simon Glass
We currently have just a 'hide' property for each object. In preparation for adding more properties, convert the struct to use a flags value, instead of individual booleans. This is more extensible. Signed-off-by: Simon Glass --- boot/scene.c | 17 +++-- boot/scene_internal

[PATCH 18/40] fdt: Allow more general use of livetree

2023-06-01 Thread Simon Glass
At present livetree can only be used for the control FDT. It is useful to be able to use the ofnode API for other FDTs, e.g. those used by the upcoming configuration editor. We already have most of the support present, and tests can be marked with the UT_TESTF_OTHER_FDT flag to use another FDT as

[PATCH 20/40] video: Correct docs for video_index_to_colour()

2023-06-01 Thread Simon Glass
This uses the private data of the video uclass, not the console uclass (its child). Update the comment to avoid confusion. Signed-off-by: Simon Glass Fixes: a032e4b55ea ("video: Move console colours to the video uclass") --- include/video.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 19/40] bootstd: Add a separate log category for expo

2023-06-01 Thread Simon Glass
This feature is different enough from bootstd that it probably deserves its own log category. It cannot use a uclass since it is not a device. Add a new category. Signed-off-by: Simon Glass --- boot/expo.c | 2 ++ boot/scene.c | 2 ++ boot/scene_menu.c | 2 +- common/log.c | 1

[PATCH 22/40] console: Allow measuring the bounding box of text

2023-06-01 Thread Simon Glass
For laying out text accurately it is necessary to know the width and height of the text. Add a measure() method to the console API, so this can be supported. Add an implementation for truetype and a base implementation for the normal console. Signed-off-by: Simon Glass --- drivers/video/consol

[PATCH 21/40] video: Allow temporary colour changes

2023-06-01 Thread Simon Glass
It is sometimes necessary to highlight some text in a different colour. Add an easy way to do this and then restore the original console colours. Signed-off-by: Simon Glass --- drivers/video/vidconsole-uclass.c | 20 include/video_console.h | 30 ++

[PATCH 23/40] expo: Allow setting the start of the dynamic-ID range

2023-06-01 Thread Simon Glass
Provide a way to set this value so that it is easy to separate the statically allocated IDs (generated by the caller) from those generated dynamically by expo itself. Signed-off-by: Simon Glass --- boot/expo.c | 15 +++ boot/scene.c | 10 -- doc/develop/expo

[PATCH 29/40] expo: Support simple themes

2023-06-01 Thread Simon Glass
It is a pain to manually set the fonts of all objects to be consistent. Some spacing settings are also better set globally than by manually positioning each object. Add a 'theme' to the expo, to hold this information. For now it includes only the font size. Signed-off-by: Simon Glass --- boot/

[PATCH 25/40] expo: Add width and height to objects

2023-06-01 Thread Simon Glass
At present objects only have a position so it is not possible to determine the amount of space they take up on the display. Add width and height properties, using a struct to keep all the dimensions together. For now this is not used. Future work will set up these new properties. Signed-off-by:

[PATCH 28/40] expo: Set up the width and height of objects

2023-06-01 Thread Simon Glass
Provide a way to set the full dimensions of objects, i.e. including the width and height. For menus, calculate the bounding box of all objects in the menu. Set all labels to be the same size, so that highlighting works correct, once implemented. Signed-off-by: Simon Glass --- boot/expo.c

[PATCH 30/40] expo: Move menu-item selection into a function

2023-06-01 Thread Simon Glass
The current implementation supports a 'pointer' object which points to the currently highlighted menu item. We want to support highlighting the label of the menu item instead, e.g. with inverse video. In this case we will need to 'unhighlight' the old item and highlight the new one. As a first ste

[PATCH 27/40] expo: Calculate text bounding-box correctly

2023-06-01 Thread Simon Glass
Rather than estimating, measure the text accurately, using the new vidconsole feature. This allows accurate placement of objects. Signed-off-by: Simon Glass --- boot/scene.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/boot/scene.c b/boot/s

[PATCH 33/40] expo: Draw popup menus in both opened and closed states

2023-06-01 Thread Simon Glass
When a popup menu is closed it shows only the selected item. When it is open it shows a background and all items, with a highlight that can be moved between the items. Add the drawing logic for this. Signed-off-by: Simon Glass --- boot/scene.c | 66

[PATCH 34/40] expo: Draw the current opened menu on top

2023-06-01 Thread Simon Glass
When a menu is opened, it must be displayed over all other objects in the scene, so that all its items are visible. Handle this by drawing the menu object a second time, after all other objects have been drawn. Draw all of the objects which are dependent on the menu object. Signed-off-by: Simon G

[PATCH 31/40] expo: Support drawing of popup menus

2023-06-01 Thread Simon Glass
At present only a single menu is supported. All items are shown and a pointer object points to the current item. Add support for multiple menus, one of which is highlighted, indicated by the highlight_id property in the scene. The highlighted menu item has a SCENEOF_POINT flag, indicating that it

[PATCH 32/40] expo: Rename EXPOACT_POINT to EXPOACT_POINT_ITEM

2023-06-01 Thread Simon Glass
At present we only support a single menu, so all that can be pointed to is the current menu item. Rename this action so that we can also add an action for pointing to an object. This will allow cycling through the objects in a scene. Signed-off-by: Simon Glass --- boot/scene_menu.c | 4 ++-- in

[PATCH 35/40] expo: Implement the keypress logic for popup menus

2023-06-01 Thread Simon Glass
In 'popup' mode, the expo allows moving around the objects in a scene. When 'enter' is pressed on a menu, it opens and the user can move around the items in the menu. Implement this using keypress handles and actions. Signed-off-by: Simon Glass --- boot/scene.c | 80 +++

[PATCH 36/40] expo: Add spacing around menus and items

2023-06-01 Thread Simon Glass
It looks better if menus have a bit of an inset, rather than be drawn hard up against the background. Also, menu items look better if they have a bit of spacing between them. Add theme options for these and implement the required changes. Signed-off-by: Simon Glass --- arch/sandbox/dts/test.dt

[PATCH 37/40] expo: Support building an expo from a description file

2023-06-01 Thread Simon Glass
The only way to create an expo at present is by calling the functions to create each object. It is useful to have more data-driven approach, where the objects can be specified in a suitable file format and created from that. This makes testing easier as well. Add support for describing an expo in

[PATCH 38/40] expo: Add a configuration editor

2023-06-01 Thread Simon Glass
Add a new 'cedit' command which allows editing configuration using an expo. The configuration items appear as menus on the display. This is extremely basic, only supporting menus and not providing any way to load or save the configuration. Signed-off-by: Simon Glass --- boot/Kconfig

[PATCH 39/40] expo: Add tests for the configuration editor

2023-06-01 Thread Simon Glass
Add some simple tests and a helpful script to make the configuration editor easier to set up. Signed-off-by: Simon Glass --- arch/sandbox/dts/sandbox.dtsi | 6 ++ arch/sandbox/dts/test.dts | 6 ++ test/boot/expo.c| 44 +++ test/boot/files/expo_layout.dts |

Re: [PATCH 2/2] efi_selftest: check for deleted handles in the event notification list

2023-06-01 Thread Heinrich Schuchardt
On 6/1/23 14:06, Ilias Apalodimas wrote: A previous patch is fixing a problem where handles were added in an event notification list, but were never deleted when the handle got deleted. Add a test case which calls - RegisterProtocolNotify - IstallMultipleProtocolInterface - UnIstallMultipleProto

Re: [PATCH] arm: dts: ast2600: Add I2C pinctrl

2023-06-01 Thread Tom Rini
On Wed, Jun 01, 2022 at 11:10:18AM -0500, Eddie James wrote: > Set the pinctrl groups for each I2C bus. These are essential to > I2C operating correctly. > > Signed-off-by: Eddie James > Reviewed-by: Joel Stanley > Reviewed-by: Ryan Chen > --- > arch/arm/dts/ast2600.dtsi | 33

[PATCH 40/40] RFC: video: Update stb_truetype

2023-06-01 Thread Simon Glass
This was brought in in 2016 and a number of changes have been made since then. There does not seem to be much change in functionality, but it is a good idea to update from time to time. Bring in the latest version: 5736b15 ("re-add perlin noise again") Add a few necessary functions, with dumm

Re: [PATCH 0/8] Updats SPL splashscreen framework for AM62x

2023-06-01 Thread Tom Rini
On Thu, May 11, 2023 at 03:29:50PM +0530, Nikhil M Jain wrote: > This patch series aims at updating SPL splashscreen framework for AM62x. > > Nikhil M Jain (8): > common: spl: spl: Update stack pointer address > arch: arm: mach-k3: common: Return a pointer after setting page table > board:

Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Vladimir Oltean
Hi Lukasz, On Thu, Jun 01, 2023 at 01:44:30PM +0200, Marek Vasut wrote: > I think after two years, it would be good to drop the RB tags and do another > round of reviews. To expand on Marek's point. In those past 2 years, Tim Harvey has put in a considerable amount of effort to add another drive

[PATCH] ARM: dts: stm32: fix display pinmux for stm32f746-disco

2023-06-01 Thread Dario Binacchi
As reported by the datasheet (DocID027590 Rev 4) for PG12: - AF9 -> LCD_B4 - AF14 -> LCD_B1 So replace AF14 with AF9 for PG12 in the dts. Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7") Signed-off-by: Dario Binacchi --- arch/arm/dts/stm32f746-disco-u-boot.dtsi

Re: Loading from squashfs with zstd compression slower than ext4

2023-06-01 Thread Tom Rini
On Thu, Jun 01, 2023 at 02:10:21PM +1000, Jonathan Liu wrote: > Hi Simon, > > On Thu, 1 Jun 2023 at 11:27, Jonathan Liu wrote: > > > > Hi Simon, > > > > On Thu, 1 Jun 2023 at 03:13, Simon Glass wrote: > > > > > > Hi Jonathan, > > > > > > On Wed, 31 May 2023 at 06:52, Jonathan Liu wrote: > > > >

Re: [PATCH] ARM: dts: stm32: fix display pinmux for stm32f746-disco

2023-06-01 Thread Tom Rini
On Thu, Jun 01, 2023 at 07:06:02PM +0200, Dario Binacchi wrote: > As reported by the datasheet (DocID027590 Rev 4) for PG12: > - AF9 -> LCD_B4 > - AF14 -> LCD_B1 > > So replace AF14 with AF9 for PG12 in the dts. > > Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for > stm32f7

Re: [PATCH v4 00/11] Add ethernet driver for StarFive JH7110 SoC

2023-06-01 Thread Torsten Duwe
On Thu, 25 May 2023 17:36:26 +0800 Yanhong Wang wrote: [...] > > base-commit: 62df7a39442902a71259568c13a4d496d5a514f4 Have you tested this? I get | U-Boot SPL 2023.07-rc2-00170-g62df7a3944 (Jun 01 2023 - 18:58:50 +0200) | DDR version: dc2e84f0. | Trying to boot from MMC2 | | | U-Boot 2023.

Re: [PATCH 2/2] efi_selftest: check for deleted handles in the event notification list

2023-06-01 Thread Ilias Apalodimas
Hi Heinrich, [...] > > + * @event notified event > > + * @contextpointer to the notification count > > + */ > > +static void EFIAPI test_uninstall_notify(struct efi_event *event, void > > *context) > > +{ > > + return; > > +} > > + > > /* > >* Setup unit test. > >* > > @@ -9

Re: [PATCH 1/2] efi_loader: delete handle from events when a protocol is uninstalled

2023-06-01 Thread Ilias Apalodimas
[...] > > > > +/** > > + * efi_handle_cleanup() - Clean the deleted handle from the various lists > > + * @handle: handle to remove > > + * @force: force removal even if protocols are still installed on the > > handle > > + * > > + * Return: status code > > + */ > > +static void efi_handle_cle

Re: [PATCH v2 1/2] Revert "arm: mach-k3: common: don't reconfigure background firewalls"

2023-06-01 Thread Tom Rini
On Fri, May 05, 2023 at 03:53:59PM +0530, Manorit Chawdhry wrote: > This reverts commit b8ebf24e7f4afb5093a31bdf122e1ed0781e5c3c. > > This patch seems to be fundamentally wrong and requires a different way > on how the background firewalls should be configured so revert the patch > > Signed-off-

Re: [PATCH v2 2/2] arm: mach-k3: common: reorder removal of firewalls

2023-06-01 Thread Tom Rini
On Fri, May 05, 2023 at 03:54:00PM +0530, Manorit Chawdhry wrote: > K3 devices have some firewalls set up by ROM that we usually remove so > that the development is easy in HS devices. > > While removing the firewalls disabling a background region before > disabling the foreground regions keeps t

  1   2   >