Re: [PATCH 3/3] cmd: pxe: use strdup to copy config

2022-12-12 Thread Tom Rini
On Fri, Oct 28, 2022 at 11:01:20AM +0200, Patrick Delaunay wrote: > Replace malloc and strcpy by strdup in > function parse_label_kernel. > > Signed-off-by: Patrick Delaunay > Reviewed-by: Neil Armstrong Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] distro/pxeboot: Handle prompt variable

2022-12-12 Thread Tom Rini
On Fri, Nov 18, 2022 at 09:00:27AM +0100, Manuel Traut wrote: > Regarding the documentation found here: > https://github.com/u-boot/u-boot/blob/master/common/menu.c#L347 > > If both timeout and prompt is set to 0 the default entry shall > be booted immediately. However the current behaviour is th

Re: [PATCH v1 1/2] ARM: config: enable function for nuvoton npcm845 bmc

2022-12-12 Thread Tom Rini
On Mon, Nov 28, 2022 at 10:32:43AM +0800, Jim Liu wrote: > Signed-off-by: Jim Liu Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v1 2/2] ARM: dts: npcm8xx: add npcm845 function node

2022-12-12 Thread Tom Rini
On Mon, Nov 28, 2022 at 10:32:44AM +0800, Jim Liu wrote: > 1. add usb phy > 2. add ehci ohci sdhci > 3. add pinctrl node > 4. add fiu node > > Signed-off-by: Jim Liu Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v1] ARM: dts: npcm7xx: add npcm750 gpio node compatible name

2022-12-12 Thread Tom Rini
On Mon, Nov 28, 2022 at 10:34:47AM +0800, Jim Liu wrote: > Add npcm750 gpio node compatible name > > Signed-off-by: Jim Liu Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/2] omap4: make musb probeable by simple bus

2022-12-12 Thread Tom Rini
On Sat, Nov 26, 2022 at 11:30:09PM +0100, Andreas Kemnade wrote: > Like other peripherals important for booting, > do not rely on ti-sysc compatibility alone > > Signed-off-by: Andreas Kemnade Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] arm: mach-omap2: Move common image process functions out of board files

2022-12-12 Thread Tom Rini
On Thu, Oct 20, 2022 at 12:12:19PM -0500, Andrew Davis wrote: > The functions board_fit_image_post_process() and board_tee_image_process() > are not actually board specific (despite their names). Any board using the > OMAP2 family can use these functions. Move them to boot-common.c. > > Signed-of

Re: [PATCH] configs: set CONFIG_LMB_MAX_REGIONS=64 for all mt798[16] boards

2022-12-12 Thread Tom Rini
On Tue, Nov 29, 2022 at 07:37:59PM +, Daniel Golle wrote: > With recently added wireless offloading features in Linux [1] the > number of reserved memory regions with MediaTek SoCs supporting > offloading wireless-to-Ethernet traffic grew beyond the default (8) > which breaks booting Linux: >

Re: [PATCH] drivers: pci: pcie_dw_common: add upper-limit to iATU

2022-12-12 Thread Tom Rini
On Thu, Oct 20, 2022 at 04:51:09PM +0100, Ben Dooks wrote: > The 4.6 spec added an upper 32bits to the ATU limit, and since this > driver is already assuming the unrolled feature added in the 4.8 > specification this really should be set. > > This is causing a bug with testing against the QEMU mo

Re: [PATCH] tpm2: ftpm: open session with privileged ree login

2022-12-12 Thread Ilias Apalodimas
On Wed, Dec 07, 2022 at 04:25:33PM +0100, Etienne Carriere wrote: > Opens the fTPM session with TEE_LOGIN_REE_KERNEL as fTPM may restrict > access to that login when Linux based OS is running as applications are > expected to got through the Linux TPMv2 driver. > > Signed-off-by: Etienne Carriere

Re: [PATCH] Makefile: With BINMAN_ALLOW_MISSING=1 don't error on missing

2022-12-12 Thread Tom Rini
On Tue, Dec 06, 2022 at 10:03:37AM -0500, Tom Rini wrote: > On Tue, Dec 06, 2022 at 03:36:49PM +1300, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 6 Dec 2022 at 15:03, Tom Rini wrote: > > > > > > When the user builds with BINMAN_ALLOW_MISSING=1 they're explicitly > > > setting the flag to allow

Re: [PATCH 1/4] riscv: spl: Introduce SPL_OPENSBI_OS_BOOT

2022-12-12 Thread Sean Anderson
On 12/12/22 10:03, Tom Rini wrote: On Mon, Dec 12, 2022 at 02:45:10PM +0800, Rick Chen wrote: Hi Tom On Fri, Dec 09, 2022 at 08:48:37AM -0500, Sean Anderson wrote: On 12/7/22 01:23, Rick Chen wrote: In RISC-V, it only provide normal mode booting currently. To speed up the booting process, he

Re: [PATCH 1/4] riscv: spl: Introduce SPL_OPENSBI_OS_BOOT

2022-12-12 Thread Rick Chen
Hi Sean, > On 12/12/22 10:03, Tom Rini wrote: > > On Mon, Dec 12, 2022 at 02:45:10PM +0800, Rick Chen wrote: > >> Hi Tom > >> > >>> On Fri, Dec 09, 2022 at 08:48:37AM -0500, Sean Anderson wrote: > On 12/7/22 01:23, Rick Chen wrote: > > In RISC-V, it only provide normal mode booting curren

Re: Converting to DM SERIAL for Kirkwood boards

2022-12-12 Thread Tony Dinh
Hi Michael, On Mon, Dec 12, 2022 at 1:03 AM Michael Walle wrote: > > >> On 12/9/22 04:55, Tony Dinh wrote: > >> > Hi Simon et al, > >> > > >> > (Resend to include u-boot mailing list) > >> > > >> > I'm in the process of converting Kirkwood boards to use DM SERIAL. I > >> > could not seem to get i

Re: [PATCH 1/4] riscv: spl: Introduce SPL_OPENSBI_OS_BOOT

2022-12-12 Thread Rick Chen
Hi Tom > On Mon, Dec 12, 2022 at 02:45:10PM +0800, Rick Chen wrote: > > Hi Tom > > > > > On Fri, Dec 09, 2022 at 08:48:37AM -0500, Sean Anderson wrote: > > > > On 12/7/22 01:23, Rick Chen wrote: > > > > > In RISC-V, it only provide normal mode booting currently. > > > > > To speed up the booting p

Re: [PATCH] serial: ns16550: Enable clocks during probe

2022-12-12 Thread Samuel Holland
On 12/12/22 12:54, Tom Rini wrote: > On Sun, Nov 27, 2022 at 11:48:34PM -0600, Samuel Holland wrote: > >> If the UART bus or baud clock has a gate, it must be enabled before the >> UART can be used. >> >> Signed-off-by: Samuel Holland >> Reviewed-by: Stefan Roese > > This breaks building on phy

Re: [PATCH v1] net: nuvoton: fix build broken for use phy_get_interface_by_name

2022-12-12 Thread Jim Liu
Hi Tom My upstream topic status is Awaiting Upstream. What could I do to make it merge fast? Your comments are welcome. Best regards, Jim On Mon, Nov 21, 2022 at 3:41 PM Jim Liu wrote: > > Hi Ramon > > My upstream topic status is Awaiting Upstream. > What could I do to make it merge fast? > >

[PATCH v2] serial: ns16550: Enable clocks during probe

2022-12-12 Thread Samuel Holland
If the UART bus clock has a gate, it must be enabled before the UART can be used. Signed-off-by: Samuel Holland --- Changes in v2: - Only enable the first clock, as using the clk_get_bulk() API pushes a board (phycore-rk3288) over its SPL size limit. drivers/serial/ns16550.c | 5 + 1 f

Re: [PATCH v1] net: nuvoton: fix build broken for use phy_get_interface_by_name

2022-12-12 Thread Tom Rini
On Tue, Dec 13, 2022 at 09:48:12AM +0800, Jim Liu wrote: > Hi Tom > > My upstream topic status is Awaiting Upstream. > What could I do to make it merge fast? > Your comments are welcome. It's in -next now, for v2023.04. Does this fix some regression already present in-tree? > > Best regards, >

Re: [PATCH 1/4] riscv: spl: Introduce SPL_OPENSBI_OS_BOOT

2022-12-12 Thread Rick Chen
> On Mon, Dec 12, 2022 at 03:49:10PM +0800, Rick Chen wrote: > > > On 12/7/22 01:23, Rick Chen wrote: > > > > In RISC-V, it only provide normal mode booting currently. > > > > To speed up the booting process, here provide SPL_OPENSBI_OS_BOOT > > > > to achieve this feature which will be call Fast-B

Re: [PATCH v1] net: nuvoton: fix build broken for use phy_get_interface_by_name

2022-12-12 Thread Jim Liu
Hi Tom Thanks for your quick response. I add defconfig patch and found this build error and i2c naming issue. https://patchwork.ozlabs.org/project/uboot/patch/20220712092407.16567-2-jjl...@nuvoton.com/ So I add patch to fix this build error. -> https://patchwork.ozlabs.org/project/uboot/patch/2

Re: [PATCH v1] net: nuvoton: fix build broken for use phy_get_interface_by_name

2022-12-12 Thread Tom Rini
On Tue, Dec 13, 2022 at 10:56:49AM +0800, Jim Liu wrote: > Hi Tom > > Thanks for your quick response. > > I add defconfig patch and found this build error and i2c naming issue. > https://patchwork.ozlabs.org/project/uboot/patch/20220712092407.16567-2-jjl...@nuvoton.com/ > > So I add patch to fix

Re: [PATCH v1] net: nuvoton: fix build broken for use phy_get_interface_by_name

2022-12-12 Thread Jim Liu
Hi Tom OK , thanks for your reply. Best regards, Jim On Tue, Dec 13, 2022 at 11:01 AM Tom Rini wrote: > > On Tue, Dec 13, 2022 at 10:56:49AM +0800, Jim Liu wrote: > > Hi Tom > > > > Thanks for your quick response. > > > > I add defconfig patch and found this build error and i2c naming issue. >

[PATCH v1] imx8: scu_api: sync sc_rm_is_pad_owned api change

2022-12-12 Thread Marcel Ziswiler
From: Ye Li SCFW has fixed a overflow issue in sc_rm_is_pad_owned API. This requires u-boot to update API implementation, since it will cause compatible issue. Otherwise all pad checking will have problem and cause pad setting not continue. Due to the compatible issue, the new u-boot only works

[PATCH 1/2] ARM: imx: bootaux: Fix macro misuse

2022-12-12 Thread Marek Vasut
There are no CONFIG_{TOOLS_,SPL_,TPL_,}IMX8M macros, nor is there one for ARM64. Use plain IS_ENABLED(CONFIG_IMX8M) and IS_ENABLED(CONFIG_ARM64) to avoid expanding the {TOOLS_,SPL_,TPL_,} part. Fixes: 56c2dbdabab5 ("imx: bootaux: cleanup code") Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot

[PATCH 2/2] ARM: imx: bootaux: Fix LTO -Wlto-type-mismatch

2022-12-12 Thread Marek Vasut
Commit 56c2dbdabab5 ("imx: bootaux: cleanup code") introduces the following LTO related warning: " arch/arm/mach-imx/imx_bootaux.c:24:31: warning: type of ‘hostmap’ does not match original declaration [-Wlto-type-mismatch] 24 | const __weak struct rproc_att hostmap[] = { }; |

Re: [PATCH v2] net: eth-uclass: revalidate priv after stop() in eth_halt()

2022-12-12 Thread Marek Vasut
On 12/12/22 16:29, Niel Fourie wrote: In eth_halt(), reread and revalidate priv after calling stop(), as it may have been freed, leaving a dangling pointer. In the ethernet gadget implementation, the gadget device gets probed during start() and removed during stop(), which includes freeing `ucla

Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2022-12-12 Thread Marek Vasut
On 12/12/22 16:29, Niel Fourie wrote: Split out _usb_eth_start() from _usb_eth_init() and usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init() only initialises and registers the gadget device, which _usb_eth_halt() reverses, and together are used for probing and removing the device. The _usb_

Re: [PATCH 1/1] cmd: change the return value when argc error

2022-12-12 Thread Simon Glass
On Sat, 10 Dec 2022 at 01:50, Shenlin Liang wrote: > > When the number of parameters is wrong, the return value should be processed > in > the same way as other cmds, return CMD_RET_USAGE so that it can print the > information. > > Signed-off-by: Shenlin Liang > --- > cmd/mvebu/comphy_rx_train

Re: [PATCH] serial: Do not write additional \r before \n for dm_serial drivers

2022-12-12 Thread Simon Glass
On Sun, 11 Dec 2022 at 12:28, Pali Rohár wrote: > > serial-uclass.c code already puts \r before \n for all dm_serial drivers. > > Signed-off-by: Pali Rohár > --- > drivers/serial/serial_lpuart.c | 3 --- > drivers/serial/serial_mpc8xx.c | 3 --- > 2 files changed, 6 deletions(-) > Reviewed-by:

Re: [PATCH] Makefile: With BINMAN_ALLOW_MISSING=1 don't error on missing

2022-12-12 Thread Simon Glass
Hi Tom, On Mon, 12 Dec 2022 at 16:43, Tom Rini wrote: > > On Tue, Dec 06, 2022 at 10:03:37AM -0500, Tom Rini wrote: > > On Tue, Dec 06, 2022 at 03:36:49PM +1300, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 6 Dec 2022 at 15:03, Tom Rini wrote: > > > > > > > > When the user builds with BI

Re: [PATCH] serial: ns16550: Enable clocks during probe

2022-12-12 Thread Stefan Roese
Hi Samuel, On 12/13/22 02:46, Samuel Holland wrote: On 12/12/22 12:54, Tom Rini wrote: On Sun, Nov 27, 2022 at 11:48:34PM -0600, Samuel Holland wrote: If the UART bus or baud clock has a gate, it must be enabled before the UART can be used. Signed-off-by: Samuel Holland Reviewed-by: Stefan

[PATCH v2] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-12-12 Thread Neha Malcom Francis
EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out whether addressing is 1-byte or 2-byte. There are currently different behaviours seen across boards as documented in commit bf6376642fe8 ("board: ti: common: board_detect: Fix EEPROM read quirk"). Adding to the list, we see that th

Re: [PATCH v5 1/3] efi_loader: Add SPI I/O protocol support

2022-12-12 Thread Ilias Apalodimas
Hi Paul, Apologies for the delayed reply. [...] > +static efi_status_t > +export_spi_peripheral(struct efi_spi_bus *bus, struct udevice *dev) > +{ > + efi_string_t name_utf16, vendor_utf16, part_number_utf16; > + struct efi_spi_peripheral_priv *priv; > + efi_status_t status; > +

Re: [PATCH 1/2] ARM: imx: bootaux: Fix macro misuse

2022-12-12 Thread Peng Fan
On 12/13/2022 12:46 PM, Marek Vasut wrote: There are no CONFIG_{TOOLS_,SPL_,TPL_,}IMX8M macros, nor is there one for ARM64. Use plain IS_ENABLED(CONFIG_IMX8M) and IS_ENABLED(CONFIG_ARM64) to avoid expanding the {TOOLS_,SPL_,TPL_,} part. Fixes: 56c2dbdabab5 ("imx: bootaux: cleanup code") Signe

Re: [PATCH 2/2] ARM: imx: bootaux: Fix LTO -Wlto-type-mismatch

2022-12-12 Thread Peng Fan
On 12/13/2022 12:46 PM, Marek Vasut wrote: Commit 56c2dbdabab5 ("imx: bootaux: cleanup code") introduces the following LTO related warning: " arch/arm/mach-imx/imx_bootaux.c:24:31: warning: type of ‘hostmap’ does not match original declaration [-Wlto-type-mismatch] 24 | const __weak stru

Re: [PATCH 1/2] pmic: pca9450: Make warm reset on WDOG_B assertion

2022-12-12 Thread Peng Fan
On 12/10/2022 3:35 AM, Marek Vasut wrote: The default configuration of the PMIC behavior makes the PMIC power cycle most regulators on WDOG_B assertion. This power cycling causes the memory contents of OCRAM to be lost. Some systems neeeds some memory that survives reset and reboot, therefore

Re: [PATCH 2/2] ARM: imx: Remove PMIC reset configuration from board files

2022-12-12 Thread Peng Fan
On 12/10/2022 3:35 AM, Marek Vasut wrote: The PCA9450 reset configuration can now be performed by the PCA9450 PMIC driver itself, remove the hard-coded variant from board code and let the PMIC driver perform this task using one-liner: ``` $ sed -i '/set WDOG_B_CFG to cold reset/,+2 d' $(git g

<    1   2