[PATCH v1] arm: relocate: Replace ADR instruction with non-pseudo-instruction

2022-07-10 Thread Jesse Taube
In Binutils 2.37 the ADR instruction has changed use alternate instructions. The change causes armv7-m to not boot. Signed-off-by: Jesse Taube --- arch/arm/lib/relocate.S | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/lib/relocate.S b/arch/arm/lib/relocate.S

Re: [PATCH v8 2/9] eficonfig: menu-driven addition of UEFI boot option

2022-07-10 Thread Heinrich Schuchardt
On 6/19/22 06:56, Masahisa Kojima wrote: This commit add the "eficonfig" command. The "eficonfig" command implements the menu-driven UEFI boot option maintenance feature. This commit implements the addition of new boot option. User can select the block device volume having efi_simple_file_system_

Re: [PATCH v8 3/9] eficonfig: add "Edit Boot Option" menu entry

2022-07-10 Thread Heinrich Schuchardt
On 6/19/22 06:56, Masahisa Kojima wrote: This commit adds the menu entry to edit the existing BOOT variable contents. User selects the item from the boot option list, then user can edit the description, file path and optional_data. Note that automatically generated boot option entry by bootm

Re: [PATCH v8 4/9] menu: add KEY_PLUS and KEY_MINUS handling

2022-07-10 Thread Heinrich Schuchardt
On 6/19/22 06:56, Masahisa Kojima wrote: This is preparation to support menu-driven UEFI BootOrder variable updated by KEY_PLUS and KEY_MINUS. Signed-off-by: Masahisa Kojima Reviewed-by: Heinrich Schuchardt

Re: [PATCH v8 1/9] efi_loader: expose END device path node

2022-07-10 Thread Heinrich Schuchardt
On 6/19/22 06:55, Masahisa Kojima wrote: This commit exposes the END device path node. Signed-off-by: Masahisa Kojima Reviewed-by: Heinrich Schuchardt --- No change in v8 Newly created in v7 include/efi_loader.h | 3 +++ lib/efi_loader/efi_device_path.c | 2 +- 2 files ch

Re: [RFC PATCH 1/3] eficonfig: add UEFI Secure Boot Key enrollment interface

2022-07-10 Thread Heinrich Schuchardt
On 7/8/22 11:14, Ilias Apalodimas wrote: On Sun, Jun 19, 2022 at 02:20:20PM +0900, Masahisa Kojima wrote: This commit adds the menu-driven UEFI Secure Boot Key enrollment interface. User can enroll the PK, KEK, db and dbx by selecting EFI Signature Lists file. After the PK is enrolled, UEFI Secu

Re: [PULL] u-boot-mips for u-boot/next (v2022.10)

2022-07-10 Thread Weijie Gao
Hi Daniel, This is my personal email address. I found that my previous mail send from my company was still be marked as spam by gmail. I've tested the latest fixups on u-boot-mips/next, and all is ok. thx. Best Regards, Weijie Daniel Schwierzeck 于2022年7月10日周日 00:23写道: > > > > On 09.07.22 14:43

Re: [RFC PATCH 3/3] eficonfig: add "Delete Key" menu entry

2022-07-10 Thread Heinrich Schuchardt
On 6/19/22 07:20, Masahisa Kojima wrote: This commit add the menu-driven interface to delete the signature database entry. EFI Signature Lists can contain the multiple signature entries, this menu can delete the indivisual entry. If the PK is enrolled and UEFI Secure Boot is in User Mode, Why

Re: [PATCH] mmc: fsl_esdhc: Fix 'Internal clock never stabilised.' error

2022-07-10 Thread Pali Rohár
PING? On Thursday 23 June 2022 18:11:37 Pali Rohár wrote: > On Tuesday 14 June 2022 11:25:18 Jaehoon Chung wrote: > > Hi, > > > > On 6/12/22 18:12, Pali Rohár wrote: > > > PING? > > > > Sorry for too late. > > When will be this fix patch processed and merged? > > > > > > > On Friday 29 April

Re: [PATCH 1/3] doc: environment: Drop u-boot_addr_r

2022-07-10 Thread Heinrich Schuchardt
On 6/20/22 16:31, Tom Rini wrote: This variable is never set nor explained why it would be set, drop it. Signed-off-by: Tom Rini Reviewed-by: Heinrich Schuchardt --- doc/usage/environment.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/usage/environment.rst b/doc/usage/enviro

Re: [PATCH 2/3] doc: environment: Expand on fdt_addr, initrd_addr and loadaddr

2022-07-10 Thread Heinrich Schuchardt
On 6/20/22 16:31, Tom Rini wrote: - Explain why fdt_addr and initrd_addr should not be set to disable relocation normally. - Provide some advice on the typical loadaddr default value. Signed-off-by: Tom Rini --- doc/usage/environment.rst | 15 --- 1 file changed, 12 insertions

[PATCH 1/2] ubifs: Fix ubifs_assert_cmt_locked()

2022-07-10 Thread Pali Rohár
U-Boot does not implement down_write_trylock() and its stub always returns true that lock was acquired. Therefore ubifs_assert_cmt_locked() assert currently always fails. Fix this issue by redefining ubifs_assert_cmt_locked() to just empty stub as there is nothing to assert. Signed-off-by: Pali R

[PATCH 2/2] ubifs: Use U-Boot assert() from in UBI/UBIFS code

2022-07-10 Thread Pali Rohár
U-Boot already provides assert function, so it use also in ubi and ubifs code. Signed-off-by: Pali Rohár --- drivers/mtd/ubi/debug.h | 9 ++--- fs/ubifs/debug.h| 9 ++--- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/mtd/ubi/debug.h b/drivers/mtd/ubi/deb

[PATCH 1/2] Fix usage of CONFIG_PREBOOT

2022-07-10 Thread Pali Rohár
Due to usage of PREBOOT in Kconfig, macro CONFIG_PREBOOT is always defined when CONFIG_USE_PREBOOT is enabled. In case CONFIG_PREBOOT is not explicitly enabled it is set to empty C string and therefore '#ifdef CONFIG_PREBOOT' guard does not work. Fix this issue by introducing a new Kconfig symbol P

[PATCH 2/2] Nokia RX-51: Remove CONFIG_PREBOOT from defconfig

2022-07-10 Thread Pali Rohár
CONFIG_PREBOOT just cause putting "preboot=CONFIG_PREBOOT" into env list. Value CONFIG_PREBOOT="run preboot" in defconfig is just nonsense and does not do anything useful (it is infinite recursion). Config file for this board already contains default preboot= env variable with correct value, which

Re: [PATCH 3/3] doc: environment: Further expand on Image locations and provide example

2022-07-10 Thread Heinrich Schuchardt
On 6/30/22 12:06, Simon Glass wrote: On Mon, 20 Jun 2022 at 08:32, Tom Rini wrote: Start by elaborating on what some of our constraints tend to be with image location values, and document where these external constraints come from. Provide a new subsection, an example based on the TI ARMv7 OM

[PATCH 1/1] dm: avoid NULL dereference in add_item()

2022-07-10 Thread Heinrich Schuchardt
acpi_add_other_item() passes dev = NULL. Instead of dev->name write the string "other" to the debug log: ACPI: Writing ACPI tables at 1fd3000 0base: writing table '' * other: Added type 3, 11fd4000, size 240 1facs: writing table 'FACS' * other: Added type 3, 11f

Re: [PATCH 2/3] doc: environment: Expand on fdt_addr, initrd_addr and loadaddr

2022-07-10 Thread Tom Rini
On Sun, Jul 10, 2022 at 01:02:28PM +0200, Heinrich Schuchardt wrote: > On 6/20/22 16:31, Tom Rini wrote: > > - Explain why fdt_addr and initrd_addr should not be set to disable > >relocation normally. > > - Provide some advice on the typical loadaddr default value. > > > > Signed-off-by: Tom R

[PATCH 1/1] efi_loader: memory leak in efi_set_bootdev()

2022-07-10 Thread Heinrich Schuchardt
efi_dp_str() allocates memory which should be released after use. Use %pD printf code. Adjust message wording. Fixes: d837cb1e3b6b ("efi: Add debugging to efi_set_bootdev()") Signed-off-by: Heinrich Schuchardt --- cmd/bootefi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

Re: [PATCH] mtd: spi-nor-ids: add winbond w25q512nw family support

2022-07-10 Thread Jae Hyun Yoo
Hello Jagan, On 7/9/2022 10:20 PM, Jagan Teki wrote: On Sat, Jul 9, 2022 at 12:10 AM Jae Hyun Yoo wrote: Add Winbond w25q512nwiq/in and w25q512nwim support. datasheet: https://www.winbond.com/resource-files/W25Q512NW%20RevB%2007192021.pdf Signed-off-by: Jae Hyun Yoo --- Applied to u-boot

[PATCH 0/4] Convert CONFIG_SYS_MIPS_TIMER_FREQ to Kconfig

2022-07-10 Thread Daniel Schwierzeck
This removes CONFIG_SYS_HZ and converts CONFIG_SYS_MIPS_TIMER_FREQ to Kconfig. The series only applies on u-boot-mips/next (based on u-boot/next and the Mediatek MT7621 series). Daniel Schwierzeck (4): MIPS: remove deprecated TARGET_VCT option MIPS: remove CONFIG_SYS_MHZ MIPS: mscc: remov

[PATCH 3/4] MIPS: mscc: remove unused CPU_CLOCK_RATE

2022-07-10 Thread Daniel Schwierzeck
CPU_CLOCK_RATE is just used once for CONFIG_SYS_MIPS_TIMER_FREQ which is migrated to Kconfig in the next patch. Signed-off-by: Daniel Schwierzeck --- include/configs/vcoreiii.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/configs/vcoreiii.h b/include/configs/vc

[PATCH 1/4] MIPS: remove deprecated TARGET_VCT option

2022-07-10 Thread Daniel Schwierzeck
This board has been removed a long time ago. Signed-off-by: Daniel Schwierzeck --- arch/mips/Kconfig | 8 1 file changed, 8 deletions(-) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 2e0793a7a7..8bef63cbb7 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -39,14 +39

[PATCH 2/4] MIPS: remove CONFIG_SYS_MHZ

2022-07-10 Thread Daniel Schwierzeck
Resolve all uses of CONFIG_SYS_MHZ with the currently defined value. Remove code which depends on CONFIG_SYS_MHZ but where no board configs actually use that code. Signed-off-by: Daniel Schwierzeck --- arch/mips/mach-jz47xx/include/mach/jz4780.h | 2 +- arch/mips/mach-jz47xx/jz4780/pll.c

[PATCH 4/4] MIPS: convert CONFIG_SYS_MIPS_TIMER_FREQ to Kconfig

2022-07-10 Thread Daniel Schwierzeck
This converts the following to Kconfig: CONFIG_SYS_MIPS_TIMER_REQ Signed-off-by: Daniel Schwierzeck --- arch/mips/Kconfig | 18 ++ configs/ap121_defconfig| 1 + configs/ap143_defconfig| 1 + conf

Re: [PATCH 3/3] doc: environment: Further expand on Image locations and provide example

2022-07-10 Thread Tom Rini
On Sun, Jul 10, 2022 at 02:26:04PM +0200, Heinrich Schuchardt wrote: > On 6/30/22 12:06, Simon Glass wrote: > > On Mon, 20 Jun 2022 at 08:32, Tom Rini wrote: > > > > > > Start by elaborating on what some of our constraints tend to be with > > > image location values, and document where these exte

Re: [PATCH 1/2] iommu: Add M2 support to Apple DART driver

2022-07-10 Thread Mark Kettenis
> From: Janne Grunau > Date: Fri, 1 Jul 2022 00:06:16 +0200 > > "apple,t8112-dart" uses an incompatible register interface but still > offers the same functionality. This DART is found on the M2 and M1 > Pro/Max/Ultra SoCs. > > Signed-off-by: Janne Grunau Reviewed-by: Mark Kettenis > --- >

Re: [PATCH 2/2] arm: apple: Add initial Apple M2 support

2022-07-10 Thread Mark Kettenis
> From: Janne Grunau > Date: Fri, 1 Jul 2022 00:06:17 +0200 > > Apple's M2 SoC very similar to the M1 and can use the same memory map. > The keyboard/trackpad on the MacBook Pro (13-inch, M2, 2022) uses > "dockchannel" as transport instead of SPI and needs a new driver. > USB, NVMe, uart, frameb

Re: [PATCH] mtd: spi-nor-ids: add winbond w25q512nw family support

2022-07-10 Thread Jagan Teki
On Sun, Jul 10, 2022 at 8:05 PM Jae Hyun Yoo wrote: > > Hello Jagan, > > On 7/9/2022 10:20 PM, Jagan Teki wrote: > > On Sat, Jul 9, 2022 at 12:10 AM Jae Hyun Yoo > > wrote: > >> > >> Add Winbond w25q512nwiq/in and w25q512nwim support. > >> > >> datasheet: > >> https://www.winbond.com/resource-fi

RE: [TF-A] [RFC] Proposed location to host the firmware handoff specification.

2022-07-10 Thread Jose Marinho
Hi Julius, Thanks for reviewing the draft proposal, and for your comments. Last year’s discussion concluded with the agreement that, as a next step, we would draft a proposal of the data structure [1]. That draft is the DEN0135 document [2]. I realise that I haven’t made it sufficiently explici

[PATCH 1/1] configs: sandbox_defconfig: CONFIG_LOG_MAX_LEVEL=9

2022-07-10 Thread Heinrich Schuchardt
Without setting CONFIG_LOG_MAX_LEVEL to a value above 6 we will not detect NULL dereferences and other errors in log_debug() calls. Signed-off-by: Heinrich Schuchardt --- configs/sandbox_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_d

Re: [PATCH 1/1] configs: sandbox_defconfig: CONFIG_LOG_MAX_LEVEL=9

2022-07-10 Thread Heinrich Schuchardt
On 7/10/22 21:31, Heinrich Schuchardt wrote: Without setting CONFIG_LOG_MAX_LEVEL to a value above 6 we will not detect NULL dereferences and other errors in log_debug() calls. Signed-off-by: Heinrich Schuchardt --- configs/sandbox_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff -

Re: [PATCH sunxi/next] spi: sunxi: use XCH status to detect in-progress transfer

2022-07-10 Thread Andre Przywara
On Tue, 28 Jun 2022 14:49:24 +0800 Icenowy Zheng wrote: Hi Icenowy, > The current detection of RX FIFO depth seems to be not reliable, and > XCH will self-clear when a transfer is done. many thanks for sending this, indeed what I put in -next is broken, probably for everything except the F1C100

Re: [PATCH v4] i2c: nuvoton: Add NPCM7xx i2c driver

2022-07-10 Thread Heiko Schocher
Hello Jim, On 23.06.22 07:31, Jim Liu wrote: > Add Nuvoton BMC NPCM750 i2c driver > > Signed-off-by: Jim Liu > --- > changes for v4: >- remove i2c doc > changes for v3: >- add i2c doc > Changes for v2: >- use debug output in reset function >- use clr/setbits_8 > --- > drivers/i2

Re: [PATCH] i2c: avoid dynamic stack use in dm_i2c_write

2022-07-10 Thread Heiko Schocher
Hello Rasmus, On 07.07.22 15:12, Rasmus Villemoes wrote: > The size of the dynamic stack allocation here is bounded by the if() > statement. However, just allocating the maximum size up-front and > doing malloc() if necessary avoids code duplication (the > i2c_setup_offset() until the invocation o

[PATCH 0/4] test: uncover NULL dereferences in logging

2022-07-10 Thread Heinrich Schuchardt
Setting CONFIG_LOG_MAX_LEVEL=9 in sandbox_defconfig exposed to NULL dereferences and bugs in the log tests. log_debug() statements are only executed for CONFIG_LOG_MAX_LEVEL > 6. We should have a defconfig that exposes problems in these statements. Heinrich Schuchardt (4): dm: avoid NULL derefe

[PATCH 1/4] dm: avoid NULL dereference in add_item()

2022-07-10 Thread Heinrich Schuchardt
acpi_add_other_item() passes dev = NULL. Instead of dev->name write the string "other" to the debug log: ACPI: Writing ACPI tables at 1fd3000 0base: writing table '' * other: Added type 3, 11fd4000, size 240 1facs: writing table 'FACS' * other: Added type 3, 11f

[PATCH 2/4] test: fix log tests

2022-07-10 Thread Heinrich Schuchardt
Consider CONFIG_LOG_MAX_LEVEL and gd->default_log_level in * do_log_test_helpers() * log_test_dropped() * log_test_level_deny() Signed-off-by: Heinrich Schuchardt --- test/log/log_test.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/test/log/log_test.c b/test/l

[PATCH 3/4] dm: avoid NULL dereference in lists_bind_fdt()

2022-07-10 Thread Heinrich Schuchardt
If parameter drv of lists_bind_fdt() is specified, we want to bind to this specific driver even if its field of_match is NULL. If entry->of_match is NULL, we should not dereference it in a debug statement. Fixes: d3e773613b6d ("dm: core: Use U-Boot logging instead of pr_debug()") Signed-off-by: H

[PATCH 4/4] configs: sandbox_defconfig: CONFIG_LOG_MAX_LEVEL=9

2022-07-10 Thread Heinrich Schuchardt
Without setting CONFIG_LOG_MAX_LEVEL to a value above 6 we will not detect NULL dereferences and other errors in log_debug() calls. Signed-off-by: Heinrich Schuchardt --- Resent --- configs/sandbox_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/sandbox_defconfig b/config

[PATCH 1/1] dm: fix logic of lists_bind_fdt()

2022-07-10 Thread Heinrich Schuchardt
If parameter drv of lists_bind_fdt() is specified, we shall bind only to this very driver and to no other. If the driver drv has an of_match property, we shall only bind to the driver if it matches the compatible string of the device. Signed-off-by: Heinrich Schuchardt --- drivers/core/lists.c

[PATCH V4 resend] spl: imx8mm: enlarge SPL_MAX_SIZE

2022-07-10 Thread Peng Fan (OSS)
From: Peng Fan The CONFIG_SPL_MAX_SIZE could be 0x27000 for i.MX8MM when SPL_TEXT_BASE set to 0x7E1000. The DDR firmware max uses 96KB, there is a 4KB padding header before SPL_TEXT_BASE, so the SPL MAX SIZE is `256KB - 96KB - 4KB`. Signed-off-by: Peng Fan --- V4 resend: Hi Stefano, this p

Re: [PATCH 3/3] doc: environment: Further expand on Image locations and provide example

2022-07-10 Thread Heinrich Schuchardt
On 7/10/22 18:17, Tom Rini wrote: On Sun, Jul 10, 2022 at 02:26:04PM +0200, Heinrich Schuchardt wrote: On 6/30/22 12:06, Simon Glass wrote: On Mon, 20 Jun 2022 at 08:32, Tom Rini wrote: Start by elaborating on what some of our constraints tend to be with image location values, and document w

RE: [v4 03/12] spi: aspeed: Add ASPEED SPI controller driver

2022-07-10 Thread Chin-Ting Kuo
Hi Cédric, > -Original Message- > From: Cédric Le Goater > Sent: Friday, July 8, 2022 4:52 PM > To: Chin-Ting Kuo ; Joel Stanley > > Subject: Re: [v4 03/12] spi: aspeed: Add ASPEED SPI controller driver > > On 7/8/22 07:42, Chin-Ting Kuo wrote: > > Hi Joel, > > > >> -Original Messag