Re: [PATCH v2 15/23] sunxi: Remove non-DM I2C clock/pin setup from U-Boot

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:12 -0500 Samuel Holland wrote: > This is now handled automatically by the clock and pinctrl drivers. > > SPL still calls this function because it needes the non-DM code. > > Signed-off-by: Samuel Holland Looks good, but needs some testing to see if really cover all t

Re: [PATCH v2 07/23] pinctrl: sunxi: Add sun4i EMAC pinmuxes

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:04 -0500 Samuel Holland wrote: > Pin lists and mux values were taken from the Linux drivers. > > Signed-off-by: Samuel Holland Compared against the respective manuals. Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > drivers/pinctrl

Re: [PATCH v2 10/23] sunxi: Remove non-DM GMAC pin setup

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:07 -0500 Samuel Holland wrote: > This is now handled automatically by the pinctrl driver. > > Signed-off-by: Samuel Holland Yeah! Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > arch/arm/include/asm/arch-sunxi/gpio.h | 2 - > boar

Re: [PATCH v2 18/23] pinctrl: sunxi: Add MMC pinmuxes

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:15 -0500 Samuel Holland wrote: > Pin lists and mux values were taken from the Linux drivers. > > Signed-off-by: Samuel Holland Compared against the respective manuals: Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > drivers/pinctrl

Re: [PATCH v2 05/23] pinctrl: sunxi: Add UART pinmuxes

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:02 -0500 Samuel Holland wrote: > This includes UART0 and R_UART (s_uart) on all supported platforms, plus > the additional UART configurations from arch/arm/mach-sunxi/board.c. > > Pin lists and mux values were taken from the Linux drivers. > > Signed-off-by: Samuel Ho

Re: [PATCH v8 15/15] cmd: bootm: add subcommand preload

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:57:07PM +0200, Philippe Reynes wrote: > Add a subcommand preload to bootm that execute the preload > stage on the image. Right now, it checks the signature > of the image with the pre-load header. If the check > succeed, the u-boot env variable 'loadaddr_verified' > is s

Re: [PATCH v2 08/23] net: sunxi_emac: Remove non-DM pin setup

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:05 -0500 Samuel Holland wrote: > This is now handled automatically by the pinctrl driver. > > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > arch/arm/include/asm/arch-sunxi/gpio.h | 1 - > drivers/net/

Re: [PATCH v2 21/23] pwm: sunxi: Remove non-DM pin setup

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:18 -0500 Samuel Holland wrote: > This is now handled automatically by the pinctrl driver. > > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > arch/arm/include/asm/arch-sunxi/gpio.h | 1 - > drivers/pwm

Re: [PATCH v2 11/23] pinctrl: sunxi: Add sun8i EMAC pinmuxes

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:08 -0500 Samuel Holland wrote: > Pin lists and mux values were taken from the Linux drivers. > > Signed-off-by: Samuel Holland Compared against the respective manuals. Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > drivers/pinctrl

Re: [PATCH v2 19/23] sunxi: Remove non-DM MMC pin setup

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:16 -0500 Samuel Holland wrote: > This is now handled automatically by the pinctrl driver. > > Signed-off-by: Samuel Holland The comment was slightly wrong, this function really only does pinmux setup, and doesn't touch any clocks. So this is fine now: Reviewed-by: An

Re: [PATCH v2 16/23] i2c: sun6i_p2wi: Only do non-DM pin setup for non-DM I2C

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:13 -0500 Samuel Holland wrote: > When the DM_I2C driver is loaded, the pin setup is done automatically > from the device tree by the pinctrl driver. > > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > d

Re: [PATCH v2 22/23] pinctrl: sunxi: Add SPI0 pinmuxes

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:19 -0500 Samuel Holland wrote: > Pin lists and mux values were taken from the Linux drivers. > > Signed-off-by: Samuel Holland Compared against the respective manuals: Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > drivers/pinctrl

Re: [PATCH v2 06/23] sunxi: Skip non-DM UART pin setup when PINCTRL=y

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:03 -0500 Samuel Holland wrote: Hi Samuel, > When a pinctrl driver is available, it will take care of setting up > these pins. However, for now this code is still needed in SPL. > > Reviewed-by: Simon Glass > Signed-off-by: Samuel Holland > --- > > (no changes since

[RFC PATCH v3 04/23] test/py: hush_if_test: Remove the test file

2022-03-31 Thread Francis Laniel
ce40f44eb336 ("test: hush: Test hush if/else") translated this test to a C test, so this python file is no more needed. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- test/py/tests/test_hush_if_test.py | 184 - 1 file changed, 184 deletions(-) delete mod

[RFC PATCH v3 05/23] test: hush: Test hush variable expansion

2022-03-31 Thread Francis Laniel
Verifies shell variables are replaced by their values. Signed-off-by: Francis Laniel --- test/hush/Makefile | 1 + test/hush/dollar.c | 175 + 2 files changed, 176 insertions(+) create mode 100644 test/hush/dollar.c diff --git a/test/hush/Makefile

[RFC PATCH v3 16/23] cli: add hush 2021 as parser for run_command*().

2022-03-31 Thread Francis Laniel
Enables using, in code, hush 2021 as parser for run_command function family. It also enables the command run to be used by CLI user of hush 2021. Signed-off-by: Francis Laniel --- common/cli.c | 60 -- common/cli_hush_upstream.c | 2 +- 2 files

[RFC PATCH v3 18/23] test: hush: Fix variable expansion tests for hush 2021

2022-03-31 Thread Francis Laniel
Modifies the expected result for hush 2021. Indeed, there were bugs in actual U-Boot hush which were fixed in upstream Busybox. As hush 2021 is based on upstream Busybox, these bugs no longer exist. Signed-off-by: Francis Laniel --- test/hush/dollar.c | 79 +++

[RFC PATCH v3 21/23] test: hush: Fix if tests for hush 2021

2022-03-31 Thread Francis Laniel
Modifies the command run for hush 2021 when using string comparison operator. Indeed, '<' and '>' must be escaped to be used as these operators. Signed-off-by: Francis Laniel --- test/hush/if.c | 45 + 1 file changed, 45 insertions(+) diff --git a/tes

[RFC PATCH v3 19/23] cli: hush_2021: Enable using \< and \> as string compare operators

2022-03-31 Thread Francis Laniel
In Busybox hush, '<' and '>' are used as redirection operators. For example, cat foo > bar will write content of file foo inside file bar. In U-Boot, we do not have file system, so we can hardly redirect command output inside a file. But, in actual U-Boot hush, these operators ('<' and '>') are us

Re: [PATCH v2 20/23] pinctrl: sunxi: Add the A64 PWM pinmux

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:17 -0500 Samuel Holland wrote: > This is the only possible mux setting for the A64's PWM peripheral. > > Signed-off-by: Samuel Holland Compared against the manual: Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > drivers/pinctrl/su

Re: [PATCH v2 12/23] net: sun8i_emac: Remove non-DM pin setup

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:09 -0500 Samuel Holland wrote: > This is now handled automatically by the pinctrl driver. > > Signed-off-by: Samuel Holland Love that diffstat! Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > drivers/net/sun8i_emac.c | 90 -

Re: [PATCH v2 09/23] pinctrl: sunxi: Add sunxi GMAC pinmuxes

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:06 -0500 Samuel Holland wrote: > Pin lists and mux values were taken from the Linux drivers. > > Signed-off-by: Samuel Holland Compared against the respective manuals. Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > drivers/pinctrl

[RFC PATCH v3 00/23] Modernize U-Boot shell

2022-03-31 Thread Francis Laniel
Hi. First I hope you are fine and the same for your relatives. I would also like to apologize for the delay between v2 and v3. During 2021 summer, Sean Anderson wrote a contribution to add a new shell, based on LIL, to U-Boot [1][2]. While one of the goals of this contribution was to address the

[RFC PATCH v3 10/23] cli: Add menu for hush parser

2022-03-31 Thread Francis Laniel
For the moment, the menu contains only entry: HUSH_OLD_PARSER which is the default. The goal is to prepare the field to add a new hush parser which guarantees actual behavior is still correct. Signed-off-by: Francis Laniel --- cmd/Kconfig | 21 + common/Makefile | 3 ++-

[RFC PATCH v3 17/23] test: hush: Fix instructions list tests for hush 2021

2022-03-31 Thread Francis Laniel
Modifies the expected result for hush 2021. Indeed, there were bugs in actual U-Boot hush which were fixed in upstream Busybox. As hush 2021 is based on upstream Busybox, these bugs no longer exist. Signed-off-by: Francis Laniel --- test/hush/list.c | 69 +

[RFC PATCH v3 11/23] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag.

2022-03-31 Thread Francis Laniel
This flag is used to indicate we are using the hush parser. Signed-off-by: Francis Laniel --- common/cli.c | 2 ++ include/asm-generic/global_data.h | 4 2 files changed, 6 insertions(+) diff --git a/common/cli.c b/common/cli.c index a7e3d84b68..ef967f4f9e 100644 --- a

[RFC PATCH v3 12/23] cmd: Add new parser command.

2022-03-31 Thread Francis Laniel
This command can be used to print the current parser with 'parser print'. It can also be used to set the current parser with 'parser set'. For the moment, only one value is valid for set: old. Signed-off-by: Francis Laniel --- cmd/Makefile | 2 + cmd/parser.c | 113

[RFC PATCH v3 23/23] test: hush: Fix loop tests for hush 2021

2022-03-31 Thread Francis Laniel
Modifies return code got from while loop as hush 2021 always returns 0 from while loop. Signed-off-by: Francis Laniel --- test/hush/loop.c | 34 ++ 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/test/hush/loop.c b/test/hush/loop.c index 519c78ef7e.

[RFC PATCH v3 20/23] cli: hush_2021: Enable if keyword

2022-03-31 Thread Francis Laniel
Adds support for "if then else" construct both for command line interface and through run_command(). Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- common/cli_hush_upstream.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/common/cli_hush_upstream.c b/

[RFC PATCH v3 22/23] cli: hush_2021: Enable loops

2022-03-31 Thread Francis Laniel
Enables the use of for, while and until loops for command line as well as with run_command(). Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- common/cli_hush_upstream.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/common/cli_hush_upstream.c b/co

[RFC PATCH v3 13/23] cli: Enables using hush 2021 parser as command line parser

2022-03-31 Thread Francis Laniel
If one defines HUSH_2021_PARSER, it is then possible to use 2021 parser with: => parser print old => parser set 2021 2021> parser get 2021 Signed-off-by: Francis Laniel --- cmd/parser.c | 14 - common/cli.c | 38 include/

[RFC PATCH v3 06/23] test: hush: Test hush commands list

2022-03-31 Thread Francis Laniel
Verifies behavior of commands separated by ';', '&&' and '||'. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- test/hush/Makefile | 1 + test/hush/list.c | 79 ++ 2 files changed, 80 insertions(+) create mode 100644 test/hush/list.c di

[RFC PATCH v3 09/23] cli: Port Busybox 2021 hush to U-Boot

2022-03-31 Thread Francis Laniel
Adds new file cli_hush_2021.c, it is a copy of Busybox hush file as it was of time to commit 37460f5da. This commit modifies Busybox hush to not compile some part specific to Busybox and adds some code needed by U-Boot. The modifications consists mainly on adding code #if(n)def guards. For the mom

[RFC PATCH v3 14/23] cli: hush_2021: Enable variables expansion for hush 2021

2022-03-31 Thread Francis Laniel
Enables variables expansion for hush 2021, both for local and environment variables. So the following commands: foo=bar echo $foo setenv bar foo echo $bar leads to "bar" and "foo" being printed on console output. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- common/cli_hush_2021.c

[RFC PATCH v3 01/23] video: sandbox: Add dummy function for sandbox_sdl_remove_display().

2022-03-31 Thread Francis Laniel
We need to defined a dummy version of this function when compiling with NO_SDL=1. Otherwise, we would face compilation error. Fixes: 250e735c692b ("video: sandbox: Avoid duplicate display windows") Signed-off-by: Francis Laniel --- arch/sandbox/include/asm/sdl.h | 5 + 1 file changed, 5 inse

[RFC PATCH v3 07/23] test: hush: Test hush loops

2022-03-31 Thread Francis Laniel
The added tests verifies correct behavior of for, while and until loops. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- test/hush/Makefile | 1 + test/hush/loop.c | 64 ++ 2 files changed, 65 insertions(+) create mode 100644 test/hush/

[RFC PATCH v3 03/23] test: hush: Test hush if/else

2022-03-31 Thread Francis Laniel
As asked in 9c6bf1715f6a ("test/py: hush_if_test: Add tests to cover octal/hex values"), this commit translates test_hush_if_test.py to a C test. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- test/hush/Makefile | 1 + test/hush/if.c | 308 +

[RFC PATCH v3 15/23] cli: hush_2021: Add functions to be called from run_command()

2022-03-31 Thread Francis Laniel
run_command() is called internally by the command run and it can also be called directly from U-Boot code, e.g. to do unit tests. This commit adds this path to go to hush 2021. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- common/cli_hush_upstream.c | 66 +++

[RFC PATCH v3 02/23] test: Add framework to test hush behavior

2022-03-31 Thread Francis Laniel
Introduce a new subcommand to ut: ut hush. For the moment, this command does nothing, future commits will add tests which will be run on command call. Note that CONFIG_HUSH_PARSER must be defined to compile this new subcommand. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- include

Re: [PATCH v2 02/23] sunxi: pinctrl: Implement pin muxing functions

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:53:59 -0500 Samuel Holland wrote: Hi Samuel, > Implement the operations to get pin and function names, and to set the > mux for a pin. The pin count and pin names are calculated as if each > bank has the maximum number of pins. Function names are simply the index > into a

Re: [PATCH v2 03/23] sunxi: pinctrl: Implement get_pin_muxing function

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:00 -0500 Samuel Holland wrote: > The pinmux command uses this function to display pinmux status. > > Since the driver cannot map pin numbers to a list of supported > functions, only functions which are common across all pins can be > reported by name. > > Signed-off-by

Re: [PATCH v2 06/23] sunxi: Skip non-DM UART pin setup when PINCTRL=y

2022-03-31 Thread Samuel Holland
On 3/31/22 6:19 PM, Andre Przywara wrote: > On Thu, 17 Mar 2022 22:54:03 -0500 > Samuel Holland wrote: > > Hi Samuel, > >> When a pinctrl driver is available, it will take care of setting up >> these pins. However, for now this code is still needed in SPL. >> >> Reviewed-by: Simon Glass >> Sign

Re: [PATCH v2 15/23] sunxi: Remove non-DM I2C clock/pin setup from U-Boot

2022-03-31 Thread Samuel Holland
On 3/31/22 6:20 PM, Andre Przywara wrote: > On Thu, 17 Mar 2022 22:54:12 -0500 > Samuel Holland wrote: > >> This is now handled automatically by the clock and pinctrl drivers. >> >> SPL still calls this function because it needes the non-DM code. >> >> Signed-off-by: Samuel Holland > > Looks go

Re: [PATCH v2 17/23] i2c: sun8i_rsb: Only do non-DM pin setup for non-DM I2C

2022-03-31 Thread Samuel Holland
On 3/31/22 6:20 PM, Andre Przywara wrote: > On Thu, 17 Mar 2022 22:54:14 -0500 > Samuel Holland wrote: > >> When the DM_I2C driver is loaded, the pin setup is done automatically >> from the device tree by the pinctrl driver. >> >> Clean up the code in the process: remove #ifdefs and recognize tha

Re: [PATCH] env: Avoid using a leftover text-environment file

2022-03-31 Thread Sean Anderson
Hi Tom, On 3/12/22 12:37 AM, Simon Glass wrote: If include/generated/environment.h exists (perhaps leftover from a build of another board) it is used, even if the board currently being built does not have a text environment. This causes a build error. Fix it by emptying the file if it should no

[PATCH] power_domain: Add power_domain_get_by_name()

2022-03-31 Thread Marek Vasut
Implement power_domain_get_by_name() convenience function which parses DT property 'power-domain-names' and looks up power domain by matching name. Signed-off-by: Marek Vasut Cc: Patrick Delaunay Cc: Simon Glass --- drivers/power/domain/power-domain-uclass.c | 14 ++ include/power-

[PATCH] imx: power-domain: Add i.MX8MP support

2022-03-31 Thread Marek Vasut
Add i.MX8MP power domain handling into the driver. This is based on the Linux GPCv2 driver state which is soon to be in Linux next. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- drivers/power/domain/imx8m-power-domain.c | 79 +++ include/d

[PATCH] imx: power-domain: Add i.MX8MP HSIOMIX driver

2022-03-31 Thread Marek Vasut
Add trivial driver for i.MX8MP HSIOMIX handling. This is responsible for enabling the GPCv2 power domains and clock for USB 3.0 and PCIe in the correct order. Currently supported is the USB 3.0 part which can be tested, PCIe support should be easy to add. Signed-off-by: Marek Vasut Cc: Fabio Este

[PATCH] clk: imx8mp: Fill in DWC3 USB, USB PHY, HSIOMIX clock

2022-03-31 Thread Marek Vasut
Add clock tables required to bring up DWC3 USB, USB PHY and HSIOMIX domain. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- drivers/clk/imx/clk-imx8mp.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/clk/imx/clk-imx8mp.c b/dri

Pull request for efi-2022-04-rc6

2022-03-31 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit 64b78f5721e65e96ea5a3d100d46b2e6fda722df: Merge branch '2022-03-31-critical-fixes' (2022-03-31 08:28:43 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2022-04-rc6 for you to fetch

[PATCH] phy: phy-imx8mq-usb: Add support for i.MX8MP USB PHY

2022-03-31 Thread Marek Vasut
Add initial support for i.MX8MP USB PHY, i.MX8MP USB is similar to the i.MX8MQ, except for clock and power domain design customization. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- drivers/phy/Kconfig | 6 ++-- drivers/phy/phy-imx8mq-usb.c | 66 +++

Re: [PATCH] env: Avoid using a leftover text-environment file

2022-03-31 Thread Tom Rini
On Fri, Mar 11, 2022 at 10:37:23PM -0700, Simon Glass wrote: > If include/generated/environment.h exists (perhaps leftover from a build > of another board) it is used, even if the board currently being built does > not have a text environment. > > This causes a build error. Fix it by emptying the

Re: [EXT] [PATCH] clk: imx8mp: Fill in DWC3 USB, USB PHY, HSIOMIX clock

2022-03-31 Thread Ye Li
On Fri, 2022-04-01 at 03:17 +0200, Marek Vasut wrote: > Caution: EXT Email > > Add clock tables required to bring up DWC3 USB, USB PHY and HSIOMIX > domain. > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Peng Fan > Cc: Stefano Babic > --- >  drivers/clk/imx/clk-imx8mp.c | 20 +++

Re: [PATCH v4 05/11] efi_loader: export efi_locate_device_handle()

2022-03-31 Thread Ilias Apalodimas
On Thu, Mar 24, 2022 at 10:54:37PM +0900, Masahisa Kojima wrote: > From: AKASHI Takahiro > > This function will be used in the next commit where some behavior > of EFI boot manager will be expanded. > > Signed-off-by: AKASHI Takahiro > --- > No changes from original version > > include/efi_lo

Re: [PATCH v4 07/11] bootmenu: add UEFI and disto_boot entries

2022-03-31 Thread Ilias Apalodimas
Hi Kojima-san, [...] > + entry->title = u16_strdup(lo.label); > + if (!entry->title) { > + free(load_option); > + free(entry); We need to free bootorder as well > + return

Re: [PATCH v4 4/8] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-03-31 Thread Sughosh Ganu
hi Ilias, On Fri, 1 Apr 2022 at 01:05, Ilias Apalodimas wrote: > > Hi Sughosh, > > Some nots below > > On Thu, Mar 31, 2022 at 06:57:46PM +0530, Sughosh Ganu wrote: > > Currently, there are a bunch of boards which enable the UEFI capsule > > update feature. The actual update of the firmware image

<    1   2