Re: [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type

2022-03-14 Thread Bin Meng
On Sun, Mar 13, 2022 at 2:03 PM Simon Glass wrote: > > This enum is currently anonymous. Add a name so it can be used in the > code. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: > - Add some comments for the enum > > arch/x86/include/asm/intel_gnvs.h | 8 +

Re: [PATCH v2 2/2] x86: Correct the coreboot header file in MAINTAINERS

2022-03-14 Thread Bin Meng
On Sun, Mar 13, 2022 at 2:04 PM Simon Glass wrote: > > This board has its own config header file. Correct it. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > (no changes since v1) > > board/coreboot/coreboot/MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-

Re: [PATCH v2] usb: dwc3: Add support to reset usb ULPI phy

2022-03-14 Thread Bin Meng
On Fri, Mar 4, 2022 at 8:48 PM Michal Simek wrote: > > From: T Karthik Reddy > > When usb PHY initialization is done, the PHY need to be reset. > > Signed-off-by: T Karthik Reddy > Signed-off-by: Michal Simek > --- > > Changes in v2: > - Remove EBUSY checking which is not needed. Reported by Bi

Re: [PATCH v3 1/2] generic-phy: s/CONFIG_PHY/CONFIG_IS_ENABLED(PHY)/

2022-03-14 Thread Bin Meng
On Wed, Mar 9, 2022 at 5:06 PM Michal Simek wrote: > > Allow to disable PHY driver in SPL because it checks the CONFIG_SPL_PHY > variable for SPL builds. > > The same change was done for usb by commit fd09c205fc57 ("usb: > s/CONFIG_DM_USB/CONFIG_IS_ENABLED(DM_USB)/"). > > Signed-off-by: Michal Sim

Re: [PATCH v3 2/2] usb: dwc3: Add support for usb3-phy PHY configuration

2022-03-14 Thread Bin Meng
On Wed, Mar 9, 2022 at 5:06 PM Michal Simek wrote: > > When usb3-phy label is found, PHY driver is called and serdes line is > initialized. This is preparation for serdes/psgtr driver to configure GT > lines based on description in DT. > > Signed-off-by: Michal Simek > --- > > Changes in v3: > -

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-03-14 Thread Masami Hiramatsu
Hi Simon, 2022年3月14日(月) 15:45 Simon Glass : > > Hi Takahiro, > > On Sun, 13 Mar 2022 at 20:43, AKASHI Takahiro > wrote: > > > > On Sun, Mar 13, 2022 at 08:15:02PM -0600, Simon Glass wrote: > > > Hi Takahiro, > > > > > > On Sun, 13 Mar 2022 at 19:08, AKASHI Takahiro > > > wrote: > > > > > > > > H

Re: [PATCH] Enable USB mass storage on Renegade

2022-03-14 Thread Kever Yang
Hi Leonidas, Thanks for your patch, please update the subject with below tags like: rockchip: rk3328: Thanks, - Kever Leonidas P. Papadakos 于2021年12月25日周六 21:57写道: > > This is very useful to access the LibreComputer eMMC as removable > storage from a PC (e.g. like so `ums 0 mmc 0`). It has b

Re: [PATCH] arm: dts: rk3399-puma: re-add vdd_log for uboot

2022-03-14 Thread Kever Yang
Hi Heiko, Heiko Stuebner 于2021年12月26日周日 20:46写道: > > The rk3399-puma board needs a 950mV vdd_log to work stable. > This was already added in > commit 77012e79ffc3 ("rockchip: rk3399-puma: Set VDD_LOG to 950 mV") > but lost again with > commit 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from

Re: [PATCH] rockchip: ram: sdram_rk3x88: replace comma by semicolon

2022-03-14 Thread Kever Yang
Hi Johan, Johan Jonker 于2022年1月13日周四 00:32写道: > > A comma at the end of a line gives sometimes strange > effects in combination with some code formatters, > so replace a comma by a semicolon in the sdram_rk3188.c > and sdram_rk3288.c files. > > Signed-off-by: Johan Jonker Reviewed-by: Kever Yan

Re: [PATCH] include: configs: move USB first in the boot order for rk3399

2022-03-14 Thread Kever Yang
Hi Dan, Thanks for your patch. Most of the board would like to boot from SD->MMC->NVME, only if there no firmware found in the onboard storage, them the U-Boot try with USB or network. So I'm afraid this patch can not be applied. Thanks, - Kever Dan Johansen 于2022年1月28日周五 05:56写道: >

Re: [PATCH] rockchip: Set default LNX_KRNL_IMG_TEXT_OFFSET_BASE to SYS_TEXT_BASE

2022-03-14 Thread Kever Yang
Hi Alper, Alper Nebi Yasak 于2022年1月29日周六 23:28写道: > > U-Boot can be chainloaded from vendor firmware on ARM64 chromebooks from > a GPT partition (roughly the same as in doc/chromium/chainload.rst), but > an appropriate image header must be built-in to the U-Boot binary by > enabling LINUX_KERNEL_

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-03-14 Thread AKASHI Takahiro
On Mon, Mar 14, 2022 at 04:35:45PM +0900, Masami Hiramatsu wrote: > Hi Simon, > > 2022年3月14日(月) 15:45 Simon Glass : > > > > Hi Takahiro, > > > > On Sun, 13 Mar 2022 at 20:43, AKASHI Takahiro > > wrote: > > > > > > On Sun, Mar 13, 2022 at 08:15:02PM -0600, Simon Glass wrote: > > > > Hi Takahiro, >

Re: [PATCH] drivers/adc/rockchip-saradc: remove double semi-colon

2022-03-14 Thread Kever Yang
Hi Giulio, Thanks for your patch, it's a good catching. Could you please update the subject with "rockchip: adc: ", and add a simple description in the commit message? Empy commit message is not allowed according to U-Boot patch commit rules :( Thanks, - Kever Giulio Benetti 于2022年2月4日周

Re: [PATCH v2] adc: rockchip-saradc: add support for getting reference voltage value

2022-03-14 Thread Kever Yang
Hi Peter, Peter Cai 于2022年2月5日周六 21:49写道: > > Mirroring commit 97ab802aa36f ("adc: meson-saradc: add support for > getting reference voltage value") for meson-saradc, this adds support > for getting the "vref-supply" regulator and register it as the ADC's > reference voltage regulator, so clients

Re: [PATCH 1/2] arm64: dts: rk3399-rock-pi-4b-u-boot: add optee node

2022-03-14 Thread Kever Yang
Hi Peter, Peter Griffin 于2022年2月22日周二 00:10写道: > > Allow u-boot to probe optee so we can access secure os > from the bootloader. > > Signed-off-by: Peter Griffin Reviewed-by: Kever Yang Thanks, - Kever > --- > arch/arm/dts/rk3399-rock-pi-4b-u-boot.dtsi | 10 ++ > 1 file changed, 10 i

Re: [PATCH 2/2] configs: rock-pi-4: Enable OP-TEE secure os support

2022-03-14 Thread Kever Yang
Hi Peter, Thanks for your patch, could you add a description in the commit message about why do we need to enable OPTEE in U-Boot, I think this is the first commit for RK3399 to enable OPTEE. Thanks, - Kever Peter Griffin 于2022年2月22日周二 00:13写道: > > Signed-off-by: Peter Griffin > --- > conf

[PATCH 1/2] board: tbs2910: Enable Link Time Optimizations in defconfig

2022-03-14 Thread Soeren Moch
This saves about 12 kBytes image size and helps to stay within the size limit. Suggested-by: Tom Rini Signed-off-by: Soeren Moch --- Cc: Stefano Babic Cc: Fabio Estevam Cc: Simon Glass Cc: u-boot@lists.denx.de Unfortunately we already are at the size limit for U-Boot v2022.04-rc3. Maybe Tom

[PATCH 2/2] board: tbs2910: Convert to DM_SERIAL

2022-03-14 Thread Soeren Moch
... to get rid of the build warning. Unfortunately we still need the board specific serial pin init code. Otherwise the first boot messages over the serial console are lost. Signed-off-by: Soeren Moch --- Cc: Stefano Babic Cc: Fabio Estevam Cc: Tom Rini Cc: Simon Glass Cc: u-boot@lists.denx.d

Re: [PATCH v3 00/19] efi_loader: more tightly integrate UEFI disks to driver model

2022-03-14 Thread Soeren Moch
Hi Simon, On 12.03.22 06:02, Simon Glass wrote: Hi Soeren, On Fri, 11 Mar 2022 at 15:43, Soeren Moch wrote: On 09.03.22 16:33, Simon Glass wrote: Hi Tom, On Wed, 9 Mar 2022 at 07:25, Tom Rini wrote: On Tue, Mar 08, 2022 at 08:10:38PM -0700, Simon Glass wrote: Hi Tom, On Tue, 8 Mar 202

Re: [PATCH v1 02/11] mmc: sdhci: allow disabling sdma in spl

2022-03-14 Thread Kever Yang
Hi Peter, On 2022/2/22 09:31, Peter Geis wrote: Rockchip emmc devices have a similar issue to Rockchip dwmmc devices, where performing dma to sram causes errors with suspend/resume. Allow us to toggle sdma in spl for sdhci similar to adma support, so we can ensure dma is not used when loading t

Re: [PATCH v1 03/11] spi: rockchip-sfc: fix building rockchip-sfc

2022-03-14 Thread Kever Yang
Hi Peter, On 2022/2/22 09:31, Peter Geis wrote: The rockchip-sfc driver is missing an include to build correctly. I think this driver builds OK and has been tested by other developer, could you share what kind of build environment do you using and what issue did you meet? Thanks, - Keve

Re: [PATCH v1 01/11] clk: rockchip: rk3568: fix reset handler

2022-03-14 Thread Kever Yang
Hi Peter, On 2022/2/22 09:31, Peter Geis wrote: The reset handler for rk3568 is missing its private data. This leads to an abort when a reset is triggered. Add the missing dev_set_priv to the rk3568 clk driver. Fixes: 4a262feba3a5 ("rockchip: rk3568: add clock driver") Signed-off-by: Peter G

Re: [PATCH v1 08/11] rockchip: rk3568: enable automatic clock gating

2022-03-14 Thread Kever Yang
Hi Peter, On 2022/2/22 09:31, Peter Geis wrote: Enable automatic clock gating on rk3568, which solves a 7c temperature difference on SoQuartz compared to downstream. Signed-off-by: Peter Geis Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/rk3568/rk3568.c | 23 +

Re: [PATCH v1 04/11] spi: rockchip-sfc: sanity check minimum freq

2022-03-14 Thread Kever Yang
+ Jon Lin, Hi Jon,     Please help to review this patch. Thanks, - Kever On 2022/2/22 09:31, Peter Geis wrote: The rockchip-sfc driver sanity checks the maximum frequency, but not the minimum frequency. This causes the probe to fail when a frequency isn't defined, such as with `sf probe 0`. C

Re: [PATCH v1 00/11] rockchip fixes and extend rk3568 support

2022-03-14 Thread Kever Yang
Hi Peter,     Thanks for your patchset.     Seems like some of the driver module author does not include in the patch cc list, I would suggest you to use scripts/get_maintainer.pl instead of add cc manually tools/patman/patman is a very wonderful tool, you can have a try :) Thanks, - Keve

Re: [PATCH v1 00/11] rockchip fixes and extend rk3568 support

2022-03-14 Thread Jagan Teki
On Tue, Feb 22, 2022 at 7:02 AM Peter Geis wrote: > > to: Simon Glass > to: Philipp Tomsich > to: Kever Yang > to: Lukasz Majewski > to: Sean Anderson > to: Peng Fan > to: Jaehoon Chung > to: Heiko Stübner > cc: u-boot@lists.denx.de > > Good Evening, > > The following is a few patches for

Re: [PATCH v1 06/11] rockchip: handle bootrom recovery mode in spl

2022-03-14 Thread Kever Yang
Hi Peter, On 2022/2/22 09:31, Peter Geis wrote: Fixup the bootrom recovery mode code to function in spl, so we can handle recovery mode in case u-boot loading is broken. I don't understand what do you mean about "Fixup the bootrom recovery mode code"? I would like to make SPL simple and small e

[PATCH v2] rockchip: saradc: remove double semi-colon

2022-03-14 Thread Giulio Benetti
Remove double semi-colon that has been forgotten while adding the driver. This is only a style fix since it doesn't change the functionality of the driver. Signed-off-by: Giulio Benetti --- V1->V2: * Improved commit log as suggested by Kever Yang --- drivers/adc/rockchip-saradc.c | 2 +- 1 file

Re: [PATCH] drivers/adc/rockchip-saradc: remove double semi-colon

2022-03-14 Thread Giulio Benetti
On 14/03/22 09:04, Kever Yang wrote: Hi Giulio, Thanks for your patch, it's a good catching. Could you please update the subject with "rockchip: adc: ", and add a simple description in the commit message? Empy commit message is not allowed according to U-Boot patch commit rules :( Oh

Re: [PATCH v2] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON when necessary

2022-03-14 Thread Jaehoon Chung
On 3/10/22 01:10, Tom Rini wrote: > On Tue, Feb 22, 2022 at 11:28:18AM +0800, haibo.c...@nxp.com wrote: > >> From: Haibo Chen >> >> After commit f132aab40327 ("Revert "mmc: fsl_esdhc_imx: use >> VENDORSPEC_FRC_SDCLK_ON to control card clock output""), it >> involve issue in mmc_switch_voltage(),

Re: [PATCH v2] rockchip: saradc: remove double semi-colon

2022-03-14 Thread Kever Yang
On 2022/3/14 17:09, Giulio Benetti wrote: Remove double semi-colon that has been forgotten while adding the driver. This is only a style fix since it doesn't change the functionality of the driver. Signed-off-by: Giulio Benetti Reviewed-by: Kever Yang Thanks, - Kever --- V1->V2: * Impr

Re: [PATCH] mmc: xenon_sdhci: remove wait_dat0 SDHCI OP

2022-03-14 Thread Jaehoon Chung
On 3/12/22 03:14, Robert Marko wrote: > Generic SDHCI driver received support for checking the busy status by > polling the DAT[0] level instead of waiting for the worst MMC switch time. > > Unfortunately, it appears that this does not work for Xenon controllers > despite being a part of the stand

Re: [PATCH v3] usb: dwc2: handle return code of dev_read_size() in of to, plat function

2022-03-14 Thread Marek Vasut
On 3/14/22 09:32, Wolfgang Grandegger wrote: dev_read_size() returns -EINVAL (-22) if the property "g-tx-fifo-size" does not exist. If that's the case, we now keep the default value of 0. Applied, thanks.

[PATCH] doc: board: raspberrypi: Add documentation

2022-03-14 Thread matthias . bgg
From: Matthias Brugger Add documentation about the different configuration files for the RaspberryPi board family. Signed-off-by: Matthias Brugger --- doc/board/raspberrypi/index.rst | 10 + doc/board/raspberrypi/raspberrypi.rst | 53 +++ 2 files changed, 63 i

Re: [PATCH v5 7/9] cmd: rng: Use a statically allocated array for random bytes

2022-03-14 Thread Sughosh Ganu
hi Simon, On Mon, 14 Mar 2022 at 03:53, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 13 Mar 2022 at 08:49, Sughosh Ganu wrote: > > > > Use a statically allocated buffer on stack instead of using malloc for > > reading the random bytes. Using a local array is faster than > > allocating heap mem

Re: ARM: socfpga: gen5: release reset before using USB as device with ums

2022-03-14 Thread Marek Vasut
On 3/14/22 11:57, Wolfgang Grandegger wrote: Hello, Am 28.02.22 um 16:22 schrieb Marek Vasut: On 2/28/22 16:18, Wolfgang Grandegger wrote: Hi, [...] diff --git a/arch/arm/mach-socfpga/board.c b/arch/arm/mach-socfpga/board.c index 7267163222..a2eed73fe9 100644 --- a/arch/arm/mach-socfpga/boa

Re: [PATCH v1 03/11] spi: rockchip-sfc: fix building rockchip-sfc

2022-03-14 Thread Peter Geis
On Mon, Mar 14, 2022 at 4:47 AM Kever Yang wrote: > > Hi Peter, Good Morning, > > On 2022/2/22 09:31, Peter Geis wrote: > > The rockchip-sfc driver is missing an include to build correctly. > > > I think this driver builds OK and has been tested by other developer, > could you share what kind of

Poky defconfig error

2022-03-14 Thread مشاري
Greetings dears , /I use the repo u-boot-socfpga to make poky image but got the below error the dtb files compiled but not found by Makefile.build test -e arch/arm/dts/socfpga_arria10_socdk_sdmmc.dtb || ( \ | echo >&2; \ | echo >&2 "Device Tree Source (arch/arm/dts/socfpga_arria10_socdk_sdmmc.dtb

[PATCH] build: allow a downstream suffix in the version shown during boot

2022-03-14 Thread Nicolas Boulenguez
Hello. https://lists.denx.de/pipermail/u-boot/2022-February/474887.html got no answer, probably because it is trivial and has been lost among more important topics, so I am submitting it again. It is convenient for redistributors to add a build number to the U-boot source version, which is displa

Re: [PATCH v5 3/9] tpm: rng: Add driver model interface for TPM RNG device

2022-03-14 Thread Sughosh Ganu
hi Simon, On Mon, 14 Mar 2022 at 03:53, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 13 Mar 2022 at 08:48, Sughosh Ganu wrote: > > > > The TPM device has a builtin random number generator(RNG) > > functionality. Expose the RNG functions of the TPM device to the > > driver model so that they ca

Re: [PATCH v1 00/11] rockchip fixes and extend rk3568 support

2022-03-14 Thread Peter Geis
On Mon, Mar 14, 2022 at 4:56 AM Kever Yang wrote: > > Hi Peter, > > Thanks for your patchset. > > Seems like some of the driver module author does not include in the > patch cc list, I would suggest you to use scripts/get_maintainer.pl > instead of add cc manually I do use scripts/get_m

Re: [PATCH v5 4/9] tpm: Add the RNG child device

2022-03-14 Thread Sughosh Ganu
hi Simon, On Mon, 14 Mar 2022 at 03:53, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 13 Mar 2022 at 08:48, Sughosh Ganu wrote: > > > > The TPM device comes with the random number generator(RNG) > > functionality which is built into the TPM device. Add logic to add the > > RNG child device in t

Re: [PATCH v1 06/11] rockchip: handle bootrom recovery mode in spl

2022-03-14 Thread Peter Geis
On Mon, Mar 14, 2022 at 5:10 AM Kever Yang wrote: > > Hi Peter, Good Morning, > > On 2022/2/22 09:31, Peter Geis wrote: > > Fixup the bootrom recovery mode code to function in spl, so we can > > handle recovery mode in case u-boot loading is broken. > I don't understand what do you mean about "F

Re: [PATCH v1 06/11] rockchip: handle bootrom recovery mode in spl

2022-03-14 Thread Philipp Tomsich
On Tue, 22 Feb 2022 at 02:31, Peter Geis wrote: > > Fixup the bootrom recovery mode code to function in spl, so we can > handle recovery mode in case u-boot loading is broken. > > Signed-off-by: Peter Geis > --- > arch/arm/mach-rockchip/Makefile| 6 +++--- > arch/arm/mach-rockchip/boot_

Re: [PATCH] mmc: xenon_sdhci: remove wait_dat0 SDHCI OP

2022-03-14 Thread Stefan Roese
On 3/11/22 19:14, Robert Marko wrote: Generic SDHCI driver received support for checking the busy status by polling the DAT[0] level instead of waiting for the worst MMC switch time. Unfortunately, it appears that this does not work for Xenon controllers despite being a part of the standard SDHC

Re: [PATCH v1 06/11] rockchip: handle bootrom recovery mode in spl

2022-03-14 Thread Peter Geis
On Mon, Mar 14, 2022 at 7:59 AM Philipp Tomsich wrote: > > On Tue, 22 Feb 2022 at 02:31, Peter Geis wrote: > > > > Fixup the bootrom recovery mode code to function in spl, so we can > > handle recovery mode in case u-boot loading is broken. > > > > Signed-off-by: Peter Geis > > --- > > arch/arm

[PATCH] ARM: dts: stm32: Add DFU support for DHCOM recovery

2022-03-14 Thread Marek Vasut
This patch configures U-Boot SPL for DHCOM SoM to permit DFU upload of SPL and subsequent u-boot.itb for recovery or commissioning purposes. The DFU usage procedure is identical to STM32MP1 DHCOR SoM, see commit 3919aa1722a ("ARM: dts: stm32: Add DFU support for DHCOR recovery") , except for switc

Re: [PATCH 1/5] disk: Add an option for partitions in SPL

2022-03-14 Thread Tom Rini
On Fri, Mar 11, 2022 at 12:10:01PM -0700, Simon Glass wrote: > In some cases we do not want to enable partition support in SPL. Add an > option to allow this. > > Signed-off-by: Simon Glass > --- > > disk/Kconfig | 24 > disk/Makefile | 6 ++

Re: [PATCH v2 02/13] Makefile: Allow LTO to be disabled for a build

2022-03-14 Thread Tom Rini
On Sat, Mar 12, 2022 at 10:58:44AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 7 Mar 2022 at 07:33, Tom Rini wrote: > > > > On Fri, Mar 04, 2022 at 08:42:57AM -0700, Simon Glass wrote: > > > > > LTO (Link-Time Optimisation) is an very useful feature which can > > > significantly reduce the si

Re: [PATCH] ARM: dts: imx: Add flexspi node to i.MX8MP

2022-03-14 Thread Peng Fan (OSS)
On 2022/3/9 11:19, Marek Vasut wrote: Add flexspi DT node matching Linux kernel as of commit d7cd74466651e ("arm64: dts: imx8mp: Reorder flexspi clock-names entry") Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Reviewed-by: Peng Fan --- arch/arm/dts/im

Re: [PATCH] spi: nxp_fspi: Add i.MX8MP compatible string

2022-03-14 Thread Peng Fan (OSS)
On 2022/3/9 11:18, Marek Vasut wrote: The i.MX8M Mini and i.MX8M Plus flexspi IPs are compatible with one another, however the linux kernel DT uses separate compatible string for each SoC. Add the missing i.MX8MP compatible into this driver. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc:

Re: [PATCH 3/5] rcar3_salvator-x: Drop EFI_LOADER

2022-03-14 Thread Tom Rini
On Fri, Mar 11, 2022 at 07:24:42PM -0700, Simon Glass wrote: > Hi Tom, > > On Fri, 11 Mar 2022 at 13:21, Tom Rini wrote: > > > > On Fri, Mar 11, 2022 at 12:10:03PM -0700, Simon Glass wrote: > > > > > This board is too close to the limit to enable this feature. Drop it. > > > > > > Signed-off-by:

Re: [PATCH v3 00/19] efi_loader: more tightly integrate UEFI disks to driver model

2022-03-14 Thread Tom Rini
On Mon, Mar 14, 2022 at 09:27:40AM +0100, Soeren Moch wrote: > Hi Simon, > > On 12.03.22 06:02, Simon Glass wrote: > > Hi Soeren, > > > > On Fri, 11 Mar 2022 at 15:43, Soeren Moch wrote: > > > > > > > > On 09.03.22 16:33, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Wed, 9 Mar 2022

Re: [PATCH] ram: aspeed: Rework kconfig options

2022-03-14 Thread Tom Rini
On Wed, Feb 16, 2022 at 06:23:22PM +1030, Joel Stanley wrote: > Ensure the ASPEED related options are grouped together under the RAM > option when enabling support. > > This also makes some minor grammar corrections and renames options so > they present cleanly in menuconfig. > > There should be

Re: [PATCH v2 1/3] include: configs: j721e_evm.h: Fix the env variable corresponding to QSGMII PHY init

2022-03-14 Thread Tom Rini
On Tue, Feb 22, 2022 at 10:49:03AM +0530, Aswath Govindraju wrote: > QSGMII PHY initialization should only be done for J721E EVMs and not for > J721E-SK boards. Therefore, fix the environment variables accordingly. > > Also, by default remote processors should not be booted in U-Boot but > rather

Re: [PATCH v2 2/3] configs: j721e_evm_a72_defconfig: Fix the bootcmd

2022-03-14 Thread Tom Rini
On Tue, Feb 22, 2022 at 10:49:04AM +0530, Aswath Govindraju wrote: > Add the command "boot_rprocs" that is required for booting remote > processors in U-Boot. > > Fixes: 5980925e2a5a ("include: configs: j721e_evm: Add support to boot ethfw > core in j721e") > Reported-by: Jesse Villarreal > Sig

Re: [PATCH 1/4] ARM: omap3_beagle: Remove non-DM initialization

2022-03-14 Thread Tom Rini
On Fri, Feb 25, 2022 at 12:18:31PM +0100, Romain Naour wrote: > With DM_MMC working for both SPL and U-Boot, this patch removes > the legacy style of initializing the MMC driver. > > Based on omap3_logic: 42140dd0962bc134c0aad27524d0f4cc3955f255. > > Signed-off-by: Romain Naour Applied to u-bo

Re: [PATCH v2 3/3] configs: j721e_hs_evm_a72_defconfig: Add command for initializing QSGMII PHY

2022-03-14 Thread Tom Rini
On Tue, Feb 22, 2022 at 10:49:05AM +0530, Aswath Govindraju wrote: > QSGMII PHY present on the j721e common processor board requires > to be initialized before the core boots up. Therefore, run the > corresponding command during boot to do the same. > > Signed-off-by: Aswath Govindraju Applied

Re: [PATCH 2/4] ARM: omap3_beagle: Power on MMC when setting up PMIC

2022-03-14 Thread Tom Rini
On Fri, Feb 25, 2022 at 12:18:32PM +0100, Romain Naour wrote: > The PMIC enables power to the MMC card by default, but depending > on the state it was left when restarted, it's possible the MMC > may be powered down. > > This patch patch explicitly tells the twl4030 to power the MMC. > > Based o

Re: [PATCH 3/4] ARM: omap3_beagle: Enable Pinctrl

2022-03-14 Thread Tom Rini
On Fri, Feb 25, 2022 at 12:18:33PM +0100, Romain Naour wrote: > The simple pinctrl driver currently available works with the omap3. > Enabling this will use the device tree to automatically set the > pin-muxing for various drivers. > > Based on commit: 57dbf754e37d3347cad441f3869bf72c0d726a71 >

Re: [PATCH 4/4] ARM: omap3_beagle: Enable DM_PMIC and DM_REGULATOR

2022-03-14 Thread Tom Rini
On Fri, Feb 25, 2022 at 12:18:34PM +0100, Romain Naour wrote: > Enabling DM_PMIC, DM_REGULATOR_FIXED, and DM_REGULATOR_GPIO > gives us the ability to better monitor voltages and enable > hardware through the device tree. The TL4030 (TPS65950) is > not yet migrated to DM, so this patch only enables

Re: [PATCH] ARM: am3517-evm: Remove more non-DM legacy ethernet reset code

2022-03-14 Thread Tom Rini
On Sat, Feb 26, 2022 at 10:13:09AM -0600, Adam Ford wrote: > The ethernet controller is DM compliant, and the device tree > defines it. There is no need to manually handle pulling > the ethernet out of reset. > > Signed-off-by: Adam Ford > Tested-by: Derald D. Woods > > diff --git a/board/log

Re: [PATCH 1/2] ARM: dts: logicpd-som-lv: Resync DTS files with Linux 5.17-rc5

2022-03-14 Thread Tom Rini
On Sat, Feb 26, 2022 at 10:49:47AM -0600, Adam Ford wrote: > Resync the DTS files for the Logic PD SOM-LV with Linux 5.17-rc5 > with some additional pending changes to address issues with > wrong pin-muxing on the OMAP35. > > Signed-off-by: Adam Ford > > diff --git a/arch/arm/dts/logicpd-som-lv

Re: [PATCH 2/2] ARM: omap3_logic: Remove hard-coded USB muxing

2022-03-14 Thread Tom Rini
On Sat, Feb 26, 2022 at 10:49:48AM -0600, Adam Ford wrote: > With recent fixes to USB pinmuxing in the device trees, there > is no need to hard-code the pinmuxing in this table. It is > all handled in DM now. > > Signed-off-by: Adam Ford > > diff --git a/board/logicpd/omap3som/omap3logic.h >

Re: [PATCH] ARM: dts: logicpd-torpedo: Resyc DTS files with Linux 5.17-rc5

2022-03-14 Thread Tom Rini
On Sat, Feb 26, 2022 at 11:01:21AM -0600, Adam Ford wrote: > Resyc DTS files with Linux 5.17-rc5. > > Signed-off-by: Adam Ford > > diff --git a/arch/arm/dts/logicpd-torpedo-35xx-devkit.dts > b/arch/arm/dts/logicpd-torpedo-35xx-devkit.dts > index 7675bc3fa8..cb08aa62d9 100644 Applied to u-boot

Re: [PATCH 1/2] ARM: dts: am3517-evm: Sync DTS with Linux 5.17-rc5

2022-03-14 Thread Tom Rini
On Sat, Feb 26, 2022 at 03:17:23PM -0600, Adam Ford wrote: > Sync the am3517-evm device tree files with those from Linux > 5.17-rc5 with some additional fixes for pinmuxing Ethernet and > moving the pinmux references to the respective peripherals. > > Signed-off-by: Adam Ford > Tested-by: Derald

Re: [PATCH v<9>] arm: add initial support for the Phytium Pomelo Board

2022-03-14 Thread Tom Rini
On Wed, Mar 02, 2022 at 03:09:05PM +0800, nicholas_zh...@outlook.com wrote: > From: weichangzheng > > This adds platform code and the device tree for the Phytium Pomelo Board. > The initial support comprises the UART and the PCIE. > > Signed-off-by: weichangzheng > Changes since v1: >

Re: [PATCH] ARM: mach-omap2: omap3: Make clock functions static

2022-03-14 Thread Tom Rini
On Sat, Mar 05, 2022 at 08:25:23AM -0600, Adam Ford wrote: > get_osc_clk_speed and get_sys_clkin_sel are only used in > one file. Make them static. > > Tested on OMAP3530, DM3730, AM3517. > > Signed-off-by: Adam Ford > > diff --git a/arch/arm/mach-omap2/omap3/clock.c > b/arch/arm/mach-omap2/

Re: [PATCH] mmc: xenon_sdhci: remove wait_dat0 SDHCI OP

2022-03-14 Thread Tom Rini
On Mon, Mar 14, 2022 at 06:37:02PM +0900, Jaehoon Chung wrote: > On 3/12/22 03:14, Robert Marko wrote: > > Generic SDHCI driver received support for checking the busy status by > > polling the DAT[0] level instead of waiting for the worst MMC switch time. > > > > Unfortunately, it appears that thi

Re: [PATCH 2/2] ARM: am3517_evm: Remove hard-coded pin muxing

2022-03-14 Thread Tom Rini
On Sat, Feb 26, 2022 at 03:17:24PM -0600, Adam Ford wrote: > With updated device trees now supporting pinmuxing for USB, > ethernet, MMC, and other peripherals necessary to start MLO > and U-Boot, the hard-coded pinmux options can be removed since > they are now handed by DM and only muxed when th

GPMI NAND Regression on i.MX6S

2022-03-14 Thread Frieder Schrempf
Hello everyone, sorry to dig out an old thread, but the below patch which was applied upstream as 616f03dabacb causes a regression for me when trying to attach an UBI volume with U-Boot 2022.01 on a board with i.MX6 Solo and AMD/Spansion parallel NAND. The failure looks like this: ubi0: attachin

Re: [PATCH] cmd: test: pinmux: Do not check all empty spaces

2022-03-14 Thread Michal Simek
po 7. 3. 2022 v 16:48 odesílatel Michal Simek napsal: > > There is really no value to check empty spaces. That's why use > ut_assert_nextlinen() instead of ut_assert_nextline(). > This change ensures that PINMUX_SIZE can be increased without changing > tests. > > Signed-off-by: Michal Simek > ---

Re: [PATCH] arm64: zynqmp: Fix i2c addresses for zynqmp-p-a2197

2022-03-14 Thread Michal Simek
po 7. 3. 2022 v 8:53 odesílatel Michal Simek napsal: > > After double checking some i2c addresses are not correct. It is visible > from i2c dump > > ZynqMP> i2c bus > Bus 3: i2c@ff02 >74: i2c-mux@74, offset len 1, flags 0 > Bus 5: i2c@ff02->i2c-mux@74->i2c@0 > Bus 6: i2c@ff02->i

[PATCH] arm64: zynqmp: Add pinctrl emmc description to SM-K26

2022-03-14 Thread Michal Simek
Production SOM has emmc on it and make sense to describe pin description to be able use EMMC if it is not configured via psu_init. (Still some regs are not handled but this is one step in that direction) Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-sm-k26-revA.dts | 20 ++

Please pull u-boot-x86

2022-03-14 Thread Bin Meng
Hi Tom, This PR includes the following x86 changes for v2022.04: - Trivial fixes for x86 Azure results: PASS https://dev.azure.com/bmeng/GitHub/_build/results?buildId=463&view=results The following changes since commit c96137000e4cf486dcb164fd67a1a0b5b2fb99c6: Merge tag 'efi-2022-04-rc3-2' o

[PATCH v7 00/16] image: add a stage pre-load

2022-03-14 Thread Philippe Reynes
This serie adds a stage pre-load before launching an image. This stage is used to read a header before the image and this header contains the signature of the full image. So u-boot may check the full image before using any data of the image. The support of this header is added to binman, and a com

[PATCH v7 04/16] lib: allow to build asn1 decoder and oid registry in SPL

2022-03-14 Thread Philippe Reynes
This commit adds the options: - SPL_ASN1_DECODER - SPL_OID_REGISTRY Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 19 +++ lib/Makefile | 4 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig b/lib/Kconfig index e749826f

[PATCH v7 02/16] lib: Kconfig: enhance help for ASN1

2022-03-14 Thread Philippe Reynes
Enhance the help for configs ASN1_COMPILER and ASN1_decoder. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/Kconfig b/lib/Kconfig index 3c6fa99b1a..b0e5d60b3d 100644 --- a/lib/Kconfig

[PATCH v7 01/16] arch: Kconfig: imply BINMAN for SANDBOX

2022-03-14 Thread Philippe Reynes
To be able to use the tool binman on sandbox, the config SANDBOX should imply BINMAN. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- arch/Kconfig | 1 + arch/sandbox/dts/sandbox.dtsi | 3 +++ arch/sandbox/dts/test.dts | 3 +++ test/py

[PATCH v7 11/16] Makefile: provide sah-key to binman

2022-03-14 Thread Philippe Reynes
Set the variable pre-load-key-path with the shell variable PRE_LOAD_KEY_PATH that contain the keys path (used for signature). This variable pre-load-key-path is provided to binman. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Makefile | 1 + 1 file changed, 1 insertion(+) diff -

[PATCH v7 03/16] lib: Kconfig: enhance the help of OID_REGISTRY

2022-03-14 Thread Philippe Reynes
Enhance the help for the config OID_REGISTRY. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index b0e5d60b3d..e749826f22 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -812,6 +812,10 @@ co

[PATCH v7 06/16] lib: rsa: allow rsa verify with pkey in SPL

2022-03-14 Thread Philippe Reynes
This commit adds the option SPL_RSA_VERIFY_WITH_PKEY. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/rsa/Kconfig | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index be9775bcce..b773f17c26 100644 --- a/lib/rsa/Kconfig

[PATCH v7 09/16] common: spl: fit_ram: allow to use image pre load

2022-03-14 Thread Philippe Reynes
Add the support of image pre load in spl or tpl when loading an image from ram. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- common/spl/spl_ram.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/common/spl/spl_ram.c b/common/spl/spl_ram.c

[PATCH v7 13/16] configs: sandbox_defconfig: enable stage pre-load in bootm

2022-03-14 Thread Philippe Reynes
Enable the support of stage pre-load in bootm. For the moment, this stage allow to verify the signature of the full image with a header. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/sandbox_d

[PATCH v7 10/16] mkimage: add public key for image pre-load stage

2022-03-14 Thread Philippe Reynes
This commit enhances mkimage to update the node /image/pre-load/sig with the public key. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- include/image.h| 15 ++ tools/fit_image.c | 3 ++ tools/image-host.c | 114 + 3 files chan

[PATCH v7 05/16] lib: crypto: allow to build crypyo in SPL

2022-03-14 Thread Philippe Reynes
This commit adds the options: - SPL_ASYMMETRIC_KEY_TYPE - SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE - SPL_RSA_PUBLIC_KEY_PARSER Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Makefile| 3 ++- lib/crypto/Kconfig | 29 + lib/crypto/Makefile | 19

[PATCH v7 15/16] cmd: pre_load_verify: initial import

2022-03-14 Thread Philippe Reynes
Add the command pre_load_verify that check the signature of an image with the pre-load header. If the check succeed, the u-boot env variable 'loadaddr_verified' is set to the address of the image (without the header). It allows to run such commands: tftp script.img && pre_load_verify $loadaddr &&

[PATCH v7 12/16] tools: binman: add support for pre-load header

2022-03-14 Thread Philippe Reynes
Adds the support of the pre-load header with the image signature to binman. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- doc/usage/index.rst | 1 + tools/binman/entries.rst | 38 tools/binman/etype/pre_load.py

[PATCH v7 14/16] test: py: vboot: add test for global image signature

2022-03-14 Thread Philippe Reynes
Adds test units for the pre-load header signature. Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 145 -- test/py/tests/vboot/sandbox-binman-pss.dts| 25 +++ test/py/tests/vboot/sandbox-binman.dts| 24 +++ .../tests/vboot/sandbox-

[PATCH v7 07/16] boot: image: add a stage pre-load

2022-03-14 Thread Philippe Reynes
Add a stage pre-load that could check or modify an image. For the moment, only a header with a signature is supported. This header has the following format: - magic : 4 bytes - version : 4 bytes - header size : 4 bytes - image size : 4 bytes - offset image signature : 4 bytes - flags : 4 bytes - r

[PATCH v7 08/16] cmd: bootm: add a stage pre-load

2022-03-14 Thread Philippe Reynes
Add a stage pre-load to the command bootm. Right now, this stage may be used to read a header and check the signature of the full image. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- boot/bootm.c| 33 + cmd/Kconfig | 10 ++ cmd/bootm

[PATCH v7 16/16] configs: sandbox_defconfig: enable config CMD_PRE_LOAD_VERIFY

2022-03-14 Thread Philippe Reynes
Enable the command pre_load_verify on sandbox. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 46bf18bc98..35fd4e3f49 100644 --- a/configs/sandbo

Re: [PATCH v2 1/3] tools: kwboot: Allow to specify custom baudrate only in supported operations

2022-03-14 Thread Stefan Roese
On 3/7/22 19:03, Pali Rohár wrote: Custom baudrate different than 115200 may be specified only when kwboot is not going to send boot/debug message pattern or when it is going to send boot message pattern with image file (in which case baudrate change happens after sending kwbimage header). BootRO

Re: [PATCH v2 2/3] tools: kwboot: Check if baudrate value is supported before sending image

2022-03-14 Thread Stefan Roese
On 3/7/22 19:03, Pali Rohár wrote: The Globalscale Technologies Sheevaplug board has the network chip Marvell 88E1116R. Use uclass mvgbe and the compatible driver M88E1310 driver to bring up Ethernet. - Currently, CONFIG_RESET_PHY_R symbol is used in arch/arm/mach-kirkwood/include/mach/config.h

Re: [PATCH v2 3/3] tools: kwboot: Allow to mix positional arguments with option -b

2022-03-14 Thread Stefan Roese
On 3/7/22 19:03, Pali Rohár wrote: Commit 9e6d71d2b55f ("tools: kwboot: Allow to use -b without image path as the last getopt() option") broke usage of kwboot with following arguments: kwboot -t -B 115200 /dev/ttyUSB0 -b u-boot-spl.kwb Fix parsing of option -b with optional argument again.

Re: [PATCH] arm: a37xx: Remap IO space to bus address 0x0

2022-03-14 Thread Stefan Roese
On 3/7/22 19:12, Pali Rohár wrote: Remap PCI I/O space to the bus address 0x0 in the Armada 37xx device-tree in order to support legacy I/O port based cards which have hardcoded I/O ports in low address space. Some legacy PCI I/O based cards do not support 32-bit I/O addressing. Signed-off-by:

Please pull u-boot-marvell/master

2022-03-14 Thread Stefan Roese
Hi Tom, please pull the next batch of Marvell MVEBU / kwboot related fixes: - kwboot: Misc minor improvement and fixes, e.g. mix of arguments (Pali) - PCI: a37xx: Remap IO space to bus address 0x0 (Pali) ---

Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig

2022-03-14 Thread Johan Jonker
On 3/12/22 15:39, Kever Yang wrote: > Hi Johan, > > On 2022/3/12 18:01, Johan Jonker wrote: >> On 3/12/22 09:51, Jagan Teki wrote: >>> On Thu, Dec 30, 2021 at 10:18 PM Johan Jonker wrote: Move ROCKCHIP_STIMER_BASE to Kconfig. Signed-off-by: Johan Jonker --- Change

Re: [PATCH 2/2] Add option to use -Og

2022-03-14 Thread Sean Anderson
On 3/11/22 9:25 PM, Simon Glass wrote: > On Tue, 22 Feb 2022 at 10:20, Sean Anderson wrote: >> >> This adds support for using -Og when building U-Boot. According to the >> gcc man page: >> >> > -Og should be the optimization level of choice for the standard >> > edit-compile-debug cycle, offeri

Re: [PATCH 2/2] Add option to use -Og

2022-03-14 Thread Tom Rini
On Mon, Mar 14, 2022 at 11:36:54AM -0400, Sean Anderson wrote: > > > On 3/11/22 9:25 PM, Simon Glass wrote: > > On Tue, 22 Feb 2022 at 10:20, Sean Anderson wrote: > >> > >> This adds support for using -Og when building U-Boot. According to the > >> gcc man page: > >> > >> > -Og should be the opt

  1   2   >