RE: [EXTERNAL] Re: Device Tree Overlays and FIT Images - Are they supported together fully?

Hey Marcel, > On Sat, 2022-02-19 at 00:38 +, Ziswiler, Marcel wrote: > I am not sure whether I fully understand the issue(s) you are having. Same here ;-) I did some more work on this, best described as copying a lot of commands from my notepad back and forth. I think you confirmed my und

Re: [PATCH V2] dt-bindings: nvmem: add U-Boot environment variables binding

On 25.02.2022 17:42, Rob Herring wrote: On Thu, Feb 17, 2022 at 02:02:35PM +0100, Rafał Miłecki wrote: From: Rafał Miłecki U-Boot uses environment variables for storing device setup data. It usually needs to be accessed by a bootloader, kernel and often user-space. How much of this is alread

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

On 23.02.22 23:59, Simon Glass wrote: > Hi Alper, > > On Tue, 22 Feb 2022 at 11:58, Alper Nebi Yasak > wrote: >> >> On 21/02/2022 07:40, Simon Glass wrote: >>> On Sat, 19 Feb 2022 at 08:53, Simon Glass wrote: On Fri, 18 Feb 2022 at 10:34, Alper Nebi Yasak wrote: > I can reproduc

[PATCH v2 00/10] tpm: rng: Move TPM RNG functionality to driver model

The TPM device provides the random number generator(RNG) functionality, whereby sending a command to the TPM device results in the TPM device responding with random bytes. There was a discussion on the mailing list earlier[1], where it was explained that platforms with a TPM device can install

[PATCH v2 01/10] tpm: Move tpm-utils header under the include directory

The random number generation functions of TPM will be moved under a dedicated driver. With this, the function declarations along with some other relevant macro definitions need to be moved under a common header file directory. Move the tpm-utils.h header file under the common include directory. Si

[PATCH v2 02/10] tpm: rng: Change tpm_get_random to return an int

The tpm random number generation functionality will be moved to the driver model. With that, the tpm_get_random function will call the common driver model api instead of separate functions for tpmv1 and tpmv2. Return an int instead of a u32 to comply with the return value of the driver model functi

[PATCH v2 03/10] tpm: Fix the return type of tpm_startup

The tpm_startup function returns negative values for error conditions. Fix the return type of the function to a signed int instead of a u32. Signed-off-by: Sughosh Ganu --- Changes since V1: None include/tpm_api.h | 2 +- lib/tpm_api.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(

[PATCH v2 04/10] tpm: Move the TPM version detection functions to the uclass driver

Make the TPM version detection functions as external symbols and move them to the TPM uclass driver. These are useful functions to check the TPM device version and should not be static functions. Signed-off-by: Sughosh Ganu Reviewed-by: Heinrich Schuchardt --- Changes since V1: None drivers/t

[PATCH v2 05/10] configs: gazerbeam: Build TPMV2 library routines

The TPM code currently does a runtime detection of the TPM version and calls appropriate functions. Gazerbeam is one of the platforms where the TPMV2 code is disabled at build time. With this, calling TPM api's from the TPM uclass driver results in link errors. Enable TPMV2 library routines and det

[PATCH v2 09/10] qemu: arm: Remove platform specific function to get RNG device

The Qemu platform has a function defined to get the random number generator(RNG) device. However, the RNG device can be obtained simply by searching for a device belonging to the RNG uclass. Remove the superfluous platform function defined for the Qemu platform for getting the RNG device. Signed-o

[PATCH v2 06/10] configs: chromebook_coral: Build TPMV1 library routines

The TPM code currently does a runtime detection of the TPM version and calls appropriate functions. Chromebook Coral is one of the platforms where the TPMV1 code is disabled at build time. With this, calling TPM api's from the TPM uclass driver results in link errors. Enable TPMV1 library routines

[PATCH v2 08/10] tpm: Add the RNG child device

The TPM device comes with the random number generator(RNG) functionality which is built into the TPM device. Add logic to add the RNG child device in the TPM uclass post probe callback. The RNG device can then be used to pass a set of random bytes to the linux kernel, need for address space random

[PATCH v2 07/10] tpm: rng: Move the TPM RNG functionality to driver model

Currently, the TPM random number generator(RNG) functions are defined as part of the library functions under the corresponding tpm files for tpmv1 and tpmv2. Move the RNG functionality under TPM RNG drivers complying with the driver model. Also make changes to the tpm_get_random function to have i

[PATCH v2 10/10] cmd: rng: Add support for selecting RNG device

The 'rng' u-boot command is used for printing a select number of random bytes on the console. Currently, the RNG device from which the random bytes are read is fixed. However, a platform can have multiple RNG devices, one example being qemu, which has a virtio RNG device and the RNG pseudo device t

[PATCH] drivers: rtc: fix null pointer access in armada38x_rtc_reset

From: Francois Berder Replace null pointer by pointer to device registers when calling armada38x_rtc_write. Signed-off-by: Francois Berder --- drivers/rtc/armada38x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/armada38x.c b/drivers/rtc/armada38x.c index 2d

[PATCH v2 0/5] board: sl28: add basic PSCI implementation

Add PSCI support to reset and power-off the board. Because this board can be used without TF-A, supply a (mandatory) PSCI implementation. The armv8 u-boot part already contains most bits for the implementation, it is just, that it isn't compatible with the layerscape parts. Thus, we first need to

[PATCH v2 1/5] armv8: include psci_update_dt() unconditionally

psci_update_dt() is also required if CONFIG_ARMV8_PSCI is set, that is, if u-boot is the PSCI provider. Guard the check which is intended to call into the PSCI implementation in the secure firmware, by the proper macro SEC_FIRMWARE_ARMV8_PSCI. Mark the function as weak because - unfortunately - th

[PATCH v2 3/5] armv8: psci: skip setup code if we are not EL3

If we are running in EL2 skip PSCI implementation setup. This avoids an exception if CONFIG_ARMV8_PSCI is set, but u-boot is started by TF-A. Signed-off-by: Michael Walle --- arch/arm/cpu/armv8/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/cpu/armv8/cpu.c b/arch/arm/cpu/a

[PATCH v2 5/5] board: sl28: add basic PSCI implementation

For now, this only provides reset and poweroff functions. Signed-off-by: Michael Walle --- board/kontron/sl28/Makefile| 2 ++ board/kontron/sl28/psci.c | 42 ++ configs/kontron_sl28_defconfig | 2 ++ 3 files changed, 46 insertions(+) create mode 100644

[PATCH v2 2/5] armv8: layerscape: get rid of smc_call()

There are two different implementations to do a secure monitor call: smc_call() and arm_smccc_smc(). The former is defined in fwcall.c and seems to be an ad-hoc implementation. The latter is imported from linux. smc_call() is also only available if CONFIG_ARMV8_PSCI is not defined. This makes it i

[PATCH v2 4/5] armv8: psci: add ARMV8_PSCI_RELOCATE Kconfig option

There is an user-selectable SYS_HAS_ARMV8_SECURE_BASE, which has the same meaning but is just for the ls1043ardb board. As no in-tree config uses this, drop it and replace it with something more sophiticated: ARMV8_PSCI_RELOCATE. This option will then enable the ARMV8_SECURE_BASE option which is us

[PATCH V3] dt-bindings: nvmem: add U-Boot environment variables binding

From: Rafał Miłecki U-Boot uses environment variables for storing device setup data. It usually needs to be accessed by a bootloader, kernel and often user-space. This binding allows describing environment data located in a raw flash partition. It's treated as NVMEM device and can be reused late

Re: [PATCH v5 3/4] test/py: Handle expected reboot while booting sandbox

On Sun, Feb 27, 2022 at 02:45:36PM -0700, Simon Glass wrote: > Hi Tom, > > On Sun, 27 Feb 2022 at 13:58, Tom Rini wrote: > > > > On Sun, Feb 27, 2022 at 12:11:01PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sun, 27 Feb 2022 at 11:14, Tom Rini wrote: > > > > > > > > On Sun, Feb 27, 20

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

On 28/02/2022 14:48, Jan Kiszka wrote: > On 23.02.22 23:59, Simon Glass wrote: >> On Tue, 22 Feb 2022 at 11:58, Alper Nebi Yasak >> wrote: >>> I've also managed to somewhat fix the rest of the issues I wrote, so now >>> I can replace a FIT entry with a modified one (having a different u-boot >>>

Re: [PATCH v5 3/4] test/py: Handle expected reboot while booting sandbox

Hi, On Mon, 28 Feb 2022 at 06:48, Tom Rini wrote: > > On Sun, Feb 27, 2022 at 02:45:36PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Sun, 27 Feb 2022 at 13:58, Tom Rini wrote: > > > > > > On Sun, Feb 27, 2022 at 12:11:01PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Sun, 27

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

Hi Jan, On Mon, 28 Feb 2022 at 04:48, Jan Kiszka wrote: > > On 23.02.22 23:59, Simon Glass wrote: > > Hi Alper, > > > > On Tue, 22 Feb 2022 at 11:58, Alper Nebi Yasak > > wrote: > >> > >> On 21/02/2022 07:40, Simon Glass wrote: > >>> On Sat, 19 Feb 2022 at 08:53, Simon Glass wrote: > On F

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

On 28.02.22 14:56, Simon Glass wrote: > Hi Jan, > > On Mon, 28 Feb 2022 at 04:48, Jan Kiszka wrote: >> >> On 23.02.22 23:59, Simon Glass wrote: >>> Hi Alper, >>> >>> On Tue, 22 Feb 2022 at 11:58, Alper Nebi Yasak >>> wrote: On 21/02/2022 07:40, Simon Glass wrote: > On Sat, 19 Feb

[PATCH v7 00/15] vpl: Introduce a verifying program loader

U-Boot provides a verified-boot feature based around FIT, but there is no standard way of implementing it for a board. At present the various required pieces must be built up separately, to produce a working implementation. In particular, there is no built-in support for selecting A/B boot or recov

[PATCH v7 01/15] doc: Convert SPL documentation to ReST

Move this documentation over to .rst format. Signed-off-by: Simon Glass --- (no changes since v1) doc/develop/index.rst | 1 + doc/{README.SPL => develop/spl.rst} | 36 +++-- 2 files changed, 20 insertions(+), 17 deletions(-) rename doc/{README.SPL => de

[PATCH v7 02/15] doc: Expand SPL docs to explain the phase and config

Add a bit more information about how to use SPL. Signed-off-by: Simon Glass --- (no changes since v1) doc/develop/spl.rst | 34 ++ 1 file changed, 34 insertions(+) diff --git a/doc/develop/spl.rst b/doc/develop/spl.rst index 4d6f394bed..1059b2fb9c 100644 --- a/

[PATCH v7 05/15] avb: Don't build in SPL

This feature is not used in SPL at present. Update the Makefile to avoid it being built. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Add new patch to avoid building avb in SPL common/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/

[PATCH v7 04/15] bloblist: Correct Kconfig dependencies

This feature is not available in SPL unless common/ and lib/ are built. Update the Kconfig to avoid build errors. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Add new patch to correct bloblist Kconfig dependencies common/Kconfig | 4 ++-- 1 file changed, 2 insertions(

[PATCH v7 03/15] test: Tidy up test building with SPL

We can in principle add tests to any SPL build, e.g. TPL or VPL. Update the build rules to handle this. Signed-off-by: Simon Glass --- (no changes since v1) Makefile | 2 +- scripts/Makefile.spl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makef

[PATCH v7 10/15] fdt: Correct condition for SEPARATE_BSS

This may have different settings for SPL and TPL. Correct the condition. Signed-off-by: Simon Glass --- Changes in v7: - Add new patch to correct condition for SEPARATE_BSS lib/fdtdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 87aa67

[PATCH v7 06/15] Makefile: Simplify devicetree rules for SPL/TPL

The current logic checks several options to decide whether SPL/TPL need the U-Boot devicetree to be built. In fact we can check OF_CONTROL, which is enabled in all cases that matter. Signed-off-by: Simon Glass --- (no changes since v1) Makefile | 7 ++- 1 file changed, 2 insertions(+), 5 d

[PATCH v7 07/15] Makefile: Tidy up the TPL build rules

These should follow the same pattern as SPL, for consistency. Fix them. Signed-off-by: Simon Glass --- (no changes since v1) Makefile | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 9d026cc8ac..f8c5fc2041 100644 --- a/Makefile +++ b/Makefile

[PATCH v7 08/15] Add a default for TPL_TEXT_BASE

If this value is not provided it causes a hang in the build. Add a default value to avoid this. Signed-off-by: Simon Glass --- Changes in v7: - Add new patch with a default for TPL_TEXT_BASE common/spl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/common/spl/Kconfig b/common/spl/

[PATCH v7 09/15] disk: Correct the conditions for SPL

These filesystems may have different settings for SPL and TPL. Use the correct Makefile variable to handle this. Signed-off-by: Simon Glass --- Changes in v7: - Add new patch to correct the conditions for SPL disk/Makefile | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH v7 11/15] fdt: sandbox: Avoid looking for an appended device tree

We don't use an appended tree for sandbox and the required symbols are not present. Add a condition to avoid a build error. Signed-off-by: Simon Glass --- Changes in v7: - Add new patch to avoid looking for an appended device tree lib/fdtdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --g

[PATCH v7 15/15] sandbox: Add a build for VPL

Add an initial VPL build for sandbox. This includes the flow: TPL (with of-platdata) -> VPL -> SPL -> U-Boot To run it: ./tpl/u-boot-tpl -D The -D is needed to get the default device tree, which includes the serial console info. Add a Makefile check for OF_HOSTFILE which is the option th

[PATCH v7 14/15] vpl: Add Kconfig options for VPL

Add VPL versions of commonly used Kconfig options. Signed-off-by: Simon Glass --- Changes in v7: - Add a few more options Changes in v5: - Rebase this patch on mainline (for GPIO and MISC Kconfig renames) Changes in v4: - Add options for blk, core, misc and tpl also - Add VPL_SIZE_LIMIT Kcon

[PATCH v7 12/15] binman: Add VPL support

Add support for U-Boot's Verifying Program Loader phase. Signed-off-by: Simon Glass --- Changes in v7: - Renumber the tests - Update for the patman library rename Changes in v6: - Fix the missing SPDX tag on test/204... tools/binman/etype/u_boot_vpl.py | 42 tools/binman/e

[PATCH v7 13/15] Introduce Verifying Program Loader (VPL)

Add support for VPL, a new phase of U-Boot. This runs after TPL. It is responsible for selecting which SPL binary to run, based on a verified-boot process. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Update spl_phase_prefix() for VPL - Tidy up some of the Makefile rule

Re: [PATCH v5 3/4] test/py: Handle expected reboot while booting sandbox

Hi Simon, 2022年2月28日(月) 6:45 Simon Glass : > > Hi Tom, > > On Sun, 27 Feb 2022 at 13:58, Tom Rini wrote: > > > > On Sun, Feb 27, 2022 at 12:11:01PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sun, 27 Feb 2022 at 11:14, Tom Rini wrote: > > > > > > > > On Sun, Feb 27, 2022 at 08:39:30A

Re: [PATCH v5 3/4] test/py: Handle expected reboot while booting sandbox

Hi Simon, 2022年2月28日(月) 22:56 Simon Glass : > > Hi, > > On Mon, 28 Feb 2022 at 06:48, Tom Rini wrote: > > > > On Sun, Feb 27, 2022 at 02:45:36PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sun, 27 Feb 2022 at 13:58, Tom Rini wrote: > > > > > > > > On Sun, Feb 27, 2022 at 12:11:01PM -0

Re: ARM: socfpga: gen5: release reset before using USB as device with ums

On 2/28/22 15:13, Wolfgang Grandegger wrote: The command "ums 0 mmc 0" does not work because the USB port is still in reset. Releasing it in board_usb_init() fixes the problem. This issue has been observed and fixed on the Aries MCVEVP board. Signed-off-by: Wolfgang Grandegger --- arch/arm/dt

[PATCH] arm64: zynqmp: Add resets property to sdhci nodes

From: Sai Krishna Potthuri Add "resets" property to sdhci nodes. resets property is used to reset the SD host controller when dynamic configuration support is enabled. Signed-off-by: Sai Krishna Potthuri Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp.dtsi | 2 ++ 1 file changed, 2 inser

[PATCH u-boot-marvell] arm64: a37xx: pinctrl: Fix PWM pins indexes

From: Marek Behún Commit 5534fb4f4833 ("arm64: a37xx: pinctrl: Correct PWM pins definitions") introduced bogus definitions os PWM pins: all 4 pins have index 11, instead of having indexes 11, 12, 13, 14. Fix this. Signed-off-by: Marek Behún --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 6

Re: [PATCH v5 3/4] test/py: Handle expected reboot while booting sandbox

Hi Masami, On Mon, 28 Feb 2022 at 07:40, Masami Hiramatsu wrote: > > Hi Simon, > > 2022年2月28日(月) 6:45 Simon Glass : > > > > > Hi Tom, > > > > On Sun, 27 Feb 2022 at 13:58, Tom Rini wrote: > > > > > > On Sun, Feb 27, 2022 at 12:11:01PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH v5 3/4] test/py: Handle expected reboot while booting sandbox

Hi Masami, On Mon, 28 Feb 2022 at 07:47, Masami Hiramatsu wrote: > > Hi Simon, > > 2022年2月28日(月) 22:56 Simon Glass : > > > > Hi, > > > > On Mon, 28 Feb 2022 at 06:48, Tom Rini wrote: > > > > > > On Sun, Feb 27, 2022 at 02:45:36PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Sun,

Re: ARM: socfpga: gen5: release reset before using USB as device with ums

On 2/28/22 16:18, Wolfgang Grandegger wrote: Hi, [...] diff --git a/arch/arm/mach-socfpga/board.c b/arch/arm/mach-socfpga/board.c index 7267163222..a2eed73fe9 100644 --- a/arch/arm/mach-socfpga/board.c +++ b/arch/arm/mach-socfpga/board.c @@ -83,6 +83,14 @@ int board_usb_init(int index, enum us

RE: [PATCH] arch: arm: recode the initialization of GICv3 ITS Re-Distributor tables

Hi Marc, Thanks a lot for your comments! > -Original Message- > From: Marc Zyngier > Sent: 2022年2月26日 19:10 > To: Z.Q. Hou > Cc: u-boot@lists.denx.de; s...@chromium.org; > bharat.go...@broadcom.com; Priyanka Jain ; > mich...@walle.cc > Subject: Re: [PATCH] arch: arm: recode the initiali

[PATCH v3] binman: Include also subnodes in generator nodes

From: Jan Kiszka This allows to prefill fdt and config nodes with hash and signature subnodes. It's just important to place the child nodes last so that hashes do not come before the data - would be disliked by mkimage. Signed-off-by: Jan Kiszka --- Rebased over "binman: rockchip: Migrate from

[PATCH] firmware: zynqmp: Do not bind PD driver in SPL if disabled

Change if condition to cover SPL flow. SPL needs to have CONFIG_SPL_POWER_DOMAIN enabled to be able to bind CONFIG_ZYNQMP_POWER_DOMAIN driver. Signed-off-by: Michal Simek --- drivers/firmware/firmware-zynqmp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/firm

Re: [PATCH 06/14] misc: Add support for nvmem cells

On 2/26/22 1:36 PM, Simon Glass wrote: > Hi Sean, > > On Mon, 7 Feb 2022 at 16:42, Sean Anderson wrote: >> >> This adds support for "nvmem cells" as seen in Linux. The nvmem device >> class in Linux is used for various assorted ROMs and EEPROMs. In this >> sense, it is similar to UCLASS_MISC,

[PATCH 00/18] Various bugfixes related to verified boot

This series collects together various misc patches that were needed when building mainline U-Boot against Chromium OS verified boot. Most of them fix minor bugs. Simon Glass (18): buildman: Update default config to build for sandbox buildman: Fix up cfgutil binman: Correct Chromium OS entry

[PATCH 02/18] buildman: Fix up cfgutil

The name of this function changed at the same time as this file was added. Fix the naming. Signed-off-by: Simon Glass --- tools/buildman/cfgutil.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/buildman/cfgutil.py b/tools/buildman/cfgutil.py index 4eba50868f..166

[PATCH 03/18] binman: Correct Chromium OS entry types

The conversion to bintools broke the invocation of the utility, since the arguments are not correct. Fix it. Signed-off-by: Simon Glass --- tools/binman/btool/futility.py | 4 ++-- tools/binman/etype/vblock.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/binman

[PATCH 01/18] buildman: Update default config to build for sandbox

At present the default .buildman file written by buildman does not specify a default toolchain. Add an 'other' line so this works correctly and sandbox builds run as expected. Signed-off-by: Simon Glass --- tools/buildman/bsettings.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/bu

[PATCH 04/18] errno: Avoid including strings in SPL

At present the header file defines this function in SPL but the file may not actually be built. This causes a build error if the option is enabled. Fix the condition in the header file. Signed-off-by: Simon Glass --- include/errno.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 05/18] abuf: Correct a corner case with abuf_realloc()

If the buffer is empty and not allocated, then abuf_realloc() tries to copy invalid data. This happens because an incorrect change to use memdup() was added after the original code was written. Signed-off-by: Simon Glass --- lib/abuf.c | 4 +++- test/lib/abuf.c | 29 ++

[PATCH 06/18] fdt: Correct condition for SEPARATE_BSS

This may have different settings for SPL and TPL. Correct the condition. Signed-off-by: Simon Glass --- lib/fdtdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 87aa677a4a..086f0c732a 100644 --- a/lib/fdtdec.c +++ b/lib/fdtdec.c @@ -1227

[PATCH 07/18] fdt: sandbox: Avoid looking for an appended device tree

We don't use an appended tree for sandbox and the required symbols are not present. Add a condition to avoid a build error. Signed-off-by: Simon Glass --- lib/fdtdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 086f0c732a..0c0ec034ec 100644 --- a/li

[PATCH 08/18] lzma: Tidy up the function prototype

This should use a const pointer for the input stream. Fix this and also add a proper comment. Signed-off-by: Simon Glass --- lib/lzma/LzmaTools.c | 4 ++-- lib/lzma/LzmaTools.h | 17 +++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/lib/lzma/LzmaTools.c b/lib/lz

[PATCH 10/18] cros_ec: Complete the comment for cros_ec_read_batt_charge()

Add the missing 'Return' information. Signed-off-by: Simon Glass --- include/cros_ec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/cros_ec.h b/include/cros_ec.h index 2a7728622c..94c988a7d6 100644 --- a/include/cros_ec.h +++ b/include/cros_ec.h @@ -648,6 +648,7 @@ int cros_ec_vs

[PATCH 09/18] cbfs: Add some more definititions

Add definitions for a payload or 'self', which is like an unpacked ELF file. Signed-off-by: Simon Glass --- include/cbfs.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/include/cbfs.h b/include/cbfs.h index 7449873b49..38efb1d2b0 100644 --- a/i

[PATCH 11/18] spi: Avoid checking console in SPL

When SPI flash is used in SPL there is no console, so ctrlc() cannot be called. Add a condition to fix this. Signed-off-by: Simon Glass --- drivers/mtd/spi/spi-nor-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor

[PATCH 12/18] disk: Correct the conditions for SPL

These filesystems may have different settings for SPL and TPL. Use the correct Makefile variable to handle this. Signed-off-by: Simon Glass --- disk/Makefile | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/disk/Makefile b/disk/Makefile index 6ce5a687b3..83f5af6069

[PATCH 13/18] Add a default for TPL_TEXT_BASE

If this value is not provided it causes a hang in the build. Add a default value to avoid this. Signed-off-by: Simon Glass --- common/spl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 9418d37b2e..b59215fe4f 100644 --- a/common/spl/Kcon

[PATCH 14/18] Make ASYMMETRIC_KEY_TYPE depend on FIT_SIGNATURE

Add this dependency to avoid a build error if FIT_SIGNATURE is not enabled. Signed-off-by: Simon Glass --- lib/crypto/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/crypto/Kconfig b/lib/crypto/Kconfig index 6369bafac0..5c6e964862 100644 --- a/lib/crypto/Kconfig +++ b/lib/crypto

[PATCH 15/18] stdint: Add a definition of UINT8_MAX

This is normally defined in stdint.h but is not used in U-Boot. When libraries (such as Chromium OS vboot) are built against U-Boot they may expect this value to be available. Add it to avoid build errors in this case. Signed-off-by: Simon Glass --- include/stdint.h | 7 +++ 1 file changed,

[PATCH 18/18] dm: blk: Expand iteration and add tests

Add some functions which support iteration before probing. Also add tests for the functions. Signed-off-by: Simon Glass --- drivers/block/blk-uclass.c | 24 include/blk.h | 45 +++ test/dm/blk.c | 111 + 3 file

[PATCH 16/18] dm: core: Add a required struct declaration

This file uses struct driver, so declare it at the top in case the header-inclusion order is not as expected. Signed-off-by: Simon Glass --- include/dm/device-internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dm/device-internal.h b/include/dm/device-internal.h index 02002ac

[PATCH 17/18] dm: core: Tidy up comments in uclass headers

Improve some of the comments in these files, which don't follow the correct style. Signed-off-by: Simon Glass --- include/dm/uclass-internal.h | 18 +- include/dm/uclass.h | 13 ++--- 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/include/dm/uc

phy_connect_dev calling phy_reset???

Greetings, I'm wondering if it is proper in U-Boot for phy_connect_dev() to always call phy_reset() which generates a soft reset via BMCR_RESET. For some (or most?) PHY's this resets specific PHY config such as RGMII delays and LED configuration that may have been configured by firmware running p

Re: [PATCH u-boot-marvell] arm64: a37xx: pinctrl: Fix PWM pins indexes

On Monday 28 February 2022 15:59:37 Marek Behún wrote: > From: Marek Behún > > Commit 5534fb4f4833 ("arm64: a37xx: pinctrl: Correct PWM pins > definitions") introduced bogus definitions os PWM pins: all 4 pins have > index 11, instead of having indexes 11, 12, 13, 14. > > Fix this. > > Signed-o

[PATCH v2] core: devres: optionally build devres into the SPL

Add a CONFIG_SPL_DEVRES option Signed-off-by: Angus Ainslie --- Changes since v1: Instead of gaurding the source add an SPL_DEVRES option drivers/core/Kconfig | 13 + drivers/core/Makefile | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/core/Kconfi

Re: [PATCH v3 0/6] imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards

Hi Stefano Any plan to get those boards in? On Thu, Feb 17, 2022 at 3:35 PM Ariel D'Alessandro wrote: > > Introduce BSH SystemMaster (SMM) S2 board family, which consists of: > iMX8MN SMM S2 and iMX8MN SMM S2 PRO boards. > > This patchset also adds support for NXP TJA11xx Ethernet PHYs. > > Chan

Re: [PATCH] configs: ti: use standard configuration nodes naming

On Thu, Feb 10, 2022 at 11:13:36PM +0100, Romain Naour wrote: > Currently, any u-boot bootloader for ti armv7 platforms using > DEFAULT_FIT_TI_ARGS to boot with a fitimage (boot_fit = 1) > doesn't boot when built with Yocto Poky (openembedded-core). > > ## Loading kernel from FIT Image at 90

Re: [PATCH] tools: mkimage/dumpimage: Allow to use -l with -T

On Sun, Feb 13, 2022 at 01:09:46AM +0100, Pali Rohár wrote: > Currently -l option for mkimage and dumpimage ignores option -T and always > tries to autodetect image type. > > With this change it is possible to tell mkimage and dumpimage to parse > image file as specific type (and not random autod

Re: [PATCH] arm: pdu001: Fix early debugging UART

On Tue, Feb 15, 2022 at 03:27:23PM +0100, Felix Brack wrote: > The changes from commit 0dba45864b2a ("arm: Init the debug UART") > prevent the early debug UART from being initialized correctly. > To fix this we not just configure the pin multiplexer but add setting up > early clocks. > > Signed-o

Re: [PATCH v3 1/1] arm: apple: Switch to fully dynamic mem layout

On Sat, Feb 19, 2022 at 02:05:19PM +0100, Janne Grunau wrote: > Support for Apple M1 Pro and Max will allow using a single binary for > all M1 SoCs. The M1 Pro/Max have a different memory layout. The RAM > start address is 0x100__ instead of 0x8__. > Replace the hardcoded memory la

Re: [PATCH v2] board: stemmy: Detect board variants and patch DTB

On Sun, Feb 20, 2022 at 11:47:01PM +0100, Linus Walleij wrote: > This patch scans the cmdline from the Samsung SBL (second stage > bootloader) and stores the parameters board_id=N and lcdtype=N > in order to augment the DTB for different board and LCD types. > > We then add a custom ft_board_setu

Re: [PATCH] arm: pdu001: Setup pinmux for console UART as early as possible

On Mon, Feb 21, 2022 at 02:26:05PM +0100, Felix Brack wrote: > To make sure we get a working console as soon as possible in the SPL the > UART pins require to be configured earlier. This is especially > true for the pins of UART3, since the PDU001 board uses this UART for > the console by default.

Re: [PATCH] image: Control FIT signature verification at runtime

On 2/27/22 19:29, Andrew Jeffery wrote: On Tue, 15 Feb 2022, at 13:55, Andrew Jeffery wrote: On Tue, 15 Feb 2022, at 13:42, Dhananjay Phadke wrote: On 2/14/2022 3:13 PM, Patrick Williams wrote: On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: There's a key-requirement polic

[PATCH 0/5] sandbox: Minor Fixes in various areas

This series contains some minor tweaks and fixes to sandbox-related code. Simon Glass (5): sandbox: Show a message when writing out the ram buffer sandbox: Add the handoff header for spl sandbox: Open host file for read-only access if needed sandbox: Slow down the LCD sync rate sandbox:

[PATCH 1/5] sandbox: Show a message when writing out the ram buffer

If state is not being written, but RAM is, we should still show a message, so it is clear that this is happening. Signed-off-by: Simon Glass --- arch/sandbox/cpu/state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/sandbox/cpu/state.c b/arch/sandbox/cpu/state.c ind

[PATCH 2/5] sandbox: Add the handoff header for spl

This defines a function declared in handoff.h so add the header. Signed-off-by: Simon Glass --- arch/sandbox/cpu/spl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sandbox/cpu/spl.c b/arch/sandbox/cpu/spl.c index 650bdb0a70..3f107b8acb 100644 --- a/arch/sandbox/cpu/spl.c +++ b/arch/

[PATCH 3/5] sandbox: Open host file for read-only access if needed

Some files cannot be written but read-only access is still useful for tests. Add a fallback to read-only access when needed. This is useful in CI when opening a large data file provided by docker, where read/write access would result in copying the file, thus needing a lot of extra disk space. Si

[PATCH 5/5] sandbox: test: Tidy up spl_test_load() calls

Use the new sandbox_find_next_phase() function, which does what is needed here. Signed-off-by: Simon Glass --- test/image/spl_load.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/test/image/spl_load.c b/test/image/spl_load.c index e7cabf5680..df389e26f9 100644 --- a/t

[PATCH 4/5] sandbox: Slow down the LCD sync rate

There is seldom a need to refresh at 100Hz and it uses a lot of CPU. Reduce the rate to 10Hz which seems to be adequate. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/video-uclass.c b/drivers/video/v

[PATCH 1/2] x86: Add an enum name for the GNVS firmware type

This enum is currently anonymous. Add a name so it can be used in the code. Signed-off-by: Simon Glass --- arch/x86/include/asm/intel_gnvs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/intel_gnvs.h b/arch/x86/include/asm/intel_gnvs.h index fc743dc92

[PATCH 2/2] x86: Correct the coreboot header file in MAINTAINERS

This board has its own config header file. Correct it. Signed-off-by: Simon Glass --- board/coreboot/coreboot/MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/coreboot/coreboot/MAINTAINERS b/board/coreboot/coreboot/MAINTAINERS index a05673bb0b..ee12d32c

Re: [PATCH] image: Control FIT signature verification at runtime

On Tue, 1 Mar 2022, at 08:42, Alex G. wrote: > On 2/27/22 19:29, Andrew Jeffery wrote: >> >> >> On Tue, 15 Feb 2022, at 13:55, Andrew Jeffery wrote: >>> On Tue, 15 Feb 2022, at 13:42, Dhananjay Phadke wrote: On 2/14/2022 3:13 PM, Patrick Williams wrote: > On Mon, Feb 14, 2022 at 11:14

[PATCH] phy: nop-phy: Fix phy reset if no reset-gpio defined

Ensure there is a valid reset-gpio defined before using it. Fixes: f9852acdce02 ("phy: nop-phy: Fix enabling reset") Cc: Adam Ford Signed-off-by: Tim Harvey --- drivers/phy/nop-phy.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/phy/nop-phy.c b/drivers

[ANN] U-Boot v2022.04-rc3 released

Hey all, It's release day and so here's v2022.04-rc3. With the release itself nearing a month away, I'm opening the -next branch as well with this release. At this point, if there's platform specific changes, or other bug fixes / changes you had submitted and hoped would be in this release, but

[PATCH 0/8] tpm: Various minor fixes and enhancements

This series contains some minor enhancements for the TPM code to make it work with Chromium OS verified boot. Simon Glass (8): tpm: Export the TPM-version functions tpm: Require a digest source when extending the PCR tpm: Correct the permissions command in TPMv1 tpm: Correct the define-sp

[PATCH 1/8] tpm: Export the TPM-version functions

These functions should really be available outside the TPM code, so that other callers can find out which version the TPM is. Rename them to have a tpm_ prefix() and add them to the header file. Signed-off-by: Simon Glass --- include/tpm_api.h | 10 ++ lib/tpm_api.c | 92 +++

[PATCH 2/8] tpm: Require a digest source when extending the PCR

This feature is used for measured boot. It is not currently supported in the TPM drivers, but add it to the API so that code which expects it can signal its request. Signed-off-by: Simon Glass --- cmd/tpm-v1.c | 3 ++- cmd/tpm_test.c| 5 +++-- include/tpm_api.h | 8 +--- lib/tpm

[PATCH 4/8] tpm: Correct the define-space command in TPMv2

The message format is incorrect. Fix it. Signed-off-by: Simon Glass --- lib/tpm-v2.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c index 6058f2e1e4..fe99b9c863 100644 --- a/lib/tpm-v2.c +++ b/lib/tpm-v2.c @@ -89,14 +89,14 @@

  1   2   >