[PATCH] usb: mtu3: flush cache for next GPD

2021-03-03 Thread Chunfeng Yun
When flush cache of the current GPD and resume QMU, the controller will try to access the next GPD after processing the current one, if not flush the next GPD, the controller may get wrong GPD status. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3_qmu.c | 3 +++ 1 file changed, 3 insertio

RE: [EXT] Re: [PATCH 4/4] imx8mq_evk: Enable the USB3.0 host port

2021-03-03 Thread Bough Chen
> -Original Message- > From: Ye Li > Sent: 2021年2月27日 14:05 > To: feste...@gmail.com; Bough Chen > Cc: Peng Fan ; u-boot@lists.denx.de; dl-uboot-imx > ; sba...@denx.de > Subject: Re: [EXT] Re: [PATCH 4/4] imx8mq_evk: Enable the USB3.0 host port > > Hi Fabio, > > On Thu, 2021-02-25 at 10:

RE: [PATCH] Revert "mmc: fsl_esdhc_imx: remove the 1ms delay before sending command"

2021-03-03 Thread Bough Chen
> -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: 2021年2月27日 21:54 > To: Peng Fan > Cc: u-boot@lists.denx.de; loru...@gmail.com; > andrey.zhizhi...@leica-geosystems.com; Ye Li ; Bough Chen > ; sba...@denx.de; tr...@konsulko.com; Fabio Estevam > > Subject: [PAT

[PATCH 1/2] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON to control card clock output

2021-03-03 Thread haibo . chen
From: Haibo Chen For FSL_USDHC, it do not implement VENDORSPEC_CKEN/PEREN/HCKEN/IPGEN, these are reserved bits. Instead, use VENDORSPEC_FRC_SDCLK_ON to gate on/off the card clock output. After commit b5874b552ffa ("mmc: fsl_esdhc_imx: add wait_dat0() support"), we meet SD3.0 card can't work at U

[PATCH 2/2] mmc: fsl_esdhc_imx: remove redundant cmd11 related code.

2021-03-03 Thread haibo . chen
From: Haibo Chen Common code already handle the voltage switch sequence based on spec, so remove the redundant voltage switch code. Signed-off-by: Haibo Chen --- drivers/mmc/fsl_esdhc_imx.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/mmc/fsl_esdhc_imx.

RE: [PATCH 3/3 v5] efi: ESRT creation tests

2021-03-03 Thread Jose Marinho
Hi Takahiro Akashi, Thank you for reviewing these tests. > -Original Message- > From: AKASHI Takahiro > Sent: 02 March 2021 23:49 > To: Heinrich Schuchardt > Cc: Jose Marinho ; u-boot@lists.denx.de; > Sughosh Ganu ; Ilias Apalodimas > ; Andre Przywara ; > Alexander Graf ; nd > Subject:

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-03 Thread Wolfgang Denk
Dear Tom, In message <20210302133435.GZ10169@bill-the-cat> you wrote: > > > Only the third example is affected by this patch. > > OK. But to what end? Historically we have a buggy but mostly > compatible "hush" that acts like "sh" does. A more flexible shell could > solve a lot of different us

[PATCH] fs/squashfs: Fix compilation error

2021-03-03 Thread Pali Rohár
Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") broke compilation of squashfs filesystem when CONFIG_CMD_SQUASHFS=y is enabled. Compilation is failing on error: aarch64-linux-gnu-ld.bfd: u-boot/fs/squashfs/sqfs_inode.c:121: undefined refe

Re: Commit 401d1c4f5d2 ("common: Drop asm/global_data.h from common header") broke CONFIG_CMD_SQUASHFS=y

2021-03-03 Thread Pali Rohár
On Tuesday 02 March 2021 16:27:27 Tom Rini wrote: > On Tue, Mar 02, 2021 at 05:59:47PM +0100, Pali Rohár wrote: > > On Friday 26 February 2021 13:54:40 Pali Rohár wrote: > > > On Friday 26 February 2021 07:51:53 Tom Rini wrote: > > > > On Fri, Feb 26, 2021 at 01:34:29PM +0100, Pali Rohár wrote: > >

Re: [PATCH v3 1/4] firmware: scmi: voltage regulator

2021-03-03 Thread Patrick DELAUNAY
Hi Etienne, On 2/22/21 8:27 AM, Etienne Carriere wrote: Implement voltage regulators interfaced by the SCMI voltage domain protocol. The DT bindings are defined in the Linux kernel since SCMI voltage domain and regulators patches [1] and [2] integration in v5.11-rc7. Link: [1] https://github.c

Dead code CONFIG_ARMADA_39X?

2021-03-03 Thread Pali Rohár
Hello! I see in more U-Boot files check for ifdef CONFIG_ARMADA_39X but I do not see that CONFIG_ARMADA_39X could be defined in some header or board code. So does it mean that all code under ifdef CONFIG_ARMADA_39X is dead? Has U-Boot support for Marvell A39X SoC? If it is really dead code, shou

Re: [PATCH] net: use the same alias stem for ethernet as linux

2021-03-03 Thread David Wu
Hi Michael, Thank you for your patch, good complement. 在 2021/2/25 下午11:51, Michael Walle 写道: Linux uses the prefix "ethernet" whereas u-boot uses "eth". This is from the linux tree: $ grep "eth[0-9].*=.*&" arch/**/*dts{,i}|wc -l 0 $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l 633 In u-

[PATCH] arm: mvebu: Espressobin: Enable additional options

2021-03-03 Thread Pali Rohár
Enable support for NVMe disks which can be connected to mPCIe slot via M.2 reduction. Enable btrfs and squashfs filesystems which are used by more Linux distributions. And enable fsuuid and setexpr commands which can be useful in scripting. Signed-off-by: Pali Rohár --- configs/mvebu_espressobin

Re: [PATCH 2/2] mmc: fsl_esdhc_imx: remove redundant cmd11 related code.

2021-03-03 Thread Adam Ford
On Wed, Mar 3, 2021 at 3:18 AM wrote: > > From: Haibo Chen > > Common code already handle the voltage switch sequence based on spec, > so remove the redundant voltage switch code. > Nice! Thank you. This lets my eMMC run at HS400ES and the microSD card run as SDR104. For the series, Tested-by:

RE: [PATCH 1/2] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON to control card clock output

2021-03-03 Thread ZHIZHIKIN Andrey
Hello Haibo, > -Original Message- > From: haibo.c...@nxp.com > Sent: Wednesday, March 3, 2021 10:06 AM > To: peng@nxp.com; u-boot@lists.denx.de; sba...@denx.de > Cc: haibo.c...@nxp.com; uboot-...@nxp.com; thar...@gateworks.com; > ZHIZHIKIN Andrey ; > feste...@gmail.com; ye...@nxp.com

RE: [PATCH 2/2] mmc: fsl_esdhc_imx: remove redundant cmd11 related code.

2021-03-03 Thread ZHIZHIKIN Andrey
Hello Haibo, > -Original Message- > From: haibo.c...@nxp.com > Sent: Wednesday, March 3, 2021 10:06 AM > To: peng@nxp.com; u-boot@lists.denx.de; sba...@denx.de > Cc: haibo.c...@nxp.com; uboot-...@nxp.com; thar...@gateworks.com; > ZHIZHIKIN Andrey ; > feste...@gmail.com; ye...@nxp.com

[PULL] u-boot-usb/master

2021-03-03 Thread Marek Vasut
This should be the last one of the stuck USB PRs. The following changes since commit 78af81c345430a9088235f48d302922955d2499f: Merge tag 'rpi-next-2021.04.2' of https://source.denx.de/u-boot/custodians/u-boot-raspberrypi (2021-03-02 16:46:16 -0500) are available in the Git repository at:

Re: [PATCH] usb: mtu3: flush cache for next GPD

2021-03-03 Thread Marek Vasut
On 3/3/21 9:07 AM, Chunfeng Yun wrote: When flush cache of the current GPD and resume QMU, the controller will try to access the next GPD after processing the current one, if not flush the next GPD, the controller may get wrong GPD status. Applied, thanks

RE: [PATCH 2/2] mmc: fsl_esdhc_imx: remove redundant cmd11 related code.

2021-03-03 Thread ZHIZHIKIN Andrey
> -Original Message- > From: haibo.c...@nxp.com > Sent: Wednesday, March 3, 2021 10:06 AM > To: peng@nxp.com; u-boot@lists.denx.de; sba...@denx.de > Cc: haibo.c...@nxp.com; uboot-...@nxp.com; thar...@gateworks.com; > ZHIZHIKIN Andrey ; > feste...@gmail.com; ye...@nxp.com > Subject: [

Re: [PATCH v5 6/6] riscv: Enable watchdog for the k210

2021-03-03 Thread Leo Liang
On Tue, Dec 22, 2020 at 06:59:03PM -0500, Sean Anderson wrote: > This enables the necessary config options. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass > --- > > (no changes since v1) > > board/sipeed/maix/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/boa

Re: [PATCH] riscv: Remove unused define in maix header

2021-03-03 Thread Leo Liang
On Wed, Aug 05, 2020 at 12:42:19PM -0400, Sean Anderson wrote: > This define was left over from a previous revision, and was never used. > > Signed-off-by: Sean Anderson > Reviewed-by: Heinrich Schuchardt > Reviewed-by: Bin Meng > --- > > include/configs/sipeed-maix.h | 3 --- > 1 file change

Re: [PATCH] nvme: Elaborate on cache maintenance operation in get/set_features

2021-03-03 Thread Andre Przywara
On Wed, 3 Mar 2021 03:42:40 +0100 Marek Vasut wrote: Hi, > On 3/2/21 4:43 PM, Andre Przywara wrote: > > [...] > > > @@ -488,12 +489,20 @@ int nvme_get_features(struct nvme_dev *dev, unsigned > > fid, unsigned nsid, > > c.features.prp1 = cpu_to_le64(dma_addr); > > c.features.fid = cpu_

RE: [PATCH 2/2] mmc: fsl_esdhc_imx: remove redundant cmd11 related code.

2021-03-03 Thread Bough Chen
> -Original Message- > From: ZHIZHIKIN Andrey [mailto:andrey.zhizhi...@leica-geosystems.com] > Sent: 2021年3月3日 19:00 > To: Bough Chen ; Peng Fan ; > u-boot@lists.denx.de; sba...@denx.de > Cc: dl-uboot-imx ; thar...@gateworks.com; > feste...@gmail.com; Ye Li > Subject: RE: [PATCH 2/2] mmc:

[PATCH 0/5] Flexspi cleanups for ls1028a and lx2160a

2021-03-03 Thread Kuldeep Singh
This patch series aim is to make fspi cleanups for ls1028a and lx2160a. This includes defconfig and header cleanups. Kuldeep Singh (5): configs: lx2160a: Unset CONFIG_SPI_FLASH_SPANSION configs: lx2160a: Remove unused Flexspi config options configs: ls1028a: Unset CONFIG_SPI_FLASH_SPANSION

[PATCH 1/5] configs: lx2160a: Unset CONFIG_SPI_FLASH_SPANSION

2021-03-03 Thread Kuldeep Singh
There is no Spansion flash on LX2160A-RDB/QDS boards. Unset CONFIG_SPI_FLASH_SPANSION option for both the boards. Signed-off-by: Kuldeep Singh --- configs/lx2160aqds_tfa_SECURE_BOOT_defconfig | 1 - configs/lx2160aqds_tfa_defconfig | 1 - configs/lx2160ardb_tfa_SECURE_BOOT_defconfig

[PATCH 2/5] configs: lx2160a: Remove unused Flexspi config options

2021-03-03 Thread Kuldeep Singh
It is now safe to remove Flexspi configs NXP_FSPI_FLASH_SIZE and NXP_FSPI_FLASH_NUM options from headers as they are no longer used by driver anymore. Signed-off-by: Kuldeep Singh --- include/configs/lx2160a_common.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/configs/lx2160

[PATCH 5/5] configs: ls1028a: Correct CONFIG_ENV_SECT_SIZE

2021-03-03 Thread Kuldeep Singh
LS1028A-RDB/QDS has Micron "mt35xu02g" nor flash of size 256M with 128K sector size. Correct CONFIG_ENV_SECT_SIZE value to 128K. Signed-off-by: Kuldeep Singh --- configs/ls1028aqds_tfa_defconfig| 2 +- configs/ls1028aqds_tfa_lpuart_defconfig | 2 +- configs/ls1028ardb_tfa_defconfig

[PATCH 4/5] configs: ls1028aqds: Move CONFIG_SPI_FLASH_* definitions to defconfig

2021-03-03 Thread Kuldeep Singh
LS1028A-QDS has CONFIG_SPI_FLASH_SST and CONFIG_SPI_FLASH_EON defines present in header. Move these entries from header to defconfigs. Signed-off-by: Kuldeep Singh --- configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 2 ++ configs/ls1028aqds_tfa_defconfig | 2 ++ configs/ls1028aqds_tfa

[PATCH 3/5] configs: ls1028a: Unset CONFIG_SPI_FLASH_SPANSION

2021-03-03 Thread Kuldeep Singh
There is no Spansion flash on LS1028A-RDB/QDS boards. Unset CONFIG_SPI_FLASH_SPANSION option for both the boards. Signed-off-by: Kuldeep Singh --- configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 1 - configs/ls1028aqds_tfa_defconfig | 1 - configs/ls1028aqds_tfa_lpuart_defconfig

Re: [PATCH] Nokia RX-51: Enable CONFIG_CMD_BOOTD

2021-03-03 Thread Pali Rohár
On Wednesday 24 February 2021 01:27:29 Pali Rohár wrote: > CONFIG_CMD_BOOTD provides 'boot' command which is required in more scripts. > > Signed-off-by: Pali Rohár > --- > This patch applies cleanly on top of the patch "Nokia RX-51: Enable > usbtty serial console by default" [1] and CI testing p

Re: [PATCH] Nokia RX-51: Enable CONFIG_CMD_BOOTD

2021-03-03 Thread Lokesh Vutla
On 03/03/21 5:13 pm, Pali Rohár wrote: > On Wednesday 24 February 2021 01:27:29 Pali Rohár wrote: >> CONFIG_CMD_BOOTD provides 'boot' command which is required in more scripts. >> >> Signed-off-by: Pali Rohár >> --- >> This patch applies cleanly on top of the patch "Nokia RX-51: Enable >> usbtt

Re: [PATCH] Nokia RX-51: Enable CONFIG_CMD_BOOTD

2021-03-03 Thread Pali Rohár
On Wednesday 03 March 2021 17:26:22 Lokesh Vutla wrote: > On 03/03/21 5:13 pm, Pali Rohár wrote: > > On Wednesday 24 February 2021 01:27:29 Pali Rohár wrote: > >> CONFIG_CMD_BOOTD provides 'boot' command which is required in more scripts. > >> > >> Signed-off-by: Pali Rohár > >> --- > >> This patc

Re: [PATCH] Nokia RX-51: Enable CONFIG_CMD_BOOTD

2021-03-03 Thread Lukasz Majewski
On Wed, 3 Mar 2021 13:02:37 +0100 Pali Rohár wrote: > On Wednesday 03 March 2021 17:26:22 Lokesh Vutla wrote: > > On 03/03/21 5:13 pm, Pali Rohár wrote: > > > On Wednesday 24 February 2021 01:27:29 Pali Rohár wrote: > > >> CONFIG_CMD_BOOTD provides 'boot' command which is required in > > >> m

RE: [PATCH 2/2] mmc: fsl_esdhc_imx: remove redundant cmd11 related code.

2021-03-03 Thread ZHIZHIKIN Andrey
Hello Haibo, > -Original Message- > From: Bough Chen > Sent: Wednesday, March 3, 2021 12:27 PM > To: ZHIZHIKIN Andrey ; Peng Fan > ; u-boot@lists.denx.de; sba...@denx.de > Cc: dl-uboot-imx ; thar...@gateworks.com; > feste...@gmail.com; Ye Li > Subject: RE: [PATCH 2/2] mmc: fsl_esdhc_imx:

Re: [PATCH 0/5] lmb: Add config for the number of memory and reserved regions

2021-03-03 Thread Patrick DELAUNAY
Hi Tom, On 3/2/21 9:50 PM, Tom Rini wrote: On Tue, Feb 02, 2021 at 01:59:07PM +0100, Patrick Delaunay wrote: Hi, I propose a update of the lmb library to allow the configuration with Kconfig of the number of memory and reserved regions in lmb libary: - CONFIG_LMB_RESERVED_REGIONS - CONFIG_LMB

[PATCH u-boot] regmap: fix a serious pointer casting bug

2021-03-03 Thread Marek Behún
There is a serious bug in regmap_read() and regmap_write() functions where an uint pointer is cast to (void *) which is then cast to (u8 *), (u16 *), (u32 *) or (u64 *), depending on register width of the map. For example given a regmap with 16-bit register width the code int val = 0x12340

Re: [PATCH 16/20] dm: core: Correctly read of simple-bus

2021-03-03 Thread Tom Rini
On Tue, Mar 02, 2021 at 11:34:47PM +0800, Bin Meng wrote: > At present we decode simple bus using the following assumption: > > - parent #address-cells 1 > - child #address-cells 1 > - child #size-cells 1 > > However this might not always be the case. > > Update to use fdt_addr_t and fdt_size_

Re: [PATCH] fs/squashfs: Fix compilation error

2021-03-03 Thread Tom Rini
On Wed, Mar 03, 2021 at 10:52:36AM +0100, Pali Rohár wrote: > Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop > asm/global_data.h from common header") broke compilation of squashfs > filesystem when CONFIG_CMD_SQUASHFS=y is enabled. > > Compilation is failing on error: > > aar

Re: [PATCH v2] arm: Add support for Kobol Helios64 board

2021-03-03 Thread Christian Glombek
Oh, thanks for the pointer! I guess I should've had another look at the archive before posting the patch. If you see this Uwe, thanks for taking it on :) On Tue, Mar 2, 2021 at 7:27 PM Dennis Gilmore wrote: > Uwe submitted this board last Thursday > > Dennis > > On Tue, Mar 2, 2021 at 10:46 AM

[PATCH] arm: a37xx: pci: Implement workaround for the readback value of VEND_ID

2021-03-03 Thread Pali Rohár
Marvell Armada 3720 Functional Errata, Guidelines, and Restrictions document describes in erratum 4.1 PCIe value of vendor ID (Ref #: 243): The readback value of VEND_ID (RD007h [15:0]) is 1B4Bh, while it should read 11ABh. The firmware can write the correct value, 11ABh, through

[PATCH v3 1/2] arm: dts: imx8mm: add Gateworks i.MX8 Mini Dev kits

2021-03-03 Thread sbabic
> Add Gateworks i.MX 8M Mini Development kits from Linux-5.12-rc1 > Signed-off-by: Tim Harvey Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, Managing Director: Wolf

[PATCH V4] ARM: imx: Include u-boot.img in u-boot-with-spl.imx if OF_SEPARATE=y

2021-03-03 Thread sbabic
> The u-boot-with-spl.imx is a concatenation of SPL and u-boot.uim. > The u-boot.uim is u-boot.bin wrapped in uImage. In case OF_SEPARATE > is enabled, the u-boot.bin does not contain control DT for U-Boot, > and so u-boot.uim does not contain the DT, and so u-boot-with-spl.imx > does not contain t

[PATCH v3 2/2] board: gateworks: imx8mm: Add Gateworks Venice board support

2021-03-03 Thread sbabic
> Add initial support for Gateworks Venice product family based on the > i.MX 8M Mini SoC > Signed-off-by: Tim Harvey Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH,

Pull request: u-boot-imx u-boot-imx-20210003

2021-03-03 Thread Stefano Babic
/custodians/u-boot-imx.git tags/u-boot-imx-20210303 for you to fetch changes up to 03bf8436a3a5b19ff4ae23868dd479acc050ff08: board: gateworks: imx8mm: Add Gateworks Venice board support (2021-03-03 14:15:02 +0100) i.MX for 2021.04

Re: [PULL] u-boot-usb/master

2021-03-03 Thread Tom Rini
On Wed, Mar 03, 2021 at 11:57:09AM +0100, Marek Vasut wrote: > This should be the last one of the stuck USB PRs. > > The following changes since commit 78af81c345430a9088235f48d302922955d2499f: > > Merge tag 'rpi-next-2021.04.2' of > https://source.denx.de/u-boot/custodians/u-boot-raspberrypi

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-03 Thread Tom Rini
On Wed, Mar 03, 2021 at 05:11:59AM +0100, Marek Behún wrote: > Hello, > > I have managed to add support for building U-Boot with LTO (with GCC) > in a rather sane way (in LOC changed). > > This series and its follows will also be available at > https://github.com/elkablo/u-boot branch lto. > >

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-03 Thread Marek Behun
On Wed, 3 Mar 2021 11:11:59 -0500 Tom Rini wrote: > On Wed, Mar 03, 2021 at 05:11:59AM +0100, Marek Behún wrote: > > > Hello, > > > > I have managed to add support for building U-Boot with LTO (with GCC) > > in a rather sane way (in LOC changed). > > > > This series and its follows will also b

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-03 Thread Tom Rini
On Wed, Mar 03, 2021 at 05:41:57PM +0100, Marek Behun wrote: > On Wed, 3 Mar 2021 11:11:59 -0500 > Tom Rini wrote: > > > On Wed, Mar 03, 2021 at 05:11:59AM +0100, Marek Behún wrote: > > > > > Hello, > > > > > > I have managed to add support for building U-Boot with LTO (with GCC) > > > in a rat

Re: [PATCH 00/20] ppc: qemu: Add eTSEC support

2021-03-03 Thread Tom Rini
On Wed, Mar 03, 2021 at 10:11:45AM +0800, Bin Meng wrote: > Hi Simon, > > On Wed, Mar 3, 2021 at 9:53 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Tue, 2 Mar 2021 at 18:08, Bin Meng wrote: > > > > > > Hi Tom, > > > > > > On Tue, Mar 2, 2021 at 11:35 PM Bin Meng wrote: > > > > > > > > QEMU p

Re: [PATCH 00/20] ppc: qemu: Add eTSEC support

2021-03-03 Thread Simon Glass
Hi Bin, On Wed, 3 Mar 2021 at 09:49, Tom Rini wrote: > > On Wed, Mar 03, 2021 at 10:11:45AM +0800, Bin Meng wrote: > > Hi Simon, > > > > On Wed, Mar 3, 2021 at 9:53 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Tue, 2 Mar 2021 at 18:08, Bin Meng wrote: > > > > > > > > Hi Tom, > > > >

Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-03-03 Thread Harry Waschkeit
On 03.03.21 00:06, Sean Anderson wrote: On 3/2/21 1:09 PM, Harry Waschkeit wrote: Hello Sean, On 02.03.21 00:10, Sean Anderson wrote: On 3/1/21 11:39 AM, Harry Waschkeit wrote: Hi again, gentle ping for that patch, also in view of subsequently sent patch ...   https://lists.denx.de/piperma

RE: [EXTERNAL] Re: U-Boot ECDSA Implementation Question

2021-03-03 Thread Tim Romanski
On 2/22/21 6:33 PM, Alex G. wrote: > Verification on the target would be great. My implementation is > platform-specific. It would make sense to also have a software implementation > of ECDSA (as we do for RSA). Once that is in place, it opens the gates for > unit-testing. Currently, we're only

Re: Pull request: u-boot-imx u-boot-imx-20210003

2021-03-03 Thread Tom Rini
1-02-26 > 15:11:08 -0500) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git > tags/u-boot-imx-20210303 > > for you to fetch changes up to 03bf8436a3a5b19ff4ae23868dd479acc050ff08: > > board: gateworks: imx8mm:

Re: [PATCH 1/4] nds32: Remove dead reset_cpu() implementation

2021-03-03 Thread Tom Rini
On Tue, Dec 15, 2020 at 04:47:49PM +0100, Harald Seiler wrote: > nds32 is one of the only architectures which still have a reset_cpu() > implementation that makes use of the `addr` parameter. The rest of > U-Boot now ignores it and passes 0 everywhere. It turns out that even > here, reset_cpu()

Re: [PATCH 2/4] board: ns3: Remove superfluous reset logic

2021-03-03 Thread Tom Rini
On Tue, Dec 15, 2020 at 04:47:50PM +0100, Harald Seiler wrote: > The current implementation of reset_cpu() in the ns3 board code does not > archieve what it is supposed to (according to the comments), due to > a number of reasons: > > 1. The argument to reset_cpu() is _not_ actually passed from

Re: [PATCH 3/4] Revert "lpc32xx: cpu: add support for soft reset"

2021-03-03 Thread Tom Rini
On Tue, Dec 15, 2020 at 04:47:51PM +0100, Harald Seiler wrote: > This reverts commit 576007aec9a4a5f4f3dd1f690fb26a8c05ceb75f. > > The paramter passed to reset_cpu() no longer holds a meaning as all > call-sites now pass the value 0. Thus, branching on it is essentially > dead code and will just

Re: [PATCH 4/4] reset: Remove addr parameter from reset_cpu()

2021-03-03 Thread Tom Rini
On Tue, Dec 15, 2020 at 04:47:52PM +0100, Harald Seiler wrote: > Historically, the reset_cpu() function had an `addr` parameter which was > meant to pass in an address of the reset vector location, where the CPU > should reset to. This feature is no longer used anywhere in U-Boot as > all reset_c

Re: [PATCH 1/8] stm32mp: update MMU config before the relocation

2021-03-03 Thread Tom Rini
On Fri, Feb 05, 2021 at 01:53:32PM +0100, Patrick Delaunay wrote: > Mark the top of ram, used for relocated U-Boot as a normal memory > (cacheable and executable) to avoid permission access issue when > U-Boot jumps to this relocated code. > > When MMU is activated in pre-reloc stage; only the be

Re: [PATCH 2/8] stm32mp: update the mmu configuration for SPL and prereloc

2021-03-03 Thread Tom Rini
On Fri, Feb 05, 2021 at 01:53:33PM +0100, Patrick Delaunay wrote: > Overidde the weak function dram_bank_mmu_setup() to set the DDR > (preloc case) or the SYSRAM (in SPL case) executable before to enable > the MMU and configure DACR. > > This weak function is called in dcache_enable/mmu_setup. >

Re: [PATCH 4/8] arm: cosmetic: align TTB_SECT define value

2021-03-03 Thread Tom Rini
On Fri, Feb 05, 2021 at 01:53:35PM +0100, Patrick Delaunay wrote: > Align TTB_SECT define value with previous value. > > Signed-off-by: Patrick Delaunay Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 5/8] arm: cp15: update DACR value to activate access control

2021-03-03 Thread Tom Rini
On Fri, Feb 05, 2021 at 01:53:36PM +0100, Patrick Delaunay wrote: > Update the initial value of Domain Access Control Register (DACR) > and set by default the access permission to client (DACR_Dn_CLIENT = 1U) > for each of the 16 domains and no more to all-supervisor > (DACR_Dn_MANAGER = 3U). > >

Re: [PATCH 3/8] arm: remove TTB_SECT_XN_MASK in DCACHE_WRITETHROUGH

2021-03-03 Thread Tom Rini
On Fri, Feb 05, 2021 at 01:53:34PM +0100, Patrick Delaunay wrote: > The normal memory (other that DCACHE_OFF) should be executable by default, > only the device memory (DCACHE_OFF) used for peripheral access should have > the bit execute never (TTB_SECT_XN_MASK). > > Signed-off-by: Patrick Delaun

Re: [PATCH 6/8] arm: omap2: remove arm_init_domains

2021-03-03 Thread Tom Rini
On Fri, Feb 05, 2021 at 01:53:37PM +0100, Patrick Delaunay wrote: > Remove the arm_init_domains and the DACR update, as it is now done > in ARMv7 CP15 level. > > Signed-off-by: Patrick Delaunay Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 7/8] arm: cp15: remove weak function arm_init_domains

2021-03-03 Thread Tom Rini
On Fri, Feb 05, 2021 at 01:53:38PM +0100, Patrick Delaunay wrote: > Remove the unused weak function arm_init_domains used to change the > DACR value. > > Signed-off-by: Patrick Delaunay Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 8/8] arm: remove set_dacr/get_dacr functions

2021-03-03 Thread Tom Rini
On Fri, Feb 05, 2021 at 01:53:39PM +0100, Patrick Delaunay wrote: > Remove the unused function set_dacr/get_dacr > > Serie-cc: Ard Biesheuvel > Serie-cc: R Sricharan > Signed-off-by: Patrick Delaunay Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 1/9] spl: Drop duplicate 'Jumping to U-Boot' message

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 09:57:27AM -0700, Simon Glass wrote: > This is printed twice but we only need one message, since there is very > little processing in between them. Drop the second one, since all branches > of the switch() already have output. Update the U-Boot message to include > the phas

Re: [PATCH v4 2/9] binman: Indicate how to make binman verbose

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 09:57:28AM -0700, Simon Glass wrote: > Add notes about how to make binman produce verbose logging when building. > > Add a comment on how to do this. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 3/9] doc: describe the md command

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 09:57:29AM -0700, Simon Glass wrote: > Provide a man-page for the md command. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 4/9] doc: Add a note about producing 'md.b' output using hexdump

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 09:57:30AM -0700, Simon Glass wrote: > Comparing a hex dump on the U-Boot command line with the contents of a > file on the host system is fairly easy and convenient to do manually if > it is small. But the format used hexdump by default differs from that > shown by U-Boot.

Re: [PATCH v4 5/9] s5p4418_nanopi2: Drop dead code

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 09:57:31AM -0700, Simon Glass wrote: > This code is still using the old command typedef. It was not noticed since > this file is not currently built. It is using a non-existent option in the > Makefile. > > Drop this file since it is not needed for correct operation. > >

Re: [PATCH v4 6/9] sandbox: Add os_realloc()

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 09:57:32AM -0700, Simon Glass wrote: > We provide os_malloc() and os_free() but not os_realloc(). Add this, > following the usual semantics. Also update os_malloc() to behave correctly > when passed a zero size. > > Signed-off-by: Simon Glass > Reviewed-by: Heinrich Schuc

Re: [PATCH v4 7/9] sandbox: Avoid using malloc() for system state

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 09:57:33AM -0700, Simon Glass wrote: > This state is not accessible to the running U-Boot but at present it is > allocated in the emulated SDRAM. This doesn't seem very useful. Adjust > it to allocate from the OS instead. > > The RAM buffer is currently not freed, but shou

Re: [PATCH v4 8/9] sandbox: Write out bloblist when exiting

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 09:57:34AM -0700, Simon Glass wrote: > Sandbox provides a way to write out its emulated memory on exit. This > makes it possible to pass a bloblist from one phase (e.g. SPL) to the > next. > > However the bloblist is not closed off, so the checksum is generally > invalid.

Re: [PATCH v4 9/9] bootm: Fix duplicate debugging in bootm_process_cmdline()

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 09:57:35AM -0700, Simon Glass wrote: > These two returns use the same string so are not distinguishable with > LOG_ERROR_RETURN. Fix it. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 03/11] tpm: Add debugging of request in tpm_sendrecv_command()

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:34PM -0700, Simon Glass wrote: > The response is shown but not the request. Update the code to show both > if debugging is enabled. > > Use a 'uint' type for size so it matches the register-word size on both > 32- and 64-bit machines. > > Signed-off-by: Simon Glass

Re: [PATCH v4 01/11] tpm: Don't include cr50 in TPL/SPL

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:32PM -0700, Simon Glass wrote: > At present the security chip is not used in these U-Boot phases. Update > the Makefile to exclude it. > > Fix a few logging statements while we are here. > > Signed-off-by: Simon Glass > Reviewed-by: Ilias Apalodimas Applied to u-

Re: [PATCH v4 04/11] tpm: Add an API that can support v1.2 and v2

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:35PM -0700, Simon Glass wrote: > There are two different TPM standards. U-Boot supports both but each has > its own set of functions. We really need a single TPM API that can call > one or the other. This is not always possible as there are some > differences between

Re: [PATCH v4 02/11] tpm: Use logging in the uclass

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:33PM -0700, Simon Glass wrote: > Update this to use log_debug() instead of the old debug(). > > Signed-off-by: Simon Glass > Reviewed-by: Ilias Apalodimas Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 05/11] tpm: Switch TPMv1 over to use the new API

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:36PM -0700, Simon Glass wrote: > Take over the plain 'tpm_...' functions for use by the new TPM API. Rename > all the TPMv1 functions so they are called from the API. > > Update the TPMv1 functions so that they are called from the API. Change > existing users to use

Re: [PATCH v4 06/11] tpm: Add a basic API implementation for TPMv2

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:37PM -0700, Simon Glass wrote: > Add support for TPMv2 versions of API functions. So far this is not > complete as the standard is quite large, but it implements everything > currently available for TPMv2 in U-Boot. > > Signed-off-by: Simon Glass > Acked-by: Ilias A

Re: [PATCH v4 07/11] tpm: Reduce duplication in a few functions

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:38PM -0700, Simon Glass wrote: > Update tpm2_clear() and tpm2_pcr_extend() so that the command size > is not repeated twice. Add a small comment to the latter. > > Signed-off-by: Simon Glass > Reviewed-by: Ilias Apalodimas Applied to u-boot/next, thanks! -- Tom

Re: [PATCH v4 08/11] tpm: Add an implementation of define_space

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:39PM -0700, Simon Glass wrote: > Add support for this so that the TPM can be set up for use with > Chromium OS verified boot. > > Signed-off-by: Simon Glass > Acked-by: Ilias Apalodimas Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP sign

Re: [PATCH v4 09/11] tpm: Add TPM2 support for read/write values

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:40PM -0700, Simon Glass wrote: > Implement this API function for TPM2. > > Signed-off-by: Simon Glass > Acked-by: Ilias Apalodimas Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 10/11] tpm: Add TPM2 support for write_lock

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:41PM -0700, Simon Glass wrote: > Implement this API function for TPM2. > > Signed-off-by: Simon Glass > Acked-by: Ilias Apalodimas Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 11/11] tpm: Allow disabling platform hierarchy with TPM2

2021-03-03 Thread Tom Rini
On Sat, Feb 06, 2021 at 02:23:42PM -0700, Simon Glass wrote: > With TPM2 we don't actually lock the TPM once verified boot is finished. > Instead we disable the platform hierarchy which serves the same purpose. > Add an implementation of this so we can safely boot into the kernel. > > Signed-off-

Re: [PATCH v3 00/41] test: Refactor tests to have a single test runner

2021-03-03 Thread Tom Rini
On Wed, Feb 03, 2021 at 05:44:06AM -0700, Simon Glass wrote: > At present U-Boot has two broad sets of tests in the C code: driver model > tests which do a lot of pre-/post-init and command tests which do not. > > This separation makes it slightly harder to write a test, since there are > two dif

Re: [PATCH v3 00/41] test: Refactor tests to have a single test runner

2021-03-03 Thread Tom Rini
On Wed, Mar 03, 2021 at 02:37:51PM -0500, Tom Rini wrote: > On Wed, Feb 03, 2021 at 05:44:06AM -0700, Simon Glass wrote: > > > At present U-Boot has two broad sets of tests in the C code: driver model > > tests which do a lot of pre-/post-init and command tests which do not. > > > > This separati

Re: [PATCH v3 00/41] test: Refactor tests to have a single test runner

2021-03-03 Thread Tom Rini
On Wed, Mar 03, 2021 at 03:18:15PM -0500, Tom Rini wrote: > On Wed, Mar 03, 2021 at 02:37:51PM -0500, Tom Rini wrote: > > On Wed, Feb 03, 2021 at 05:44:06AM -0700, Simon Glass wrote: > > > > > At present U-Boot has two broad sets of tests in the C code: driver model > > > tests which do a lot of p

Re: [PATCH v4 05/16] gpio: Drop dm_gpio_set_dir()

2021-03-03 Thread Tom Rini
On Thu, Feb 04, 2021 at 09:21:58PM -0700, Simon Glass wrote: > This function is not used. Drop it. > > Signed-off-by: Simon Glass > > Reviewed-by: Patrick Delaunay I'm dropping this patch as it seems to be an explicit break of: commit 6befb51f349459c96ed64412070feda7472cf152 Author: Harm Bern

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-03 Thread Tom Rini
On Wed, Mar 03, 2021 at 05:41:57PM +0100, Marek Behun wrote: > On Wed, 3 Mar 2021 11:11:59 -0500 > Tom Rini wrote: > > > On Wed, Mar 03, 2021 at 05:11:59AM +0100, Marek Behún wrote: > > > > > Hello, > > > > > > I have managed to add support for building U-Boot with LTO (with GCC) > > > in a rat

Re: make O=directory parameter

2021-03-03 Thread Fred 1
On 26/2/21 11:58 pm, Tom Rini wrote: On Fri, Feb 26, 2021 at 10:27:46PM +1100, Fred 1 wrote: On 26/2/21 2:35 am, Tom Rini wrote: On Thu, Feb 25, 2021 at 12:50:47PM +1100, Fred 1 wrote: like in the linux kernel build make O=builds/arm builds the result to the specified output directory i

Re: [PATCH] JFFS2: fix the reading address over nand's limit

2021-03-03 Thread Wagner Popov dos Santos
Forgot to Cc the maintainer, doing it now, sorry for the spam. Em seg, 2021-02-22 às 23:30 -0300, Wagner Popov dos Santos escreveu: > Fixes address violation in functions read_nand_cached() and > read_onenand_cached(). This happens because these functions > try to read a fixed amount > of data eve

Re: [PATCH] JFFS2: fix jffs2 summary datacrc status uninitialized

2021-03-03 Thread Wagner Popov dos Santos
Forgot to Cc the maintainer, doing it now, sorry for the spam. On ter, 2021-02-23 às 00:49 -0300, Wagner Popov dos Santos wrote: > The function jffs2_1pass_read_inode() was discarding the summary > inodes and dirent because the value in datacrc flag wasn't > initialized in function jffs2_sum_proce

Re: [RFC PATCH u-boot 05/12] binman: declare symbols externally visible

2021-03-03 Thread Tom Rini
On Wed, Mar 03, 2021 at 05:12:04AM +0100, Marek Behún wrote: > Use the `__visible` macro to declare binman symbols externally visible, > so that when building with LTO the compiler does not optimize this data > away. > > Signed-off-by: Marek Behún > --- > include/binman.h | 1 + > include/b

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-03 Thread Adam Ford
On Wed, Mar 3, 2021 at 3:36 PM Tom Rini wrote: > > On Wed, Mar 03, 2021 at 05:41:57PM +0100, Marek Behun wrote: > > On Wed, 3 Mar 2021 11:11:59 -0500 > > Tom Rini wrote: > > > > > On Wed, Mar 03, 2021 at 05:11:59AM +0100, Marek Behún wrote: > > > > > > > Hello, > > > > > > > > I have managed to a

Re: [PATCH v3 04/38] ppc: qemu: Support non-identity PCI bus address

2021-03-03 Thread Bin Meng
Hi Simon, On Tue, Mar 2, 2021 at 2:34 PM Priyanka Jain (OSS) wrote: > > > > >-Original Message- > >From: Bin Meng > >Sent: Monday, March 1, 2021 1:25 PM > >To: Priyanka Jain (OSS) > >Cc: Simon Glass ; Alexander Graf ; U- > >Boot Mailing List ; Tom Rini > >Subject: Re: [PATCH v3 04/38]

Re: u-boot on RPi4 32bit - issue after upgrading the firmware

2021-03-03 Thread Jaehoon Chung
Hi, On 2/25/21 8:11 PM, Marek Szyprowski wrote: > Hi Nicolas, > > On 25.02.2021 11:55, Nicolas Saenz Julienne wrote: >> On Thu, 2021-02-25 at 11:43 +0100, Marek Szyprowski wrote: >>> Recently I've upgraded a video core firmware on my RPi4 and I've noticed >>> that u-boot in ARM 32bit mode stopped

Re: [PATCH 01/19] sunxi: video: select dw-hdmi in Kconfig, not Makefile

2021-03-03 Thread Andre Przywara
On Tue, 23 Feb 2021 21:46:13 +0100 Jernej Skrabec wrote: > Currently sunxi Makefile manually specifies full path to dw-hdmi common > code. However, that is not needed because it can be selected in Kconfig > instead. > > Select proper symbol in Kconfig and drop path from Makefile. Ah, indeed. Go

Re: [PATCH 02/19] video: sunxi: Add mode_valid callback to sunxi_dw_hdmi

2021-03-03 Thread Andre Przywara
On Tue, 23 Feb 2021 21:46:14 +0100 Jernej Skrabec wrote: > Currently driver accepts all resolution which won't work on 4k screens. > Add validation callback which limits acceptable resolutions to 297 MHz. Makes sense. Newer SoCs seem to support more, but apparently not without further code to en

Re: [PATCH 03/19] common: edid: check for digital display earlier

2021-03-03 Thread Andre Przywara
On Tue, 23 Feb 2021 21:46:15 +0100 Jernej Skrabec wrote: Hi, > When searching for detailed timing in EDID, check for digital display > earlier. There is no point parsing other parameters if this flag is not > present. Indeed we would exit anyway, so we should avoid unneeded work. > Signed-off

  1   2   >