[GIT PULL] please pull NXP i.MX

2020-07-14 Thread Peng Fan
Hi Stefano, This is collect of patches that pending in patchwork and some new patches posted recently. The PR is rebased on Tom's master branch since imx/master was not up to date, should I do the PR based on imx/master? CI: https://travis-ci.org/github/MrVan/u-boot/builds/707889918 ---

RE: [PATCH] mmc: Parse new binding for eMMC fixed driver type

2020-07-14 Thread Peng Fan
> Subject: [PATCH] mmc: Parse new binding for eMMC fixed driver type > > Parse the new binding and store it in the mmc config struct after doing some > sanity checks. The code is designed to support fixed mmc driver type if we > ever need that. > > Signed-off-by: Shunsuke Tokumoto > Signed-off-b

[GIT PULL] please pull mmc-7-24-2020

2020-07-14 Thread Peng Fan
Hi Tom, Please pull mmc-7-24-2020 Correct mmc_spi check condition Generate R1/R2/R1b response Read SSR for SD SPI CI: https://travis-ci.org/github/MrVan/u-boot/builds/707901966 Thanks, Peng. The following changes since c

Re: Pinebook Pro keyboard (RK3399 OHCI)?

2020-07-14 Thread Peter Robinson
On Tue, Jul 14, 2020 at 12:02 AM Simon South wrote: > > Has anyone managed to get the built-in keyboard of the Pinebook Pro > working with U-Boot? It should be fixed in the main devel repo, commit 3a5771249 > Kever, Jagan: Are you aware of any special setup required to have the > RK3399's OHCI c

[PATCH v5 0/5] roc-rk3399-pc: Custom SPL

2020-07-14 Thread Jagan Teki
This series supports custom initialization code required for roc-rk3399-pc board on SPL stage. Now this series is well mature code handling to add custom spl_board_init code parts. roc-rk3399-pc would require custom leds initialization based on user intervention of the power key. This code han

[PATCH v5 1/5] roc-rk3399-pc: Move leds setup in SPL

2020-07-14 Thread Jagan Teki
roc-rk3399-pc has some specific requirements to support LEDS, environment. board detection and etc prior to U-Boot proper. So as of now SPL would be a better stage for these custom board requirements to support unlike TPL. Adding few of these custom requirements like LEDS in TPL would require extr

[PATCH v5 4/5] rockchip: spl: Move board_early_init_f after cpu timer

2020-07-14 Thread Jagan Teki
Custom board_early_init_f not only deal with simple gpio configuration but also have a possibility to access clocks to process any clock related operations like checking reset cause state and etc. So, call it once the rockchip timer initialization done instead of calling first place of board_init_

[PATCH v5 5/5] roc-rk3399-pc: Set LED only during POR and pwr_key=y

2020-07-14 Thread Jagan Teki
ROC-RK3399-PC has specific set of configurations for on-board led setup. Due to easiness for user to know the state of the board roc-rk339-pc board code will setup the low power led on/off, and waiting for user to press power key and then glow full power led. All this needs to happen only during

[PATCH v5 3/5] rockchip: Separate the reset cause from display cpuinfo

2020-07-14 Thread Jagan Teki
reset cause is a generic functionality based on the soc cru registers in rockchip. This can be used for printing the cause of reset in cpuinfo or some other place where reset cause is needed.  Other than cpuinfo, reset cause can also be using during bootcount for checking the specific reset cause

[PATCH v5 2/5] rockchip: Don't clear the reset status reg

2020-07-14 Thread Jagan Teki
reset reason can be used several stages of U-Boot bootloader like SPL, U-Boot proper based on the requirements. Clearing the status register end of get_reset_cause will end up showing the wrong reset cause when it read the second time. For example, if board resets, SPL reads the reset status as RS

Re: [GIT PULL] please pull NXP i.MX

2020-07-14 Thread Stefano Babic
Hi Peng, On 14.07.20 09:36, Peng Fan wrote: > Hi Stefano, > > This is collect of patches that pending in patchwork and some new patches > posted recently. > The PR is rebased on Tom's master branch since imx/master was not up to date, > should I do the PR based on imx/master? > CI: https://trav

RE: [PATCH v1 3/4] clk: agilex: Handle clock configuration differently in SPL and U-Boot proper

2020-07-14 Thread Tan, Ley Foon
> -Original Message- > From: Ang, Chee Hong > Sent: Friday, July 10, 2020 8:55 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Simon Goldschmidt > ; See, Chin Liang > ; Tan, Ley Foon ; Ang, > Chee Hong > Subject: [PATCH v1 3/4] clk: agilex: Handle clock configuration differently in >

RE: [PATCH v1 4/4] clk: agilex: Additional membus writes for HPS PLL

2020-07-14 Thread Tan, Ley Foon
> -Original Message- > From: Ang, Chee Hong > Sent: Friday, July 10, 2020 8:55 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Simon Goldschmidt > ; See, Chin Liang > ; Tan, Ley Foon ; Ang, > Chee Hong > Subject: [PATCH v1 4/4] clk: agilex: Additional membus writes for HPS PLL > > A

RE: [PATCH] arm: socfpga: soc64: Remove PHY interface setup from misc arch init

2020-07-14 Thread Tan, Ley Foon
> -Original Message- > From: Ang, Chee Hong > Sent: Friday, July 10, 2020 11:53 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Simon Goldschmidt > ; See, Chin Liang > ; Tan, Ley Foon ; Ang, > Chee Hong > Subject: [PATCH] arm: socfpga: soc64: Remove PHY interface setup from > misc ar

RE: [PATCH] arm: socfpga: soc64: Initialize timer in SPL only

2020-07-14 Thread Tan, Ley Foon
> -Original Message- > From: Ang, Chee Hong > Sent: Friday, July 10, 2020 11:53 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Simon Goldschmidt > ; See, Chin Liang > ; Tan, Ley Foon ; Ang, > Chee Hong > Subject: [PATCH] arm: socfpga: soc64: Initialize timer in SPL only > > Timer o

[PATCH 1/1] efi_loader: restructure code for TEE variables

2020-07-14 Thread Heinrich Schuchardt
When using secure boot functions needed both for file and TEE based UEFI variables have to be moved to the common code module efi_var_common.c. Signed-off-by: Heinrich Schuchardt --- include/efi_variable.h | 7 ++ lib/efi_loader/efi_var_common.c | 155 +++

[PATCH 1/1] efi_loader: update secure state

2020-07-14 Thread Heinrich Schuchardt
Update the UEFI secure state when variable 'PK' is updated in the TEE variables implementation. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_variable_tee.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/efi_loader/efi_variable_tee.c b/lib/efi_loader/efi_variable_te

Re: [PATCH] memsize: Make get_ram_size() work with arbitary RAM size

2020-07-14 Thread Bin Meng
Hi Wolfgang, On Tue, Jul 14, 2020 at 1:18 AM Wolfgang Denk wrote: > > Dear Bin Meng, > > In message <1594378641-26360-1-git-send-email-bmeng...@gmail.com> you wrote: > > > > Currently get_ram_size() only works with certain RAM size like 1GiB, > > 2GiB, 4GiB, 8GiB, etc. Chanage the codes to work w

Re: Pinebook Pro keyboard (RK3399 OHCI)?

2020-07-14 Thread Simon South
Peter Robinson writes: > It should be fixed in the main devel repo, commit 3a5771249 That commit enables the OHCI driver but doesn't lead to a working keyboard, at least for me. Have you actually tested this successfully on a PBP? (Has anyone else?) I wonder if there's something different about

Re: Pinebook Pro keyboard (RK3399 OHCI)?

2020-07-14 Thread Peter Robinson
On Tue, Jul 14, 2020 at 11:50 AM Simon South wrote: > > Peter Robinson writes: > > It should be fixed in the main devel repo, commit 3a5771249 > > That commit enables the OHCI driver but doesn't lead to a working > keyboard, at least for me. > > Have you actually tested this successfully on a PBP

[PATCH 1/1] doc: provide links to Microsoft UEFI certificates

2020-07-14 Thread Heinrich Schuchardt
Some distributions provide UEFI binaries like Shim that have been signed using a Microsoft certificate. Provide the download paths for the public keys. Signed-off-by: Heinrich Schuchardt --- doc/uefi/uefi.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/uefi/uefi.rst b/doc/ue

Re: [PATCH 1/1] efi_loader: update secure state

2020-07-14 Thread ilias . apalodimas
On Tue, Jul 14, 2020 at 12:06:56PM +0200, Heinrich Schuchardt wrote: > Update the UEFI secure state when variable 'PK' is updated in the TEE > variables implementation. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_variable_tee.c | 8 > 1 file changed, 8 insertions(+

Re: [PATCH 1/1] efi_loader: update secure state

2020-07-14 Thread Ilias Apalodimas
On Tue, 14 Jul 2020 at 14:14, wrote: > > On Tue, Jul 14, 2020 at 12:06:56PM +0200, Heinrich Schuchardt wrote: > > Update the UEFI secure state when variable 'PK' is updated in the TEE > > variables implementation. > > > > Signed-off-by: Heinrich Schuchardt > > --- > > lib/efi_loader/efi_variable

RE: [PATCH v1 3/4] clk: agilex: Handle clock configuration differently in SPL and U-Boot proper

2020-07-14 Thread Ang, Chee Hong
> > From: Ang, Chee Hong > > Sent: Friday, July 10, 2020 8:55 PM > > To: u-boot@lists.denx.de > > Cc: Marek Vasut ; Simon Goldschmidt > > ; See, Chin Liang > > ; Tan, Ley Foon ; > > Ang, Chee Hong > > Subject: [PATCH v1 3/4] clk: agilex: Handle clock configuration > > differently in SPL and U-Boo

Re: [PATCH] memsize: Make get_ram_size() work with arbitary RAM size

2020-07-14 Thread Wolfgang Denk
Dear Bin Meng, In message you wrote: > > > I'm afraid I don't understand this change, Can you please explain a > > bit more detailed what "any RAM size" means? > > I meant "any RAM size" that is not power of two. I was afraid you meant this. > > The existing code should work fine with any RAM

Re: Pull request for UEFI sub-system for efi-2020-10-rc1 (3)

2020-07-14 Thread Tom Rini
On Mon, Jul 13, 2020 at 12:42:55PM +0200, Heinrich Schuchardt wrote: > The following changes since commit 4a9146c29573dbfa661918280d9522a01f6ca919: > > Merge tag 'dm-pull-10jul20' of > https://gitlab.denx.de/u-boot/custodians/u-boot-dm (2020-07-10 16:22:57 > -0400) > > are available in the Git

Re: Using gerrit or github for review?

2020-07-14 Thread Tom Rini
On Tue, Jul 14, 2020 at 08:09:23AM +0200, Michal Simek wrote: > > > On 13. 07. 20 22:36, Tom Rini wrote: > > On Mon, Jul 13, 2020 at 12:25:42PM -0600, Simon Glass wrote: > > > >> Hi, > >> > >> At present U-Boot uses the mailing list for patch review. What do > >> people think about trying out ge

Re: [PATCH v2 17/44] sound: Add an ACPI driver for Maxim MAX98357ac

2020-07-14 Thread Simon Glass
Hi Bin, On Mon, 13 Jul 2020 at 23:01, Bin Meng wrote: > > Hi Simon, > > On Tue, Jul 14, 2020 at 9:28 AM Bin Meng wrote: > > > > Hi Simon, > > > > On Wed, Jul 8, 2020 at 11:33 AM Simon Glass wrote: > > > > > > This chip is used on coral and we need to generate ACPI tables for sound > > > to make

Re: [PATCH v1 07/43] dm: acpi: Add support for the NHLT table

2020-07-14 Thread Simon Glass
Hi Bin, On Mon, 13 Jul 2020 at 00:10, Bin Meng wrote: > > Hi Simon, > > On Mon, Jul 13, 2020 at 3:37 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Tue, 7 Jul 2020 at 21:25, Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Mon, 6 Jul 2020 at 18:22, Bin Meng wrote: > > > > > > > > Hi Sim

Re: [PATCH 1/2] patman: Make sure sendemail.suppresscc is (un)set correctly

2020-07-14 Thread Simon Glass
On Sun, 12 Jul 2020 at 20:50, Nicolas Boichat wrote: > > Setting sendemail.suppresscc to all or cccmd leads to --cc-cmd > parameter being ignored, and emails going either nowhere, or > just to the To: line maintainer. > > Signed-off-by: Nicolas Boichat > --- > > tools/patman/gitutil.py | 25

Re: [PATCH 2/2] patman: When no tracking branch is provided, tell the user

2020-07-14 Thread Simon Glass
On Sun, 12 Jul 2020 at 20:50, Nicolas Boichat wrote: > > The user can either count the number of patches, or provide a > tracking branch. > > Signed-off-by: Nicolas Boichat > --- > > tools/patman/main.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: Pinebook Pro keyboard (RK3399 OHCI)?

2020-07-14 Thread Rtp
Simon South writes: > Peter Robinson writes: >> It should be fixed in the main devel repo, commit 3a5771249 > > That commit enables the OHCI driver but doesn't lead to a working > keyboard, at least for me. > > Have you actually tested this successfully on a PBP? (Has anyone else?) > I wonder if

Re: Pinebook Pro keyboard (RK3399 OHCI)?

2020-07-14 Thread Simon South
Arnaud Patard (Rtp) writes: > Did you check if everything needed is enabled in your configuration and > if the keyboard is detected after a usb start / usb tree ? It is detected, yes. I believe the configuration is fine; I see this issue using the standard "pinebook-pro-rk3399_defconfig" and bui

Re: Pinebook Pro keyboard (RK3399 OHCI)?

2020-07-14 Thread Peter Robinson
> > Did you check if everything needed is enabled in your configuration and > > if the keyboard is detected after a usb start / usb tree ? > > It is detected, yes. > > I believe the configuration is fine; I see this issue using the standard > "pinebook-pro-rk3399_defconfig" and building either from

Re: [GIT PULL] TI changes for v2020.10-rc1

2020-07-14 Thread Tom Rini
On Tue, Jul 14, 2020 at 11:08:44AM +0530, Lokesh Vutla wrote: > Hi Tom, > Please find the pull request for v2020.10-rc1 containing TI specific > changes. > > Travis-CI build: > https://travis-ci.org/github/lokeshvutla/u-boot/builds/707679753 > > The following changes since commit 497c759

Re: [PATCH] memsize: Make get_ram_size() work with arbitary RAM size

2020-07-14 Thread Heinrich Schuchardt
On 14.07.20 12:35, Bin Meng wrote: > Hi Wolfgang, > > On Tue, Jul 14, 2020 at 1:18 AM Wolfgang Denk wrote: >> >> Dear Bin Meng, >> >> In message <1594378641-26360-1-git-send-email-bmeng...@gmail.com> you wrote: >>> >>> Currently get_ram_size() only works with certain RAM size like 1GiB, >>> 2GiB,

Re: Pinebook Pro keyboard (RK3399 OHCI)?

2020-07-14 Thread Rtp
Simon South writes: > Arnaud Patard (Rtp) writes: >> Did you check if everything needed is enabled in your configuration and >> if the keyboard is detected after a usb start / usb tree ? > > It is detected, yes. ok. > > I believe the configuration is fine; I see this issue using the standard >

Re: [PATCH] memsize: Make get_ram_size() work with arbitary RAM size

2020-07-14 Thread Wolfgang Denk
Dear Heinrich, In message <53dad1c7-7684-f975-1567-6ec5e03fa...@gmx.de> you wrote: > > If we want a fast algorithm to determine the last supported address even > if the start or size is not a power of two: Are you sure? How is this supposed to work? Running it with start = 0 and size = 0xC0

[PATCH v2 1/1] efi_loader: update secure state

2020-07-14 Thread Heinrich Schuchardt
Update the UEFI secure state when variable 'PK' is updated in the TEE variables implementation. Signed-off-by: Heinrich Schuchardt --- v2: simplify the logic for handling return codes --- lib/efi_loader/efi_variable_tee.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/li

Re: Pinebook Pro keyboard (RK3399 OHCI)?

2020-07-14 Thread Simon South
Arnaud Patard (Rtp) writes: > Did you check the stdin variable content if it contains only "usbkbd" ? > If you have more than one value in it (like "serial,usbkbd"), do you have > CONSOLE_MUX configuration setting enabled ? Yes, "stdin" is set to "serial,usbkbd" and CONSOLE_MUX is set. The consol

[PATCH 1/1] efi_loader: configuration of variables store

2020-07-14 Thread Heinrich Schuchardt
The file based and the OP-TEE based UEFI variable store are mutually exclusive. Define them as choice options in Kconfig. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/Kconfig | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/lib/efi_loa

Re: Using gerrit or github for review?

2020-07-14 Thread Karsten Merker
On Mon, Jul 13, 2020 at 06:05:42PM -0400, Corey Clayton wrote: > On Mon, Jul 13, 2020 at 12:25:42PM -0600, Simon Glass wrote: > > > At present U-Boot uses the mailing list for patch review. What do > > people think about trying out geritt or github for this? I'd be > > willing to do a trial with t

Re: [PATCH v2 1/1] efi_loader: update secure state

2020-07-14 Thread ilias . apalodimas
On Tue, Jul 14, 2020 at 06:08:15PM +0200, Heinrich Schuchardt wrote: > Update the UEFI secure state when variable 'PK' is updated in the TEE > variables implementation. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > simplify the logic for handling return codes > --- > lib/efi_loader/

Re: [PATCH v2 1/1] Dockerfile: provide kernel for libguestfs-tools

2020-07-14 Thread Tom Rini
On Tue, Jul 14, 2020 at 08:18:56AM +0200, Heinrich Schuchardt wrote: > The libguestfs-tools use QEMU to mount an image file. This requires a Linux > kernel. > > On Ubuntu the kernel (/boot/vmlinuz*) is not readable for normal users > (chmod 600), cf. > https://bugs.launchpad.net/ubuntu/+source/li

Re: [PATCH v2 1/1] Dockerfile: provide kernel for libguestfs-tools

2020-07-14 Thread Heinrich Schuchardt
Am 14. Juli 2020 23:28:21 MESZ schrieb Tom Rini : >On Tue, Jul 14, 2020 at 08:18:56AM +0200, Heinrich Schuchardt wrote: > >> The libguestfs-tools use QEMU to mount an image file. This requires a >Linux >> kernel. >> >> On Ubuntu the kernel (/boot/vmlinuz*) is not readable for normal >users >> (chm

Re: [PATCH v2 1/1] Dockerfile: provide kernel for libguestfs-tools

2020-07-14 Thread Tom Rini
On Wed, Jul 15, 2020 at 12:00:25AM +0200, Heinrich Schuchardt wrote: > Am 14. Juli 2020 23:28:21 MESZ schrieb Tom Rini : > >On Tue, Jul 14, 2020 at 08:18:56AM +0200, Heinrich Schuchardt wrote: > > > >> The libguestfs-tools use QEMU to mount an image file. This requires a > >Linux > >> kernel. > >>

Re: [PATCH 1/1] efi_loader: configuration of variables store

2020-07-14 Thread ilias . apalodimas
On Tue, Jul 14, 2020 at 07:28:43PM +0200, Heinrich Schuchardt wrote: > The file based and the OP-TEE based UEFI variable store are mutually > exclusive. Define them as choice options in Kconfig. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/Kconfig | 30 ++

Re: [PATCH v4 06/15] board: ns3: default reset type to L3

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 02:53, Rayagonda Kokatanur wrote: > > Default "reset" from U-Boot to L3 reset. > "reset" command with argument will trigger L1 reset. > > Signed-off-by: Rajesh Ravi > Signed-off-by: Bharat Kumar Reddy Gooty > Signed-off-by: Rayagonda Kokatanur > --- > Changes from v3: >

Re: [PATCH v2] serial: Fix SIFIVE debug serial dependency

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:41, Michal Simek wrote: > > The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for > debug consoles") has added incorrect dependency for SIFIVE debug uart which > should depend on SIFIVE driver instead of PL01x. > > Fixes: 4cc24aeaf420 ("serial: Add missin

Re: [PATCH v2 01/14] Kconfig: Introduce CONFIG_SYS_HAS_SRAM

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:22, Ovidiu Panait wrote: > > In order to be able to replace "#ifdef CONFIG_SYS_SRAM_BASE" sequences > with the IS_ENABLED() equivalent, introduce a new boolean Kconfig option > that signals whether the platform has SRAM support. > > Signed-off-by: Ovidiu Panait > --- > >

Re: [PATCH v2 04/14] Kconfig: Remove CONFIG_SYS_SRAM_START

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:23, Ovidiu Panait wrote: > > Remove ad-hoc CONFIG_SYS_SRAM_START and use CONFIG_SYS_SRAM_BASE instead. > > Signed-off-by: Ovidiu Panait > --- > > Kconfig | 2 ++ > include/configs/devkit8000.h | 3 --- > include/configs/tricorder.h | 3 --- > scrip

Re: [PATCH v2 03/14] Kconfig: Convert CONFIG_SYS_SRAM_SIZE to Kconfig

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:23, Ovidiu Panait wrote: > > This converts ad-hoc CONFIG_SYS_SRAM_SIZE to Kconfig. > > Signed-off-by: Ovidiu Panait > --- > > Kconfig | 7 +++ > include/configs/devkit8000.h | 1 - > include/configs/pic32mzdask.h | 2 -- > include/configs/tric

Re: [PATCH 2/3] Revert "lib: fdt: Split fdtdec_setup_memory_banksize()"

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 05:16, Michal Simek wrote: > > This reverts commit 118f4d4559a4386fa87a1e2509e84a1986b24a34. > > There is no user of this split function that's why remove it. > > Signed-off-by: Michal Simek > --- > > include/fdtdec.h | 19 --- > lib/fdtdec.c | 18 +

Re: [PATCH 3/3] Revert "lib: fdt: Split fdtdec_setup_mem_size_base()"

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 05:17, Michal Simek wrote: > > This reverts commit 3ebe09d09a407f93022d945a205c5318239eb3f6. > > There is no user of this split function that's why remove it. > > Signed-off-by: Michal Simek > --- > > include/fdtdec.h | 20 > lib/fdtdec.c | 11 +++-

Re: [PATCH v2 2/3] lib: fdt: Convert fdtdes_setup_mem..() to livetree API

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 06:41, Michal Simek wrote: > > Convert fdtdec_setup_mem_size_base(), get_next_memory_node(), > fdtdec_setup_memory_banksize() and fdtdec_setup_mem_size_base_lowest() to > livetree API. > > Tested on ZynqMP zcu104 board. > > Signed-off-by: Michal Simek > --- > > Changes in v

Re: [PATCH 3/7] cmd: button: add a new 'button' command

2020-07-14 Thread Simon Glass
On Mon, 13 Jul 2020 at 06:56, Philippe Reynes wrote: > > Adds a command 'button' that provides the list of buttons > supported by the board, and the state of a button. > > Signed-off-by: Philippe Reynes > --- > cmd/Kconfig | 11 > cmd/Makefile | 1 + > cmd/button.c | 86 > +++

Re: [PATCH v4 07/15] board: ns3: program GIC LPI tables

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 02:53, Rayagonda Kokatanur wrote: > > U-boot programs the GIC LPI configuration tables and enables > the LPI table. > > Signed-off-by: Bharat Kumar Reddy Gooty > Signed-off-by: Rayagonda Kokatanur > --- > Changes from v3: > -Address review comments from Simon, >Use d

Re: Using gerrit or github for review?

2020-07-14 Thread Simon Glass
Hi, On Tue, 14 Jul 2020 at 14:06, Karsten Merker wrote: > > On Mon, Jul 13, 2020 at 06:05:42PM -0400, Corey Clayton wrote: > > On Mon, Jul 13, 2020 at 12:25:42PM -0600, Simon Glass wrote: > > > > > At present U-Boot uses the mailing list for patch review. What do > > > people think about trying o

Re: [PATCH v4 02/15] arm: cpu: armv8: add L3 memory flush support

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 02:52, Rayagonda Kokatanur wrote: > > Add L3 memory flush support for NS3. > > Signed-off-by: Rayagonda Kokatanur > --- > Changes from v3: > -Address review comments from Simon, >Commit message correction > > arch/arm/cpu/armv8/Makefile | 1 + > arch/arm/cp

Re: [PATCH 6/7] sandbox: enable button

2020-07-14 Thread Simon Glass
On Mon, 13 Jul 2020 at 06:56, Philippe Reynes wrote: > > Enable the support of button (driver and command) on sandbox. > > Signed-off-by: Philippe Reynes > --- > configs/sandbox_defconfig | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH v4 14/15] doc: add README doc for bcmns3 platform

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 02:53, Rayagonda Kokatanur wrote: > > Add README doc for bcmns3 platform. > > Signed-off-by: Rayagonda Kokatanur > --- > doc/README.bcmns3 | 74 +++ > 1 file changed, 74 insertions(+) > create mode 100644 doc/README.bcmns3 Revi

Re: [PATCH v2 02/14] Kconfig: Convert CONFIG_SYS_SRAM_BASE to Kconfig

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:23, Ovidiu Panait wrote: > > This converts ad-hoc CONFIG_SYS_SRAM_BASE to Kconfig. > > Signed-off-by: Ovidiu Panait > --- > > Kconfig | 5 + > include/configs/pic32mzdask.h | 1 - > scripts/config_whitelist.txt | 1 - > 3 files changed, 5 inse

Re: [PATCH] serial: Fix SIFIVE debug serial dependency

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 00:21, Michal Simek wrote: > > Hi Simon, > > On 10. 07. 20 2:35, Simon Glass wrote: > > Hi Michal, > > > > On Thu, 9 Jul 2020 at 08:17, Michal Simek wrote: > >> > >> The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for > >> debug consoles") has added incor

Re: [PATCH v2 17/44] sound: Add an ACPI driver for Maxim MAX98357ac

2020-07-14 Thread Bin Meng
Hi Simon, On Tue, Jul 14, 2020 at 9:25 PM Simon Glass wrote: > > Hi Bin, > > On Mon, 13 Jul 2020 at 23:01, Bin Meng wrote: > > > > Hi Simon, > > > > On Tue, Jul 14, 2020 at 9:28 AM Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Wed, Jul 8, 2020 at 11:33 AM Simon Glass wrote: > > > > > >

Re: [PATCH v3 2/3] board: ns3: add FIT image its file

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:18, Rayagonda Kokatanur wrote: > > From: Pramod Kumar > > Add FIT image its file. > > Signed-off-by: Pramod Kumar > Signed-off-by: Rayagonda Kokatanur > --- > board/broadcom/bcmns3/fit/multi.its | 59 + > 1 file changed, 59 insertions(+) >

Re: [PATCH 1/7] dm: button: add an uclass for button

2020-07-14 Thread Simon Glass
Hi Philippe, On Mon, 13 Jul 2020 at 06:56, Philippe Reynes wrote: > > Add a new uclass for button that implements two functions: > - button_get_by_label > - button_get_status > > Signed-off-by: Philippe Reynes > --- > drivers/Kconfig| 2 ++ > drivers/Makefile | 1

Re: [PATCH 7/7] test/py: add tests for the button commands

2020-07-14 Thread Simon Glass
Hi Philippe, On Mon, 13 Jul 2020 at 06:56, Philippe Reynes wrote: > > Adds tests for the button commands. > > Signed-off-by: Philippe Reynes > --- > arch/sandbox/dts/test.dts| 14 ++ > test/py/tests/test_button.py | 19 +++ > 2 files changed, 33 insertions(+) >

Re: [PATCH v2 06/14] board_f: m68k: Factor out m68k-specific bdinfo setup

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:25, Ovidiu Panait wrote: > > Factor out m68k-specific bdinfo setup to arch_setup_bdinfo in > arch/m68k/lib/bdinfo.c. Also, use if(IS_ENABLED()) instead of #ifdef where > possible. > > Signed-off-by: Ovidiu Panait > --- > v2 updates: > - use "if (IS_ENABLED(CONFIG_SYS_HAS

Re: [PATCH 1/3] ARM: rmobile: Switch back to fdtdec_setup_memory/banksize_fdt()

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 05:16, Michal Simek wrote: > > The commit 361377dbdbc9 ("ARM: rmobile: Merge prior-stage firmware DT > fragment into U-Boot DT on Gen3") reverted changes introduced by commit > 175f5027345c ("ARM: renesas: Configure DRAM size from ATF DT fragment") > that's why there is no r

Re: [PATCH 4/7] sandbox: dtsi: add buttons

2020-07-14 Thread Simon Glass
On Mon, 13 Jul 2020 at 06:56, Philippe Reynes wrote: > > Adds two buttons on sandbox so button framework may be tested. > > Signed-off-by: Philippe Reynes > --- > arch/sandbox/dts/sandbox.dtsi | 14 ++ > 1 file changed, 14 insertions(+) > Reviewed-by: Simon Glass But don't you wan

Re: [PATCH 2/7] dm: button: add a driver for button driven by gpio

2020-07-14 Thread Simon Glass
On Mon, 13 Jul 2020 at 06:56, Philippe Reynes wrote: > > Add a simple driver which allows use of buttons attached to GPIOs. > > Signed-off-by: Philippe Reynes > --- > drivers/button/Kconfig | 10 > drivers/button/Makefile | 1 + > drivers/button/button-gpio.c | 111 >

Re: [PATCH v2 1/3] lib: fdt: Introduce fdtdec_setup_mem_size_base_lowest()

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 06:41, Michal Simek wrote: > > New function should be called from board dram_init() because it initialized > gd->ram_base/ram_size. It finds the lowest available memory. > > On systems with multiple memory nodes finding out the first memory node by > fdtdec_setup_mem_size_ba

Re: [PATCH 5/7] sandbox64: enable button

2020-07-14 Thread Simon Glass
On Mon, 13 Jul 2020 at 06:56, Philippe Reynes wrote: > > Enable the support of button (driver and command) on sandbox64. > > Signed-off-by: Philippe Reynes > --- > configs/sandbox64_defconfig | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH v2 09/14] board_f: mips: Factor out mips-specific bdinfo setup

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:25, Ovidiu Panait wrote: > > Factor out mips-specific bdinfo setup from generic init sequence to > arch_setup_bdinfo in arch/mips/lib/boot.c. Also, use if(IS_ENABLED()) > instead of #ifdef where possible. > > Signed-off-by: Ovidiu Panait > --- > v2 updates: > - use "if (

Re: [PATCH v2 08/14] board_f: sh: Factor out sh-specific bdinfo setup

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:25, Ovidiu Panait wrote: > > Factor out sh-specific bdinfo setup from generic init sequence to > arch_setup_bdinfo in arch/sh/lib/board.c. Also, use if(IS_ENABLED()) > instead of #ifdef where possible. > > Signed-off-by: Ovidiu Panait > --- > v2 updates: > - use "if (IS_

Re: [PATCH v4 1/2] drivers: tee: broadcom: add optee based bnxt fw load driver

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:51, Rayagonda Kokatanur wrote: > > From: Vikas Gupta > > Add optee based bnxt fw load driver. > bnxt is Broadcom NetXtreme controller Ethernet card. > This driver is used to load bnxt firmware binary using OpTEE. > > Signed-off-by: Vikas Gupta > Signed-off-by: Rayagonda

Re: [PATCH] serial: Fix SIFIVE debug serial dependency

2020-07-14 Thread Tom Rini
On Tue, Jul 14, 2020 at 07:05:54PM -0600, Simon Glass wrote: > On Fri, 10 Jul 2020 at 00:21, Michal Simek wrote: > > > > Hi Simon, > > > > On 10. 07. 20 2:35, Simon Glass wrote: > > > Hi Michal, > > > > > > On Thu, 9 Jul 2020 at 08:17, Michal Simek wrote: > > >> > > >> The commit 4cc24aeaf420 ("s

Re: [PATCH v2 07/14] board_f: ppc: Factor out ppc-specific bdinfo setup

2020-07-14 Thread Simon Glass
On Fri, 10 Jul 2020 at 04:25, Ovidiu Panait wrote: > > Factor out ppc-specific bdinfo setup from generic init sequence to > arch_setup_bdinfo in arch/powerpc/lib/bdinfo.c. Also, use if(IS_ENABLED()) > instead of #ifdef where possible. > > Signed-off-by: Ovidiu Panait > --- > v2 updates: > - use "

Re: [PATCH v3 04/17] common: update: add a generic interface for FIT image

2020-07-14 Thread AKASHI Takahiro
Heinrich, On Fri, Jul 10, 2020 at 06:24:45PM +0200, Heinrich Schuchardt wrote: > On 10.07.20 03:25, AKASHI Takahiro wrote: > > The main purpose of this patch is to separate a generic interface for > > updating firmware using DFU drivers from "auto-update" via tftp. > > > > This function will also

Re: [PATCH] test: use virt-make-fs to build image

2020-07-14 Thread AKASHI Takahiro
Heinrich, On Tue, Jul 14, 2020 at 01:18:04AM +0200, Heinrich Schuchardt wrote: > Am 14. Juli 2020 01:02:07 MESZ schrieb AKASHI Takahiro > : > >Heinrich, > > > >On Tue, Jul 14, 2020 at 12:15:34AM +0200, Heinrich Schuchardt wrote: > >> Avoid sudo for test/py/tests/test_efi_secboot by using virt-mak

Re: [PATCH v3 06/17] efi_loader: add option to initialise EFI subsystem early

2020-07-14 Thread AKASHI Takahiro
Heinrich, On Fri, Jul 10, 2020 at 06:25:34PM +0200, Heinrich Schuchardt wrote: > On 10.07.20 03:25, AKASHI Takahiro wrote: > > If this option, CONFIG_EFI_SETUP_EARLY, is enabled, the initialisation > > of UEFI subsystem will be done as part of U-Boot initialisation. > > > > Please note that this o

Re: [PATCH v3 05/17] dfu: export dfu_list

2020-07-14 Thread AKASHI Takahiro
Heinrich, On Fri, Jul 10, 2020 at 06:25:16PM +0200, Heinrich Schuchardt wrote: > On 10.07.20 03:25, AKASHI Takahiro wrote: > > This variable will be utilized to enumerate all dfu entities > > for UEFI capsule firmware update in a later commit. > > > > Signed-off-by: AKASHI Takahiro > > --- > > d

Re: [PATCH v3 02/17] dfu: add a hidden reverse-dependency on UPDATE_TFTP

2020-07-14 Thread AKASHI Takahiro
Heinrich, On Fri, Jul 10, 2020 at 07:21:14AM +0200, Heinrich Schuchardt wrote: > On 7/10/20 3:25 AM, AKASHI Takahiro wrote: > > DFU_OVER_TFTP support on "dfu" command relies on update_tftp() > > being available. Just explicitly add this dependency. > > > > Signed-off-by: AKASHI Takahiro > > --- >

Re: [PATCH v3 03/17] dfu: rename dfu_tftp_write() to dfu_write_by_name()

2020-07-14 Thread AKASHI Takahiro
Heinrich, On Fri, Jul 10, 2020 at 07:45:30AM +0200, Heinrich Schuchardt wrote: > On 7/10/20 3:25 AM, AKASHI Takahiro wrote: > > This function is essentially independent from tffp, and will also be > > utilised in implementing UEFI capsule update in a later commit. > > So just give it a more generi

Re: [PATCH] serial: Fix SIFIVE debug serial dependency

2020-07-14 Thread Michal Simek
On 15. 07. 20 3:10, Tom Rini wrote: > On Tue, Jul 14, 2020 at 07:05:54PM -0600, Simon Glass wrote: >> On Fri, 10 Jul 2020 at 00:21, Michal Simek wrote: >>> >>> Hi Simon, >>> >>> On 10. 07. 20 2:35, Simon Glass wrote: Hi Michal, On Thu, 9 Jul 2020 at 08:17, Michal Simek wrote: >>

Re: Using gerrit or github for review?

2020-07-14 Thread Michael Nazzareno Trimarchi
Hi all On Wed, Jul 15, 2020 at 3:08 AM Simon Glass wrote: > > Hi, > > On Tue, 14 Jul 2020 at 14:06, Karsten Merker wrote: > > > > On Mon, Jul 13, 2020 at 06:05:42PM -0400, Corey Clayton wrote: > > > On Mon, Jul 13, 2020 at 12:25:42PM -0600, Simon Glass wrote: > > > > > > > At present U-Boot uses