On Sat, 15 Feb 2020 21:22:00 +0100
Heinrich Schuchardt wrote:
> If all branches of a switch statement have a return instruction, all
> subsequent lines are unreachable.
>
> Identified with cppcheck.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/clk/intel/clk_intel.c | 4
> 1 fil
On Sat, 15 Feb 2020 21:10:54 +0100
Heinrich Schuchardt wrote:
> Add missing break for CLKID_PCIE_PLL in switch statement.
>
> Reported by CppCheck.
>
> Cc: Neil Armstrong
> Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support")
> Signed-off-by: Heinrich Schuchardt
> ---
> Looking at th
On Sat, 15 Feb 2020 21:27:38 +0100
Heinrich Schuchardt wrote:
> Do not calculate a unused value of n which is overwritten in both
> branches of the subsequent if statement.
>
> Identified by cppcheck.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/clk/ics8n3qv01.c | 1 -
> 1 file chan
We should not assign a value that is overwritten before use.
Signed-off-by: Heinrich Schuchardt
---
drivers/rng/stm32mp1_rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rng/stm32mp1_rng.c b/drivers/rng/stm32mp1_rng.c
index dab3b995eb..e0f0a66c6e 100644
--- a/dri
Using memcpy() for some MMIO access is generally frowned upon and might
break things on some platforms. Allwinner H3, which fails to boot, being
an example here.
Moreover, fields being accessed are naturally aligned and warnings
produced by GCC have been quiesced for some time already by:
53dc8ae
Use the standard BIT() and GENMASK() macros for bitfield definitions.
Signed-off-by: Dario Binacchi
---
Changes in v2:
- Use GENMASK macro too
drivers/video/am335x-fb.c | 36 ++--
drivers/video/am335x-fb.h | 12 ++--
2 files changed, 24 insertions(+), 2
Changes:
- Fix coding style
- Refactor some parts of the driver
- Add support for driver model and device-tree
- Update the boards device-tree
- Add device-tree binding documentation
Changes for v2:
- Use the GENMASK macro to manage bitfield mask
- Move clock e
Add, if missing, the bitfield masks in the setting macros of the LCD
controller registers.
Signed-off-by: Dario Binacchi
- Use GENMASK macro
---
Changes in v2: None
drivers/video/am335x-fb.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/am335x-f
Add more clarity by prefixing the name of the register to the bitfields.
Signed-off-by: Dario Binacchi
---
Changes in v2: None
drivers/video/am335x-fb.c | 107 +++---
1 file changed, 54 insertions(+), 53 deletions(-)
diff --git a/drivers/video/am335x-fb.c b/dri
In case of null error, round rate is equal to target rate, so it is
useless to continue to search the DPLL setup parameters to get the
desidered pixel clock rate.
Signed-off-by: Dario Binacchi
Reviewed-by: Lokesh Vutla
---
Changes in v2: None
drivers/video/am335x-fb.c | 4 +++-
1 file changed
Arrange the bitfields of each register in the ascending order.
Signed-off-by: Dario Binacchi
---
Changes in v2: None
drivers/video/am335x-fb.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb
Use one space around (on each side of) the binary '-' operator.
Signed-off-by: Dario Binacchi
---
Changes in v2: None
drivers/video/am335x-fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c
index 4fd3b7f65a..92e37bd1e0
"DISP" -> "DIV"
Signed-off-by: Dario Binacchi
Reviewed-by: Lokesh Vutla
---
Changes in v2: None
drivers/video/am335x-fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c
index 9f488f656e..bbe965af84 100644
--- a/drivers
Update the driver to support the device tree and the driver model.
Timings and panel parameters are now loaded from the device tree.
The DM code replaces the am335x_lcdpanel structure with
tilcdc_panel_info taken from the linux kernel, as well the management
of additional parameters not covered in
Created in preparation to support driver-model, they can also be called
from legacy code. In this way, code duplication is avoided.
Signed-off-by: Dario Binacchi
- Use GENMASK macro for clock divisor mask
---
Changes in v2: None
drivers/video/am335x-fb.c | 130 ---
Add device-tree binding documentation for ti framebuffer and generic
panel output driver.
Signed-off-by: Dario Binacchi
Reviewed-by: Simon Glass
---
Changes in v2: None
.../video/tilcdc/panel.txt| 66 +++
.../video/tilcdc/tilcdc.txt | 82 +
Add the "u-boot,dm-pre-reloc" property to the "ti,tilcdc,panel"
compatible node. In this way the video-uclass module can allocate the
amount of memory needed to be assigned to the frame buffer.
In the case of the boards that support Linux, the addition of the
property in the *-u-boot.dtsi file stil
Fix the macro to set the pplmsb field (bit 3) of the RASTER_TIMING_0
register. It is used in order to support up to 2048 pixels per line.
Signed-off-by: Dario Binacchi
---
Changes in v2: None
drivers/video/am335x-fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/
Fix building errors if CONFIG_DM_VIDEO is enabled. This is the only
u-boot board that enables CONFIG_AM335X_LCD and from which I started
to develop the version of the frame buffer driver that supports the
driver model.
Signed-off-by: Dario Binacchi
---
Changes in v2: None
board/BuR/common/br_
Dear Rasmus,
In message <509a01fb-ba01-33b9-33bc-7323544d2...@prevas.dk> you wrote:
>
> So in bash, that might be written
>
> slot=none
> for x in $BOOT_ORDER ; do
> eval "left=\${BOOT_${x}_LEFT}"
> if [ $left -gt 0 ] ; then
> slot=$x
> break
> fi
> done
OK, now I get the context.
Dear Martin,
In message <2cd28d15-b5bf-4c5b-a57c-b9a24ad6d...@geanix.com> you wrote:
>
>
> I chose to implement boot count / selection functionality as a command
> instead:
> https://patchwork.ozlabs.org/patch/943549/
Thanks for pointing out, I think I should NAK this patch, too. It
can be imple
Dear Martin,
In message <20180713123413.4115-1-mar...@geanix.com> you wrote:
> The existing bootcount feature is targeted systems with a primary, and a
> rescue boot setup, where the number of boot tries to the primary boot is
> tracked. If the number exceeds the limit, the alternative/rescue is
>
Hi Tom,
Cc: Masahiro Yamada
On Fri, Feb 14, 2020 at 12:38:19PM -0500, Tom Rini wrote:
> The image.h header can be used fairly widely in U-Boot builds. We
> cannot use u32 here as it may be used in cases where we don't have that
> typedef available and don't want to expose it either. Use uint ins
On Sun, Feb 16, 2020 at 05:23:14PM +0100, Eugeniu Rosca wrote:
> Hi Tom,
> Cc: Masahiro Yamada
>
> On Fri, Feb 14, 2020 at 12:38:19PM -0500, Tom Rini wrote:
> > The image.h header can be used fairly widely in U-Boot builds. We
> > cannot use u32 here as it may be used in cases where we don't have
On Sun, Feb 16, 2020 at 04:09:39PM +0100, Dario Binacchi wrote:
> Add the "u-boot,dm-pre-reloc" property to the "ti,tilcdc,panel"
> compatible node. In this way the video-uclass module can allocate the
> amount of memory needed to be assigned to the frame buffer.
> In the case of the boards that s
Dear Rasmus,
In message <20200216152427.e80c7240...@gemini.denx.de> I wrote:
>
> So lets change my little script to add setting "left":
>
> slot=none
> for i in $BOOT_ORDER ; do
> setenv tmp_cmd 'setexpr tmp_val sub '^' "" $'BOOT_${i}_LEFT
> run tmp_cmd
> test $slot =
On Wed, 12 Feb 2020 at 11:45, Patrick Delaunay wrote:
>
> The default environment is still used with "ENVL_NOWHERE"
> indicated by the weak function env_get_location() and
> activated by CONFIG_ENV_IS_NOWHERE.
>
> Signed-off-by: Patrick Delaunay
> ---
>
> board/sandbox/sandbox.c| 12
On Wed, 12 Feb 2020 at 12:47, Markus Klotzbuecher wrote:
>
> Printing the error message in verbose mode fails, since python3
> doesn't implicitely convert bytes to strings.
>
> Signed-off-by: Markus Klotzbuecher
> Cc: Simon Glass
> Cc: Tom Rini
> Cc: Masahiro Yamada
> ---
> tools/moveconfig.p
Hi Patrick,
On Wed, 12 Feb 2020 at 11:45, Patrick Delaunay wrote:
>
> Add support of environment location with a new sandbox command
> 'env_loc'.
>
> When the user change the environment location with the command
> 'env_loc ' the env is reinitialized and saved;
> the GD_FLG_ENV_DEFAULT flag is al
Hi Patrick,
On Wed, 12 Feb 2020 at 11:45, Patrick Delaunay wrote:
>
> Add test for the erase command tested on ENV in EXT4.
>
> Signed-off-by: Patrick Delaunay
> ---
>
> configs/sandbox64_defconfig| 1 +
> configs/sandbox_defconfig | 1 +
> configs/sandbox_flattree_defconfig
On Sat, 15 Feb 2020 at 03:14, Heinrich Schuchardt wrote:
>
> Provide unit tests for the syslog logging driver.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> v3:
> new patch
> ---
> test/log/Makefile | 4 +
> test/log/syslog_test.c | 186 +
>
On Sat, 15 Feb 2020 at 03:14, Heinrich Schuchardt wrote:
>
> Provide a log driver that broadcasts RFC 3164 messages to syslog servers.
> rsyslog is one implementation of such a server.
>
> The messages are sent to the local broadcast address 255.255.255.255 on
> port 514.
>
> The environment varia
On Sat, 15 Feb 2020 at 03:14, Heinrich Schuchardt wrote:
>
> If CONFIG_LOG=n, we still expect output for log_err(), log_warning(),
> log_notice(), log_info() and in case of DEBUG=1 also for log_debug().
>
> Provide unit tests verifying this.
>
> The tests depend on:
>
> CONFIG_CONSOLE_RECO
On Sat, 15 Feb 2020 at 13:22, Heinrich Schuchardt wrote:
>
> If all branches of a switch statement have a return instruction, all
> subsequent lines are unreachable.
>
> Identified with cppcheck.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/clk/intel/clk_intel.c | 4
> 1 file chan
On Sat, 15 Feb 2020 at 03:14, Heinrich Schuchardt wrote:
>
> For testing purposes enable the syslog logging driver.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> v3:
> new patch
> ---
> configs/sandbox64_defconfig| 1 +
> configs/sandbox_defconfig | 1 +
> configs/sandb
On Sat, 15 Feb 2020 at 04:34, Anatolij Gustschin wrote:
>
> Currently when booting the kernel on i.MX8 U-Boot hangs in an
> endless loop when switching off dma, connectivity or lsio power
> domains during device removal. It hapens first when removing
> gpio0 (gpio@5d08) device, here its power
On Sat, 15 Feb 2020 at 13:38, Heinrich Schuchardt wrote:
>
> The value of parent is not changed in the first if statement. So we can
> merge the two if statements depending on parent.
>
> Indicated by cppcheck.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/core/device.c | 6 ++
> 1
On Sat, 15 Feb 2020 at 13:46, Heinrich Schuchardt wrote:
>
> Variable count is initialized at the start of every round of the while
> loop and it is not used after the while loop. So there is no need to
> initialize it beforehand.
>
> Identified by cppcheck.
>
> Signed-off-by: Heinrich Schuchardt
Hi Simon, Peng,
On Sun, 16 Feb 2020 12:02:55 -0700
Simon Glass s...@chromium.org wrote:
...
> > drivers/power/domain/power-domain-uclass.c | 12
> > 1 file changed, 12 insertions(+)
>
> Can we have a sandbox test for this case?
I didn't check if there are more platforms with such
Hi Tom,
On Sun, Feb 16, 2020 at 11:53:23AM -0500, Tom Rini wrote:
> On Sun, Feb 16, 2020 at 05:23:14PM +0100, Eugeniu Rosca wrote:
> > On Fri, Feb 14, 2020 at 12:38:19PM -0500, Tom Rini wrote:
> > > The image.h header can be used fairly widely in U-Boot builds. We
> > > cannot use u32 here as it
On Fri, Feb 14, 2020 at 8:43 AM Tom Rini wrote:
>
> On Thu, Feb 13, 2020 at 11:32:52PM +0200, David Abdurachmanov wrote:
> > On Thu, Feb 13, 2020 at 6:17 PM Tom Rini wrote:
> > >
> > > On Wed, Feb 05, 2020 at 12:01:38AM +, Atish Patra wrote:
> > > > On Fri, 2019-11-22 at 18:19 -0800, Atish Pa
Hi Tom,
On Fri, Feb 14, 2020 at 07:29:37AM -0500, Tom Rini wrote:
> On Mon, Jan 27, 2020 at 07:27:33PM +0900, AKASHI Takahiro wrote:
>
> > # This patch set is a prerequisite for UEFI secure boot.
> >
> > The current rsa_verify() requires five parameters for a RSA public key
> > for efficiency wh
> Subject: Re: [PATCH] power-domain: fix hang in endless loop on i.MX8
>
> Hi Simon, Peng,
>
> On Sun, 16 Feb 2020 12:02:55 -0700
> Simon Glass s...@chromium.org wrote:
> ...
> > > drivers/power/domain/power-domain-uclass.c | 12
> > > 1 file changed, 12 insertions(+)
> >
> > Can we
On 15/02/20 5:04 PM, Anatolij Gustschin wrote:
> Currently when booting the kernel on i.MX8 U-Boot hangs in an
> endless loop when switching off dma, connectivity or lsio power
> domains during device removal. It hapens first when removing
> gpio0 (gpio@5d08) device, here its power domain de
On 16/02/20 8:39 PM, Dario Binacchi wrote:
>
> Changes:
> - Fix coding style
> - Refactor some parts of the driver
> - Add support for driver model and device-tree
> - Update the boards device-tree
> - Add device-tree binding documentation
>
> Changes for v2:
> -
On 13/02/20 7:04 PM, moseschristoph...@gmail.com wrote:
> From: Moses Christopher Bollavarapu
>
> - As tiny printf lib is further optimized, the ability to deal with
> ethaddr is lost. Hence, in order to handle usb-eth boot from SPL
> we need to disable tiny printf.
>
> - Tested o
Hi Patrick,
On Thu, 13 Feb 2020 at 11:48, Patrick Delaunay wrote:
>
> Use the new function dm_scan_fdt_ofnode_path() to scan all the nodes
> which aren't devices themselves but may contain some:
> - "/chosen"
> - "/clocks"
> - "/firmware"
>
> The patch removes the strcmp call in recursive functio
Hi Frank,
On Thu, 13 Feb 2020 at 10:51, Frank Wunderlich wrote:
>
> Hi,
>
> i guess you mean this (board is bananapi R64, not M64):
>
> board/mediatek/mt7622/mt7622_rfb.c
> arch/arm/dts/mt7622.dtsi
> arch/arm/dts/mt7622-rfb.dts
>
> currently i have added
>
> CONFIG_BINMAN_FDT=n
>
> to configs/mt7
On 15/02/20 12:03 am, Marek Vasut wrote:
> On 2/14/20 1:23 PM, Vignesh Raghavendra wrote:
>> From: Jean-Jacques Hiblot
>>
>> This fixes potential issues reported by klokworks:
>> Pointer 'req' returned from call to function 'next_request' at line 531 and
>> 538 may be NULL and will be dereferen
On 14/02/20 5:52 pm, Vignesh Raghavendra wrote:
Its possible that k3_avs_priv is NULL because the driver may not have
been probed yet. Therefore check if pointer is valid before
dereferencing it.
Reviewed-by: Keerthy
Signed-off-by: Vignesh Raghavendra
---
drivers/misc/k3_avs.c | 4 +++
On 11/02/20 11:59 am, Kuldeep Singh wrote:
> Commit "658df8bd9464"(mtd: spi-nor-core: Add octal mode support) enables
> octal mode(1-1-8) support in spi-nor framework.
>
> mt35xu512aba and mt35xu02g supports SINGLE and OCTAL I/O.
> Hence, enable SPI_NOR_OCTAL_READ flag for these flashes.
>
> S
Tom, Simon,
On Fri, Feb 14, 2020 at 12:16:33PM -0700, Simon Glass wrote:
> Hi AKASHI,
>
> On Thu, 13 Feb 2020 at 18:39, AKASHI Takahiro
> wrote:
> >
> > Tom, Simon,
> >
> > Is CONFIG_SYS_RELOC_GD_ENV_ADDR really needed on sandbox?
> >
> > When I try to have a variable environment on emulated SPI
An error
undefined reference to `do_log_test'
occurs for CONFIG_CMD_LOG=y, CONFIG_LOG_TEST=y, CONGIG_UNIT_TEST=n
Make CONFIG_UNIT_TEST a prerequisite.
Signed-off-by: Heinrich Schuchardt
Reviewed-by: Simon Glass
---
v4:
no change
---
common/Kconfig | 2 +-
1 file changed, 1 in
This patch series provides a logging driver to send syslog messages via
UDP port 514 to a syslog server and a unit test for the syslog driver.
For testing LOG_SYSLOG is enabled on the sandbox.
For CONFIG_LOG=n a patch enables printf() or debug() output for log_*
functions. A unit test for this use
If CONFIG_LOG=n, we should still output errors, warnings, notices, infos,
and for DEBUG=1 also debug messages.
Signed-off-by: Heinrich Schuchardt
Reviewed-by: Simon Glass
---
v4:
no change
---
include/log.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/i
Provide a log driver that broadcasts RFC 3164 messages to syslog servers.
rsyslog is one implementation of such a server.
The messages are sent to the local broadcast address 255.255.255.255 on
port 514.
The environment variable log_hostname can be used to provide the HOSTNAME
field for the messa
For testing purposes enable the syslog logging driver.
Signed-off-by: Heinrich Schuchardt
Reviewed-by: Simon Glass
---
v4:
no change
---
configs/sandbox64_defconfig| 1 +
configs/sandbox_defconfig | 1 +
configs/sandbox_flattree_defconfig | 1 +
3 files changed, 3 inser
If CONFIG_LOG=n, we still expect output for log_err(), log_warning(),
log_notice(), log_info() and in case of DEBUG=1 also for log_debug().
Provide unit tests verifying this.
The tests depend on:
CONFIG_CONSOLE_RECORD=y
CONFIG_LOG=n
CONFIG_UT_LOG=y
It may be necessary to
Provide unit tests for the syslog logging driver.
Signed-off-by: Heinrich Schuchardt
---
v4:
provide more comments
move uts and expected to a common structure
expect 'uboot:' not 'uboot[1]:' in syslog message
v3:
new patch
---
test/log/Makefile | 4 +
test/
Hi Simon,Ryder
The binman-option is introduced by this commit:
https://gitlab.denx.de/u-boot/u-boot/commit/cbd2fba1eca11300649052e289685e7404e0b81c
add basic support for MT7629 boards
@ryder is binman used (mt7629)? R2 and r64 are affected from this issue (boot
broken by binman_fdt). Have it
Hi,
Does kernel and u-boot both need be compiled by u-boot configure files
to include bootargs, mtdpars etc?
Thank you.
Kind regards,
- jh
Hi Eugeniu, Tom,
On Mon, Feb 17, 2020 at 7:05 AM Eugeniu Rosca wrote:
>
> Hi Tom,
>
> On Sun, Feb 16, 2020 at 11:53:23AM -0500, Tom Rini wrote:
> > On Sun, Feb 16, 2020 at 05:23:14PM +0100, Eugeniu Rosca wrote:
> > > On Fri, Feb 14, 2020 at 12:38:19PM -0500, Tom Rini wrote:
> > > > The image.h h
Add DT nodes for main domain I2Cs and its slave devices
Signed-off-by: Vignesh Raghavendra
---
arch/arm/dts/k3-am654-base-board.dts | 48
1 file changed, 48 insertions(+)
diff --git a/arch/arm/dts/k3-am654-base-board.dts
b/arch/arm/dts/k3-am654-base-board.dts
index
63 matches
Mail list logo
