Re: [U-Boot] [PATCH v2 2/3] efi_loader: disk: install FILE_SYSTEM_PROTOCOL only if available

2019-10-03 Thread AKASHI Takahiro
Heinrich, On Thu, Sep 12, 2019 at 06:51:35PM +0900, AKASHI Takahiro wrote: > On Thu, Sep 12, 2019 at 11:43:07AM +0200, Heinrich Schuchardt wrote: > > On 9/12/19 11:17 AM, AKASHI Takahiro wrote: > > > On Thu, Sep 12, 2019 at 10:57:20AM +0200, Heinrich Schuchardt wrote: > > >> On 9/12/19 6:51 AM, AK

Re: [U-Boot] [PATCH v2 3/3] efi_loader: disk: install file system protocol to a whole disk

2019-10-03 Thread AKASHI Takahiro
Heinrich, On Thu, Sep 12, 2019 at 11:21:51AM +0200, Heinrich Schuchardt wrote: > On 9/12/19 6:51 AM, AKASHI Takahiro wrote: > > Currently, a whole disk without any partitions is not associated > > with EFI_SIMPLE_FILE_SYSTEM_PROTOCOL. So even if it houses FAT > > file system, there is a chance tha

Re: [U-Boot] [PATCH 2/2] watchdog: designware: Convert to DM and DT probing

2019-10-03 Thread Marek Vasut
On 10/3/19 3:57 AM, Ley Foon Tan wrote: [...] >> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >> index 6fd9b0a177..ec34993664 100644 >> --- a/drivers/watchdog/Kconfig >> +++ b/drivers/watchdog/Kconfig >> @@ -36,13 +36,6 @@ config ULP_WATCHDOG >> help >> Say Y

[U-Boot] [PATCH v4 1/3] env: correct the check of env_flags_validate presence

2019-10-03 Thread Patrick Delaunay
This patch corrects the check of env_flags_validate presence because "flags.c" is always compiled in U-Boot and CONFIG_ENV_SUPPORT don't exist; so the macro CONFIG_IS_ENABLED(ENV_SUPPORT) only provides the expected result for SPL and TPL (check activation of CONFIG_SPL_ENV_SUPPORT and CONFIG_TPL_EN

[U-Boot] [PATCH v4 0/3] env: Add CONFIG_ENV_FULL_SUPPORT

2019-10-03 Thread Patrick Delaunay
Hi, This patchset follow http://patchwork.ozlabs.org/project/uboot/list/?series=131268&state=* It follow the first proposal http://patchwork.ozlabs.org/project/uboot/list/?series=129339 "env: Add CONFIG_ENV_SUPPORT" The first patch of the serie only solves the regression introduced by com

[U-Boot] [PATCH v4 2/3] env: introduce macro ENV_IS_IN_SOMEWHERE

2019-10-03 Thread Patrick Delaunay
This patch introduce a macro ENV_IS_IN_SOMEWHERE to check if the the environment can be saved somewhere, in a storage medium, without assumption on CONFIG$(SPL_TPL_)ENV_IS_NOWHERE. Since the commit 208bd2b85ecc ("env: allow ENV_IS_NOWHERE with other storage target"), it is allowed to activated ENV

Re: [U-Boot] [PATCH] cmd: host: fix seg fault at "host info"

2019-10-03 Thread Bin Meng
+Tom On Thu, Oct 3, 2019 at 2:00 PM AKASHI Takahiro wrote: > > Ping, > > This patch has not been merged yet. > Simon is on vacation. Tom, could you please take this patch directly? This needs to be in v2019.10. Regards, Bin ___ U-Boot mailing list U-

Re: [U-Boot] [RFC 2/3] lib: rsa: generate additional parameters for public key

2019-10-03 Thread Ilias Apalodimas
On Fri, Sep 06, 2019 at 04:08:07PM +0900, AKASHI Takahiro wrote: > In the current implementation of FIT_SIGNATURE, five parameters for > a RSA public key are required while only two of them are essential. > (See rsa-mod-exp.h and uImage.FIT/signature.txt) > This is a result of considering relativel

Re: [U-Boot] [PATCH v2 07/38] spl: Avoid checking for Ctrl-C in SPL with print_buffer()

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 9:58 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > We don't have a console in SPL so it doesn't make sense to check for > > Ctrl-C when printing a memory dump. Skip this so that print_buffer() can > > be used in SPL. > > > > Signed-off-b

Re: [U-Boot] [PATCH v2 08/38] spl: handoff: Correct Kconfig condition for SPL and TPL

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 9:58 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > At present these options can be enabled when bloblist is not enabled for > > SPL or TPL. This is incorrect as SPL handoff requires bloblist. Fix it. > > > > Signed-off-by: Simon Glass >

Re: [U-Boot] [PATCH v2 09/38] spl: Add an arch-specific hook for writing to SPL handoff

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 9:58 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > At present there is an arch-specific area in the SPL handoff area intended > > for use by arch-specific code, but there is no explicit call to fill in > > this data. Add a hook for this.

Re: [U-Boot] [PATCH v2 10/38] spl: Set up the bloblist in board_init_r()

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 9:58 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > At present the bloblist is set up in spl_common_init() which can be called > > from spl_early_init(), i.e. before SDRAM is ready. This prevents the > > bloblist from being located in SDR

Re: [U-Boot] [PATCH v2 11/38] spl: Add a function to determine the U-Boot phase

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 9:58 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > U-Boot is built in three phases: TPL, SPL and U-Boot proper. Sometimes > > it is necessary to use different init code depending on the phase. For > > example, TPL might do very basic CPU

Re: [U-Boot] [PATCH v2 15/38] x86: sysreset: Allow reset driver to be included in SPL/TPL

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:06 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > At present this driver is always included in SPL and TPL, if U-Boot proper > > enables it. Update the Makefile to provide full control using the existing > > Kconfig options. > > > > Si

Re: [U-Boot] [PATCH 2/2] watchdog: designware: Convert to DM and DT probing

2019-10-03 Thread Jagan Teki
On Thu, Oct 3, 2019 at 4:26 AM Marek Vasut wrote: > > Convert the designware watchdog timer driver to DM and add DT probing > support. Perform minor coding style clean up, like drop superfluous > braces. These ought to be no functional change. > > Signed-off-by: Marek Vasut > Cc: Chin Liang See

Re: [U-Boot] [PATCH v2 16/38] x86: Rename some FSP functions to have an fsp_ prefix

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:06 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > Given these exported function an fsp_ prefix since they are declared in an > > fsp.h header. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: None > > > > arch/x86/cp

Re: [U-Boot] [PATCH v2 18/38] x86: fsp: Use if() instead of #ifdef

2019-10-03 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Update a few #ifdefs to if() to improve build coverage. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/lib/fsp1/fsp_common.c | 9 - > arch/x86/lib/fsp1/fsp_dram.c | 8 ++-- > 2 files changed, 6 inser

Re: [U-Boot] [PATCH v2 18/38] x86: fsp: Use if() instead of #ifdef

2019-10-03 Thread Bin Meng
On Thu, Oct 3, 2019 at 4:16 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > Update a few #ifdefs to if() to improve build coverage. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: None > > > > arch/x86/lib/fsp1/fsp_common.c | 9 - > >

Re: [U-Boot] [PATCH v2 19/38] x86: fsp: Tidy up comment style a little

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:06 PM Bin Meng wrote: > > Hi Simon, > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > The comments in the FSP code use a different style from the rest of the > > x86 code. I am not sure it this is intentional. > > I guess it's because when it was written I

Re: [U-Boot] [PATCH v2 17/38] x86: fsp: Create a common fsp_support.h header

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:06 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > Many support functions are common between FSP1 and FSP2. Add a new header > > to handle this. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: None > > > > arch/x86/i

Re: [U-Boot] [PATCH v2 20/38] x86: fsp: Move common dram functions into a common file

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:06 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > > > Most of the DRAM functionality can be shared between FSP1 and FSP2. Move > > it into a shared file. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: None > > > > arch

Re: [U-Boot] [PATCH v2 23/38] efi: Move inline functions to unconditional part of header

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:07 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > > > At present these two functions are defined in efi_loader.h but only if > > CONFIG_EFI_LOADER is enabled. But these are functions that are useful to > > other code, such as that which de

Re: [U-Boot] [PATCH v2 22/38] x86: fsp: Move common support functions into a common file

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:06 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > Some of this file can be shared between FSP1 and FSP2. Move it into a > > shared file. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: None > > > > arch/x86/lib/fsp/

Re: [U-Boot] [PATCH v2 21/38] x86: Move common fsp functions into a common file

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:06 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > Some of this file can be shared between FSP1 and FSP2. Move it into a > > shared file. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: None > > > > arch/x86/include/

Re: [U-Boot] [PATCH v2 24/38] x86: fsp: Add a few more definitions for FSP2

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:07 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > > > Add definitions for the FSP signature and the FSP init phase. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: None > > > > arch/x86/include/asm/fsp/fsp_infoheader.h

Re: [U-Boot] [PATCH v2 25/38] x86: fsp: Add access to variable MRC data

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:07 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > > > With FSP2 the non-volatile storage used by the FSP to init memory can be > > split into a fixed piece (determined at compile time) and a variable piece > > (determined at run time). Add

Re: [U-Boot] [RFC 2/3] lib: rsa: generate additional parameters for public key

2019-10-03 Thread AKASHI Takahiro
Ilias, On Thu, Oct 03, 2019 at 10:34:33AM +0300, Ilias Apalodimas wrote: > On Fri, Sep 06, 2019 at 04:08:07PM +0900, AKASHI Takahiro wrote: > > In the current implementation of FIT_SIGNATURE, five parameters for > > a RSA public key are required while only two of them are essential. > > (See rsa-m

Re: [U-Boot] [PATCH v2 28/38] x86: pci: Add a function to clear and set PCI config regs

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:07 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > > > At present the x86 pre-DM equivalent of pci_bus_clrset_config32() does not > > exist. Add it to simplify PCI init code on x86. > > > > Also add the missing functions to this header. > >

Re: [U-Boot] [PATCH v2 26/38] x86: Move common Intel CPU info code into a function

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:07 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > > > Add cpu_intel_get_info() to find out the CPU info on modern Intel CPUs. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: None > > > > arch/x86/cpu/broadwell/cpu_full.

Re: [U-Boot] [PATCH v2 30/38] x86: spl: Reduce priority of the basic SPL image loader

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:07 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > > > This image loader works on systems where the flash is directly mapped to > > the last part of the 32-bit address space. On recent Intel systems (such > > as apollolake) this is not the

Re: [U-Boot] [PATCH v2 29/38] x86: spl: Use hang() instead of a while() loop

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:07 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > > > Use the standard hang() function when booting fails since this implements > > the defined U-Boot behaviour for this situation. > > > > Signed-off-by: Simon Glass > > --- > > > > Change

Re: [U-Boot] [PATCH v2 27/38] x86: Add binman symbols to the image

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:07 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > > > It is useful in SPL and TPL to access symbols from binman, such as the > > position and size of an entry in the ROM. Collect these symbols together > > in the SPL binaries. > > > > Sign

Re: [U-Boot] [PATCH v2 31/38] x86: spl: Move broadwell-specific code out of generic x86 spl

2019-10-03 Thread Bin Meng
On Wed, Oct 2, 2019 at 10:07 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > > > When TPL is running, broadwell needs to do different init from SPL. There > > is no need for this code to be in the generic x86 SPL file, so move it to > > arch_cpu_init(). > > > > Sign

[U-Boot] [PATCH v2] NVMe: do PCI enumerate before nvme scan

2019-10-03 Thread Patrick Wildt
Make sure that the PCI busses are enumerated before trying to find a NVMe device. Signed-off-by: Patrick Wildt --- Changes for v2: - moved from nvme_init to nvme_boot diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h index 3570a32dff..fc0935fa21 100644 --- a/inclu

Re: [U-Boot] [PATCH v2] NVMe: do PCI enumerate before nvme scan

2019-10-03 Thread Bin Meng
On Thu, Oct 3, 2019 at 5:11 PM Patrick Wildt wrote: > > Make sure that the PCI busses are enumerated before trying to > find a NVMe device. > > Signed-off-by: Patrick Wildt > --- > Changes for v2: >- moved from nvme_init to nvme_boot > Reviewed-by: Bin Meng _

Re: [U-Boot] [PATCH] efi: device path for nvme

2019-10-03 Thread Patrick Wildt
On Thu, Oct 03, 2019 at 08:48:59AM +0200, Heinrich Schuchardt wrote: > On 10/2/19 11:11 PM, Patrick Wildt wrote: > > This adds a device path node for NVMe block devices. For that > > nvme_get_namespace_id() is added to return the privately stored > > namespace identifier. > > Thanks a lot for loo

[U-Boot] [PATCH v2] efi: device path for nvme

2019-10-03 Thread Patrick Wildt
[PATCH v2] efi: device path for nvme This adds a device path node for NVMe block devices. For that nvme_get_namespace_id() is added to return the privately stored namespace identifier and optionally also the EUI64. Signed-off-by: Patrick Wildt --- Changes for v2: - the EUI64 is now also store

Re: [U-Boot] [PATCH v2] efi: device path for nvme

2019-10-03 Thread Bin Meng
Hi Patrick, On Thu, Oct 3, 2019 at 5:21 PM Patrick Wildt wrote: > > [PATCH v2] efi: device path for nvme You don't need put the [PATCH v2] in the commit title. > > This adds a device path node for NVMe block devices. For that > nvme_get_namespace_id() is added to return the privately stored >

[U-Boot] [PATCH] nvme: add accessor to namespace id and eui64

2019-10-03 Thread Patrick Wildt
This adds a function which can be used by e.g. EFI to retrieve the namespace identifier and EUI64. For that it adds the EUI64 to its driver internal namespace structure and copies the EUI64 during namespace identification. Signed-off-by: Patrick Wildt diff --git a/drivers/nvme/nvme.c b/drivers/

[U-Boot] [PATCH] efi: device path for nvme

2019-10-03 Thread Patrick Wildt
This allows our EFI API to create a device path node for NVMe devices. It adds the necessary device path struct, uses the nvme namespace accessor to retrieve the id and eui64, and also provides support for the device path text protocol. Signed-off-by: Patrick Wildt diff --git a/include/efi_api.

Re: [U-Boot] [PATCH] nvme: add accessor to namespace id and eui64

2019-10-03 Thread Bin Meng
On Thu, Oct 3, 2019 at 5:56 PM Patrick Wildt wrote: > > This adds a function which can be used by e.g. EFI to retrieve > the namespace identifier and EUI64. For that it adds the EUI64 > to its driver internal namespace structure and copies the EUI64 > during namespace identification. > > Signed-o

Re: [U-Boot] [PATCH] efi: device path for nvme

2019-10-03 Thread Bin Meng
On Thu, Oct 3, 2019 at 5:57 PM Patrick Wildt wrote: > > This allows our EFI API to create a device path node for NVMe > devices. It adds the necessary device path struct, uses the > nvme namespace accessor to retrieve the id and eui64, and also > provides support for the device path text protocol

Re: [U-Boot] [PATCH] nvme: add accessor to namespace id and eui64

2019-10-03 Thread Patrick Wildt
On Thu, Oct 03, 2019 at 06:25:53PM +0800, Bin Meng wrote: > On Thu, Oct 3, 2019 at 5:56 PM Patrick Wildt wrote: > > > > This adds a function which can be used by e.g. EFI to retrieve > > the namespace identifier and EUI64. For that it adds the EUI64 > > to its driver internal namespace structure

[U-Boot] [PATCH 1/5] arm64: versal: Move common board dtb search

2019-10-03 Thread Michal Simek
From: Ibai Erkiaga Move the exisiting function of getting board dtb from versal to a common Xilinx folder. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- arch/arm/mach-versal/Kconfig | 5 - arch/arm/mach-versal/cpu.c | 21 - board/xilinx/Kconfig

[U-Boot] [PATCH 0/5] xilinx: Introduce Zynq/ZynqMP virtual defconfig

2019-10-03 Thread Michal Simek
Hi, The following patch series implements a common function to get the dtb for of_board configuration. Additionally provides a virtual defconfig for Zynq and ZynqMP architectures with of_board configuration enabled. In future this should go in a way where we could remove all board specific defcon

[U-Boot] [PATCH 4/5] ARM: zynq: Introduce virtual defconfig

2019-10-03 Thread Michal Simek
From: Ibai Erkiaga Add virtual defconfig for Zynq architecture using of_board dtb. This defconfig should become generic config for all Zynq boards. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- configs/zynq_virt_defconfig | 79 + 1 file chang

[U-Boot] [PATCH 5/5] arm64: versal: remove debug uart for versal virt

2019-10-03 Thread Michal Simek
From: Ibai Erkiaga Remove the debug uart configuration from versal virtual defconfig. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- configs/xilinx_versal_virt_defconfig | 5 - 1 file changed, 5 deletions(-) diff --git a/configs/xilinx_versal_virt_defconfig b/configs/xilin

[U-Boot] [PATCH 2/5] arm64: xilinx: Enable generic of_board_dtb

2019-10-03 Thread Michal Simek
From: Ibai Erkiaga Modify the configuration naming to be generic to xilinx rather than specific to Versal. The offset value is different for Zynq and ZynqMP to avoid overlapping with FSBL. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- board/xilinx/Kconfig| 5 +++-- boar

[U-Boot] [PATCH 3/5] arm64: zynqmp: Introduce virtual defconfig

2019-10-03 Thread Michal Simek
From: Ibai Erkiaga Add virtual defconfig for ZynqMP architecture using of_board dtb. This defconfig should become generic config for all ZynqMP boards. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- configs/xilinx_zynqmp_virt_defconfig | 108 +++ 1 file c

Re: [U-Boot] [PATCH] nvme: add accessor to namespace id and eui64

2019-10-03 Thread Bin Meng
Hi Patrick, On Thu, Oct 3, 2019 at 6:33 PM Patrick Wildt wrote: > > On Thu, Oct 03, 2019 at 06:25:53PM +0800, Bin Meng wrote: > > On Thu, Oct 3, 2019 at 5:56 PM Patrick Wildt wrote: > > > > > > This adds a function which can be used by e.g. EFI to retrieve > > > the namespace identifier and EUI6

Re: [U-Boot] One u-boot.bin for Raspberry PI 3 and 4 - possible?

2019-10-03 Thread Matthias Brugger
On 03/10/2019 03:44, Geoff Williams wrote: >> And with a U-Boot based on f5c626c64874d6e1482edf4a76aa22e5e54be63d without >> my >> patches you see correct behavior? > > The screen turning off issue was caused by a deployment script copying the > wrong > u-boot binary to the SD card! The patch

[U-Boot] [PATCH 1/2] nvme: add accessor to namespace id and eui64

2019-10-03 Thread Patrick Wildt
This adds a function which can be used by e.g. EFI to retrieve the namespace identifier and EUI64. For that it adds the EUI64 to its driver internal namespace structure and copies the EUI64 during namespace identification. Signed-off-by: Patrick Wildt --- drivers/nvme/nvme.c | 13 +

[U-Boot] [PATCH 2/2] efi: device path for nvme

2019-10-03 Thread Patrick Wildt
This allows our EFI API to create a device path node for NVMe devices. It adds the necessary device path struct, uses the nvme namespace accessor to retrieve the id and eui64, and also provides support for the device path text protocol. Signed-off-by: Patrick Wildt --- include/efi_api.h

Re: [U-Boot] [PATCH 1/2] nvme: add accessor to namespace id and eui64

2019-10-03 Thread Bin Meng
On Thu, Oct 3, 2019 at 7:01 PM Patrick Wildt wrote: > > This adds a function which can be used by e.g. EFI to retrieve > the namespace identifier and EUI64. For that it adds the EUI64 > to its driver internal namespace structure and copies the EUI64 > during namespace identification. > > Signed-o

[U-Boot] U-Boot build for i.MX board won't boot in corresponding QEMU machine

2019-10-03 Thread Waseem ALKurdi
Dear all, I'm trying to get mainline U-Boot to boot on mainline QEMU 4.1.0 for the 'sabrelite' board, using the configuration 'mx6qsabrelite_defconfig'. It's not booting at all. Actually, not a single U-Boot build for an i.MX board would boot, with the exception of 'imx25-pdk'. I'm compiling U

[U-Boot] What versions of SD/MMC cards are supported by "mmc write" command?

2019-10-03 Thread Andrey Sukhanov
Hello, I am working on an update script for my device, and the script is supposed to download a new image and write it to the memory card. I plan to download a new image by TFTP, and then use "mmc write" command in uboot to overwrite the content of my Linux root partition. The question is what me

Re: [U-Boot] [PATCH 2/2] watchdog: designware: Convert to DM and DT probing

2019-10-03 Thread Marek Vasut
On 10/3/19 9:55 AM, Jagan Teki wrote: > On Thu, Oct 3, 2019 at 4:26 AM Marek Vasut wrote: >> >> Convert the designware watchdog timer driver to DM and add DT probing >> support. Perform minor coding style clean up, like drop superfluous >> braces. These ought to be no functional change. >> >> Signe

[U-Boot] HAB synchronous error loop i.MX8M

2019-10-03 Thread Bartlomiej
Hello, * * I'm using an i.MX8M based Boundary Devices Nitrogen8M board with U-Boot / U-Boot SPL as the bootloader. I want to use HAB (arch/arm/mach-imx/hab.c) in order to authenticate the bootloader and kernel images before running them. The problem is my board goes into a synchronous error lo

[U-Boot] [PATCH v2 1/2] nvme: add accessor to namespace id and eui64

2019-10-03 Thread Patrick Wildt
This adds a function which can be used by e.g. EFI to retrieve the namespace identifier and EUI64. For that it adds the EUI64 to its driver internal namespace structure and copies the EUI64 during namespace identification. Signed-off-by: Patrick Wildt --- drivers/nvme/nvme.c | 13 +

Re: [U-Boot] [PATCH v2 1/2] nvme: add accessor to namespace id and eui64

2019-10-03 Thread Bin Meng
On Thu, Oct 3, 2019 at 7:48 PM Patrick Wildt wrote: > > This adds a function which can be used by e.g. EFI to retrieve > the namespace identifier and EUI64. For that it adds the EUI64 > to its driver internal namespace structure and copies the EUI64 > during namespace identification. > > Signed-o

Re: [U-Boot] U-Boot build for i.MX board won't boot in corresponding QEMU machine

2019-10-03 Thread Bin Meng
+QEMU developers ML On Thu, Oct 3, 2019 at 7:37 PM Waseem ALKurdi wrote: > > Dear all, > > I'm trying to get mainline U-Boot to boot on mainline QEMU 4.1.0 for the > 'sabrelite' board, using the configuration 'mx6qsabrelite_defconfig'. > > It's not booting at all. Actually, not a single U-Boot b

[U-Boot] [PATCH v2 2/2] efi: device path for nvme

2019-10-03 Thread Patrick Wildt
This allows our EFI API to create a device path node for NVMe devices. It adds the necessary device path struct, uses the nvme namespace accessor to retrieve the id and eui64, and also provides support for the device path text protocol. Signed-off-by: Patrick Wildt --- include/efi_api.h

Re: [U-Boot] [PATCH 2/2] watchdog: designware: Convert to DM and DT probing

2019-10-03 Thread Marek Vasut
On 10/3/19 1:40 PM, Marek Vasut wrote: > On 10/3/19 9:55 AM, Jagan Teki wrote: >> On Thu, Oct 3, 2019 at 4:26 AM Marek Vasut wrote: >>> >>> Convert the designware watchdog timer driver to DM and add DT probing >>> support. Perform minor coding style clean up, like drop superfluous >>> braces. These

Re: [U-Boot] [PATCH 001/126] dm: core: Use U-Boot logging instead of pr_debug()

2019-10-03 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > The pr_debug() functions do not response to setting the log level and in > fact have their own separate log level. Use U-Boot logging instead. > > Perhaps we should make these options redirect to log_debug(), etc.? > > Signed-off-by: Simon Gl

Re: [U-Boot] [PATCH 002/126] dm: core: Correct low cell in ofnode_read_pci_addr()

2019-10-03 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > This reads the low cell of the PCI address from the wrong cell. Fix it. > Also fix the function that this code came from. > > Fixes: 9e51204527 (dm: core: Add operations on device tree references) > Fixes: 4ea5243a3a (fdt: fix fdtdec_get_pci_

Re: [U-Boot] [PATCH 005/126] dm: core: Don't include ofnode functions with of-platdata

2019-10-03 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > These functions cannot work with of-platdata since libfdt is not > available. At present when dev_read_...() functions are used it produces > error messages about ofnode which is confusing. > > Adjust the Makefile and header to produce an err

Re: [U-Boot] [PATCH 004/126] dm: core: Add documentation on how to debug driver model

2019-10-03 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > Sometimes devices don't appear and it can be confusing. Add a few notes to > help with this situation. > > Signed-off-by: Simon Glass > --- > > doc/driver-model/debugging.rst | 62 ++ missed updating index.rs

Re: [U-Boot] [PATCH 003/126] dm: core: Drop a few early returns

2019-10-03 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > Two functions in this file return early for no good reason. Adjust the > code to match the standard DM style of returning 0 at the end of the > function on success. > > Oddly enough this save 12 bytes of code size on ARM. > > Signed-off-by: S

Re: [U-Boot] [PATCH 006/126] dm: core: Correct bad cast in ofnode_get_addr_size_index()

2019-10-03 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > At present this code passes an fdt_addr_t pointer as a u64 pointer which > is not save, since sizeof(fdt_addr_t) may be 4, e.g. with sandbox. Correct not safe > this to avoid a stack corruption problem. > > Fixes: e679d03b08 (core: ofnode:

[U-Boot] [PATCH V2 1/3] watchdog: designware: Migrate CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2019-10-03 Thread Marek Vasut
Migrate CONFIG_DESIGNWARE_WATCHDOG to Kconfig and update the headers accordingly, no functional change. The S10 enables the WDT only in SPL, but does not enable it in U-Boot itself, hence disable it in the config again. Signed-off-by: Marek Vasut Cc: Chin Liang See Cc: Dalon Westergreen Cc: Din

[U-Boot] [PATCH V2 2/3] watchdog: designware: Convert to DM and DT probing

2019-10-03 Thread Marek Vasut
Convert the designware watchdog timer driver to DM and add DT probing support. Perform minor coding style clean up, like drop superfluous braces. There ought to be no functional change. Signed-off-by: Marek Vasut Cc: Chin Liang See Cc: Dalon Westergreen Cc: Dinh Nguyen Cc: Jagan Teki Cc: Ley

[U-Boot] [PATCH V2 3/3] watchdog: designware: Optionally fetch clock from DT

2019-10-03 Thread Marek Vasut
Add optional support for fetching watchdog clock rate from DT. This is optional as not all platforms using DW WDT support the clock framework yet. Signed-off-by: Marek Vasut Cc: Chin Liang See Cc: Dalon Westergreen Cc: Dinh Nguyen Cc: Jagan Teki Cc: Ley Foon Tan Cc: Philipp Tomisch Cc: Simo

Re: [U-Boot] HAB synchronous error loop i.MX8M

2019-10-03 Thread Patrick Wildt
On Thu, Oct 03, 2019 at 12:06:24PM +0200, Bartlomiej wrote: > Hello, > * > * > I'm using an i.MX8M based Boundary Devices Nitrogen8M board with U-Boot / > U-Boot SPL as the bootloader. I want to use HAB (arch/arm/mach-imx/hab.c) in > order to authenticate the bootloader and kernel images before run

Re: [U-Boot] HAB synchronous error loop i.MX8M

2019-10-03 Thread Fabio Estevam
Hi Patrick, On Thu, Oct 3, 2019 at 10:01 AM Patrick Wildt wrote: > Boundary Devices U-Boot is about a year old, and I haven't checked how > they implemented it. I have a diff for i.MX8M HAB support which works > for me. Please submit the i.MX8M HAB support as a formal patch. Thanks > > Best

Re: [U-Boot] [PATCH 2/2] efi: device path for nvme

2019-10-03 Thread Heinrich Schuchardt
On 10/3/19 1:02 PM, Patrick Wildt wrote: This allows our EFI API to create a device path node for NVMe devices. It adds the necessary device path struct, uses the nvme namespace accessor to retrieve the id and eui64, and also provides support for the device path text protocol. Signed-off-by: Pa

Re: [U-Boot] [PATCH 002/126] dm: core: Correct low cell in ofnode_read_pci_addr()

2019-10-03 Thread Bin Meng
On Thu, Oct 3, 2019 at 8:47 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > This reads the low cell of the PCI address from the wrong cell. Fix it. > > Also fix the function that this code came from. > > > > Fixes: 9e51204527 (dm: core: Add operations on device

Re: [U-Boot] [PATCH 006/126] dm: core: Correct bad cast in ofnode_get_addr_size_index()

2019-10-03 Thread Bin Meng
On Thu, Oct 3, 2019 at 8:48 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present this code passes an fdt_addr_t pointer as a u64 pointer which > > is not save, since sizeof(fdt_addr_t) may be 4, e.g. with sandbox. Correct > > not safe Fixed this typo, and

Re: [U-Boot] [PATCH v4 1/3] env: correct the check of env_flags_validate presence

2019-10-03 Thread Tom Rini
On Thu, Oct 03, 2019 at 09:24:26AM +0200, Patrick Delaunay wrote: > This patch corrects the check of env_flags_validate presence because > "flags.c" is always compiled in U-Boot and CONFIG_ENV_SUPPORT > don't exist; so the macro CONFIG_IS_ENABLED(ENV_SUPPORT) only provides > the expected result fo

Re: [U-Boot] [PATCH] imx: add Boundary Devices Nitrogen8M board support

2019-10-03 Thread Fabio Estevam
Hi Patrick, [Adding Troy, NXP U-Boot folks and Stefano] Thanks for your contribution. On Tue, Oct 1, 2019 at 4:15 PM Patrick Wildt wrote: > > This adds basic support for the Nitrogen8M board. It's based on > the NXP i.MX8MQ and provides 2GB of memory. This code has been > based on the i.MX8M

Re: [U-Boot] HAB synchronous error loop i.MX8M

2019-10-03 Thread Patrick Wildt
On Thu, Oct 03, 2019 at 10:13:19AM -0300, Fabio Estevam wrote: > Hi Patrick, > > On Thu, Oct 3, 2019 at 10:01 AM Patrick Wildt wrote: > > > Boundary Devices U-Boot is about a year old, and I haven't checked how > > they implemented it. I have a diff for i.MX8M HAB support which works > > for me

Re: [U-Boot] [PATCH 2/2] efi: device path for nvme

2019-10-03 Thread Patrick Wildt
On Thu, Oct 03, 2019 at 03:12:45PM +0200, Heinrich Schuchardt wrote: > On 10/3/19 1:02 PM, Patrick Wildt wrote: > > This allows our EFI API to create a device path node for NVMe > > devices. It adds the necessary device path struct, uses the > > nvme namespace accessor to retrieve the id and eui64

Re: [U-Boot] [RFC 2/3] lib: rsa: generate additional parameters for public key

2019-10-03 Thread Heinrich Schuchardt
On 10/3/19 10:58 AM, AKASHI Takahiro wrote: Ilias, On Thu, Oct 03, 2019 at 10:34:33AM +0300, Ilias Apalodimas wrote: On Fri, Sep 06, 2019 at 04:08:07PM +0900, AKASHI Takahiro wrote: In the current implementation of FIT_SIGNATURE, five parameters for a RSA public key are required while only two

Re: [U-Boot] HAB synchronous error loop i.MX8M

2019-10-03 Thread Bartlomiej
Hello Patrick, On a first glance it looks very similar to the Variscite's implementation for i.MX8M HAB, which actually seems to work for authenticating the bootloader image, but on the other hand fails on the kernel image on `hab_rvt_check_target` with the check target SMC returning -1 ("unk

Re: [U-Boot] [PATCH] imx: add Boundary Devices Nitrogen8M board support

2019-10-03 Thread Patrick Wildt
On Thu, Oct 03, 2019 at 10:27:12AM -0300, Fabio Estevam wrote: > Hi Patrick, > > [Adding Troy, NXP U-Boot folks and Stefano] > > Thanks for your contribution. Thanks for looking at it! > On Tue, Oct 1, 2019 at 4:15 PM Patrick Wildt wrote: > > > > This adds basic support for the Nitrogen8M boar

Re: [U-Boot] HAB synchronous error loop i.MX8M

2019-10-03 Thread Patrick Wildt
Since I'm not booting Linux I don't know if it will help you. :( Best regards, Patrick On Thu, Oct 03, 2019 at 03:39:34PM +0200, Bartlomiej wrote: > Hello Patrick, > > On a first glance it looks very similar to the Variscite's implementation > for i.MX8M HAB, which actually seems to work for au

Re: [U-Boot] [PATCH v2 2/3] efi_loader: disk: install FILE_SYSTEM_PROTOCOL only if available

2019-10-03 Thread Heinrich Schuchardt
On 10/3/19 9:09 AM, AKASHI Takahiro wrote: Heinrich, On Thu, Sep 12, 2019 at 06:51:35PM +0900, AKASHI Takahiro wrote: On Thu, Sep 12, 2019 at 11:43:07AM +0200, Heinrich Schuchardt wrote: On 9/12/19 11:17 AM, AKASHI Takahiro wrote: On Thu, Sep 12, 2019 at 10:57:20AM +0200, Heinrich Schuchardt

[U-Boot] [PATCH] imx: update i.MX8MQ clocks

2019-10-03 Thread Patrick Wildt
I would like to add support for additional drivers, and for that it makes sense to update the clock headers first, before adding a node to the device tree. Since no drivers use them so far it's easy to just update the header and adjust the device tree. Signed-off-by: Patrick Wildt diff --git a/

[U-Boot] [PATCH] imx: add support for i.MX7/i.MX8MQ reset controller

2019-10-03 Thread Patrick Wildt
Add support for the reset controller that's used on the i.MX7D and i.MX8MQ. This will be needed to be able to assert the PCIe reset pins. Bindings taken from Linux, driver implementation mostly taken from Linux and adjusted to U-Boot infrastructure. Signed-off-by: Patrick Wildt diff --git a/ar

[U-Boot] [PATCH] imx: add support for i.MX8MQ power domain controller

2019-10-03 Thread Patrick Wildt
Add support for the power domain controller that's used on the i.MX8MQ. This will be needed to be able to power on the PCIe controller. Bindings taken from Linux, driver implementation taken from the i.MX8 power domain controller and adjusted for the i.MX8M SoC. Signed-off-by: Patrick Wildt di

Re: [U-Boot] [PATCH v2 2/2] efi_loader: device_path: show a host device in understandable form

2019-10-03 Thread Heinrich Schuchardt
On 10/3/19 8:56 AM, AKASHI Takahiro wrote: Heinrich, On Fri, Sep 13, 2019 at 09:20:53AM +0900, AKASHI Takahiro wrote: On Thu, Sep 12, 2019 at 11:50:04AM +0200, Heinrich Schuchardt wrote: On 9/12/19 11:07 AM, AKASHI Takahiro wrote: On Thu, Sep 12, 2019 at 09:59:01AM +0200, Heinrich Schuchardt

Re: [U-Boot] [PATCH] imx: add support for i.MX7/i.MX8MQ reset controller

2019-10-03 Thread Fabio Estevam
Hi Patrick, On Thu, Oct 3, 2019 at 10:50 AM Patrick Wildt wrote: > > Add support for the reset controller that's used on the i.MX7D > and i.MX8MQ. This will be needed to be able to assert the PCIe > reset pins. Bindings taken from Linux, driver implementation > mostly taken from Linux and adjus

[U-Boot] [PATCH 1/3] imx: add support for i.MX7/i.MX8MQ reset controller

2019-10-03 Thread Patrick Wildt
Add support for the reset controller that's used on the i.MX7D and i.MX8MQ. This will be needed to be able to assert the PCIe reset pins. Bindings taken from Linux, driver implementation mostly taken from Linux and adjusted to U-Boot infrastructure. Signed-off-by: Patrick Wildt --- drivers/res

[U-Boot] [PATCH 2/3] imx: add the i.MX8M reset controller node

2019-10-03 Thread Patrick Wildt
This patch adds the reset controller node to the i.MX8MQ SoC device tree. Signed-off-by: Patrick Wildt --- arch/arm/dts/fsl-imx8mq.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/dts/fsl-imx8mq.dtsi b/arch/arm/dts/fsl-imx8mq.dtsi index c35c23e293..d843b401be 100644 --- a

[U-Boot] [PATCH 3/3] imx: enable the reset controller on the i.MX8MQ EVK

2019-10-03 Thread Patrick Wildt
This patch makes sure that the reset controller driver is compiled for the i.MX8MQ EVK. Signed-off-by: Patrick Wildt --- configs/imx8mq_evk_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/imx8mq_evk_defconfig b/configs/imx8mq_evk_defconfig index e45731edda..c0e5860e85 10064

Re: [U-Boot] [PATCH] linux_compat: fix potential NULL pointer access

2019-10-03 Thread Ralph Siemsen
On Wed, Oct 02, 2019 at 02:37:20PM +0200, Marek Szyprowski wrote: malloc_cache_aligned() might return zero, so fix potential NULL pointer access if __GFP_ZERO flag is set. Signed-off-by: Marek Szyprowski Reviewed-by: Ralph Siemsen This looks reasonable to me. The memset() will happily scrib

[U-Boot] [PATCH v3 2/2] efi: device path for nvme

2019-10-03 Thread Patrick Wildt
This allows our EFI API to create a device path node for NVMe devices. It adds the necessary device path struct, uses the nvme namespace accessor to retrieve the id and eui64, and also provides support for the device path text protocol. Signed-off-by: Patrick Wildt --- include/efi_api.h

[U-Boot] [BUGS] fs/cbfs/cbfs.c and net/net.c do not compile with GCC 9.2.1

2019-10-03 Thread Heinrich Schuchardt
Compiling fs/cbfs/cbfs.c and net/net.c fails for sandbox_defconfig using GCC 9.2.1 (Debian Bullseye): CC fs/cbfs/cbfs.o fs/cbfs/cbfs.c: In function ‘file_cbfs_fill_cache’: fs/cbfs/cbfs.c:164:16: error: taking address of packed member of ‘struct cbfs_cachenode’ may result in an unaligned poin

[U-Boot] Bootcount on raspberry pi 0 w

2019-10-03 Thread Thomas Mahringer
Hello We are using yocto + swupdate and u-boot do deliver software updates for our hardware which is based on a raspberry pi zero w. So far everything seems to be working, however I would like to use u-boot's bootcount feature to switch back to the previous version in case an upgrade fails t

[U-Boot] [BUG] arch/arm/cpu/armv7/sunxi/psci.c does not build with GCC 9.2.1

2019-10-03 Thread Heinrich Schuchardt
Building orangepi_pc_defconfig with GCC 9.2.1 (Debian Bullseye) fails: arch/arm/cpu/armv7/sunxi/psci.c: In function ‘sunxi_cpu_set_power’: arch/arm/cpu/armv7/sunxi/psci.c:163:21: error: taking address of packed member of ‘struct sunxi_prcm_reg’ may result in an unaligned pointer value [-Werror=ad

[U-Boot] [PATCH] MAINTAINERS: Update my email address

2019-10-03 Thread Maxime Ripard
I'm not at bootlin anymore, and my mail address doesn't work any longer. Signed-off-by: Maxime Ripard --- MAINTAINERS | 2 +- board/sunxi/MAINTAINERS | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e752e4b3de0f..9193f7ccf212

  1   2   >