Re: [U-Boot] [PATCH v2 0/4] arm: socfpga: Convert drivers from struct to defines

2019-10-02 Thread Ley Foon Tan
On Wed, Sep 18, 2019 at 12:23 PM Simon Goldschmidt wrote: > > > > Ley Foon Tan schrieb am Mi., 18. Sep. 2019, 04:32: >> >> On Wed, Sep 18, 2019 at 6:33 AM Dinh Nguyen wrote: >> > >> > >> > >> > On 9/10/19 3:37 AM, Ley Foon Tan wrote: >> > > This is 2nd version of patchset to convert reset, syste

Re: [U-Boot] [PATCH v4 00/17] Add Intel Agilex SoC support

2019-10-02 Thread Ley Foon Tan
On Thu, Sep 12, 2019 at 6:11 PM Ley Foon Tan wrote: > > This is 4th version of patchset to add Intel Agilex SoC[1] support. > Most of changes are related to _SOC64 prefix change and use base > address from DT for managers access. Detail changelog can find in > commit message. > > This patchset nee

Re: [U-Boot] [PATCH v4 03/17] arm: socfpga: Move Stratix10 and Agilex reset manager common code

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > Move Stratix10 and Agilex reset manager common code to reset_manager_soc64.h. > > Remove unused RSTMGR_XXX defines. > > Signed-off-by: Ley Foon Tan Reviewed-by: Simon Goldschmidt > > --- > v4: > - Change prefix from RSTMGR_S10* to RSTMGR

Re: [U-Boot] [PATCH v4 02/17] arm: socfpga: Move firewall code to firewall file

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > Move firewall related code to new firewall.c, to share > code in Stratix 10 and Agilex. > > SDMMC will transfer data to OCRAM in SPL. So, enable privilege for SDMMC > to allow DMA transfer to OCRAM. > > Signed-off-by: Ley Foon Tan Reviewed

Re: [U-Boot] [PATCH v4 04/17] arm: socfpga: agilex: Add reset manager support

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > Add reset manager support for Agilex. > > Signed-off-by: Ley Foon Tan > > --- > v3: > - Add reset_manager_soc64.h > - Convert to use defines instead of struct. > --- > arch/arm/mach-socfpga/include/mach/reset_manager.h| 2 ++ > .../ma

Re: [U-Boot] [PATCH v4 05/17] arm: socfpga: Move Stratix10 and Agilex system manager common code

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > Move Stratix10 and Agilex system manager common code to > system_manager_soc64.h. > > Signed-off-by: Ley Foon Tan Reviewed-by: Simon Goldschmidt > > --- > v4: > - Change prefix from SYSMGR_S10* to SYSMGR_SOC64*. > > v3: > - Change filen

Re: [U-Boot] [PATCH v4 06/17] arm: socfpga: agilex: Add system manager support

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > Add system manager support for Agilex. > > Signed-off-by: Ley Foon Tan > > --- > v3: > - Change include filename to system_manager_soc64.h. > - Move to use defines instead of struct. > > v2: > - Include system_manager_s10_agilex_common.h in

Re: [U-Boot] [PATCH v4 07/17] arm: socfpga: Move Stratix10 and Agilex clock manager common code

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > Move Stratix10 and Agilex clock manager common code to new header file. > > Fixed CLKMGR_INTOSC_HZ to 400MHz instead of 460MHz. Separate patch for a fix vs. moving code, please! Regards, Simon > > Signed-off-by: Ley Foon Tan > --- > ...

Re: [U-Boot] [PATCH v4 08/17] clk: agilex: Add clock driver for Agilex

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > Add clock manager driver for Agilex. Provides clock initialization > and get_rate functions. > > Rename stratix10-clock.h to socfpga-soc64-clock.h. > > stratix10-clock.h is from Linux commit ID 89727949ea1e. > > Signed-off-by: Chee Hon

Re: [U-Boot] [PATCH v4 09/17] arm: socfpga: agilex: Add clock wrapper functions

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > Add clock wrapper functions call to clock DM functions to get clock > frequency and used in cm_print_clock_quick_summary(). > > Signed-off-by: Ley Foon Tan This whole patch looks like a hack to me. However, I was facing the same problem wh

Re: [U-Boot] [PATCH v4 10/17] arm: socfpga: agilex: Add CCU support for Agilex

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:12 PM Ley Foon Tan wrote: > > Add Cache Coherency Unit (CCU) support for Agilex. > CCU is to ensures consistency of shared data between multi masters > in the system. Wouldn't this better fit into drivers/cache instead of adding yet more arch code? Regards, Simon > >

Re: [U-Boot] [PATCH v4 11/17] arm: agilex: Add clock handoff offset for Agilex

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:12 PM Ley Foon Tan wrote: > > Add clock handoff offset for Agilex. Remove S10 prefix to avoid confusion. > > Signed-off-by: Ley Foon Tan Reviewed-by: Simon Goldschmidt > --- > arch/arm/mach-socfpga/include/mach/handoff_s10.h | 9 +++-- > arch/arm/mach-socfpga/wr

Re: [U-Boot] [PATCH v4 12/17] ddr: altera: Restructure Stratix 10 SDRAM driver

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:12 PM Ley Foon Tan wrote: > > Restructure Stratix 10 SDRAM driver. Move common code to separate > file, in preparation to support SDRAM driver for Agilex. > > Signed-off-by: Ley Foon Tan > > --- > v4: > - Change to use base address from DT. I know someone has requested

Re: [U-Boot] [PATCH v4 13/17] ddr: altera: agilex: Add SDRAM driver for Agilex

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:12 PM Ley Foon Tan wrote: > > Add SDRAM driver for Agilex SoC. > > Signed-off-by: Tien Fong Chee > Signed-off-by: Ley Foon Tan Reviewed-by: Simon Goldschmidt > > --- > v4: > - Fixed checkpatch warnings > > v3: > - Use sdmmc_soc64.* > - Change compatible string to us

Re: [U-Boot] [PATCH v4 16/17] arm: dts: agilex: Add base dtsi and devkit dts

2019-10-02 Thread Simon Goldschmidt
On Thu, Sep 12, 2019 at 12:12 PM Ley Foon Tan wrote: > > Add device tree files for Agilex SoC platform. > > Based on Linux Commit ID4b36daf9ada30. > > Signed-off-by: Ley Foon Tan Reviewed-by: Simon Goldschmidt > > --- > v4: > - Add u-boot,dm-pre-reloc to sysmgr node. > > v3: > - Fixed

Re: [U-Boot] [PATCH v2 1/4] arm: dts: socfpga: Add u-boot, dm-pre-reloc for sysmgr and clkmgr nodes

2019-10-02 Thread Simon Goldschmidt
On Tue, Sep 10, 2019 at 10:38 AM Ley Foon Tan wrote: > > Add u-boot,dm-pre-reloc for sysmgr and clkmgr nodes to use it in SPL. > In preparation to get base address from DT. > > Signed-off-by: Ley Foon Tan I'm OK with this change as long as it doesn't blow SPL size limits because of the additiona

Re: [U-Boot] [PATCH v2 2/4] arm: socfpga: Convert reset manager from struct to defines

2019-10-02 Thread Simon Goldschmidt
On Tue, Sep 10, 2019 at 10:38 AM Ley Foon Tan wrote: > > Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct > to defines. > No functional change. > > Signed-off-by: Ley Foon Tan > > --- > v2: > - Get base address from DT Wait, "no functional change", yet you now read the base ad

Re: [U-Boot] [PATCH v2 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-02 Thread Simon Goldschmidt
On Tue, Sep 10, 2019 at 10:38 AM Ley Foon Tan wrote: > > Convert system manager for Gen5, Arria 10 and Stratix 10 from struct > to defines. > No functional change. > > Signed-off-by: Ley Foon Tan > > --- > v2: > - Change to use writel(), readl() and etc. > - Get base address from DT. Same as 2/4

Re: [U-Boot] [PATCH v2 4/4] arm: socfpga: Convert clock manager from struct to defines

2019-10-02 Thread Simon Goldschmidt
On Tue, Sep 10, 2019 at 10:38 AM Ley Foon Tan wrote: > > Convert clock manager for Gen5, Arria 10 and Stratix 10 from struct > to defines. > No functional change. > > Signed-off-by: Ley Foon Tan > > --- > v2: > - Change to use writel(), readl() and etc. > - Get base address from DT. And again: s

Re: [U-Boot] [PATCH v2 0/4] arm: socfpga: Convert drivers from struct to defines

2019-10-02 Thread Simon Goldschmidt
On Wed, Oct 2, 2019 at 10:13 AM Ley Foon Tan wrote: > > On Wed, Sep 18, 2019 at 12:23 PM Simon Goldschmidt > wrote: > > > > > > > > Ley Foon Tan schrieb am Mi., 18. Sep. 2019, 04:32: > >> > >> On Wed, Sep 18, 2019 at 6:33 AM Dinh Nguyen wrote: > >> > > >> > > >> > > >> > On 9/10/19 3:37 AM, Ley

Re: [U-Boot] [PATCH v4 04/17] arm: socfpga: agilex: Add reset manager support

2019-10-02 Thread Ley Foon Tan
On Wed, Oct 2, 2019 at 4:26 PM Simon Goldschmidt wrote: > > On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > > > Add reset manager support for Agilex. > > > > Signed-off-by: Ley Foon Tan > > > > --- > > v3: > > - Add reset_manager_soc64.h > > - Convert to use defines instead of struct. >

Re: [U-Boot] [PATCH v4 06/17] arm: socfpga: agilex: Add system manager support

2019-10-02 Thread Ley Foon Tan
On Wed, Oct 2, 2019 at 4:27 PM Simon Goldschmidt wrote: > > On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > > > Add system manager support for Agilex. > > > > Signed-off-by: Ley Foon Tan > > > > --- > > v3: > > - Change include filename to system_manager_soc64.h. > > - Move to use defin

Re: [U-Boot] [PATCH v4 07/17] arm: socfpga: Move Stratix10 and Agilex clock manager common code

2019-10-02 Thread Ley Foon Tan
On Wed, Oct 2, 2019 at 4:28 PM Simon Goldschmidt wrote: > > On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan wrote: > > > > Move Stratix10 and Agilex clock manager common code to new header file. > > > > Fixed CLKMGR_INTOSC_HZ to 400MHz instead of 460MHz. > > Separate patch for a fix vs. moving code

[U-Boot] [PATCH v1 2/2] test: regmap: check the values read from the regmap

2019-10-02 Thread Jean-Jacques Hiblot
The test did reads after writes but didn't check the value. It probably was because the sandbox didn't implement the writeX/readX functions. Signed-off-by: Jean-Jacques Hiblot --- test/dm/regmap.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/test/dm/regm

[U-Boot] [PATCH v1 1/2] arch: sandbox: Provide working writeX/readX functions

2019-10-02 Thread Jean-Jacques Hiblot
Those functions are used by the regmap core. Without them regmaps are not working on sandbox. The implementation is taken from arch/x86/include/asm/io.h. Signed-off-by: Jean-Jacques Hiblot --- arch/sandbox/include/asm/io.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

[U-Boot] [PATCH v1 0/2] sandbox: Fixes the regmap tests

2019-10-02 Thread Jean-Jacques Hiblot
The sandbox architecture does not implement the writeX nor readX functions. This prevents testing properly the regmaps and the other stuff relying on it. Jean-Jacques Hiblot (2): arch: sandbox: Provide working writeX/readX functions test: regmap: check the values read from the regmap arch/s

Re: [U-Boot] [PATCH 04/13] firmware: zynqmp: Add zynqmp-power support

2019-10-02 Thread Luca Ceresoli
Hi Ibai, Michal, On 27/09/19 15:34, Michal Simek wrote: > From: Ibai Erkiaga > > zynqmp-power driver for ZynqMP to handle the communication with the PMU > firmware. Firmware driver just probes subnodes and power driver handles > communication with PMU using the IPI mailbox driver. > > Signed-of

Re: [U-Boot] [PATCH 00/13] arm64: zynqmp: Clean communication with PMUFW

2019-10-02 Thread Luca Ceresoli
Hi Michal, Ibai, On 27/09/19 15:34, Michal Simek wrote: > Hi, > > This patch series using ZynqMP firmware driver to provide a interface to > communicate with the PMU Firmware. As part of the series a mailbox driver > is also implemented to handle communication through ipi interface. > > There ar

Re: [U-Boot] [PATCH 13/13] arm64: zynqmp: Use mailbox driver for PMUFW config loading

2019-10-02 Thread Luca Ceresoli
Hi Michal, On 27/09/19 15:35, Michal Simek wrote: > With new mailbox driver PMUFW configuration object can be loaded via the > same interface and there is no need to have pmu_ipc.c completely. > > Signed-off-by: Michal Simek > --- > > arch/arm/mach-zynqmp/Makefile | 4 - > ar

Re: [U-Boot] [PATCH 06/13] arm64: zynqmp: Cleanup PM SMC macro composition

2019-10-02 Thread Luca Ceresoli
Hi Michal, On 27/09/19 15:34, Michal Simek wrote: > Cleanup PM ID handling by using enum values. > > Signed-off-by: Michal Simek > Signed-off-by: Ibai Erkiaga > --- > > arch/arm/mach-zynqmp/include/mach/sys_proto.h | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > di

Re: [U-Boot] [PATCH 12/13] firmware: zynqmp: Separate function for sending message via mailbox

2019-10-02 Thread Luca Ceresoli
Hi Michal, On 27/09/19 15:35, Michal Simek wrote: > U-Boot running in EL3 can't use SMC that's why there is a need to talk to > PMUFW directly via mailbox. The same logic is applied to all functions > which need to talk to PMUFW that's why move this logic to separate function > to avoid code dupli

Re: [U-Boot] [PATCH 06/13] arm64: zynqmp: Cleanup PM SMC macro composition

2019-10-02 Thread Michal Simek
On 02. 10. 19 11:34, Luca Ceresoli wrote: > Hi Michal, > > On 27/09/19 15:34, Michal Simek wrote: >> Cleanup PM ID handling by using enum values. >> >> Signed-off-by: Michal Simek >> Signed-off-by: Ibai Erkiaga >> --- >> >> arch/arm/mach-zynqmp/include/mach/sys_proto.h | 13 +++-- >> 1

Re: [U-Boot] [PATCH 06/13] arm64: zynqmp: Cleanup PM SMC macro composition

2019-10-02 Thread Luca Ceresoli
Hi Michal, On 02/10/19 11:36, Michal Simek wrote: > On 02. 10. 19 11:34, Luca Ceresoli wrote: >> Hi Michal, >> >> On 27/09/19 15:34, Michal Simek wrote: >>> Cleanup PM ID handling by using enum values. >>> >>> Signed-off-by: Michal Simek >>> Signed-off-by: Ibai Erkiaga >>> --- >>> >>> arch/arm/

Re: [U-Boot] [PATCH 06/13] arm64: zynqmp: Cleanup PM SMC macro composition

2019-10-02 Thread Michal Simek
On 02. 10. 19 11:44, Luca Ceresoli wrote: > Hi Michal, > > On 02/10/19 11:36, Michal Simek wrote: >> On 02. 10. 19 11:34, Luca Ceresoli wrote: >>> Hi Michal, >>> >>> On 27/09/19 15:34, Michal Simek wrote: Cleanup PM ID handling by using enum values. Signed-off-by: Michal Simek

Re: [U-Boot] [PATCH 12/13] firmware: zynqmp: Separate function for sending message via mailbox

2019-10-02 Thread Michal Simek
On 02. 10. 19 11:34, Luca Ceresoli wrote: > Hi Michal, > > On 27/09/19 15:35, Michal Simek wrote: >> U-Boot running in EL3 can't use SMC that's why there is a need to talk to >> PMUFW directly via mailbox. The same logic is applied to all functions >> which need to talk to PMUFW that's why move th

Re: [U-Boot] [PATCH 04/13] firmware: zynqmp: Add zynqmp-power support

2019-10-02 Thread Michal Simek
On 02. 10. 19 11:34, Luca Ceresoli wrote: > Hi Ibai, Michal, > > On 27/09/19 15:34, Michal Simek wrote: >> From: Ibai Erkiaga >> >> zynqmp-power driver for ZynqMP to handle the communication with the PMU >> firmware. Firmware driver just probes subnodes and power driver handles >> communication w

Re: [U-Boot] [PATCH v4 04/17] arm: socfpga: agilex: Add reset manager support

2019-10-02 Thread Simon Goldschmidt
On Wed, Oct 2, 2019 at 11:25 AM Ley Foon Tan wrote: > > On Wed, Oct 2, 2019 at 4:26 PM Simon Goldschmidt > wrote: > > > > On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan > > wrote: > > > > > > Add reset manager support for Agilex. > > > > > > Signed-off-by: Ley Foon Tan > > > > > > --- > > > v3:

[U-Boot] [PATCH RESEND] cmd: itest: add support for .q size specifier

2019-10-02 Thread Marek Szyprowski
Add support for quad (64bits) memory access specifier. Signed-off-by: Marek Szyprowski Acked-by: Lukasz Majewski --- Resend reason: stand alone patch, independent from the main patchset: https://patchwork.ozlabs.org/cover/994309/ --- cmd/itest.c | 12 1 file changed, 12 insertions(

[U-Boot] [PATCH RESEND] gadget: f_thor: properly enable 3rd endpoint defined by the protocol

2019-10-02 Thread Marek Szyprowski
This is needed to make Windows THOR flash tool happy, because it starts sending data only when interrupt packet is received on the 3rd endpoint. Signed-off-by: Marek Szyprowski Acked-by: Lukasz Majewski --- Resend reason: stand alone patch, independent from the main patchset: https://patchwork.o

Re: [U-Boot] [PATCH 1/5] riscv: dts: Add hifive-unleashed-a00 dts from Linux

2019-10-02 Thread Jagan Teki
On Mon, Sep 30, 2019 at 3:35 PM Bin Meng wrote: > > Hi Jagan, > > On Sun, Sep 29, 2019 at 3:42 PM Jagan Teki wrote: > > > > Sync the hifive-unleashed-a00 dts from Linux with > > below commit details: > > commit 11ae2d892139a1086f257188d457ddcb71ab5257 > > The latest commit should be: > > commit c

[U-Boot] [PATCH RESEND] cmd: thor: select DFU subsystem also for 'thor' download tool

2019-10-02 Thread Marek Szyprowski
'THOR' download command requires DFU infrastructure to properly flash board images. It can be used without enabling DFU command, so add such dependency to Kconfig. Signed-off-by: Marek Szyprowski Acked-by: Lukasz Majewski --- Resend reason: stand alone patch, independent from the main patchset:

[U-Boot] [PATCH v2] dfu: mmc: add support for in-partition offset

2019-10-02 Thread Marek Szyprowski
Add possibility to define a part of partition as a separate DFU entity. This allows to have more than one items on the given partition. The real use case for this option is TM2 board. It can use u-boot stored as Linux kernel on the defined partition (as RAW data) and load the real kernel from the

Re: [U-Boot] [PATCH 4/5] riscv: dts: hifive-unleashed-a00: Add -u-boot.dtsi

2019-10-02 Thread Jagan Teki
On Mon, Sep 30, 2019 at 3:35 PM Bin Meng wrote: > > Hi Jagan, > > On Sun, Sep 29, 2019 at 3:43 PM Jagan Teki wrote: > > > > Add u-boot specific dts file for hifive-unleashed-a00, this > > would help to add u-boot specific properties and other node > > changes without touching the base dts(i) file

Re: [U-Boot] [PATCH v3 01/10] x86: Rename existing FSP code to fsp1

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > Since there is now a new version of the FSP and it is incompatible with > the existing version, move the code into an fsp1 directory. This will > allow us to put FSP v2 code into an fsp2 directory. > > Add a Kconfig which defines which versio

Re: [U-Boot] [PATCH v3 03/10] x86: Create a new fsp_arch.h header

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > At present fsp_support.h includes fsp_vpd.h which is an FPSv1 concept > (VPD means Vital Product Data). For FSPv2 only UPD (Updatable Product > Data) is used. > > To avoid mangling header files, put these two includes in a separate > header w

Re: [U-Boot] [PATCH v3 05/10] x86: Move fsp_types.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This header file is the same for FSP v1 and v2. Move it into the general > fsp directory. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: None > > arch/x86/include/asm/{fsp1 => fsp}/fsp

Re: [U-Boot] [PATCH v3 04/10] x86: Move fsp_api.h inclusion out of fsp_support.h

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This header file is different for each version of FSP. Move it into the > fsp_arch.h header file. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: None > > arch/x86/include/asm/fsp1/fsp_

Re: [U-Boot] [PATCH v3 06/10] x86: Move fsp_fv.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This header file is the same for FSP v1 and v2. Move it into the general > fsp directory. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: None > > arch/x86/include/asm/{fsp1 => fsp}/fsp

Re: [U-Boot] [PATCH v3 02/10] x86: Move fsp_azalia.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 6:55 AM Bin Meng wrote: > > Hi Simon, > > On Wed, Oct 2, 2019 at 1:39 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Tue, 1 Oct 2019 at 04:59, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > > > > > > > This head

Re: [U-Boot] [PATCH v3 08/10] x86: Move fsp_infoheader.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This header file is the same for FSP v1 and v2. Move it into the general > fsp directory. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: None > > arch/x86/include/asm/fsp1/fsp_support.

Re: [U-Boot] [PATCH v3 10/10] x86: Move fsp_ffs.h include to fsp_arch.h

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This include file is only used for FSP v1. Avoid including it from > fdt_support.h so we can use the latter with FSP v2. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: None > > arch/x8

Re: [U-Boot] [PATCH v3 07/10] x86: Move fsp_hob.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 8:05 AM Bin Meng wrote: > > On Wed, Oct 2, 2019 at 8:00 AM Bin Meng wrote: > > > > On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > > > > > This header file is the same for FSP v1 and v2. Move it into the general > > > fsp directory. > > > > > > Signed-off-by: Simon

Re: [U-Boot] [PATCH v3 09/10] x86: Move fsp_bootmode.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This header file is the same for FSP v1 and v2, although there may be > some additions to come. Move it into the generic fsp directory. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: No

[U-Boot] [PATCH] dwc3: flush cache only if there is a buffer attached to a request

2019-10-02 Thread Marek Szyprowski
Calling cache flush on invalid buffer, even with zero length might cause an exception on certain platforms. Signed-off-by: Marek Szyprowski --- drivers/usb/dwc3/gadget.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c in

[U-Boot] [PATCH] thor: fix error path after g_dnl_register() failure

2019-10-02 Thread Marek Szyprowski
Set command return value and perform needed cleanup when g_dnl_register() function fails. Signed-off-by: Marek Szyprowski --- cmd/thordown.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/thordown.c b/cmd/thordown.c index dd0544d475..8dae024e31 100644 --- a/cmd/thordow

Re: [U-Boot] [PATCH 000/126] x86: Add initial support for apollolake

2019-10-02 Thread Bin Meng
Hi Simon, On Wed, Oct 2, 2019 at 10:15 AM Simon Glass wrote: > > Hi Bin, > > On Wed, 25 Sep 2019 at 08:58, Simon Glass wrote: > > > > Apollolake is an Intel SoC generation aimed at relatively low-end embedded > > systems. It was released in 2016 but has become more popular recently with > > some

[U-Boot] [PATCH] linux_compat: fix potential NULL pointer access

2019-10-02 Thread Marek Szyprowski
malloc_cache_aligned() might return zero, so fix potential NULL pointer access if __GFP_ZERO flag is set. Signed-off-by: Marek Szyprowski --- lib/linux_compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/linux_compat.c b/lib/linux_compat.c index 6373b4451e..81ea8fb12

[U-Boot] [PATCH v1 3/4] drivers: mux: mmio-based syscon mux controller

2019-10-02 Thread Jean-Jacques Hiblot
This adds a driver for mmio-based syscon multiplexers controlled by bitfields in a syscon register range. This is heavily based on the linux mmio-mux driver. Signed-off-by: Jean-Jacques Hiblot --- drivers/mux/Kconfig | 15 + drivers/mux/Makefile | 1 + drivers/mux/mmio.c | 155 +++

[U-Boot] [PATCH v1 0/4] drivers: Add a framework for MUX drivers

2019-10-02 Thread Jean-Jacques Hiblot
Add a new minimalistic subsystem that handles multiplexer controllers. It provides the same API as Linux and mux drivers should be portable with a minimum effort. This series also includes a port of the Linux's mmio-mux driver. This series relies on 2 other series [1] and [2] posted earlier. [1]

[U-Boot] [PATCH v1 2/4] dm: board: complete the initialization of the muxes in initr_dm()

2019-10-02 Thread Jean-Jacques Hiblot
This will probe the multiplexer devices that have a "u-boot,mux-autoprobe" property. As a consequence they will be put in their idle state. Signed-off-by: Jean-Jacques Hiblot --- common/board_r.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/board_r.c b/common/board_r.c index d6f

[U-Boot] [PATCH v1 1/4] drivers: Add a new framework for multiplexer devices

2019-10-02 Thread Jean-Jacques Hiblot
Add a new subsystem that handles multiplexer controllers. The API is the same as in Linux. Signed-off-by: Jean-Jacques Hiblot --- drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/mux/Kconfig | 7 + drivers/mux/Makefile | 6 + drivers/m

[U-Boot] [PATCH v1 4/4] test: Add tests for the multiplexer framework

2019-10-02 Thread Jean-Jacques Hiblot
Provide tests to check the behavior of the multiplexer framework. The test uses a mmio-based multiplexer. Signed-off-by: Jean-Jacques Hiblot --- arch/sandbox/dts/test.dts | 26 +++ configs/sandbox_defconfig | 2 + test/dm/Makefile | 1 + test/dm/mux-mmio.c| 143 ++

Re: [U-Boot] [U-BOOT PATCH v2 1/2] gpio: sifive: add support for DM based gpio driver for FU540-SoC

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 1:01 AM Sagar Shrikant Kadam wrote: > > This patch adds a DM based driver model for gpio controller present in > FU540-C000 SoC on HiFive Unleashed A00 board. This SoC has one GPIO > bank and 16 GPIO lines in total, out of which GPIO0 to GPIO9 and > GPIO15 are routed to the

[U-Boot] [PATCH v2 01/13] mailbox: check ops prior calling

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga Check if request and free operations are present prior calling to the functions. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None drivers/mailbox/mailbox-uclass.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dr

[U-Boot] [PATCH v2 00/13] arm64: zynqmp: Clean communication with PMUFW

2019-10-02 Thread Michal Simek
Hi, This patch series using ZynqMP firmware driver to provide a interface to communicate with the PMU Firmware. As part of the series a mailbox driver is also implemented to handle communication through ipi interface. There are two new wiring: 1. Reading PMUFW version via firmware driver - mailb

[U-Boot] [PATCH v2 03/13] mailbox: zynqmp: ipi mailbox driver

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga ZynqMP mailbox driver implementing IPI communication with PMU. This would allow U-Boot SPL to communicate with PMUFW to request privileged operations. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None MAINTAINERS

[U-Boot] [PATCH v2 02/13] mailbox: allow subnode for mbox regs

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga The following patch allows the mailbox node in DT to host subnodes with mailbox definitions. If the client phandle to the mailbox is not the mailbox driver node, just checks parents as well. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None d

[U-Boot] [PATCH v2 04/13] firmware: zynqmp: Add zynqmp-power support

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga zynqmp-power driver for ZynqMP to handle the communication with the PMU firmware. Firmware driver just probes subnodes and power driver handles communication with PMU using the IPI mailbox driver. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: -

[U-Boot] [PATCH v2 08/13] firmware: zynqmp: create firmware header

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga New firmware header to place firmware specific macro and function declarations. The patch also moves the macros defining PM operations as well as some helper macros. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: - Move pm_api_id higher - Reporte

[U-Boot] [PATCH v2 05/13] arm64: zynqmp: add firmware and mailbox node to DT

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga The following patch adds a mailbox node and firmware node to following the mainline DT. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None arch/arm/dts/zynqmp.dtsi | 44 +++- 1 file changed, 39 insertions(+)

[U-Boot] [PATCH v2 06/13] arm64: zynqmp: Cleanup PM SMC macro composition

2019-10-02 Thread Michal Simek
Cleanup PM ID handling by using enum values. Signed-off-by: Michal Simek Signed-off-by: Ibai Erkiaga --- Changes in v2: None arch/arm/mach-zynqmp/include/mach/sys_proto.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-zynqmp/include/mach/sys_p

[U-Boot] [PATCH v2 13/13] arm64: zynqmp: Use mailbox driver for PMUFW config loading

2019-10-02 Thread Michal Simek
With new mailbox driver PMUFW configuration object can be loaded via the same interface and there is no need to have pmu_ipc.c completely. Signed-off-by: Michal Simek Reviewed-by: Luca Ceresoli --- Changes in v2: None arch/arm/mach-zynqmp/Makefile | 4 - arch/arm/mach-zynqmp

[U-Boot] [PATCH v2 12/13] firmware: zynqmp: Separate function for sending message via mailbox

2019-10-02 Thread Michal Simek
U-Boot running in EL3 can't use SMC that's why there is a need to talk to PMUFW directly via mailbox. The same logic is applied to all functions which need to talk to PMUFW that's why move this logic to separate function to avoid code duplication. Also SMC request ID can be composed from PM_SIP_SV

[U-Boot] [PATCH v2 10/13] arm64: zynqmp: remove old fw version function

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga Removes the old function to get the firmware version. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None arch/arm/mach-zynqmp/cpu.c| 23 --- arch/arm/mach-zynqmp/include/mach/sys_proto.h | 1 - 2 files chan

[U-Boot] [PATCH v2 09/13] arm64: zynqmp: use firmware driver to get version

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga Use the new function from firmware version to get the firmware version. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None board/xilinx/zynqmp/zynqmp.c | 2 +- drivers/fpga/zynqmppl.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletion

[U-Boot] [PATCH v2 07/13] firmware: zynqmp: get fw version with mailbox driver

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga Implements the function to get PMU Firmware version using the mailbox driver or smc call based on if running SPL or not. Additionally gets version as part of the ZynqMP Firmware driver probing Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: - Alig

[U-Boot] [PATCH v2 11/13] arm64: zynqmp: probe firmware driver

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga Probe ZynqMP firmware driver on the board initialization phase and ensure that firmware is in place to continue execution. The probing is done on board_init so it can be used for both SPL and U-Boot proper. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes

[U-Boot] [PATCH] Makefile: Fix typo around CONFIG_SPL_FIT_SOURCE

2019-10-02 Thread Michal Simek
Trivial fix. Signed-off-by: Michal Simek --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1d9ade948bab..60ae53d6388a 100644 --- a/Makefile +++ b/Makefile @@ -1232,7 +1232,7 @@ ifndef CONFIG_SYS_UBOOT_START CONFIG_SYS_UBOOT_START := 0 e

Re: [U-Boot] [PATCH v2 02/38] binman: Allow selection of logging verbosity

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Support a new BINMAN_VERBOSE option to the build, to allow passing the > -v flag to binman. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > Makefile| 3 ++- > tools/binman/README | 6 ++ > 2 files changed, 8

Re: [U-Boot] [PATCH v2 01/38] binman: Pass the toolpath to binman from the main Makefile

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Pass in the toolpath in case binman needs to use tools compiled in the > U-Boot tools/ directory. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > Makefile | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng __

Re: [U-Boot] [PATCH v2 04/38] mtd: spi: Add 'struct spi_flash {' to the code

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present spi_flash is defined to be spi_nor which is confusing since it > is not possible to find the 'spi_flash' by normal text search. Add a > comment to help with this. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > i

Re: [U-Boot] [PATCH v2 03/38] dm: gpio: Allow control of GPIO uclass in SPL

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present if CONFIG_SPL_GPIO_SUPPORT is enabled then the GPIO uclass > is included in SPL/TPL without any control for boards. Some boards may > want to disable this to reduce code size where GPIOs are not needed in > SPL or TPL. > > Add a ne

Re: [U-Boot] [PATCH v2 05/38] serial: ns16550: Allow serial to enabled/disabled in SPL

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present this driver uses the wrong condition for including the code and > drivers in SPL/TPL. Update it so that the code is only included if > DM_SERIAL is enabled for SPL/TPL. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None

Re: [U-Boot] [PATCH v2 08/38] spl: handoff: Correct Kconfig condition for SPL and TPL

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present these options can be enabled when bloblist is not enabled for > SPL or TPL. This is incorrect as SPL handoff requires bloblist. Fix it. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > common/spl/Kconfig | 4 ++--

Re: [U-Boot] [PATCH v2 09/38] spl: Add an arch-specific hook for writing to SPL handoff

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present there is an arch-specific area in the SPL handoff area intended > for use by arch-specific code, but there is no explicit call to fill in > this data. Add a hook for this. > > Also use the hook to remove the sandbox-specific test c

Re: [U-Boot] [PATCH v2 07/38] spl: Avoid checking for Ctrl-C in SPL with print_buffer()

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > We don't have a console in SPL so it doesn't make sense to check for > Ctrl-C when printing a memory dump. Skip this so that print_buffer() can > be used in SPL. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > lib/display_o

Re: [U-Boot] [PATCH v2 10/38] spl: Set up the bloblist in board_init_r()

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present the bloblist is set up in spl_common_init() which can be called > from spl_early_init(), i.e. before SDRAM is ready. This prevents the > bloblist from being located in SDRAM, which is useful on some platforms > where SRAM is inacce

Re: [U-Boot] [PATCH v2 11/38] spl: Add a function to determine the U-Boot phase

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > U-Boot is built in three phases: TPL, SPL and U-Boot proper. Sometimes > it is necessary to use different init code depending on the phase. For > example, TPL might do very basic CPU init, SPL might do a little more > and U-Boot proper might

Re: [U-Boot] [PATCH v2 15/38] x86: sysreset: Allow reset driver to be included in SPL/TPL

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present this driver is always included in SPL and TPL, if U-Boot proper > enables it. Update the Makefile to provide full control using the existing > Kconfig options. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > driv

Re: [U-Boot] [PATCH v2 17/38] x86: fsp: Create a common fsp_support.h header

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Many support functions are common between FSP1 and FSP2. Add a new header > to handle this. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/include/asm/fsp/fsp_support.h | 128 > arch/x86/

Re: [U-Boot] [PATCH 18/38] x86: fsp: Use if() instead of #ifdef

2019-10-02 Thread Bin Meng
Hi Simon, On Tue, Aug 27, 2019 at 12:03 AM Simon Glass wrote: > > Update a few #ifdefs to if() to improve build coverage. > > Signed-off-by: Simon Glass > --- > > arch/x86/lib/fsp1/fsp_common.c | 9 - > arch/x86/lib/fsp1/fsp_dram.c | 8 ++-- > 2 files changed, 6 insertions(+), 11

Re: [U-Boot] [PATCH v2 16/38] x86: Rename some FSP functions to have an fsp_ prefix

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Given these exported function an fsp_ prefix since they are declared in an > fsp.h header. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/cpu/baytrail/fsp_configs.c | 2 +- > arch/x86/cpu/braswell/fsp_configs

Re: [U-Boot] [PATCH v2 29/38] x86: spl: Use hang() instead of a while() loop

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > Use the standard hang() function when booting fails since this implements > the defined U-Boot behaviour for this situation. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/lib/spl.c | 3 +-- > arch/x86/lib/tpl.c |

Re: [U-Boot] [PATCH v2 22/38] x86: fsp: Move common support functions into a common file

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Some of this file can be shared between FSP1 and FSP2. Move it into a > shared file. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/lib/fsp/Makefile | 1 + > arch/x86/lib/fsp/fsp_support.c | 176 +

Re: [U-Boot] [PATCH v2 19/38] x86: fsp: Tidy up comment style a little

2019-10-02 Thread Bin Meng
Hi Simon, On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > The comments in the FSP code use a different style from the rest of the > x86 code. I am not sure it this is intentional. I guess it's because when it was written I was not familiar with the documenting style :) > > Signed-off-by

Re: [U-Boot] [PATCH v2 23/38] efi: Move inline functions to unconditional part of header

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > At present these two functions are defined in efi_loader.h but only if > CONFIG_EFI_LOADER is enabled. But these are functions that are useful to > other code, such as that which deals with Intel Handoff Blocks (HOBs). > > Move these to the t

Re: [U-Boot] [PATCH v2 25/38] x86: fsp: Add access to variable MRC data

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > With FSP2 the non-volatile storage used by the FSP to init memory can be > split into a fixed piece (determined at compile time) and a variable piece > (determined at run time). Add support for reading the latter. > > Signed-off-by: Simon Gla

Re: [U-Boot] [PATCH v2 26/38] x86: Move common Intel CPU info code into a function

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > Add cpu_intel_get_info() to find out the CPU info on modern Intel CPUs. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/cpu/broadwell/cpu_full.c| 9 + > arch/x86/cpu/intel_common/cpu.c | 13 ++

Re: [U-Boot] [PATCH v2 30/38] x86: spl: Reduce priority of the basic SPL image loader

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > This image loader works on systems where the flash is directly mapped to > the last part of the 32-bit address space. On recent Intel systems (such > as apollolake) this is not the case. > > Reduce the priority of this loader so that another

Re: [U-Boot] [PATCH v2 21/38] x86: Move common fsp functions into a common file

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Some of this file can be shared between FSP1 and FSP2. Move it into a > shared file. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/include/asm/fsp/fsp_support.h | 17 > arch/x86/include/asm/fsp1/fsp_suppor

  1   2   >