Re: [U-Boot] [PATCH] ARM: socfpga: remove unneeded NAND config options

2017-09-02 Thread Marek Vasut
On 09/02/2017 03:53 AM, Masahiro Yamada wrote: > CONFIG_NAND_DENALI select's CONFIG_SYS_NAND_SELF_INIT, so the > NAND initialization process is driven by the driver itself. > CONFIG_SYS_NAND_MAX_CHIPS and CONFIG_SYS_NAND_BASE are unused. > > Signed-off-by: Masahiro Yamada Acked-by: Marek Vasut

Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN variable with env

2017-09-02 Thread Łukasz Majewski
Hi Heiko, Would you find some time and run this patch through your test setup? Thanks in advance. Best regards, Łukasz Since commit 842778a09104 ("usb: gadget: g_dnl: only set iSerialNumber if we have a serial#") "fastboot devices" stopped to show correct device serial number for TI boards,

Re: [U-Boot] [PATCH 2/5] pci: xilinx: Remove unused field 'hose' from struct xilinx_pcie

2017-09-02 Thread Bin Meng
On Fri, Sep 1, 2017 at 10:25 PM, Tuomas Tynkkynen wrote: > This field has never been used as the driver has been DM-based since the > beginning. Drop it. > > Signed-off-by: Tuomas Tynkkynen > --- > drivers/pci/pcie_xilinx.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Bin Meng _

Re: [U-Boot] [PATCH 1/5] pci: xilinx: Fix doc comments on config space accessors

2017-09-02 Thread Bin Meng
On Fri, Sep 1, 2017 at 10:25 PM, Tuomas Tynkkynen wrote: > These take the 'struct udevice *' as an argument, not the > 'struct xilinx_pcie *` which is a local variable. Fix the comments to > match the code. > > Signed-off-by: Tuomas Tynkkynen > --- > drivers/pci/pcie_xilinx.c | 4 ++-- > 1 file

Re: [U-Boot] [PATCH 4/5] pci: layerscape: Remove unused field 'hose' from struct ls_pcie

2017-09-02 Thread Bin Meng
On Fri, Sep 1, 2017 at 10:26 PM, Tuomas Tynkkynen wrote: > This field is no longer used since the DM conversion. Drop it. > > Signed-off-by: Tuomas Tynkkynen > --- > drivers/pci/pcie_layerscape.h | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Bin Meng ___

Re: [U-Boot] [PATCH 3/5] pci: tegra: Remove unused field 'hose' from struct tegra_pcie

2017-09-02 Thread Bin Meng
On Fri, Sep 1, 2017 at 10:26 PM, Tuomas Tynkkynen wrote: > This field is no longer used since the DM conversion. Drop it. > > Signed-off-by: Tuomas Tynkkynen > --- > drivers/pci/pci_tegra.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Bin Meng ___

Re: [U-Boot] [PATCH 5/5] pci: Remove unnecessary 'default n' from Kconfig

2017-09-02 Thread Bin Meng
On Fri, Sep 1, 2017 at 10:26 PM, Tuomas Tynkkynen wrote: > 'default n' is the default anyway so it doesn't need to be specified > explicitly, and the rest of the file doesn't specify it either anywhere. > Drop it. > > Signed-off-by: Tuomas Tynkkynen > --- > drivers/pci/Kconfig | 1 - > 1 file ch

Re: [U-Boot] [PATCH] ARM: socfpga: remove unneeded NAND config options

2017-09-02 Thread Masahiro Yamada
Hi Marek. 2017-09-02 18:23 GMT+09:00 Marek Vasut : > On 09/02/2017 03:53 AM, Masahiro Yamada wrote: >> CONFIG_NAND_DENALI select's CONFIG_SYS_NAND_SELF_INIT, so the >> NAND initialization process is driven by the driver itself. >> CONFIG_SYS_NAND_MAX_CHIPS and CONFIG_SYS_NAND_BASE are unused. >> >

[U-Boot] [PATCH] Convert CONFIG_NAND_OMAP_ECCSCHEME to Kconfig

2017-09-02 Thread Adam Ford
This converts the following to Kconfig: CONFIG_NAND_OMAP_ECCSCHEME This is just the first step to migrate ECCSCHEME. Eventually, the goal is to make the Kconfig smarter by setting up menu options and dependancies after evertying gets migrated. Signed-off-by: Adam Ford --- configs/am335x_balt

[U-Boot] [PATCH 2/3] nvme: Fix potential sign extension issue in nvme_blk_rw()

2017-09-02 Thread Bin Meng
"lbas" with type "u16" (16 bits, unsigned) is promoted in "lbas << ns->lba_shift" to type "int" (32 bits, signed), then sign-extended to type "unsigned long long" (64 bits, unsigned). If "lbas << ns->lba_shift" is greater than 0x7FFF, the upper bits of the result will all be 1. Fix it by casti

[U-Boot] [PATCH 1/3] nvme: Fix wrong ndev->queues memset

2017-09-02 Thread Bin Meng
memset() was given a sizeof(NVME_Q_NUM * sizeof(struct nvme_queue *) to clear, which is wrong. Reported-by: Coverity (CID: 166729) Signed-off-by: Bin Meng --- drivers/nvme/nvme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c inde

[U-Boot] [PATCH 3/3] nvme: Remove dead codes in nvme_setup_io_queues()

2017-09-02 Thread Bin Meng
Execution cannot reach this statement: "nr_io_queues = result;" Reported-by: Coverity (CID: 166731) Signed-off-by: Bin Meng --- drivers/nvme/nvme.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index 59d54eb..1c3519b 100644 --- a/drivers/nvme/nv

Re: [U-Boot] [PATCH] ARM: socfpga: remove unneeded NAND config options

2017-09-02 Thread Marek Vasut
On 09/02/2017 04:18 PM, Masahiro Yamada wrote: > Hi Marek. Hello Masahiro, > 2017-09-02 18:23 GMT+09:00 Marek Vasut : >> On 09/02/2017 03:53 AM, Masahiro Yamada wrote: >>> CONFIG_NAND_DENALI select's CONFIG_SYS_NAND_SELF_INIT, so the >>> NAND initialization process is driven by the driver itself.

Re: [U-Boot] [PATCH 1/3] nvme: Fix wrong ndev->queues memset

2017-09-02 Thread Tom Rini
On Sat, Sep 02, 2017 at 08:15:35AM -0700, Bin Meng wrote: > memset() was given a sizeof(NVME_Q_NUM * sizeof(struct nvme_queue *) > to clear, which is wrong. > > Reported-by: Coverity (CID: 166729) > Signed-off-by: Bin Meng Reviewed-by: Tom Rini -- Tom signature.asc Description: Digital sig

Re: [U-Boot] [PATCH 3/3] nvme: Remove dead codes in nvme_setup_io_queues()

2017-09-02 Thread Tom Rini
On Sat, Sep 02, 2017 at 08:15:37AM -0700, Bin Meng wrote: > Execution cannot reach this statement: "nr_io_queues = result;" > > Reported-by: Coverity (CID: 166731) > Signed-off-by: Bin Meng Reviewed-by: Tom Rini -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] [PATCH 2/3] nvme: Fix potential sign extension issue in nvme_blk_rw()

2017-09-02 Thread Tom Rini
On Sat, Sep 02, 2017 at 08:15:36AM -0700, Bin Meng wrote: > "lbas" with type "u16" (16 bits, unsigned) is promoted in > "lbas << ns->lba_shift" to type "int" (32 bits, signed), then > sign-extended to type "unsigned long long" (64 bits, unsigned). > If "lbas << ns->lba_shift" is greater than 0x7FF

[U-Boot] [PATCH] part: mac: Suppress the error message after reading ddb

2017-09-02 Thread Bin Meng
Change to use 'debug' to output the error message if it fails to read the driver descriptor block. Signed-off-by: Bin Meng --- disk/part_mac.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/disk/part_mac.c b/disk/part_mac.c index b6c082e..507efdd 100644 --- a/disk/part

[U-Boot] [PATCH 1/3] block: ide: Drop CONFIG_IDE_INIT_POSTRESET

2017-09-02 Thread Bin Meng
This is not referenced anywhere. Drop it. Signed-off-by: Bin Meng --- drivers/block/ide.c | 9 - include/ide.h| 4 scripts/config_whitelist.txt | 1 - 3 files changed, 14 deletions(-) diff --git a/drivers/block/ide.c b/drivers/block/ide.c index edcf87b..ce

[U-Boot] [PATCH 3/3] block: Drop the ftide020 driver

2017-09-02 Thread Bin Meng
This is not used in U-Boot. Signed-off-by: Bin Meng --- drivers/block/Makefile | 1 - drivers/block/ftide020.c | 347 --- drivers/block/ftide020.h | 266 - scripts/config_whitelist.txt | 3 - 4 files chang

[U-Boot] [PATCH 2/3] block: ide: Drop CONFIG_IDE_LED

2017-09-02 Thread Bin Meng
This is actually not used. Drop it. Signed-off-by: Bin Meng --- drivers/block/ide.c | 46 include/configs/dbau1x00.h | 1 - include/configs/lsxl.h | 1 - include/configs/pb1x00.h | 1 - include/ide.h| 13 --

Re: [U-Boot] [PATCH] x86: theadorable-x86-common: Remove "ip=dhcp" from default environment

2017-09-02 Thread Bin Meng
On Wed, Aug 30, 2017 at 7:53 PM, Bin Meng wrote: > On Wed, Aug 30, 2017 at 3:40 PM, Stefan Roese wrote: >> Without ethernet cable plugged, "ip=dhcp" leads to a complete hangup in >> Linux booting and the system does not boot into userland at all. Since >> its not required to have an active networ

[U-Boot] Please pull u-boot-x86

2017-09-02 Thread Bin Meng
Hi Tom, These are some bug fixes for v2017.09. The following changes since commit 6ef2f90108e2cf101d931c71ea7904f2b6301641: Convert CONFIG_BCH to Kconfig (2017-09-01 20:45:26 -0400) are available in the git repository at: git://git.denx.de/u-boot-x86.git for you to fetch changes up to f04

Re: [U-Boot] [PATCH 01/13] x86: tsc: Add Airmont reference clock values

2017-09-02 Thread Bin Meng
On Sat, Aug 26, 2017 at 9:38 PM, Simon Glass wrote: > On 15 August 2017 at 23:41, Bin Meng wrote: >> Per the Intel 64 and IA-32 Architecture Software Developer's Manual, >> add the reference clock for Intel Atom Processors based on the Airmont >> Microarchitecture (Braswell). >> >> This keeps in

Re: [U-Boot] [PATCH 03/13] x86: fsp: Add FSP_GRAPHICS_INFO_HOB

2017-09-02 Thread Bin Meng
On Sat, Aug 26, 2017 at 9:38 PM, Simon Glass wrote: > On 15 August 2017 at 23:41, Bin Meng wrote: >> This adds a new HOB type for graphics information introduced in FSP >> spec 1.1. When graphics capability is included in FSP and enabled, >> FSP produces an FSP_GRAPHICS_INFO_HOB as described in t

Re: [U-Boot] [PATCH 04/13] x86: Add Video BIOS Table (VBT) related Kconfig options

2017-09-02 Thread Bin Meng
On Sat, Aug 26, 2017 at 9:38 PM, Simon Glass wrote: > On 15 August 2017 at 23:41, Bin Meng wrote: >> This adds Kconfig options for Video BIOS Table which is normally >> required if you are using an Intel FSP firmware that is complaint >> with spec 1.1 or later to initialize the integrated graphic

Re: [U-Boot] [PATCH 02/13] x86: fsp: Update struct common_buf for FSP spec 1.1

2017-09-02 Thread Bin Meng
On Sat, Aug 26, 2017 at 9:38 PM, Simon Glass wrote: > On 15 August 2017 at 23:41, Bin Meng wrote: >> FSP spec 1.1 adds one more member to the struct common_buf to >> determine the memory size that can be reserved by FSP below "top >> of low usable memory" for bootloader usage. This new member use

Re: [U-Boot] [PATCH 05/13] tools: binman: Add a new entry type for Intel VBT

2017-09-02 Thread Bin Meng
On Sat, Aug 26, 2017 at 9:38 PM, Simon Glass wrote: > On 15 August 2017 at 23:41, Bin Meng wrote: >> This adds a new entry type for Intel Video BIOS Table. >> >> Signed-off-by: Bin Meng >> --- >> >> tools/binman/etype/intel_vbt.py| 14 ++ >> tools/binman/func_test.py |

Re: [U-Boot] [PATCH 07/13] x86: dm: video: Add a framebuffer driver that utilizes VBT

2017-09-02 Thread Bin Meng
On Sat, Aug 26, 2017 at 11:36 AM, Simon Glass wrote: > On 15 August 2017 at 23:41, Bin Meng wrote: >> When a VBT is given to an FSP that supports graphics initialization, >> the FSP will produce a graphics info HOB that contains all necessary >> information for the linear frame buffer of the inte

Re: [U-Boot] [PATCH 08/13] x86: fsp: Update fsp command to show spec 1.1 header

2017-09-02 Thread Bin Meng
On Sat, Aug 26, 2017 at 9:39 PM, Simon Glass wrote: > On 15 August 2017 at 23:41, Bin Meng wrote: >> FSP spec 1.1 adds 3 new APIs and their offsets are in the header. >> Update the 'fsp hdr' command to show these new entries. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/include/asm/fsp/f

Re: [U-Boot] [PATCH 06/13] x86: dts: Include Intel Video BIOS Table in the ROM image

2017-09-02 Thread Bin Meng
On Sat, Aug 26, 2017 at 9:39 PM, Simon Glass wrote: > On 15 August 2017 at 23:41, Bin Meng wrote: >> Now that binman is able to recognize the Video BIOS Table entry, >> add such one in the u-boot.dtsi. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/dts/u-boot.dtsi | 6 ++ >> 1 file cha

[U-Boot] [PATCH v2 0/8] fs/fat: cleanups + readdir implementation

2017-09-02 Thread Rob Clark
Introduce directory traversal iterators, and implement fs_readdir() which is needed by EFI_LOADER. The part re-working fat.c to use the directory iterators itself is nearly a 2:1 negative diffstat, and a pretty big cleanup. I fixed one or two other small issues along the way. It hasn't really be

[U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata

2017-09-02 Thread Rob Clark
Want to re-use this in fat dirent iterator in next patch. Signed-off-by: Rob Clark --- fs/fat/fat.c | 73 +++ include/fat.h | 1 + 2 files changed, 44 insertions(+), 30 deletions(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 465a6875

[U-Boot] [PATCH v2 2/8] fs/fat: introduce new director iterators

2017-09-02 Thread Rob Clark
Untangle directory traversal into a simple iterator, to replace the existing multi-purpose do_fat_read_at() + get_dentfromdir(). Signed-off-by: Rob Clark --- fs/fat/fat.c | 326 +++ 1 file changed, 326 insertions(+) diff --git a/fs/fat/fat

[U-Boot] [PATCH v2 6/8] fat/fs: remove a bunch of dead code

2017-09-02 Thread Rob Clark
Spotted by chance, when trying to remove file_fat_ls(), I noticed there were some dead users of the API. Signed-off-by: Rob Clark Acked-by: Stefan Brüns --- fs/fat/Makefile | 4 -- fs/fat/file.c | 183 include/fat.h | 20 --- 3

[U-Boot] [PATCH v2 4/8] fs: add fs_readdir()

2017-09-02 Thread Rob Clark
Needed to support efi file protocol. The fallback.efi loader wants to be able to read the contents of the /EFI directory to find an OS to boot. Modelled after POSIX opendir()/readdir()/closedir(). Unlike the other fs APIs, this is stateful (ie. state is held in the FS_DIR "directory stream"), to

[U-Boot] [PATCH v2 5/8] fs/fat: implement opendir/readdir/closedir

2017-09-02 Thread Rob Clark
Implement the readdir interface using the directory iterators. Signed-off-by: Rob Clark --- fs/fat/fat.c | 56 1 file changed, 56 insertions(+) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index 3193290434..d30ef3903b 100644 --- a/fs/fat/fat.

[U-Boot] [PATCH v2 3/8] fat/fs: convert to directory iterators

2017-09-02 Thread Rob Clark
And drop a whole lot of ugly code! Signed-off-by: Rob Clark --- fs/fat/fat.c | 723 ++ include/fat.h | 6 - 2 files changed, 75 insertions(+), 654 deletions(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index c72d6ca931..3193290434 100644

[U-Boot] [PATCH v2 8/8] fs/fat: fix case for FAT shortnames

2017-09-02 Thread Rob Clark
Noticed when comparing our output to linux. There are some lcase bits which control whether filename and/or extension should be downcase'd. Signed-off-by: Rob Clark --- fs/fat/fat.c | 17 - fs/fat/fat_write.c | 4 ++-- include/fat.h | 3 +++ 3 files changed, 17 inse

[U-Boot] [PATCH v2 7/8] fat/fs: move ls to generic implementation

2017-09-02 Thread Rob Clark
Add a generic implementation of 'ls' using opendir/readdir/closedir, and replace fat's custom implementation. Other filesystems should move to the generic implementation after they add opendir/readdir/closedir support. Signed-off-by: Rob Clark --- fs/fat/fat.c | 32

Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per efi_object

2017-09-02 Thread Rob Clark
On Thu, Aug 31, 2017 at 10:01 AM, Alexander Graf wrote: > On 08/27/2017 12:51 AM, Heinrich Schuchardt wrote: >> >> 8 protocols per efi_object is insufficient for iPXE. >> >> Signed-off-by: Heinrich Schuchardt >> --- >> include/efi_loader.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deleti

Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per efi_object

2017-09-02 Thread Alexander Graf
> Am 02.09.2017 um 20:14 schrieb Rob Clark : > >> On Thu, Aug 31, 2017 at 10:01 AM, Alexander Graf wrote: >>> On 08/27/2017 12:51 AM, Heinrich Schuchardt wrote: >>> >>> 8 protocols per efi_object is insufficient for iPXE. >>> >>> Signed-off-by: Heinrich Schuchardt >>> --- >>> include/efi_lo

[U-Boot] [PATCHi v2] omap3: evm: Fixes for CONFIG_NAND, SPL_OS_BOOT, USB, and environment

2017-09-02 Thread Derald D. Woods
- Pass MTDPARTS kernel arguments to kernel - Use Kconfig CONFIG_NAND instead of CONFIG_SYS_EXTRA_OPTIONS="NAND" - Call 'usb_stop' on kernel start - Update Falcon mode setup to match other OMAP3 boards - Use "uEnv.txt" as boot script instead of "boot.scr" --- Changes in v2: - Rebase with master on

[U-Boot] [PATCH v3] omap3: evm: Fixes for CONFIG_NAND, SPL_OS_BOOT, USB, and environment

2017-09-02 Thread Derald D. Woods
- Pass MTDPARTS kernel arguments to kernel - Use Kconfig CONFIG_NAND instead of CONFIG_SYS_EXTRA_OPTIONS="NAND" - Call 'usb_stop' on kernel start - Update Falcon mode setup to match other OMAP3 boards - Use "uEnv.txt" as boot script instead of "boot.scr" --- Changes in v3: - Fix subject 'PATCHi' -

[U-Boot] [PATCH 1/3] GPT: create block device for sandbox testing

2017-09-02 Thread alison
From: Alison Chaiken Provide a shell script that creates a small block device for the purpose of testing the cmd/gpt.c functions in the u-boot sandbox. Running the tests removes the device file. Signed-off-by: Alison Chaiken --- test/gpt/make-test-disk.sh | 8 1 file changed, 8 insert

[U-Boot] [PATCH 3/3] add pytests for 'gpt rename' and 'gpt swap'

2017-09-02 Thread alison
From: Alison Chaiken Add unit tests for the 'gpt rename' and 'gpt swap' commands that rely on the block device created by test/gpt/make-test-disk.sh. Create a new configs/sandbox_gpt_rename_defconfig file to enable testing with CONFIG_CMD_GPT_RENAME. Remove the disk.raw test device at the end

[U-Boot] [PATCH 2/3] add pytest for 'gpt guid' command in sandbox

2017-09-02 Thread alison
From: Alison Chaiken Run unit tests for the 'gpt guid' command, making use of the disk.raw block device created by test/gpt/make-test-disk.sh script. Remove this device at the end of the tests. Signed-off-by: Alison Chaiken --- test/py/tests/test_gpt.py | 39 ++

Re: [U-Boot] omap3_logic: Move CONFIG_SYS_NAND_U_BOOT_OFFS to Kconfig

2017-09-02 Thread Tom Rini
On Sun, Aug 13, 2017 at 08:21:39AM -0500, Adam Ford wrote: > Manually enable SYS_NAND_U_BOOT_LOCATIONS. > Set CONFIG_SYS_NAND_U_BOOT_OFFS=0x8 and remove it from header > > Signed-off-by: Adam Ford Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature

Re: [U-Boot] Kconfig: Add EEPROM options to Kconfig when I2C_EEPROM is set

2017-09-02 Thread Tom Rini
On Sun, Aug 13, 2017 at 09:00:28AM -0500, Adam Ford wrote: > Add the following options to drivers/misc/Kconfig: > SYS_I2C_EEPROM_ADDR > SYS_I2C_EEPROM_BUS > SYS_EEPROM_SIZE > SYS_EEPROM_PAGE_WRITE_BITS > SYS_EEPROM_PAGE_WRITE_DELAY_MS > SYS_I2C_EEPROM_ADDR_LEN >

Re: [U-Boot] [PATCH 1/2] configs: Migrate all of the existing USB symbols, except fastboot

2017-09-02 Thread Chris Packham
On 26/08/2017 9:55 AM, "Tom Rini" wrote: This syncs all of the currently Kconfig'd symbols out of the headers and into the defconfig files. This has two exceptions, first am335x_evm needs to be converted to DM in SPL and then it can stop undef'ing CONFIG_DM_USB. Leaving this as-is results in a

[U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden target $(obj)/helloworld.so:

2017-09-02 Thread Heinrich Schuchardt
The target $(obj)/helloworld.so: exists twice in Makefile.lib. If you add an echo command to each of the two recipes you get warnings like: scripts/Makefile.lib:383: warning: overriding recipe for target 'drivers/power/battery/helloworld.so' scripts/Makefile.lib:379: warning: ignoring old recipe