Re: [U-Boot] [PATCH 4/5] imx: mx6ullevk: support plugin

2016-09-23 Thread Peng Fan
On Thu, Sep 22, 2016 at 11:48:16AM -0400, Tom Rini wrote: >On Mon, Sep 19, 2016 at 11:55:43AM +0800, van.free...@gmail.com wrote: > >> From: Peng Fan >> >> Add plugin code for mx6ullevk. >> Define CONFIG_USE_PLUGIN in include/configs/mx6ullevk.h to use plugin code. >> >> Signed-off-by: Peng Fan

[U-Boot] [PATCH v4] drivers: usb: xhci-fsl: Implement Erratum A-010151 for FSL USB3 controller

2016-09-23 Thread Sriram Dash
Currently the controller by default enables the Receive Detect feature in P3 mode in USB 3.0 PHY. However, USB 3.0 PHY does not reliably support receive detection in P3 mode. Enabling the USB3 controller to configure USB in P2 mode whenever the Receive Detect feature is required. Signed-off-by: Sr

Re: [U-Boot] [v2, 2/5] mmc: send STOP command when the READ/WRITE commands fail

2016-09-23 Thread Y.B. Lu
> -Original Message- > From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] > Sent: Monday, September 19, 2016 8:09 AM > To: Y.B. Lu; u-boot@lists.denx.de > Cc: york sun > Subject: Re: [v2, 2/5] mmc: send STOP command when the READ/WRITE > commands fail > > Hi Yangbo, > > On 08/02/2016 06:

[U-Boot] [PATCH v3 0/7] add pwm regulator driver

2016-09-23 Thread Kever Yang
This patch set add pwm regulator driver and enable it on rk3399, also do some update and fix to make the regulator driver work properly. Changes in v3: - remove priv->boot_on to fix compile error Changes in v2: - add comments for pwm_regulator_info struct member - do not init pwm_id if there is

[U-Boot] [PATCH v3 3/7] power: regulator: add pwm regulator

2016-09-23 Thread Kever Yang
add driver support for pwm regulator. Signed-off-by: Elaine Zhang Signed-off-by: Kever Yang Acked-by: Simon Glass --- Changes in v3: - remove priv->boot_on to fix compile error Changes in v2: - add comments for pwm_regulator_info struct member - do not init pwm_id if there is none - other fix

[U-Boot] [PATCH v3 1/7] rockchip: rk3399: update PPLL and pmu_pclk frequency

2016-09-23 Thread Kever Yang
Update PPLL to 676MHz and PMU_PCLK to 48MHz, because: 1. 48MHz can make sure the pwm can get exact 50% duty ratio, but 99MHz can not, 2. We think 48MHz is fast enough for pmu pclk and it is lower power cost than 99MHz, 3. PPLL 676 MHz and PMU_PCLK 48MHz are the clock rate we are using internally fo

[U-Boot] [PATCH v3 4/7] rockchip: evb_rk3399: init vdd_center regulator

2016-09-23 Thread Kever Yang
Add vdd_center pwm regulator get_device to enable this regulator. Signed-off-by: Kever Yang Acked-by: Simon Glass --- Changes in v3: None Changes in v2: - add Acked-by tag from Simon and commit message fix board/rockchip/evb_rk3399/evb-rk3399.c | 6 ++ 1 file changed, 6 insertions(+) dif

[U-Boot] [PATCH v3 2/7] rockchip: rkpwm: fix the register sequence

2016-09-23 Thread Kever Yang
Reference to kernel source code, rockchip pwm has three type, we are using v2 for rk3288 and rk3399, so let's update the register to sync with pwm_data_v2 in kernel. Signed-off-by: Kever Yang Acked-by: Simon Glass --- Changes in v3: None Changes in v2: None arch/arm/include/asm/arch-rockchip/

[U-Boot] [PATCH v3 6/7] dts: evb-rk3399: add init voltage node for vdd-center

2016-09-23 Thread Kever Yang
Add a regulator-init-microvolt for vdd_center regulator so that we can get a init value for driver probe. Not like pmic regulator, the PWM regulator do not have a known default output value, so we would like to init the regulator when driver probe. Signed-off-by: Kever Yang Acked-by: Simon Glass

[U-Boot] [PATCH v3 5/7] Kconfig: rockchip: enable DM_PWM and DM_REGULATOR

2016-09-23 Thread Kever Yang
Enable DM_PWM and DM_REGULATOR on rockchip SoCs. Signed-off-by: Kever Yang Acked-by: Simon Glass --- Changes in v3: None Changes in v2: None arch/arm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 4928206..c877f5d 100644 --- a/arch/arm/

[U-Boot] [PATCH v3 7/7] config: evb-rk3399: enable pwm regulator

2016-09-23 Thread Kever Yang
Enable the pwm regulator for evb-rk3399. Signed-off-by: Kever Yang Acked-by: Simon Glass --- Changes in v3: None Changes in v2: None configs/evb-rk3399_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig index 1e7575d..6468

[U-Boot] [PATCH] arm: ls102xa: Remove reduplicate definition for Generic Timer frequency

2016-09-23 Thread Alison Wang
GENERIC_TIMER_CLK and CONFIG_TIMER_CLK_FREQ are both used to define Generic Timer frequency. It is reduplicate. This patch will remove GENERIC_TIMER_CLK macro. Signed-off-by: Alison Wang --- arch/arm/cpu/armv7/ls102xa/psci.S | 2 +- arch/arm/cpu/armv7/ls102xa/timer.c | 2 +- include/configs/ls1

Re: [U-Boot] [v2, 1/5] mmc: fsl_esdhc: don't set XFERTYP_RSPTYP_48_BUSY for CMD with busy response

2016-09-23 Thread Y.B. Lu
> -Original Message- > From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] > Sent: Monday, September 19, 2016 8:17 AM > To: Y.B. Lu; york sun; u-boot@lists.denx.de; Pantelis Antoniou > Subject: Re: [v2, 1/5] mmc: fsl_esdhc: don't set XFERTYP_RSPTYP_48_BUSY > for CMD with busy response > >

Re: [U-Boot] [PATCH 4/5] imx: mx6ullevk: support plugin

2016-09-23 Thread Peng Fan
On Thu, Sep 22, 2016 at 11:48:16AM -0400, Tom Rini wrote: >On Mon, Sep 19, 2016 at 11:55:43AM +0800, van.free...@gmail.com wrote: > >> From: Peng Fan >> >> Add plugin code for mx6ullevk. >> Define CONFIG_USE_PLUGIN in include/configs/mx6ullevk.h to use plugin code. >> >> Signed-off-by: Peng Fan

Re: [U-Boot] [v2, 4/5] mmc: add workaround for eSDHC erratum A009620

2016-09-23 Thread Y.B. Lu
> -Original Message- > From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] > Sent: Monday, September 19, 2016 8:16 AM > To: Y.B. Lu; u-boot@lists.denx.de > Cc: york sun > Subject: Re: [v2, 4/5] mmc: add workaround for eSDHC erratum A009620 > > On 08/02/2016 06:20 PM, Yangbo Lu wrote: > > E

Re: [U-Boot] [PATCH 1/2] Makefile: use if_change_dep for u-boot.cfg

2016-09-23 Thread Masahiro Yamada
2016-09-23 13:16 GMT+09:00 Simon Glass : > On 19 September 2016 at 12:20, Stephen Warren wrote: >> From: Stephen Warren >> >> cmd_cpp_cfg generates a dependency output, but because it's invoked using >> if_changed rather than if_changed_dep, that dependency file is ignored. >> This results in Kbu

[U-Boot] couple questions on driver model for gpio, and gpio in sandbox

2016-09-23 Thread Robert P. J. Day
currently crawling through the gpio code in u-boot so, question one, i see in include/asm-generic/gpio.h, the explicitly listed as "deprecated" old API routines: int gpio_request(unsigned gpio, const char *label) int gpio_free(unsigned gpio) int gpio_direction_input(unsigned gpio) int gpio_

[U-Boot] [PATCH] mmc: dw_mmc: remove the unnecessary arguments for dwmci_setup_cfg

2016-09-23 Thread Jaehoon Chung
Some arguments don't need to pass to dwmci_setup_cfg. They are already included in dwmci_host structure. Signed-off-by: Jaehoon Chung --- drivers/mmc/dw_mmc.c | 13 ++--- drivers/mmc/exynos_dw_mmc.c | 3 +-- drivers/mmc/rockchip_dw_mmc.c | 3 +-- drivers/mmc/socfpga_dw_mmc.c

[U-Boot] [PATCH 1/2] mmc: sdhci: use the host version value in sdhci_setup_cfg

2016-09-23 Thread Jaehoon Chung
"host->version" isn't a SoC specific value. It doesn't need to get in each SoC drivers. Signed-off-by: Jaehoon Chung --- drivers/mmc/atmel_sdhci.c | 1 - drivers/mmc/bcm2835_sdhci.c | 1 - drivers/mmc/kona_sdhci.c| 5 - drivers/mmc/msm_sdhci.c | 3 --- drivers/mmc/mv_sdhci.c |

[U-Boot] [PATCH 2/2] mmc: sdhci: use the generic error number

2016-09-23 Thread Jaehoon Chung
Use the generic error number instead of meaningless value. Signed-off-by: Jaehoon Chung --- drivers/mmc/kona_sdhci.c | 6 +++--- drivers/mmc/mv_sdhci.c | 2 +- drivers/mmc/s5p_sdhci.c | 8 drivers/mmc/sdhci.c | 12 ++-- 4 files changed, 14 insertions(+), 14 deletions(

Re: [U-Boot] [PATCH 2/2] mmc: sdhci: use the generic error number

2016-09-23 Thread Stefan Roese
On 23.09.2016 12:14, Jaehoon Chung wrote: Use the generic error number instead of meaningless value. Signed-off-by: Jaehoon Chung --- drivers/mmc/kona_sdhci.c | 6 +++--- drivers/mmc/mv_sdhci.c | 2 +- drivers/mmc/s5p_sdhci.c | 8 drivers/mmc/sdhci.c | 12 ++-- 4 fi

Re: [U-Boot] [RFC v2] bootm: fix passing argc to standalone apps

2016-09-23 Thread Zubair Lutfullah Kakakhel
Hi, comments at end On 09/19/2016 01:57 AM, Simon Glass wrote: On 9 September 2016 at 02:18, Zubair Lutfullah Kakakhel wrote: This bug appears in b6396403 which makes u-boot unable to pass arguments via bootm to a standalone application without this patch. Steps to reproduce. Compile a u-bo

Re: [U-Boot] [PATCH 03/15] net: mvneta: Make driver 64bit safe

2016-09-23 Thread Stefan Roese
On 16.09.2016 19:30, Joe Hershberger wrote: On Fri, Sep 16, 2016 at 8:09 AM, Stefan Roese wrote: The mvneta driver is also used on the ARMv8 64bit Armada 3700 SoC. This patch fixes the compilation warnings seen on this 64bit platform. Signed-off-by: Stefan Roese Cc: Nadav Haklai Cc: Kostya P

Re: [U-Boot] [PATCH] ns16650: Make sure we have CONFIG_CLK set before using infrastructure

2016-09-23 Thread Tom Rini
On Fri, Sep 23, 2016 at 11:27:25AM +0900, Masahiro Yamada wrote: > Hi Tom, > > > 2016-09-23 10:11 GMT+09:00 Tom Rini : > > We cannot call on the CONFIG_CLK based clk_get_rate function unless > > CONFIG_CLK is set. > > > > Signed-off-by: Tom Rini > > --- > > drivers/serial/ns16550.c | 7 +--

[U-Boot] [PATCH 04/15 v2] net: mvneta: Add support for Armada 3700 SoC

2016-09-23 Thread Stefan Roese
This patch adds support for the Armada 3700 SoC to the Marvell mvneta network driver. Not like A380, in Armada3700, there are two layers of decode windows for GBE: First layer is: GbE Address window that resides inside the GBE unit, Second layer is: Fabric address window which is located in the N

[U-Boot] [PATCH 09/15 v2] arm64: mvebu: Armada 3700: Add SPI device tree nodes

2016-09-23 Thread Stefan Roese
This patch adds the SPI device tree nodes that are still missing to the Armada 3700 dts files. Signed-off-by: Stefan Roese Cc: Nadav Haklai Cc: Kostya Porotchkin Cc: Wilson Ding Cc: Victor Gu Cc: Hua Jing Cc: Terry Zhou Cc: Hanna Hawa Cc: Haim Boot --- v2: - Use "spi-flash" instead of "je

Re: [U-Boot] [PATCH 09/15 v2] arm64: mvebu: Armada 3700: Add SPI device tree nodes

2016-09-23 Thread Jagan Teki
On Fri, Sep 23, 2016 at 5:07 PM, Stefan Roese wrote: > This patch adds the SPI device tree nodes that are still missing to > the Armada 3700 dts files. > > Signed-off-by: Stefan Roese > Cc: Nadav Haklai > Cc: Kostya Porotchkin > Cc: Wilson Ding > Cc: Victor Gu > Cc: Hua Jing > Cc: Terry Zhou

Re: [U-Boot] disabling mmc in spl when booting using bootrom

2016-09-23 Thread Sandy Patterson
> > My concern with the Rockchip back-to-brom feature is that then U-Boot > cannot load U-Boot normally as SPL likes to do. I think it is fine > when we are short on space, but OF_PLATDATA fixes that. > > So I think the back-to-rom feature need to be optional on boards which > don't have to use it,

Re: [U-Boot] [v2, 1/5] mmc: fsl_esdhc: don't set XFERTYP_RSPTYP_48_BUSY for CMD with busy response

2016-09-23 Thread Y.B. Lu
> -Original Message- > From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] > Sent: Monday, September 19, 2016 8:07 AM > To: Y.B. Lu; u-boot@lists.denx.de > Cc: york sun > Subject: Re: [v2, 1/5] mmc: fsl_esdhc: don't set XFERTYP_RSPTYP_48_BUSY > for CMD with busy response > > Hi Yangbo, >

Re: [U-Boot] [PATCH 02/15] spi: Add driver for Marvell Armada 3700 SoC

2016-09-23 Thread Stefan Roese
On 21.09.2016 09:56, Jagan Teki wrote: > On Fri, Sep 16, 2016 at 6:39 PM, Stefan Roese wrote: >> The SPI IP core in the Marvell Armada 3700 is similar to the one in the >> other Armada SoCs. But the differences are big enough that it makes >> sense to introduce a new driver instead of cluttering t

[U-Boot] [PATCH 02/15 v2] spi: Add driver for Marvell Armada 3700 SoC

2016-09-23 Thread Stefan Roese
The SPI IP core in the Marvell Armada 3700 is similar to the one in the other Armada SoCs. But the differences are big enough that it makes sense to introduce a new driver instead of cluttering the old kirkwood driver with #ifdef's. Signed-off-by: Stefan Roese Cc: Nadav Haklai Cc: Kostya Porotch

Re: [U-Boot] Rockchip patches for testing

2016-09-23 Thread Sandy Patterson
On Thu, Sep 22, 2016 at 11:17 PM, Simon Glass wrote: > Hi, > > I have pushed a branch to u-boot-rockchip/testing. Please take a look > and let me know if any of these patches need rework. > > Are there more patches coming for this merge window? > > Re rk3399, one of the patches causes a build err

[U-Boot] [PATCH v2 1/2] mtd: nand : zynq_nand: Add nand driver support for zynq

2016-09-23 Thread Siva Durga Prasad Paladugu
Add nand flash controller driver support for zynq SoC. Signed-off-by: Siva Durga Prasad Paladugu --- Changes for v2: - corrected the from address --- drivers/mtd/nand/Kconfig |7 + drivers/mtd/nand/Makefile|1 + drivers/mtd/nand/zynq_nand.c | 1186

Re: [U-Boot] [PATCH 02/15 v2] spi: Add driver for Marvell Armada 3700 SoC

2016-09-23 Thread Jagan Teki
On Fri, Sep 23, 2016 at 5:47 PM, Stefan Roese wrote: > The SPI IP core in the Marvell Armada 3700 is similar to the one in the > other Armada SoCs. But the differences are big enough that it makes > sense to introduce a new driver instead of cluttering the old > kirkwood driver with #ifdef's. > >

Re: [U-Boot] [PATCH 02/15 v2] spi: Add driver for Marvell Armada 3700 SoC

2016-09-23 Thread Stefan Roese
On 23.09.2016 14:53, Jagan Teki wrote: On Fri, Sep 23, 2016 at 5:47 PM, Stefan Roese wrote: The SPI IP core in the Marvell Armada 3700 is similar to the one in the other Armada SoCs. But the differences are big enough that it makes sense to introduce a new driver instead of cluttering the old k

Re: [U-Boot] [PATCH v3 00/16] imx6: Add Engicam i.CoreM6 QDL support

2016-09-23 Thread Jagan Teki
Hi Stefano, On Thu, Sep 22, 2016 at 8:52 PM, Jagan Teki wrote: > This series supports Engicam i.CoreM6 QDL modules on top of > u-boot-imx.git/next > and test on the respective starter kits as well. > > Changes for v3: > - Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs base" >

[U-Boot] [PATCH] fs-test.sh: Update expected results

2016-09-23 Thread Tom Rini
Thanks to Stefan Brüns we have more tests and a few more passes too, update the expected output now. Cc: Stefan Brüns Signed-off-by: Tom Rini --- test/fs/fs-test.sh | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh index 5

Re: [U-Boot] [PATCH 02/15 v2] spi: Add driver for Marvell Armada 3700 SoC

2016-09-23 Thread Jagan Teki
On Fri, Sep 23, 2016 at 6:54 PM, Stefan Roese wrote: > On 23.09.2016 14:53, Jagan Teki wrote: >> >> On Fri, Sep 23, 2016 at 5:47 PM, Stefan Roese wrote: >>> >>> The SPI IP core in the Marvell Armada 3700 is similar to the one in the >>> other Armada SoCs. But the differences are big enough that i

[U-Boot] [PATCH 02/15 v3] spi: Add driver for Marvell Armada 3700 SoC

2016-09-23 Thread Stefan Roese
The SPI IP core in the Marvell Armada 3700 is similar to the one in the other Armada SoCs. But the differences are big enough that it makes sense to introduce a new driver instead of cluttering the old kirkwood driver with #ifdef's. Signed-off-by: Stefan Roese Cc: Nadav Haklai Cc: Kostya Porotch

Re: [U-Boot] [PATCH 02/15 v3] spi: Add driver for Marvell Armada 3700 SoC

2016-09-23 Thread Jagan Teki
On Fri, Sep 23, 2016 at 7:58 PM, Stefan Roese wrote: > The SPI IP core in the Marvell Armada 3700 is similar to the one in the > other Armada SoCs. But the differences are big enough that it makes > sense to introduce a new driver instead of cluttering the old > kirkwood driver with #ifdef's. > >

Re: [U-Boot] [PATCH 2/2] zynq: nand: Enable Nand flash controller driver a zynq board

2016-09-23 Thread Siva Durga Prasad Paladugu
Hi, Please ignore this series. I will resend the patch. Regards, Siva > -Original Message- > From: root [mailto:root@xhdsivadur40] > Sent: Friday, September 23, 2016 6:00 PM > To: u-boot@lists.denx.de > Cc: o...@buserror.net; Michal Simek ; Siva Durga > Prasad Paladugu > Subject: [PATCH

[U-Boot] [PATCH v2 2/2] zynq: nand: Enable Nand flash controller driver a zynq board

2016-09-23 Thread Siva Durga Prasad Paladugu
Enable zynq Nand flash controller driver for a zynq ZC770 XM011(dc2) board. Signed-off-by: Siva Durga Prasad Paladugu --- Changes for v2: - Corrected the from address --- configs/zynq_zc770_xm011_defconfig | 2 ++ include/configs/zynq-common.h | 7 +++ 2 files changed, 9 insertions(+)

Re: [U-Boot] [PATCH 03/15] net: mvneta: Make driver 64bit safe

2016-09-23 Thread Joe Hershberger
Hi Stefan, On Fri, Sep 23, 2016 at 6:05 AM, Stefan Roese wrote: > On 16.09.2016 19:30, Joe Hershberger wrote: >> >> On Fri, Sep 16, 2016 at 8:09 AM, Stefan Roese wrote: >>> >>> The mvneta driver is also used on the ARMv8 64bit Armada 3700 SoC. This >>> patch fixes the compilation warnings seen o

Re: [U-Boot] [PATCH 04/15 v2] net: mvneta: Add support for Armada 3700 SoC

2016-09-23 Thread Joe Hershberger
On Fri, Sep 23, 2016 at 6:26 AM, Stefan Roese wrote: > This patch adds support for the Armada 3700 SoC to the Marvell mvneta > network driver. > > Not like A380, in Armada3700, there are two layers of decode windows for GBE: > First layer is: GbE Address window that resides inside the GBE unit, >

Re: [U-Boot] [PATCH] vexpress: disable cci ace slave ports when booting in non-sec/hyp mode

2016-09-23 Thread Marc Zyngier
On 23/09/16 16:10, Sudeep Holla wrote: > Commit f225d39d3093 ("vexpress: Check TC2 firmware support before defaulting > to nonsec booting") added support to check if the firmware on TC2 is > configured appropriately before booting in nonsec/hyp mode. > > However when booting in non-secure/hyp mod

Re: [U-Boot] U-boot Driver Model - MMC - missing uclass implementation?

2016-09-23 Thread Simon Glass
Hi Phllipp, On 23 September 2016 at 09:30, Philipp Rossak wrote: > Hi, > > I would like to develop an mmc driver for the STM32 boards with the new > driver model. > > I already built up the basic structure and I discovered some strange > behaviour compared to net or serial drivers: > > When I pla

[U-Boot] [PATCH v2 2/2] Sync config_whitelist.txt

2016-09-23 Thread Masahiro Yamada
It is a good practice to drop a option from the whitelist when we convert it to Kconfig, but we may sometimes forget to do that. So, it might be a good idea to sync the whitelist from time to time. This commit was generated by: scripts/build-whitelist.sh Looks like we had a bit progress... Si

[U-Boot] [PATCH v2 0/2] config whitelist: tool update and sync

2016-09-23 Thread Masahiro Yamada
The current build-whitelist.sh allows to add new options into the whitelist. For example, it is possible that somebody adds #ifdef CONFIG_NEW_OPTITON to his C file. So, the build-whitelist.sh will pick it up when we run it next time. We never want to increase the ad-hoc options. 1/2 bans such a ca

[U-Boot] [PATCH v2 1/2] build-whitelist: do not add new options to whitelist when update

2016-09-23 Thread Masahiro Yamada
If somebody adds references to new CONFIG options in source files, they will be added in the whitelist when we sync it. (For example, if we run scripts/build-whitelist.sh against commit 201c9d884dca, new options CONFIG_SPL_DFU_SUPPORT and CONFIG_USB_XHCI_UNIPHIER will appear in the list.) In orde

Re: [U-Boot] [PATCH v7 10/12] dm: syscon: Provide a generic syscon driver

2016-09-23 Thread Paul Burton
On Thursday, 22 September 2016 22:15:48 BST Simon Glass wrote: > Hi, > > On 8 September 2016 at 00:47, Paul Burton wrote: > > Provide a trivial syscon driver matching the generic "syscon" compatible > > string, allowing for simple system controllers to be used without a > > custom driver just as

Re: [U-Boot] [PATCH] net: smsc95xx: fix DM MAC address reading

2016-09-23 Thread Stephen Warren
On 09/15/2016 01:20 PM, Joe Hershberger wrote: On Thu, Sep 15, 2016 at 1:53 PM, Stephen Warren wrote: From: Stephen Warren eth-uclass.c expects DM-capable Ethernet adapters to implement ops-> read_rom_hwaddr(), or for some other mechanism to set pdata->enetaddr, or for the user to set environ

Re: [U-Boot] [PATCH] vexpress: disable cci ace slave ports when booting in non-sec/hyp mode

2016-09-23 Thread Jon Medhurst (Tixy)
On Fri, 2016-09-23 at 16:10 +0100, Sudeep Holla wrote: > +#ifdef CONFIG_OF_BOARD_SETUP > +int ft_board_setup(void *fdt, bd_t *bd) > +{ > + int offset, tmp, len; > + const struct fdt_property *prop; > + const char *cci_compatible = "arm,cci-400-ctrl-if"; > + > + if (!armv7_bo

Re: [U-Boot] ad-hoc config error

2016-09-23 Thread york sun
Tom, Following this thread, I have different macros to resolve. Please take a look at this patch http://patchwork.ozlabs.org/patch/660787/. It adds CONFIG_SYS_DCSR_RCPM_ADDR and CONFIG_SYS_GIC_ADDR. This kind of macros are used across platforms to define the base addresses. All existing macros

Re: [U-Boot] [PATCH] net: smsc95xx: fix DM MAC address reading

2016-09-23 Thread Joe Hershberger
On Fri, Sep 23, 2016 at 11:31 AM, Stephen Warren wrote: > On 09/15/2016 01:20 PM, Joe Hershberger wrote: >> >> On Thu, Sep 15, 2016 at 1:53 PM, Stephen Warren >> wrote: >>> >>> From: Stephen Warren >>> >>> eth-uclass.c expects DM-capable Ethernet adapters to implement ops-> >>> read_rom_hwaddr()

[U-Boot] [PATCH] net: fec_mxc: Convert into driver model

2016-09-23 Thread Jagan Teki
This patch add driver model support for fec_mxc driver. Cc: Simon Glass Cc: Joe Hershberger Cc: Peng Fan Cc: Stefano Babic Cc: Michael Trimarchi Signed-off-by: Jagan Teki --- Note: Tested both dm and non-dm varients. drivers/net/fec_mxc.c | 268 +

Re: [U-Boot] ad-hoc config error

2016-09-23 Thread Tom Rini
On Fri, Sep 23, 2016 at 04:42:24PM +, york sun wrote: > Tom, > > Following this thread, I have different macros to resolve. Please take a > look at this patch http://patchwork.ozlabs.org/patch/660787/. > > It adds CONFIG_SYS_DCSR_RCPM_ADDR and CONFIG_SYS_GIC_ADDR. This kind of > macros are

Re: [U-Boot] [U-Boot, 1/2] Makefile: use if_change_dep for u-boot.cfg

2016-09-23 Thread Tom Rini
On Mon, Sep 19, 2016 at 12:20:25PM -0600, Stephen Warren wrote: > From: Stephen Warren > > cmd_cpp_cfg generates a dependency output, but because it's invoked using > if_changed rather than if_changed_dep, that dependency file is ignored. > This results in Kbuild not knowing about which files u-

Re: [U-Boot] image-fit: Fix fit_get_node_from_config semantics

2016-09-23 Thread Tom Rini
On Tue, Sep 20, 2016 at 06:17:12PM +0100, Paul Burton wrote: > Commit bac17b78dace ("image-fit: switch ENOLINK to ENOENT") changed > fit_get_node_from_config to return -ENOENT when a property doesn't > exist, but didn't change any of its callers which check return values. > Notably it didn't chang

Re: [U-Boot] test/py/tests/test_vboot.py: Add check that we boot the image

2016-09-23 Thread Tom Rini
On Sun, Sep 18, 2016 at 09:46:58AM -0400, Tom Rini wrote: > Make sure that when we're telling bootm to boot an image, and we expect > the image to boot we get the output from sandbox that we attempted to > run Linux and that U-Boot completed its job. > > Cc: Simon Glass > Cc: Stephen Warren > S

Re: [U-Boot] [U-Boot, 2/2] Makefile: rm u-boot.cfg dependencies are missing

2016-09-23 Thread Tom Rini
On Mon, Sep 19, 2016 at 12:20:26PM -0600, Stephen Warren wrote: > From: Stephen Warren > > Prior to the previous patch, a freshly created .u-boot.cfg.cmd may not > correctly represent all dependencies for u-boot.cfg. The previous change > only solved this issue for fresh builds; when performing

Re: [U-Boot] [PATCH 06/13] buildman: Tidy up the 'cloning' message

2016-09-23 Thread Tom Rini
On Thu, Sep 22, 2016 at 10:14:01PM -0600, Simon Glass wrote: > Hi Tom, > > On 19 September 2016 at 13:14, Tom Rini wrote: > > On Sun, Sep 18, 2016 at 04:48:31PM -0600, Simon Glass wrote: > > > >> On a machine with a lot of CPUs this prints a lot of useless lines of the > >> form: > >> > >>Clo

Re: [U-Boot] [PATCH 4/5] imx: mx6ullevk: support plugin

2016-09-23 Thread Tom Rini
On Fri, Sep 23, 2016 at 04:35:59PM +0800, Peng Fan wrote: > On Thu, Sep 22, 2016 at 11:48:16AM -0400, Tom Rini wrote: > >On Mon, Sep 19, 2016 at 11:55:43AM +0800, van.free...@gmail.com wrote: > > > >> From: Peng Fan > >> > >> Add plugin code for mx6ullevk. > >> Define CONFIG_USE_PLUGIN in include

Re: [U-Boot] [PATCH] fs-test.sh: Update expected results

2016-09-23 Thread Tom Rini
On Fri, Sep 23, 2016 at 09:31:32AM -0400, Tom Rini wrote: > Thanks to Stefan Brüns we have more tests and a few more passes too, > update the expected output now. > > Cc: Stefan Brüns > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital sign

Re: [U-Boot] [U-Boot,v3,2/4] ext4: use kernel names for byte swaps

2016-09-23 Thread Tom Rini
On Mon, Aug 29, 2016 at 10:46:44AM +0200, Michael Walle wrote: > Instead of __{be,le}{16,32}_to_cpu use {be,le}{16,32}_to_cpu. > > Signed-off-by: Michael Walle Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature _

Re: [U-Boot] [U-Boot, v3, 1/4] ext4: change structure fields to __le/__be types

2016-09-23 Thread Tom Rini
On Mon, Aug 29, 2016 at 10:46:43AM +0200, Michael Walle wrote: > Change all the types of ext2/4 fields to little endian types and all the > JBD fields to big endian types. Now we can use sparse (make C=1) to check > for statements where we need byteswaps. > > Signed-off-by: Michael Walle Applie

Re: [U-Boot] [U-Boot, v4, 3/4] ext4: fix endianess problems in ext4 write support

2016-09-23 Thread Tom Rini
On Thu, Sep 01, 2016 at 11:21:40AM +0200, Michael Walle wrote: > All fields were accessed directly instead of using the proper byte swap > functions. Thus, ext4 write support was only usable on little-endian > architectures. Fix this. > > Signed-off-by: Michael Walle Applied to u-boot/master, t

Re: [U-Boot] [U-Boot, 1/4] fs/fat: Remove two statements without effect

2016-09-23 Thread Tom Rini
On Sun, Sep 11, 2016 at 10:51:39PM +0200, Stefan Brüns wrote: > fatlength is a local variable which is no more used after the assignment. > s_name is not used in the function, save the strncpy. > > Signed-off-by: Stefan Brüns > Acked-by: Lukasz Majewski > Acked-by: Stephen Warren > Reviewed-by

Re: [U-Boot] [U-Boot, v3, 4/4] ext4: fix wrong usage of le32_to_cpu()

2016-09-23 Thread Tom Rini
On Mon, Aug 29, 2016 at 10:46:46AM +0200, Michael Walle wrote: > le32_to_cpu() must only convert the revision_level and not the boolean > result. > > Signed-off-by: Michael Walle Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] [U-Boot, 2/4] fs/fat: Do not write unmodified fat entries to disk

2016-09-23 Thread Tom Rini
On Sun, Sep 11, 2016 at 10:51:40PM +0200, Stefan Brüns wrote: > The code caches 6 sectors of the FAT. On FAT traversal, the old contents > needs to be flushed to disk, but only if any FAT entries had been modified. > Explicitly flag the buffer on modification. > > Currently, creating a new file t

Re: [U-Boot] [U-Boot, 3/4] fs/fat: Correct description of determine_fatent function

2016-09-23 Thread Tom Rini
On Sun, Sep 11, 2016 at 10:51:41PM +0200, Stefan Brüns wrote: > Current description does not match the function behaviour. > > Signed-off-by: Stefan Brüns > Acked-by: Lukasz Majewski Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature _

Re: [U-Boot] [U-Boot, v2, 2/5] test/fs: remove use of undefined WRITE_FILE variable

2016-09-23 Thread Tom Rini
On Wed, Sep 14, 2016 at 01:01:28AM +0200, Stefan Brüns wrote: > The write file is created from $SMALL_FILE by appending ".w" on all > other occurences in the code. > > Signed-off-by: Stefan Brüns Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature _

Re: [U-Boot] [U-Boot, 4/4] cmd/fat: Do not crash on write when is not specified

2016-09-23 Thread Tom Rini
On Sun, Sep 11, 2016 at 10:51:42PM +0200, Stefan Brüns wrote: > argc is checked, but is off by one. In case is not specified, > create an empty file, which is identical to the ext4write behaviour. > > Signed-off-by: Stefan Brüns > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --

Re: [U-Boot] [U-Boot, v2, 3/5] test/fs: strip noise from filesystem code prior to checking results

2016-09-23 Thread Tom Rini
On Wed, Sep 14, 2016 at 01:01:29AM +0200, Stefan Brüns wrote: > ext4 and fat code emit some diagnostic messages during command execution. > These additional lines force a match window size which strictly is not > necessary. > > Signed-off-by: Stefan Brüns Applied to u-boot/master, thanks! --

Re: [U-Boot] [U-Boot, v2, 1/5] test/fs: Restructure file path specification to allow some flexibility

2016-09-23 Thread Tom Rini
On Wed, Sep 14, 2016 at 01:01:27AM +0200, Stefan Brüns wrote: > Instead of providing the full path, specify directory and filename > separately. This allows to specify intermediate directories, required > for some additional tests. > > Signed-off-by: Stefan Brüns Applied to u-boot/master, thank

Re: [U-Boot] [U-Boot, v2, 4/5] test/fs: Check ext4 behaviour if dirent is first entry in directory block

2016-09-23 Thread Tom Rini
On Wed, Sep 14, 2016 at 01:01:30AM +0200, Stefan Brüns wrote: > This is a regression test for a crash happening if the first dirent > in the block matches. Code tried to access a predecessor entry which > does not exist. > The crash happened for any block, but "." is always the first entry in > th

Re: [U-Boot] [U-Boot, 2/7] ext4: determine group descriptor size for 64bit feature

2016-09-23 Thread Tom Rini
On Sat, Sep 17, 2016 at 02:10:07AM +0200, Stefan Brüns wrote: > If EXT4_FEATURE_INCOMPAT_64BIT is set, the descriptor can be read from > the superblocks, otherwise it defaults to 32. > > Signed-off-by: Stefan Brüns Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital

Re: [U-Boot] [U-Boot, v2, 5/5] test/fs: Check writes using "." (same dir) relative path

2016-09-23 Thread Tom Rini
On Wed, Sep 14, 2016 at 01:01:31AM +0200, Stefan Brüns wrote: > / and /./ should reference the same file. > > Signed-off-by: Stefan Brüns Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list

Re: [U-Boot] [U-Boot, 1/7] ext4: Update ext2/3/4 superblock, group descriptor and inode structures

2016-09-23 Thread Tom Rini
On Sat, Sep 17, 2016 at 02:10:06AM +0200, Stefan Brüns wrote: > Most importantly, the superblock provides the used group descriptor size, > which is required for the EXT4_FEATURE_INCOMPAT_64BIT. > > Signed-off-by: Stefan Brüns Applied to u-boot/master, thanks! -- Tom signature.asc Descripti

Re: [U-Boot] [U-Boot, 5/7] ext4: Use helper function to access group descriptor and its fields

2016-09-23 Thread Tom Rini
On Sat, Sep 17, 2016 at 02:10:10AM +0200, Stefan Brüns wrote: > The descriptor size is variable, thus array indices are not generically > applicable. The larger group descriptors also contain e.g. high parts > of block numbers, which have to be read and written. > > Signed-off-by: Stefan Brüns

Re: [U-Boot] [U-Boot, 4/7] ext4: Use correct descriptor size when reading the block group descriptor

2016-09-23 Thread Tom Rini
On Sat, Sep 17, 2016 at 02:10:09AM +0200, Stefan Brüns wrote: > The correct descriptor size must be used when calculating offsets, and > also to read the correct amount of data. > > Signed-off-by: Stefan Brüns Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signa

Re: [U-Boot] [U-Boot, v2, 3/7] ext4: Add helper functions for block group descriptor field access

2016-09-23 Thread Tom Rini
On Tue, Sep 20, 2016 at 01:12:42AM +0200, Stefan Brüns wrote: > The helper functions encapsulate access of the block group descriptors, > independent of group descriptor size. The helpers also deal with the > endianess of the fields, and with split fields like free_blocks/ > free_blocks_high. > >

Re: [U-Boot] [U-Boot, 7/7] ext4: Revert rejection of 64bit enabled ext4 fs

2016-09-23 Thread Tom Rini
On Sat, Sep 17, 2016 at 02:10:12AM +0200, Stefan Brüns wrote: > Enable mounting of ext4 fs with 64bit feature, as it is supported now. > These had been disabled in 6f94ab6656ceffb3f2a972c8de4c554502b6f2b7. > > Signed-off-by: Stefan Brüns Applied to u-boot/master, thanks! -- Tom signature.as

Re: [U-Boot] [U-Boot, v2, 6/7] ext4: Respect group descriptor size when adjusting free counts

2016-09-23 Thread Tom Rini
On Tue, Sep 20, 2016 at 01:13:01AM +0200, Stefan Brüns wrote: > Also adjust high 16/32 bits when free inode/block counts are modified. > > Signed-off-by: Stefan Brüns Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] [U-Boot, v5, 01/16] ext4: fix possible crash on directory traversal, ignore deleted entries

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:41AM +0200, Stefan Brüns wrote: > The following command triggers a segfault in search_dir: > ./sandbox/u-boot -c 'host bind 0 ./sandbox/test/fs/3GB.ext4.img ; > ext4write host 0 0 /./foo 0x10' > > The following command triggers a segfault in check_filename: > ./s

Re: [U-Boot] [U-Boot, v5, 02/16] ext4: propagate error if creation of directory entry fails

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:42AM +0200, Stefan Brüns wrote: > In case the dir entry creation failed, ext4fs_write would later overwrite > a random inode, as inodeno was never initialized. > > Signed-off-by: Stefan Brüns > Reviewed-by: Lukasz Majewski Applied to u-boot/master, thanks! -- To

Re: [U-Boot] [U-Boot, v5, 03/16] ext4: Do not crash when trying to grow a directory using extents

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:43AM +0200, Stefan Brüns wrote: > The following command crashes u-boot: > ./sandbox/u-boot -c 'i=0; host bind 0 ./sandbox/test/fs/3GB.ext4.img ; > while test $i -lt 200 ; do echo $i; setexpr i $i + 1; > ext4write host 0 0 /foobar${i} 0; done' > > Previously, the

Re: [U-Boot] [U-Boot, v5, 04/16] ext4: Scan all directory blocks for space when inserting a new entry

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:44AM +0200, Stefan Brüns wrote: > Previously, only the last directory block was scanned for available space. > Instead, scan all blocks back to front, and if no sufficient space is > found, eventually append a new block. > Blocks are only appended if the directory doe

Re: [U-Boot] [U-Boot, v5, 06/16] ext4: Scan all directory blocks when looking up an entry

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:46AM +0200, Stefan Brüns wrote: > Scanning only the direct blocks of the directory file may falsely report > an existing file as nonexisting, and worse can also lead to creation > of a duplicate entry on file creation. > > Signed-off-by: Stefan Brüns > Reviewed-by:

Re: [U-Boot] [U-Boot, v5, 05/16] ext4: Avoid corruption of directories with hash tree indexes

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:45AM +0200, Stefan Brüns wrote: > While directories can be read using the old linear scan method, adding a > new file would require updating the index tree (alternatively, the whole > tree could be removed). > > Signed-off-by: Stefan Brüns > Reviewed-by: Lukasz Maje

Re: [U-Boot] [U-Boot, v5, 07/16] ext4: Only update number of of unused inodes if GDT_CSUM feature is set

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:47AM +0200, Stefan Brüns wrote: > e2fsck warns about "Group descriptor 0 marked uninitialized without > feature set." > The bg_itable_unused field is only defined if FEATURE_RO_COMPAT_GDT_CSUM > is set, and should be set (kept) zero otherwise. > > Signed-off-by: Stef

Re: [U-Boot] [U-Boot, v5, 08/16] ext4: Do not clear zalloc'ed buffers a second time

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:48AM +0200, Stefan Brüns wrote: > zero_buffer is never written, thus clearing it is pointless. > journal_buffer is completely initialized by ext4fs_devread (or in case > of failure, not used). > > Signed-off-by: Stefan Brüns > Reviewed-by: Lukasz Majewski Applied

Re: [U-Boot] [U-Boot, v5, 09/16] ext4: After completely filled group, scan next group from the beginning

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:49AM +0200, Stefan Brüns wrote: > The last free block of a block group may be in its middle. After it has > been allocated, the next block group should be scanned from its beginning. > > The following command triggers the bad behaviour (on a blocksize 1024 fs): > >

Re: [U-Boot] [U-Boot, v5, 10/16] ext4: Avoid out-of-bounds access of block bitmap

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:50AM +0200, Stefan Brüns wrote: > If the blocksize is 1024, count is initialized with 1. Incrementing count > by 8 will never match (count == fs->blksz * 8), and ptr may be > incremented beyond the buffer end if the bitmap is filled. Add the > startblock offset after

Re: [U-Boot] [U-Boot, v5, 12/16] ext4: Use correct value for inode size even on revision 0 filesystems

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:52AM +0200, Stefan Brüns wrote: > fs->inodesz is already correctly (i.e. dependent on fs revision) > initialized in ext4fs_mount. > > Signed-off-by: Stefan Brüns > Reviewed-by: Lukasz Majewski Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [U-Boot] [U-Boot, v5, 13/16] ext4: initialize full inode for inodes bigger than 128 bytes

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:53AM +0200, Stefan Brüns wrote: > Make sure the the extra_isize field (offset 128) is initialized to 0, to > mark any extra data as invalid. > > Signed-off-by: Stefan Brüns > Reviewed-by: Lukasz Majewski Applied to u-boot/master, thanks! -- Tom signature.asc D

Re: [U-Boot] [U-Boot, v5, 11/16] ext4: Fix memory leak in case of failure

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:51AM +0200, Stefan Brüns wrote: > temp_ptr should always be freed, even if the function is left via > goto fail. > > Signed-off-by: Stefan Brüns > Reviewed-by: Lukasz Majewski Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signatur

Re: [U-Boot] [U-Boot, v5, 14/16] ext4: remove duplicated block release code for extents

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:54AM +0200, Stefan Brüns wrote: > The data blocks are identical for files using traditional direct/indirect > block allocation scheme and extent trees, thus this code part can be > common. Only the code to deallocate the indirect blocks to record the > used blocks has

Re: [U-Boot] [U-Boot, v5, 15/16] ext4: Correct block number handling, empty block vs. error code

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:55AM +0200, Stefan Brüns wrote: > read_allocated block may return block number 0, which is just an indicator > a chunk of the file is not backed by a block, i.e. it is sparse. > > During file deletions, just continue with the next logical block, for other > operation

Re: [U-Boot] [U-Boot, v5, 16/16] ext4: Fix memory leak of journal buffer if block is updated multiple times

2016-09-23 Thread Tom Rini
On Tue, Sep 06, 2016 at 04:36:56AM +0200, Stefan Brüns wrote: > If the same block is updated multiple times in a row during a single > file system operation, gd_index is decremented to use the same journal > entry again. Avoid loosing the already allocated buffer. > > Signed-off-by: Stefan Brüns

Re: [U-Boot] [PATCH 01/28] Remove some merge markers

2016-09-23 Thread Tom Rini
On Mon, Sep 19, 2016 at 04:32:45PM -0600, Simon Glass wrote: > These two files have patch merge markers in them, within comments or > strings. Remove then, so that a search for merge markers does not show up > matches in these files. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- To

  1   2   >