Re: [U-Boot] [PATCH] dm: timer: Avoid using timer before it is ready

Hi Simon, On Sun, Nov 29, 2015 at 1:16 PM, Simon Glass wrote: > At present bootstage will try to read the timer very early after relocation. > When driver model it used to provide the timer, we cannot read it until When driver model is > driver model is ready. Correct this by adding a separate

Re: [U-Boot] [PATCH 2/4] fsl_*_serdes.c: Modify memset call in serdes_init

On Sat, Nov 28, 2015 at 9:04 PM, Tom Rini wrote: > GCC 5.x does not like sizeof(array_variable) and errors out. Change these > calls to be instead sizeof(u8) (as that's what serdes_prtcl_map is) * > SERDES_PRCTL_COUNT (the number of array elements). > > Cc: York Sun > Signed-off-by: Tom Rini >

Re: [U-Boot] [PATCH 1/4] eth-raw-os.c: Add cast to bind(2) call

On Sat, Nov 28, 2015 at 9:04 PM, Tom Rini wrote: > With more recent gcc versions we otherwise get an error like: > note: expected 'const struct sockaddr *' but argument is of type > 'struct sockaddr_in *' > > and the common solution here is to cast, rather than re-work the code. > > Cc: Joe Hershb

Re: [U-Boot] [PATCH 3/4] qbman_portal.c: Update BUG_ON() call in qbman_swp_mc_submit

On Sat, Nov 28, 2015 at 9:04 PM, Tom Rini wrote: > With gcc-5.x we get a warning about the ambiguity of BUG_ON(!a != b) and > becomes BUG_ON((!a) != b). In this case reading of the function leads to > us wanting to rewrite this as BUG_ON(a != b). > > Cc: Prabhakar Kushwaha > Cc: Geoff Thorpe >

Re: [U-Boot] [PATCH 4/4] arch/arm/cpu/arm920t/ep93xx/led.c: Mark inline functions as static inline

On Sat, Nov 28, 2015 at 9:04 PM, Tom Rini wrote: > With gcc-5.x we get warning about inline non-static functions referring to > static elements. > > Signed-off-by: Tom Rini > --- > arch/arm/cpu/arm920t/ep93xx/led.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch

[U-Boot] [PATCH 1/2] altera_qspi: add lock unlock ops

Add lock() and unlock() mtd ops to altera_qspi. Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 82 +++ 1 file changed, 82 insertions(+) diff --git a/drivers/mtd/altera_qspi.c b/drivers/mtd/altera_qspi.c index 50c6e0e..89f04a4 100644 --- a/

[U-Boot] [PATCH 2/2] altera_qspi: fix erase and write error code

Fix erase and write error code, which should be "protected". Signed-off-by: Thomas Chou --- drivers/mtd/altera_qspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/altera_qspi.c b/drivers/mtd/altera_qspi.c index 89f04a4..cf45e73 100644 --- a/drivers/mtd/alte

Re: [U-Boot] [PATCH 02/19] dm: timer: uclass: add timer init to add timer device

On Saturday 28 November 2015 05:16 PM, Bin Meng wrote: > Yes, but your patch 01 will break x86. I can prepare a patch for x86 > if you like Can you send the patch so that I can include it on my next series. Regards Mugunthan V N ___ U-Boot mailing list

Re: [U-Boot] [PATCH 04/19] drivers: timer: omap_timer: add timer driver for omap devices based on dm

On Saturday 28 November 2015 05:22 PM, Bin Meng wrote: > Hi Mugunthan, > > On Fri, Nov 27, 2015 at 4:31 PM, Mugunthan V N wrote: >> Adding a timer driver for omap devices based on driver model >> and device tree. >> >> Signed-off-by: Mugunthan V N >> --- >> drivers/timer/Kconfig | 6 +++

Re: [U-Boot] [PATCH 2/2] altera_qspi: fix erase and write error code

On Sunday, November 29, 2015 at 12:38:23 PM, Thomas Chou wrote: > Fix erase and write error code, which should be "protected". Can you elaborate on why do you think this change is correct please ? That reasoning should be part of the patch description. > Signed-off-by: Thomas Chou > --- > drive

Re: [U-Boot] [PATCH 1/2] altera_qspi: add lock unlock ops

On Sunday, November 29, 2015 at 12:38:22 PM, Thomas Chou wrote: > Add lock() and unlock() mtd ops to altera_qspi. > > Signed-off-by: Thomas Chou > --- > drivers/mtd/altera_qspi.c | 82 > +++ 1 file changed, 82 > insertions(+) > > diff --git a/drivers/m

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

On Friday, November 27, 2015 at 08:22:03 AM, Chin Liang See wrote: > Enable SDMMC calibration to determine the best setting for > drvsel and smplsel. Calibration will be triggered if the > drvsel and smplsel node are not available in DTS. > > Signed-off-by: Chin Liang See > Cc: Dinh Nguyen > Cc:

[U-Boot] [PATCH 1/1] Change e-mail address of Kamil Lulko

Signed-off-by: Kamil Lulko --- arch/arm/cpu/armv7m/config.mk | 2 +- arch/arm/cpu/armv7m/cpu.c | 2 +- arch/arm/cpu/armv7m/start.S | 2 +- arch/arm/cpu/armv7m/stm32f1/Makefile | 2 +- arch/arm/cpu/armv7m/stm32f1/clock.c | 2 +- arch/arm/cpu/arm

[U-Boot] [PATCH 1/1] stm32: Convert serial driver to DM

Signed-off-by: Kamil Lulko --- arch/arm/Kconfig | 2 + arch/arm/include/asm/arch-stm32f4/stm32.h | 10 +- board/st/stm32f429-discovery/stm32f429-discovery.c | 13 +- doc/driver-model/serial-howto.txt | 1 - drivers/serial/serial_st

[U-Boot] [PATCH] imx: mx6: add missing return value

cc: Peng Fan Signed-off-by: Jeroen Hofstee --- not tested ;) arch/arm/cpu/armv7/mx6/clock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c index 67e0f32..4f6fe86 100644 --- a/arch/arm/cpu/armv7/mx6/clock.c +++ b/arch/arm/cpu

[U-Boot] [PATCH] Re-enable setexpr on Raspberry Pi

This patch re-enables the setexpr command, I don't really understand why it got excluded in the first place. setexpr can be used e.g. to implement failed-boot-counters and failovers to rescue firmware. Signed-off-by: Marco Schuster --- configs/rpi_2_defconfig | 1 - configs/rpi_defconfig | 1

[U-Boot] [PATCH 1/2] Pass through start.elf bootargs on Raspberry Pi

On Raspberry Pi, the primary bootloader start.elf uses the options in config.txt, as well as options hidden in the firmware itself, to tell the Linux kernel e.g. framebuffer sizes, memory regions, MAC addresses and more. Normally, u-boot would not be able to pass through these options to the Linux

[U-Boot] [PATCH 2/2] Remove fdtfile list from Raspberry Pi

As pass-through of the processed FDT is working now, there is no need for the RPi u-boot any more to load fdt files. This patch removes the fdtfile list and the setter for the env variable "fdtfile". This also removes the naming inconsistencies between the fdtfile names in u-boot and the fdtfile n

[U-Boot] [PATCH v2 00/26] dm: Conversion of code to the new driver model PCI API

PCI devices should be accessed just by their device pointer (which is struct udevice *). At present the hose (PCI controller) is often passed along with a pci_dev_t (bus/device/function) value. With driver model this is not necessary but most PCI code has not been converted over to use this new AP

[U-Boot] [PATCH v2 03/26] dm: pci: Add a dm_ prefix to pci_bus_find_bdf()

Most driver model PCI functions have a dm_ prefix. At some point, when the old code is converted to driver model and the old functions are removed, we will drop that prefix. For consistency, we should use the dm_ prefix for all driver model functions. Update pci_bus_find_bdf() accordingly. Signed

[U-Boot] [PATCH v2 02/26] dm: pci: Add a dm_ prefix to pci_get_bdf()

Most driver model PCI functions have a dm_ prefix. At some point, when the old code is converted to driver model and the old functions are removed, we will drop that prefix. For consistency, we should use the dm_ prefix for all driver model functions. Update pci_get_bdf() accordingly. Signed-off-

[U-Boot] [PATCH v2 01/26] dm: pci: Mark legacy files as such

We don't want people changing the legacy PCI files while migration is in progress. Update the file headers to indicate that. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None drivers/pci/pci.c | 5 - drivers/pci/pci_auto_old.c | 9 ++--- 2 files changed

[U-Boot] [PATCH v2 05/26] dm: pci: Add a driver-model version of pci_find_device()

Add a function which scans the driver model device information rather than scanning the PCI bus again. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None drivers/pci/pci-uclass.c | 39 +++ include/pci.h| 12 2

[U-Boot] [PATCH v2 07/26] dm: pci: Add a driver-model version of pci_find_class()

Add a function which scans the driver model device information rather than scanning the PCI bus again. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None drivers/pci/pci-uclass.c | 20 include/pci.h| 10 ++ 2 files changed, 30 ins

[U-Boot] [PATCH v2 09/26] dm: serial: Convert ns16550 driver to use driver model PCI API

Use the driver model version of the function to find the BAR. This updates the fdtdec function, of which ns16550 is the only user. The fdtdec_get_pci_bdf() function is dropped for several reasons: - with driver model we should use 'struct udevice *' rather than passing the device tree offset ex

[U-Boot] [PATCH v2 06/26] dm: pci: scsi: Use driver-model PCI API

Adjust the SCSI command to use driver model for its PCI interface. Signed-off-by: Simon Glass --- Changes in v2: - Use dm_pci_get_bdf() common/cmd_scsi.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/common/cmd_scsi.c b/common/cmd_scsi.c index 31c4319..8695

[U-Boot] [PATCH v2 10/26] dm: x86: ivybridge: Convert graphics init to use DM PCI API

Use the driver-model PCI functions here where possible. For now we have to search for the device with pci_bus_find_bdf() but at some point we can put this in a proper driver and avoid this. Signed-off-by: Simon Glass --- Changes in v2: - Use pci_bus_find_bdf() arch/x86/cpu/ivybridge/bd82x6x.c

[U-Boot] [PATCH v2 04/26] dm: pci: Use driver model PCI API in auto-config

At present we are using legacy functions even in the auto-configuration code used by driver model. Add a new pci_auto.c version which uses the correct API. Create a new pci_internal.h header to hold functions that are used within the PCI subsystem, but are not exported to other drivers. Signed-of

[U-Boot] [PATCH v2 11/26] dm: Convert bios_interrupts to use DM PCI API

Adjust this code to use driver model for devices where possible. Since existing users have not been converted the old code must remain. Signed-off-by: Simon Glass --- Changes in v2: - Drop non-DM PCI code - Use dm_pci_get_bdf() - Use pci_bus_find_bdf() arch/x86/lib/bios_interrupts.c | 36 +

[U-Boot] [PATCH v2 13/26] dm: x86: pci: Adjust bios_run_on_x86() to use the DM PCI API

This function should take a struct udevice rather than pci_dev_t. Update it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/lib/bios.c | 3 ++- drivers/pci/pci_rom.c | 4 ++-- include/bios_emul.h | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-)

[U-Boot] [PATCH v2 14/26] dm: pci: Drop the old version of pci_find_device/s()

Move these functions into the compatibility file so that they are not available by default. Signed-off-by: Simon Glass --- Changes in v2: - Move the functions into pci_common.c so they can be used by old code - Reword the commit message for clarity drivers/pci/pci_common.c | 2 ++ 1 file chang

[U-Boot] [PATCH v2 15/26] dm: pci: Drop the old version of pci_find_class()

Move this function into the compatibility file so that it is not available by default. Signed-off-by: Simon Glass --- Changes in v2: - Move the functions into pci_common.c so they can be used by old code drivers/pci/pci_common.c | 84 1 file cha

[U-Boot] [PATCH v2 22/26] dm: usb: Convert echi-pci to use new DM PCI API

Convert this driver to use the new driver model PCI API. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: - Use u32 instead of uint32_t - Use uintptr_t to cast the hcor address drivers/usb/host/ehci-pci.c | 51 ++--- 1 file changed, 3

[U-Boot] [PATCH v2 26/26] dm: net: usb: Convert mcs7830 driver to support driver model

Adjust this driver to support driver model for Ethernet. Signed-off-by: Simon Glass Acked-by: Joe Hershberger --- Changes in v2: None drivers/usb/eth/mcs7830.c | 105 ++ 1 file changed, 105 insertions(+) diff --git a/drivers/usb/eth/mcs7830.c b/dri

[U-Boot] [PATCH v2 16/26] dm: tegra: net: Convert tegra boards to driver model for Ethernet

Adjust all Tegra boards to use driver model for Ethernet, now that the required drivers are converted. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/arm/mach-tegra/Kconfig | 1 + board/compulab/trimslice/trimslice.c | 8 board/nvidia/cardhu/

[U-Boot] [PATCH v2 12/26] dm: pci: video: Convert video and pci_rom to use DM PCI API

Adjust these files to use the driver-model PCI API instead of the legacy functions. Signed-off-by: Simon Glass --- Changes in v2: - Rename pci_run_vga_bios() to dm_pci_run_vga_bios() - Require driver model with pci_rom.c - Use dev_get_parent_platdata() instead of re-reading values from the devic

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

Hi Marek, On 28 November 2015 at 18:05, Marek Vasut wrote: > On Sunday, November 29, 2015 at 02:59:37 AM, Simon Glass wrote: >> Hi Marek, >> >> On 27 November 2015 at 11:41, Marek Vasut wrote: >> > On Friday, November 27, 2015 at 07:36:27 PM, Simon Glass wrote: >> >> Hi, >> >> >> >> On 26 Novemb

[U-Boot] [PATCH v2 19/26] dm: net: Convert rtl8169 to use DM PCI API

Update this driver to use the proper driver-model PCI API functions. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: - Drop unnecessary and confusing '#ifdef CONFIG_DM_ETH' in rtl8169_eth_probe() drivers/net/rtl8169.c | 85 +++---

[U-Boot] [PATCH v2 08/26] dm: pci: Add a function to read a PCI BAR

Add a driver-model function for reading the PCI BAR from a device. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None drivers/pci/pci-uclass.c | 13 + include/pci.h| 9 + 2 files changed, 22 insertions(+) diff --git a/drivers/pci/pci-ucl

[U-Boot] [PATCH v2 25/26] dm: net: usb: Refactor mcs7830 driver ready for DM conversion

Remove stamp data and create common functions for the main Ethernet operations. This will make it easier to convert this driver to support driver model. Signed-off-by: Simon Glass Acked-by: Joe Hershberger --- Changes in v2: None drivers/usb/eth/mcs7830.c | 265 +--

[U-Boot] [PATCH v2 23/26] dm: Convert PCI MMC over to use DM PCI API

At present pci_mmc_init() does not correctly use the PCI function since the list it passes is not terminated. The array size passed to pci_mmc_init() is actually not used correctly. Fix this and adjust the pci_mmc_init() to scan all available MMC devices. Adjust this code to use the new driver mod

[U-Boot] [PATCH v2 17/26] dm: test: Convert PCI tests to use the DM PCI API

Update these tests to use driver model API functions. Signed-off-by: Simon Glass --- Changes in v2: - Use pci_bus_find_bdf() test/dm/pci.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/test/dm/pci.c b/test/dm/pci.c index 3ab4ba8..a5b1290 100644 --- a/test/

[U-Boot] [PATCH v2 18/26] dm: pci: Add driver model API functions for address mapping

At present the PCI address map functions use the old API. Add new functions for this so that drivers can be converted. Signed-off-by: Simon Glass --- Changes in v2: - Add missing code in dm_pci_phys_to_bus() - Rename _dm_pci_hose_bus_to_phys() to _dm_pci_bus_to_phys() drivers/pci/pci-uclass.c

[U-Boot] [PATCH v2 21/26] dm: ahci: Convert to use new DM PCI API

Convert this driver to use the new driver model PCI API. Signed-off-by: Simon Glass --- Changes in v2: - Fix use of 'pdev' instead of 'dev' - Get the vendor from the PCI parent platdata - Use pci_bus_find_bdf() drivers/block/ahci.c | 70 ++-- inc

[U-Boot] [PATCH v2 20/26] dm: pci: Switch to DM API for PCI address mapping

We should use the new address mapping functions unless we are in compatibility mode. Disable the old functions by default. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None drivers/pci/pci_common.c | 2 +- include/pci.h| 2 +- 2 files changed, 2 insertions(+

[U-Boot] [PATCH v2 24/26] pci: Tidy up comments in pci_bind_bus_devices()

The current comments are confusing. We don't actually bind a generic device when the device tree has no information. We try to scan available PCI drivers. Update the comments to reflect this. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None drivers/pci/pci-uclass.c | 4

Re: [U-Boot] [PATCH v2 22/26] dm: usb: Convert echi-pci to use new DM PCI API

On Sunday, November 29, 2015 at 09:18:07 PM, Simon Glass wrote: > Convert this driver to use the new driver model PCI API. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng ad subject -- it's EHCI, not ECHI . > --- > > Changes in v2: > - Use u32 instead of uint32_t > - Use uintptr_t to c

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

On Sunday, November 29, 2015 at 09:19:14 PM, Simon Glass wrote: > Hi Marek, > > On 28 November 2015 at 18:05, Marek Vasut wrote: > > On Sunday, November 29, 2015 at 02:59:37 AM, Simon Glass wrote: > >> Hi Marek, > >> > >> On 27 November 2015 at 11:41, Marek Vasut wrote: > >> > On Friday, Novemb

[U-Boot] Please pull u-boot-marvell master

Hi Tom, please pull the queued changes below from Marvell tree. Additional work from Stefan will be sent later on. The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757: Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03 -0500) are available in t

Re: [U-Boot] [PATCH] imx: mx6: add missing return value

Hi Jeroen, On Sun, Nov 29, 2015 at 06:30:34PM +0100, Jeroen Hofstee wrote: >cc: Peng Fan >Signed-off-by: Jeroen Hofstee >--- >not tested ;) > > arch/arm/cpu/armv7/mx6/clock.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c >

Re: [U-Boot] [PATCH 5/5] move the erratum_a008336_a008514 from general ddr file to soc file

Hi Sinan Akman, Thanks for your review, I will update my commit message in the next version. Best Regards, Yuan Yao On 27/11/2015 12:04 AM, Sinan Akman wrote: Hi Yuan On 26/11/15 02:58 AM, Yuan Yao wrote: > Both of the erratum:A008336 and A008514 are not apply to all the soc > like:LS1021A

Re: [U-Boot] [PATCH] dm: timer: Avoid using timer before it is ready

On Sunday 29 November 2015 10:46 AM, Simon Glass wrote: > At present bootstage will try to read the timer very early after relocation. > When driver model it used to provide the timer, we cannot read it until > driver model is ready. Correct this by adding a separate stage for the > post-relocation

Re: [U-Boot] [PATCH] ns16550: change reg-shift property default to zero

On Sunday 29 November 2015 11:31 AM, Thomas Chou wrote: > Change reg-shift property default to zero. When the integer property > is missing, it should be taken as zero. This is consistent to Linux > drivers/tty/serial/of_serial.c. > > The x86 and most powerpc use reg-shift of 0. Most others use re

Re: [U-Boot] [PATCH] dm: core: Add platform specific bus translation function

Hi Simon, On 27.11.2015 19:36, Simon Glass wrote: > On 27 November 2015 at 02:22, Stefan Roese wrote: >> This patch adds the additional platform_translate_address() call to >> dev_get_addr(). A weak default with a 1-to-1 translation is also >> provided. Platforms that need a special address trans

Re: [U-Boot] MX6ULEVK does not boot

Hi Fabio, On Thu, Nov 19, 2015 at 02:13:31PM -0200, Fabio Estevam wrote: >On Thu, Nov 19, 2015 at 1:58 PM, Fabio Estevam wrote: >> Hi Peng, >> >> Just noticed that mx6ulevk is not booting with latest U-boot: >> >> U-Boot SPL 2016.01-rc1-00078-g736d174 (Nov 19 2015 - 13:45:19) >> Trying to boot fro

[U-Boot] [PATCH] arm, ubifs: fix gcc5.x compiler warning

compiling U-Boot for openrd_base_defconfig with gcc 5.x shows the following warning: CC fs/ubifs/super.o In file included from fs/ubifs/ubifs.h:35:0, from fs/ubifs/super.c:37: fs/ubifs/super.c: In function 'atomic_inc': ./arch/arm/include/asm/atomic.h:55:2: warning: 'flags'