Re: [U-Boot] [PATCH 01/13] lcd: move platform specific structs to their own headers

2015-01-30 Thread Simon Glass
Hi Nikita, On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > common/lcd code is full of platform specific code and definitions, which > ideally should reside with the respective driver code. Take a step towards > that > goal by moving platform specific structs from lcd.h to their own header

Re: [U-Boot] [PATCH 03/13] lcd: atmel: move atmel specific fb_put_word to atmel_lcdfb

2015-01-30 Thread Simon Glass
On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > Reduce the amount of platform dependant code in common/lcd.c by moving Atmel > specific implementation of fb_put_word() to atmel_lcdfb.c. Since we must also > have a default implementation for everybody else, make the remainder of the > code in

Re: [U-Boot] [PATCH 04/13] lcd: mpc8xx: move mpc823 specific fb_put_byte to mpc8xx_lcd.c

2015-01-30 Thread Simon Glass
On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > Reduce the amount of platform dependant code in common/lcd.c by moving MPC823 > specific implementation of fb_put_byte() to mpc8xx_lcd.c. Since we must also > have a default implementation for everybody else, make the remainder of the > code in

Re: [U-Boot] [PATCH 07/13] lcd: logo: move generic cmap setting to lcd_logo_set_cmap()

2015-01-30 Thread Simon Glass
On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > Get rid of platform specific #ifdefs in bitmap_plot() by moving the generic > case of setting cmap into the weak lcd_logo_set_cmap(). > > Signed-off-by: Nikita Kiryanov > Cc: Bo Shen > Cc: Simon Glass > Cc: Anatolij Gustschin > --- > commo

Re: [U-Boot] [PATCH 06/13] lcd: mpc823: move mpc823 specific lcd_logo_set_cmap code to mpc8xx_lcd.c

2015-01-30 Thread Simon Glass
On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > Reduce the bitmap_plot #ifdef complexity by extracting MPC823 specific code > for > setting cmap into its own implementation of lcd_logo_set_cmap(), implemented > in > mpc8xx_lcd.c. In the MPC823 implementation, ARRAY_SIZE(bmp_logo_palette) i

Re: [U-Boot] [PATCH 09/13] lcd: remove unused includes

2015-01-30 Thread Simon Glass
On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > Remove unused includes. > > Signed-off-by: Nikita Kiryanov > Cc: Bo Shen > Cc: Simon Glass > Cc: Anatolij Gustschin > --- > common/lcd.c | 18 -- > 1 file changed, 18 deletions(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 05/13] lcd: atmel: introduce lcd_logo_set_cmap

2015-01-30 Thread Simon Glass
On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > Reduce the bitmap_plot #ifdef complexity by extracting Atmel specific code for > setting cmap into a new function lcd_logo_set_cmap(), which is implemented in > atmel_lcdfb driver and defined as part of common/lcd.c api with a weak dummy > vers

Re: [U-Boot] [PATCH 10/13] lcd: various cleanups

2015-01-30 Thread Simon Glass
On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > This cleanup mostly focuses on removing unnecessary whitespace and comments > which are superfluous and/or do not conform to the coding style. > > Signed-off-by: Nikita Kiryanov > Cc: Simon Glass > Cc: Anatolij Gustschin > --- > common/lcd.

Re: [U-Boot] [PATCH 08/13] lcd: introduce lcd_set_cmap

2015-01-30 Thread Simon Glass
On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > Reduce the lcd_display_bitmap #ifdef complexity by extracting Atmel specific > code for setting cmap for bitmap images into a new function lcd_set_cmap(). > A default version is implemented with the remainder of the code. > > Signed-off-by: Nik

Re: [U-Boot] [PATCH 11/13] lcd: rename bitmap_plot to better represent its functionality

2015-01-30 Thread Simon Glass
On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > The name "bitmap_plot" is misleading because it implies that this is a generic > function capable of dealing with any bitmap, but its implementation only works > with the logo data. > > Rename the function to better reflect this. > > Signed-off

Re: [U-Boot] [PATCH 13/13] lcd: split splash code into its own function

2015-01-30 Thread Simon Glass
Hi Nikita, On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > lcd_logo() currently performs tasks well beyond just displaying the logo. > It has code which displays splash image, it has logic which determines > when the different display features are displayed, and it is coupled with > the lcd

Re: [U-Boot] [PATCH 12/13] lcd: dt: extract simplefb support

2015-01-30 Thread Simon Glass
On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > We now have api functions that can support compiling simplefb code as its own > module. Since this code is not part of the display functionality, extract it > to its own file. > > Raspberry Pi config file is updated to compile the new file. > >

[U-Boot] [PATCH] video: sunxi: Enable cache for the framebuffer

2015-01-30 Thread Siarhei Siamashka
Because the framebuffer resides in a hidden chopped off part of DRAM, caching is not enabled for this area automatically when the MMU is configured. So it needs to be set explicitly. Additionally, the cfb console has a function to check whether the framebuffer resides in DRAM or not. And the hidde

Re: [U-Boot] [PATCH 17/17] sunxi: Hookup OTG USB controller support

2015-01-30 Thread Siarhei Siamashka
On Sun, 11 Jan 2015 20:34:55 +0100 Hans de Goede wrote: > Hookup OTG USB controller support and enable the otg controller + USB-keyb > on various tablets. > > This allows tablet owners to interact with u-boot without needing to solder > a serial console onto their tablet PCB. Thanks. Works grea

[U-Boot] [PATCH RFT] gpio: at91: Fix getting addres of private data

2015-01-30 Thread Axel Lin
Use dev_get_priv() rather than dev_get_platdata() to get correct address of private data. Signed-off-by: Axel Lin --- Hi Simon, I don't have this h/w, so please test if you think this patch is ok. Thanks, Axel drivers/gpio/at91_gpio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletion

[U-Boot] [PATCH RFT v2] gpio: at91: Fix getting address of private data

2015-01-30 Thread Axel Lin
Use dev_get_priv() rather than dev_get_platdata() to get correct address of private data. Signed-off-by: Axel Lin --- v2: Fix an obvious typo in subject line (s/addres/address). drivers/gpio/at91_gpio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/a

<    1   2