Dear Simon Glass,
> This code is never compiled into U-Boot, so move it into a separate
> file in tools/ to avoid the large #ifdef.
>
> Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lis
Dear Simon Glass,
> One we split out the FIT code from image.c we will need this function.
> Export it in the header.
>
> Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http
Dear Simon Glass,
> RSA provides a public key encryption facility which is ideal for image
> signing and verification.
>
> Images are signed using a private key by mkimage. Then at run-time, the
> images are verified using a private key.
>
> This implementation uses openssl for the host part (mk
Dear Simon Glass,
> Move this definition from aisimage.c to mkimage.h so that it is available
> more widely.
>
> Signed-off-by: Simon Glass
> ---
Acked-by: Marek Vasut
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lis
Dear Simon Glass,
> Rather than repeat the line
> #if defined(CONFIG_TIMESTAMP) || defined(CONFIG_CMD_DATE) || \
> defined(USE_HOSTCC)
>
> everywhere, put this in a header file and #define IMAGE_ENABLE_TIMESTAMP
> to either 1 or 0. Then we can use a plain if() in most code and avoid
> the
Dear Simon Glass,
> Keys required for signing images will be in a specific directory. Add a
> -k option to specify that directory.
>
> Also update the mkimage man page with this information and a clearer list
> of available commands.
>
> Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut
Be
Dear Simon Glass,
[...]
> + /* Signatures have a time stamp */
> + if (IMAGE_ENABLE_TIMESTAMP && keyname) {
> + time_t timestamp;
> +
> + printf("%s Timestamp:", p);
> + if (fit_get_timestamp(fit, noffset, ×tamp))
> + printf("un
Dear Simon Glass,
> This is the main entry point to the FIT image verification code. We will
> be using it to handle image verification with signatures, so rename the
> function.
>
> Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut
Best regards,
Marek Vasut
Dear Simon Glass,
> Much of the image code uses addresses as ulongs and pointers
> interchangeably, casting between the two forms as needed.
>
> This doesn't work with sandbox, which has a U-Boot RAM buffer which is
> separate from the host machine's memory.
>
> Adjust the cost so that translati
Dear Simon Glass,
> When signing images it is sometimes necessary to sign with different keys
> at different times, or make the signer entirely separate from the FIT
> creation to avoid needing the private keys to be publicly available in
> the system.
>
> Add a -F option so that key signing can
Dear Simon Glass,
> This function doesn't need to be exported, and with verification
> we want to use it for setting the 'value' property in any node,
> so rename it.
>
> Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut
Best regards,
Marek Vasut
___
Dear Simon Glass,
> This function has become quite long and much of the body is indented quite
> a bit. Move it into a separate function to make it easier to work with.
>
> Signed-off-by: Simon Glass
Acked-by: Marek Vasut
Best regards,
Marek Vasut
Dear Simon Glass,
> The string " error\n" appears in each error string. Move it out to a
> common place.
>
> Signed-off-by: Simon Glass
> ---
> common/image-fit.c | 16
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/common/image-fit.c b/common/image-fit.
Dear Simon Glass,
> This function will be needed by signature checking code, so export it,
> and also add docs.
>
> Signed-off-by: Simon Glass
[...]
> +/**
> + * fit_conf_get_prop_node() - Get node refered to by a configuration
> + *
> + * The conf@ nodes contain references to other nodes, usin
Dear Simon Glass,
> This function will be used to print signatures as well as hashes, so rename
> it. Also make it static since it is not used outside this file.
>
> Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut
Best regards,
Marek Vasut
___
U
Dear Simon Glass,
> The existing function is long and most of the code is indented a long
> way. Before adding yet more code, split this out into its own function.
>
> Signed-off-by: Simon Glass
> ---
> common/image-fit.c | 128
> 1 files cha
Dear Simon Glass,
[...]
> + int string_size;
> + int ret;
> +
> + /*
> + * Get the current string size, before we update the FIT and add
> + * more
> + */
> + string_size = fdt_size_dt_strings(fit);
> +
> + ret = fdt_setprop(fit, noffset, FIT_VALUE_PROP, value,
Dear Simon Glass,
> Normally, multiple public keys can be provided and U-Boot is not
> required to use all of them for verification. This is because some
> images may not be signed, or may be optionally signed.
>
> But we still need a mechanism to determine when a key must be used.
> This feature
Dear Simon Glass,
> The fit_handle_file() function is quiet long
quite ;-)
> - split out the part that
> loads and checks a FIT into its own function. We will use this
> function for storing public keys into a destination FDT file.
>
> The error handling is currently a bit repetitive - tidy it.
Dear Simon Glass,
> FIT image verification requires public keys. Add a convenient option to
> mkimage to write the public keys to an FDT blob when it uses then for
> signing an image. This allows us to use:
>
>mkimage -f test.its -K dest.dtb -k keys test.fit
>
> and have the signatures writt
Dear Simon Glass,
> When signing an image, it is useful to add some details about which tool
> or person is authorising the signing. Add a comment field which can take
> care of miscellaneous requirements.
>
> Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut
Best regards,
Marek Vasut
_
Dear Simon Glass,
> The FIT code is about half the size of the >3000-line image.c. Split this
> code into its own file.
>
> Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut
[...]
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx
Hi,
On 01/03/2013 09:28 PM, Wolfgang Denk wrote:
Hm... I'm not sure if this is the right approach, then. If mainline
Linux insists on such a 2 MB alignment, we shoud rather teach
lcd_setmem() to follow tha rule, too. That should solve the problem
as well (and probably more efficiently, especi
On 26/12/2012 02:08, Marek Vasut wrote:
> Adjust the NAND partitioning layout so that there is a separate partition
> for the ramdisk and fdt blob on the NAND.
>
> Signed-off-by: Marek Vasut
> Cc: Detlev Zundel
> Cc: Stefano Babic
> Cc: Wolfgang Denk
> ---
> include/configs/m28evk.h |2 ++
On 07/11/2012 18:37, Ashok Kumar Reddy wrote:
> Use IMX_GPO_NR macro
>
> Signed-off-by: Ashok Kumar Reddy
> ---
> board/freescale/mx35pdk/mx35pdk.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/mx35pdk/mx35pdk.c
> b/board/freescale/mx35pdk/mx35pdk.
On 28/12/2012 20:17, Otavio Salvador wrote:
> For a generic environment, we shouldn't have a fixed rootfs filesystem
> so we drop it from env.
>
> Signed-off-by: Otavio Salvador
> ---
Hi Otavio,
> Changes in v2:
> - reformat environment change to fit in 80 cols
>
> include/configs/mx28evk.h
On 31/12/2012 01:14, Shawn Guo wrote:
> All esdhc variants we know should support high capacity MMC cards,
> so let's add MMC_MODE_HC host_caps unconditionally to support those
> MMC cards (capacity > 2 GB).
>
> Signed-off-by: Shawn Guo
> ---
> drivers/mmc/fsl_esdhc.c |3 ++-
> 1 file change
On 31/12/2012 01:15, Shawn Guo wrote:
> It makes more sense to use on-board eMMC to store environments. The
> boot partition 1 is selected by default.
>
> Signed-off-by: Shawn Guo
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
==
On 31/12/2012 01:14, Shawn Guo wrote:
> The on-board number of available usdhc devices is something board
> specific. The patch moves CONFIG_SYS_FSL_USDHC_NUM out of
> mx6qsabre_common.h and adds usdhc2 and usdhc4 support for mx6qsabresd
> board.
>
> To keep the default mmc device for environment
Dear Stefano Babic,
> On 26/12/2012 02:08, Marek Vasut wrote:
> > Adjust the NAND partitioning layout so that there is a separate partition
> > for the ramdisk and fdt blob on the NAND.
> >
> > Signed-off-by: Marek Vasut
> > Cc: Detlev Zundel
> > Cc: Stefano Babic
> > Cc: Wolfgang Denk
> > --
On 03/01/2013 19:24, Fabio Estevam wrote:
> In order to mx53 ROM to properly load the U-boot image, its header size
> should
> be multiple of 512 bytes.
>
> This issue was observed with gcc 4.6.2/4.7.3, which caused data aborts:
>
> U-Boot 2013.01-rc2-00172-gf8cfcf1-dirty (Dec 26 2012 - 13:13:2
On 28/12/2012 15:05, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Make the error handling more robust.
>
> Check if each one of the PMIC writes fail and if they do, just return
> immediately.
>
> Also, print the cause for the failures.
>
> Signed-off-by: Fabio Estevam
> ---
Applied to u-bo
On 27/12/2012 16:46, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Looks like the original comment came from a copy and paste from mx31ads.h.
>
> It does not have a context on mx51evk anymore, so delete it.
>
> Signed-off-by: Fabio Estevam
> ---
Applied to u-boot-imx, thanks.
Best regards,
On 28/12/2012 15:05, Fabio Estevam wrote:
> From: Fabio Estevam
>
> commit c73368150 (pmic: Extend PMIC framework to support multiple instances
> of PMIC devices) introduced an extra 'retval' variable, but this is not
> necessary since we have already the variable 'ret' in place.
>
> So use 'r
On 05/01/2013 18:10, Marek Vasut wrote:
> Dear Stefano Babic,
>
>> On 26/12/2012 02:08, Marek Vasut wrote:
>>> Adjust the NAND partitioning layout so that there is a separate partition
>>> for the ramdisk and fdt blob on the NAND.
>>>
>>> Signed-off-by: Marek Vasut
>>> Cc: Detlev Zundel
>>> Cc:
Hi Albert,
please pull from u-boot-imx, thanks.
The following changes since commit b874df74afc986b069738b180763f2464ac3f5f4:
mx25pdk: Allow booting a device tree kernel (2012-12-13 09:23:59 +0100)
are available in the git repository at:
git://www.denx.de/git/u-boot-imx.git master
for you
Hi,
While looking at the common/lcd.c I fail to understand why it declares
and uses global variables like lcd_color_fg, lcd_color_color_bg, lcd_base
and relies on the drivers / boards to provide them, leading to code
duplication. It also provides getters / setters for some of these variables.
To
Dear Stefano Babic,
> On 05/01/2013 18:10, Marek Vasut wrote:
> > Dear Stefano Babic,
> >
> >> On 26/12/2012 02:08, Marek Vasut wrote:
> >>> Adjust the NAND partitioning layout so that there is a separate
> >>> partition for the ramdisk and fdt blob on the NAND.
> >>>
> >>> Signed-off-by: Marek
Dear Jeroen,
In message <50e7fb65.9000...@myspectrum.nl> you wrote:
>
> > Hm... I'm not sure if this is the right approach, then. If mainline
> > Linux insists on such a 2 MB alignment, we shoud rather teach
> > lcd_setmem() to follow tha rule, too. That should solve the problem
> > as well (a
Dear Jeroen,
In message <50e86dfc.20...@myspectrum.nl> you wrote:
>
> While looking at the common/lcd.c I fail to understand why it declares
> and uses global variables like lcd_color_fg, lcd_color_color_bg, lcd_base
> and relies on the drivers / boards to provide them, leading to code
> duplicat
lcd_color_fg and lcd_color_bg had to be declared in board specific
code, but were not actually used there; in addition, we have getter /
setter functions for these, which were not used either.
Get rid of the global variables, and use the getter function where
needed (so far no setter calls are nee
Dear Anatolij,
In message <1357415148-9243-1-git-send-email...@denx.de> you wrote:
> lcd_color_fg and lcd_color_bg had to be declared in board specific
> code, but were not actually used there; in addition, we have getter /
> setter functions for these, which were not used either.
>
> Get rid of
This is available on other architectures, and nds32 will start to break
without it as code starts to use error numbers more.
Signed-off-by: Simon Glass
---
arch/nds32/include/asm/errno.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
create mode 100644 arch/nds32/include/asm/errno.h
Hi Marek,
On Sat, Jan 5, 2013 at 12:20 AM, Marek Vasut wrote:
> Dear Simon Glass,
>
> [...]
>
>> + /* Signatures have a time stamp */
>> + if (IMAGE_ENABLE_TIMESTAMP && keyname) {
>> + time_t timestamp;
>> +
>> + printf("%s Timestamp:", p);
>> + if
Hi Marek,
On Sat, Jan 5, 2013 at 12:19 AM, Marek Vasut wrote:
> Dear Simon Glass,
>
> [...]
>
>> + int string_size;
>> + int ret;
>> +
>> + /*
>> + * Get the current string size, before we update the FIT and add
>> + * more
>> + */
>> + string_size = fdt_size_dt_str
Hi Marek,
On Sat, Jan 5, 2013 at 12:24 AM, Marek Vasut wrote:
> Dear Simon Glass,
>
>> The fit_handle_file() function is quiet long
>
> quite ;-)
Quite.
>
>> - split out the part that
>> loads and checks a FIT into its own function. We will use this
>> function for storing public keys into a de
46 matches
Mail list logo
