Re: [U-Boot] [PATCH 1/3] The BUILD_BUG_ON macros moved from ubi_uboot.h to common.h

2010-04-03 Thread Michael Zaidman
On Fri, Apr 2, 2010 at 9:22 PM, Mike Frysinger wrote: >> >> The common.h includes image.h which includes compiler.h, so >> technically it should works also. > > you're looking the wrong direction.  host tools include compiler.h, they dont > include common.h. It was clear to me. I meant the u-boot

[U-Boot] [PATCH 1/2] Add AT91_ECC_BASE to at91sam9260.h to use atmel_nand with HW-ECC

2010-04-03 Thread Alexander Holler
Signed-off-by: Alexander Holler --- include/asm-arm/arch-at91/at91sam9260.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/asm-arm/arch-at91/at91sam9260.h b/include/asm-arm/arch-at91/at91sam9260.h index a60a081..3bc7167 100644 --- a/include/asm-arm/arch-at91/at9

[U-Boot] [PATCH 2/2] Fix compile errors for atmel_nand with hw-ecc and new SoC access

2010-04-03 Thread Alexander Holler
atmel_nand.c with HW-ECC doesn't compile with the new SoC access. Using CONFIG_AT91_LEGACY to circumvent the compile errors only leaves the driver in a state where it doesn't find the NAND. To use HW-ECC with atmel_nand one has to use CONFIG_SYS_NAND_ECC_BASE AT91_ECC0_BASE (instead of AT91_ECC0)

Re: [U-Boot] [PATCH 2/2] Fix compile errors for atmel_nand with hw-ecc and new SoC access

2010-04-03 Thread Alexander Holler
If someone else wonders why an author should sign his own patches, a good explanation can be found here: http://kerneltrap.org/files/Jeremy/DCO.txt ;) Regards, Alexander ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinf

Re: [U-Boot] [PATCH 1/3] The BUILD_BUG_ON macros moved from ubi_uboot.h to common.h

2010-04-03 Thread Mike Frysinger
On Saturday 03 April 2010 04:23:58 Michael Zaidman wrote: > On Fri, Apr 2, 2010 at 9:22 PM, Mike Frysinger wrote: > >> I have a doubt however - what about location of similar staff such as > >> BUG, BUG_ON, debug, error, etc. Should it also be moved into compiler.h > >> file? > > > > many should

Re: [U-Boot] [PATCH 1/1] at91sam9x: driver to use the internal RTT as RTC

2010-04-03 Thread Tom
Alexander Holler wrote: > Based on the linux driver. > AT91 is moving away from legacy register access to accessing registers through structures. Please convert to this change to the new at91 register access through structures. See doc/README.at91-soc > Signed-off-by: Alexander Holler > --- >

Re: [U-Boot] [PATCH 1/2] at91: add defines for RTT and GPBR

2010-04-03 Thread Tom
Alexander Holler wrote: > Signed-off-by: Alexander Holler > --- > include/asm-arm/arch-at91/at91sam9260.h |2 ++ > include/asm-arm/arch-at91/at91sam9261.h |2 ++ > include/asm-arm/arch-at91/at91sam9263.h |3 +++ > 3 files changed, 7 insertions(+), 0 deletions(-) > Ack This change is

Re: [U-Boot] [PATCH 3/3] TI: TNETV107X EVM initial support

2010-04-03 Thread Tom
Chemparathy, Cyril wrote: > Wolfgang, > > [...] Is "davinci" correct here? >>> Yes, this SOC has the exact same controller as on Davinci, and therefore >>> the NAND driver is reused. >> But you don't call this a "Davinci"-Board, or do you? > > "Davinci NAND" is a bit of a misnomer since this

Re: [U-Boot] [PATCH 1/1] at91sam9x: driver to use the internal RTT as RTC

2010-04-03 Thread Alexander Holler
Am 03.04.2010 20:33, schrieb Tom: > Alexander Holler wrote: > > Change parameter name to something more descriptive. > 'tmp' implies used locally and this value is passed back. > Maybe 'tm' as to_tmp(.., struct rtc_time *tm) ? > Maybe someone should place a README in drivers/rtc which reads "Don't

Re: [U-Boot] [PATCH 1/2] at91: add defines for RTT and GPBR

2010-04-03 Thread Alexander Holler
Am 03.04.2010 20:36, schrieb Tom: > Alexander Holler wrote: >> Signed-off-by: Alexander Holler >> --- >> include/asm-arm/arch-at91/at91sam9260.h | 2 ++ >> include/asm-arm/arch-at91/at91sam9261.h | 2 ++ >> include/asm-arm/arch-at91/at91sam9263.h | 3 +++ >> 3 files changed, 7 insertions(+), 0 deleti