Re: [U-Boot] powerpc/usb: fix bug of CPU halt when missing USB PHY clock

> -Original Message- > From: Andy Fleming [mailto:aflem...@gmail.com] > Sent: Monday, February 13, 2012 4:14 PM > To: Liu Shengzhou-B36685; U-Boot list > Subject: Re: powerpc/usb: fix bug of CPU halt when missing USB PHY > clock > > You moved the USB_EN setting: > > > + /* Enable interf

Re: [U-Boot] powerpc/usb: fix bug of CPU halt when missing USB PHY clock

You moved the USB_EN setting: + /* Enable interface. */ + setbits_be32(&ehci->control, USB_EN); + [...] - /* Enable interface. */ - setbits_be32(&ehci->control, USB_EN); - Should we clear this bit if we don't find a valid clock? The patch description didn't say why you moved this write. Andy