Re: [U-Boot] omap_gpmc: Do not default to HAM1 when SW ECC is selected

2015-02-18 Thread Adam Lee
Had a conversation with Ash @ Gumstix and he pointed out relying on CONFIG_NAND_OMAP_ECCSCHEME could be dangerous as it could be anything other than the two SW ECC schemes available for OMAP3. Also it looks like making a selection between OMAP_ECC_BCH8_CODE_HW and OMAP_ECC_BCH8_CODE_HW_DETECTION_S

Re: [U-Boot] omap_gpmc: Do not default to HAM1 when SW ECC is selected

2015-02-18 Thread Adam Lee
Hi Andreas, for OMAP3 and AM35xx boards, it would have been ok omitting the CONFIG_BCH check and simply use CONFIG_NAND_OMAP_ECCSCHEME. Those boards use the ecc scheme config already. However I just wasn't 100% sure if I could rely on this config for all TI OMAP/AM based boards. I know OMAP3 and A

Re: [U-Boot] omap_gpmc: Do not default to HAM1 when SW ECC is selected

2015-02-18 Thread Andreas Bießmann
Hi Adam, On 02/18/2015 03:58 AM, Adam YH Lee wrote: > The ECC scheme selection algorithm in OMAP GPMC appears to be left untested > when > BCH8 handling code was added. Running 'nandecc sw' defaults to HAM1 even if > the board is using another scheme (ex. OMAP_ECC_BCH8_CODE_HW_DETECTION_SW on > O