Re: [U-Boot] dfu: make data buffer size configurable

2013-06-12 Thread Heiko Schocher
Hello Marek, Am 12.06.2013 10:36, schrieb Marek Vasut: > Dear Tom Rini, > >> On Mon, Jun 10, 2013 at 09:05:48AM +0200, Wolfgang Denk wrote: >>> Dear Heiko Schocher, >>> >>> In message <51b555d7.5010...@denx.de> you wrote: Ok, I can change this. Envvar name "dfu_data_buf_size" is ok? >>> >>>

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-12 Thread Marek Vasut
Dear Tom Rini, > On Mon, Jun 10, 2013 at 09:05:48AM +0200, Wolfgang Denk wrote: > > Dear Heiko Schocher, > > > > In message <51b555d7.5010...@denx.de> you wrote: > > > Ok, I can change this. Envvar name "dfu_data_buf_size" is ok? > > > > Such long names are a paint to type. As we can't buffer an

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-10 Thread Tom Rini
On Mon, Jun 10, 2013 at 09:05:48AM +0200, Wolfgang Denk wrote: > Dear Heiko Schocher, > > In message <51b555d7.5010...@denx.de> you wrote: > > > > Ok, I can change this. Envvar name "dfu_data_buf_size" is ok? > > Such long names are a paint to type. As we can't buffer anything else > but data, w

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-10 Thread Wolfgang Denk
Dear Heiko Schocher, In message <51b555d7.5010...@denx.de> you wrote: > > Ok, I can change this. Envvar name "dfu_data_buf_size" is ok? Such long names are a paint to type. As we can't buffer anything else but data, we should be able to omit this, i. e. what about dfu_bufsiz ["bufsiz"

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-09 Thread Lukasz Majewski
Hi Heiko, > Hello Marek, > > Am 09.06.2013 22:01, schrieb Marek Vasut: > > Dear Pantelis Antoniou, > > > >> Heiko, > >> > >> On Jun 4, 2013, at 1:31 PM, Heiko Schocher wrote: > >>> Hello Pantelis, > >>> > >>> Am 04.06.2013 12:08, schrieb Pantelis Antoniou: > Hi Heiko, > > Just thi

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-09 Thread Heiko Schocher
Hello Marek, Am 09.06.2013 22:01, schrieb Marek Vasut: > Dear Pantelis Antoniou, > >> Heiko, >> >> On Jun 4, 2013, at 1:31 PM, Heiko Schocher wrote: >>> Hello Pantelis, >>> >>> Am 04.06.2013 12:08, schrieb Pantelis Antoniou: Hi Heiko, Just thinking out loud here. Can we have an ext

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-09 Thread Marek Vasut
Dear Pantelis Antoniou, > Heiko, > > On Jun 4, 2013, at 1:31 PM, Heiko Schocher wrote: > > Hello Pantelis, > > > > Am 04.06.2013 12:08, schrieb Pantelis Antoniou: > >> Hi Heiko, > >> > >> Just thinking out loud here. Can we have an extra option that > >> allocates the buffer dynamically based o

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-07 Thread Wolfgang Denk
Dear Heiko, In message <51b17815.8060...@denx.de> you wrote: > > and I see no longer the above error! So I see two solutions > for my problem: > > - make DFU_DATA_BUF_SIZE in U-Boot smaller or configurable > - make the timeout in dfu-util bigger or configurable I think we have just learned that

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-06 Thread Heiko Schocher
Hello Tom, Am 06.06.2013 17:55, schrieb Tom Rini: > On Wed, Jun 05, 2013 at 04:04:46PM +0200, Heiko Schocher wrote: > > [snip] In current code CONFIG_SYS_DFU_MAX_FILE_SIZE is not used in dfu_nand.c, >>> >>> Nor anywhere else. As I said in the DFU + UBI thread, there's a bug >>> here :) >> >

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-06 Thread Tom Rini
On Wed, Jun 05, 2013 at 04:04:46PM +0200, Heiko Schocher wrote: [snip] > >> In current code CONFIG_SYS_DFU_MAX_FILE_SIZE is not used in dfu_nand.c, > > > > Nor anywhere else. As I said in the DFU + UBI thread, there's a bug > > here :) > > CONFIG_SYS_DFU_MAX_FILE_SIZE is used in ./drivers/dfu/d

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-05 Thread Heiko Schocher
Hello Tom, Am 05.06.2013 14:43, schrieb Tom Rini: > On Wed, Jun 05, 2013 at 06:53:53AM +0200, Heiko Schocher wrote: >> Hello Tom, >> >> Am 04.06.2013 22:04, schrieb Tom Rini: >>> On Tue, Jun 04, 2013 at 11:22:54AM +0200, Heiko Schocher wrote: [...] + CONFIG_SYS_DFU_DATA_BUF_SIZE

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-05 Thread Tom Rini
On Wed, Jun 05, 2013 at 06:53:53AM +0200, Heiko Schocher wrote: > Hello Tom, > > Am 04.06.2013 22:04, schrieb Tom Rini: > > On Tue, Jun 04, 2013 at 11:22:54AM +0200, Heiko Schocher wrote: > > > >> Dfu transfer uses a buffer before writing data to the > >> raw storage device. Make the size (in byt

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-04 Thread Heiko Schocher
Hello Tom, Am 04.06.2013 22:04, schrieb Tom Rini: > On Tue, Jun 04, 2013 at 11:22:54AM +0200, Heiko Schocher wrote: > >> Dfu transfer uses a buffer before writing data to the >> raw storage device. Make the size (in bytes) of this buffer >> configurable. > > NAK. :-( >> +CONFIG_SYS

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-04 Thread Tom Rini
On Tue, Jun 04, 2013 at 11:22:54AM +0200, Heiko Schocher wrote: > Dfu transfer uses a buffer before writing data to the > raw storage device. Make the size (in bytes) of this buffer > configurable. NAK. > + CONFIG_SYS_DFU_DATA_BUF_SIZE > + Dfu transfer uses a buffer before

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-04 Thread Pantelis Antoniou
Heiko, On Jun 4, 2013, at 1:31 PM, Heiko Schocher wrote: > Hello Pantelis, > > Am 04.06.2013 12:08, schrieb Pantelis Antoniou: >> Hi Heiko, >> >> Just thinking out loud here. Can we have an extra option that >> allocates the buffer dynamically based on an env variable? > > Hmm.. also a possibi

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-04 Thread Heiko Schocher
Hello Pantelis, Am 04.06.2013 12:08, schrieb Pantelis Antoniou: > Hi Heiko, > > Just thinking out loud here. Can we have an extra option that > allocates the buffer dynamically based on an env variable? Hmm.. also a possibility... I have here no preferences ... Name: "dfu_data_buf_size" if not

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-04 Thread Lukasz Majewski
Hi Heiko, > Dfu transfer uses a buffer before writing data to the > raw storage device. Make the size (in bytes) of this buffer > configurable. > Acked-by: Lukasz Majewski > Signed-off-by: Heiko Schocher > Cc: Pantelis Antoniou > Cc: Tom Rini > Cc: Lukasz Majewski > Cc: Kyungmin Park > Cc

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-04 Thread Pantelis Antoniou
Hi Heiko, Just thinking out loud here. Can we have an extra option that allocates the buffer dynamically based on an env variable? Regards -- Pantelis On Jun 4, 2013, at 12:22 PM, Heiko Schocher wrote: > Dfu transfer uses a buffer before writing data to the > raw storage device. Make the size