Re: [U-Boot] [RFC] setting pio modes for IDE devices

2008-08-15 Thread Wolfgang Denk
Dear "Steven A. Falco", In message <[EMAIL PROTECTED]> you wrote: > I realized that I should be checking to see if word 163 is applicable to > the ATA device in question. To do that, I need to call ata_id_is_cfa() from > libata.h. However, libata.h conflicts with ata.h because of duplicate > enu

Re: [U-Boot] [RFC] setting pio modes for IDE devices

2008-08-15 Thread Steven A. Falco
I realized that I should be checking to see if word 163 is applicable to the ATA device in question. To do that, I need to call ata_id_is_cfa() from libata.h. However, libata.h conflicts with ata.h because of duplicate enum values. Therefore, this respin of the proposed patch deletes the duplica

Re: [U-Boot] [RFC] setting pio modes for IDE devices

2008-08-15 Thread Steven A. Falco
Jean-Christophe PLAGNIOL-VILLARD wrote: >> --- >> common/cmd_ide.c | 52 >> include/ata.h|4 +++- >> 2 files changed, 55 insertions(+), 1 deletions(-) >> >> diff --git a/common/cmd_ide.c b/common/cmd_ide.c >> index b4d9719..0e435a7 100

Re: [U-Boot] [RFC] setting pio modes for IDE devices

2008-08-14 Thread Jean-Christophe PLAGNIOL-VILLARD
> --- > common/cmd_ide.c | 52 > include/ata.h|4 +++- > 2 files changed, 55 insertions(+), 1 deletions(-) > > diff --git a/common/cmd_ide.c b/common/cmd_ide.c > index b4d9719..0e435a7 100644 > --- a/common/cmd_ide.c > +++ b/common/cm

Re: [U-Boot] [RFC] setting pio modes for IDE devices

2008-08-14 Thread Steven A. Falco
Wolfgang Denk wrote: > Dear "Steven A. Falco", > > In message <[EMAIL PROTECTED]> you wrote: >> The following patch adds the ability to call-out from the ide_ident >> routine to a board-specific routine to set the PIO mode of an attached >> device. >> >> This feature is controlled by the preproces

Re: [U-Boot] [RFC] setting pio modes for IDE devices

2008-08-13 Thread Wolfgang Denk
Dear "Steven A. Falco", In message <[EMAIL PROTECTED]> you wrote: > The following patch adds the ability to call-out from the ide_ident > routine to a board-specific routine to set the PIO mode of an attached > device. > > This feature is controlled by the preprocessor variable CONFIG_TUNE_CFA.