Re: [U-Boot] [RFC] disk: part_dos: Fix part_test_dos() regression

2017-10-03 Thread Tom Rini
On Tue, Oct 03, 2017 at 08:44:31AM -0400, Rob Clark wrote: > On Tue, Oct 3, 2017 at 7:04 AM, Fabio Estevam wrote: > > On Tue, Oct 3, 2017 at 7:57 AM, Rob Clark wrote: > > > >> btw, if I had to take a guess, I'd say that perhaps blksz is smaller > >> than 'legacy_mbr', so maybe rather than allocat

Re: [U-Boot] [RFC] disk: part_dos: Fix part_test_dos() regression

2017-10-03 Thread Rob Clark
On Tue, Oct 3, 2017 at 7:04 AM, Fabio Estevam wrote: > On Tue, Oct 3, 2017 at 7:57 AM, Rob Clark wrote: > >> btw, if I had to take a guess, I'd say that perhaps blksz is smaller >> than 'legacy_mbr', so maybe rather than allocating blksize, it should >> be DIV_ROUND_UP(sizeof(legacy_mbr), dev_des

Re: [U-Boot] [RFC] disk: part_dos: Fix part_test_dos() regression

2017-10-03 Thread Fabio Estevam
On Tue, Oct 3, 2017 at 7:57 AM, Rob Clark wrote: > btw, if I had to take a guess, I'd say that perhaps blksz is smaller > than 'legacy_mbr', so maybe rather than allocating blksize, it should > be DIV_ROUND_UP(sizeof(legacy_mbr), dev_desc->blksz).. or I guess that > could be simplified to not use

Re: [U-Boot] [RFC] disk: part_dos: Fix part_test_dos() regression

2017-10-03 Thread Rob Clark
On Tue, Oct 3, 2017 at 6:47 AM, Rob Clark wrote: > personally I think we should try to figure out what is wrong on imx6 > rather than blindly reverting.. without this change MBR partitioned > disks might not generate unique device-paths for EFI boot. > > If you can't get any debug logs from SPL bu

Re: [U-Boot] [RFC] disk: part_dos: Fix part_test_dos() regression

2017-10-03 Thread Rob Clark
personally I think we should try to figure out what is wrong on imx6 rather than blindly reverting.. without this change MBR partitioned disks might not generate unique device-paths for EFI boot. If you can't get any debug logs from SPL build, perhaps you can try an old SPL image but main u-boot i