Re: [U-Boot] [PATCH v5 1/3] dm: implement a Timer uclass

2015-10-08 Thread Thomas Chou
Hi Simon, On 10/09/2015 01:14 AM, Simon Glass wrote: +config DM_TIMER One more little nit - this should be just 'TIMER'? All of the DM_... options will eventually be removed. They indicate that driver model is being used for a function. In your case, there is no legacy version so you can just

Re: [U-Boot] [PATCH v5 1/3] dm: implement a Timer uclass

2015-10-08 Thread Simon Glass
Hi Thomas, On 8 October 2015 at 02:03, Thomas Chou wrote: > Implement a Timer uclass to work with lib/time.c. > > Signed-off-by: Thomas Chou > Reviewed-by: Simon Glass > --- > v2 > fix coding style. > v3 > add description to Kconfig as Simon suggested. > move timer.c code to lib/time.c. >