Re: [U-Boot] [PATCH v5] mmc: add generic mmc spi driver

2010-04-29 Thread Thomas Chou
On 04/30/2010 03:07 AM, Mike Frysinger wrote: > On Thursday 29 April 2010 10:51:03 Thomas Chou wrote: > >> 2. Andy suggested to create a new mmc_spi device for each bus and cs. >> > this is what i was suggesting from the start ... sorry if i wasnt clear > -mike > Hi Mike, Thank you a

Re: [U-Boot] [PATCH v5] mmc: add generic mmc spi driver

2010-04-29 Thread Mike Frysinger
On Thursday 29 April 2010 10:51:03 Thomas Chou wrote: > 2. Andy suggested to create a new mmc_spi device for each bus and cs. this is what i was suggesting from the start ... sorry if i wasnt clear -mike signature.asc Description: This is a digitally signed message part.

Re: [U-Boot] [PATCH v5] mmc: add generic mmc spi driver

2010-04-29 Thread Thomas Chou
On 04/28/2010 11:21 PM, Andy Fleming wrote: > >> +static int do_mmc_spi(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) >> +{ >> + int dev_num = -1; >> + uint bus; >> + uint cs; >> + uint speed; >> + uint mode; >> + char *endp; >> + struct mmc *mmc; >>

Re: [U-Boot] [PATCH v5] mmc: add generic mmc spi driver

2010-04-28 Thread Thomas Chou
Hi Andy, Thanks for you review. On 04/28/2010 11:21 PM, Andy Fleming wrote: > >> The crc7 lib func is merged from linux and used to compute mmc >> command checksum. >> > This should probably be a separate patch. > > OK. > >> + >> + do { >> + mmc = find_mmc_device(++d

Re: [U-Boot] [PATCH v5] mmc: add generic mmc spi driver

2010-04-28 Thread Andy Fleming
On Wed, Apr 28, 2010 at 1:00 AM, Thomas Chou wrote: > This patch supports mmc/sd card with spi interface. It is based on > the generic mmc framework. It works with SDHC and supports write. > > The crc7 lib func is merged from linux and used to compute mmc > command checksum. This should probably