Re: [U-Boot] [PATCH v4 3/4]: Define ffs/fls for all architectures

2009-09-17 Thread Stefan Roese
On Thursday 17 September 2009 09:13:48 Simon Kagstrom wrote: > > > Yes, the patch should have contained something like that. Well, we'll > > > have to cook up a fix for this then. Sorry about that again. > > > > Simon, could you do this please? > > Yes, absolutely. I'll try to have it done by this

Re: [U-Boot] [PATCH v4 3/4]: Define ffs/fls for all architectures

2009-09-17 Thread Simon Kagstrom
On Thu, 17 Sep 2009 08:56:08 +0200 > > Yes, the patch should have contained something like that. Well, we'll > > have to cook up a fix for this then. Sorry about that again. > > Simon, could you do this please? Yes, absolutely. I'll try to have it done by this afternoon. > And btw: > > #ifndef

Re: [U-Boot] [PATCH v4 3/4]: Define ffs/fls for all architectures

2009-09-16 Thread Stefan Roese
On Thursday 17 September 2009 08:45:21 Simon Kagstrom wrote: > > One way to solve this would be something like this: > > > > include/asm-ppc/bitops.h: > > @@ -230,6 +231,7 @@ extern __inline__ int ffs(int x) > > { > > return __ilog2(x & -x) + 1; > > } > > +#define PLATFORM_FFS > > > > include

Re: [U-Boot] [PATCH v4 3/4]: Define ffs/fls for all architectures

2009-09-16 Thread Simon Kagstrom
On Wed, 16 Sep 2009 21:19:03 +0200 Stefan Roese wrote: > include/asm-ppc/bitops.h: > @@ -230,6 +231,7 @@ extern __inline__ int ffs(int x) > { > return __ilog2(x & -x) + 1; > } > +#define ffs > > So after "ffs()" is define as an inline function, you define it to nothing. I > understand t

Re: [U-Boot] [PATCH v4 3/4]: Define ffs/fls for all architectures

2009-09-16 Thread Stefan Roese
Hi Simon, On Tuesday 15 September 2009 22:34:43 Wolfgang Denk wrote: > Dear Simon Kagstrom, > > In message <20090824091012.0df5b...@marrow.netinsight.se> you wrote: > > Define ffs/fls for all architectures > > > > UBIFS requires fls(), which is not defined for arm (and some other > > architecture

Re: [U-Boot] [PATCH v4 3/4]: Define ffs/fls for all architectures

2009-09-15 Thread Wolfgang Denk
Dear Simon Kagstrom, In message <20090824091012.0df5b...@marrow.netinsight.se> you wrote: > Define ffs/fls for all architectures > > UBIFS requires fls(), which is not defined for arm (and some other > architectures) and this patch adds it. The implementation is taken from > Linux and is generic.