Re: [U-Boot] [PATCH v4 2/5] Add Ethernet hardware MAC address framework to usbnet

2011-04-29 Thread Mike Frysinger
On Thursday, April 21, 2011 19:38:06 Wolfgang Denk wrote: > Simon Glass wrote: > > >> + * base_name - base name for device (NULL for "eth") > > > > > > This is an atitifical decision for the API which is difficult to > > > understand. It just makes the code and understanding it more > > > diffi

Re: [U-Boot] [PATCH v4 2/5] Add Ethernet hardware MAC address framework to usbnet

2011-04-26 Thread Simon Glass
On Thu, Apr 21, 2011 at 6:52 PM, Simon Glass wrote: > On Thu, Apr 21, 2011 at 4:38 PM, Wolfgang Denk wrote: > > Dear Simon Glass, > > > > In message you > wrote: > >> > >> >> + eth = &usb_eth[usb_max_eth_dev].eth_dev; > >> > > >> > Index for eth is usb_max_eth_dev. > >> > > >> >> @@

Re: [U-Boot] [PATCH v4 2/5] Add Ethernet hardware MAC address framework to usbnet

2011-04-21 Thread Simon Glass
On Thu, Apr 21, 2011 at 4:38 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message you wrote: >> >> >> +             eth = &usb_eth[usb_max_eth_dev].eth_dev; >> > >> > Index for eth is usb_max_eth_dev. >> > >> >> @@ -100,7 +102,10 @@ static void probe_valid_drivers(struct usb_device *> >>

Re: [U-Boot] [PATCH v4 2/5] Add Ethernet hardware MAC address framework to usbnet

2011-04-21 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > >> + eth = &usb_eth[usb_max_eth_dev].eth_dev; > > > > Index for eth is usb_max_eth_dev. > > > >> @@ -100,7 +102,10 @@ static void probe_valid_drivers(struct usb_device *> > >> dev) > >>* call since eth_current_> chan

Re: [U-Boot] [PATCH v4 2/5] Add Ethernet hardware MAC address framework to usbnet

2011-04-19 Thread Simon Glass
On Mon, Apr 18, 2011 at 12:04 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1302748176-4324-2-git-send-email-...@chromium.org> you wrote: >> @@ -88,9 +89,10 @@ static void probe_valid_drivers(struct usb_device *dev) >>               /* >>                * ok, it is a supported eth d

Re: [U-Boot] [PATCH v4 2/5] Add Ethernet hardware MAC address framework to usbnet

2011-04-18 Thread Wolfgang Denk
Dear Remy Bohmer, In message you wrote: > > > board/davinci/common/misc.c |2 +- > > drivers/net/designware.c|2 +- > > drivers/usb/eth/usb_ether.c |9 - > > include/net.h | 25 - > > net/eth.c | 65 +++= > +

Re: [U-Boot] [PATCH v4 2/5] Add Ethernet hardware MAC address framework to usbnet

2011-04-18 Thread Wolfgang Denk
Dear Simon Glass, In message <1302748176-4324-2-git-send-email-...@chromium.org> you wrote: > Built-in Ethernet adapters support setting the mac address by means of a > ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr). > > This adds similar support to the USB network

Re: [U-Boot] [PATCH v4 2/5] Add Ethernet hardware MAC address framework to usbnet

2011-04-18 Thread Remy Bohmer
Hi, 2011/4/14 Simon Glass : > Built-in Ethernet adapters support setting the mac address by means of a > ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr). > > This adds similar support to the USB network side, using the names > usbethaddr, usbeth1addr, etc. They are ke