Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-21 Thread Michael Walle
Am Freitag 11 Mai 2012, 18:51:09 schrieb Prafulla Wadaskar: > I will check on this patch in this week end since I am travelling. Hi Prafulla, did you find the time to review the arm/board specific patches in this series (http://patchwork.ozlabs.org/patch/158627/)? -- Michael __

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-13 Thread Mike Frysinger
On Friday 11 May 2012 17:22:23 Michael Walle wrote: > Am Freitag 11 Mai 2012, 23:14:25 schrieb Wolfgang Denk: > > Michael Walle wrote: > > > What about the rand function? I guess that should be two > > > compile time options > > > > > > - CONFIG_RAND > > > - CONFIG_RANDOM_HWADDR > > > > > > Any b

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112342.43133.mich...@walle.cc> you wrote: > Am Freitag 11 Mai 2012, 23:30:59 schrieb Wolfgang Denk: > > Well, you patch did not change this code. > > > > And I have to admit that I doubt the increased code size would be > > worth such a change, at this place.

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 23:30:59 schrieb Wolfgang Denk: > Well, you patch did not change this code. > > And I have to admit that I doubt the increased code size would be > worth such a change, at this place. Ok, can we agree on keeping the rand function in lib/ but using just one macro CONFIG_RAN

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112322.23891.mich...@walle.cc> you wrote: > > > > - CONFIG_RAND > > > - CONFIG_RANDOM_HWADDR > > > > > > Any better names? > > > > Please make this a single option, CONFIG_RANDOM_MACADDR. It appears > > nobody else ever needed a random number before, and we

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 23:14:25 schrieb Wolfgang Denk: > Dear Michael Walle, > > In message <201205112254.13896.mich...@walle.cc> you wrote: > > What about the rand function? I guess that should be two > > compile time options > > > > - CONFIG_RAND > > - CONFIG_RANDOM_HWADDR > > > > Any better

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112254.13896.mich...@walle.cc> you wrote: > > What about the rand function? I guess that should be two > compile time options > > - CONFIG_RAND > - CONFIG_RANDOM_HWADDR > > Any better names? Please make this a single option, CONFIG_RANDOM_MACADDR. It appe

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 22:43:16 schrieb Wolfgang Denk: > Keep these patches together, please. The responsible custodians can > still ACK individual patches of the series. > > The fact that only a single board ever needed these functions makes me > wonder if these are really of any general use.

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <201205112229.44084.mich...@walle.cc> you wrote: > > > Please submit with the patches that actually use this code. > > Please have a look at > "[PATCH v4] Kirkwood: add lschlv2 and lsxhl board support" > > All introduced functions are used by this bsp. The origin

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 21:18:50 schrieb Wolfgang Denk: > Dear Michael Walle, > > In message <1336671134-16342-1-git-send-email-mich...@walle.cc> you wrote: > > This patchset is a split-off from my patch series "Kirkwood: add lschlv2 > > and lsxhl board support". > > > > Changes: > > > > v4: > >

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message <1336671134-16342-1-git-send-email-mich...@walle.cc> you wrote: > This patchset is a split-off from my patch series "Kirkwood: add lschlv2 > and lsxhl board support". > > Changes: > v4: > - typo fixes (thanks Mike) > - seed all 46bits of the generated ethernet add

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Prafulla Wadaskar
> -Original Message- > From: Joe Hershberger [mailto:joe.hershber...@gmail.com] > Sent: 11 May 2012 09:47 > To: Michael Walle > Cc: u-boot@lists.denx.de; Prafulla Wadaskar > Subject: Re: [PATCH v4 0/3] net: helper functions > > Hi Michael, > > On Fri, May 11, 2012 at 11:32 AM, Michael W

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Joe Hershberger
Hi Michael, On Fri, May 11, 2012 at 11:32 AM, Michael Walle wrote: > Am Donnerstag 10 Mai 2012, 19:32:11 schrieb Michael Walle: >> This patchset is a split-off from my patch series "Kirkwood: add lschlv2 >> and lsxhl board support". > > Hi Joe, > > will you ack/nak these patch series and in case

Re: [U-Boot] [PATCH v4 0/3] net: helper functions

2012-05-11 Thread Michael Walle
Am Donnerstag 10 Mai 2012, 19:32:11 schrieb Michael Walle: > This patchset is a split-off from my patch series "Kirkwood: add lschlv2 > and lsxhl board support". Hi Joe, will you ack/nak these patch series and in case of an ack, Prafulla will fetch these into his tree? Or how is it supposed to w