Re: [U-Boot] [PATCH v4] sh: i2c: Add support I2C controller of SH7734

Hi, Mike. 2012/3/1 Mike Frysinger : > On Wednesday 29 February 2012 21:58:42 Nobuhiro Iwamatsu wrote: >> --- /dev/null >> +++ b/drivers/i2c/sh_sh7734_i2c.c >> >> +#include >> +#include > > should include i2c.h too so you know your funcs match the prototypes everyone > else uses OK. > >> +stati

Re: [U-Boot] [PATCH v4] sh: i2c: Add support I2C controller of SH7734

On Wednesday 29 February 2012 21:58:42 Nobuhiro Iwamatsu wrote: > --- /dev/null > +++ b/drivers/i2c/sh_sh7734_i2c.c > > +#include > +#include should include i2c.h too so you know your funcs match the prototypes everyone else uses > +static int check_stop(struct sh_i2c *base) > +{ > + int i