Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-17 Thread Wolfgang Denk
Dear Mike Rapoport, In message <4b0117da.2020...@compulab.co.il> you wrote: > > >> These should not be needed in your board config file. Please move to a > >> more appropriate header. > > As I've already answered Wolfgang ([1]), this is what _all_ other omap3 board > do... Moving these requires

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-16 Thread Tom
Mike Rapoport wrote: > >>> >>> >> Yes this change would apply to all the omap3 boards. >> But it looks like they are are all the same change. >> >> The change per board, would be to delete these externs once the >> first code change is made. >> >> Since this is a code movement change, it can be

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-16 Thread Mike Rapoport
Tom wrote: > Mike Rapoport wrote: >> Tom, >> >> Tom wrote: >>> Paulraj, Sandeep wrote: > Add CM-T35 board support > >>> Please add more description of the board. >>> > Signed-off-by: Mike Rapoport > > -- > v2 changes: > - rename board config file from omap3_cm-t35.h

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-16 Thread Tom
Mike Rapoport wrote: > Tom, > > Tom wrote: >> Paulraj, Sandeep wrote: Add CM-T35 board support >> Please add more description of the board. >> Signed-off-by: Mike Rapoport -- v2 changes: - rename board config file from omap3_cm-t35.h to cm-t35.h - remove S

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-16 Thread Mike Rapoport
Tom, Tom wrote: > Paulraj, Sandeep wrote: >>> Add CM-T35 board support >>> > > Please add more description of the board. > >>> Signed-off-by: Mike Rapoport >>> >>> -- >>> v2 changes: >>> - rename board config file from omap3_cm-t35.h to cm-t35.h >>> - remove SZ_xx references >>> - add MAKEALL/

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-15 Thread Mike Rapoport
Dear Wolfgang, Wolfgang Denk wrote: > Dear Mike Rapoport, > > In message <1258296430-19678-1-git-send-email-m...@compulab.co.il> you wrote: >> Add CM-T35 board support > ... >> MAINTAINERS |4 + >> MAKEALL |1 + >> Makefile |2 + >> board

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-15 Thread Tom
Mike Rapoport wrote: > Add CM-T35 board support > > Signed-off-by: Mike Rapoport > > -- > v2 changes: > - rename board config file from omap3_cm-t35.h to cm-t35.h > - remove SZ_xx references > - add MAKEALL/MAINTEINERS entries > > v3 changes: > - fix whitespace and indentation > - remove eth_in

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-15 Thread Wolfgang Denk
Dear Mike Rapoport, In message <1258296430-19678-1-git-send-email-m...@compulab.co.il> you wrote: > Add CM-T35 board support ... > MAINTAINERS |4 + > MAKEALL |1 + > Makefile |2 + > board/cm-t35/Makefile| 47 +++ > board/cm-t35

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-15 Thread Tom
Paulraj, Sandeep wrote: >> Add CM-T35 board support >> Please add more description of the board. >> Signed-off-by: Mike Rapoport >> >> -- >> v2 changes: >> - rename board config file from omap3_cm-t35.h to cm-t35.h >> - remove SZ_xx references >> - add MAKEALL/MAINTEINERS entries Wolfgang had

Re: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board

2009-11-15 Thread Paulraj, Sandeep
> > Add CM-T35 board support > > Signed-off-by: Mike Rapoport > > -- > v2 changes: > - rename board config file from omap3_cm-t35.h to cm-t35.h > - remove SZ_xx references > - add MAKEALL/MAINTEINERS entries > > v3 changes: > - fix whitespace and indentation > - remove eth_init from board_eth