ge-
> >>> From: Sun York-R58495
> >>> Sent: Thursday, August 13, 2015 6:55 PM
> >>> To: Ciubotariu Codrin Constantin-B43658
> >>> Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com
> >>> Subject: Re: [U-Boot] [PATCH v
m: Sun York-R58495
>>>> Sent: Thursday, August 13, 2015 6:55 PM
>>>> To: Ciubotariu Codrin Constantin-B43658
>>>> Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com
>>>> Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add functio
;> To: Ciubotariu Codrin Constantin-B43658
>>> Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com
>>> Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate
>>> a MAC
>>> address
>>>
>>>
>>>
&g
ists.denx.de; joe.hershber...@ni.com
>> Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a
>> MAC
>> address
>>
>>
>>
>> On 08/13/2015 08:42 AM, Ciubotariu Codrin Constantin-B43658 wrote:
>>> Hi Joe, York,
>>>
>>&
t; >> To: Ciubotariu Codrin Constantin-B43658
> >> Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com
> >> Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to
> >> validate a MAC address
> >>
> >> +Codrin
> >>
&g
; u-boot@lists.denx.de; joe.hershber...@ni.com
>> Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a
>> MAC
>> address
>>
>> +Codrin
>>
>> Somehow I dropped Codrin in last reply.
>>
>> On 08/10/2015 01:45 PM, York Sun wrote:
Hi Joe, York,
> -Original Message-
> From: Sun York-R58495
> Sent: Wednesday, August 12, 2015 10:59 PM
> To: Ciubotariu Codrin Constantin-B43658
> Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com
> Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add fu
n Constantin-B43658
> Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com
> Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a
> MAC
> address
>
> +Codrin
>
> Somehow I dropped Codrin in last reply.
>
> On 08/10/2015 01:45 PM,
+Codrin
Somehow I dropped Codrin in last reply.
On 08/10/2015 01:45 PM, York Sun wrote:
>
>
> On 08/10/2015 01:05 PM, Joe Hershberger wrote:
>> Hi York,
>>
>> On Mon, Aug 10, 2015 at 3:03 PM, York Sun wrote:
>>>
>>>
>>> On 08/10/2015 12:57 PM, Joe Hershberger wrote:
Too much top-posting.
On 08/10/2015 01:05 PM, Joe Hershberger wrote:
> Hi York,
>
> On Mon, Aug 10, 2015 at 3:03 PM, York Sun wrote:
>>
>>
>> On 08/10/2015 12:57 PM, Joe Hershberger wrote:
>>> Too much top-posting.
>>>
>>> On Mon, Aug 10, 2015 at 2:41 PM, York Sun wrote:
SPL doesn't use net/eth.c. You add a ca
Hi York,
On Mon, Aug 10, 2015 at 3:03 PM, York Sun wrote:
>
>
> On 08/10/2015 12:57 PM, Joe Hershberger wrote:
>> Too much top-posting.
>>
>> On Mon, Aug 10, 2015 at 2:41 PM, York Sun wrote:
>>> SPL doesn't use net/eth.c. You add a call in env_flags.c.
>>>
>>> I think you can put it in header fi
On 08/10/2015 12:57 PM, Joe Hershberger wrote:
> Too much top-posting.
>
> On Mon, Aug 10, 2015 at 2:41 PM, York Sun wrote:
>> SPL doesn't use net/eth.c. You add a call in env_flags.c.
>>
>> I think you can put it in header file and use static inline, or keep it in
>> the
>> same file where it
Too much top-posting.
On Mon, Aug 10, 2015 at 2:41 PM, York Sun wrote:
> SPL doesn't use net/eth.c. You add a call in env_flags.c.
>
> I think you can put it in header file and use static inline, or keep it in the
> same file where it is called.
That is probably fine.
> Another way is to undef
SPL doesn't use net/eth.c. You add a call in env_flags.c.
I think you can put it in header file and use static inline, or keep it in the
same file where it is called.
Another way is to undef CONFIG_CMD_NET for SPL part. It is default to 'y' in
Kconfig. Joe may have some good suggestion.
York
O
Hi York,
I didn't know that SPL uses net/eth.c . Could you please suggest a place for
eth_validate_ethaddr_str()?
Thanks and best regards,
Codrin
> -Original Message-
> From: Sun York-R58495
> Sent: Saturday, August 08, 2015 3:31 AM
> To: Ciubotariu Codrin Constantin-B43658; u-boot@list
On 07/24/2015 06:55 AM, Codrin Ciubotariu wrote:
> The code from common/env_flags.c that checks if a
> string has the format of a MAC address has been moved
> in net/eth.c as a separate function called
> eth_validate_ethaddr_str().
>
> Signed-off-by: Codrin Ciubotariu
> ---
>
> Changes for v3:
>
Hi Codrin,
On Fri, Jul 24, 2015 at 8:55 AM, Codrin Ciubotariu
wrote:
> The code from common/env_flags.c that checks if a
> string has the format of a MAC address has been moved
> in net/eth.c as a separate function called
> eth_validate_ethaddr_str().
>
> Signed-off-by: Codrin Ciubotariu
> ---
>
17 matches
Mail list logo
