Re: [U-Boot] [PATCH v3 09/11] S3C24XX: Add NAND Flash driver

2012-09-18 Thread Scott Wood
On 09/18/2012 01:48:09 PM, José Miguel Gonçalves wrote: On 18-09-2012 19:30, Scott Wood wrote: On 09/18/2012 01:22:58 PM, José Miguel Gonçalves wrote: On 18-09-2012 19:02, Scott Wood wrote: Please consider using the new SELF_INIT mechanism. Can you explain and/or point_to_resources for what

Re: [U-Boot] [PATCH v3 09/11] S3C24XX: Add NAND Flash driver

2012-09-18 Thread José Miguel Gonçalves
On 18-09-2012 19:30, Scott Wood wrote: On 09/18/2012 01:22:58 PM, José Miguel Gonçalves wrote: On 18-09-2012 19:02, Scott Wood wrote: On 09/18/2012 12:40:36 PM, José Miguel Gonçalves wrote: +#define TACLS_VAL7/* CLE & ALE duration setting (0~7) */ +#defineTWRPH0_VAL7/* TWRP

Re: [U-Boot] [PATCH v3 09/11] S3C24XX: Add NAND Flash driver

2012-09-18 Thread Scott Wood
On 09/18/2012 01:22:58 PM, José Miguel Gonçalves wrote: On 18-09-2012 19:02, Scott Wood wrote: On 09/18/2012 12:40:36 PM, José Miguel Gonçalves wrote: +#define TACLS_VAL7/* CLE & ALE duration setting (0~7) */ +#defineTWRPH0_VAL7/* TWRPH0 duration setting (0~7) */ +#define TW

Re: [U-Boot] [PATCH v3 09/11] S3C24XX: Add NAND Flash driver

2012-09-18 Thread José Miguel Gonçalves
On 18-09-2012 19:02, Scott Wood wrote: On 09/18/2012 12:40:36 PM, José Miguel Gonçalves wrote: NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of clrsetbit

Re: [U-Boot] [PATCH v3 09/11] S3C24XX: Add NAND Flash driver

2012-09-18 Thread Scott Wood
On 09/18/2012 12:40:36 PM, José Miguel Gonçalves wrote: NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of clrsetbits_le32() - Use of register bit macros