Re: [U-Boot] [PATCH v3 011/108] i2c: Tidy up designware PCI support

2019-10-28 Thread Stefan Roese
On 21.10.19 05:31, Simon Glass wrote: This is hacked into the driver at present. It seems better to have it as a separate driver that uses the base driver. Create a new file and put the X86 code into it. Actually the Baytrail settings should really come from the device tree. Signed-off-by: Simo

Re: [U-Boot] [PATCH v3 011/108] i2c: Tidy up designware PCI support

2019-10-27 Thread Bin Meng
+Stefan Hi Simon, On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > This is hacked into the driver at present. It seems better to have it as > a separate driver that uses the base driver. Create a new file and put > the X86 code into it. > > Actually the Baytrail settings should really com

Re: [U-Boot] [PATCH v3 011/108] i2c: Tidy up designware PCI support

2019-10-27 Thread Heiko Schocher
Hello Simon, Am 21.10.2019 um 05:31 schrieb Simon Glass: This is hacked into the driver at present. It seems better to have it as a separate driver that uses the base driver. Create a new file and put the X86 code into it. Actually the Baytrail settings should really come from the device tree.