Re: [U-Boot] [PATCH v2 8/8] mtd: vf610_nfc: enable ONFI detection

2015-05-08 Thread Stefan Agner
On 2015-04-21 01:17, Scott Wood wrote: > On Wed, 2015-04-08 at 16:44 +0200, Stefan Agner wrote: >> +case ALT_BUF_ONFI: >> +/* Reverse byte since the controller uses big endianness */ >> +c = nfc->column % 4; >> +c = nfc->column - c + (3 - c); > > These two l

Re: [U-Boot] [PATCH v2 8/8] mtd: vf610_nfc: enable ONFI detection

2015-04-20 Thread Scott Wood
On Wed, 2015-04-08 at 16:44 +0200, Stefan Agner wrote: > + case ALT_BUF_ONFI: > + /* Reverse byte since the controller uses big endianness */ > + c = nfc->column % 4; > + c = nfc->column - c + (3 - c); These two lines can be simplified to "c = nfc->column ^