Re: [U-Boot] [PATCH v2 4/4] lin_gadget: use common linux/compat.h

2012-04-26 Thread Anatolij Gustschin
Hi Lukasz, On Thu, 26 Apr 2012 12:32:40 +0200 Lukasz Majewski wrote: ... > > Now I see another issue. In this 4/4 patch we are removing kmalloc: > > > > -#define kmalloc(size, type) memalign(CONFIG_SYS_CACHELINE_SIZE, size) > > > > linux/compat.h defines kmalloc() to be malloc(), so the gadget

Re: [U-Boot] [PATCH v2 4/4] lin_gadget: use common linux/compat.h

2012-04-26 Thread Lukasz Majewski
Hi Anatolij, > > Hi Anatolij, > > > > > From: Mike Frysinger > > > > > > Merge our duplicate definitions with the common header. > > > Also fix drivers/usb/gadget/s3c_udc_otg_xfer_dma.c to > > > use min() instead of min_t() since we remove the latter > > > from compat.h. > > > > Yes. the incl

Re: [U-Boot] [PATCH v2 4/4] lin_gadget: use common linux/compat.h

2012-04-26 Thread Anatolij Gustschin
Hi Lukasz, On Wed, 25 Apr 2012 17:58:51 +0200 Lukasz Majewski wrote: > Hi Anatolij, > > > From: Mike Frysinger > > > > Merge our duplicate definitions with the common header. > > Also fix drivers/usb/gadget/s3c_udc_otg_xfer_dma.c to > > use min() instead of min_t() since we remove the latter

Re: [U-Boot] [PATCH v2 4/4] lin_gadget: use common linux/compat.h

2012-04-25 Thread Lukasz Majewski
Hi Anatolij, > From: Mike Frysinger > > Merge our duplicate definitions with the common header. > Also fix drivers/usb/gadget/s3c_udc_otg_xfer_dma.c to > use min() instead of min_t() since we remove the latter > from compat.h. Yes. the include/usb/lin_gadget_compat.h layer. Good idea to provide

Re: [U-Boot] [PATCH v2 4/4] lin_gadget: use common linux/compat.h

2012-04-25 Thread Mike Frysinger
On Wednesday 25 April 2012 04:11:41 Anatolij Gustschin wrote: > From: Mike Frysinger > > Merge our duplicate definitions with the common header. > Also fix drivers/usb/gadget/s3c_udc_otg_xfer_dma.c to > use min() instead of min_t() since we remove the latter > from compat.h. > > Signed-off-by: M